[Mesa-dev] [PATCH] configure.ac: Check for expat when building just vulkan

Intel vulkan drivers also need expat: make sure EXPAT_LIBS is set even if dri is disabled. --- configure.ac | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 61d98e28e0..01a8b24736 100644 --- a/configure.ac +++ b/configu

Re: [Mesa-dev] [PATCH] amd: add .editorconfig

On 27.08.2017 23:44, Grazvydas Ignotas wrote: amd/common/ and amd/vulkan/ are using tabs for indent, which doesn't match the settings in root .editorconfig, so let's override. Signed-off-by: Grazvydas Ignotas Reviewed-by: Nicolai Hähnle --- src/amd/common/.editorconfig | 3 +++ src/amd

[Mesa-dev] [PATCH] nir/spirv: add support for chain access with different index bit sizes

Fixes dEQP-VK.spirv_assembly.instruction.*.indexing.* Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/vtn_variables.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_VARYINGS

On 27.08.2017 12:59, Karol Herbst wrote: this way Nouveau can report 128 inputs, but only 124 varyings. Fixes: 'KHR-GL45.limits.max_fragment_input_components' Can you explain a bit more why this is necessary? The GL CTS test only exercises the core profile, where it should be possible for you

Re: [Mesa-dev] [PATCH v2] st/mesa: fix handling of vertex array double inputs

On 27.08.2017 17:47, Ilia Mirkin wrote: The is_double_vertex_input needs to be set for arrays of doubles as well. Fixes KHR-GL45.enhanced_layouts.varying_array_locations Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org Makes sense. Reviewed-by: Nicolai Hähnle --- v1 ->

Re: [Mesa-dev] [PATCH] ac/nir: silence maybe-uninitialized warnings

On 27.08.2017 23:43, Grazvydas Ignotas wrote: These are likely false positives, but are also annoying because they show up on every "make install", which causes ac_nir_to_llvm to be rebuilt here. Initializing those variables to NULL should be harmless even when unnecessary. Signed-off-by: Grazvy

Re: [Mesa-dev] [PATCH] glsl: fix counting of vertex shader output slots used by explicit vars

On 27.08.2017 06:12, Ilia Mirkin wrote: The argument to count_attribute_slots should only be set to true for vertex inputs, not for all vertex shader varyings. Fixes KHR-GL45.enhanced_layouts.varying_locations Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Nico

Re: [Mesa-dev] [PATCH] radeonsi: stop leaking nir

Thanks! Reviewed-by: Nicolai Hähnle On 28.08.2017 07:02, Timothy Arceri wrote: --- src/gallium/drivers/radeonsi/si_state_shaders.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 35

Re: [Mesa-dev] [PATCH] gallium/docs: fix a typo

On 26.08.2017 10:39, Gwan-gyeong Mun wrote: Signed-off-by: Mun Gwan-gyeong R-b and pushed, thanks! --- src/gallium/docs/source/context.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/docs/source/context.rst b/src/gallium/docs/source/context.rst index 7

Re: [Mesa-dev] [PATCH] ac/nir: silence maybe-uninitialized warnings

On 28.08.2017 10:30, Nicolai Hähnle wrote: On 27.08.2017 23:43, Grazvydas Ignotas wrote: These are likely false positives, but are also annoying because they show up on every "make install", which causes ac_nir_to_llvm to be rebuilt here. Initializing those variables to NULL should be harmless e

Re: [Mesa-dev] [PATCH] configure.ac: Check for expat when building just vulkan

Hi Jussi, On 28 August 2017 at 08:07, Jussi Kukkonen wrote: > Intel vulkan drivers also need expat: make sure EXPAT_LIBS is set even > if dri is disabled. We've got a similar patch in master 6f9298dbde63049da6f530ba4f4693ba78b01448 Although in hindsight we'd want that in 17.2.x as well and maybe

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

On 28 August 2017 at 03:33, Leo Liu wrote: > On 08/27/2017 01:52 PM, Emil Velikov wrote: >> >> On 25 August 2017 at 18:17, Leo Liu wrote: >>> >>> Signed-off-by: Leo Liu >>> --- >>> src/gallium/drivers/radeon/radeon_uvd.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff -

[Mesa-dev] [PATCH v2 01/12] gallium: all drivers should accept two-dimensional constant buffer indexing

From: Nicolai Hähnle Most older drivers seem to just ignore the Dimension setting, so virtually no changes should be needed. Acked-by: Roland Scheidegger Tested-by: Dieter Nützel --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 2 +- src/gallium/docs/source/screen.rst | 11 +++ 2 f

[Mesa-dev] [PATCH v2 07/12] nine: always generate two-dimensional constant file accesses

From: Nicolai Hähnle Acked-by: Roland Scheidegger Tested-by: Dieter Nützel --- src/gallium/state_trackers/nine/nine_ff.c | 2 +- src/gallium/state_trackers/nine/nine_shader.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/gallium/state_trackers/nine/ni

[Mesa-dev] [PATCH v2 04/12] st/drawpixels: always use two-dimensional constant references

From: Nicolai Hähnle --- src/mesa/state_tracker/st_cb_drawpixels_shader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_drawpixels_shader.c b/src/mesa/state_tracker/st_cb_drawpixels_shader.c index 35a9da0643d..83dcfeab4da 100644 --- a/src/mesa/state_tracker/

[Mesa-dev] [PATCH v2 12/12] radeonsi: add an assertion that only two-dimensional constant references are used

From: Nicolai Hähnle v2: remove some redundant checks Acked-by: Roland Scheidegger (v1) Tested-by: Dieter Nützel (v1) --- src/gallium/drivers/radeonsi/si_shader.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/d

[Mesa-dev] [PATCH v2 09/12] pp: always use two-dimensional constant references

From: Nicolai Hähnle Acked-by: Roland Scheidegger Tested-by: Dieter Nützel --- src/gallium/auxiliary/postprocess/pp_mlaa.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/auxiliary/postprocess/pp_mlaa.h b/src/gallium/auxiliary/postprocess

[Mesa-dev] [PATCH v2 00/12] gallium: normalize CONST file accesses to 2D

Hi all, This series changes all CONST accesses to be two-dimensional, i.e. CONST[buf][vec_index]. Relative to v1, the changes are: - added patches 3 & 4 and fix patch 6 to fix piglit regressions - add Timothy's suggestions to patch 12 Cheers, Nicolai -- src/gallium/auxiliary/hud/hud_context.c

[Mesa-dev] [PATCH v2 06/12] st/glsl_to_tgsi: inline src_register into translate_src

From: Nicolai Hähnle src_register has no meaningful standalone use, it only makes sense when called from translate_src. v2: fix input array handling Acked-by: Roland Scheidegger (v1) Tested-by: Dieter Nützel --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 152 +++--

[Mesa-dev] [PATCH v2 10/12] gallium/tests: always use two-dimensional constant references

From: Nicolai Hähnle Acked-by: Roland Scheidegger Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_tests.c | 4 ++-- src/gallium/tests/graw/fragment-shader/frag-cb-1d.sh | 8 src/gallium/tests/graw/vertex-shader/vert-cb-1d.sh | 8 3 files changed, 1

[Mesa-dev] [PATCH v2 02/12] tgsi/ureg: always emit constants (and their decls) as 2D

From: Nicolai Hähnle Acked-by: Roland Scheidegger Tested-by: Dieter Nützel --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/tgsi_ureg.c in

[Mesa-dev] [PATCH v2 08/12] gallium/hud: always use two-dimensional constant references

From: Nicolai Hähnle Acked-by: Roland Scheidegger Tested-by: Dieter Nützel --- src/gallium/auxiliary/hud/hud_context.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 2deb48d18e

[Mesa-dev] [PATCH v2 03/12] tgsi/build: always generate two-dimensional constant file accesses

From: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_build.c | 11 + src/gallium/auxiliary/tgsi/tgsi_transform.h | 65 +++-- 2 files changed, 45 insertions(+), 31 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_build.c b/src/gallium/auxiliary/tgsi/

[Mesa-dev] [PATCH v2 11/12] gallium/radeon: always use two-dimensional constant references

From: Nicolai Hähnle Acked-by: Roland Scheidegger Tested-by: Dieter Nützel --- src/gallium/drivers/radeon/r600_query.c | 36 - 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r

[Mesa-dev] [PATCH v2 05/12] st/glsl_to_tgsi: ir_load_ubo always has a second index

From: Nicolai Hähnle Acked-by: Roland Scheidegger Tested-by: Dieter Nützel Reviewed-by: Timothy Arceri --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_g

Re: [Mesa-dev] [PATCH 1/3] st/omx: move YUV deinterlace function to common

On 28 August 2017 at 03:43, Leo Liu wrote: > > > On 08/27/2017 01:49 PM, Emil Velikov wrote: >> >> Hi Leo, >> >> On 24 August 2017 at 16:11, Leo Liu wrote: >>> >>> Signed-off-by: Leo Liu >>> --- >>> src/gallium/auxiliary/vl/vl_compositor.c | 87 >>> +--- >>> src/ga

Re: [Mesa-dev] [PATCH 2/2] radeon/uvd: add Define Restart Interval to MJPEG bitstream reconstruction

On 28 August 2017 at 04:45, Leo Liu wrote: > > > On 08/27/2017 01:53 PM, Emil Velikov wrote: >> >> On 25 August 2017 at 18:17, Leo Liu wrote: >>> >>> Signed-off-by: Leo Liu >> >> Same here - please add a couple words of commit message alongside a >> fixes (or stable) tag. > > Well this is not a

Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

On 28.08.2017 03:51, Timothy Arceri wrote: On 27/08/17 05:18, Thomas Helland wrote: Plowed through it a couple times, and it looks solid to me. After thinking through it a couple times it seems like this should be more performant than my modification of Vladislav's original implementation. Would

Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

On 28.08.2017 11:13, Nicolai Hähnle wrote: On 28.08.2017 03:51, Timothy Arceri wrote: On 27/08/17 05:18, Thomas Helland wrote: Plowed through it a couple times, and it looks solid to me. After thinking through it a couple times it seems like this should be more performant than my modification o

Re: [Mesa-dev] [PATCH] gallium/docs: Fix an inequality sign of TGSI_SEMANTIC_SUBGROUP_LT_MASK

On 23.08.2017 18:54, Gwan-gyeong Mun wrote: A previous expression presents same as TGSI_SEMANTIC_SUBGROUP_GT_MASK. It fixes a direction of an inequality for TGSI_SEMANTIC_SUBGROUP_LT_MASK. before: bit index > TGSI_SEMANTIC_SUBGROUP_INVOCATION after: bit index < TGSI_SEMANTIC_SUBGROUP_INVO

[Mesa-dev] [PATCH] radv: silent a compiler warning in radv_emit_framebuffer_state()

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index fcc14dd936..b567bee329 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/am

Re: [Mesa-dev] [PATCH 20/47] i965/fs: Define new shader opcodes to set rounding modes

On 25/08/17 20:09, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> Although it is possible to emit them directly as AND/OR on brw_fs_nir, >> having specific opcodes makes it easier to remove duplicate settings >> later. >> >> Signed-off-by: Alejandro Piñeiro >> Signed-off-by: Jose Maria

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

On 27/08/17 20:24, Connor Abbott wrote: > Hi, > > On Aug 25, 2017 9:28 AM, "Alejandro Piñeiro" > wrote: > > On 24/08/17 21:07, Connor Abbott wrote: > > > > Hi Alejandro, > > Hi Connor, > > > > > This seems really suspicious. If the live ranges a

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

This still doesn't seem to be merged. Can someone please look at it? It does have Rbs. Regards, Yogesh. > -Original Message- > From: Marathe, Yogesh > Sent: Wednesday, August 23, 2017 11:35 PM > To: mesa-dev@lists.freedesktop.org > Cc: tf...@chromium.org; emil.l.veli...@gmail.com; Gao, S

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: set EVENT_WRITE_EOP.INT_SEL = wait for write confirmation

On 25.08.2017 02:57, Marek Olšák wrote: From: Marek Olšák Ported from Vulkan. Not sure what this is good for.. maybe write confirmation from L2 flushes? I think so, yes. Reviewed-by: Nicolai Hähnle --- src/amd/common/r600d_common.h | 3 +++ src/gallium/drivers/radeon/

Re: [Mesa-dev] [PATCH 2/2] gallium/u_threaded: rename IGNORE_VALID_RANGE -> NO_INFER_UNSYNCHRONIZED

Both patches: Reviewed-by: Nicolai Hähnle On 25.08.2017 15:41, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/util/u_threaded_context.c | 4 ++-- src/gallium/auxiliary/util/u_threaded_context.h | 4 ++-- src/gallium/drivers/radeon/r600_buffer_common.c | 2 +- 3 files ch

Re: [Mesa-dev] [PATCH] configure.ac: Check for expat when building just vulkan

On 28 August 2017 at 11:47, Emil Velikov wrote: > Hi Jussi, > > On 28 August 2017 at 08:07, Jussi Kukkonen > wrote: > > Intel vulkan drivers also need expat: make sure EXPAT_LIBS is set even > > if dri is disabled. > > We've got a similar patch in master 6f9298dbde63049da6f530ba4f4693 > ba78b014

Re: [Mesa-dev] [PATCH 2/2] radeonsi: rewrite late alloc VS limit computation

On 25.08.2017 02:57, Marek Olšák wrote: From: Marek Olšák This is still very simple, but it's better than before. Loosely ported from Vulkan. --- src/gallium/drivers/radeonsi/si_state.c | 38 ++--- 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/s

Re: [Mesa-dev] [PATCH 2/2] radeon/uvd: add Define Restart Interval to MJPEG bitstream reconstruction

On 08/28/2017 05:04 AM, Emil Velikov wrote: On 28 August 2017 at 04:45, Leo Liu wrote: On 08/27/2017 01:53 PM, Emil Velikov wrote: On 25 August 2017 at 18:17, Leo Liu wrote: Signed-off-by: Leo Liu Same here - please add a couple words of commit message alongside a fixes (or stable) tag.

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

On 08/28/2017 04:53 AM, Emil Velikov wrote: On 28 August 2017 at 03:33, Leo Liu wrote: On 08/27/2017 01:52 PM, Emil Velikov wrote: On 25 August 2017 at 18:17, Leo Liu wrote: Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [Mesa-dev] [PATCH 1/3] st/omx: move YUV deinterlace function to common

On 08/28/2017 05:01 AM, Emil Velikov wrote: On 28 August 2017 at 03:43, Leo Liu wrote: On 08/27/2017 01:49 PM, Emil Velikov wrote: Hi Leo, On 24 August 2017 at 16:11, Leo Liu wrote: Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_compositor.c | 87 +

Re: [Mesa-dev] [PATCH 12/47] i965/fs: Add brw_reg_type_from_bit_size utility method

El 26/08/17 a las 19:19, Jason Ekstrand escribió: > On Thu, Aug 24, 2017 at 6:54 AM, Alejandro Piñeiro > mailto:apinhe...@igalia.com>> wrote: > > Returns the brw_type for a given ssa.bit_size, and a reference type. > So if bit_size is 64, and the reference type is BRW_REGISTER_TYPE_F, >

[Mesa-dev] [Bug 102318] Mesa3D Scons build - LLVM 5.0 not supported

https://bugs.freedesktop.org/show_bug.cgi?id=102318 Alex Granni changed: What|Removed |Added Attachment #133638|Mesa3D scons build with |Mesa3D scons build output descript

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_VARYINGS

On Mon, Aug 28, 2017 at 4:23 AM, Nicolai Hähnle wrote: > On 27.08.2017 12:59, Karol Herbst wrote: >> >> this way Nouveau can report 128 inputs, but only 124 varyings. >> >> Fixes: 'KHR-GL45.limits.max_fragment_input_components' > > > Can you explain a bit more why this is necessary? The GL CTS tes

[Mesa-dev] [ANNOUNCE] mesa 17.1.8

Mesa 17.1.8 is now available. In this release we have: In Mesa Core we include a fix to prevent a crash in glCompressedTextureSubImage3D. The GLSL compiler now includes a fix to add some int64 constant propagation cases. Intel drivers have received several patches. Among those, i965 has gotten

[Mesa-dev] [Bug 102454] glibc 2.26 doesn't provide anymore xlocale.h

https://bugs.freedesktop.org/show_bug.cgi?id=102454 Bug ID: 102454 Summary: glibc 2.26 doesn't provide anymore xlocale.h Product: Mesa Version: unspecified Hardware: All OS: Linux (All) Status: NEW Severit

Re: [Mesa-dev] [PATCH 00/10] egl: mixed bag of fixes/cleanups

Hi Emil, On 27 August 2017 at 11:20, Emil Velikov wrote: > egl: simplify refcounting after screen creation Acked-by: Daniel Stone > egl/wayland: plug leaks in dri2_wl_create_window_surface() error path > egl/wayland: polish object teardown in dri2_wl_destroy_surface Reviewed-by: Daniel

[Mesa-dev] [Bug 102454] glibc 2.26 doesn't provide anymore xlocale.h

https://bugs.freedesktop.org/show_bug.cgi?id=102454 Andreas Radke changed: What|Removed |Added CC||andy...@archlinux.org -- You are recei

Re: [Mesa-dev] [PATCH] nir/spirv: add support for chain access with different index bit sizes

On August 28, 2017 1:18:33 AM Samuel Iglesias Gonsálvez wrote: Fixes dEQP-VK.spirv_assembly.instruction.*.indexing.* Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/vtn_variables.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff -

Re: [Mesa-dev] [PATCH] i965: Set "Subslice Hashing Mode" to 16x16 on Apollolake.

Kenneth, would we want this patch in 17.1 or we shouldn't bother ? On Tue, 2017-05-30 at 16:28 -0700, Kenneth Graunke wrote: > As of 4.11, the kernel isn't bothering to set the subslice hashing mode > on Apollolake, leaving it at the default of 8x8. (It initializes it to > 16x4 on most platforms.

Re: [Mesa-dev] [PATCH 1/5] dri/image: Add a format modifier attributes query

On 16 August 2017 at 20:30, Jason Ekstrand wrote: > + /** > +* dmabuf format modifier attribute query for a given format and modifier. > +* > +* \param fourccThe format to query. If this format is not supported > by > +* the driver, return false. > +* \p

Re: [Mesa-dev] [PATCH 2/5] gbm: Add a gbm_device_get_format_modifier_plane_count function

On 16 August 2017 at 20:30, Jason Ekstrand wrote: > +/** Get the number of planes that are required for a given format+modifier > + * > + * \param gbm The gbm device returned from gbm_create_device() > + * \param format The format to query > + * \param modifier The modifier to query > + */ > +int

Re: [Mesa-dev] [PATCH 3/5] i965/screen: Make a parameter const

On 16 August 2017 at 20:30, Jason Ekstrand wrote: > This gets rid of some compiler warnings. Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 0/7] i965/fs/nir: Fix readInvocationARB and readFirstInvocationARB

This little series contains some fixes I found when working on SPIR-V subgroup operations. From my reading of GL_ARB_shader_ballot, the readInvocationARB and readFirstInvocationARB intrinsics only support 32-bit values. This seems weird to me, but whatever. The SPIR-V subgroup extensions, on the

[Mesa-dev] [PATCH 1/7] i965/fs/nir: Use the nir_src_bit_size helper

--- src/intel/compiler/brw_fs_nir.cpp | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index d760946..18c5fc6 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++ b/src/intel/compiler/brw_fs_nir.cp

[Mesa-dev] [PATCH 3/7] i965/fs/nir: Simplify 64-bit store_output

The swizzles weren't doing any good because swiz is just XYZW. Also, we were emitting an extra set of MOVs because shuffle_64bit_data_for_32bit already does a MOV for us. Finally, the temporary was only ever used inside the inner loop so there's no need for it to actually be an array. --- src/in

[Mesa-dev] [PATCH 6/7] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

--- src/intel/compiler/brw_fs_nir.cpp | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index c46998a..a882979 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++ b/src/

[Mesa-dev] [PATCH 4/7] i965/fs: Return a fs_reg from shuffle_64bit_data_for_32bit_write

All callers of this function allocate a fs_reg expressly to pass into it. It's much easier if we just let the helper allocate the register. While we're here, we switch it to doing the MOVs with an integer type so that we don't accidentally canonicalize floats on half of a double. --- src/intel/co

[Mesa-dev] [PATCH 2/7] i965/fs: Add brw_reg_type_from_bit_size utility method

From: Alejandro Piñeiro Returns the brw_type for a given ssa.bit_size, and a reference type. So if bit_size is 64, and the reference type is BRW_REGISTER_TYPE_F, it returns BRW_REGISTER_TYPE_DF. The same applies if bit_size is 32 and reference type is BRW_REGISTER_TYPE_HF it returns BRW_REGISTER_

[Mesa-dev] [PATCH 5/7] i965/fs/nir: Minor refactor of store_output

Stop retyping the output of shuffle_64bit_data_for_32bit_write. It's always BRW_REGISTER_TYPE_D which is perfectly fine for writing out. Also, when we change get_nir_src to return something with a 64-bit type for 64-bit values, the retyping will not be at all what we want. Also, retyping the outp

[Mesa-dev] [PATCH 7/7] i965/fs: Fix readInvocationARB and readFirstInvocationARB

The readInvocationARB built-in maps fairly nicely to our BROADCAST opcode. However, the current implementation isn't quite right. This commit fixes three different issues: 1) It was blindly taking component 0 of the index value even if that channel is disabled. We need emit_uniformize() to

Re: [Mesa-dev] [RFC PATCH 2/2] main/format: skip format conversion if src and dst format are equal

On Wed, Aug 16, 2017 at 11:32 AM, Karol Herbst wrote: > Fixes 'KHR-GL45.copy_image.functional' on Nouveau > > Signed-off-by: Karol Herbst > --- > src/mesa/main/format_utils.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/format_utils.c b/src/mesa/ma

Re: [Mesa-dev] Question about implementing viewport transfer and const load in nir

Kenneth Graunke writes: > [ Unknown signature status ] > On Saturday, August 26, 2017 6:40:14 AM PDT Qiang Yu wrote: >> Hi guys, >> >> When working on lima gp compiler, I come across two problems about >> inserting extra uniform >> and instructions in nir for the driver and don't know where's th

[Mesa-dev] [Bug 102454] glibc 2.26 doesn't provide anymore xlocale.h

https://bugs.freedesktop.org/show_bug.cgi?id=102454 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net -- You are receivi

Re: [Mesa-dev] [PATCH 6/7] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

Hi Jason, given that 16bit types are already on the horizon a switch(nir_src_bit_size(src)) seems more future-proof --Michael Am 28.08.2017 um 16:51 schrieb Jason Ekstrand: --- src/intel/compiler/brw_fs_nir.cpp | 38 ++ 1 file changed, 26 insertions(

[Mesa-dev] [PATCH v2 6/7] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

--- src/intel/compiler/brw_fs_nir.cpp | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index c46998a..04deaed 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++ b/src/intel

[Mesa-dev] [Bug 101709] [llvmpipe] piglit gl-1.0-scissor-offscreen regression

https://bugs.freedesktop.org/show_bug.cgi?id=101709 --- Comment #2 from Vinson Lee --- (In reply to Brian Paul from comment #1) > Vinson, this test seems to pass for me with current Mesa (fe2f5cfdc7). Can > you re-test and close this if it's OK for you? Retested with Mesa 17.3.0-devel (git-63e7

[Mesa-dev] [Bug 95338] build fails with python3 version of mako

https://bugs.freedesktop.org/show_bug.cgi?id=95338 Bug ID: 95338 Summary: build fails with python3 version of mako Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity:

Re: [Mesa-dev] [PATCH 2/2] radeonsi: rewrite late alloc VS limit computation

On Mon, Aug 28, 2017 at 12:50 PM, Nicolai Hähnle wrote: > On 25.08.2017 02:57, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This is still very simple, but it's better than before. >> >> Loosely ported from Vulkan. >> --- >> src/gallium/drivers/radeonsi/si_state.c | 38 >> +++

[Mesa-dev] [Bug 102461] [llvmpipe] piglit glean fragprog1 XPD test 1 regression

https://bugs.freedesktop.org/show_bug.cgi?id=102461 Bug ID: 102461 Summary: [llvmpipe] piglit glean fragprog1 XPD test 1 regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_VARYINGS

Please makes this a non-shader cap if the value doesn't vary between shaders. Marek On Sun, Aug 27, 2017 at 12:59 PM, Karol Herbst wrote: > this way Nouveau can report 128 inputs, but only 124 varyings. > > Fixes: 'KHR-GL45.limits.max_fragment_input_components' > Signed-off-by: Karol Herbst > -

[Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

If llvmpipe_set_scissor_states() is never called, we still need to be sure that derived scissor/clip state is updated. As of commit 743ad599a97d09b1 that function might not be called. Fixes regressed Piglit gl-1.0-scissor-offscreen -fbo -auto test. Bugzilla: https://bugs.freedesktop.org/show_bug

[Mesa-dev] [Bug 101709] [llvmpipe] piglit gl-1.0-scissor-offscreen regression

https://bugs.freedesktop.org/show_bug.cgi?id=101709 --- Comment #3 from Brian Paul --- OK, I must have had something wrong. I see the issue. Patch posted to mesa-dev for review. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.__

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/query: init result data with 0

You can also call util_query_clear_result in the driver. Marek On Sat, Aug 26, 2017 at 1:15 AM, Karol Herbst wrote: > otherwise the result might contain random data. > > fixes on nvc0: > * KHR-GL45.pipeline_statistics_query_tests_ARB.functional_default_qo_values > * > KHR-GL45.pipeline_statis

Re: [Mesa-dev] [PATCH 2/2] radeonsi: rewrite late alloc VS limit computation

On 28.08.2017 21:43, Marek Olšák wrote: On Mon, Aug 28, 2017 at 12:50 PM, Nicolai Hähnle wrote: On 25.08.2017 02:57, Marek Olšák wrote: From: Marek Olšák This is still very simple, but it's better than before. Loosely ported from Vulkan. --- src/gallium/drivers/radeonsi/si_state.c | 38

Re: [Mesa-dev] [PATCH v2 6/7] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

On Mon, Aug 28, 2017 at 11:13 AM, Jason Ekstrand wrote: > --- > src/intel/compiler/brw_fs_nir.cpp | 33 + > 1 file changed, 21 insertions(+), 12 deletions(-) > > diff --git a/src/intel/compiler/brw_fs_nir.cpp > b/src/intel/compiler/brw_fs_nir.cpp > index c46998a..

[Mesa-dev] [Bug 102463] SpaceEngine can't render main scenery properly

https://bugs.freedesktop.org/show_bug.cgi?id=102463 Bug ID: 102463 Summary: SpaceEngine can't render main scenery properly Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Se

Re: [Mesa-dev] [PATCH v3 01/12] anv/queue: Allow temporary import of SYNC_FD semaphores

This series is : Reviewed-by: Lionel Landwerlin On 25/08/17 19:54, Jason Ekstrand wrote: We didn't allow them before because it didn't look like the spec allowed it. It certainly doesn't make much sense. However, there are CTS tests that apparently hit this. What the spec actually says is:

[Mesa-dev] [PATCH 1/3] radv/amdgpu: Enable dumping of all IBs with RADV_DEBUG=allbos.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c index ad4b0b3f9dc..adb855f97de 100644 --- a/src/amd/

[Mesa-dev] [PATCH 3/3] radv: Add trace ids for secondary buffers.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 2 ++ src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_radeon_winsys.h | 2 +- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 4 ++-- 4 files changed, 6 insertions(+), 4 deleti

[Mesa-dev] [PATCH 2/3] ac/debug: Support multiple trace ids for nested IBs.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_debug.c | 54 ++- src/amd/common/ac_debug.h | 8 ++-- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 4 +- src/gallium/drivers/radeonsi/si_debug.c | 19 +- 4 fil

[Mesa-dev] [PATCH] st/mesa: fix XPD lowering - don't read dst

From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102461 --- src/mesa/state_tracker/st_mesa_to_tgsi.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c b/src/mesa/state_tracker/st_mesa_to_tgsi.c index 916

Re: [Mesa-dev] [PATCH] st/mesa: fix XPD lowering - don't read dst

Reviewed-by: Brian Paul On 08/28/2017 03:30 PM, Marek Olšák wrote: From: Marek Olšák Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D102461&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA&m=3xi9WRUmX1

Re: [Mesa-dev] [PATCH 7/7] i965/fs: Fix readInvocationARB and readFirstInvocationARB

On Mon, Aug 28, 2017 at 7:51 AM, Jason Ekstrand wrote: > The readInvocationARB built-in maps fairly nicely to our BROADCAST > opcode. However, the current implementation isn't quite right. This > commit fixes three different issues: > > 1) It was blindly taking component 0 of the index value ev

[Mesa-dev] [PATCH 03/19] compiler: Add $(WNO_OVERRIDE_INIT) to AM_CFLAGS

nir_intrinsics.h does this a lot, causing lots of warnings from clang. --- src/compiler/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/Makefile.am b/src/compiler/Makefile.am index 001ff81aeb..45b9cc5854 100644 --- a/src/compiler/Makefile.am +++ b/src/compiler/Makefile

[Mesa-dev] [PATCH 05/19] nir: Remove series of unnecessary conversions

Clang warns: warning: absolute value function 'fabsf' given an argument of type 'const float64_t' (aka 'const double') but has parameter of type 'float' which may cause truncation of value [-Wabsolute-value] float64_t dst = bit_size == 64 ? fabs(src0) : fabsf(src0); The type of the t

[Mesa-dev] [PATCH 09/19] i965: Mark functions used conditionally as UNUSED

The functions we're marking as UNUSED in genX_state_upload.c are used only when compiling for particular generations. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 4 ++-- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 01/19] configure: Add and use AX_CHECK_COMPILE_FLAG

This makes it a lot clearer what's happening (at least I think so), and will make future additions much simpler. --- configure.ac| 94 - m4/ax_check_compile_flag.m4 | 74 +++ 2 files changed, 99 insertions(

[Mesa-dev] [PATCH 04/19] nir/spirv: Use unreachable("...") rather than assert(!"...")

Quiets a number of uninitialized variable warnings in clang. Reviewed-by: Jordan Justen --- src/compiler/spirv/spirv_to_nir.c | 18 +- src/compiler/spirv/vtn_variables.c | 8 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/compiler/spirv/spirv_to_n

[Mesa-dev] [PATCH 02/19] configure: Test for -Wno-initializer-overrides

Clang has "-Wno-initializer-overrides", while gcc has "-Wno-override-init". Quiets a lot of warnings with clang. --- configure.ac | 4 src/intel/Makefile.am | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 84b0805401..218c03dad5

[Mesa-dev] [PATCH 06/19] i965: Remove some 'inline' keywords

brw_texture_view_sane() is only used by an assert()... No difference in the resulting binary with gcc-6.3.0 or clang-4.0. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/genX_state_uploa

[Mesa-dev] [PATCH 17/19] intel/isl: Mark functions used conditionally as UNUSED

The functions we're marking as UNUSED in isl_surface_state.c are used only when compiling for particular generations. --- src/intel/isl/isl_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c ind

[Mesa-dev] [PATCH 16/19] intel/isl: Explicitly cast between different enums

Fixes warnings like warning: implicit conversion from enumeration type 'enum isl_format' to different enumeration type 'enum GEN10_SURFACE_FORMAT' [-Wenum-conversion] .SourceElementFormat = ISL_FORMAT_R32_UINT, ^~~ --- src/intel/isl/isl_sur

[Mesa-dev] [PATCH 10/19] i965: Add $(WNO_OVERRIDE_INIT) to AM_CFLAGS

brw_surface_formats.c and genX_blorp_exec.c do this a lot, causing lots of warnings from clang. --- src/mesa/drivers/dri/i965/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am index f884a530eb..eccca643c3

[Mesa-dev] [PATCH 15/19] intel/isl: Remove 'inline' keywords

Unless you have data, the compiler knows better than you whether a function should be inlined. Unlike all other cases in this series, the removal of the inline keyword from isl_format_has_channel_type actually changes the resulting binary with gcc-6.3.0: textdata bss dec hex fi

[Mesa-dev] [PATCH 13/19] anv: Explicitly cast between different enums

Fixes warnings like warning: implicit conversion from enumeration type 'enum isl_format' to different enumeration type 'enum GEN10_SURFACE_FORMAT' [-Wenum-conversion] .SourceElementFormat = ISL_FORMAT_R32_UINT, ^~~ --- src/intel/vulkan/genX

[Mesa-dev] [PATCH 11/19] anv: Use GNU C empty brace initializer

Avoids Clang's warning about the current code: warning: suggest braces around initialization of subobject --- src/intel/vulkan/anv_formats.c | 2 +- src/intel/vulkan/anv_pipeline.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/intel/vulkan/an

[Mesa-dev] [PATCH 12/19] anv: Remove 'inline' keywords

Unless you have data, the compiler knows better than you whether a function should be inlined. No difference in the resulting binary with gcc-6.3.0 or clang-4.0. --- src/intel/vulkan/anv_batch_chain.c | 4 ++-- src/intel/vulkan/anv_blorp.c | 2 +- src/intel/vulkan/gen7_cmd_buffer.c | 2 +

[Mesa-dev] [PATCH 07/19] i965: Drop unnecessary conditional

Clang doesn't realize that 0 and 1 are the only possibilities, a thinks lots of variables might be uninitialized. --- src/intel/compiler/brw_eu_validate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_v

[Mesa-dev] [PATCH 19/19] glsl: define YY_NO_INPUT to prevent unused symbol warnings

Otherwise clang warns: glsl/glsl_lexer.cpp:3507:16: warning: function 'yyinput' is not needed and will not be emitted [-Wunneeded-internal-declaration] static int yyinput (yyscan_t yyscanner) ^ --- src/compiler/glsl/glsl_lexer.ll | 1 + 1 file changed, 1 insertion(+) diff --gi

  1   2   >