Re: [Mesa-dev] [PATCH v4] glsl: update the extensions that are enabled for 460

On 08/03/2017 07:36 PM, Ilia Mirkin wrote: On Thu, Aug 3, 2017 at 5:24 AM, Samuel Pitoiset wrote: Other ones are either unsupported or don't have any helper function checks. v4: - drop ARB suffix for shader_group_vote/arb_shader_atomic_counter_ops v3: - always add gl_BaseVertex & co when 460

[Mesa-dev] [PATCH 2/3] glsl: clone builtin function constants

f81ede469910d fixed a problem with shaders including IR that was owned by builtins. However the approach of cloning the whole function each time we referenced it lead to a significant reduction in the GLSL IR compiler performance. Everything was already cloned when inlining the function, as far as

[Mesa-dev] [PATCH 3/3] glsl: stop cloning builtin fuctions _mesa_glsl_find_builtin_function()

The cloning was introduced in f81ede469910d to fixed a problem with shaders including IR that was owned by builtins. However the approach of cloning the whole function each time we reference a builtin lead to a significant reduction in the GLSL IR compilers performance. The previous patch fixes t

[Mesa-dev] [PATCH 1/3] glsl: remove unused field from ir_call

--- src/compiler/glsl/ir.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h index 40f3338470..d425b97aca 100644 --- a/src/compiler/glsl/ir.h +++ b/src/compiler/glsl/ir.h @@ -1595,32 +1595,30 @@ public: */ class ir_call : public ir_instructi

Re: [Mesa-dev] [PATCH] radv: avoid GPU hangs if someone does a resolve with non-multisample src (v2)

Reviewed-by: Bas Nieuwenhuizen On Fri, Aug 4, 2017 at 4:51 AM, Dave Airlie wrote: > From: Dave Airlie > > This is a bug in the app, but I'd rather avoid hanging the GPU, > esp if someone is running in validation and it takes out their > development environment. > > v2: get it right, reverse the

Re: [Mesa-dev] LLVM build issue on r299777

On Thu, 2017-08-03 at 21:19 +0200, Marek Olšák wrote: > On Thu, Aug 3, 2017 at 7:54 PM, Juan A. Suarez Romero > wrote: > > On Fri, 2017-04-28 at 14:15 +0200, Nicolai Hähnle wrote: > > > On 28.04.2017 13:08, Eric Engestrom wrote: > > > > Hi, > > > > > > > > I'm currently running llvm r299777 but I

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Fix decompression on multisampled depth buffers

On 3 August 2017 at 23:44, Bas Nieuwenhuizen wrote: > On Fri, Aug 4, 2017 at 12:26 AM, Marek Olšák wrote: > > Hi Alex, > > > > Which game uses texturing from MSAA depth buffers? > > They don't necessarily have to do that, radv could also be doing some > superfluous layout transitions that might

Re: [Mesa-dev] [PATCH v2 6/6] radeonsi: try to re-use previously deleted bindless descriptor slots

On 08/01/2017 09:54 PM, Marek Olšák wrote: Hi Samuel, Can you move this slot allocator into a util module? It seems generic enough that it could be reused for "handle" and "ID" allocations. Some additional notes: - a bit array of uin32_t would be better. bool is too large (1 byte). - "free" i

Re: [Mesa-dev] [PATCH] anv/formats: Allow sampling on depth-only formats on gen7

On Thu, 2017-08-03 at 20:00 -0700, Jason Ekstrand wrote: > We can't sample from depth-stencil formats but on gen7 but we can > sample > from depth-only formats. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102024 > --- Reviewed-by: Juan A. Suarez Romero > src/intel/vulkan/anv_fo

Re: [Mesa-dev] [PATCH] gallium/clover: Remove libxmlconfig.la from targets/clover/Makefile.am

On 04.08.2017 06:24, Aaron Watry wrote: Gets rid of a bunch of errors like the following: make[4]: Entering directory '/home/me/src/mesa/build/src/gallium/targets/opencl' CXXLDlibOpenCL.la ../../../../src/util/.libs/libxmlconfig.a(libxmlconfig_la-xmlconfig.o): In function `driParseOption

Re: [Mesa-dev] [PATCH v2 6/6] radeonsi: try to re-use previously deleted bindless descriptor slots

On Fri, Aug 4, 2017 at 10:06 AM, Samuel Pitoiset wrote: > > > On 08/01/2017 09:54 PM, Marek Olšák wrote: >> >> Hi Samuel, >> >> Can you move this slot allocator into a util module? It seems generic >> enough that it could be reused for "handle" and "ID" allocations. >> >> Some additional notes: >>

Re: [Mesa-dev] [PATCH 02/23] mesa: add support for memory object creation/import/delete

On 08/04/2017 03:54 AM, Timothy Arceri wrote: From: Andres Rodriguez Used by EXT_external_objects and EXT_external_objects_fd V2 (Timothy Arceri): - Throw GL_OUT_OF_MEMORY error if CreateMemoryObjectsEXT() fails. - C99 tidy ups - remove void cast (Constantine Kharlamov) V3 (Timoth

Re: [Mesa-dev] [PATCH 04/23] gallium: introduce memory object

On 08/04/2017 03:54 AM, Timothy Arceri wrote: From: Dave Airlie v2: fix comment regarding fd ownership, define pipe_memory_object v3: remove stray return v4 (Timothy Arceri): update trace v5 (Timothy Arceri): actually dump the params in trace Reviewed-by: Marek Olšák (v3) --- src/gallium/

Re: [Mesa-dev] [PATCH v2 2/9] anv: Submit a dummy batch when only semaphores are provided.

Quoting Jason Ekstrand (2017-08-04 02:25:21) > Vulkan allows you to do a submit whose only job is to wait on and > trigger semaphores. The easiest way for us to support that right > now is to insert a dummy execbuf. > --- > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c

Re: [Mesa-dev] [PATCH 06/23] mesa: hook up memoryobject tex(ture)storage api

On 08/04/2017 03:54 AM, Timothy Arceri wrote: From: Andres Rodriguez V2 (Timothy Arceri): - formating fixes V3 (Timothy): - error check memory == 0 before lookup Signed-off-by: Andres Rodriguez Reviewed-by: Samuel Pitoiset (v2) --- src/mesa/main/dd.h | 10 src/me

Re: [Mesa-dev] [PATCH 07/23] mesa: hook up memory object multisamples tex(ture)storage api

Reviewed-by: Samuel Pitoiset On 08/04/2017 03:54 AM, Timothy Arceri wrote: From: Andres Rodriguez V2 (Timothy): - error check memory == 0 before lookup Signed-off-by: Andres Rodriguez Reviewed-by: Samuel Pitoiset (v1) --- src/mesa/main/externalobjects.c | 46 +

Re: [Mesa-dev] [PATCH 13/23] mesa: hook up (Named)BufferStorageMem api

On 08/04/2017 03:54 AM, Timothy Arceri wrote: Include no_error variants as well. v2 (Timothy Arceri): - reduced code churn by squashing some changes into previous commits v3 (Timothy Arceri): - drop unused function declaration v4 (Timothy Arceri): - fix Driver function assert() -

Re: [Mesa-dev] [PATCH 16/23] gallium: introduce device/driver UUID queries

Reviewed-by: Samuel Pitoiset On 08/04/2017 03:54 AM, Timothy Arceri wrote: From: Andres Rodriguez v2: remove unnecessary returns v3 (Timothy Arceri): updated trace v4 (Timothy Arceri): actually dump the params in trace Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák (v2) --- src

Re: [Mesa-dev] [PATCH v2 6/6] radeonsi: try to re-use previously deleted bindless descriptor slots

On 08/04/2017 10:33 AM, Marek Olšák wrote: On Fri, Aug 4, 2017 at 10:06 AM, Samuel Pitoiset wrote: On 08/01/2017 09:54 PM, Marek Olšák wrote: Hi Samuel, Can you move this slot allocator into a util module? It seems generic enough that it could be reused for "handle" and "ID" allocations.

Re: [Mesa-dev] [PATCH] radv: avoid GPU hangs if someone does a resolve with non-multisample src (v2)

On 04.08.2017 04:51, Dave Airlie wrote: From: Dave Airlie This is a bug in the app, but I'd rather avoid hanging the GPU, esp if someone is running in validation and it takes out their development environment. v2: get it right, reverse the polarity. Signed-off-by: Dave Airlie --- src/amd/v

Re: [Mesa-dev] [PATCH] i965: Avoids loop for buffer object availability in add_exec_bo

Hi Chris, > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Tuesday, August 1, 2017 2:35 PM > To: Marathe, Yogesh ; mesa- > d...@lists.freedesktop.org > Cc: Muthukumar, Aravindan > Subject: RE: [Mesa-dev] [PATCH] i965: Avoids loop for buffer object > ava

Re: [Mesa-dev] [PATCH v2 7/9] anv/allocator: Add a syncobj cache

Quoting Jason Ekstrand (2017-08-04 02:25:26) > This is mostly a copy+paste of the BO cache but it's a bit simpler > because syncobjs don't have actual backing storage so we don't need to > check sizes or anything like that. Also, we put the refcount directly > in anv_syncobj because they will alwa

Re: [Mesa-dev] [PATCH v2 8/9] anv: Use DRM sync objects for external semaphores when available

Quoting Jason Ekstrand (2017-08-04 02:25:27) > @@ -1497,6 +1569,12 @@ anv_cmd_buffer_execbuf(struct anv_device *device, >setup_empty_execbuf(&execbuf, device); > } > > + if (execbuf.fence_count > 0) { For sanity, since I just had to check, assert(device->has_syncobj); > + exe

Re: [Mesa-dev] [PATCH v4] glsl: update the extensions that are enabled for 460

On 03.08.2017 11:24, Samuel Pitoiset wrote: Other ones are either unsupported or don't have any helper function checks. v4: - drop ARB suffix for shader_group_vote/arb_shader_atomic_counter_ops v3: - always add gl_BaseVertex & co when 460 is enabled v2: - fix ARB_shader_draw_parameters system va

Re: [Mesa-dev] [PATCH] i965: Avoids loop for buffer object availability in add_exec_bo

Quoting Muthukumar, Aravindan (2017-08-04 09:53:57) > > The tip of https://cgit.freedesktop.org/~ickle/mesa/log/?h=qbo > > i.e. > > https://cgit.freedesktop.org/~ickle/mesa/commit/?h=qbo&id=b40fa6633bdac9 > > 4cef2fd5f56360dfdb5eeb3738 > > I tested the patch series with mesa demos which seems func

Re: [Mesa-dev] [PATCH] gallium/clover: Remove libxmlconfig.la from targets/clover/Makefile.am

On 04.08.2017 10:27, Nicolai Hähnle wrote: On 04.08.2017 06:24, Aaron Watry wrote: Gets rid of a bunch of errors like the following: make[4]: Entering directory '/home/me/src/mesa/build/src/gallium/targets/opencl' CXXLDlibOpenCL.la ../../../../src/util/.libs/libxmlconfig.a(libxmlconfig

Re: [Mesa-dev] [PATCH 06/23] mesa: hook up memoryobject tex(ture)storage api

On 04/08/17 18:45, Samuel Pitoiset wrote: On 08/04/2017 03:54 AM, Timothy Arceri wrote: From: Andres Rodriguez V2 (Timothy Arceri): - formating fixes V3 (Timothy): - error check memory == 0 before lookup Signed-off-by: Andres Rodriguez Reviewed-by: Samuel Pitoiset (v2) --- src/me

Re: [Mesa-dev] [PATCH 13/23] mesa: hook up (Named)BufferStorageMem api

On 04/08/17 18:49, Samuel Pitoiset wrote: On 08/04/2017 03:54 AM, Timothy Arceri wrote: Include no_error variants as well. v2 (Timothy Arceri): - reduced code churn by squashing some changes into previous commits v3 (Timothy Arceri): - drop unused function declaration v4 (Timothy Ar

Re: [Mesa-dev] [PATCH 06/23] mesa: hook up memoryobject tex(ture)storage api

On 08/04/2017 11:10 AM, Timothy Arceri wrote: On 04/08/17 18:45, Samuel Pitoiset wrote: On 08/04/2017 03:54 AM, Timothy Arceri wrote: From: Andres Rodriguez V2 (Timothy Arceri): - formating fixes V3 (Timothy): - error check memory == 0 before lookup Signed-off-by: Andres Rodriguez

[Mesa-dev] [PATCH] loader: always include libxmlconfig on autotools build

From: Nicolai Hähnle This aligns with the fact that we also check for EXPAT_LIBS unconditionally in configure.ac now. It should make all the various build permutations of Clover work (whether DRI is enabled or disabled in the build). Cc: Aaron Watry Cc: Emil Velikov -- This change keeps everyt

Re: [Mesa-dev] [PATCH 10/12] egl/drm: remove unreachable code in dri2_drm_create_surface()

On Thursday, 2017-08-03 19:29:36 +0100, Emil Velikov wrote: > From: Emil Velikov > > The function can be called only when the type is EGL_WINDOW_BIT. > Remove the unneeded switch statement. I take it we plan on never supporting pbuffers or pixmaps in platform_drm? If so, I'd rather fold dri2_dr

[Mesa-dev] [PATCH 2/7] radeonsi: remove a tautology sctx->framebuffer.nr_samples >= 1

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index c9bb108..11dee49 100644 --- a/src/gallium/drivers/radeonsi/si_state.c +++ b

[Mesa-dev] [PATCH 6/7] radeonsi: use optimal packet order when doing a pipeline sync

From: Marek Olšák Process new SET packets in parallel with previous draw calls. This decreases [CP busy / SPI busy] by a very tiny amount (verified with GRBM perf counters), and probably increases FPS by a very tiny amount for apps that do pipeline syncs often. --- src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH 3/7] radeonsi: align all CE dumps to L2 cache line size

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 02f921e..ea5b89e 100644 --- a/sr

[Mesa-dev] [PATCH 4/7] radeonsi: de-atomize L2 prefetch

From: Marek Olšák I'd like to be able to move the prefetch call site around. --- src/gallium/drivers/radeonsi/si_cp_dma.c| 7 +++ src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- src/gallium/drivers/radeonsi/si_hw_context.c| 2 +- src/gallium/drivers/radeonsi/si_pipe.h

[Mesa-dev] [PATCH 1/7] gallium/radeon: print all members of radeon_info with R600_DEBUG=info

From: Marek Olšák also set max_alignment on amdgpu. --- src/gallium/drivers/radeon/r600_pipe_common.c | 16 ++-- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 +- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src

[Mesa-dev] [PATCH 7/7] radeonsi: rename shader_userdata -> shader_pointers where appropriate

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 2 +- src/gallium/drivers/radeonsi/si_descriptors.c | 24 src/gallium/drivers/radeonsi/si_pipe.h| 2 +- src/gallium/drivers/radeonsi/si_state.h | 6 +++--- src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 5/7] radeonsi: move flush+prefetch invocation and state emission into separate funcs

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 97 1 file changed, 57 insertions(+), 40 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 3f933fe..ae48115 100644 --- a/s

Re: [Mesa-dev] [EGL android: accquire fence implementation 1/2] i965: Return the last fence if the batch buffer is empty and nothing to be flushed when _intel_batchbuffer_flush_fence.

Hi Emil, > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Emil Velikov > Sent: Tuesday, July 25, 2017 8:19 PM > To: Wu, Zhongmin > Cc: Gao, Shuo ; Antognolli, Rafael > ; Timothy Arceri ; > Marathe, Yogesh ; Tomasz Figa > ; Kenneth Graunk

Re: [Mesa-dev] [PATCH 06/12] egl: add dri2_setup_swap_interval helper

On Thursday, 2017-08-03 19:29:32 +0100, Emil Velikov wrote: > From: Emil Velikov > > The current two implementations - X11 and Wayland were identical, > barrind the upper limit. > > Instead of having same code twice - introduce a helper and pass the > limit as an argument. > > Thus as Android/D

Re: [Mesa-dev] [EGL android: accquire fence implementation 1/2] i965: Return the last fence if the batch buffer is empty and nothing to be flushed when _intel_batchbuffer_flush_fence.

Hi Yogesh, On Fri, Aug 4, 2017 at 7:12 PM, Marathe, Yogesh wrote: > Hi Emil, > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf >> Of Emil Velikov >> Sent: Tuesday, July 25, 2017 8:19 PM >> To: Wu, Zhongmin >> Cc: Gao, Shuo ; Antognolli, R

Re: [Mesa-dev] [PATCH] gallium/clover: Remove libxmlconfig.la from targets/clover/Makefile.am

Am 04.08.2017 11:08, schrieb Nicolai Hähnle: On 04.08.2017 10:27, Nicolai Hähnle wrote: On 04.08.2017 06:24, Aaron Watry wrote: Gets rid of a bunch of errors like the following: make[4]: Entering directory '/home/me/src/mesa/build/src/gallium/targets/opencl' CXXLDlibOpenCL.la ../../..

Re: [Mesa-dev] [PATCH 08/12] egl: handle BAD_NATIVE_WINDOW/PIXMAP further up the stack

On Thursday, 2017-08-03 19:29:34 +0100, Emil Velikov wrote: > From: Emil Velikov > > The basic (null) check is identical across all backends. > Just move it to the top. > > Note that eglCreateWindowSurface* already has a guard in the *Common > helper. Read the code, checked that, was going to c

Re: [Mesa-dev] [PATCH] loader/dri3: Use dri3_find_back in loader_dri3_swap_buffers_msc

On 08/04/2017 04:47 AM, Michel Dänzer wrote: On 03/08/17 11:25 PM, Thomas Hellstrom wrote: Hi, Michel. Thanks for doing this. No worries, thank you for coming up with the fix in the first place. :) Was there a follow-up st/mesa fix to this. I remember someone posting about a problem about t

Re: [Mesa-dev] [PATCH 1/3] glsl: remove unused field from ir_call

This patch is: Reviewed-by: Thomas Helland 2017-08-04 7:25 GMT+00:00 Timothy Arceri : > --- > src/compiler/glsl/ir.h | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h > index 40f3338470..d425b97aca 100644 > --- a/src/compiler/glsl/ir.h

Re: [Mesa-dev] [PATCH 3/3] glsl: stop cloning builtin fuctions _mesa_glsl_find_builtin_function()

2017-08-04 7:25 GMT+00:00 Timothy Arceri : > The cloning was introduced in f81ede469910d to fixed a problem with > shaders including IR that was owned by builtins. > > However the approach of cloning the whole function each time we > reference a builtin lead to a significant reduction in the GLSL >

Re: [Mesa-dev] [PATCH v2 6/6] radeonsi: try to re-use previously deleted bindless descriptor slots

On Fri, Aug 4, 2017 at 10:52 AM, Samuel Pitoiset wrote: > > > On 08/04/2017 10:33 AM, Marek Olšák wrote: >> >> On Fri, Aug 4, 2017 at 10:06 AM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 08/01/2017 09:54 PM, Marek Olšák wrote: Hi Samuel, Can you move this slot allocator

Re: [Mesa-dev] GALLIUM_HUD issue with Android

afaict this is more or less the case w/ android.. top/bottom bar, search bar, wallpaper, etc, are all pushed to surface-flinger as separate "windows".. Try "adb shell dumpsys SurfaceFlinger" with an android device. (I'm not 100% sure if you need root to do that.) And with android forking everyth

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

On 3 August 2017 at 17:55, Marathe, Yogesh wrote: > Adding folks who were CCed for earlier versions. > > Hi Emil, few doubts and comments below. > >> -Original Message- >> From: Tomasz Figa [mailto:tf...@chromium.org] >> Sent: Thursday, August 3, 2017 7:19 PM >> To: Marathe, Yogesh >> Cc:

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

On 4 August 2017 at 04:21, Marathe, Yogesh wrote: >> > The check looks like below now, this is in dri2_surf_update_fence_fd() >> > before >> create_fence_fd is called. >> > >> > if (dri2_surf->enable_out_fence && dri2_dpy->fence) { >> >if(__DRI_FENCE_CAP_NATIVE_FD | >> > dri2_dpy->fence-

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

On Fri, Aug 4, 2017 at 12:21 PM, Marathe, Yogesh wrote: >> >> >> - version check (2+) the fence extension, calling >> >> >> .create_fence_fd() only when >> >> >> .get_capabilities() advertises __DRI_FENCE_CAP_NATIVE_FD >> > >> > The check looks like below now, this is in dri2_surf_update_fence_fd

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

On Fri, Aug 4, 2017 at 9:55 PM, Emil Velikov wrote: >>> >> - version check (2+) the fence extension, calling .create_fence_fd() >>> >> only when >>> >> .get_capabilities() advertises __DRI_FENCE_CAP_NATIVE_FD >> >> The check looks like below now, this is in dri2_surf_update_fence_fd() >> before

Re: [Mesa-dev] [PATCH 1/3] android: radeonsi: add nir include paths

2017-08-03 20:50 GMT+02:00 Rob Herring : > On Thu, Aug 3, 2017 at 11:12 AM, Mauro Rossi wrote: >> 2017-08-03 16:52 GMT+02:00 Emil Velikov : >>> On 3 August 2017 at 13:24, Mauro Rossi wrote: 2017-08-03 11:57 GMT+02:00 Emil Velikov : > Hi Mauro, > > Thanks for the series. I'll pull

Re: [Mesa-dev] [PATCH 08/12] egl: handle BAD_NATIVE_WINDOW/PIXMAP further up the stack

On 4 August 2017 at 11:38, Eric Engestrom wrote: > On Thursday, 2017-08-03 19:29:34 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> The basic (null) check is identical across all backends. >> Just move it to the top. >> >> Note that eglCreateWindowSurface* already has a guard in the *Commo

Re: [Mesa-dev] [PATCH] gallium/clover: Remove libxmlconfig.la from targets/clover/Makefile.am

On 4 August 2017 at 11:36, Dieter Nützel wrote: > Am 04.08.2017 11:08, schrieb Nicolai Hähnle: >> >> On 04.08.2017 10:27, Nicolai Hähnle wrote: >>> >>> On 04.08.2017 06:24, Aaron Watry wrote: Gets rid of a bunch of errors like the following: make[4]: Entering directory '/h

Re: [Mesa-dev] [PATCH] gallium/clover: Remove libxmlconfig.la from targets/clover/Makefile.am

Am 04.08.2017 16:02, schrieb Emil Velikov: On 4 August 2017 at 11:36, Dieter Nützel wrote: Am 04.08.2017 11:08, schrieb Nicolai Hähnle: On 04.08.2017 10:27, Nicolai Hähnle wrote: On 04.08.2017 06:24, Aaron Watry wrote: Gets rid of a bunch of errors like the following: make[4]: Entering d

Re: [Mesa-dev] [PATCH v4] glsl: update the extensions that are enabled for 460

On Aug 4, 2017 02:02, "Samuel Pitoiset" wrote: On 08/03/2017 07:36 PM, Ilia Mirkin wrote: > On Thu, Aug 3, 2017 at 5:24 AM, Samuel Pitoiset > wrote: > >> Other ones are either unsupported or don't have any helper >> function checks. >> >> v4: - drop ARB suffix for shader_group_vote/arb_shader

Re: [Mesa-dev] [PATCH] gallium/clover: Remove libxmlconfig.la from targets/clover/Makefile.am

On Fri, 2017-08-04 at 15:02 +0100, Emil Velikov wrote: > On 4 August 2017 at 11:36, Dieter Nützel wrote: > > Am 04.08.2017 11:08, schrieb Nicolai Hähnle: > > > > > > On 04.08.2017 10:27, Nicolai Hähnle wrote: > > > > > > > > On 04.08.2017 06:24, Aaron Watry wrote: > > > > > > > > > > Gets rid o

Re: [Mesa-dev] [PATCH 6/7] radeonsi: use optimal packet order when doing a pipeline sync

There is an ugly bug here: prefetches are skipped, because emit_all_states clears all dirty bits. Expect v2... Marek On Fri, Aug 4, 2017 at 12:05 PM, Marek Olšák wrote: > From: Marek Olšák > > Process new SET packets in parallel with previous draw calls. > > This decreases [CP busy / SPI busy]

Re: [Mesa-dev] [PATCH] gallium/clover: Remove libxmlconfig.la from targets/clover/Makefile.am

Am 04.08.2017 16:29, schrieb Jan Vesely: On Fri, 2017-08-04 at 15:02 +0100, Emil Velikov wrote: On 4 August 2017 at 11:36, Dieter Nützel wrote: > Am 04.08.2017 11:08, schrieb Nicolai Hähnle: > > > > On 04.08.2017 10:27, Nicolai Hähnle wrote: > > > > > > On 04.08.2017 06:24, Aaron Watry wrote: >

Re: [Mesa-dev] [PATCH v4] glsl: update the extensions that are enabled for 460

On 08/04/2017 04:27 PM, Ilia Mirkin wrote: On Aug 4, 2017 02:02, "Samuel Pitoiset" > wrote: On 08/03/2017 07:36 PM, Ilia Mirkin wrote: On Thu, Aug 3, 2017 at 5:24 AM, Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote:

[Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

Look up BOs from the name table using the name parameter instead of req.handle (which at this point is always zero). Signed-off-by: Philipp Zabel --- etnaviv/etnaviv_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etnaviv/etnaviv_bo.c b/etnaviv/etnaviv_bo.c index 4ad0434

[Mesa-dev] [PATCH 2/2] etnaviv: add etna_bo_from_handle

Although etnaviv_drmif.h declared etna_bo_from_handle from the start, there was no implementation. Signed-off-by: Philipp Zabel --- etnaviv/etnaviv_bo.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/etnaviv/etnaviv_bo.c b/etnaviv/etnaviv_bo.c index 4fe877f..7566957 100

[Mesa-dev] [PATCH] egl: deduplicate allocations of local buffer over each platform backend (v2)

platform_drm, platform_wayland and platform_android have similiar local buffer allocation routines. For deduplicating, it unifies dri2_egl_surface's local buffer allocation routines. And it polishes inconsistent indentations. Note that as dri2_wl_get_buffers_with_format() have not make a __DRI_BU

Re: [Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

On Friday, 2017-08-04 17:07:54 +0200, Philipp Zabel wrote: > Look up BOs from the name table using the name parameter instead of > req.handle (which at this point is always zero). > > Signed-off-by: Philipp Zabel Reviewed-by: Eric Engestrom > --- > etnaviv/etnaviv_bo.c | 2 +- > 1 file change

Re: [Mesa-dev] [PATCH] gallium/clover: Remove libxmlconfig.la from targets/clover/Makefile.am

On Fri, Aug 4, 2017 at 4:08 AM, Nicolai Hähnle wrote: > On 04.08.2017 10:27, Nicolai Hähnle wrote: >> >> On 04.08.2017 06:24, Aaron Watry wrote: >>> >>> Gets rid of a bunch of errors like the following: >>> >>> make[4]: Entering directory >>> '/home/me/src/mesa/build/src/gallium/targets/opencl' >>

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

https://bugs.freedesktop.org/show_bug.cgi?id=102038 Bug ID: 102038 Summary: assertion failure in update_framebuffer_size Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] egl: deduplicate allocations of local buffer over each platform backend (v2)

On Saturday, 2017-08-05 00:16:11 +0900, Gwan-gyeong Mun wrote: > platform_drm, platform_wayland and platform_android have similiar local buffer > allocation routines. For deduplicating, it unifies dri2_egl_surface's > local buffer allocation routines. And it polishes inconsistent indentations. > >

Re: [Mesa-dev] [PATCH v4] glsl: update the extensions that are enabled for 460

On Fri, Aug 4, 2017 at 10:49 AM, Samuel Pitoiset wrote: > > > On 08/04/2017 04:27 PM, Ilia Mirkin wrote: >> >> >> >> On Aug 4, 2017 02:02, "Samuel Pitoiset" > > wrote: >> >> >> >> On 08/03/2017 07:36 PM, Ilia Mirkin wrote: >> >> On Thu, Aug 3, 2017 at

Re: [Mesa-dev] [EGL android: accquire fence implementation 1/2] i965: Return the last fence if the batch buffer is empty and nothing to be flushed when _intel_batchbuffer_flush_fence.

Tomasz, > -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Friday, August 4, 2017 3:48 PM > To: Marathe, Yogesh > Cc: Emil Velikov ; Wu, Zhongmin > ; Gao, Shuo ; Antognolli, > Rafael ; Timothy Arceri > ; Kenneth Graunke ; > Kondapally, Kalyan ; ML mesa-dev d...@

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

Tomasz, Emil, > -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Friday, August 4, 2017 6:54 PM > To: Emil Velikov > Cc: Marathe, Yogesh ; Antognolli, Rafael > ; ML mesa-dev d...@lists.freedesktop.org>; Wu, Zhongmin ; Gao, > Shuo ; Liu, Zhiquan ; Daniel > Stone

Re: [Mesa-dev] [PATCH] loader: always include libxmlconfig on autotools build

On Fri, 2017-08-04 at 11:53 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This aligns with the fact that we also check for EXPAT_LIBS > unconditionally in configure.ac now. It should make all the > various build permutations of Clover work (whether DRI is > enabled or disabled in the bu

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

On Sat, Aug 5, 2017 at 12:53 AM, Marathe, Yogesh wrote: > Tomasz, Emil, > >> -Original Message- >> From: Tomasz Figa [mailto:tf...@chromium.org] >> Sent: Friday, August 4, 2017 6:54 PM >> To: Emil Velikov >> Cc: Marathe, Yogesh ; Antognolli, Rafael >> ; ML mesa-dev > d...@lists.freedeskto

Re: [Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

On Fri, Aug 04, 2017 at 05:07:54PM +0200, Philipp Zabel wrote: > Look up BOs from the name table using the name parameter instead of > req.handle (which at this point is always zero). Good catch. Just out of interest: when is this used, what problems does this cause? Regards, Wladimir __

Re: [Mesa-dev] [PATCH v2 2/9] anv: Submit a dummy batch when only semaphores are provided.

On Fri, Aug 4, 2017 at 1:43 AM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-08-04 02:25:21) > > Vulkan allows you to do a submit whose only job is to wait on and > > trigger semaphores. The easiest way for us to support that right > > now is to insert a dummy execbuf. > > --- > > diff --g

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

> -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Friday, August 4, 2017 9:39 PM > On Sat, Aug 5, 2017 at 12:53 AM, Marathe, Yogesh > wrote: > > Tomasz, Emil, > > > >> -Original Message- > >> From: Tomasz Figa [mailto:tf...@chromium.org] > >> On Fri, Aug

Re: [Mesa-dev] [PATCH 1/5] clover/memory: Copy data when creating buffers with CL_MEM_USE_HOST_PTR

On 2017-08-03 22:26, Alex Deucher wrote: IIRC, user_ptrs require page alignment. Alex I didn't follow the whole discussion (sorry if I'm saying something redundant), but AMD's older OpenCL Optimization Guide [1] has some notes regarding the implementation of the USE_HOST_PTR flag. It initi

Re: [Mesa-dev] [PATCH v2 7/9] anv/allocator: Add a syncobj cache

On Fri, Aug 4, 2017 at 1:59 AM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-08-04 02:25:26) > > This is mostly a copy+paste of the BO cache but it's a bit simpler > > because syncobjs don't have actual backing storage so we don't need to > > check sizes or anything like that. Also, we put

Re: [Mesa-dev] [PATCH v2 8/9] anv: Use DRM sync objects for external semaphores when available

On Fri, Aug 4, 2017 at 2:03 AM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-08-04 02:25:27) > > @@ -1497,6 +1569,12 @@ anv_cmd_buffer_execbuf(struct anv_device *device, > >setup_empty_execbuf(&execbuf, device); > > } > > > > + if (execbuf.fence_count > 0) { > > For sanity, si

Re: [Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

On Fri, 2017-08-04 at 18:15 +0200, Wladimir J. van der Laan wrote: > On Fri, Aug 04, 2017 at 05:07:54PM +0200, Philipp Zabel wrote: > > Look up BOs from the name table using the name parameter instead of > > req.handle (which at this point is always zero). > > Good catch. > > Just out of interest

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #1 from Brian Paul --- Sorry for the breakage, Brad. I'll try to investigate ASAP, but I'm about to leave town for a week. I can't repro with llmvpipe, fwiw. I suspect it may be an issue in the swr driver. I'm building it now, bu

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #2 from Brian Paul --- Hmm, swr isn't working at all for me. It's hanging in a swr_fence_finish() call with everything I've tried. Even glxinfo hangs (but elsewhere). Maybe one of the swr developers can take a look. -- You are r

[Mesa-dev] [PATCH] egl: Clean up native_type vs drawable mess

The next patch is going to stop passing XCB_WINDOW_NONE (of type xcb_window_enum_t) as an argument where these functions expect a void *, which clang does not appreciate. This patch cleans things up to better convince me and reviewers that it's safe to do that. --- src/egl/drivers/dri2/platform_x

Re: [Mesa-dev] [PATCH 09/12] egl/x11: pass NULL instead of XCB_WINDOW_NONE as native_surface

Thanks. I wrote the same patch some time ago, but never had a chance to send it out. I'll send you another patch that I wrote to clear up some of this confusion. I put it in my series immediately before this patch. Feel free to add it to yours. Reviewed-by: Matt Turner ___

[Mesa-dev] [PATCH] docs: removed the '--with-sha1' requirement from shading.html

The configuration option --with-sha1 is no longer required for the MESA_SHADER_READ_PATH, MESA_SHADER_DUMP_PATH environment variables to take effect. 1- removed the "--with-sha1" sentence from docs/shading.html 2- added an extra note: that the corresponding dumped and replacement shaders must have

[Mesa-dev] [PATCH v3 0/8] anv: Implement VK_KHR_external_semaphore

This series is a quick re-spin of the v2 sent yesterday to address review feedback from Chris. In particular, we now set EXEC_ASYNC on the trivial batch and I deleted the syncobj cache. Somehow, when I was working on this yesterday, I got it into my head that the kernel deduplicates syncobj handl

[Mesa-dev] [PATCH v3 4/8] anv: Implement support for exporting semaphores as FENCE_FD

--- src/intel/vulkan/anv_batch_chain.c | 57 +-- src/intel/vulkan/anv_device.c | 1 + src/intel/vulkan/anv_gem.c | 36 src/intel/vulkan/anv_private.h | 23 + src/intel/vulkan/anv_queue.c | 69 +

[Mesa-dev] [PATCH v3 2/8] anv: Submit a dummy batch when only semaphores are provided.

Vulkan allows you to do a submit whose only job is to wait on and trigger semaphores. The easiest way for us to support that right now is to insert a dummy execbuf. --- src/intel/vulkan/anv_batch_chain.c | 28 +--- src/intel/vulkan/anv_device.c | 30 ++

[Mesa-dev] [PATCH v3 1/8] anv: Add a basic implementation of VK_KHX_external_semaphore

This patch adds an implementation based on DRM BOs. We don't actually advertise the extension yet because we want to add a couple more paths first. --- src/intel/vulkan/anv_batch_chain.c | 31 +++- src/intel/vulkan/anv_extensions.py | 3 + src/intel/vulkan/anv_private.h | 3 + src/in

[Mesa-dev] [PATCH v3 3/8] anv/gem: Use EXECBUFFER2_WR when the FENCE_OUT flag is set

Reviewed-by: Chad Versace --- src/intel/vulkan/anv_gem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index ac47da4..36692f5 100644 --- a/src/intel/vulkan/anv_gem.c +++ b/src/intel/vulkan/anv_gem.c @@ -185,7 +185,1

[Mesa-dev] [PATCH v3 5/8] intel/drm: Pull in the i916 fence array API

--- include/drm-uapi/i915_drm.h | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h index c26bf7c..338c8c2 100644 --- a/include/drm-uapi/i915_drm.h +++ b/include/drm-uapi/i915_drm.h @@ -431,6

[Mesa-dev] [PATCH v3 8/8] anv: Advertise VK_KHR_external_semaphore

--- src/intel/vulkan/anv_extensions.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index 00186bc..3252e0f 100644 --- a/src/intel/vulkan/anv_extensions.py +++ b/src/intel/vulkan/anv_extensions.py

[Mesa-dev] [PATCH v3 6/8] anv/gem: Add a drm syncobj support

--- src/intel/vulkan/anv_gem.c | 52 src/intel/vulkan/anv_gem_stubs.c | 24 +++ src/intel/vulkan/anv_private.h | 4 3 files changed, 80 insertions(+) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index 5

[Mesa-dev] [PATCH v3 7/8] anv: Use DRM sync objects for external semaphores when available

--- src/intel/vulkan/anv_batch_chain.c | 59 +++ src/intel/vulkan/anv_device.c | 1 + src/intel/vulkan/anv_private.h | 8 src/intel/vulkan/anv_queue.c | 83 +++--- 4 files changed, 128 insertions(+), 23 deletions(-) dif

[Mesa-dev] [PATCH 02/25] i965: Move compaction "prepass" into brw_eu_compact.c

--- src/intel/compiler/brw_eu_compact.c | 82 - src/intel/compiler/brw_eu_emit.c| 72 +--- 2 files changed, 82 insertions(+), 72 deletions(-) diff --git a/src/intel/compiler/brw_eu_compact.c b/src/intel/compiler/brw_eu_compact.c

[Mesa-dev] [PATCH 03/25] i965: Silence signed/unsigned comparison warning

--- src/intel/compiler/test_eu_compact.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/test_eu_compact.cpp b/src/intel/compiler/test_eu_compact.cpp index 39e7f1a27c..1ef7e5ae7f 100644 --- a/src/intel/compiler/test_eu_compact.cpp +++ b/src/intel/compiler/

[Mesa-dev] [PATCH 00/25] i965: Switch to always using logical register types

The mixture of hardware encodings and logical types has caused lots of confusion. It's time to fix that. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 04/25] i965: Test instruction compaction on all supported Gens

Note that there's no point in testing on G45, since its compaction is the same as Gen5. Same logic applies to Gen7 variants and low-power parts. --- src/intel/compiler/test_eu_compact.cpp | 50 -- 1 file changed, 42 insertions(+), 8 deletions(-) diff --git a/src/in

[Mesa-dev] [PATCH 01/25] i965: Mark src inst pointer const in compaction code

--- src/intel/compiler/brw_eu.h | 2 +- src/intel/compiler/brw_eu_compact.c | 23 --- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/src/intel/compiler/brw_eu.h b/src/intel/compiler/brw_eu.h index a3a9c63239..8e597b212a 100644 --- a/src/intel/compiler

[Mesa-dev] [PATCH 08/25] i965: Validate destination restrictions with vector immediates

--- src/intel/compiler/brw_eu_emit.c| 13 +- src/intel/compiler/brw_eu_validate.c| 61 + src/intel/compiler/test_eu_validate.cpp | 79 + 3 files changed, 141 insertions(+), 12 deletions(-) diff --git a/src/intel/compiler/brw_

  1   2   >