Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

2017-08-02 Thread Emil Velikov
On 2 August 2017 at 18:29, Rafael Antognolli wrote: > On Wed, Aug 02, 2017 at 02:56:34PM +0100, Emil Velikov wrote: >> On 1 August 2017 at 16:29, Rafael Antognolli >> wrote: >> > On Mon, Jul 31, 2017 at 09:58:24AM -0700, Marathe, Yogesh wrote: >> >> Rafael, Tomasz, >> >> >> >> > -Original Me

[Mesa-dev] [PATCH 1/2] mesa: only check errors when the state change in glBlendEquationSeparateiARB()

2017-08-02 Thread Samuel Pitoiset
When this GL call is a no-op, it should be a little faster. Signed-off-by: Samuel Pitoiset --- src/mesa/main/blend.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 9ca04c1db2..af

[Mesa-dev] [PATCH 2/2] mesa: only check errors when the state change in glLogicOp()

2017-08-02 Thread Samuel Pitoiset
When this GL call is a no-op, it should be a little faster. Signed-off-by: Samuel Pitoiset --- src/mesa/main/blend.c | 56 ++- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index af378

Re: [Mesa-dev] [PATCH] glsl: update the extensions that are enabled for 460

2017-08-02 Thread Samuel Pitoiset
On 08/02/2017 06:24 PM, Ilia Mirkin wrote: On Aug 2, 2017 6:56 AM, "Samuel Pitoiset" > wrote: Other ones are either unsupported or don't have any helper function checks. Signed-off-by: Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> ---

[Mesa-dev] [PATCH v2] glsl: update the extensions that are enabled for 460

2017-08-02 Thread Samuel Pitoiset
Other ones are either unsupported or don't have any helper function checks. v2: - fix ARB_shader_draw_parameters system value names Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 6 -- src/compiler/glsl/builtin_variables.cpp | 12 +--- 2 files changed,

Re: [Mesa-dev] [PATCH v2] glsl: update the extensions that are enabled for 460

2017-08-02 Thread Gustaw Smolarczyk
2017-08-02 20:57 GMT+02:00 Samuel Pitoiset : > Other ones are either unsupported or don't have any helper > function checks. > > v2: - fix ARB_shader_draw_parameters system value names > > Signed-off-by: Samuel Pitoiset > --- > src/compiler/glsl/builtin_functions.cpp | 6 -- > src/compiler/g

[Mesa-dev] [PATCH 1/2] calibrate_rast: add vertical line test

2017-08-02 Thread Brian Paul
Print GL_VERSION string. Call glutSwapBuffers() and fflush() more frequently so we can see what's happening. --- src/tests/calibrate_rast.c | 141 +++-- 1 file changed, 136 insertions(+), 5 deletions(-) diff --git a/src/tests/calibrate_rast.c b/src/tests/ca

[Mesa-dev] [PATCH 2/2] calibrate_rast: add command line arguments

2017-08-02 Thread Brian Paul
To skip swapbuffers, or only test points/lines/quads. --- src/tests/calibrate_rast.c | 130 ++--- 1 file changed, 88 insertions(+), 42 deletions(-) diff --git a/src/tests/calibrate_rast.c b/src/tests/calibrate_rast.c index ae9ff10..0bbbf84 100644 --- a/src/

Re: [Mesa-dev] [PATCH v2] glsl: update the extensions that are enabled for 460

2017-08-02 Thread Samuel Pitoiset
On 08/02/2017 09:06 PM, Gustaw Smolarczyk wrote: 2017-08-02 20:57 GMT+02:00 Samuel Pitoiset : Other ones are either unsupported or don't have any helper function checks. v2: - fix ARB_shader_draw_parameters system value names Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_fu

[Mesa-dev] [PATCH v5 1/2] i965: Return the last fence if the batch buffer is empty

2017-08-02 Thread yogesh . marathe
From: Zhongmin Wu Always save the last fence in the brw context when flushing buffer. If there is nothing to be flushed, return the last fence if asked for. Nothing to be flushed when _intel_batchbuffer_flush_fence. Signed-off-by: Zhongmin Wu Signed-off-by: Yogesh Marathe --- src/mesa/driver

[Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

2017-08-02 Thread yogesh . marathe
From: Zhongmin Wu Before we queued the buffer with a invalid fence (-1), it causes benchmarks such as flatland to fail. This patch enables explicit sync feature on android. Now we get the out fence during the flushing buffer and then pass it to SurfaceFlinger in eglSwapbuffer function. v2: a) A

[Mesa-dev] [PATCH v3] glsl: update the extensions that are enabled for 460

2017-08-02 Thread Samuel Pitoiset
Other ones are either unsupported or don't have any helper function checks. v3: - always add gl_BaseVertex & co when 460 is enabled v2: - fix ARB_shader_draw_parameters system value names Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 6 -- src/compiler/glsl/bu

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

2017-08-02 Thread Roland Scheidegger
Am 02.08.2017 um 20:35 schrieb Brian Paul: > On 08/02/2017 11:59 AM, Roland Scheidegger wrote: >> I think the problem here is that msaa surfaces with sample count 1 are >> not really supposed to exist in gallium. >> This is a rather awkward gl-ism, which isn't possible anywhere else, >> other apis

Re: [Mesa-dev] [PATCH] intel/isl: Stop padding surfaces

2017-08-02 Thread Jason Ekstrand
On Wed, Aug 2, 2017 at 8:23 AM, Tomasz Figa wrote: > On Tue, Aug 1, 2017 at 3:27 AM, Jason Ekstrand > wrote: > > The docs contain a bunch of commentary about the need to pad various > > surfaces out to multiples of something or other. However, all of those > > requirements are about avoiding GT

Re: [Mesa-dev] [PATCH 1/2] gallium: add CAPs to support HW atomic counters.

2017-08-02 Thread Dave Airlie
On 2 August 2017 at 20:56, Nicolai Hähnle wrote: > On 02.08.2017 01:00, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This looks like an evergreen specific feature, but with atomic >> counters AMD have hw specific counters they use instead of operating >> on buffers directly. These are separat

[Mesa-dev] [PATCH 2/2] mesa: reduce CPU overhead when updating the viewport

2017-08-02 Thread Samuel Pitoiset
Before: DrawElements (1 VBO, 8 UBO, 8 Tex) w/ viewport change: 3.61 million (43.7%) After: DrawElements (1 VBO, 8 UBO, 8 Tex) w/ viewport change: 4.95 million (60.2%) Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 89 +++- 1 file change

[Mesa-dev] [PATCH 1/2] mesa: reduce CPU overhead when updating the scissor

2017-08-02 Thread Samuel Pitoiset
Before: DrawElements (1 VBO, 8 UBO, 8 Tex) w/ scissor change: 3.67 million (44.4%) After: DrawElements (1 VBO, 8 UBO, 8 Tex) w/ scissor change: 5.02 million (62.1%) Signed-off-by: Samuel Pitoiset --- src/mesa/main/scissor.c | 79 ++--- 1 file changed,

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

2017-08-02 Thread Brian Paul
On 08/02/2017 01:18 PM, Roland Scheidegger wrote: Am 02.08.2017 um 20:35 schrieb Brian Paul: On 08/02/2017 11:59 AM, Roland Scheidegger wrote: I think the problem here is that msaa surfaces with sample count 1 are not really supposed to exist in gallium. This is a rather awkward gl-ism, which i

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

2017-08-02 Thread Roland Scheidegger
Am 02.08.2017 um 21:49 schrieb Brian Paul: > On 08/02/2017 01:18 PM, Roland Scheidegger wrote: >> Am 02.08.2017 um 20:35 schrieb Brian Paul: >>> On 08/02/2017 11:59 AM, Roland Scheidegger wrote: I think the problem here is that msaa surfaces with sample count 1 are not really supposed to

[Mesa-dev] [PATCH 1/3] specs: Update Mesa EGL enums

2017-08-02 Thread Adam Jackson
Note that, presumably because Khronos never got a copy of WL_bind_wayland_display in the registry, we've double-allocated some enums into the (now KHR) platform extensions, and we should consider retiring the wayland extension at some point to fix it. Signed-off-by: Adam Jackson --- docs/specs/e

[Mesa-dev] [RFC PATCH 0/3] EGL spec updates and proposals

2017-08-02 Thread Adam Jackson
I've been looking at finishing up the EGL_EXT_device_base work properly as I'd like to consume it in xserver. I think I'm going to need some additional extensions to be able to consume it sanely though, so, here's some draft specs. Any feedback would be greatly appreciated. 1/3 is a bit unrelated,

[Mesa-dev] [PATCH 2/3] specs: Add EGL_MESA_device_software

2017-08-02 Thread Adam Jackson
The device extension string is expected to contain the name of the extension defining what kind of device it is, so the caller can know what kinds of operations it can perform with it. So that string had better be non-empty, hence this trivial extension. Signed-off-by: Adam Jackson --- docs/spec

[Mesa-dev] [PATCH 3/3] specs: Add EGL_MESA_platform_device

2017-08-02 Thread Adam Jackson
This extension name is bad, but I don't have an idea for a better one. Signed-off-by: Adam Jackson --- docs/specs/EGL_MESA_platform_device.txt | 94 + 1 file changed, 94 insertions(+) create mode 100644 docs/specs/EGL_MESA_platform_device.txt diff --git a/docs/s

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Andy Furniss
Hmm, been AFK, but now have actually installed as well as just testing build. Testing with this and the patch that avoids segfaults for cl. I am getting segfaults when using vdpau for video, so maybe that needs something similar. Jan Vesely wrote: The patch still causes segfaults because yo

[Mesa-dev] [PATCH 03/11] i965/blit: Stop asserting linear row_pitches are 64B-aligned

2017-08-02 Thread Jason Ekstrand
The 64B alignment restriction is on the base address and not the row pitch. This code already ensures that the base address is aligned by adding a small X offset if needed. The assertion serves no purpose and is actually causing people problems. Cc: "17.2" Cc: Kenneth Graunke --- src/mesa/dri

[Mesa-dev] [PATCH 05/11] i965/miptree: Refactor is_mcs_supported

2017-08-02 Thread Jason Ekstrand
We rename it to intel_miptree_supports_mcs and make the function signature match intel_miptree_supports_ccs/hiz. We also move the sample count check into the function so it returns false for single-sampled surfaces. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 13 + 1 file chan

[Mesa-dev] [PATCH 00/11] i965: Clean up miptrees a bit

2017-08-02 Thread Jason Ekstrand
This patch series is the start of what I'm sure will be a decent sized effort to clean up intel_mipmap_tree.c after the ISL conversion. Patches 1, 2, 3, and 8 are actually bugfixes that will need to get landed in 17.2. The rest just makes the miptree create flags more sane. Cc: Topi Pohjolainen

[Mesa-dev] [PATCH 01/11] intel/isl: Stop padding surfaces

2017-08-02 Thread Jason Ekstrand
The docs contain a bunch of commentary about the need to pad various surfaces out to multiples of something or other. However, all of those requirements are about avoiding GTT errors due to missing pages when the data port or sampler accesses slightly out-of-bounds. However, because the kernel al

[Mesa-dev] [PATCH 07/11] i965/miptree: Delete MIPTREE_LAYOUT_FOR_SCANOUT

2017-08-02 Thread Jason Ekstrand
The flag hasn't affected actual surface layout for some time. The only purpose it served was to set bo->cache_coherent = false on the BO used to create the miptree. This is fairly silly because we can just set that directly from the caller where it makes much more sense. --- src/mesa/drivers/dri

[Mesa-dev] [PATCH 04/11] i965/miptree Remove layout_flags parameter form is_mcs_supported

2017-08-02 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index daa49f9..0e0aaa8 100644 --- a/src/mesa/drivers/dri/i965/intel_mipma

[Mesa-dev] [PATCH 02/11] intel/isl: Don't align the height of the last array slice

2017-08-02 Thread Jason Ekstrand
We were calculating the total height of 2D surfaces by multiplying the row pitch by the number of slices. This means that we actually request slightly more space than actually needed since the padding on the last slice is unnecessary. For tiled surfaces this is not likely to make a difference. F

[Mesa-dev] [PATCH 06/11] i965/miptree: Delete some unused layout flags

2017-08-02 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 ++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 --- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index eb01f58..d1cb

[Mesa-dev] [PATCH 10/11] i965/miptree: Delete MIPTREE_LAYOUT_TILING_(Y|ANY)

2017-08-02 Thread Jason Ekstrand
The only force tiling flag we really care about is LAYOUT_TILING_NONE. The others don't actually do anything but add confusion. --- src/mesa/drivers/dri/i965/intel_fbo.c | 3 +-- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 19 --- src/mesa/drivers/dri/i965/intel_mipm

[Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-02 Thread Jason Ekstrand
Originally, I had moved it to the caller to make some things easier when adding the CCS modifier. However, this broke DRI2 because intel_process_dri2_buffer calls intel_miptree_create_for_bo but never calls intel_miptree_alloc_aux. Also, in hindsight, it should be pretty easy to make the CCS modi

[Mesa-dev] [PATCH 09/11] i965/miptree: Delete an unused function declaration

2017-08-02 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h index 7636172..70acb96 100644 --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h +++ b/src/mesa/

[Mesa-dev] [PATCH 11/11] i965/miptree: Rework create flags

2017-08-02 Thread Jason Ekstrand
The only one of the three remaining flags that has anything whatsoever to do with layout is TILING_NONE. This commit renames them to MIPTREE_CREATE_*, documents the meaning of each flag, and makes the create functions take an actual enum type so GDB will print them nicely. --- src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH v2] mesa: Fix swizzling for luminance/intensity in _mesa_readpixels

2017-08-02 Thread Kenneth Graunke
On Wednesday, August 2, 2017 3:28:23 AM PDT Nicolai Hähnle wrote: > On 01.08.2017 00:15, Chris Wilson wrote: > > Quoting Chris Wilson (2017-07-31 22:51:25) > >> Luminance/Intensity when converted to RGB should be replicated to fill > >> the RGB channels, but they differ on how the alpha channel is

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Jan Vesely
probably. The original changeset passes NULL(which is then unconditionally accessed) at least in: src/gallium/auxiliary/vl/vl_winsys_dri.c src/gallium/auxiliary/vl/vl_winsys_dri3.c src/gallium/auxiliary/vl/vl_winsys_drm.c src/gallium/state_trackers/xa/xa_tracker.c src/gallium/targets/d3dadapter9/d

[Mesa-dev] [PATCH v2 1/1] clover: Wait for requested operation if blocking flag is set

2017-08-02 Thread Jan Vesely
v2: wait in map_buffer and map_image as well Signed-off-by: Jan Vesely --- Hi Aaron, yes, I think you're right, we should wait in Map* as well. If nothing else it's consistent, even if passing the flag to add_map might make it unnecessary (haven't actually checked). thanks, Jan src/gallium/s

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #5 from Gert Wollny --- Can you also run the game from the command line and see whether there are any error messages, specifically whether you get any messages saying something like r600_shader_select - Failed to build shader var

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

2017-08-02 Thread Marek Olšák
Can the issue be fixed such that gallium drivers keep getting nr_samples = 0? Marek On Wed, Aug 2, 2017 at 7:07 PM, Brian Paul wrote: > We pretty much use the convention that if gl_renderbuffer::NumSamples > or gl_texture_image::NumSamples is zero, it's a non-MSAA surface. > Otherwise, it's an M

Re: [Mesa-dev] [PATCH 1/3] radv: Add VK_KHR_display, VK_KEITHP_kms_display and VK_EXT_direct_mode_display [v2]

2017-08-02 Thread Keith Packard
Emil Velikov writes: > Is the VK_KEITHP_kms_display spec available somewhere? Here's a rough version: VK_KEITHP_kms_display = **Name String** VK_KEITHP_kms_display **Extension Type** Instance Extension **Registered Extension Number** TBD **Status*

Re: [Mesa-dev] [PATCH v2 1/1] clover: Wait for requested operation if blocking flag is set

2017-08-02 Thread Francisco Jerez
These changes are somewhat redundant and potentially performance-impacting, the reason is that in the OpenCL API, clEnqueueWrite* commands are specified to block until the memory provided by the application as origin can be reused safely (i.e. until soft_copy_op()() runs), not necessarily until the

[Mesa-dev] [PATCH] anv/allocator: Loosen the size restriction on imported BOs

2017-08-02 Thread Kevin Strasser
It's possible for a buffer manager to issue the application a BO that is larger than what is requested. The out-of-bounds access issue would only apply in cases where the size of the imported buffer exceeds that of the underlying BO, as such we should only reject import requests sizes that exceed t

Re: [Mesa-dev] [PATCH 03/11] i965/blit: Stop asserting linear row_pitches are 64B-aligned

2017-08-02 Thread Matt Turner
Ken committed this as 595a47b8293 earlier today. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/mesa: add osmesa framebuffer iface hash table per st manager

2017-08-02 Thread Bruce Cherniak
Commit bbc29393d3 didn't include osmesa state_tracker. This patch adds necessary initialization. Fixes crash in OSMesa initialization. Created-by: Charmaine Lee Tested-by: Bruce Cherniak Cc: 17.2 --- src/gallium/state_trackers/osmesa/osmesa.c | 11 +++ 1 file changed, 11 insertions(

[Mesa-dev] [PATCH] st/mesa: add osmesa framebuffer iface hash table per st manager

2017-08-02 Thread Bruce Cherniak
Commit bbc29393d3 didn't include osmesa state_tracker. This patch adds necessary initialization. Fixes crash in OSMesa initialization. Created-by: Charmaine Lee Tested-by: Bruce Cherniak Cc: Charmaine Lee Cc: 17.2 --- src/gallium/state_trackers/osmesa/osmesa.c | 11 +++ 1 file chan

Re: [Mesa-dev] [PATCH 2/2] mesa: only check errors when the state change in glLogicOp()

2017-08-02 Thread Timothy Arceri
Both: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3] glsl: update the extensions that are enabled for 460

2017-08-02 Thread Ilia Mirkin
Can you go through all the others and work out the suffixes too? Just going by memory, but the vote extension functions have suffixes, as do the atomic counter ones, maybe there's other stuff too... On Aug 2, 2017 2:15 PM, "Samuel Pitoiset" wrote: > Other ones are either unsupported or don't hav

[Mesa-dev] [PATCH 3/3] android: radeonsi: prepare for driver-specific driconf options

2017-08-02 Thread Mauro Rossi
Android build changes to avoid the following building error: In file included from external/mesa/src/gallium/targets/dri/target.c:1: external/mesa/src/gallium/auxiliary/target-helpers/drm_helper.h:185:10: fatal error: 'radeonsi/si_driinfo.h' file not found #include "radeonsi/si_driinfo.h"

[Mesa-dev] [PATCH 1/3] android: radeonsi: add nir include paths

2017-08-02 Thread Mauro Rossi
Android build changes to avoid the following building error: target C: libmesa_pipe_radeonsi <= external/mesa/src/gallium/drivers/radeonsi/si_pipe.c ... In file included from external/mesa/src/gallium/drivers/radeonsi/si_pipe.c:38: external/mesa/src/compiler/nir/nir.h:48:10: fatal error: 'nir_op

[Mesa-dev] [PATCH 2/3] android: ac/common: always build NIR translation

2017-08-02 Thread Mauro Rossi
Android build changes to avoid the following building error: external/mesa/src/gallium/drivers/radeonsi/si_shader_nir.c:505: error: undefined reference to 'ac_nir_translate' Fixes: 86d4b46d66 "ac/common: always build NIR translation" --- src/amd/Android.common.mk | 3 ++- 1 file changed, 2 inser

[Mesa-dev] Android fixes for radeonsi building errors introduced by recent commits

2017-08-02 Thread Mauro Rossi
[PATCH 1/3] android: radeonsi: add nir include paths [PATCH 2/3] android: ac/common: always build NIR translation [PATCH 3/3] android: radeonsi: prepare for driver-specific driconf ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.fre

[Mesa-dev] [PATCH] i965/bufmgr: Set bo->idle after waiting.

2017-08-02 Thread Kenneth Graunke
After a successful wait, we know the buffer ought to be idle. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index f70365eba2a..1df812a711a 100644 --- a/src/mesa/drive

Re: [Mesa-dev] [PATCH] i965/blit: Remember to include miptree buffer offset in relocs

2017-08-02 Thread Kenneth Graunke
On Monday, July 31, 2017 2:56:15 AM PDT Chris Wilson wrote: > Remember to add the offset to the start of the buffer in the relocation > or else we write 0xff into random bytes elsewhere. > --- > src/mesa/drivers/dri/i965/intel_blit.c | 4 ++-- > src/mesa/drivers/dri/i965/intel_pixel_bitmap

Re: [Mesa-dev] [PATCH] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Michel Dänzer
On 03/08/17 01:14 AM, Nicolai Hähnle wrote: > On 02.08.2017 18:04, Emil Velikov wrote: >> On 2 August 2017 at 16:29, Nicolai Hähnle wrote: >>> From: Nicolai Hähnle >>> >>> Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create >>> functions") >>> Bugzilla: https://bugs.freedesktop.

Re: [Mesa-dev] [PATCH 2/2] configure.ac: drop support for ancient expat versions

2017-08-02 Thread Michel Dänzer
On 03/08/17 03:39 AM, Emil Velikov wrote: > From: Emil Velikov > > Expat versions prior to 2.1.0 lack the .pc file, so we need to do extra > gymnastics to detect it. > > Version 2.1.0 was released back in Mar 2012 and all major distributions > use it. > > Cc: Michel Dänzer > Signed-off-by: Emi

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #6 from MWATTT --- This game always worked fine for me with an HD 5770, and is still OK with Oibaf PPA. It was also OK with an HD 4850. The problem might be specific to Cayman. Can you try running the game with the environement vari

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: add osmesa framebuffer iface hash table per st manager

2017-08-02 Thread Brian Paul
I'll let Charmaine review, but the subject line prefix should probably be "st/osmesa". -Brian On 08/02/2017 05:28 PM, Bruce Cherniak wrote: Commit bbc29393d3 didn't include osmesa state_tracker. This patch adds necessary initialization. Fixes crash in OSMesa initialization. Created-by: Char

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

2017-08-02 Thread Brian Paul
Yes, I'm not proposing otherwise. -Brian On 08/02/2017 03:53 PM, Marek Olšák wrote: Can the issue be fixed such that gallium drivers keep getting nr_samples = 0? Marek On Wed, Aug 2, 2017 at 7:07 PM, Brian Paul wrote: We pretty much use the convention that if gl_renderbuffer::NumSamples or

[Mesa-dev] [PATCH] intel/vec4/gs: reset nr_pull_param if DUAL_INSTANCED compile failed.

2017-08-02 Thread Dave Airlie
If dual instanced compile fails (as seems to happen with virgl a fair bit, and does piglit even have any tests for it?), we end up not restarting the pull params, so we call vec4_visitor::move_uniform_array_access_to_pull_constant a second time and it runs over the ends of the alloc. Fixes: tests/

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: add osmesa framebuffer iface hash table per st manager

2017-08-02 Thread Charmaine Lee
Change looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, August 2, 2017 8:30 PM To: Bruce Cherniak; mesa-dev@lists.freedesktop.org Cc: 17 . 2; Charmaine Lee Subject: Re: [Mesa-stable] [PATCH] st/mesa: add osmesa framebuffer iface h

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #7 from Kenneth Graunke --- You might also want to try with UNITY_DISABLE_GRAPHICS_DRIVER_WORKAROUNDS=yes - Cities Skylines has broken in the past due to bugs in Unity (which were fixed in a newer version of the engine, but the game

Re: [Mesa-dev] [PATCH 1/5] clover/memory: Copy data when creating buffers with CL_MEM_USE_HOST_PTR

2017-08-02 Thread Aaron Watry
/ On Sat, Jul 22, 2017 at 2:27 PM, Jan Vesely wrote: > On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote: >> Fixes: OpenCL CTS test/conformance/buffers/buffer_copy > > Similar patch was pushed in 2013: > 56647c5d8f8e60269f0a3277e3caa7ee57d1fe6a > "clover: Append buffers that use CL_MEM_USE_HOS

Re: [Mesa-dev] [PATCH] intel/vec4/gs: reset nr_pull_param if DUAL_INSTANCED compile failed.

2017-08-02 Thread Kenneth Graunke
On Wednesday, August 2, 2017 8:50:54 PM PDT Dave Airlie wrote: > If dual instanced compile fails (as seems to happen with virgl a I think you mean "dual object" - it tries that first, then falls back to either "dual instance" or "single" mode. Thanks for fixing this! Reviewed-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-02 Thread Tapani Pälli
Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on Android and issue persists on both. On 08/02/2017 11:35 PM, Jason Ekstrand wrote: Originally, I had moved it to the caller to make some things easier when adding the CCS modifier

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-02 Thread Jason Ekstrand
On August 2, 2017 11:21:33 PM Tapani Pälli wrote: Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on Android and issue persists on both. Can you provide a but now detail? I tried today but wasn't able to reproduce the piglit fa

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-02 Thread Tapani Pälli
On 08/03/2017 09:28 AM, Jason Ekstrand wrote: On August 2, 2017 11:21:33 PM Tapani Pälli wrote: Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on Android and issue persists on both. Can you provide a but now detail? I tried

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-02 Thread Tapani Pälli
On 08/03/2017 09:33 AM, Tapani Pälli wrote: On 08/03/2017 09:28 AM, Jason Ekstrand wrote: On August 2, 2017 11:21:33 PM Tapani Pälli wrote: Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on Android and issue persists on bot

<    1   2