Re: [Mesa-dev] [PATCH] glsl: xfb_stride applies to buffers, not block members

2017-07-10 Thread Juan A. Suarez Romero
On Mon, 2017-07-10 at 14:30 +0800, Timothy Arceri wrote: > > On 8 July 2017 12:19:48 am GMT+08:00, "Juan A. Suarez Romero" > wrote: > > When we have an interface block like: > > > > layout (xfb_buffer = 0, xfb_offset = 0) out Block { > > vec4 var1; > >layout (xfb

Re: [Mesa-dev] [PATCH] gallium: use "ull" number suffix to keep the QtCreator parser happy

2017-07-10 Thread Eric Engestrom
On Saturday, 2017-07-08 23:59:25 +0200, Thomas Helland wrote: > Yes please! > I find this much more intuitive, as a bonus =) > > Reviewed-by: Thomas Helland > Agreed, r-b as well: Reviewed-by: Eric Engestrom You missed a couple though, feel free to squash this with your commit: 8< di

Re: [Mesa-dev] [PATCH] i965: skip varyings without slot

2017-07-10 Thread Juan A. Suarez Romero
On Thu, 2017-06-29 at 14:43 +1000, Timothy Arceri wrote: > On 27/06/17 21:20, Juan A. Suarez Romero wrote: > > On Tue, 2017-06-27 at 09:29 +1000, Timothy Arceri wrote: > > > On 16/06/17 18:12, Juan A. Suarez Romero wrote: > > > > > > > Commit 00620782c9 (i965: use nir_shader_gather_info() over > >

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-10 Thread Emil Velikov
Hi Zhongmin Wu, Above all, a bit of a disclaimer: I'm by no means an expert on the topic so take the following with a pinch of salt. On 10 July 2017 at 03:11, Zhongmin Wu wrote: > Before we queued the buffer with a invalid fence (-1), it will > make some benchmarks failed to test such as flatlan

Re: [Mesa-dev] [PATCH 2/4] docs: remove redundant parameter for scons build basic testing

2017-07-10 Thread Eric Engestrom
On Saturday, 2017-07-08 22:59:39 +0300, Andres Gomez wrote: > toolchain=crossmingw is the default option for platform=windows when > invoking scons. Has that always been true though? Or at least since the minimal scons version supported? > > Signed-off-by: Andres Gomez > --- > docs/releasing.h

Re: [Mesa-dev] [PATCH 3/4] docs: avoid overwrite of LD_LIBRARY_PATH during basic testing

2017-07-10 Thread Eric Engestrom
On Saturday, 2017-07-08 22:59:40 +0300, Andres Gomez wrote: > The LD_LIBRARY_PATH environment variable could be already defined so > we extend it and restore it rather than just overwriting it. > > Signed-off-by: Andres Gomez > --- > docs/releasing.html | 4 +++- > 1 file changed, 3 insertions(+

Re: [Mesa-dev] [PATCH 0/4] docs: update basic testing on the releasing instructions

2017-07-10 Thread Eric Engestrom
On Saturday, 2017-07-08 22:59:37 +0300, Andres Gomez wrote: > Some small update on the "Making a new release" section of the > releasing instructions. > > Patches 1-3 add some small modifications for performing the basic > testing. > > Patch 4 merges the section for updating the calendar into the

Re: [Mesa-dev] [PATCH 3/4] docs: avoid overwrite of LD_LIBRARY_PATH during basic testing

2017-07-10 Thread Emil Velikov
On 8 July 2017 at 20:59, Andres Gomez wrote: > The LD_LIBRARY_PATH environment variable could be already defined so > we extend it and restore it rather than just overwriting it. > Hmm, what are you doing to actually require LD_LIBRARY_PATH in the first place? It makes it somewhat uneasy that one

Re: [Mesa-dev] [PATCH 2/4] docs: remove redundant parameter for scons build basic testing

2017-07-10 Thread Emil Velikov
On 8 July 2017 at 20:59, Andres Gomez wrote: > toolchain=crossmingw is the default option for platform=windows when > invoking scons. > It may be a bit redundant, but I'd rather keep it. I doubt it's so interesting to track when it became the default and if/when that will change ;-) -Emil ___

Re: [Mesa-dev] [PATCH] mesa/marshal: add custommarshallingforglNamedBuffer(Sub)Data

2017-07-10 Thread Marc Dietrich
Hi Grigori, Am Montag, 10. Juli 2017, 01:59:05 CEST schrieb Grigori Goronzy: > On 2017-06-26 15:51, Marc Dietrich wrote: > > Am Montag, 26. Juni 2017, 15:35:15 CEST schrieb Grigori Goronzy: > >> On 2017-06-26 15:11, Marc Dietrich wrote: > >> > unfortunately, this change broke vmware/vmplayer here

Re: [Mesa-dev] [PATCH 4/4] docs: update master's release notes, news and calendar commit

2017-07-10 Thread Emil Velikov
On 8 July 2017 at 20:59, Andres Gomez wrote: > This reflects closer what we are actually doing. > > Signed-off-by: Andres Gomez > --- > docs/releasing.html | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/docs/releasing.html b/docs/releasing.html > index

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-10 Thread Rob Clark
On Sun, Jul 9, 2017 at 10:11 PM, Zhongmin Wu wrote: > Before we queued the buffer with a invalid fence (-1), it will > make some benchmarks failed to test such as flatland. > > Now we get the out fence during the flushing buffer and then pass > it to SurfaceFlinger in eglSwapbuffer function. > > C

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #9 from Emil Velikov --- Trevor, please try and get [ideally] all of the patches upstreamed. Be that in mesa[1] or the respective project. Frédéric Devernay may be able to lend a hand? Any of your local patches may be changing Mesa

Re: [Mesa-dev] [PATCH 1/3] vbo: simplify vbo_save_NotifyBegin()

2017-07-10 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Fri, Jul 7, 2017 at 4:11 PM, Brian Paul wrote: > This function always returned GL_TRUE. Just make it a void function. > Remove unreachable code following the call to vbo_save_NotifyBegin() > in save_Begin() in dlist.c > > There were some stale comments that no lon

Re: [Mesa-dev] [PATCH 2/2] swr: build driver proper separate from rasterizer

2017-07-10 Thread Emil Velikov
Hi Tim, On 7 July 2017 at 22:25, Tim Rowley wrote: > swr used to build and link the rasterizer to the driver, and to support > multiple architectures we needed to have multiple versions of the > driver/rasterizer combination, which needed to link in much of mesa. > > Changing to having one instan

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-10 Thread Marathe, Yogesh
Hello Emil, My two cents since I too spent some time on this. > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Emil Velikov > Sent: Monday, July 10, 2017 4:41 PM > To: Wu, Zhongmin > Cc: Widawsky, Benjamin ; Liu, Zhiquan > ; Eric Engestr

[Mesa-dev] [PATCH] mesa/marshal: fix glNamedBufferData with NULL data

2017-07-10 Thread Grigori Goronzy
The semantics are similar to glBufferData. Fixes a crash with VMWare Player. Signed-off-by: Grigori Goronzy --- src/mesa/main/marshal.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/marshal.c b/src/mesa/main/marshal.c index 8db4531..b801bdc

[Mesa-dev] [PATCH] svga: fix PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE value

2017-07-10 Thread Brian Paul
This query is supposed to return the max texture buffer size/width in texels, not size in bytes. Divide by 16 (the largest format size) to return texels. Fixes Piglit arb_texture_buffer_object-max-size test. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/svga/svga_screen.c | 5 ++

[Mesa-dev] [PATCH mesa] scons: split out check_header() helper

2017-07-10 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- scons/gallium.py | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/scons/gallium.py b/scons/gallium.py index 61643a6d4f..c8e47a39db 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -145,6 +145,17 @@ def check_cc(env, cc,

[Mesa-dev] [PATCH mesa] util: enforce unreachable() semantic

2017-07-10 Thread Eric Engestrom
No implementation of unreachable() should allow code execution to keep going past it. We can discuss whether we should have a dead loop, abort(), or do something else, but the current "meh, let's just keep going" is just wrong. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] anv: Stop setting domains to RENDER on EXEC_OBJECT_WRITE

2017-07-10 Thread Jason Ekstrand
On Sat, Jul 8, 2017 at 12:18 PM, Matt Turner wrote: > On Sat, Jul 8, 2017 at 11:05 AM, Jason Ekstrand > wrote: > > On July 7, 2017 1:52:54 PM Chris Wilson > wrote: > > > >> Quoting Jason Ekstrand (2017-07-07 21:37:29) > >>> > >>> The reason we were doing this was to ensure that the kernel did t

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 Trevor SANDY changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 George Kyriazis changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: [Mesa-dev] [PATCH mesa] util: enforce unreachable() semantic

2017-07-10 Thread Emil Velikov
On 10 July 2017 at 16:08, Eric Engestrom wrote: > No implementation of unreachable() should allow code execution to > keep going past it. > > We can discuss whether we should have a dead loop, abort(), or do > something else, but the current "meh, let's just keep going" is > just wrong. > > Cc: me

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #12 from George Kyriazis --- Emil, you said that cross compiling software drivers on arch works for you. Have you tried running the generated binaries? I've created a patch for Trevor, but for some reason the swr driver is not loa

Re: [Mesa-dev] [PATCH mesa] util: enforce unreachable() semantic

2017-07-10 Thread Eric Engestrom
On Monday, 2017-07-10 17:02:48 +0100, Emil Velikov wrote: > On 10 July 2017 at 16:08, Eric Engestrom wrote: > > No implementation of unreachable() should allow code execution to > > keep going past it. > > > > We can discuss whether we should have a dead loop, abort(), or do > > something else, bu

Re: [Mesa-dev] [PATCH v3 03/16] anv/cmd_buffer: Initialize the clear values buffer

2017-07-10 Thread Jason Ekstrand
On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > v2: Rewrite functions. > > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/genX_cmd_buffer.c | 93 ++ > > 1 file changed, 84 insertions(+), 9 deletions(-) > > diff --git a/src/intel/vulkan/genX_cmd_

Re: [Mesa-dev] [PATCH] gallium: improve selection of pixel format

2017-07-10 Thread Olivier Lauffenburger
Technically, a correctly written application should not rely on ChoosePixelFormat but should enumerate by itself through all the pixel formats and select the best one with its own algorithm. However, for the (numerous) applications that use ChoosePixelFormat, color depth is more a question of q

Re: [Mesa-dev] [PATCH v3 05/16] anv/cmd_buffer: Restrict fast clears in the GENERAL layout

2017-07-10 Thread Jason Ekstrand
On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > v2: Remove ::first_subpass_layout assertion (Jason Ekstrand). > v3: Allow some fast clears in the GENERAL layout. > > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_pass.c| 22 ++ > src/intel/vulkan/anv

Re: [Mesa-dev] [PATCH v3 06/16] anv/gpu_memcpy: Add a lighter-weight GPU memcpy function

2017-07-10 Thread Jason Ekstrand
On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > We'll be performing a GPU memcpy in more places to copy small amounts of > data. Add an alternate function that thrashes less state. > > v2: > - Make a new function (Jason Ekstrand). > - Move the #define into the function. > v3: > - Update th

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #13 from Emil Velikov --- (In reply to Trevor SANDY from comment #10) > Ok, Thanks to George's patch (0001-mingw-fixes.patch), the behaviour > reported in this ticket is fixed. > > I applied the set below (excluding the conflict) to

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 --- Comment #14 from Emil Velikov --- George, I'm only build-testing those, I have no setup to actually test those. No idea on the on the symbols part. In general scons or mingw (the w64 of course), Brian and Jose are the people to check with.

Re: [Mesa-dev] [PATCH v3 07/16] anv/cmd_buffer: Ensure fast-clear values are current

2017-07-10 Thread Jason Ekstrand
On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > v2: Rewrite functions, change location of synchronization. > > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/genX_cmd_buffer.c | 114 ++ > +++ > 1 file changed, 114 insertions(+) > > diff --git a/src/i

Re: [Mesa-dev] [Mesa-stable] [Fwd: Re: [PATCH 1/2] intel/isl: Use uint64_t to store total surface size]

2017-07-10 Thread Anuj Phogat
These patches are not fixing any known bug. But they are adding the previously missing surface size limits for the hardware. It's really hard to hit these limits. But, let's pick them to stable for the sake of completion. Thanks for marking them for mesa-stable. On Fri, Jul 7, 2017 at 7:25 AM, An

Re: [Mesa-dev] [PATCH 2/2] swr: build driver proper separate from rasterizer

2017-07-10 Thread Rowley, Timothy O
On Jul 10, 2017, at 8:24 AM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: Hi Tim, On 7 July 2017 at 22:25, Tim Rowley mailto:timothy.o.row...@intel.com>> wrote: swr used to build and link the rasterizer to the driver, and to support multiple architectures we needed to have multiple ve

Re: [Mesa-dev] [PATCH v3 08/16] anv: Transition more color buffer layouts

2017-07-10 Thread Jason Ekstrand
On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > v2: Expound on comment for the pipe controls (Jason Ekstrand). > > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_blorp.c | 4 +- > src/intel/vulkan/genX_cmd_buffer.c | 183 ++ > +++ > 2 fil

Re: [Mesa-dev] [PATCH] svga: fix breakage in create_backed_surface_view()

2017-07-10 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Sunday, July 9, 2017 1:00 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: fix breakage in create_backed_surface_view() This fixes a regression in some piglit tests since com

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-10 Thread Emil Velikov
On 10 July 2017 at 15:26, Marathe, Yogesh wrote: > Hello Emil, My two cents since I too spent some time on this. > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf >> Of Emil Velikov >> Sent: Monday, July 10, 2017 4:41 PM >> To: Wu, Zhongmin

Re: [Mesa-dev] [PATCH 03/20] nir: Support lowering vote intrinsics

2017-07-10 Thread Matt Turner
On Thu, Jul 6, 2017 at 8:04 PM, Connor Abbott wrote: > On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: >> ... trivially (as allowed by the spec!) by reusing the existing >> nir_opt_intrinsics code. >> --- >> src/compiler/nir/nir.h| 4 >> src/compiler/nir/nir_opt_intrinsic

Re: [Mesa-dev] [PATCH 16/20] nir: Add a ballot32 intrinsic

2017-07-10 Thread Matt Turner
On Thu, Jul 6, 2017 at 7:39 PM, Connor Abbott wrote: > I've thought about this a little bit, and I think we'd rather just > decrease the bitsize of the intrinsic rather than add a whole new one. > The separate intrinsic isn't really buying you anything, I don't think > it's going to make anything

[Mesa-dev] [PATCH 16/20] nir: Reduce destination size of ballot intrinsic when possible

2017-07-10 Thread Matt Turner
Some hardware, like i965, doesn't support group sizes greater than 32. In that case, we can reduce the destination size of the ballot intrinsic, which will simplify our code generation. --- v2: Just change the intrinsic size, and don't add a new intrinsic (Connor) src/compiler/nir/nir.h

[Mesa-dev] [PATCH 18/20] i965/fs: Match destination type to size for ballot

2017-07-10 Thread Matt Turner
No use in taking a 64-bit value when we know the high 32-bits are zero. --- v2: Update for v2 of 16/20 (Connor) src/intel/compiler/brw_compiler.c | 2 +- src/intel/compiler/brw_fs_nir.cpp | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/intel/compiler/brw_compiler.c

Re: [Mesa-dev] [Mesa-stable] [Fwd: Re: [PATCH 1/2] intel/isl: Use uint64_t to store total surface size]

2017-07-10 Thread Andres Gomez
OK, thanks for the feedback! ☺ On Mon, 2017-07-10 at 09:46 -0700, Anuj Phogat wrote: > These patches are not fixing any known bug. But they are adding the > previously missing surface size limits for the hardware. It's really hard > to hit these limits. But, let's pick them to stable for the sake

Re: [Mesa-dev] [PATCH] nir: copy front interpolation when creating fake back color input

2017-07-10 Thread Andres Gomez
Ilia, would we want this patch in -stable ? On Fri, 2017-07-07 at 20:34 -0400, Ilia Mirkin wrote: > Fixes a bunch of gl_BackColor interpolation tests that had explicit > interpolation specified on the fragment shader gl_Color. > > Signed-off-by: Ilia Mirkin > --- > src/compiler/nir/nir_lower_tw

Re: [Mesa-dev] [PATCH] nir: copy front interpolation when creating fake back color input

2017-07-10 Thread Ilia Mirkin
I wouldn't object to it being in stable, but it's also not super-important. It does fix some piglits for freedreno though. (I don't think vc4 exposes GL 3.0, so the problematic condition can't happen there.) On Mon, Jul 10, 2017 at 1:30 PM, Andres Gomez wrote: > Ilia, would we want this patch in

Re: [Mesa-dev] [Mesa-stable] [PATCH] gallium: improve selection of pixel format

2017-07-10 Thread Andres Gomez
Great! Thanks for the feedback! ☺ On Mon, 2017-07-10 at 12:18 +0200, Olivier Lauffenburger wrote: > Technically, a correctly written application should not rely on > ChoosePixelFormat but should enumerate by itself through all the > pixel formats and select the best one with its own algorithm. >

Re: [Mesa-dev] [Mesa-stable] [PATCH] nir: copy front interpolation when creating fake back color input

2017-07-10 Thread Andres Gomez
I'll leave it out, then. Thanks for the feedback! ☺ On Mon, 2017-07-10 at 13:35 -0400, Ilia Mirkin wrote: > I wouldn't object to it being in stable, but it's also not > super-important. It does fix some piglits for freedreno though. (I > don't think vc4 exposes GL 3.0, so the problematic conditio

Re: [Mesa-dev] [PATCH] i965: Use brw_bo_wait() for brw_bo_wait_rendering()

2017-07-10 Thread Kenneth Graunke
On Friday, July 7, 2017 5:12:54 AM PDT Chris Wilson wrote: > Currently, we use set_domain() to cause a stall on rendering. But the > set-domain ioctl has the side-effect of changing the kernel's cache > domain underneath the struct_mutex, which may perturb state if there was > no rendering to wait

Re: [Mesa-dev] [PATCH 03/11] i965: Select ranges of UBO data to be uploaded as push constants.

2017-07-10 Thread Matt Turner
On Thu, Jul 6, 2017 at 5:22 PM, Kenneth Graunke wrote: > This adds a NIR pass that decides which portions of UBOS we should > upload as push constants, rather than pull constants. > --- > src/intel/Makefile.sources | 1 + > src/intel/compiler/brw_compiler.h |

Re: [Mesa-dev] [PATCH] svga: fix PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE value

2017-07-10 Thread Charmaine Lee
Reviewed-by :Charmaine Lee From: Brian Paul Sent: Monday, July 10, 2017 7:40 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; mesa-sta...@lists.freedesktop.org Subject: [PATCH] svga: fix PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE value This query is suppos

Re: [Mesa-dev] [PATCH 11/11] i965: Use pushed UBO data in the scalar backend.

2017-07-10 Thread Matt Turner
On Thu, Jul 6, 2017 at 5:22 PM, Kenneth Graunke wrote: > This actually takes advantage of the newly pushed UBO data, avoiding > pull loads. > > XXX: quote performance numbers > --- > src/intel/compiler/brw_fs.cpp | 35 ++- > src/intel/compiler/brw_fs.h |

[Mesa-dev] [PATCH] squash: Add more comments to bitfield manipulations in UBO analysis pass

2017-07-10 Thread Kenneth Graunke
--- src/intel/compiler/brw_nir_analyze_ubo_ranges.c | 28 - 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_nir_analyze_ubo_ranges.c b/src/intel/compiler/brw_nir_analyze_ubo_ranges.c index 3535e67758c..b365728e77b 100644 --- a/src/intel

[Mesa-dev] [PATCH] drirc: whitelist glthread for The Witcher 2

2017-07-10 Thread Edmondo Tommasina
Performance delta on AMD Phenom II X3 720 / RX 470 The Witcher 2: +18% --- src/mesa/drivers/dri/common/drirc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index 69b735ce70..3108451090 100644 --- a/src/mesa/drivers

Re: [Mesa-dev] [PATCH 00/11] i965: UBO pushing for fun and profit?

2017-07-10 Thread Matt Turner
On Thu, Jul 6, 2017 at 5:22 PM, Kenneth Graunke wrote: > Hello, > > This series begins pushing UBOs (rather than resorting to pull loads) > for scalar shaders on Gen7.5+, for the OpenGL driver. Future work is > to hook it up for Vulkan (haven't started), for the vec4 shader stages > (I have about

Re: [Mesa-dev] [PATCH 1/2] swr: switch to using SwrGetInterface api table

2017-07-10 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jul 7, 2017, at 4:25 PM, Tim Rowley wrote: > > Use the SWR rasterizer API through the table returned from > SwrGetInterface rather than referencing the functions directly. > This will allow us to move to a model of having the driver dynamically > load the appro

Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-10 Thread Connor Abbott
On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: > We already had a channel_num system value, which I'm renaming to > subgroup_invocation to match the rest of the new system values. > > Note that while ballotARB(true) will return zeros in the high 32-bits on > systems where gl_SubGroupSizeARB <=

Re: [Mesa-dev] [PATCH] mesa/marshal: fix glNamedBufferData with NULLdata

2017-07-10 Thread Marc Dietrich
Am Montag, 10. Juli 2017, 16:28:28 CEST schrieb Grigori Goronzy: > The semantics are similar to glBufferData. Fixes a crash with VMWare > Player. > > Signed-off-by: Grigori Goronzy Tested-by: Marc Dietrich > --- > src/mesa/main/marshal.c | 17 + > 1 file changed, 13 insertions

Re: [Mesa-dev] [PATCH] i965/blorp: Use the renderbuffer format for clears

2017-07-10 Thread Andres Gomez
Jason, which is the status of this patch? Has it been superseded or discarded? On Mon, 2017-06-26 at 09:01 -0700, Jason Ekstrand wrote: > This fixes the Piglit ARB_texture_views rendering-formats test. > > Cc: "17.1" > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 10 +- > 1 file chang

Re: [Mesa-dev] [PATCH] meta: Fix BlitFramebuffer temp texture setup

2017-07-10 Thread Andres Gomez
Ville, has this patch fallen through the cracks ? On Fri, 2017-06-23 at 14:58 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Pass the correct src coordinates to CopyTexSubImage() > when creating the temporary texture, and also take care to adjust > flipX/Y if the original

Re: [Mesa-dev] [PATCH v3 1/3] spirv: Fix reaching unreachable for compare exchange on images

2017-07-10 Thread Andres Gomez
James, it doesn't seem like this patch has landed in master. Are you in need of review or is it that this has been superseded? Thanks! On Mon, 2017-06-26 at 10:46 +0100, James Legg wrote: > We were hitting the > unreachable("Invalid image opcode") > near the end of vtn_handle_image when par

Re: [Mesa-dev] [PATCH v3 1/3] spirv: Fix reaching unreachable for compare exchange on images

2017-07-10 Thread Jason Ekstrand
On Mon, Jul 10, 2017 at 1:46 PM, Andres Gomez wrote: > James, it doesn't seem like this patch has landed in master. Are you in > need of review or is it that this has been superseded? > Sorry. My fault. Reviewed-by: Jason Ekstrand and pushed. Thanks! > Thanks! > > On Mon, 2017-06-26 at 10

Re: [Mesa-dev] [PATCH 11/11] i965: Use pushed UBO data in the scalar backend.

2017-07-10 Thread Kenneth Graunke
On Monday, July 10, 2017 11:59:45 AM PDT Matt Turner wrote: > On Thu, Jul 6, 2017 at 5:22 PM, Kenneth Graunke wrote: > > This actually takes advantage of the newly pushed UBO data, avoiding > > pull loads. > > > > XXX: quote performance numbers > > --- > > src/intel/compiler/brw_fs.cpp | 35 +

Re: [Mesa-dev] [PATCH v2 09/73] st/mesa: get rid of st_glsl_types

2017-07-10 Thread Eric Anholt
Nicolai Hähnle writes: > From: Nicolai Hähnle > > It's a duplicate of glsl_type::count_attribute_slots. Reviewed-by: Eric Anholt It's a bit unfortunate to duplicate the little wrapper function everywhere, but I know st_glsl_type_size() has been a pain for linking, and deleting this much code

[Mesa-dev] [PATCH 04/10] radeonsi/gfx9: don't read back non-existent register SRBM_STATUS2

2017-07-10 Thread Marek Olšák
From: Marek Olšák It looks like there is no way to monitor SDMA busyness on GFX9. --- src/gallium/drivers/radeon/r600_gpu_load.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_gpu_load.c b/src/gallium/drivers/radeon/r600_gpu_load.c index 3b45

[Mesa-dev] [PATCH 01/10] radeonsi: simplify computation of tessellation offchip buffers

2017-07-10 Thread Marek Olšák
From: Marek Olšák This is overly cautious, but better safe than sorry. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_sta

[Mesa-dev] [PATCH 02/10] ac/surface/gfx9: flags.texture currently refers to TC-compatible HTILE

2017-07-10 Thread Marek Olšák
From: Marek Olšák This should lead to better MSAA performance on GFX9. --- src/amd/common/ac_surface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index a4df595..5f38205 100644 --- a/src/amd/common/ac_surface.c

[Mesa-dev] [PATCH 07/10] util/u_queue: add an option to resize the queue when it's full

2017-07-10 Thread Marek Olšák
From: Marek Olšák Consider the following situation: mtx_lock(mutex); do_something(); util_queue_add_job(...); mtx_unlock(mutex); If the queue is full, util_queue_add_job will wait for a free slot. If the job which is currently being executed tries to lock the mutex, it will be stuck fore

[Mesa-dev] [PATCH 09/10] radeonsi: automatically resize shader compiler thread queues when they are full

2017-07-10 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index e2ec377..4df60b6 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.

[Mesa-dev] [PATCH 05/10] ac/gpu_info: if clock crystal frequency is 0, print an error and set 1

2017-07-10 Thread Marek Olšák
From: Marek Olšák During bring-up, this is often 0. Prevent automatic disablement of ARB_timer_query and demotion of the OpenGL version to 3.2 by setting a non-zero frequency. Print an error message instead. --- src/amd/common/ac_gpu_info.c | 4 1 file changed, 4 insertions(+) diff --git a

[Mesa-dev] [PATCH 10/10] radeonsi/gfx9: add VM fault dmesg parser support

2017-07-10 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index 0d26ce5..06dea61 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH 08/10] radeonsi: prevent a deadlock in util_queue_add_job with too many GL contexts

2017-07-10 Thread Marek Olšák
From: Marek Olšák If the queue is full, util_queue_add_job will wait while bo_fence_lock is held. It pb_slab wants to reuse a buffer, it will lock the pb_slab mutex and try to check BO fence busyness, but it has to wait for bo_fence_lock to get released. Both bo_fence_lock and pb_slab mutex are

[Mesa-dev] [PATCH 03/10] radeonsi: prevent a crash with DBG_CHECK_VM and u_threaded_context

2017-07-10 Thread Marek Olšák
From: Marek Olšák by setting PIPE_CONTEXT_DEBUG in the caller --- src/gallium/drivers/radeonsi/si_pipe.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 8a4bc41..371d337 100644 -

[Mesa-dev] [PATCH 06/10] radeonsi: expose ARB_timer_query unconditionally

2017-07-10 Thread Marek Olšák
From: Marek Olšák clock_crystal_freq is always non-zero now. --- src/gallium/drivers/radeonsi/si_pipe.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 371d337..e2ec377 100644 --- a/

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

2017-07-10 Thread Chad Versace
On Fri 07 Jul 2017, Rob Herring wrote: > On Wed, Jul 5, 2017 at 5:14 PM, Chad Versace wrote: > > On Fri 30 Jun 2017, Rob Herring wrote: > >> Add support for 32-bit RGBX/RGBA formats which are required for Android. > >> > >> The original patch (commit ccdcf91104a5) was reverted (commit > >> c0c6ca4

Re: [Mesa-dev] [PATCH v2 07/73] st/glsl_to_nir: fix the case where NIR clone testing is enabled

2017-07-10 Thread Eric Anholt
Nicolai Hähnle writes: > From: Nicolai Hähnle > > In that case, prog->nir must be assigned at the end. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesk

Re: [Mesa-dev] [RFC 01/22] RFC: egl/x11: Support DRI3 v1.1

2017-07-10 Thread Louis-Francis Ratté-Boulianne
Hi, On Tue, 2017-06-20 at 15:19 +0100, Emil Velikov wrote: > > +for (i = 0; i < count; i++) { > > + modifiers[i] = (uint64_t) mod_parts[i * 2] << 32; > > + modifiers[i] |= (uint64_t) mod_parts[i * 2 + 1] & > > 0xff; > > +} > > + } > >

Re: [Mesa-dev] [PATCH v2 05/73] nir: add nir_lower_uniforms_to_ubo pass

2017-07-10 Thread Eric Anholt
Nicolai Hähnle writes: > From: Nicolai Hähnle > > This is a further lowering of default-block uniform loads that transforms > load_uniform intrinsics into load_ubo intrinsics. This simplies the rest "simplifies" > of the backend. I don't think I'll be able to use it, but this seems like a rea

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

2017-07-10 Thread Chad Versace
On Mon 10 Jul 2017, Chad Versace wrote: > On Fri 07 Jul 2017, Rob Herring wrote: > > On Wed, Jul 5, 2017 at 5:14 PM, Chad Versace > > wrote: > > > On Fri 30 Jun 2017, Rob Herring wrote: > > >> Add support for 32-bit RGBX/RGBA formats which are required for Android. > > >> > > >> The original patc

Re: [Mesa-dev] [PATCH v3 11/16] anv/cmd_buffer: Move aux_usage assignment up

2017-07-10 Thread Jason Ekstrand
On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > For readability, bring the assignment of CCS closer to the assignment of > NONE and MCS. > > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/genX_cmd_buffer.c | 62 ++ > > 1 file changed, 30 inserti

Re: [Mesa-dev] [PATCH v3 03/16] anv/cmd_buffer: Initialize the clear values buffer

2017-07-10 Thread Nanley Chery
On Mon, Jul 10, 2017 at 09:18:56AM -0700, Jason Ekstrand wrote: > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > > > v2: Rewrite functions. > > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 93 ++ > > > > 1 file cha

[Mesa-dev] [PATCH 2/5] svga: s/unsigned/enum tgsi_file_type/

2017-07-10 Thread Brian Paul
--- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index 070d67f..cd4cab4 100644 --- a/src/gallium/drivers/svga/svga_tgsi_vgpu1

[Mesa-dev] [PATCH 1/5] svga: s/unsigned/enum tgsi_semantic/

2017-07-10 Thread Brian Paul
Makes gdb debugging a little nicer. --- src/gallium/drivers/svga/svga_link.c | 2 +- src/gallium/drivers/svga/svga_pipe_streamout.c | 3 ++- src/gallium/drivers/svga/svga_swtnl_state.c| 2 +- src/gallium/drivers/svga/svga_tgsi_vgpu10.c| 11 ++- 4 files changed, 10 inse

[Mesa-dev] [PATCH 4/5] svga: s/unsigned/enum tgsi_swizzle/

2017-07-10 Thread Brian Paul
--- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index d02dbb6..bbaad20 100644 --- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c +++

[Mesa-dev] [PATCH 5/5] svga: s/unsigned/enum tgsi_texture_type/

2017-07-10 Thread Brian Paul
--- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index bbaad20..d29ac28 100644 --- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c +++

[Mesa-dev] [PATCH 3/5] svga: s/unsigned/enum tgsi_interpolate_mode/

2017-07-10 Thread Brian Paul
And s/unsigned/enum tgsi_interpolate_loc/ --- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index cd4cab4..d02dbb6 100644 --- a/src/gallium

Re: [Mesa-dev] [PATCH v3 05/16] anv/cmd_buffer: Restrict fast clears in the GENERAL layout

2017-07-10 Thread Nanley Chery
On Mon, Jul 10, 2017 at 09:28:05AM -0700, Jason Ekstrand wrote: > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > > > v2: Remove ::first_subpass_layout assertion (Jason Ekstrand). > > v3: Allow some fast clears in the GENERAL layout. > > > > Signed-off-by: Nanley Chery > > --- > > src/in

Re: [Mesa-dev] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

2017-07-10 Thread Francisco Jerez
Ian Romanick writes: > From: Ian Romanick > > On NV20 (and probably also on earlier NV GPUs that lack > GL_ARB_texture_border_clamp) fixes the following piglit tests: > > gl-1.0-beginend-coverage gltexparameter[if]{v,} > push-pop-texture-state > texwrap 1d > texwrap 1d proj >

[Mesa-dev] [Bug 101668] Counter-Strike: Global Offense - Everything is purple

2017-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101668 --- Comment #4 from Ernst Sjöstrand --- I saw this too. The next time Padoka updates LLVM that fix should come in, let's see if that fixes it. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

[Mesa-dev] [Bug 101668] Counter-Strike: Global Offense - Everything is purple

2017-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101668 Ernst Sjöstrand changed: What|Removed |Added CC||ern...@gmail.com -- You are receivin

Re: [Mesa-dev] [PATCH 5/5] svga: s/unsigned/enum tgsi_texture_type/

2017-07-10 Thread Charmaine Lee
Series looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, July 10, 2017 2:50:25 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 5/5] svga: s/unsigned/enum tgsi_texture_type/ --- src/gallium/driver

Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-10 Thread Matt Turner
On Mon, Jul 10, 2017 at 1:10 PM, Connor Abbott wrote: > On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: >> We already had a channel_num system value, which I'm renaming to >> subgroup_invocation to match the rest of the new system values. >> >> Note that while ballotARB(true) will return zeros

Re: [Mesa-dev] [PATCH v3 16/16] anv: Predicate fast-clear resolves

2017-07-10 Thread Jason Ekstrand
On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > Image layouts only let us know that an image *may* be fast-cleared. For > this reason we can end up with redundant resolves. Testing has shown > that such resolves can measurably hurt performance and that predicating > them can avoid the pena

Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-10 Thread Connor Abbott
On Mon, Jul 10, 2017 at 3:50 PM, Matt Turner wrote: > On Mon, Jul 10, 2017 at 1:10 PM, Connor Abbott wrote: >> On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: >>> We already had a channel_num system value, which I'm renaming to >>> subgroup_invocation to match the rest of the new system value

Re: [Mesa-dev] [PATCH v3 06/16] anv/gpu_memcpy: Add a lighter-weight GPU memcpy function

2017-07-10 Thread Nanley Chery
On Mon, Jul 10, 2017 at 09:35:25AM -0700, Jason Ekstrand wrote: > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > > > We'll be performing a GPU memcpy in more places to copy small amounts of > > data. Add an alternate function that thrashes less state. > > > > v2: > > - Make a new function

Re: [Mesa-dev] [PATCH 5/5] svga: s/unsigned/enum tgsi_texture_type/

2017-07-10 Thread Neha Bhende
For the series, Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Monday, July 10, 2017 2:50:25 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 5/5] svga: s/unsigned/enum tgsi_texture_type/ --- src/gallium/d

Re: [Mesa-dev] [PATCH] i965/blorp: Use the renderbuffer format for clears

2017-07-10 Thread Jason Ekstrand
On Mon, Jul 10, 2017 at 1:34 PM, Andres Gomez wrote: > Jason, which is the status of this patch? Has it been superseded or > discarded? > Still awaiting review. > On Mon, 2017-06-26 at 09:01 -0700, Jason Ekstrand wrote: > > This fixes the Piglit ARB_texture_views rendering-formats test. > > >

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-10 Thread Wu, Zhongmin
Hi Emil and Yogesh Thank you for your comments, and thanks Yogesh for giving the detailed explanations And according to the document of Android below (https://source.android.com/devices/graphics/arch-bq-gralloc): Recent Android devices support the sync framework, which enables the system to

[Mesa-dev] [PATCH] nv50/ir: fix threads calculation for non-compute shaders

2017-07-10 Thread Ilia Mirkin
We were using the "cp" union fields, which are only valid for compute shaders. The threads calculation affects the availabel GPRs, so just pick a small number for other shader types to avoid limiting available registers. Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- src/ga

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-10 Thread Wu, Zhongmin
By the way, For cancelBuffer, sorry I forget such function, thanks for notice. It should also pass the same fence fd as the queuebuffer. And Yogesh, you mentioned the gallium, is it another platform supported by mesa ? I am sorry I have no idea about this, could you please help to check t

[Mesa-dev] [PATCH] radv: allow clear merging for depth/stencil with no care stencil

2017-07-10 Thread Dave Airlie
From: Dave Airlie Some of the Sascha Willems demos pick a D32/S8 format for the depth buffer, then do a LOAD_OP_CLEAR/LOAD_OP_DONT_CARE on it, which means we don't get to merge the undefined->depth and clear htile transitions. This add the stencil aspect to the pending clears if there is a depth

  1   2   >