20.06.2017, 08:34, "Constantine Kharlamov" :
> This was discussed on IRC, there was much confusion, and overall there was a
> belief like the bug in some place other. A few minutes ago I was writing a
> follow-up in mail because I'll have trouble replying today.
>
> And… for writing a reply I fou
On 19 June 2017 at 22:39, Ian Romanick wrote:
> On 06/19/2017 04:01 AM, Eric Engestrom wrote:
>> Also, make that table const, since no-one is supposed to modify it anyway.
>
> I certainly like this, but I'm not sure we can use designated
> initializers in common Mesa code due to MSVC. Brian?
>
Sh
On 19 June 2017 at 00:49, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom
Reviewed-by: Emil Velikov
Couple of random thoughts below.
> + bool invalidate_available;
> + bool swap_available;
These two could be nuked since X and all the xf86-vid
Reviewed-by: Samuel Pitoiset
On 06/20/2017 07:51 AM, Dave Airlie wrote:
From: Dave Airlie
I just noticed a warning with a non-debug build, but really
this could all be one line, and I'm not even 100% the assert
makes sense here.
---
src/mesa/state_tracker/st_texture.c | 5 +
1 file cha
On 19 June 2017 at 00:49, Eric Engestrom wrote:
> Same as the previous commit, but this one was split out because it's
> a bit more complicated: this field is given as a pointer to a function,
> so the function had to be changed as well, and the function was use in
> a bunch of places, which neede
On Fri, Jun 16, 2017 at 10:17:14AM -0700, Nanley Chery wrote:
> On Tue, Jun 13, 2017 at 05:50:08PM +0300, Topi Pohjolainen wrote:
> > Signed-off-by: Topi Pohjolainen
> > ---
> > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 16
> > 1 file changed, 16 insertions(+)
> >
> > diff
On 16 June 2017 at 00:55, Eric Engestrom wrote:
> dri2_conf represents a similar config (which shouldn't be counted)
> if its config has the ID EGL_DONT_CARE.
>
> Reported-by: Liu Zhiquan
> Signed-off-by: Eric Engestrom
> ---
>
> Re-implemented Liu Zhiquan's fix, without all the unnecessary chan
Omg, nvm, it was a copy-paste error (the "input[i]"), I should've written a
follow up mail. The real problem remains to be seen.
Alright, later then.
20.06.2017, 10:04, "Constantine Kharlamov" :
> 20.06.2017, 08:34, "Constantine Kharlamov" :
>> This was discussed on IRC, there was much confusio
On 19 June 2017 at 20:52, Chad Versace wrote:
> On Fri 16 Jun 2017, Christian Gmeiner wrote:
>> 2017-06-16 14:54 GMT+02:00 Emil Velikov :
>> > On 15 June 2017 at 21:47, Robert Foss wrote:
>> >> From: Tomeu Vizoso
>> >>
>> >> Signed-off-by: Robert Foss
>> >> ---
>> >> src/gallium/drivers/etnavi
On 19 June 2017 at 20:46, Chad Versace wrote:
> On Thu 15 Jun 2017, Gurchetan Singh wrote:
>> Emil, would you be fine with leaving the image extension in dri2.c but still
>> adding it as a drisw extension? That solution would look like:
>>
>> [1]https://patchwork.freedesktop.org/patch/154807/
>
>
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/radeonsi/si_descriptors.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c
b/src/gallium/drivers/radeonsi/si_descriptors.c
index 1e92a70dc7c..a7031ec3632 100644
--- a/src/ga
> -Original Message-
> From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
> Sent: Thursday, June 15, 2017 9:59 PM
> To: Liu, Zhiquan
> Cc: ML mesa-dev ; Long, Zhifang
> ; Rob Herring ; Tomasz Figa
>
> Subject: Re: [PATCH] egl/android: config id increase one by one
>
> On 12 January 2
On 17 June 2017 at 03:37, Chad Versace wrote:
> Many Android apps (such as Google's official NDK GLES2 example app), and
> even portions the core framework code (such as SystemServiceManager in
> Nougat), incorrectly choose their EGLConfig. They neglect to match the
> EGLConfig's EGL_NATIVE_VISUA
On 17 June 2017 at 03:37, Chad Versace wrote:
> No behavioral change. Just a cleanup.
>
> Post-patch, we no longer modify the same array on each iteration of the
> inner loop of droid_add_configs_for_visuals(). Instead, we just declare
> the array as const inside the inner loop.
> ---
> src/egl/d
Quoting Kenneth Graunke (2017-06-20 00:33:35)
> On Monday, June 19, 2017 3:55:01 AM PDT Chris Wilson wrote:
> > If we need to force a cache domain transition (e.g. a buffer was in the
> > CPU domain and we want to access it via WC) then we need to trigger a
> > clflush. This overrides the use of MA
On 19 June 2017 at 18:51, Lepton Wu wrote:
> The original dri2_format_to_pipe_format function just misses case branch
> for __DRI_IMAGE_FORMAT_XBGR. I discovered this when debugging one google
> map crash inside emulator.
>
> Signed-off-by: Lepton Wu
> ---
> src/gallium/state_trackers/dri/dr
Hi Christian,
this one is a logical follow-up to my piglit fixes series. Since the
other patches have landed, it would be nice if you could also land this
one.
Regards,
Lucas
Am Montag, den 05.06.2017, 21:11 +0200 schrieb Lucas Stach:
> Same as with the colormasks, the blend color needs to be sw
Hi Lepton,
On 19 June 2017 at 18:51, Lepton Wu wrote:
> The original dri2_format_to_pipe_format function just misses case branch
> for __DRI_IMAGE_FORMAT_XBGR. I discovered this when debugging one google
> map crash inside emulator.
>
> Signed-off-by: Lepton Wu
> ---
> src/gallium/state_tra
On 06/20/2017 07:17 AM, Thomas Hellstrom wrote:
On 06/20/2017 05:09 AM, Michel Dänzer wrote:
On 20/06/17 03:00 AM, Thomas Hellstrom wrote:
On 06/19/2017 07:44 PM, Thomas Hellstrom wrote:
On 06/19/2017 07:26 PM, Eric Anholt wrote:
Thomas Hellstrom writes:
Applications calling glXSwapBuffers
Hi Daniel,
On 8 June 2017 at 19:43, Daniel Stone wrote:
> Hi,
> With full support for modifiers in DRIimage, this patch series adds
> support for fully plumbing them through X11. A patchset proposing
> an extension to DRI3 to support multiple planes and modifiers can
> be found here:
> https://li
Reviewed-by: Marek Olšák
Marek
On Tue, Jun 20, 2017 at 7:51 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> I just noticed a warning with a non-debug build, but really
> this could all be one line, and I'm not even 100% the assert
> makes sense here.
> ---
> src/mesa/state_tracker/st_texture.c
On 16.06.2017 21:08, Karol Herbst wrote:
v2: use str_match_no_case to fix _SAT_PRECISE detection
Signed-off-by: Karol Herbst
---
src/gallium/auxiliary/tgsi/tgsi_text.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.
With Roland's suggestion, patches 6 & 7:
Reviewed-by: Nicolai Hähnle
On 16.06.2017 21:08, Karol Herbst wrote:
Signed-off-by: Karol Herbst
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tg
Reviewed-by: Marek Olšák
Marek
On Tue, Jun 20, 2017 at 10:24 AM, Samuel Pitoiset
wrote:
> Signed-off-by: Samuel Pitoiset
> ---
> src/gallium/drivers/radeonsi/si_descriptors.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_descriptor
If the user triggers an implicit batch flush while holding access to a
CPU mapped buffer, that mmapping will be invalidated by the kernel for
non-LLC devices. (The kernel when executing a batch will change the
cache domain of the buffers in that batch, which for non-LLC CPU access
will cause that b
If we need to force a cache domain transition (e.g. a buffer was in the
CPU domain and we want to access it via WC) then we need to trigger a
clflush. This overrides the use of MAP_ASYNC as we call into the kernel
to change domains on the whole object.
v2: ASYNC cpu mmapings (on !llc) are not perm
For the series:
Reviewed-by: Marek Olšák
Marek
On Tue, Jun 20, 2017 at 3:50 AM, Brian Paul wrote:
> A common user error is to call glDrawRangeElements() with the 'end'
> argument being one too large. If we use the vbuf module to translate
> some vertex attributes this error can cause us to re
On 19.06.2017 20:53, Marek Olšák wrote:
From: Marek Olšák
First this happens:
1) amdgpu_cs_flush (lock bo_fence_lock)
-> amdgpu_add_fence_dependency
-> os_wait_until_zero (wait for submission_in_progress) - WAITING
2) amdgpu_bo_create
-> pb_cache_reclaim_buffer (lock pb_cache::mut
Supposedly we were keeping a reference count for the number of users of
a mapping so that we could use valgrind to detect access to the map
outside of the valid section. However, we were incrementing the counter
only when first creating the cached mapping but decrementing on every
unmap. The bo->ma
On Tue, Jun 20, 2017 at 12:22 PM, Nicolai Hähnle wrote:
> On 16.06.2017 21:08, Karol Herbst wrote:
>>
>> v2: use str_match_no_case to fix _SAT_PRECISE detection
>>
>> Signed-off-by: Karol Herbst
>> ---
>> src/gallium/auxiliary/tgsi/tgsi_text.c | 17 ++---
>> 1 file changed, 14 inse
Hi Lucas,
> this one is a logical follow-up to my piglit fixes series. Since the
> other patches have landed, it would be nice if you could also land this
> one.
>
thanks for the gentle ping :) Will 'process' it in the evening (and
will also have a
look at the other open patches on the ml).
gree
In 5f2fe9302c is_geminilake was introduced for the differenciate
broxton from geminilake. Unfortunately I failed as verifying that
is_broxton is throughout the code base to mean Gen9lp.
Fixes: 5f2fe9302c ("intel: common: add flag to identify platforms by name")
Signed-off-by: Lionel Landwerlin
--
_mesa_lookup_vao() already returns NULL if id is zero.
Signed-off-by: Samuel Pitoiset
---
src/mesa/main/arrayobj.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c
index 82c00fbe826..7988a225baf 100644
--- a/src/mesa/ma
On Fri, Jun 09, 2017 at 12:27:35PM +0200, Christian Gmeiner wrote:
> Import the etnaviv header changes from kernel commits x
>
> The drm_etnaviv_gem_submit structure was extended to include performance
> monitor requests. Also two new ioctls got added to readout performance
> monitor domains a
Am Dienstag, den 20.06.2017, 13:21 +0200 schrieb Christian Gmeiner:
> Hi Lucas,
>
> > this one is a logical follow-up to my piglit fixes series. Since the
> > other patches have landed, it would be nice if you could also land this
> > one.
> >
>
> thanks for the gentle ping :) Will 'process' it i
Hi,
This fixes the texture decompression path for i965 that this
uncommitted patch of mine broke:
https://cgit.freedesktop.org/~mareko/mesa/commit/?h=mesa-cpu-optz&id=b7ae4ddc15507d13c7019426dd4800872e211600
It was the last blocker for pushing my mega patch series that
decreases CPU overhead for
From: Marek Olšák
_mesa_update_state will no longer recompute Width/Height if the framebuffer
is complete. We now rely on the FBO completeness check to do it.
The only code that needs to be fixed seems to be this one.
---
src/mesa/drivers/common/meta.c | 5 +
1 file changed, 5 insertions(+)
Michel, Eric, others
Do you know what's stopping dri3 from flipping to the fake front instead
of copying? Like below?
The fake front will of course be "busy" until the server completes the
present, but that doesn't really stop us from front rendering to it or
reading from it if so desired?
On Fri, Jun 09, 2017 at 12:27:36PM +0200, Christian Gmeiner wrote:
> Query all domains and their signals and provide it this information
> via struct etna_perfmon and the corresponding api functions.
Comments in-line.
> Signed-off-by: Christian Gmeiner
> ---
> etnaviv/Makefile.sources | 1
On Fri, Jun 09, 2017 at 12:27:37PM +0200, Christian Gmeiner wrote:
> Add etna_cmd_stream_perf(..) to submit perform requests.
> Userspace can submit pmrs via submit ioctl to sample perfmon
> signals.
Comment in-line.
> Signed-off-by: Christian Gmeiner
> ---
> etnaviv/etnaviv-symbol-check | 1 +
On Fri, Jun 09, 2017 at 12:34:49PM +0200, Christian Gmeiner wrote:
> It could be useful to get the number of emited resolve operations when
> doing driver optimizations.
Nothing to add, seems useful and correct.
(though RS operations are better than falling back on the software blit path -
should
On Tue, May 30, 2017 at 12:50:07PM +0200, Philipp Zabel wrote:
> Before resolving a rendertarget or a depth/stencil resource into a
> texture, flush both the color cache and the depth cache together.
>
> It is unclear whether this is necessary for the following stall to
> work properly, or whether
On Mon, Jun 05, 2017 at 09:11:02PM +0200, Lucas Stach wrote:
> Same as with the colormasks, the blend color needs to be swizzled according
> to the rendertarget format.
Yes, indeed.
Reviewed-by: Wladimir J. van der Laan
> Signed-off-by: Lucas Stach
> ---
> src/gallium/drivers/etnaviv/etnaviv_b
From: Marek Olšák
The kernel sort of does the same thing with fences.
v2: do emit partial flushes on SI
---
src/gallium/drivers/radeonsi/si_hw_context.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c
b/src/gallium
Hi Daniel,
Top-level comments
Build POV:
- Having the XCB_DRI3_.*_VERSION compile guards is Ok for now. But
let's drop those as get a xcb release.
We dont want to be in cases where Mesa is built w/o DRI3 1.1 support
and one spends time debugging why "nothing works".
Couple of ideas/questions fro
On 06/19/2017 03:39 PM, Ian Romanick wrote:
On 06/19/2017 04:01 AM, Eric Engestrom wrote:
Also, make that table const, since no-one is supposed to modify it anyway.
I certainly like this, but I'm not sure we can use designated
initializers in common Mesa code due to MSVC. Brian?
They should
Reviewed-by: Alejandro Piñeiro
On 20/06/17 15:13, Samuel Pitoiset wrote:
> _mesa_lookup_vao() already returns NULL if id is zero.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/mesa/main/arrayobj.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/src/mesa/main/arra
> -Original Message-
> On Thu 15 Jun 2017, Eric Engestrom wrote:
> > On Thursday, 2017-06-15 16:17:20 -0400, Rob Clark wrote:
> > > On Thu, Jun 15, 2017 at 1:17 PM, Tapani Pälli
> wrote:
> > > > On 06/15/2017 07:57 PM, Rob Clark wrote:
> > > >
> > > > On Thu, Jun 15, 2017 at 12:04 PM, Tap
From: Emil Velikov
Function cannot fail and always returns true.
Signed-off-by: Emil Velikov
---
We could even inline it in the header if people prefer.
---
src/egl/drivers/dri2/egl_dri2.c | 16 +++-
src/egl/drivers/dri2/platform_android.c | 5 +
src/egl/drivers/dri2
From: Emil Velikov
The function _eglError() already explicitly returns EGL_FALSE,
explicitly to simplify the callers. Make use of it.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 72 +++-
src/egl/drivers/dri2/platform_android.c | 6 +--
Hey Emil,
A few bits from me, since this is actually lfrb's code ...
On 20 June 2017 at 15:19, Emil Velikov wrote:
> Top-level comments
>
> Build POV:
> - Having the XCB_DRI3_.*_VERSION compile guards is Ok for now. But
> let's drop those as get a xcb release.
> We dont want to be in cases where
On Tuesday, 2017-06-20 08:24:42 -0600, Brian Paul wrote:
> On 06/19/2017 03:39 PM, Ian Romanick wrote:
> > On 06/19/2017 04:01 AM, Eric Engestrom wrote:
> > > Also, make that table const, since no-one is supposed to modify it anyway.
> >
> > I certainly like this, but I'm not sure we can use desig
On Sun, Jun 18, 2017 at 07:07:51PM -0700, Ian Romanick wrote:
> From: Ian Romanick
I have the same patch in my tree :)
For the i915 parts of the series:
Reviewed-by: Ville Syrjälä
>
> Signed-off-by: Ian Romanick
> ---
> src/mesa/drivers/dri/i915/intel_mipmap_tree.c | 5 ++---
> src/mesa/dr
I've been doing this inside of vc4, but it seems like a pass that may be
useful for other drivers (Intel has a related path for pre-gen6 with MRT,
and freedreno had a TGSI path for it at one point).
This required defining a common enum for the standard comparison
functions, but other lowering pass
On Tuesday, 2017-06-20 16:04:47 +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> Function cannot fail and always returns true.
>
> Signed-off-by: Emil Velikov
Both patches are:
Reviewed-by: Eric Engestrom
> ---
> We could even inline it in the header if people prefer.
Good idea. I just c
Doom shipped with a broken version of GLSLang which handles samplers as
function arguments in a way that isn't spec-compliant. In particular,
it creates a temporary local sampler variable and copies the sampler
into it. While Dave has had a hack patch out for a while that gets it
working, we've n
From: Tomeu Vizoso
Signed-off-by: Robert Foss
Reviewed-by: Tapani Pälli
---
Changes since v1:
Emil Velikov
- Switch return statement to unreachable call
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/etnaviv/etnav
Consider the following RT attachment order:
1. Attach surfaces attachments 0 & 1, and render with them
2. Detach 0 & 1
3. Re-attach 0 & 1 to different surfaces
4. Render with the new attachment
The definition of a tile being resolved is that local changes have been
flushed out to the surface, henc
On 06/20/2017 07:24 AM, Brian Paul wrote:
> On 06/19/2017 03:39 PM, Ian Romanick wrote:
>> On 06/19/2017 04:01 AM, Eric Engestrom wrote:
>>> Also, make that table const, since no-one is supposed to modify it
>>> anyway.
>>
>> I certainly like this, but I'm not sure we can use designated
>> initiali
On Mon, Jun 19, 2017 at 7:07 PM, Lin, Johnson wrote:
> Kristian,
>
> Thanks for the review comments. By my tests, UYVY buffer can be sampled and
> rendered correctly. So there is no swap of U/V channel here.
Just saying "the test pass, all is fine" isn't good enough. See below.
>
> -Origina
On 06/20/2017 06:29 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> _mesa_update_state will no longer recompute Width/Height if the framebuffer
> is complete. We now rely on the FBO completeness check to do it.
>
> The only code that needs to be fixed seems to be this one.
I just started it runn
On Tue 20 Jun 2017, Dave Airlie wrote:
> I'm not sure why avoiding drmIoctl is even a thing, there are plenty
> of huge optimisation opportunities, this just seems like a feel good
> pointless microptimisation.
There is very little usage of libdrm remaining in i965. If the last bit
were dropped,
On 06/20/2017 06:13 AM, Samuel Pitoiset wrote:
> _mesa_lookup_vao() already returns NULL if id is zero.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/mesa/main/arrayobj.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arr
On Tuesday, 2017-06-20 09:47:30 -0700, Ian Romanick wrote:
> On 06/20/2017 07:24 AM, Brian Paul wrote:
> > On 06/19/2017 03:39 PM, Ian Romanick wrote:
> >> On 06/19/2017 04:01 AM, Eric Engestrom wrote:
> >>> Also, make that table const, since no-one is supposed to modify it
> >>> anyway.
> >>
> >>
On 06/20/2017 05:23 AM, Lionel Landwerlin wrote:
> In 5f2fe9302c is_geminilake was introduced for the differenciate
> broxton from geminilake. Unfortunately I failed as verifying that
> is_broxton is throughout the code base to mean Gen9lp.
It looks like this replaces every instances of devinfo->i
On Tuesday, 2017-06-20 09:56:25 -0700, Chad Versace wrote:
> On Tue 20 Jun 2017, Dave Airlie wrote:
>
> > I'm not sure why avoiding drmIoctl is even a thing, there are plenty
> > of huge optimisation opportunities, this just seems like a feel good
> > pointless microptimisation.
>
> There is very
On Tue 20 Jun 2017, Marathe, Yogesh wrote:
> > From the framework's perspective, at least from the comments in
> > aosp://system/core/include/system/window.h [1], it's legal to call
> > ANativeWindow::queueBuffer with fenceFd=-1 if implicit sync is enabled.
> > And, as far as I know, implicity syn
From: Marek Olšák
It seems to work now.
---
src/gallium/drivers/radeon/r600_texture.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_texture.c
b/src/gallium/drivers/radeon/r600_texture.c
index f74bbce..d68587b 100644
--- a/src/gallium/drivers/radeon/r600_
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_cp_dma.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c
b/src/gallium/drivers/radeonsi/si_cp_dma.c
index 9505d62..e737519 100644
--- a/src/gallium/drivers/radeonsi/si_cp_dm
From: Marek Olšák
The closed Vulkan driver doesn't do it either.
Also remove some old comments that aren't useful.
---
src/gallium/drivers/radeonsi/si_state_draw.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c
b/
From: Marek Olšák
I reproduced this bug on Polaris11 and Raven.
I can't get this bug on Fiji. The reason might be that Fiji doesn't use
2D tiling for the test due to higher 2D tiling alignment requirements.
Fixes piglit: spec@ext_framebuffer_object@fbo-fast-clear
---
src/gallium/drivers/radeon
On Mon 19 Jun 2017, Chris Wilson wrote:
> Quoting Chad Versace (2017-06-19 19:42:16)
> > On Mon 12 Jun 2017, Chris Wilson wrote:
> > > brw_emit_mi_flush(brw);
> > >
> > > switch (fence->type) {
> > > @@ -335,6 +363,8 @@ brw_gl_fence_sync(struct gl_context *ctx, struct
> > > gl_sync_objec
On 06/20/2017 06:57 PM, Ian Romanick wrote:
On 06/20/2017 06:13 AM, Samuel Pitoiset wrote:
_mesa_lookup_vao() already returns NULL if id is zero.
Signed-off-by: Samuel Pitoiset
---
src/mesa/main/arrayobj.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/mesa/
From: Ville Syrjälä
Unlike the older gen2 hardware, gen3 performs perspective
correct interpolation even for the primary/secondary colors.
To do that it naturally needs us to emit W for the vertices.
Currently we emit W only when at least one texture coordinate
set gets emitted. This means the i
On Tue 20 Jun 2017, Eric Engestrom wrote:
> On Tuesday, 2017-06-20 09:56:25 -0700, Chad Versace wrote:
> > On Tue 20 Jun 2017, Dave Airlie wrote:
> >
> > > I'm not sure why avoiding drmIoctl is even a thing, there are plenty
> > > of huge optimisation opportunities, this just seems like a feel goo
On Tue 20 Jun 2017, Emil Velikov wrote:
> On 17 June 2017 at 03:37, Chad Versace wrote:
> > Many Android apps (such as Google's official NDK GLES2 example app), and
> > even portions the core framework code (such as SystemServiceManager in
> > Nougat), incorrectly choose their EGLConfig. They neg
On Tue 20 Jun 2017, Emil Velikov wrote:
> On 17 June 2017 at 03:37, Chad Versace wrote:
> > No behavioral change. Just a cleanup.
> >
> > Post-patch, we no longer modify the same array on each iteration of the
> > inner loop of droid_add_configs_for_visuals(). Instead, we just declare
> > the arra
> -Original Message-
> From: Chad Versace [mailto:chadvers...@chromium.org]
> On Tue 20 Jun 2017, Marathe, Yogesh wrote:
>
> > > From the framework's perspective, at least from the comments in
> > > aosp://system/core/include/system/window.h [1], it's legal to call
> > > ANativeWindow::que
On 20/06/17 18:05, Ian Romanick wrote:
On 06/20/2017 05:23 AM, Lionel Landwerlin wrote:
In 5f2fe9302c is_geminilake was introduced for the differenciate
broxton from geminilake. Unfortunately I failed as verifying that
is_broxton is throughout the code base to mean Gen9lp.
It looks like this re
On 20 June 2017 18:22:32 BST, Chad Versace wrote:
>On Tue 20 Jun 2017, Eric Engestrom wrote:
>> On Tuesday, 2017-06-20 09:56:25 -0700, Chad Versace wrote:
>> > On Tue 20 Jun 2017, Dave Airlie wrote:
>> >
>> > > I'm not sure why avoiding drmIoctl is even a thing, there are
>plenty
>> > > of huge o
Inline function SWR_MULTISAMPLE_POS::PrecalcSampleData() was missing
definition. Include definition in core/state_funcs.h.
Fixes windows build.
---
src/gallium/drivers/swr/swr_state.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/swr/swr_state.cpp
b/src/gallium/drive
From: Rob Herring
The function getprogname() is available on Android, since it reuses
various BSD solutions C runtime.
Signed-off-by: Rob Herring
Reviewed-by: Tapani Pälli
Reviewed-by: Emil Velikov
---
Changes since v1:
Emil Velikov
- Added commit msg
- Dropped whitepace change
src
From: Tomeu Vizoso
Signed-off-by: Robert Foss
Reviewed-by: Tapani Pälli
---
Changes since v1:
Emil Velikov
- Replaced return with unreachable call
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_com
This series enables etnaviv and imx for the android platform.
This is done through updating the Android build scripts.
Rob Herring (3):
gallium: os_process fixes for Android
gbm: add XBGR support for dumb buffers
android: add etnaviv driver build support
Tomeu Vizoso (2):
etnaviv: Ad
From: Rob Herring
Add GBM_FORMAT_XBGR format support which is needed for Android.
Signed-off-by: Rob Herring
Reviewed-by: Tapani Pälli
Reviewed-by: Daniel Stone
Reviewed-by: Emil Velikov
---
Changes since v1:
Emil Velikov
- Added commit msg
src/gbm/backends/dri/gbm_dri.c | 2 +-
From: Rob Herring
Add etnaviv to Android makefiles.
Signed-off-by: Rob Herring
Reviewed-by: Tapani Pälli
---
Changes since v1:
Tapani Pälli
- Remove copy-pasta
Emil Velikov
- Remove libmesa_loader inclusion
- Remove copy-pasta
- Remove spurious include
- Fix C_SOURCES inc
From: Tomeu Vizoso
Signed-off-by: Tomeu Vizoso
Reviewed-by: Tapani Pälli
---
Changes since v1:
Emil Velikov
- Fix C_SOURCES include
- Fix GALLIUM_LIBS assignment
Android.mk| 5 +++--
src/gallium/Android.mk| 1 +
src/gallium/winsys/imx/drm
On 06/20/2017 10:37 AM, Lionel Landwerlin wrote:
> On 20/06/17 18:05, Ian Romanick wrote:
>> On 06/20/2017 05:23 AM, Lionel Landwerlin wrote:
>>> In 5f2fe9302c is_geminilake was introduced for the differenciate
>>> broxton from geminilake. Unfortunately I failed as verifying that
>>> is_broxton is
From: Marek Olšák
This reverts commit 6b6fed3a3c81c2b0d319ef121df20a0dc914705f.
---
src/gallium/drivers/radeonsi/si_shader.c| 8 ++--
src/gallium/drivers/radeonsi/si_shader.h| 3 +--
src/gallium/drivers/radeonsi/si_state_shaders.c | 8 ++--
3 files changed, 5 insertions(+
Reviewed-by: Ian Romanick
On 06/20/2017 10:22 AM, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Unlike the older gen2 hardware, gen3 performs perspective
> correct interpolation even for the primary/secondary colors.
> To do that it naturally needs us to emit W for the vertices
From: Marek Olšák
sizeof(struct si_shader_key):
Before reverting the 2 commits: 120 bytes
After reverting the 2 commits: 128 bytes
With #pragma pack: 107 bytes
I'm not sure if memcmp with a byte-aligned size is a good idea.
---
src/gallium/drivers/radeonsi/si_shader.h | 8
1 file
From: Marek Olšák
This reverts commit 7b2240ac9ce3ba9bd86f4ae8aac53af8878c0b10.
---
src/gallium/drivers/radeonsi/si_shader.c| 8 +++-
src/gallium/drivers/radeonsi/si_shader.h| 3 +--
src/gallium/drivers/radeonsi/si_state_shaders.c | 5 ++---
3 files changed, 6 insertions(+),
On Tuesday, June 20, 2017 10:05:26 AM PDT Ian Romanick wrote:
> On 06/20/2017 05:23 AM, Lionel Landwerlin wrote:
> > In 5f2fe9302c is_geminilake was introduced for the differenciate
> > broxton from geminilake. Unfortunately I failed as verifying that
> > is_broxton is throughout the code base to m
The Intel CI system doesn't report anything wrong with your branch.
Though, as I told you offline, this breaks DOW3, I'm bisecting.
Samuel.
On 06/20/2017 03:29 PM, Marek Olšák wrote:
Hi,
This fixes the texture decompression path for i965 that this
uncommitted patch of mine broke:
https://cgit
On Monday, June 19, 2017 9:38:04 PM PDT Dave Airlie wrote:
> From: Dave Airlie
>
> Just noticed in passing.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/common/ac_nir_to_llvm.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b
Reviewed-by: Tim Rowley
mailto:timothy.o.row...@intel.com>>
On Jun 20, 2017, at 12:53 PM, George Kyriazis
mailto:george.kyria...@intel.com>> wrote:
Inline function SWR_MULTISAMPLE_POS::PrecalcSampleData() was missing
definition. Include definition in core/state_funcs.h.
Fixes windows build.
-
You need to update _mesa_uniform_handle() as well because the handles
won't be propagated if you don't do that.
With that fixed, patch is:
Reviewed-by: Samuel Pitoiset
On 06/12/2017 06:55 PM, Marek Olšák wrote:
From: Marek Olšák
---
src/mesa/main/shaderapi.c | 8 ++--
src
On Tuesday, June 20, 2017 5:23:00 AM PDT Lionel Landwerlin wrote:
> In 5f2fe9302c is_geminilake was introduced for the differenciate
> broxton from geminilake. Unfortunately I failed as verifying that
> is_broxton is throughout the code base to mean Gen9lp.
>
> Fixes: 5f2fe9302c ("intel: common: a
I've been told by Pierre that there is an update, but it just hasn't
been pushed out yet. He'd know better when it's supposed to be
released.
On Tue, Jun 20, 2017 at 9:11 AM, Jason Ekstrand wrote:
> Doom shipped with a broken version of GLSLang which handles samplers as
> function arguments in a
On Mon, Jun 19, 2017 at 04:19:36PM -0700, Jason Ekstrand wrote:
> On Wed, Jun 14, 2017 at 3:06 PM, Nanley Chery wrote:
>
> > On Wed, Jun 14, 2017 at 09:32:22AM +0200, Iago Toral wrote:
> > > On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote:
> > > > For 3D image subresources undergoing a layo
1 - 100 of 167 matches
Mail list logo
