[Mesa-dev] [PATCH] radv: set PERF_MOD in sample state like radeonsi.

2017-04-28 Thread Dave Airlie
From: Dave Airlie This just aligns the code with radeonsi. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index edc62c3..1f7b87f 100644 --- a/src/amd/vulk

Re: [Mesa-dev] [PATCH v2] docs: add release calendar page and references to it

2017-04-28 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Thu, 2017-04-27 at 16:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > Add a page that has information which release is expected when and > associated information. > > Reference to it from the "Releasing process" and "Release notes" pages. > > v2:

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

2017-04-28 Thread Marc Dietrich
Hi Constantine, Am Donnerstag, 27. April 2017, 21:04:37 CEST schrieb Constantine Kharlamov: > Please, could you try this patch. The change is: I'm setting dirty_zsbuf in > r600_bind_blend_state_internal() as well. It was the difference between > radeonsi and r600 for CB updates, and my guess is,

Re: [Mesa-dev] [RFC 0/1] Port dri2GetBuffersWithFormat/dri2GetBuffers to XCB

2017-04-28 Thread gregory hainaut
On Thu, 27 Apr 2017 17:11:30 +0900 Michel Dänzer wrote: > On 26/04/17 07:06 PM, Gregory Hainaut wrote: > > On 4/26/17, Michel Dänzer wrote: > [...] > [...] > [...] > > > > I didn't test it (yet). But I think it is safe to call XCB from > > various threads. However if one thread use X

Re: [Mesa-dev] [PATCH 03/18] anv/allocator: Convert the state stream to pull from a state pool

2017-04-28 Thread Juan A. Suarez Romero
On Thu, 2017-04-27 at 20:30 -0700, Jason Ekstrand wrote: > On Wed, Apr 26, 2017 at 9:04 AM, Juan A. Suarez Romero > wrote: > > On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > > > --- > > >  src/intel/vulkan/anv_allocator.c      | 71 > > >+-- > > >  src/

Re: [Mesa-dev] [PATCH 04/18] anv: Get rid of a bunch of uses of size_t

2017-04-28 Thread Juan A. Suarez Romero
On Thu, 2017-04-27 at 20:36 -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 9:23 AM, Juan A. Suarez Romero > wrote: > > On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > > > > > We should only use size_t when referring to sizes of bits of CPU memory. > > > > > Anything on the GP

[Mesa-dev] [PATCH] glsl: include image qualifiers when printing IR

2017-04-28 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/compiler/glsl/ir_print_visitor.cpp | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/ir_print_visitor.cpp b/src/compiler/glsl/ir_print_visitor.cpp index 6c1c86a..36dfbdd 100644 --- a/src/compiler/glsl/ir_print_

Re: [Mesa-dev] [PATCH] glsl: include image qualifiers when printing IR

2017-04-28 Thread Samuel Pitoiset
On 04/28/2017 11:26 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/compiler/glsl/ir_print_visitor.cpp | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/ir_print_visitor.cpp b/src/compiler/glsl/ir_print_visitor.cpp index 6c1c8

Re: [Mesa-dev] [PATCH 1/2] renderonly: close transfer prime_fd

2017-04-28 Thread Emil Velikov
On 27 April 2017 at 17:44, Philipp Zabel wrote: > prime_fd is only used to transfer the scanout buffer to the GPU inside > renderonly_create_kms_dumb_buffer_for_resource. It should be closed > immediately to avoid leaking the DMA-BUF file handle. > > Signed-off-by: Philipp Zabel Fixes: 848b49b288

Re: [Mesa-dev] [PATCH 2/2] renderonly: drop resources on destroy

2017-04-28 Thread Emil Velikov
On 27 April 2017 at 17:44, Philipp Zabel wrote: > The renderonly_scanout holds a reference on its prime pipe resource, > which should be released when it is destroyed. If it was created by > renderonly_create_kms_dumb_buffer_for_resource, the dumb BO also has > to be destroyed. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 30/61] radeonsi/gfx9: move RW_BUFFERS to s[0:1] for merged shaders

2017-04-28 Thread Nicolai Hähnle
One small comment on patch 13. Apart from that, patches 9-30: Reviewed-by: Nicolai Hähnle On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 13 src/gallium/drivers/radeonsi/si_shader.c | 29 +++---

Re: [Mesa-dev] [PATCH 13/61] radeonsi: adjust the signature of si_get_vs_prolog_key

2017-04-28 Thread Nicolai Hähnle
On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 0

Re: [Mesa-dev] [PATCH v3] gallium: introduce dmabuf format and modifier querying

2017-04-28 Thread Lucas Stach
Am Mittwoch, den 26.04.2017, 17:49 +0530 schrieb Varad Gautam: > allows drivers to be queried for supported formats and format > modifiers for EGL_EXT_image_dma_buf_import_modifiers. drivers that > implement format/modifier queries must advertise these under > PIPE_CAP_QUERY_DMABUF_ATTRIBS. > > v2

Re: [Mesa-dev] [PATCH 01/15] travis: explicitly LD_LIBRARY_PATH the local libraries

2017-04-28 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > Some of the libraries may be dlopened, which may not always work due to > the non-standard prefix that we're using. > > Signed-off-by: Emil Velikov > --- > Adding this is a good

Re: [Mesa-dev] [PATCH 05/15] travis: automatically manage ccache caching

2017-04-28 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > According to the manual > > "If you are using ccache, use: > > language: c # or other C/C++ variants > > cache: ccache > > to cache $HOME/.ccache and automatically add /us

Re: [Mesa-dev] [PATCH 04/15] travis: enable apt cache

2017-04-28 Thread Andres Gomez
Do we want to do this? According to Travis own doc, there is little to no gain: https://docs.travis-ci.com/user/caching/#Things-not-to-cache On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > .travis.yml | 1 + > 1 file changed,

Re: [Mesa-dev] [PATCH 06/15] travis: remove unused -dev packages

2017-04-28 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > We effectively override libdrm-dev and libxcb-dri2-0-dev since we build > and install the package locally. > > Signed-off-by: Emil Velikov > --- > .travis.yml | 2 -- > 1 file

Re: [Mesa-dev] [PATCH 07/15] travis: rework "if test" blocks in the script section

2017-04-28 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > Split the "if test" blocks so that we get more sensible output in case > of a failure. > > Signed-off-by: Emil Velikov > --- > .travis.yml | 4 +++- > 1 file changed, 3 inserti

Re: [Mesa-dev] [PATCH v3] gallium: introduce dmabuf format and modifier querying

2017-04-28 Thread Lucas Stach
Am Mittwoch, den 26.04.2017, 17:49 +0530 schrieb Varad Gautam: > allows drivers to be queried for supported formats and format > modifiers for EGL_EXT_image_dma_buf_import_modifiers. drivers that > implement format/modifier queries must advertise these under > PIPE_CAP_QUERY_DMABUF_ATTRIBS. > > v2

[Mesa-dev] LLVM build issue on r299777

2017-04-28 Thread Eric Engestrom
Hi, I'm currently running llvm r299777 but I have no idea when this was changed. make[4]: Entering directory '/var/tmp/mesa-git/src/mesa/src/amd' CXX common/common_libamd_common_la-ac_llvm_helper.lo common/ac_llvm_helper.cpp: In function ‘void ac_add_attr_dereferenceable(LLVMValueRef, uin

Re: [Mesa-dev] [PATCH 2/2] renderonly: drop resources on destroy

2017-04-28 Thread Philipp Zabel
On Fri, 2017-04-28 at 11:19 +0100, Emil Velikov wrote: > On 27 April 2017 at 17:44, Philipp Zabel wrote: > > The renderonly_scanout holds a reference on its prime pipe resource, > > which should be released when it is destroyed. If it was created by > > renderonly_create_kms_dumb_buffer_for_resour

[Mesa-dev] [PATCH] renderonly: use drmIoctl

2017-04-28 Thread Philipp Zabel
To restart interrupted system calls, use drmIoctl. Suggested-by: Emil Velikov Signed-off-by: Philipp Zabel --- Applies on top of the "renderonly: drop resources on destroy" patch: https://patchwork.freedesktop.org/patch/153274/ --- src/gallium/auxiliary/renderonly/renderonly.c | 7 +++ 1 fi

Re: [Mesa-dev] [PATCH v2] docs: add release calendar page and references to it

2017-04-28 Thread Eric Engestrom
On Thursday, 2017-04-27 16:38:19 +0100, Emil Velikov wrote: > From: Emil Velikov > > Add a page that has information which release is expected when and > associated information. > > Reference to it from the "Releasing process" and "Release notes" pages. > > v2: > - Add Andres for 17.0.5 > - R

[Mesa-dev] [PATCH] renderonly: use drmIoctl

2017-04-28 Thread Philipp Zabel
To restart interrupted system calls, use drmIoctl. Suggested-by: Emil Velikov Signed-off-by: Philipp Zabel --- Applies on top of the "renderonly: drop resources on destroy" patch: https://patchwork.freedesktop.org/patch/153274/ --- src/gallium/auxiliary/renderonly/renderonly.c | 7 +++ 1 fi

Re: [Mesa-dev] [PATCH 35/61] radeonsi/gfx9: add GS user SGPRs

2017-04-28 Thread Nicolai Hähnle
Patches 31-35: Reviewed-by: Nicolai Hähnle On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 15 +++ src/gallium/drivers/radeonsi/si_shader.c| 2 +- src/gallium/drivers/radeonsi/si_shader.h| 13 ++

Re: [Mesa-dev] [PATCH 08/15] travis: split out matrix from env

2017-04-28 Thread Andres Gomez
On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > With next commits we'll add a couple of more options. > > v2: Rework check target. > v3: Comment the current check target, add -j4 SCONSFLAGS > > Signed-off-by: Emil Velikov > --- > .travis.yml | 20 ++

Re: [Mesa-dev] [PATCH 36/61] radeonsi/gfx9: set registers and shader key for merged ES-GS

2017-04-28 Thread Nicolai Hähnle
On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c| 8 + src/gallium/drivers/radeonsi/si_shader.h| 2 + src/gallium/drivers/radeonsi/si_state.c | 22 +-- src/gallium/drivers/radeonsi/si_state_draw.c| 3 +- s

Re: [Mesa-dev] [PATCH 43/61] radeonsi/gfx9: add GS prolog support for merged ES-GS

2017-04-28 Thread Nicolai Hähnle
On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 87 +--- 1 file changed, 70 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c ind

Re: [Mesa-dev] [PATCH 09/15] travis: add separate "scons" and "scons llvm" targets

2017-04-28 Thread Andres Gomez
On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > The former does not require any LLVM, while the latter uses LLVM 3.3. > > This way we'll quickly catch any LLVM 3.3+ functionality that gets > introduced where it shouldn't. > > Add the full list of addons for each

Re: [Mesa-dev] [PATCH 51/61] radeonsi: add reference counting for shader selectors

2017-04-28 Thread Nicolai Hähnle
On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák The 2nd shader of merged shaders should take a reference of the 1st shader. The next commit will do that. --- src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 27 +

Re: [Mesa-dev] [PATCH 52/61] radeonsi/gfx9: 2nd shader of merged shaders should hold a reference of the 1st

2017-04-28 Thread Nicolai Hähnle
On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 35 ++--- 2 files changed, 26 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si

Re: [Mesa-dev] [PATCH 53/61] radeonsi/gfx9: enable OpenGL 4.5

2017-04-28 Thread Nicolai Hähnle
I've sent comments on patches 43, 51, 52. Apart from those, patches 37-53 are: Reviewed-by: Nicolai Hähnle On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák Tentatively enable it, expecting the scratch buffer support to be done before the next Mesa release. --- src/gallium/drivers

Re: [Mesa-dev] [PATCH 56/61] radeonsi: get InstanceID from VGPR1 (or VGPR2 for tess) instead of VGPR3

2017-04-28 Thread Nicolai Hähnle
On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák VGPR1 = InstanceID / StepRate0; // StepRate0 can be set to 1 --- src/gallium/drivers/radeonsi/si_shader.c| 20 ++-- src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_state.c

Re: [Mesa-dev] [PATCH] mesa: Avoid leaking surface in st_renderbuffer_delete

2017-04-28 Thread Marek Olšák
On Thu, Apr 27, 2017 at 3:51 PM, Rob Clark wrote: > On Thu, Apr 27, 2017 at 9:18 AM, Bartosz Tomczyk > wrote: >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100741 >> Fixes: a5e733c6b52 mesa: drop current draw/read buffer when ctx is released >> CC: Rob Clark > > That looks reasonable

Re: [Mesa-dev] [PATCH 61/61] radeonsi: tell LLVM not to remove s_barrier instructions

2017-04-28 Thread Nicolai Hähnle
On 24.04.2017 10:45, Marek Olšák wrote: From: Marek Olšák LLVM 5.0 removes s_barrier instructions if the max-work-group-size attribute is not set. What a surprise. One minor comment on patch 56, apart from that patches 54-61: Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] disk_cache: reduce default cache size to 5% of filesystem

2017-04-28 Thread Marek Olšák
On Thu, Apr 27, 2017 at 8:47 AM, Michel Dänzer wrote: > On 27/04/17 10:15 AM, Timothy Arceri wrote: >> Modern disks are extremely large and are only going to get bigger. >> Usage has shown frequent Mesa upgrades can result in the cache >> growing very fast i.e. wasting a lot of disk space unnecess

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-28 Thread Marek Olšák
On Thu, Apr 27, 2017 at 4:57 PM, Emil Velikov wrote: > On 27 April 2017 at 11:52, Constantine Kharlamov wrote: >> 27.04.2017, 13:26, "Emil Velikov" : >>> Hi Constantine, >>> >>> I'm not familiar with r600, so mostly a drive-by idea/nit. >> >> I'm not familiar with graphics :P Well, perhaps a litt

[Mesa-dev] [PATCH 1/3] mapi: replace mapi_table abstraction

2017-04-28 Thread Emil Velikov
From: Emil Velikov Replace all instances of mapi_table with the actual struct _glapi_table. The former may have been needed when the OpenVG was around. But since that one is long gone, there' no point in having the current confusing mix of the two. Signed-off-by: Emil Velikov --- src/mapi/entr

[Mesa-dev] [PATCH 2/3] mapy_abi.py: remove dead output_for_app generator

2017-04-28 Thread Emil Velikov
From: Emil Velikov Used by the OpenVG codebase. Signed-off-by: Emil Velikov --- src/mapi/mapi_abi.py | 48 1 file changed, 48 deletions(-) diff --git a/src/mapi/mapi_abi.py b/src/mapi/mapi_abi.py index adb5d77126d..d6c505caa81 100644 --- a/src/

[Mesa-dev] [PATCH 3/3] mapi_abi.py: remove no longer used --mode option

2017-04-28 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/mapi/Android.mk | 2 +- src/mapi/Makefile.am | 6 +++--- src/mapi/glapi/gen/Makefile.am | 2 +- src/mapi/mapi_abi.py | 9 ++--- src/mapi/shared-glapi/SConscript | 2 +- 5 files changed, 8 insertion

Re: [Mesa-dev] [PATCH 10/12] Android: default to building all drivers

2017-04-28 Thread Rob Herring
On Thu, Apr 27, 2017 at 9:50 PM, Chih-Wei Huang wrote: > A typo in the subject? > (s/building/build/) It's a bit misleading as originally I wrote it such that a blank BOARD_GPU_DRIVERS would enable all drivers, then changed it to "all". So it's not really a default anymore. > 2017-04-28 3:43 GMT

Re: [Mesa-dev] [PATCH 10/15] travis: add "scons swr" to the build matrix

2017-04-28 Thread Andres Gomez
On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > Requires GCC 5.0 (due to the C++14 requirement) and LLVM 3.9. > > v2: Enable the target, add libedit-dev, rework check target. I've missed (or overlooked) the review that lead to v2 but I wonder why we need libedit-

Re: [Mesa-dev] [PATCH 11/15] travis: add "make swr" to the build matrix

2017-04-28 Thread Andres Gomez
On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > v2: Quote OVERRIDE variables. > > Signed-off-by: Emil Velikov > --- > .travis.yml | 39 --- > 1 file changed, 36 insertions(+), 3 deletions(-) > > diff --git a/.travis.yml b/.tr

Re: [Mesa-dev] [PATCH] util/disk_cache: remove percentage based max cache limit

2017-04-28 Thread Marek Olšák
On Fri, Apr 28, 2017 at 5:05 AM, Timothy Arceri wrote: > The more I think about it the more this seems like a bad idea. > When we were deleting old cache dirs this wasn't so bad as it > was unlikely we would ever hit the actual limit before things > were cleaned up. Now that we only start cleaning

Re: [Mesa-dev] [PATCH 08/15] travis: split out matrix from env

2017-04-28 Thread Emil Velikov
On 28 April 2017 at 12:18, Andres Gomez wrote: > On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> With next commits we'll add a couple of more options. >> >> v2: Rework check target. >> v3: Comment the current check target, add -j4 SCONSFLAGS >> >> Signed-off-by:

Re: [Mesa-dev] [PATCH] renderonly: use drmIoctl

2017-04-28 Thread Eric Engestrom
On Friday, 2017-04-28 13:14:20 +0200, Philipp Zabel wrote: > To restart interrupted system calls, use drmIoctl. > > Suggested-by: Emil Velikov > Signed-off-by: Philipp Zabel Reviewed-by: Eric Engestrom A quick grep shows 8 other `ioctl()`; do we want to fix them as well? src/gallium/auxiliar

[Mesa-dev] [PATCH] anv: Alphabetize KHR extensions

2017-04-28 Thread Jason Ekstrand
--- src/intel/vulkan/anv_device.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index cf32df6..6b3202d 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_de

Re: [Mesa-dev] [PATCH] renderonly: use drmIoctl

2017-04-28 Thread Emil Velikov
On 28 April 2017 at 13:55, Eric Engestrom wrote: > On Friday, 2017-04-28 13:14:20 +0200, Philipp Zabel wrote: >> To restart interrupted system calls, use drmIoctl. >> >> Suggested-by: Emil Velikov >> Signed-off-by: Philipp Zabel > > Reviewed-by: Eric Engestrom > > A quick grep shows 8 other `io

Re: [Mesa-dev] [PATCH 11/15] travis: add "make swr" to the build matrix

2017-04-28 Thread Emil Velikov
On 28 April 2017 at 13:29, Andres Gomez wrote: > On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> v2: Quote OVERRIDE variables. >> >> Signed-off-by: Emil Velikov >> --- >> .travis.yml | 39 --- >> 1 file changed, 36 insertion

[Mesa-dev] [PATCH 05/13] mapi/es*api: remove unneeded HAVE_SHARED_GLAPI guard

2017-04-28 Thread Emil Velikov
From: Emil Velikov Always true, since GLES* requires shared glapi. Signed-off-by: Emil Velikov --- src/mapi/Makefile.am | 4 1 file changed, 4 deletions(-) diff --git a/src/mapi/Makefile.am b/src/mapi/Makefile.am index 7ebe14f5207..61b8470437c 100644 --- a/src/mapi/Makefile.am +++ b/src/

[Mesa-dev] [PATCH 03/13] gallium/dri: remove unneeded HAVE_SHARED_GLAPI guard

2017-04-28 Thread Emil Velikov
From: Emil Velikov Always true, since the dri modules required shared glapi. With earlier commit (da410e6afad "configure: explicitly require shared glapi for enable-dri") we even made that explicit during the configure stage. Signed-off-by: Emil Velikov --- src/gallium/targets/dri/Makefile.am

[Mesa-dev] [PATCH 01/13] gallium/dri: always link against shared glapi

2017-04-28 Thread Emil Velikov
From: Emil Velikov In the early days of Xorg and Mesa we had multiple providers of the GLAPI. All of those were the ones responsible for dlopening the DRI module. Hence it was perfectly fine, and actually expected, for the DRI modules to have unresolved symbols. Since then we've moved the API to

[Mesa-dev] [PATCH 02/13] mesa/dri: always link against shared glapi

2017-04-28 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit. Check with the extensive commit description and bug report referenced. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/Makefile.am | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-)

[Mesa-dev] [PATCH 08/13] targets/libgl-xlib: remove unneeded GLX_SHARED_GLAPI define

2017-04-28 Thread Emil Velikov
From: Emil Velikov There's no users in-tree that use it. Signed-off-by: Emil Velikov --- src/gallium/targets/libgl-xlib/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/targets/libgl-xlib/Makefile.am b/src/gallium/targets/libgl-xlib/Makefile.am index d2fd2ed7b68..d

[Mesa-dev] [PATCH 04/13] mesa/dri: remove unneeded HAVE_SHARED_GLAPI guard

2017-04-28 Thread Emil Velikov
From: Emil Velikov Always true, since the dri modules required shared glapi. With earlier commit (da410e6afad "configure: explicitly require shared glapi for enable-dri") we even made that explicit during the configure stage. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/Makefile.am |

[Mesa-dev] [PATCH 07/13] drivers/x11: remove unneeded GLX_SHARED_GLAPI define

2017-04-28 Thread Emil Velikov
From: Emil Velikov There's no users in-tree that use it. Signed-off-by: Emil Velikov --- src/mesa/drivers/x11/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/x11/Makefile.am b/src/mesa/drivers/x11/Makefile.am index ba79f6981b9..8c6b67d6a8d 100644 --- a/src/mes

[Mesa-dev] [PATCH 10/13] glx/windows: remove empty variable SHARED_GLAPI_CFLAGS

2017-04-28 Thread Emil Velikov
From: Emil Velikov Cc: Jon Turney Signed-off-by: Emil Velikov --- src/glx/windows/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/glx/windows/Makefile.am b/src/glx/windows/Makefile.am index 6de3cf226b4..f84288b935c 100644 --- a/src/glx/windows/Makefile.am +++ b/src/glx/windo

[Mesa-dev] [PATCH 13/13] mesa/tests: remove no longer needed HAVE_SHARED_GLAPI define

2017-04-28 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/main/tests/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/tests/Makefile.am b/src/mesa/main/tests/Makefile.am index 8b4598d9248..47fce8a5b78 100644 --- a/src/mesa/main/tests/Makefile.am +++ b/src/mesa/ma

[Mesa-dev] [PATCH 11/13] glx/apple: remove empty variable SHARED_GLAPI_CFLAGS

2017-04-28 Thread Emil Velikov
From: Emil Velikov Cc: Jeremy Huddleston Sequoia Signed-off-by: Emil Velikov --- src/glx/apple/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/glx/apple/Makefile.am b/src/glx/apple/Makefile.am index ca74aa7b99b..bfa18b1c2f3 100644 --- a/src/glx/apple/Makefile.am +++ b/src/gl

[Mesa-dev] [PATCH 06/13] glx: glX_proto_send.py: use correct compile guard GLX_INDIRECT_RENDERING

2017-04-28 Thread Emil Velikov
From: Emil Velikov The code itself has nothing to do with shared glapi, thus having it behind GLX_SHARED_GLAPI is misleading. Use GLX_INDIRECT_RENDERING instead. The latter macro is set at global scope by the Autotools and Scons build systems. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by

[Mesa-dev] [PATCH 09/13] glx: automake: scons: remove unneeded GLX_SHARED_GLAPI define

2017-04-28 Thread Emil Velikov
From: Emil Velikov There's no users in-tree that use it. Signed-off-by: Emil Velikov --- src/glx/Makefile.am | 2 -- src/glx/SConscript | 3 --- 2 files changed, 5 deletions(-) diff --git a/src/glx/Makefile.am b/src/glx/Makefile.am index 41e4939a0b7..b306bcc08db 100644 --- a/src/glx/Makefile

[Mesa-dev] [PATCH 12/13] gl_table.py: always regenerate the complete struct _glapi_table

2017-04-28 Thread Emil Velikov
From: Emil Velikov Currently we would generate a partial one as we do non-shared glapi. At the same time since it's local, we don't care that much if we have a few extra bytes of space in the table. Drop the guard, which allows us to simplify both build system and code. Signed-off-by: Emil Veli

Re: [Mesa-dev] [PATCH] anv: Alphabetize KHR extensions

2017-04-28 Thread Alejandro Piñeiro
On 28/04/17 14:59, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index cf32df6..6b3202d 100644 > --- a/src/i

[Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-04-28 Thread Johnson Lin
The matrix used for YCbCr to RGB is listed in Wiki https://en.wikipedia.org/wiki/YCbCr; There is minor error in the matrix constant: 0.0625=16/256 should be 16.0/255, and 0.5=128.0/256 should be 128.0/255. Note that conversion from a 0-255 byte number to 0-1.0 float is to divide by 255 instead o

Re: [Mesa-dev] [PATCH] anv: Alphabetize KHR extensions

2017-04-28 Thread Alejandro Piñeiro
Forget my question, didn't realize that the prefix was KHX instead of KHR. So: Reviewed-by: Alejandro Piñeiro On 28/04/17 15:39, Alejandro Piñeiro wrote: > On 28/04/17 14:59, Jason Ekstrand wrote: >> --- >> src/intel/vulkan/anv_device.c | 36 ++-- >> 1 file change

Re: [Mesa-dev] [PATCH] anv: Alphabetize KHR extensions

2017-04-28 Thread Jason Ekstrand
On Fri, Apr 28, 2017 at 6:43 AM, Alejandro Piñeiro wrote: > Forget my question, didn't realize that the prefix was KHX instead of > KHR. So: > Reviewed-by: Alejandro Piñeiro > > On 28/04/17 15:39, Alejandro Piñeiro wrote: > > On 28/04/17 14:59, Jason Ekstrand wrote: > >> --- > >> src/intel/vulk

Re: [Mesa-dev] [PATCH] anv: Alphabetize KHR extensions

2017-04-28 Thread Alejandro Piñeiro
On 28/04/17 15:46, Jason Ekstrand wrote: > On Fri, Apr 28, 2017 at 6:43 AM, Alejandro Piñeiro > mailto:apinhe...@igalia.com>> wrote: > > Forget my question, didn't realize that the prefix was KHX instead of > KHR. So: > Reviewed-by: Alejandro Piñeiro >

[Mesa-dev] [PATCH] glx: add missing sRGB attribute check in fbconfigs_compatible()

2017-04-28 Thread Brian Paul
From: Neha Bhende This patch will allow driver to choose srgb capable FBconfig if GLX_FRAMEBUFFER_SRGB_CAPABLE_ARB attribute is 1 Reviewed-by: Brian Paul Reviewed-by: Charmaine Lee --- src/glx/glxcmds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c

Re: [Mesa-dev] [PATCH 13/15] travis: add Gallium state-tracker targets

2017-04-28 Thread Andres Gomez
On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > Split into OpenCL and others, since the former is quite time consuming. > > v2: > - explicitly enable/disable components > - build libvdpau 1.1 requirement > - enable st/vdpau > - build libva 1.6.2 (API 0.38) req

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

2017-04-28 Thread Dieter Nützel
I'm running this, too. But alone. 4/4 didn't apply anylonger ;-) NO glitches on NI/Turks XT (6670). I had tested 'Heaven' and 'Valley' even with the former patch version. The 'Heaven' GPU hang (wireframe/tessellation) is OLD, as it stays there for ages. So: Tested-by: Dieter Nützel Dieter

Re: [Mesa-dev] [PATCH 14/15] travis: enable wayland support

2017-04-28 Thread Andres Gomez
On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > .travis.yml | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 86f88e86b05..32ef3e27651 100644 > ---

Re: [Mesa-dev] [PATCH 13/15] travis: add Gallium state-tracker targets

2017-04-28 Thread Andres Gomez
On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > Split into OpenCL and others, since the former is quite time consuming. > > v2: > - explicitly enable/disable components > - build libvdpau 1.1 requirement > - enable st/vdpau > - build libva 1.6.2 (API 0.38) req

Re: [Mesa-dev] [PATCH 15/15] travis: bump MAKEFLAGS to -j4

2017-04-28 Thread Andres Gomez
On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > The instance has 2 cores, yet bumping the jobs to 4 gives a minor speed > improvement. It probably won't make any harm in any case. This is: Reviewed-by: Andres Gomez -- Br, Andres _

Re: [Mesa-dev] [PATCH 12/15] travis: split the make target to three separate ones

2017-04-28 Thread Andres Gomez
On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > From: Emil Velikov > > Split the target to allow faster builds for each run. > > The overall build time will be more, yet Travis runs multiple builds in > parallel so we're limited by the slowest one. > > Things are split roughly as: > -

Re: [Mesa-dev] LLVM build issue on r299777

2017-04-28 Thread Eric Engestrom
On Friday, 2017-04-28 14:15:41 +0200, Nicolai Hähnle wrote: > On 28.04.2017 13:08, Eric Engestrom wrote: > > Hi, > > > > I'm currently running llvm r299777 but I have no idea when this was > > changed. > > Yeah, you'll just have to upgrade LLVM (or downgrade to LLVM 4.0). This sort > of thing unf

Re: [Mesa-dev] [PATCH] glx: add missing sRGB attribute check in fbconfigs_compatible()

2017-04-28 Thread Emil Velikov
On 28 April 2017 at 14:53, Brian Paul wrote: > From: Neha Bhende > > This patch will allow driver to choose srgb capable FBconfig > if GLX_FRAMEBUFFER_SRGB_CAPABLE_ARB attribute is 1 > Out of curiosity - how did you spot that? If some existing program was affected we want to mention that in the c

Re: [Mesa-dev] [PATCH 09/15] travis: add separate "scons" and "scons llvm" targets

2017-04-28 Thread Emil Velikov
On 28 April 2017 at 12:38, Andres Gomez wrote: > On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> The former does not require any LLVM, while the latter uses LLVM 3.3. >> >> This way we'll quickly catch any LLVM 3.3+ functionality that gets >> introduced where it

Re: [Mesa-dev] [PATCH 14/15] travis: enable wayland support

2017-04-28 Thread Emil Velikov
On 28 April 2017 at 15:54, Andres Gomez wrote: > On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Signed-off-by: Emil Velikov >> --- >> .travis.yml | 20 >> 1 file changed, 16 insertions(+), 4 deletions(-) >> >> diff --git a/.travis.yml b/.

Re: [Mesa-dev] [PATCH 36/61] radeonsi/gfx9: set registers and shader key for merged ES-GS

2017-04-28 Thread Marek Olšák
>> +static void gfx9_get_gs_info(struct si_shader_selector *es, >> + struct si_shader_selector *gs, >> + struct gfx9_gs_info *out) >> +{ >> + unsigned gs_num_invocations = MAX2(gs->gs_num_invocations, 1); >> + unsigned in

Re: [Mesa-dev] [PATCH 10/12] Android: default to building all drivers

2017-04-28 Thread Mauro Rossi
2017-04-28 14:23 GMT+02:00 Rob Herring : > On Thu, Apr 27, 2017 at 9:50 PM, Chih-Wei Huang > wrote: >> A typo in the subject? >> (s/building/build/) > > It's a bit misleading as originally I wrote it such that a blank > BOARD_GPU_DRIVERS would enable all drivers, then changed it to "all". > So it

Re: [Mesa-dev] [PATCH 43/61] radeonsi/gfx9: add GS prolog support for merged ES-GS

2017-04-28 Thread Marek Olšák
On Fri, Apr 28, 2017 at 1:25 PM, Nicolai Hähnle wrote: > On 24.04.2017 10:45, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_shader.c | 87 >> +--- >> 1 file changed, 70 insertions(+), 17 deletions(-) >> >> diff --git a/src/gal

Re: [Mesa-dev] [PATCH] radv: set PERF_MOD in sample state like radeonsi.

2017-04-28 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Apr 28, 2017 at 9:14 AM, Dave Airlie wrote: > From: Dave Airlie > > This just aligns the code with radeonsi. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_image.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src

[Mesa-dev] [PATCH] egl: polish dri2_to_egl_attribute_map[]

2017-04-28 Thread Emil Velikov
From: Emil Velikov Annotate the array as static const and use C99 initialiser to populate it. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 68 +++-- 1 file changed, 18 insertions(+), 50 deletions(-) diff --git a/src/egl/drivers/dri2/egl

Re: [Mesa-dev] [PATCH 56/61] radeonsi: get InstanceID from VGPR1 (or VGPR2 for tess) instead of VGPR3

2017-04-28 Thread Marek Olšák
On Fri, Apr 28, 2017 at 1:54 PM, Nicolai Hähnle wrote: > On 24.04.2017 10:45, Marek Olšák wrote: >> >> From: Marek Olšák >> >> VGPR1 = InstanceID / StepRate0; // StepRate0 can be set to 1 >> --- >> src/gallium/drivers/radeonsi/si_shader.c| 20 ++-- >> src/gallium/drivers/

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

2017-04-28 Thread Chad Versace
On Thu 27 Apr 2017, Emil Velikov wrote: > On 27 April 2017 at 12:14, Xu, Randy wrote: > > Hi, Chad > > > > Please review this patch, we need it to solve some instability issues Randy and Tapani, could you provide a few dEQP test names that this patch fixes? I'd like to mention at least one EGL an

[Mesa-dev] [PATCH kmscube 2/2] drm-atomic: init out_fence_fd to -1

2017-04-28 Thread Lucas Stach
The current initial value of 0 is a valid fd, so this will trip up the GPU submit on the first render, when used as an IN fence for rendering. Reported-by: Philipp Zabel Signed-off-by: Lucas Stach --- drm-atomic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drm-atom

[Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

2017-04-28 Thread Lucas Stach
Use long long format when printing the format modifier, as a simple long is only 4 bytes on 32bit systems. Signed-off-by: Lucas Stach --- drm-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drm-common.c b/drm-common.c index 2f2c918596a4..fb4ec7f4389e 100644 --- a/drm

Re: [Mesa-dev] [PATCH 12/15] travis: split the make target to three separate ones

2017-04-28 Thread Emil Velikov
On 28 April 2017 at 16:00, Andres Gomez wrote: > On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Split the target to allow faster builds for each run. >> >> The overall build time will be more, yet Travis runs multiple builds in >> parallel so we're limited by t

Re: [Mesa-dev] LLVM build issue on r299777

2017-04-28 Thread Nicolai Hähnle
On 28.04.2017 13:08, Eric Engestrom wrote: Hi, I'm currently running llvm r299777 but I have no idea when this was changed. Yeah, you'll just have to upgrade LLVM (or downgrade to LLVM 4.0). This sort of thing unfortunately happens occasionally when running LLVM trunk and Mesa master. I curr

Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

2017-04-28 Thread Mark Janes
With this commit, a wide range of intel hardware began hanging during the GLES CTS, with dmesg errors like: [25488.739167] traps: glcts[15106] general protection ip:7fdac6484ba5 sp:7ffdcda85a20 error:0 Machines that did complete the cts, reported hundreds of errors like: *** Error in `/tmp/buil

Re: [Mesa-dev] [PATCH 12/15] travis: split the make target to three separate ones

2017-04-28 Thread Andres Gomez
On Fri, 2017-04-28 at 17:43 +0100, Emil Velikov wrote: > On 28 April 2017 at 16:00, Andres Gomez wrote: > > On Thu, 2017-04-27 at 19:38 +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > Split the target to allow faster builds for each run. > > > > > > The overall build time will b

Re: [Mesa-dev] [PATCH 1/2] vbo: set min_index = 0 so gallium can use the value directly

2017-04-28 Thread Marek Olšák
Ping On Wed, Apr 26, 2017 at 11:35 AM, Marek Olšák wrote: > From: Marek Olšák > > We could also remove index_bounds_valid and use max_index != ~0 instead. > Opinions on that are welcome. > --- > src/mesa/vbo/vbo_context.c| 2 +- > src/mesa/vbo/vbo_exec_array.c | 6 +++--- > 2 files changed,

Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

2017-04-28 Thread Samuel Pitoiset
On 04/28/2017 06:58 PM, Mark Janes wrote: With this commit, a wide range of intel hardware began hanging during the GLES CTS, with dmesg errors like: [25488.739167] traps: glcts[15106] general protection ip:7fdac6484ba5 sp:7ffdcda85a20 error:0 Machines that did complete the cts, reported hun

Re: [Mesa-dev] [PATCH 04/15] travis: enable apt cache

2017-04-28 Thread Emil Velikov
On 28 April 2017 at 11:50, Andres Gomez wrote: > Do we want to do this? > > According to Travis own doc, there is little to no gain: > https://docs.travis-ci.com/user/caching/#Things-not-to-cache > The packages we use should not be slow to download, although I've not checked explicitly. It seems c

Re: [Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

2017-04-28 Thread Rob Clark
I guess this applies on top of one of Ben's in-flight patches? Perhaps it can be squashed into that? (Otherwise remind me about this when the modifiers patchset is merged) BR, -R On Fri, Apr 28, 2017 at 12:18 PM, Lucas Stach wrote: > Use long long format when printing the format modifier, as a

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

2017-04-28 Thread Marc Dietrich
Am Freitag, 28. April 2017, 16:53:55 CEST schrieb Dieter Nützel: > I'm running this, too. > But alone. 4/4 didn't apply anylonger ;-) > > NO glitches on NI/Turks XT (6670). > > I had tested 'Heaven' and 'Valley' even with the former patch version. > The 'Heaven' GPU hang (wireframe/tessellation)

Re: [Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

2017-04-28 Thread Ben Widawsky
Fix kmscube -A on i915 :P On 17-04-28 14:17:34, Rob Clark wrote: I guess this applies on top of one of Ben's in-flight patches? Perhaps it can be squashed into that? (Otherwise remind me about this when the modifiers patchset is merged) BR, -R On Fri, Apr 28, 2017 at 12:18 PM, Lucas Stach wr

Re: [Mesa-dev] [PATCH 04/15] travis: enable apt cache

2017-04-28 Thread Emil Velikov
On 28 April 2017 at 19:15, Emil Velikov wrote: > On 28 April 2017 at 11:50, Andres Gomez wrote: >> Do we want to do this? >> >> According to Travis own doc, there is little to no gain: >> https://docs.travis-ci.com/user/caching/#Things-not-to-cache >> > The packages we use should not be slow to d

[Mesa-dev] [PATCH 01/16] travis: explicitly LD_LIBRARY_PATH the local libraries

2017-04-28 Thread Emil Velikov
From: Emil Velikov Some of the libraries may be dlopened, which may not always work due to the non-standard prefix that we're using. Signed-off-by: Emil Velikov Reviewed-by: Andres Gomez --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 6d6e44

[Mesa-dev] [PATCH 03/16] travis: add the possibility of using the txc-dxtn library

2017-04-28 Thread Emil Velikov
From: Andres Gomez The txc-dxtn library implements the patented S3 Texture Compression algorithm. By default it won't be used but we add the possibility of setting the USE_TXC_DXTN variable to yes in the travis web UI so it will be installed and used for the scons tests. Cc: Eric Anholt Cc: Rh

  1   2   >