Re: [Mesa-dev] [RFC 2/3] mesa: always return GL_OUT_OF_MEMORY or GL_NO_ERROR when KHR_no_error enabled

2017-03-28 Thread Gustaw Smolarczyk
28 mar 2017 06:35 "Timothy Arceri" napisał(a): --- src/mesa/main/getstring.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index 6e90511..50140cf 100644 --- a/src/mesa/main/getstring.c +++ b/src/mesa/main/getstring.c @@ -2

[Mesa-dev] [Bug 100425] glGenFramebuffersEXT appears to be null on (some?) Mesa 12.0.6 systems

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100425 --- Comment #3 from Timo Aaltonen --- fwiw, 17.0.x backport to xenial-updates is being prepared on a ppa: https://launchpad.net/~ubuntu-x-swat/+archive/ubuntu/updates so if the update fixes this bug then assume it's going to be on xenial withi

[Mesa-dev] [Bug 100202] llvmpipe Windows scons build can't detect Visual Studio 2017 toolchain

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100202 --- Comment #3 from Anonymous Helper --- (In reply to Anonymous Helper from comment #2) > For now you can use either the normal VS2017 Native Tools and VS2015 Native > Tools, but VS2017 toolset would stop working if bug 100201 gets fixed before

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with MSVC toolchain and LLVM 4.0 fails

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100201 --- Comment #5 from Anonymous Helper --- After applying the patch from above over 17.0.2 release (it works over master too, I only noticed minor indent changes in master, no actual functional changes on that header), I got unresolved symbols dur

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with MSVC toolchain and LLVM 4.0 fails

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100201 --- Comment #6 from Anonymous Helper --- Created attachment 130496 --> https://bugs.freedesktop.org/attachment.cgi?id=130496&action=edit 17.0.2 build with LLVM 4.0 after xtime patch, OpenSWR excluded, link error with unresolved symbols -- Yo

[Mesa-dev] [PATCH v2 02/25] ARB_sparse_buffer for radeonsi (>= CIK)

2017-03-28 Thread Nicolai Hähnle
Hi all, here's a v2 of the series, motivated by providing an open user of the new kernel APIs for PRT / sparse buffers/textures. Now with: - addressed the comments from v1 - simplified by using the new VA_OP_CLEAR and VA_OP_REPLACE kernel interfaces - various bug fixes, missing ddebug piping -

[Mesa-dev] [PATCH v2 04/25] mesa: implement sparse buffer commitment

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Ian Romanick Reviewed-by: Marek Olšák --- src/mesa/main/bufferobj.c | 66 +++ src/mesa/main/dd.h| 10 +++ 2 files changed, 76 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferob

[Mesa-dev] [PATCH v2 01/25] mesa: Add GL_ARB_sparse_buffer boilerplate

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Ian Romanick Reviewed-by: Marek Olšák --- src/mapi/glapi/gen/ARB_sparse_buffer.xml | 30 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml| 3 +++ src/mesa/main/bufferobj.c

[Mesa-dev] [PATCH v2 06/25] ddebug: add resource_commit pass-through

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/ddebug/dd_context.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/ddebug/dd_context.c b/src/gallium/drivers/ddebug/dd_context.c index 9811663..dd277c9 100644 --- a/src/gallium/drivers/ddebug/dd_context.c +++ b/s

[Mesa-dev] [PATCH v2 10/25] radeon/winsys: add sparse buffer interface

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h | 17 + 1 file changed, 17 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index 812c036..924ad9c 100644 --- a/src/ga

[Mesa-dev] [PATCH v2 12/25] winsys/amdgpu: extract amdgpu_do_add_real_buffer

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle We will use it for delayed adding of sparse buffers' backing buffers. Reviewed-by: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu

[Mesa-dev] [PATCH v2 05/25] gallium: add sparse buffer interface and capability

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle TODO fill out caps in all drivers v2: - explain the resource_commit interface in more detail --- src/gallium/docs/source/context.rst | 25 + src/gallium/docs/source/screen.rst | 3 +++ src/gallium/include/pipe/p_context.h | 13 + src/

[Mesa-dev] [PATCH v2 07/25] trace: add resource_commit pass-through

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/trace/tr_context.c | 20 1 file changed, 20 insertions(+) diff --git a/src/gallium/drivers/trace/tr_context.c b/src/gallium/drivers/trace/tr_context.c index 81c1a46..75a3748 100644 --- a/src/gallium/drivers/trace/tr_context.c ++

[Mesa-dev] [PATCH v2 03/25] mesa: implement sparse storage buffer allocation

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: - spec quote and style (Ian) Reviewed-by: Marek Olšák --- src/mesa/main/bufferobj.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index cbd9228..a4ccf8c 100644 --

[Mesa-dev] [PATCH v2 18/25] winsys/amdgpu: add sparse buffers to CS

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle ... and implement the corresponding fence handling. v2: - add missing bit in amdgpu_bo_is_referenced_by_cs_with_usage - remove pipe_mutex_* --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 147 +++--- src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 9 +-

[Mesa-dev] [PATCH v2 23/25] gallium/radeon: implement pipe->resource_commit

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_pipe_common.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index b3b925e..e9ac912 100644 --- a/src/gallium/d

[Mesa-dev] [PATCH v2 15/25] winsys/amdgpu: extend amdgpu_add_fence to allow adding multiple fences

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 35 +-- src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 3 +++ 2 files changed, 27 insertions(+), 11 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm

[Mesa-dev] [PATCH v2 19/25] winsys/amdgpu: take fences when freeing a backing buffer

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle We never add fences to backing buffers during submit. When we free a backing buffer, it must inherit the sparse buffer's fences, so that it doesn't get re-used prematurely via the cache. v2: - remove pipe_mutex_* --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 14 ++

[Mesa-dev] [PATCH v2 16/25] winsys/amdgpu: add sparse buffer data structures

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: - remove pipe_mutex_* - use a simple page commitment array --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 9 src/gallium/winsys/amdgpu/drm/amdgpu_bo.h | 38 ++- 2 files changed, 46 insertions(+), 1 deletion(-) diff --git a/src/gall

[Mesa-dev] [PATCH v2 14/25] winsys/amdgpu: build handles and flags list late on submit thread

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle This probably has only minor performance effects, but it simplifies some subsequent code slightly. Ideally, it could also be used to simplify the handling of slab buffers in the same way, but unfortunately that's not possible as long as we need indices for relocations. ---

[Mesa-dev] [PATCH v2 21/25] gallium/radeon: implement sparse buffer creation

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_buffer_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c b/src/gallium/drivers/radeon/r600_buffer_common.c index 5fde0d6..a1e8228 100644 --- a/src/gallium/drivers/radeon/r600_bu

[Mesa-dev] [PATCH v2 17/25] winsys/amdgpu: sparse buffer creation / destruction / commitment

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle This is the bulk of the buffer allocation logic. It is fairly simple and stupid. We'll probably want to use e.g. interval trees at some point to keep track of commitments, but Mesa doesn't have an implementation of those yet. v2: - remove pipe_mutex_* - fix total_backing_pag

[Mesa-dev] [PATCH v2 13/25] winsys/amdgpu: share common code in amdgpu_add_fence_dependencies

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 38 ++- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index 0381359..2520aff 100644 --- a/src/

[Mesa-dev] [PATCH v2 22/25] gallium/radeon: transfers and invalidation for sparse buffers

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle Sparse buffers can never be mapped by the CPU. --- src/gallium/drivers/radeon/r600_buffer_common.c | 34 + 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c b/src/gallium/drivers/radeon/r6

[Mesa-dev] [PATCH v2 25/25] radeonsi: enable ARB_sparse_buffer

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle TODO add features.txt and ChangeLog v2: - fill in DRM version requirement - disable on SI due to CP DMA faults --- src/gallium/drivers/radeonsi/si_pipe.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/dr

[Mesa-dev] [PATCH v2 24/25] radeonsi: disable SDMA clears and copies for sparse buffers

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle VM faults cannot be disabled for SDMA on <= VI. We could still use SDMA by asking the winsys about which parts of the buffers are committed. This is left as a potential future improvement. --- src/gallium/drivers/radeonsi/cik_sdma.c | 7 +-- src/gallium/drivers/radeons

[Mesa-dev] [PATCH v2 20/25] winsys/amdgpu: sparse buffer debugging helpers

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 61 +++ 1 file changed, 61 insertions(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index 567399d..c650993 100644 --- a/src/gallium/winsys/am

[Mesa-dev] [PATCH v2 11/25] winsys/radeon: sparse buffers will not be supported

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b/src/gallium/winsys/radeon/drm/radeon_drm_bo.c index f6d5c8a..1419169 100644 --- a/src/gallium/wi

[Mesa-dev] [PATCH v2 02/25] mesa: implement SPARSE_BUFFER_PAGE_SIZE_ARB

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Ian Romanick Reviewed-by: Marek Olšák --- src/mesa/main/get.c | 1 + src/mesa/main/get_hash_params.py | 3 +++ src/mesa/main/mtypes.h | 3 +++ 3 files changed, 7 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index

[Mesa-dev] [PATCH v2 09/25] st/mesa: plumbing for sparse buffers

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_cb_bufferobjects.c | 20 1 file changed, 20 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_bufferobjects.c b/src/mesa/state_tracker/st_cb_bufferobjects.c index 7c202eb..5911d1e 100644 ---

[Mesa-dev] [PATCH v2 08/25] st/mesa: enable ARB_sparse_buffer when supported

2017-03-28 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 16f8685..d363cef 100644 --- a/src/mesa/state_tracker/st_extensi

Re: [Mesa-dev] [RFC 2/3] mesa: always return GL_OUT_OF_MEMORY or GL_NO_ERROR when KHR_no_error enabled

2017-03-28 Thread Timothy Arceri
On 28/03/17 18:10, Gustaw Smolarczyk wrote: 28 mar 2017 06:35 "Timothy Arceri" mailto:tarc...@itsqueeze.com>> napisał(a): --- src/mesa/main/getstring.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c i

[Mesa-dev] [PATCH] AndroidIA: android: Pass sse4.1 flag as appropriate.

2017-03-28 Thread Harish Krupo
We have functions which depend on sse4.1 support but we didnt pass the right compile flag for it. This patch fixes it. Signed-off-by: Kalyan Kondapally Signed-off-by: Harish Krupo --- src/mesa/Android.libmesa_sse41.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/Android.libme

Re: [Mesa-dev] [PATCH 4/5] radv: move calculating fragment shader i/os to pipeline.

2017-03-28 Thread Alex Smith
Hi Dave, This commit is causing some GPU hangs for us, on Polaris cards at least (470 and 480). It also causes hangs in Dota 2 (on the initial logo screen at startup). Seems to be caused by the change to set the SPI_PS_INPUT_CNTL registers with radeon_set_context_reg_seq - changing that to use a

[Mesa-dev] [PATCH 1/2] c11/threads: Include thr/xtimec.h for xtime definition when building with MSVC.

2017-03-28 Thread Jose Fonseca
MSVC has been including a xtime definition in thr/xtimec.h ever since MSVC 2013 (which is the minimum we require for building Mesa), and including it prevents duplicate definitions when it gets included by LLVM. In fact, it looks that MSVC has been including a partial C11 threads implementation to

[Mesa-dev] [PATCH 2/2] appveyor: Update dependencies.

2017-03-28 Thread Jose Fonseca
- Use explicit versions everywhere. - Avoid deprecate `--egg` pip option. --- appveyor.yml | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 6e69cbfb5c..96eb1a67b3 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -34,13 +34,13 @@ branch

Re: [Mesa-dev] [PATCH v2 10/10] swr: [rasterizer codegen] Fix windows build

2017-03-28 Thread Rowley, Timothy O
I’m going to drop patch 10 from the patchset for now. -Tim On Mar 27, 2017, at 9:42 PM, Kyriazis, George mailto:george.kyria...@intel.com>> wrote: Tried Depends(), but it doesn’t work all the time. There are some cases where it works, and some others where it doesn’t. I’ll need to investigat

Re: [Mesa-dev] kmscube on vmwgfx

2017-03-28 Thread Thomas Hellstrom
Hi, Peter, Please see inline. On 03/27/2017 10:37 AM, Peter Hanzel wrote: > Hello. > > I have downloaded kmscube from git://anonogit.freedesktop.org/mesa/kmscube. > I have tried it inside VMware with vmwgfx acceleration. > > The smooth mode works correctly and I see rotating cube. > But I have al

Re: [Mesa-dev] kmscube on vmwgfx

2017-03-28 Thread Peter Hanzel
Hello. I have attached patch and it works now. So thank you very much and hopefully the others will find a way to fix it in mesa-dev. On Tue, Mar 28, 2017 at 2:46 PM, Thomas Hellstrom wrote: > Hi, Peter, > > Please see inline. > > On 03/27/2017 10:37 AM, Peter Hanzel wrote: >> Hello. >> >> I ha

Re: [Mesa-dev] [PATCH 2/2] swr: fix llvm-5.0.0 build bustage

2017-03-28 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Mar 27, 2017, at 1:34 PM, Tim Rowley wrote: > > Handle rename of llvm AttributeSet to AttributeList in the same > fashion as ac_llvm_helper.cpp. > --- > src/gallium/drivers/swr/swr_shader.cpp | 24 +++- > 1 file changed, 15 insertions(+), 9 de

Re: [Mesa-dev] [PATCH 1/2] swr: [rasterizer jitter] fix llvm-5.0.0 build bustage

2017-03-28 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Mar 27, 2017, at 1:34 PM, Tim Rowley wrote: > > Add CreateAlignmentAssumptionHelper to gen_llvm_ir_macros.py ignore list. > --- > src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > >

Re: [Mesa-dev] [PATCH v2 01/10] swr: [rasterizer codegen] Refactor codegen

2017-03-28 Thread Cherniak, Bruce
In light of dropping patch 10/10 (for now), this patch stands as-is. Windows/SCONS build will be addressed in a followup. This patch: Reviewed-by: Bruce Cherniak mailto:bruce.chern...@intel.com>> On Mar 27, 2017, at 7:35 PM, Kyriazis, George mailto:george.kyria...@intel.com>> wrote: With thi

Re: [Mesa-dev] [PATCH 1/2] c11/threads: Include thr/xtimec.h for xtime definition when building with MSVC.

2017-03-28 Thread Roland Scheidegger
For the series: Reviewed-by: Roland Scheidegger Am 28.03.2017 um 13:50 schrieb Jose Fonseca: > MSVC has been including a xtime definition in thr/xtimec.h ever since > MSVC 2013 (which is the minimum we require for building Mesa), and > including it prevents duplicate definitions when it gets inc

Re: [Mesa-dev] [PATCH 2/3] anv: Flush caches prior to PIPELINE_SELECT on all gens

2017-03-28 Thread Emil Velikov
Hi all, On 15 March 2017 at 18:58, Jason Ekstrand wrote: > The programming note that says we need to do this still exists in the > SkyLake PRM and, from looking at the bspec, seems to apply to all > hardware generations SNB+. Also, this seems to be the cause of some of > the GPU hangs we've been

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Reduce number of max descriptor sets to 4.

2017-03-28 Thread Emil Velikov
On 17 March 2017 at 08:42, Bas Nieuwenhuizen wrote: > We never supported more, as we can run out of user SGPRs on the VS. > > Fixes: f4e499ec791 ("radv: add initial non-conformant radv vulkan driver") > Signed-off-by: Bas Nieuwenhuizen > CC: > CC: James Legg > --- > src/amd/vulkan/radv_descrip

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Select pipeline and emit state base address in Gen8+ HiZ ops.

2017-03-28 Thread Emil Velikov
On 21 March 2017 at 03:05, Nanley Chery wrote: > On Mon, Mar 20, 2017 at 08:01:25PM -0700, Nanley Chery wrote: >> On Thu, Mar 16, 2017 at 05:34:13PM -0700, Kenneth Graunke wrote: >> > On Wednesday, March 8, 2017 10:27:20 AM PDT Nanley Chery wrote: >> > > On Wed, Mar 08, 2017 at 10:07:12AM -0800, N

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-03-28 Thread Nicolai Hähnle
On 24.03.2017 22:21, Rob Clark wrote: It's kinda sad that (a) we don't have debug_backtrace support on !X86 and that (b) we re-invent our own crude backtrace support in the first place. If available, use libunwind instead. The backtrace format is based on what xserver and weston use, since it i

[Mesa-dev] [PATCH v2 1/2] intel: android: remove libdrm_intel requirement

2017-03-28 Thread Emil Velikov
From: Emil Velikov The only part which requires libdrm_intel tools/aubinator is not built on Android. Signed-off-by: Emil Velikov --- What was 1/3 of the series has superseded by Ken with commit 0c3fbf8028b6f44a341548d341fa660e6b120647 --- src/intel/Android.blorp.mk| 2 -- src/intel/Andro

[Mesa-dev] [PATCH v2 2/2] intel: automake: move INTEL_CFLAGS as applicable

2017-03-28 Thread Emil Velikov
From: Emil Velikov Only common/decoder.[ch] requires it [for intel_aub.h]. v2: The code was moved to from intel/tools to intel/common, update accordingly. Signed-off-by: Emil Velikov --- src/intel/Makefile.am| 1 - src/intel/Makefile.common.am | 1 + 2 files changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] tests/cache_test: allow crossing mount points

2017-03-28 Thread Nicolai Hähnle
On 25.03.2017 01:40, Juan A. Suarez Romero wrote: When using an overlayfs system (like a Docker container), rmrf_local() fails because part of the files to be removed are in different mount points (layouts). And thus cache-test fails. Can you explain a bit more how this can happen? I thought th

Re: [Mesa-dev] [RFC 1/3] dri: add support for CONTEXT_FLAG_NO_ERROR_BIT_KHR

2017-03-28 Thread Nicolai Hähnle
On 28.03.2017 06:35, Timothy Arceri wrote: The KHR_no_error spec says: "CONTEXT_FLAG_NO_ERROR_BIT_KHR is only supported if the OpenGL version has support for context flags (as defined in the OpenGL 4.5 core spec) or an extension supporting equivalent functionality is exposed." But

Re: [Mesa-dev] [PATCH 2/2] nir: Add support for 8 and 16-bit types

2017-03-28 Thread Jason Ekstrand
Sorry I haven't gotten back on this. It got lost somehow. On Fri, Mar 10, 2017 at 1:56 AM, Iago Toral wrote: > On Thu, 2017-03-09 at 14:05 -0800, Jason Ekstrand wrote: > > --- > > src/compiler/nir/nir.h | 4 > > src/compiler/nir/nir_constant_expressions.py | 16

Re: [Mesa-dev] [PATCH] tests/cache_test: allow crossing mount points

2017-03-28 Thread Juan A. Suarez Romero
On Tue, 2017-03-28 at 16:53 +0200, Nicolai Hähnle wrote: > On 25.03.2017 01:40, Juan A. Suarez Romero wrote: > > When using an overlayfs system (like a Docker container), rmrf_local() > > fails because part of the files to be removed are in different mount > > points (layouts). And thus cache-test

Re: [Mesa-dev] [PATCH 2/2] st/mesa: EGLImageTarget* error handling

2017-03-28 Thread Nicolai Hähnle
On 27.03.2017 12:11, Philipp Zabel wrote: Stop trying to specify texture or renderbuffer objects for unsupported EGL images. Generate the error codes specified in the OES_EGL_image extension. EGLImageTargetTexture2D and EGLImageTargetRenderbuffer would call the pipe driver's create_surface callb

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #1 from Christian Lanig --- I confirm this bug. Dolphin 5.0-741d230-dirty Ubuntu 17.04 with MESA git and Kernel 4.11 RC4 Ryzen 7 1700X RX 480 8GiB 32 DDR4 2933 MHz ECC -- You are receiving this mail because: You are the QA Contact

Re: [Mesa-dev] [PATCH] tests/cache_test: allow crossing mount points

2017-03-28 Thread Nicolai Hähnle
On 28.03.2017 17:32, Juan A. Suarez Romero wrote: On Tue, 2017-03-28 at 16:53 +0200, Nicolai Hähnle wrote: On 25.03.2017 01:40, Juan A. Suarez Romero wrote: When using an overlayfs system (like a Docker container), rmrf_local() fails because part of the files to be removed are in different moun

Re: [Mesa-dev] [PATCH] tests/cache_test: allow crossing mount points

2017-03-28 Thread Juan A. Suarez Romero
On Tue, 2017-03-28 at 17:50 +0200, Nicolai Hähnle wrote: > The crossing happens because I'm running it inside a docker container, > > which uses internally an overlayfs. This means that some of those > > subdirectories can be in one mountpoint and others in other mountpoint. > >   This seems to be

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100430 Christian Lanig changed: What|Removed |Added CC||freedesktop@lanig.email -- You are r

Re: [Mesa-dev] [PATCH 4/4] anv: Use subpass dependencies for flushes

2017-03-28 Thread Jason Ekstrand
Nanley, Mind taking a look at these? On Tue, Mar 14, 2017 at 7:55 AM, Jason Ekstrand wrote: > Instead of figuring it all out ourselves, just use the information given > to us by the client. > --- > src/intel/vulkan/anv_blorp.c | 88 -- > > src/intel/vu

Re: [Mesa-dev] [PATCH] radv: Invalidate L2 for TRANSFER_WRITE barriers

2017-03-28 Thread Emil Velikov
On 22 March 2017 at 10:06, Bas Nieuwenhuizen wrote: > On Tue, Mar 21, 2017 at 1:02 PM, Alex Smith > wrote: >> CP DMA and PKT3_WRITE_DATA (in CmdUpdateBuffer) don't (currently) write >> through L2. Therefore, to make these writes visible to later accesses >> we must invalidate L2 rather than just

Re: [Mesa-dev] [PATCH v5 2/5] isl: Validate the calculated row pitch (v4)

2017-03-28 Thread Chad Versace
On Sat 25 Mar 2017, Jason Ekstrand wrote: > > > On March 24, 2017 7:29:05 PM Chad Versace wrote: > > > Validate that isl_surf::row_pitch fits in the below bitfields, > > if applicable based on isl_surf::usage. > > > > RENDER_SURFACE_STATE::SurfacePitch > > RENDER_SURFACE_STATE::Auxilia

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

2017-03-28 Thread Jose Fonseca
On 28/03/17 00:12, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-27 09:58:59) On 27/03/17 17:42, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-27 09:31:04) On 27/03/17 17:24, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-26 14:53:50) I've pushed the branch to mesa/demos, so we can a

Re: [Mesa-dev] [PATCH v5 2/5] isl: Validate the calculated row pitch (v4)

2017-03-28 Thread Jason Ekstrand
On Tue, Mar 28, 2017 at 9:15 AM, Chad Versace wrote: > On Sat 25 Mar 2017, Jason Ekstrand wrote: > > > > > > On March 24, 2017 7:29:05 PM Chad Versace > wrote: > > > > > Validate that isl_surf::row_pitch fits in the below bitfields, > > > if applicable based on isl_surf::usage. > > > > > > R

Re: [Mesa-dev] [PATCH] radv: Invalidate L2 for TRANSFER_WRITE barriers

2017-03-28 Thread Alex Smith
On 28 March 2017 at 17:09, Emil Velikov wrote: > On 22 March 2017 at 10:06, Bas Nieuwenhuizen > wrote: > > On Tue, Mar 21, 2017 at 1:02 PM, Alex Smith > wrote: > >> CP DMA and PKT3_WRITE_DATA (in CmdUpdateBuffer) don't (currently) write > >> through L2. Therefore, to make these writes visible t

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #2 from Ilia Mirkin --- I suspect you'll greatly increase the likelihood of getting this issue investigated if you include a dolphin fifo log which can be used to reproduce the issue. [Not sure how those are recorded, I'm sure the do

Re: [Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

2017-03-28 Thread Chad Versace
On Sat 25 Mar 2017, Dylan Baker wrote: > Quoting Chad Versace (2017-03-24 19:28:23) > > genX_bits.h contains the sizes of bitfields in genxml instructions, > > structures, and registers. It also defines some functions to query those > > sizes. > > > > isl_surf_init() will use the new header to val

Re: [Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

2017-03-28 Thread Chad Versace
On Sat 25 Mar 2017, Dylan Baker wrote: > Oh, for what it's worth (since I wrote part of this), with the one .keys() > thing > changed: > Reviewed-by: Dylan Baker Thanks ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100430 jdr...@gmail.com changed: What|Removed |Added CC||jdr...@gmail.com -- You are receivin

Re: [Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

2017-03-28 Thread Emil Velikov
Hi Chad, On 25 March 2017 at 02:28, Chad Versace wrote: > genX_bits.h contains the sizes of bitfields in genxml instructions, > structures, and registers. It also defines some functions to query those > sizes. > > isl_surf_init() will use the new header to validate that requested > pitches fit in

Re: [Mesa-dev] [PATCH v2 2/4] si_compute: check NULL return from u_upload_alloc

2017-03-28 Thread Julien Isorce
- if (program->input_size || program->ir_type == PIPE_SHADER_IR_NATIVE) - si_upload_compute_input(sctx, code_object, info); + if ((program->input_size || +program->ir_type == PIPE_SHADER_IR_NATIVE) && +unlikely(!si_upload_compute_input(sctx, code_ob

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #3 from jdr...@gmail.com --- Created attachment 130504 --> https://bugs.freedesktop.org/attachment.cgi?id=130504&action=edit bad colors on MarioKart (fifo) I used the fifo player included in dolphin to record 3 images. -- You are

Re: [Mesa-dev] [PATCH v2 2/4] si_compute: check NULL return from u_upload_alloc

2017-03-28 Thread Julien Isorce
Oops it should be just "return;" here. On 28 March 2017 at 17:52, Julien Isorce wrote: > - if (program->input_size || program->ir_type == > PIPE_SHADER_IR_NATIVE) > - si_upload_compute_input(sctx, code_object, info); > + if ((program->input_size || > +progra

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #4 from jdr...@gmail.com --- Created attachment 130505 --> https://bugs.freedesktop.org/attachment.cgi?id=130505&action=edit White Square on MarioKart (fifo) Same: 3 pictures saved -- You are receiving this mail because: You are

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-28 Thread Emil Velikov
Hi Chad, On 24 March 2017 at 20:44, Chad Versace wrote: > On Tue 21 Mar 2017, Matt Turner wrote: >> On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov >> wrote: >> > On 20 March 2017 at 18:30, Matt Turner wrote: >> >> On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov >> >> wrote: > >> >>> These proj

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #5 from jdr...@gmail.com --- Created attachment 130506 --> https://bugs.freedesktop.org/attachment.cgi?id=130506&action=edit Screen part missing (fifo) Last one recorded with dolphin's fifo player. Hope it helps. -- You are recei

Re: [Mesa-dev] [PATCH v2 2/4] si_compute: check NULL return from u_upload_alloc

2017-03-28 Thread Marek Olšák
On Tue, Mar 28, 2017 at 6:52 PM, Julien Isorce wrote: > - if (program->input_size || program->ir_type == > PIPE_SHADER_IR_NATIVE) > - si_upload_compute_input(sctx, code_object, info); > + if ((program->input_size || > +program->ir_type == PIPE_SHADER_IR_NATIVE

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

2017-03-28 Thread Dylan Baker
Quoting Jose Fonseca (2017-03-28 09:19:48) > On 28/03/17 00:12, Dylan Baker wrote: > > > > Okay, I have libepoxy working for windows. I also got libepoxy working as a > > subproject, but it took a bit of hacking on their build system (there's > > some things they're doing that make them non-subproj

Re: [Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

2017-03-28 Thread Dylan Baker
Quoting Chad Versace (2017-03-28 09:37:56) > On Sat 25 Mar 2017, Dylan Baker wrote: > > > > This is just a suggestion, feel free to ignore > > > > I forgot to do something here, but this is one case where using > > argparse.FileType might actually be the right thing to do. > > > > it would like

[Mesa-dev] [Bug 100425] glGenFramebuffersEXT appears to be null on (some?) Mesa 12.0.6 systems

2017-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100425 --- Comment #4 from Kai Ninomiya --- Thanks Timothy and Timo, if this isn't a major, widely-seen regression in 12.0.6 then there isn't much we can do. If Chromium added a workaround it would also be a few months before the fix is out, so the xen

Re: [Mesa-dev] [PATCH 0/7] Adding more documentation to the release process

2017-03-28 Thread Emil Velikov
Hi Andres, Thanks for the corrections/updates. On 27 March 2017 at 19:48, Andres Gomez wrote: > A series of patches adding more details to the release process. > > Andres Gomez (7): > docs/releasing: format/style homogenization > docs/releasing: check in master for forgotten nomination candi

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

2017-03-28 Thread Brian Paul
On 03/28/2017 11:19 AM, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-28 09:19:48) On 28/03/17 00:12, Dylan Baker wrote: Okay, I have libepoxy working for windows. I also got libepoxy working as a subproject, but it took a bit of hacking on their build system (there's some things they're do

Re: [Mesa-dev] [PATCH] radv: Invalidate L2 for TRANSFER_WRITE barriers

2017-03-28 Thread Bas Nieuwenhuizen
On Tue, Mar 28, 2017 at 6:31 PM, Alex Smith wrote: > On 28 March 2017 at 17:09, Emil Velikov wrote: >> >> On 22 March 2017 at 10:06, Bas Nieuwenhuizen >> wrote: >> > On Tue, Mar 21, 2017 at 1:02 PM, Alex Smith >> > wrote: >> >> CP DMA and PKT3_WRITE_DATA (in CmdUpdateBuffer) don't (currently) w

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Reduce number of max descriptor sets to 4.

2017-03-28 Thread Bas Nieuwenhuizen
On Tue, Mar 28, 2017 at 4:12 PM, Emil Velikov wrote: > On 17 March 2017 at 08:42, Bas Nieuwenhuizen wrote: >> We never supported more, as we can run out of user SGPRs on the VS. >> >> Fixes: f4e499ec791 ("radv: add initial non-conformant radv vulkan driver") >> Signed-off-by: Bas Nieuwenhuizen >

Re: [Mesa-dev] [PATCH v2 1/2] intel: android: remove libdrm_intel requirement

2017-03-28 Thread Kenneth Graunke
On Tuesday, March 28, 2017 7:47:39 AM PDT Emil Velikov wrote: > From: Emil Velikov > > The only part which requires libdrm_intel tools/aubinator is not built > on Android. > > Signed-off-by: Emil Velikov > --- > What was 1/3 of the series has superseded by Ken with commit > 0c3fbf8028b6f44a3415

Re: [Mesa-dev] [PATCH] st/nine: Fix support for ps 1.4 dw and dz modifiers

2017-03-28 Thread Axel Davy
This probably should be CC Mesa 17 stable. I'll add it before push. On 26/03/2017 23:00, Axel Davy wrote: RCP was used incorrectly to support NINED3DSPSM_DW and NINED3DSPSM_DZ. src.x as used as input instead of src.w or src.z. Fixes: https://github.com/iXit/Mesa-3D/issues/271 Signed-off-by: Ax

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

2017-03-28 Thread Edmondo Tommasina
On Mon, Mar 27, 2017 at 11:32 PM, Eric Anholt wrote: > Edmondo Tommasina writes: > >> On Mon, Mar 27, 2017 at 6:05 PM, Eric Anholt wrote: >>> Edmondo Tommasina writes: >>> Define a new MESA_USER_DRIRC environment variable to load a customized drirc file. When the variable is

Re: [Mesa-dev] [PATCH 4/5] radv: move calculating fragment shader i/os to pipeline.

2017-03-28 Thread Dave Airlie
On 28 March 2017 at 21:05, Alex Smith wrote: > Hi Dave, > > This commit is causing some GPU hangs for us, on Polaris cards at least (470 > and 480). > > It also causes hangs in Dota 2 (on the initial logo screen at startup). > > Seems to be caused by the change to set the SPI_PS_INPUT_CNTL registe

Re: [Mesa-dev] [PATCH 03/11] etnaviv: add basic shader variant support

2017-03-28 Thread Christian Gmeiner
Hi Lucas, 2017-03-27 10:56 GMT+02:00 Lucas Stach : > Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner: >> This commit adds some basic infrastructure to handle shader >> variants. We are still creating exactly one shader variant >> for each shader. >> >> Signed-off-by: Christian G

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

2017-03-28 Thread Eric Anholt
Edmondo Tommasina writes: > On Mon, Mar 27, 2017 at 11:32 PM, Eric Anholt wrote: >> Edmondo Tommasina writes: >> >>> On Mon, Mar 27, 2017 at 6:05 PM, Eric Anholt wrote: Edmondo Tommasina writes: > Define a new MESA_USER_DRIRC environment variable to load a customized > drirc

Re: [Mesa-dev] [PATCH 4/5] r600g: use a clever alignment for index buffer uploads

2017-03-28 Thread Marek Olšák
BTW, I don't know if tcc_cache_line_size has the correct value for pre-GCN chips. Marek On Sun, Mar 26, 2017 at 5:36 PM, Constantine Kharlamov wrote: > Stolen from radeonsi > > Signed-off-by: Constantine Kharlamov > --- > src/gallium/drivers/r600/r600_state_common.c | 3 ++- > 1 file changed,

Re: [Mesa-dev] [PATCH 4/5] r600g: use a clever alignment for index buffer uploads

2017-03-28 Thread Constantine Kharlamov
Ok, I can look it up. Is there some docs where I find the right alignment value? On 28.03.2017 22:33, Marek Olšák wrote: > BTW, I don't know if tcc_cache_line_size has the correct value for > pre-GCN chips. > > Marek > > On Sun, Mar 26, 2017 at 5:36 PM, Constantine Kharlamov > wrote: >> Stolen

Re: [Mesa-dev] [PATCH 4/5] r600g: use a clever alignment for index buffer uploads

2017-03-28 Thread Marek Olšák
Actually nevermind. Patches 1-3: Reviewed-by: Marek Olšák Patches 4-5: These have no effect, because r600g hw doesn't use TC for index fetches. Marek On Tue, Mar 28, 2017 at 9:33 PM, Marek Olšák wrote: > BTW, I don't know if tcc_cache_line_size has the correct value for > pre-GCN chips. > >

[Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-28 Thread Thomas Hellstrom
Drivers may queue dma operations on the context at unmap time so we need to flush to make sure the data gets to the bo. Ideally the application would take care of this, but since there appears to be no exported gbm flush functionality we need to explicitly flush at unmap time. This fixes a problem

Re: [Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

2017-03-28 Thread Chad Versace
On Tue 28 Mar 2017, Emil Velikov wrote: > Hi Chad, > > On 25 March 2017 at 02:28, Chad Versace wrote: > > genX_bits.h contains the sizes of bitfields in genxml instructions, > > structures, and registers. It also defines some functions to query those > > sizes. > > > > isl_surf_init() will use th

Re: [Mesa-dev] [PATCH v2 05/25] gallium: add sparse buffer interface and capability

2017-03-28 Thread Marek Olšák
On Tue, Mar 28, 2017 at 11:11 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > TODO fill out caps in all drivers > > v2: > - explain the resource_commit interface in more detail > --- > src/gallium/docs/source/context.rst | 25 + > src/gallium/docs/source/screen.rst

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

2017-03-28 Thread Edmondo Tommasina
On Tue, Mar 28, 2017 at 9:31 PM, Eric Anholt wrote: > Edmondo Tommasina writes: > >> On Mon, Mar 27, 2017 at 11:32 PM, Eric Anholt wrote: >>> Edmondo Tommasina writes: >>> On Mon, Mar 27, 2017 at 6:05 PM, Eric Anholt wrote: > Edmondo Tommasina writes: > >> Define a new MESA_U

Re: [Mesa-dev] [PATCH v2 07/25] trace: add resource_commit pass-through

2017-03-28 Thread Marek Olšák
Patches 6 & 7 return void, but patch 5 defines the return type as bool. With those fixed, patches 5-7 are: Reviewed-by: Marek Olšák Marek On Tue, Mar 28, 2017 at 11:11 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/trace/tr_context.c | 20

Re: [Mesa-dev] [PATCH 07/11] etnaviv: add etna_shader_key and generate variants if needed

2017-03-28 Thread Christian Gmeiner
Hi Lucas >> diff --git a/src/gallium/drivers/etnaviv/etnaviv_shader.h >> b/src/gallium/drivers/etnaviv/etnaviv_shader.h >> index 9f26bef..b0d97a7 100644 >> --- a/src/gallium/drivers/etnaviv/etnaviv_shader.h >> +++ b/src/gallium/drivers/etnaviv/etnaviv_shader.h >> @@ -32,6 +32,21 @@ >> struct etn

Re: [Mesa-dev] [PATCH 09/11] etnaviv: adopt shader-db output for variant support

2017-03-28 Thread Christian Gmeiner
Hi Lucas 2017-03-27 10:43 GMT+02:00 Lucas Stach : > Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner: >> Signed-off-by: Christian Gmeiner > > s/adopt/adapt in the subject > Fixed locally. > Reviewed-by: Lucas Stach > greets -- Christian Gmeiner, MSc https://www.youtube.com/u

Re: [Mesa-dev] [PATCH 10/11] etnaviv: add support for rb swap

2017-03-28 Thread Christian Gmeiner
Hi Lucas 2017-03-27 10:40 GMT+02:00 Lucas Stach : > Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner: >> If we render to rb swapped format we will create a shader variant doing >> the involved swizzing in the pixel shader. >> >> Signed-off-by: Christian Gmeiner >> --- >> src/ga

  1   2   >