[Mesa-dev] [Bug 100223] marshal_generated.c:38:10: fatal error: 'X11/Xlib-xcb.h' file not found

https://bugs.freedesktop.org/show_bug.cgi?id=100223 Vinson Lee changed: What|Removed |Added CC||die...@nuetzel-hh.de, |

Re: [Mesa-dev] [PATCH v3] anv: handle failures when growing reloc lists

On Wed, 2017-03-15 at 16:56 +0200, Pohjolainen, Topi wrote: > On Wed, Mar 15, 2017 at 01:03:37PM +0100, Iago Toral Quiroga wrote: > > > > Growing the reloc list happens through calling anv_reloc_list_add() > > or > > anv_reloc_list_append(). Make sure that we call these through > > helpers > > tha

Re: [Mesa-dev] [PATCH] genxml: Add XML version tags

Reviewed-by: Lionel Landwerlin On 16/03/17 05:56, Jason Ekstrand wrote: There's not much point to having them or not having them but this reduces some pointless diff from the version we can auto-generate --- src/intel/genxml/gen4.xml | 1 + src/intel/genxml/gen45.xml | 1 + src/intel/genxm

Re: [Mesa-dev] [PATCH 1/4] aubinator: Fix indentation.

Thanks for the cleanups! This series is : Reviewed-by: Lionel Landwerlin On 16/03/17 03:01, Kenneth Graunke wrote: Three space, not four. --- src/intel/tools/aubinator.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/inte

[Mesa-dev] [PATCH] i965/gen8+: Do full stall when switching pipeline

just as earlier gens do. CC: Jason Ekstrand Cc: "17.0 13.0" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96743 Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH v2] android: fix segfault within swap_buffers

Function droid_swap_buffers may get called without dri2_surf->buffer set, in these cases we don't have a back buffer set either. Patch fixes segfault seen with 3DMark that uses android.opengl.GLSurfaceView for rendering it's UI. backtrace: #00 pc 00013f88 /system/lib/egl/libGLES_mesa.so (droid

[Mesa-dev] [Bug 100223] marshal_generated.c:38:10: fatal error: 'X11/Xlib-xcb.h' file not found

https://bugs.freedesktop.org/show_bug.cgi?id=100223 --- Comment #2 from Tapani Pälli --- FYI we are getting this error also on Android where 'X11/Xlib-xcb.h' does not exist -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

Re: [Mesa-dev] [PATCH 12/12] anv: implement pipeline statistics queries

On Wed, 2017-03-15 at 17:03 -0700, Jason Ekstrand wrote: > From: Ilia Mirkin > > In the end, pipeline statistics queries look a lot like occlusion > queries only with between 1 and 11 begin/end pairs being generated > instead of just the one. > --- >  src/intel/vulkan/anv_device.c  |   2 +- >  sr

[Mesa-dev] [PATCH] android: add marshal_generated c and h files to generated sources

Fixes: efd63e2 ("mesa: Connect the generated GL command marshalling code to the build.") Signed-off-by: Tapani Pälli --- src/mesa/Android.gen.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/Android.gen.mk b/src/mesa/Android.gen.mk index a1e58a6..42d4ba1 100644

Re: [Mesa-dev] [PATCH v3] anv: handle failures when growing reloc lists

On Thu, Mar 16, 2017 at 08:56:30AM +0100, Iago Toral wrote: > On Wed, 2017-03-15 at 16:56 +0200, Pohjolainen, Topi wrote: > > On Wed, Mar 15, 2017 at 01:03:37PM +0100, Iago Toral Quiroga wrote: > > > > > > Growing the reloc list happens through calling anv_reloc_list_add() > > > or > > > anv_reloc

[Mesa-dev] [Bug 100223] marshal_generated.c:38:10: fatal error: 'X11/Xlib-xcb.h' file not found

https://bugs.freedesktop.org/show_bug.cgi?id=100223 --- Comment #3 from Tapani Pälli --- IMO there should be a check if X11 exists or maybe removal of include if this code does not utilize Xlib/Xcb? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

Re: [Mesa-dev] [PATCH 1/3] anv/cmd_buffer: Fix bad indentation

All 3 patches are: Reviewed-by: Iago Toral Quiroga On Wed, 2017-03-15 at 11:58 -0700, Jason Ekstrand wrote: > A bunch of code was indented in such a way that it looked like it > went > with the if statement above but it definitely didn't. > > Cc: "17.0 13.0" > --- >  src/intel/vulkan/genX_cmd_

[Mesa-dev] [Bug 99987] Mesa 13+ breaks Xvnc (and similar X servers)

https://bugs.freedesktop.org/show_bug.cgi?id=99987 --- Comment #20 from Pierre Ossman --- Sorry, you're right. I misread this part when it was originally posted: "Libglvnd relies on a GLX extension to..." I interpreted it as "Libglvnd relies on ...", which was obviously present in my test cases

[Mesa-dev] [PATCH v4] anv: handle failures when growing reloc lists

Growing the reloc list happens through calling anv_reloc_list_add() or anv_reloc_list_append(). Make sure that we call these through helpers that check the result and set the batch error status if needed. v2: - Handling the crashes is not good enough, we need to keep track of the error, for

Re: [Mesa-dev] [PATCH 6/4] radv: make use of on-disk cache

Hi, On 16 March 2017 at 00:43, Timothy Arceri wrote: > > On 16/03/17 11:10, Jason Ekstrand wrote: > >> On Tue, Mar 14, 2017 at 10:57 PM, Timothy Arceri > > wrote: >> >> If the app provided and in-memory pipeline caches don't contain >> what we are looking fo

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with Visual Studio 2015 toolchain and LLVM 4.0 fails

https://bugs.freedesktop.org/show_bug.cgi?id=100201 --- Comment #2 from Anonymous Helper --- After discovering 100202 I worked around by installing the optional Visual Studio 2015.3 toolchain. When releasing a new version of Visual Studio, Microsoft provides the previous version toolchain as an o

[Mesa-dev] [PATCH mesa] docs/specs: update Khronos registries URLs

The registries were migrated to git and are now hosted on GitHub. The old svn is now read-only, and will not be updated anymore. Signed-off-by: Eric Engestrom --- docs/specs/enums.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/specs/enums.txt b/docs/specs/en

Re: [Mesa-dev] [PATCHi V2] spec: MESA_program_binary

On Thursday, 2017-03-16 14:36:48 +1100, Timothy Arceri wrote: > In order to add functionality for OES_get_program_binary and > ARB_get_program_binary we need a binary format enum. > > V2: share a single enum for all mesa drivers. > > Cc: Ian Romanick > --- > > Hi Ian, > > Did you find out if M

Re: [Mesa-dev] [PATCH 3/3] hud_context: check NULL return from u_upload_alloc

On Mar 16, 2017 3:56 AM, "Emil Velikov" wrote: On 13 March 2017 at 16:44, Marek Olšák wrote: > Hi, > > I've pushed the series with small commit message changes. > Hmm crash fixes - do we want these for stable, Marek ? You can pick it up if you want. I don't think it's important. Marek -Emil

Re: [Mesa-dev] [PATCH 00/12] anv: Queries!

Patches 1-3 are : Reviewed-by: Lionel Landwerlin On 16/03/17 00:03, Jason Ekstrand wrote: This little patch series does a number of things. The first three patches fix bugs in the current query code. These bugs have been causing rendering corruptions in The Talos Principle. The next 8 patch

Re: [Mesa-dev] [PATCH v4] anv: handle failures when growing reloc lists

On Thu, Mar 16, 2017 at 10:47:59AM +0100, Iago Toral Quiroga wrote: > Growing the reloc list happens through calling anv_reloc_list_add() or > anv_reloc_list_append(). Make sure that we call these through helpers > that check the result and set the batch error status if needed. > > v2: > - Handl

Re: [Mesa-dev] [PATCH 04/12] genxml: Make MI_STORE_DATA_IMM have a single 64-bit data field

I might be wrong, but are you sure it's a good idea? The documentation says that dword0 is the lower 32bits of a qword and dword1 the upper bits. With this change we now make it look like it's a regular 64 bits number but it actually isn't. On 16/03/17 00:03, Jason Ekstrand wrote: This is w

Re: [Mesa-dev] [PATCH 00/12] anv: Queries!

On Wed, 2017-03-15 at 17:03 -0700, Jason Ekstrand wrote: > This little patch series does a number of things.  The first three > patches > fix bugs in the current query code.  These bugs have been causing > rendering > corruptions in The Talos Principle.  The next 8 patches are various > clean-ups a

Re: [Mesa-dev] [PATCH 06/12] anv/query: Move the available bits to the front

It feels like using offsetof() would prevent surprises in case we change the order again. On 16/03/17 00:03, Jason Ekstrand wrote: We're about to make slots variable-length and always having the available bits at the front makes certain operations substantially easier once we do that. --- src

[Mesa-dev] [Bug 100227] gl_marshal.py: generating duplicate declaration specifiers

https://bugs.freedesktop.org/show_bug.cgi?id=100227 Bug ID: 100227 Summary: gl_marshal.py: generating duplicate declaration specifiers Product: Mesa Version: git Hardware: Other OS: All Status: N

[Mesa-dev] [Bug 100227] gl_marshal.py: generating duplicate declaration specifiers

https://bugs.freedesktop.org/show_bug.cgi?id=100227 --- Comment #1 from Tapani Pälli --- Created attachment 130255 --> https://bugs.freedesktop.org/attachment.cgi?id=130255&action=edit attempt to fix warnings this was my 1st attempt to fix this -- You are receiving this mail because: You are

[Mesa-dev] [PATCH] mapi: remove Xlib/xcb include in gl_marshal.py

From: Emil Velikov The only use of it was to provide the _X_INLINE macro. We already require (and provide where needed) 'inline', not to mention that it's used in the file already. So replace the macro and drop the include. This fixes the build on platforms which lack the headers - from X-less L

Re: [Mesa-dev] [PATCH] mapi: remove Xlib/xcb include in gl_marshal.py

nice! Reviewed-by: Tapani Pälli On 03/16/2017 01:09 PM, Emil Velikov wrote: From: Emil Velikov The only use of it was to provide the _X_INLINE macro. We already require (and provide where needed) 'inline', not to mention that it's used in the file already. So replace the macro and drop the

Re: [Mesa-dev] [PATCH mesa] docs/specs: update Khronos registries URLs

lgtm. Reviewed-by: Plamena Manolova On Thu, Mar 16, 2017 at 12:02 PM, Eric Engestrom wrote: > The registries were migrated to git and are now hosted on GitHub. > The old svn is now read-only, and will not be updated anymore. > > Signed-off-by: Eric Engestrom > --- > docs/specs/enums.txt | 8 +

Re: [Mesa-dev] [PATCH] android: add marshal_generated c and h files to generated sources

Reviewed-by: Plamena Manolova On Thu, Mar 16, 2017 at 11:24 AM, Tapani Pälli wrote: > Fixes: efd63e2 ("mesa: Connect the generated GL command marshalling code > to the build.") > Signed-off-by: Tapani Pälli > --- > src/mesa/Android.gen.mk | 4 +++- > 1 file changed, 3 insertions(+), 1 deletio

Re: [Mesa-dev] [PATCH] util/build-id: check dlpi_name before strstr call

Reviewed-by: Plamena Manolova On Thu, Mar 16, 2017 at 8:10 AM, Tapani Pälli wrote: > According to dl_iterate_phdr man page first object visited is the > main program where dlpi_name is an empty string. This fixes segfault > on Android when using build-id as identifier. > > Signed-off-by: Tapani

Re: [Mesa-dev] [PATCH 00/12] anv: Queries!

Patches 5-11 are also : Reviewed-By: Lionel Landwerlin On 16/03/17 00:03, Jason Ekstrand wrote: This little patch series does a number of things. The first three patches fix bugs in the current query code. These bugs have been causing rendering corruptions in The Talos Principle. The next 8

[Mesa-dev] [PATCH] st/mesa: call glthread_destroy() before _vbo_DestroyContext()

Otherwise we have a race condition between vbo calls in the glthread and the _vbo_DestroyContext() call. This fixes a bunch of piglit crashes. --- src/mesa/main/context.c | 2 -- src/mesa/state_tracker/st_context.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [Mesa-dev] [PATCH] util/build-id: check dlpi_name before strstr call

On 16 March 2017 at 06:10, Tapani Pälli wrote: > According to dl_iterate_phdr man page first object visited is the > main program where dlpi_name is an empty string. This fixes segfault > on Android when using build-id as identifier. > > Signed-off-by: Tapani Pälli > --- > src/util/build_id.c |

Re: [Mesa-dev] [PATCH v2] android: fix segfault within swap_buffers

On 16 March 2017 at 08:55, Tapani Pälli wrote: > Function droid_swap_buffers may get called without dri2_surf->buffer set, > in these cases we don't have a back buffer set either. Patch fixes segfault > seen with 3DMark that uses android.opengl.GLSurfaceView for rendering it's UI. > > backtrace: >

Re: [Mesa-dev] [PATCH] android: add marshal_generated c and h files to generated sources

On 16 March 2017 at 09:24, Tapani Pälli wrote: > Fixes: efd63e2 ("mesa: Connect the generated GL command marshalling code to > the build.") > Signed-off-by: Tapani Pälli > --- > src/mesa/Android.gen.mk | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/Android.

Re: [Mesa-dev] [PATCH] mapi: remove Xlib/xcb include in gl_marshal.py

On 16/03/17 22:09, Emil Velikov wrote: From: Emil Velikov The only use of it was to provide the _X_INLINE macro. We already require (and provide where needed) 'inline', not to mention that it's used in the file already. I see, thanks. Please push this. Reviewed-by: Timothy Arceri So re

[Mesa-dev] [Bug 92361] [BSW SKL] Regression: glx@glx-copy-sub-buffer failed

https://bugs.freedesktop.org/show_bug.cgi?id=92361 cprigent changed: What|Removed |Added Assignee|christophe.prig...@intel.co |jairo.daniel.miramontes.cat

Re: [Mesa-dev] [PATCH 08/11] st/va: clear the video surface on allocation

Christian König wrote: From: Christian König This makes debugging of decoding problems quite a bit easier. This breaks gstreamer encode for me. ffmpeg is OK, but then IIRC ffmpeg only uses one of something that gstreamer uses two of, not wishing to get too technical here :-) Whatever the ca

[Mesa-dev] [Bug 92366] [BSW SKL] Regression: glx@glx-swap-event_async failed

https://bugs.freedesktop.org/show_bug.cgi?id=92366 cprigent changed: What|Removed |Added Assignee|ramix.ben.hass...@intel.com |jairo.daniel.miramontes.cat

Re: [Mesa-dev] [PATCH 7/7] util/disk_cache: also write key_blob to cache entry

On Thu, Mar 16, 2017 at 3:28 AM, Timothy Arceri wrote: > On 16/03/17 10:09, Grazvydas Ignotas wrote: >> >> This can be used to deal with key hash collisions from different >> version (should we find that to actually happen) and to find >> which mesa version produced it the entry. >> >> Signed-off-

[Mesa-dev] [Bug 100075] st/va raises segmentation fault while using videotestsrc with gstreamer

https://bugs.freedesktop.org/show_bug.cgi?id=100075 --- Comment #1 from Julien Isorce --- Thx Gurkirpal for the report. The other day I was going further into https://bugzilla.gnome.org/show_bug.cgi?id=779642 and I wonder if it is not the same issue in the end, see its commet #6. -- You are re

Re: [Mesa-dev] [PATCH 6/7] util/disk_cache: add a write helper

On Thu, Mar 16, 2017 at 3:00 AM, Timothy Arceri wrote: > > > On 16/03/17 10:09, Grazvydas Ignotas wrote: >> >> Simplifies the write code a bit and handles EINTR. >> >> Signed-off-by: Grazvydas Ignotas >> --- >> src/util/disk_cache.c | 40 ++-- >> 1 file change

Re: [Mesa-dev] [PATCH 5/7] util/disk_cache: hash pointer size and gpu name into cache keys

On Thu, Mar 16, 2017 at 2:49 AM, Timothy Arceri wrote: > > > On 16/03/17 10:09, Grazvydas Ignotas wrote: >> >> This allows to get rid of the arch and gpu name directories. >> Also, gpu_name is now optional. >> >> Signed-off-by: Grazvydas Ignotas >> --- >> src/compiler/glsl/tests/cache_test.c | 1

Re: [Mesa-dev] [PATCH 7/7] util/disk_cache: also write key_blob to cache entry

On 16/03/17 23:40, Grazvydas Ignotas wrote: On Thu, Mar 16, 2017 at 3:28 AM, Timothy Arceri wrote: On 16/03/17 10:09, Grazvydas Ignotas wrote: This can be used to deal with key hash collisions from different version (should we find that to actually happen) and to find which mesa version produ

Re: [Mesa-dev] [PATCH 6/7] util/disk_cache: add a write helper

On 16/03/17 23:53, Grazvydas Ignotas wrote: On Thu, Mar 16, 2017 at 3:00 AM, Timothy Arceri wrote: On 16/03/17 10:09, Grazvydas Ignotas wrote: Simplifies the write code a bit and handles EINTR. Signed-off-by: Grazvydas Ignotas --- src/util/disk_cache.c | 40 ++--

Re: [Mesa-dev] [PATCH 5/7] util/disk_cache: hash pointer size and gpu name into cache keys

On 17/03/17 00:00, Grazvydas Ignotas wrote: On Thu, Mar 16, 2017 at 2:49 AM, Timothy Arceri wrote: On 16/03/17 10:09, Grazvydas Ignotas wrote: This allows to get rid of the arch and gpu name directories. Also, gpu_name is now optional. Signed-off-by: Grazvydas Ignotas --- src/compiler/

Re: [Mesa-dev] [PATCH] mapi: remove Xlib/xcb include in gl_marshal.py

On 16 March 2017 at 12:26, Timothy Arceri wrote: > On 16/03/17 22:09, Emil Velikov wrote: >> >> From: Emil Velikov >> >> The only use of it was to provide the _X_INLINE macro. We already >> require (and provide where needed) 'inline', not to mention that it's >> used in the file already. > > > I

Re: [Mesa-dev] [PATCH] mesa: disable glthread when glNewList() is called

Please ignore this the correct fix is: https://patchwork.freedesktop.org/patch/144360/ ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] docs/releasing: document how to squash/announce queued patches

On 15 March 2017 at 19:05, Eric Engestrom wrote: > On Wednesday, 2017-03-15 17:34:26 +, Emil Velikov wrote: >> From: Emil Velikov >> >> In the odd case where a patch needs to be fixed, squash the appropriate >> fix and document how. Add a note in the pre-release notes, such that >> devs can q

Re: [Mesa-dev] [PATCH] android: i965: generate code for OA counter queries

On 13 March 2017 at 22:36, Mauro Rossi wrote: > 2017-03-13 14:00 GMT+01:00 Emil Velikov : >> >> On 12 March 2017 at 23:01, Mauro Rossi wrote: >> > Automake generation rules are replicated for android. >> > $* macro was expected to return "hsw" but instead gives "hsw.{h,c}" >> > so $(basename $*)

Re: [Mesa-dev] [PATCH 5/7] util/disk_cache: hash pointer size and gpu name into cache keys

On Thu, Mar 16, 2017 at 3:14 PM, Timothy Arceri wrote: > > > On 17/03/17 00:00, Grazvydas Ignotas wrote: >> >> On Thu, Mar 16, 2017 at 2:49 AM, Timothy Arceri >> wrote: >>> >>> >>> >>> On 16/03/17 10:09, Grazvydas Ignotas wrote: This allows to get rid of the arch and gpu name direc

Re: [Mesa-dev] [PATCH] i965: avoid using a GNU make pattern rule

On 16 March 2017 at 02:49, Jonathan Gray wrote: > % pattern rules are a GNU extension. As there is only one file here > avoid patterns and globbing entirely to fix the build on non-GNU make. > > Signed-off-by: Jonathan Gray > --- > src/mesa/drivers/dri/i965/Makefile.am | 8 > 1 file ch

Re: [Mesa-dev] [PATCH] i965: remove uneeded asm/unistd.h include

On 16 March 2017 at 02:48, Jonathan Gray wrote: > Fix the build on OpenBSD by removing an uneeded include for asm/unistd.h. > > Signed-off-by: Jonathan Gray Reviewed-by: Emil Velikov and push both of your patches. Thank you Jonathan, wish we had a person like you in FreeBSD/Solaris/other :-) -

[Mesa-dev] [PATCH 1/6] radeon: initialize hole variable before calling container_of

Like in a few other places in that radeon_drm_bo.c file. CID 715739. Signed-off-by: Julien Isorce --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b/src/gallium/winsys/radeon/drm/

[Mesa-dev] [PATCH 0/6] Fixes a few radeon issues found by Coverity

CID 1399479: medium CID 1237295: medium CID 1313492: medium CID 1354483: medium CID 1250588: high CID 715739: high It is all more cosmetic than anything but worth to add some more checks. To Emil: thx for your reply about "question about container_of". Here is a cosmetic patch for it. https://sc

[Mesa-dev] [PATCH 2/6] r600_shader.c: check validity of the value returned by eg_get_interpolator_index

Like done in another place in that same file. Not sure if this should be an assert though. CID 1250588 Signed-off-by: Julien Isorce --- src/gallium/drivers/r600/r600_shader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/

[Mesa-dev] [PATCH 3/6] si_pipe: do not dereference sscreen before checking if it is NULL.

CID 1354483 Signed-off-by: Julien Isorce --- src/gallium/drivers/radeonsi/si_pipe.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index a9a7c8f..6cbaa72 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 6/6] si_descriptor: move velems nullity check before dereference

CID 1399479: Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking velems suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Signed-off-by: Julien Isorce --- src/gallium/drivers/radeonsi/si_descriptors.c | 15 +++

[Mesa-dev] [PATCH 5/6] si_blit: check zstex nullity

Few lines before there is a if (zstex && zstex->htile_buffer ...) which tells that there are some situation where it can be NULL. So let's check for its nullity in other places too. Spotted by coverity: CID 1237295 Signed-off-by: Julien Isorce --- src/gallium/drivers/radeonsi/si_blit.c | 6 +++

[Mesa-dev] [PATCH 4/6] radeon_drm_bo: explicitly check return value of drmCommandWriteRead

CID 1313492 Signed-off-by: Julien Isorce --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b/src/gallium/winsys/radeon/drm/radeon_drm_bo.c index f4ed3ce..f6d5c8a 100644 ---

Re: [Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

Hi Ben, On 13 March 2017 at 21:47, Ben Widawsky wrote: > On 17-03-10 10:28:42, Emil Velikov wrote: >> >> Hi Ben, >> >> Mostly pointing out a few things that look strange, pardon if some >> seem too pedantic. >> >> On 10 March 2017 at 01:48, Ben Widawsky wrote: >> >>> --- >>> include/GL/internal

[Mesa-dev] [PATCH] mesa: more unused linux/version.h include

From: Emil Velikov The header provides the LINUX_VERSION_CODE and KERNEL_VERSION macros. With neither of which being used by any part of mesa. Signed-off-by: Emil Velikov --- src/mesa/x86/common_x86.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/x86/common_x86.c b/src/mesa/x8

Re: [Mesa-dev] [PATCH 04/12] genxml: Make MI_STORE_DATA_IMM have a single 64-bit data field

On Thu, Mar 16, 2017 at 3:24 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > I might be wrong, but are you sure it's a good idea? > > The documentation says that dword0 is the lower 32bits of a qword and > dword1 the upper bits. > With this change we now make it look like it's a re

Re: [Mesa-dev] [PATCH] i965/gen8+: Do full stall when switching pipeline

Thanks for tracking this down! Reviewed-by: Jason Ekstrand I'm not sure how we missed this when CS was brought up. Oh well. On Thu, Mar 16, 2017 at 1:24 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > just as earlier gens do. > > CC: Jason Ekstrand > Cc: "17.0 13.0" > Bugzilla:

Re: [Mesa-dev] [PATCH] util/build-id: check dlpi_name before strstr call

On Wed, Mar 15, 2017 at 11:10 PM, Tapani Pälli wrote: > According to dl_iterate_phdr man page first object visited is the > main program where dlpi_name is an empty string. This fixes segfault > on Android when using build-id as identifier. If Android's libc returns dlpi_name as a NULL pointer fo

[Mesa-dev] [PATCH] radv/ac: Fix shared memory offset calculation

The index passed to get_shared_memory_ptr is an attribute slot index, i.e. the index of a vec4 within LDS. Therefore this must be scaled by sizeof(vec4) to give the LDS byte offset. Signed-off-by: Alex Smith --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [Mesa-dev] [PATCH] radv/ac: Fix shared memory offset calculation

On 16 March 2017 at 16:40, Alex Smith wrote: > The index passed to get_shared_memory_ptr is an attribute slot index, > i.e. the index of a vec4 within LDS. Therefore this must be scaled by > sizeof(vec4) to give the LDS byte offset. > Whoever is reviewing/merging this patch please add the followin

Re: [Mesa-dev] [PATCH kmscube] cube-tex: Handle SMOOTH switch case

On 16 March 2017 at 00:27, Eric Engestrom wrote: > On Wednesday, 2017-03-15 18:56:53 -0300, Fabio Estevam wrote: >> In kmscube.c there is the following logic: >> >> if (mode == SMOOTH) { >> egl = init_cube_smooth(gbm); >> } else { >> egl = init_cube_tex(gbm,

[Mesa-dev] [PATCH] util/disk_cache: pass predicate functions file stats directly (v3)

Since switching to LRU eviction the only user of these predicate functions now resolves directory entry stats itself so pass them directly saving calling fstat and strlen twice (and the expensive strlen is skipped entirely if access time is newer). v2: Update for empty cache dir detection changes

[Mesa-dev] [PATCH] radv: Fix using more than 4 bound descriptor sets

Avoid a buffer overflow in ac_nir_to_llvm.c's create_function when using more than 4 descriptor sets. radv claims support for 8. Cc: 17.0 --- src/amd/common/ac_nir_to_llvm.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.h b/src/amd/common/ac

Re: [Mesa-dev] MESA and KOTOR

Patch for implementing WGL_ARB_make_current_read attached. I can’t test it at the moment since I’m not near my Windows development environment. Let me know what you find. -Brian 0001-st-wgl-add-support-for-WGL_ARB_make_current_read.patch Description: Binary data > On Mar 15, 2017, at 12:2

[Mesa-dev] [Bug 100236] Undefined symbols for architecture x86_64: "typeinfo for llvm::RTDyldMemoryManager"

https://bugs.freedesktop.org/show_bug.cgi?id=100236 Bug ID: 100236 Summary: Undefined symbols for architecture x86_64: "typeinfo for llvm::RTDyldMemoryManager" Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [Bug 100236] Undefined symbols for architecture x86_64: "typeinfo for llvm::RTDyldMemoryManager"

https://bugs.freedesktop.org/show_bug.cgi?id=100236 --- Comment #1 from Emil Velikov --- Interesting - this might be related to my pthread-stubs patches. Vinson, please provide a complete configure line alongside the summary and more information about the platform/setup. -- You are receiving t

Re: [Mesa-dev] [PATCH 00/28] update swr rasterizer

On Mar 15, 2017, at 9:59 PM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: Hi Tim, On 16 March 2017 at 00:12, Tim Rowley mailto:timothy.o.row...@intel.com>> wrote: Hightlights include: lots of simd16 work, assert rework, and autogen changes (scripts centralized, one file added, two rem

[Mesa-dev] [PATCH 02/32] swr: [rasterizer core] Finish SIMD16 PA OPT except tesselation

--- src/gallium/drivers/swr/rasterizer/core/pa.h | 84 - src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp | 1625 +--- 2 files changed, 1420 insertions(+), 289 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/pa.h b/src/gallium/drivers/swr/rasterizer/co

[Mesa-dev] [PATCH 03/32] swr: [rasterizer core] Finish SIMD16 PA OPT including tesselation

--- src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp | 268 +++-- 1 file changed, 247 insertions(+), 21 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp b/src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp index 22643bd..6fb37e5 100644 --- a/src/gall

[Mesa-dev] [PATCH 00/32] update swr rasterizer

Hightlights include: lots of simd16 work, assert rework, and autogen changes (scripts centralized, one file added, two removed). v2: * adjust scons build system along with automake * separate backend template comment style change * only one declaration of gBackendPixelRateTable * prefix template a

[Mesa-dev] [PATCH 08/32] swr: [rasterizer archrast] Fix performance issue with archrast stats

Performance is now 50x faster with archrast now that we're properly filtering out all of the rdtsc begin/end. --- .../drivers/swr/rasterizer/archrast/archrast.cpp | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/archr

[Mesa-dev] [PATCH 07/32] swr: [rasterizer core] Implement SIMD16 GS and STREAMOUT

--- .../drivers/swr/rasterizer/core/frontend.cpp | 302 + 1 file changed, 251 insertions(+), 51 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/frontend.cpp b/src/gallium/drivers/swr/rasterizer/core/frontend.cpp index 18728e5..761e044 100644 --- a/src/

[Mesa-dev] [PATCH 16/32] swr: [rasterizer] Backend code adjustments

--- .../drivers/swr/rasterizer/common/simdintrin.h | 9 ++ src/gallium/drivers/swr/rasterizer/core/api.cpp| 5 +- .../drivers/swr/rasterizer/core/backend.cpp| 1 + src/gallium/drivers/swr/rasterizer/core/backend.h | 96 -- src/gallium/drivers/swr/rasterizer/

[Mesa-dev] [PATCH 04/32] swr: [rasterizer core] backend.h declares gBackendPixelRateTable

--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 1 - src/gallium/drivers/swr/rasterizer/core/backend.h | 8 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/api.cpp b/src/gallium/drivers/swr/rasterizer/core/api.cpp index 6c0d5d

[Mesa-dev] [PATCH 12/32] swr: [rasterizer archrast] Remove redundant data from archrast files

If count can be derived from other counts then this can be done in post processing scripts. --- .../drivers/swr/rasterizer/archrast/archrast.cpp | 42 ++--- .../drivers/swr/rasterizer/archrast/events.proto | 198 ++--- 2 files changed, 103 insertions(+), 137 deletions(-) diff

[Mesa-dev] [PATCH 11/32] swr: [rasterizer archrast/scripts] Further archrast cleanups

Removed redundant data being written out to file --- .../drivers/swr/rasterizer/archrast/archrast.cpp | 264 - .../scripts/templates/ar_eventhandler_h.template | 2 +- .../templates/ar_eventhandlerfile_h.template | 2 +- 3 files changed, 104 insertions(+), 164 del

[Mesa-dev] [PATCH 15/32] swr: [rasterizer archrast] Fix the early and late depthstencil events

The coverage and stencil mask arguments were reversed. --- src/gallium/drivers/swr/rasterizer/core/backend.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/backend.cpp b/src/gallium/drivers/swr/rasterizer/core/backend.cpp i

[Mesa-dev] [PATCH 24/32] swr: [rasterizer core] Fix trifan regression from 886a196cf2

Fixes piglit triangle-rasterization-overdraw. SIMD16 path not working. --- src/gallium/drivers/swr/rasterizer/core/pa.h | 2 ++ src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp | 14 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/swr/ra

[Mesa-dev] [PATCH 05/32] swr: [rasterizer core/scripts] Autogen backend initialization function(s)

Autogen functions that instantiates different BackendPixelRate templates. Functions get split into separate files after reaching a user defined threshold (currently 512 per file) to speed up compilation. This change will enable the addition of more template flags in the pixel back end. --- src/ga

[Mesa-dev] [PATCH 14/32] swr: [rasterizer core] Implement double pumped SIMD16 TESS

--- .../drivers/swr/rasterizer/core/frontend.cpp | 256 ++--- 1 file changed, 177 insertions(+), 79 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/frontend.cpp b/src/gallium/drivers/swr/rasterizer/core/frontend.cpp index 761e044..b2f4643 100644 --- a/src/

[Mesa-dev] [PATCH 06/32] swr: [rasterizer archrast] Add additional API events

--- .../drivers/swr/rasterizer/archrast/events.proto | 36 ++ src/gallium/drivers/swr/rasterizer/core/api.cpp| 12 2 files changed, 48 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/archrast/events.proto b/src/gallium/drivers/swr/rasterizer/archr

[Mesa-dev] [PATCH 25/32] swr: [rasterizer scripts] Put codegen scripts into a separate directory

--- src/gallium/drivers/swr/.gitignore | 4 +- src/gallium/drivers/swr/Makefile.am| 126 ++--- src/gallium/drivers/swr/SConscript | 38 +++ .../{scripts => codegen}/gen_archrast.py | 0 .../{scripts => codegen}/gen_

[Mesa-dev] [PATCH 20/32] swr: [rasterizer core] Fix typo in SIMD16 code path

--- src/gallium/drivers/swr/rasterizer/core/pa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/pa.h b/src/gallium/drivers/swr/rasterizer/core/pa.h index 2e159da..afeed65 100644 --- a/src/gallium/drivers/swr/rasterizer/core/pa.h +++ b/s

[Mesa-dev] [PATCH 01/32] swr: [rasterizer core] Support sparse numa id values on all OSes

--- .../drivers/swr/rasterizer/core/threads.cpp| 80 ++ 1 file changed, 53 insertions(+), 27 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/threads.cpp b/src/gallium/drivers/swr/rasterizer/core/threads.cpp index f1c3030..e11291b 100644 --- a/src/gal

[Mesa-dev] [PATCH 18/32] swr: [rasterizer core] Allow no arguments to SWR_INVALID macro

Turns out this is somewhat tricky with gcc/g++. --- src/gallium/drivers/swr/rasterizer/common/swr_assert.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/swr_assert.h b/src/gallium/drivers/swr/rasterizer/common/swr_asse

[Mesa-dev] [PATCH 26/32] swr: [rasterizer codegen] Quiet gen_backends.py execution

--- src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py index cbbc378..d6367ca 100644 --- a/src/

[Mesa-dev] [PATCH 23/32] swr: [rasterizer core] SIMD16 Frontend WIP - fix tesselation crashes

--- .../drivers/swr/rasterizer/core/frontend.cpp | 19 +- src/gallium/drivers/swr/rasterizer/core/pa.h | 7 ++-- src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp | 40 -- 3 files changed, 35 insertions(+), 31 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH 09/32] swr: [rasterizer common] Add InterpolateComponentFlat utility

--- src/gallium/drivers/swr/rasterizer/common/simdintrin.h | 13 + 1 file changed, 13 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/simdintrin.h b/src/gallium/drivers/swr/rasterizer/common/simdintrin.h index 8926e66..ea79902 100644 --- a/src/gallium/drivers/swr

[Mesa-dev] [PATCH 30/32] swr: [rasterizer codegen] Rewrite gen_llvm_types.py to use mako

--- src/gallium/drivers/swr/Makefile.am| 9 +- src/gallium/drivers/swr/SConscript | 2 +- .../swr/rasterizer/codegen/gen_llvm_types.py | 206 ++--- .../swr/rasterizer/codegen/templates/gen_llvm.hpp | 72 +++ 4 files changed, 171 inser

[Mesa-dev] [PATCH 19/32] swr: [rasterizer core/common] Fix the native AVX512 build under ICC

--- .../drivers/swr/rasterizer/common/simd16intrin.h | 26 +--- src/gallium/drivers/swr/rasterizer/core/pa.h | 46 -- src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp | 2 +- 3 files changed, 47 insertions(+), 27 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH 32/32] swr: [rasterizer] Cleanup naming of codegen files

All template files and generated files are prefixed with gen_. --- src/gallium/drivers/swr/.gitignore | 12 ++--- src/gallium/drivers/swr/Makefile.am| 62 +++--- src/gallium/drivers/swr/SConscript | 18 +++ .../drivers/swr/rasteri

[Mesa-dev] [PATCH 17/32] swr: [rasterizer] Slight assert refactoring

Make asserts more robust. Add SWR_INVALID(...) as a replacement for SWR_ASSERT(0, ...) --- .../drivers/swr/rasterizer/archrast/archrast.cpp | 2 +- .../drivers/swr/rasterizer/archrast/eventmanager.h | 2 +- .../drivers/swr/rasterizer/common/swr_assert.cpp | 331 ++--- .../

  1   2   3   >