On 16 March 2017 at 02:49, Jonathan Gray <j...@jsg.id.au> wrote: > % pattern rules are a GNU extension. As there is only one file here > avoid patterns and globbing entirely to fix the build on non-GNU make. > > Signed-off-by: Jonathan Gray <j...@jsg.id.au> > --- > src/mesa/drivers/dri/i965/Makefile.am | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/Makefile.am > b/src/mesa/drivers/dri/i965/Makefile.am > index a83e3a6fa1..fee1ccbbf5 100644 > --- a/src/mesa/drivers/dri/i965/Makefile.am > +++ b/src/mesa/drivers/dri/i965/Makefile.am > @@ -92,8 +92,8 @@ EXTRA_DIST = \ > # .c and .h files in one go so we don't hit problems with parallel > # make and multiple invocations of the same script trying to write > # to the same files. > -brw_oa_%.h: brw_oa_%.xml brw_oa.py Makefile.am > - $(PYTHON2) $(PYTHON_FLAGS) $(srcdir)/brw_oa.py > --header=$(builddir)/brw_oa_$(*).h --chipset="$(*)" $(srcdir)/brw_oa_$(*).xml > -brw_oa_%.c: brw_oa_%.xml brw_oa.py Makefile.am > - $(PYTHON2) $(PYTHON_FLAGS) $(srcdir)/brw_oa.py > --code=$(builddir)/brw_oa_$(*).c --chipset="$(*)" $(srcdir)/brw_oa_$(*).xml <unrelated> Hmm that is not even remotely what was reviewed or suggested ... strange. </unrelated>
> +brw_oa_hsw.h: $(srcdir)/brw_oa_hsw.xml > + $(PYTHON2) $(PYTHON_FLAGS) $(srcdir)/brw_oa.py > --header=$(builddir)/brw_oa_hsw.h --chipset=hsw $(srcdir)/brw_oa_hsw.xml > +brw_oa_hsw.c: $(srcdir)/brw_oa_hsw.xml > + $(PYTHON2) $(PYTHON_FLAGS) $(srcdir)/brw_oa.py > --code=$(builddir)/brw_oa_hsw.c --chipset=hsw $(srcdir)/brw_oa_hsw.xml > Thank you Jonathan. We might need a generic rule as other generations are covered and/or even move the lot to another location. All that in due time, for now I'll add the missing brw_oa.py dependency and push this. Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
