Re: [Mesa-dev] [PATCH] radv: Properly handle destroying NULL devices and instances

Reviewed-by: Bas Nieuwenhuizen On Mon, Mar 6, 2017 at 8:17 AM, Dave Airlie wrote: > From: Dave Airlie > > Ported from anv: > 3d33a23e anv: Properly handle destroying NULL devices and instances > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_device.c | 6 ++ > 1 file changed, 6

[Mesa-dev] [Bug 100063] Payday 2's maximum frame rate locked to refresh rate

https://bugs.freedesktop.org/show_bug.cgi?id=100063 --- Comment #4 from thedribbleo...@gmail.com --- (In reply to Michel Dänzer from comment #1) > If sync-to-vblank can't be disabled in the game settings, you can override > it with the environment variable vblank_mode=0. Tested this very briefly,

Re: [Mesa-dev] [PATCH 2/2] radv/ac: introduce i1true/i1false to contxet.

If you fix the title, this series is Reviewed-by: Bas Nieuwenhuizen On Mon, Mar 6, 2017 at 8:19 AM, Dave Airlie wrote: > From: Dave Airlie > > This uses these in a few places, and fixes one or two > cases which were using da as 32-bit instead of bool. > > Signed-off-by: Dave Airlie > --- > s

Re: [Mesa-dev] [PATCH] st/omx: Fix port format enumeration

Am 05.03.2017 um 23:10 schrieb Mark Thompson: From OpenMAX IL section 4.3.5: "The value of nIndex is the range 0 to N-1, where N is the number of formats supported by the port. There is no need for the port to report N, as the caller can determine N by enumerating all the formats supported by t

Re: [Mesa-dev] [PATCH] st/omx: Set end-of-frame flag on bitstream output buffers

Am 06.03.2017 um 00:18 schrieb Mark Thompson: Since all output buffers are whole frames, this should always be set. Technically, setting this flag is is optional (see OpenMAX IL section 3.1.2.7.1), but some clients assume that it will be used and therefore buffer indefinitely thinking that all o

Re: [Mesa-dev] [RFC 00/11] GL_ARB_gpu_shader_fp64

On 04/03/17 05:32 AM, Jason Ekstrand wrote: > On Fri, Mar 3, 2017 at 11:41 AM, Ilia Mirkin > wrote: > > On Fri, Mar 3, 2017 at 2:16 PM, Jason Ekstrand > wrote: > > Hey Elie! > > > > On Fri, Mar 3, 2017 at 8:22 AM, Elie

Re: [Mesa-dev] [RFC 1/3] gk110/ir: Add rcp f64 implementation

2017-03-06 0:33 GMT+08:00 Ilia Mirkin : > On Sun, Mar 5, 2017 at 10:34 AM, Boyan Ding wrote: >> Signed-off-by: Boyan Ding >> --- >> src/gallium/drivers/nouveau/codegen/lib/gk110.asm | 156 >> - >> .../drivers/nouveau/codegen/lib/gk110.asm.h| 96 - >> 2

Re: [Mesa-dev] [PATCH 2/2] st/dri: reduce dri_fill_st_options() params

Yeah, you can push these. Marek On Mar 6, 2017 5:03 AM, "Timothy Arceri" wrote: > From: Marek Olšák > > --- > src/gallium/state_trackers/dri/dri_screen.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/state_trackers/dri/dri_screen.c > b/src/galliu

Re: [Mesa-dev] [PATCH 4/4] gallium/util: remove unused header from u_queue.c

The whole series looks good to me. Reviewed-by: Plamena Manolova On Mon, Mar 6, 2017 at 2:58 AM, Timothy Arceri wrote: > --- > src/gallium/auxiliary/util/u_queue.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/gallium/auxiliary/util/u_queue.c > b/src/gallium/auxiliary/util/u_que

Re: [Mesa-dev] [PATCH] anv: Add a helper for working with VK_WHOLE_SIZE for buffers

Reviewed-by: Plamena Manolova On Sat, Mar 4, 2017 at 8:47 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 16 +++- > src/intel/vulkan/anv_descriptor_set.c | 7 +++ > src/intel/vulkan/anv_image.c | 4 ++-- > src/intel/vulkan/anv_private.h

Re: [Mesa-dev] [RFC 00/11] GL_ARB_gpu_shader_fp64

On 6 March 2017 at 08:34, Michel Dänzer wrote: > On 04/03/17 05:32 AM, Jason Ekstrand wrote: >> On Fri, Mar 3, 2017 at 11:41 AM, Ilia Mirkin > > wrote: >> >> On Fri, Mar 3, 2017 at 2:16 PM, Jason Ekstrand > > wrote: >> > Hey Eli

[Mesa-dev] [Bug 100063] Payday 2's maximum frame rate locked to refresh rate

https://bugs.freedesktop.org/show_bug.cgi?id=100063 Grazvydas Ignotas changed: What|Removed |Added CC||nota...@gmail.com --- Comment #5 fr

[Mesa-dev] [Bug 100063] vsync setting of OpenGL programs is ignored

https://bugs.freedesktop.org/show_bug.cgi?id=100063 Grazvydas Ignotas changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

Re: [Mesa-dev] [PATCH] radv: add .dir-locals.el to make radv code more readable in Emacs

On Mon, Mar 6, 2017 at 7:44 AM, Michel Dänzer wrote: > This doesn't seem consistent with existing .dir-locals.el files in the > tree. If any of those files match the Linux kernel coding style as well, > it would be good to make them all consistent one way or another. Hi Michel, you're right, I wi

[Mesa-dev] [PATCH] dir-locals.el: use appropriate style and stop unsafe warning

This updates the c-file-style for directories that appear to use Linux kernel style rather than the Stroustrup style, and adds a .dir-locals.el and .editorconfig for the radv driver. Also changes the mode from prog-mode to the less generic cc-mode so that Emacs doesn't warn about unsafe variables.

Re: [Mesa-dev] [PATCH v3 07/24] i965/fs: generalize the legalization d2x pass

On 04/03/17 00:19, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> Add support to SEL instruction and add an assert to detect unsupported >> instructions than do d2x conversions. >> >> Signed-off-by: Samuel Iglesias Gonsálvez >> --- >> >> Curro, this patch legalizes SEL instruc

Re: [Mesa-dev] [PATCH v3 13/24] i965/vec4: split DF instructions and later double its execsize in IVB/BYT

On 04/03/17 00:32, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> We need to split DF instructions in two on IVB/BYT as it needs an >> execsize 8 to process 4 DF values (one GRF in total). >> >> v2: >> - Rename helper and make it static inline function (Matt). >> - Fix indentio

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: Translate float ir_unop_neg into float MOV with modifier.

Am 04.03.2017 um 20:45 schrieb Ilia Mirkin: > Also, how is this happening in the first place? For example, we have: > >case ir_unop_bitcast_f2i: >case ir_unop_bitcast_f2u: > /* Make sure we don't propagate the negate modifier to integer opcodes. > */ > if (op[0].negate || op[0

[Mesa-dev] [PATCH] android: fix segfault within swap_buffers

Function droid_swap_buffers may get called without dri2_surf->buffer set, in these cases we don't have a back buffer set either. Patch fixes segfault seen with 3DMark that uses android.opengl.GLSurfaceView for rendering it's UI. backtrace: #00 pc 00013f88 /system/lib/egl/libGLES_mesa.so (droi

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: Translate float ir_unop_neg into float MOV with modifier.

I'm sure radeonsi will handle UCMP with modifiers too. (which is basically gallivm) Marek On Mar 6, 2017 1:06 PM, "Roland Scheidegger" wrote: > Am 04.03.2017 um 20:45 schrieb Ilia Mirkin: > > Also, how is this happening in the first place? For example, we have: > > > >case ir_unop_bitcast_f

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: Translate float ir_unop_neg into float MOV with modifier.

Am 06.03.2017 um 13:06 schrieb Roland Scheidegger: > Am 04.03.2017 um 20:45 schrieb Ilia Mirkin: >> Also, how is this happening in the first place? For example, we have: >> >>case ir_unop_bitcast_f2i: >>case ir_unop_bitcast_f2u: >> /* Make sure we don't propagate the negate modifier t

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #4 from Jan Vesely --- there will always some configuration that is overlooked. wouldn't it be easier if the subdirectories were based on timestamp itself? that gives you clean slate for new builds, evicting the oldest will cleanup

[Mesa-dev] [PATCH] radv: Emit pending flushes before executing a secondary command buffer

If we have any pending flushes on the primary command buffer, these must be performed before executing the secondary buffer. This fixes potential corruption when the contents of a subpass which clears any of its render targets are given in a secondary buffer: the flushes after a fast clear would n

[Mesa-dev] [PATCH] glsl: Fix indent in dump code

From: Elie Tournier Signed-off-by: Elie Tournier --- On an other thread [1], we discovered than the GLSL compiler have some trouble to indent correctly the dump IR. I don't have git access, please push it for me. [1] https://lists.freedesktop.org/archives/mesa-dev/2017-March/146518.html ---

Re: [Mesa-dev] [PATCH 4/5] radeonsi: drop support for LLVM 3.6 & 3.7

On 5 March 2017 at 22:22, Marek Olšák wrote: > From: Marek Olšák > > They are too old. > --- > configure.ac | 4 +-- > src/amd/common/ac_llvm_build.c | 30 > -- > src/amd/common/ac_llvm_helper.cpp |

[Mesa-dev] [PATCH] st/va: cleanup error handling in vlVaCreateSurfaces2

From: Christian König No need to have that twice. Signed-off-by: Christian König --- src/gallium/state_trackers/va/surface.c | 52 + 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_trac

[Mesa-dev] [PATCH 3/3] util/disk_cache: scale cache according to filesystem size

Select higher of current 1G default or 10% of filesystem where cache is located. Note that cache for different architectures are currently calculated separately so on x86 this could be potentially 20%. Quotas could be considered too. --- src/util/disk_cache.c | 11 --- 1 file changed, 8 i

[Mesa-dev] [PATCH 1/3] util/disc_cache: use LRU eviction rather than random eviction

Still using random selection of two-character subdirectory in which to check cache files rather than scanning entire cache. --- src/util/disk_cache.c | 77 +++ 1 file changed, 34 insertions(+), 43 deletions(-) diff --git a/src/util/disk_cache.c b/sr

[Mesa-dev] [PATCH 2/3] util/disk_cache: actually enforce cache size

Currently only a one in one out eviction so if at max_size and cache files were to constantly increase in size then so would the cache. Restrict to limit of 8 evictions per new cache entry. --- src/util/disk_cache.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/util/d

Re: [Mesa-dev] [PATCH] dir-locals.el: use appropriate style and stop unsafe warning

Actually please ignore this, cc-mode does not actually work the way I thought it should. Sorry for the noise. On Mon, Mar 6, 2017 at 1:00 PM, Damien Grassart wrote: > This updates the c-file-style for directories that appear to use Linux > kernel style rather than the Stroustrup style, and adds a

Re: [Mesa-dev] [PATCH] getteximage: avoid to lookup textures with id 0

Reviewed-by: Marek Olšák Marek On Wed, Mar 1, 2017 at 10:54 PM, Samuel Pitoiset wrote: > This fixes the following assertion when the key is 0. > > main/hash.c:181: _mesa_HashLookup_unlocked: Assertion `key' failed. > > Fixes: 633c959fae ("getteximage: Return correct error value when texure > o

Re: [Mesa-dev] [PATCH] mesa/main: remove useless check in _mesa_IsSampler()

I'd prefer _mesa_lookup...(...) != NULL, but either way: Reviewed-by: Marek Olšák Marek On Wed, Mar 1, 2017 at 10:53 PM, Samuel Pitoiset wrote: > _mesa_lookup_samplerobj() returns NULL if sampler is 0. > > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/samplerobj.c | 8 +--- > 1 fi

Re: [Mesa-dev] [PATCH] util/disk_cache: fix make check

Hi Tim, Please use something like " src/compiler/glsl/tests/cache_test: track correct folder for the disk cache" On 6 March 2017 at 02:25, Timothy Arceri wrote: > Fixes make check after 11f0efec2e615f5233d which caused disk cache > to create an additional directory. Fixes: 11f0efec2e6 ("util/di

Re: [Mesa-dev] [RFC 00/11] GL_ARB_gpu_shader_fp64

On Mon, Mar 6, 2017 at 3:26 AM, Emil Velikov wrote: > On 6 March 2017 at 08:34, Michel Dänzer wrote: > > On 04/03/17 05:32 AM, Jason Ekstrand wrote: > >> On Fri, Mar 3, 2017 at 11:41 AM, Ilia Mirkin >> > wrote: > >> > >> On Fri, Mar 3, 2017 at 2:16 PM, Jason Eks

Re: [Mesa-dev] [RFC] anv: Use on-the-fly surface states for dynamic buffer descriptors

Hey Jason, Overall looks really good to me, always nice to delete code and get performance. It also seems like you've fixed a bug, it seems the push_descriptor/push_descriptor_template entry points weren't setting cmd_buffer->state.push_constants_dirty properly (my bad...). Now that we're n

Re: [Mesa-dev] [RFC] nir: Improve induction variables detection

Any comments, tips before I go to deep in the code? On 24 February 2017 at 12:17, Elie Tournier wrote: > The actual code detect only basic induction variables (i = i +/- c). > I'm working on improve the detection in order to reconize derived induction > varibles (j = c1 * i +/- c2). > I obtain t

[Mesa-dev] [PATCH 2/6] isl: Rename isl_surf_init_info::min_pitch -> min_row_pitch

It is the lower bound for isl_surf::row_pitch; not isl_surf::pitch, which doesn't exist; nor does it affect isl_surf::array_pitch*. --- src/intel/blorp/blorp_blit.c | 4 ++-- src/intel/isl/isl.c | 6 +++--- src/intel/isl/isl.h | 2 +- src/intel/vulkan/anv_blorp.c | 2 +- src/inte

[Mesa-dev] [PATCH 1/6] isl: Fix s/pitch/row_pitch/ in comment

struct isl_surf has no member named 'pitch'. --- src/intel/isl/isl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 9d92906ca71..add708b760f 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -810,7 +810,7 @@ struct is

[Mesa-dev] [PATCH 3/6] isl: Refactor row pitch calculation

The calculations of row_pitch, surface size, and base_alignment were mixed together. Extract the calculation of row pitch into a new function, isl_calc_row_pitch(), and call it before calculating surface_size and base_alignment. This simplifies a follow-on patch that adds a new member, 'row_pitch'

[Mesa-dev] [PATCH 6/6] isl: Drop unused isl_surf_init_info::min_pitch

--- src/intel/isl/isl.c | 12 ++-- src/intel/isl/isl.h | 3 --- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index b3ac305b81b..ec8424cd48b 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1008,8 +1008,6 @@ isl_cal

[Mesa-dev] [PATCH 5/6] intel: Fix requests for exact surface row pitch

All callers of isl_surf_init() that set 'min_row_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. Now that isl has an API for that, update the code to use it. --- src/intel/blorp/blorp_blit.c | 3 +-- src/intel/vulkan/anv_blorp.c | 3 +

[Mesa-dev] [PATCH 0/6] isl: Fix requests for exact row pitch

All callers of isl_surf_init() that set 'min_row_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. This series fixes that by adding a field, isl_surf_init_info::row_pitch. This prepares for VK_MESAX_external_image_dma_buf, which require

[Mesa-dev] [PATCH 4/6] isl: Let isl_surf_init's caller set the exact row pitch

The caller does so by setting the new field isl_surf_init_info::row_pitch, which overrides isl's row pitch calculation. --- src/intel/isl/isl.c | 11 ++- src/intel/isl/isl.h | 9 + 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/i

Re: [Mesa-dev] [RFC 00/11] GL_ARB_gpu_shader_fp64

On 6 March 2017 at 17:15, Jason Ekstrand wrote: >> >> How about we allows drivers to opt-in for this ? There's already a >> bunch in gl_shader_compiler_options that we toggle. >> This will allow Elie's work to land and be [at least partially] useful >> in the interim. > > > That's entirely beside

[Mesa-dev] [PATCH 3/5] anv/image: Fix return type of make_surface()

make_surface() always returns VK_SUCCESS, so change its return type to 'void'. This simplifies the return-code handling in anv_image_create_info() and removes a goto. --- src/intel/vulkan/anv_image.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/src/intel/vul

[Mesa-dev] [PATCH 1/5] anv/image: Better var names in vkCreateImage

- Rename the anv_image_create_info vars from 'create_info' to 'anv_info'. - Rename the VkImageCreateInfo vars from 'pCreateInfo' and 'vk_info' to 'base_info'. This reduces the diff and eliminates ambiguity in follow-up patches for upcoming extensions, because the extensions define yet more "crea

[Mesa-dev] [PATCH 4/5] anv/image: Refactor creation of aux surfaces

Creation of hiz, ccs, and mcs surfaces was encoded by a giant 'if' tree at the tail of make_surface(). This patch extracts that 'if' tree into the new functions: make_hiz_surface_maybe() make_ccs_surface_maybe() make_mcs_surface_maybe() For clarity, also rename make_surface() to make_

[Mesa-dev] [PATCH 2/5] anv/image: Refactor how tiling is chosen

The code that chooses the image's tiling flags, extract it into a new function, choose_isl_tiling_flags(). This reduces the diff in future patches for the upcoming dma_buf-import extension, in which the the tiling code will become more complex. --- src/intel/vulkan/anv_image.c | 30 ++

[Mesa-dev] [PATCH 5/5] anv: Handle failure in make_hiz_surface_maybe()

make_ccs_surface_maybe() correctly handles failure isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still valid, just without a ccs surface. Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf(). Fix make_hiz_surface_maybe() to do the same. --- src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 0/5] anv: Some image refactors and a hiz fix

This series prepares for VK_MESAX_external_image_dma_buf by heavily refactoring vkCreateImage(). I separated these prep patches the VK_MESAX_external_image_dma_buf patches to make review less burdensome, and to begin getting patches upstreamed asap. This patch series lives at: git://git.kiwitr

Re: [Mesa-dev] [PATCH] radv: Emit pending flushes before executing a secondary command buffer

Nice catch. Reviewed-by: Bas Nieuwenhuizen On Mon, Mar 6, 2017 at 3:54 PM, Alex Smith wrote: > If we have any pending flushes on the primary command buffer, these > must be performed before executing the secondary buffer. > > This fixes potential corruption when the contents of a subpass which

Re: [Mesa-dev] [PATCH 04/37] glsl/tests: suffix .sh/.py files as applicable

On 23 February 2017 at 17:13, Emil Velikov wrote: > From: Emil Velikov > > This makes it easier/clearer as to: > - if the file should have the execute bit set (.py should not) > - do we need the shebang in the first place and if so what it should be > > Signed-off-by: Emil Velikov > --- > This

[Mesa-dev] [PATCH 3/3] anv: Use anv_outarray in vkGetPhysicalDeviceQueueFamilyProperties

No intended change in behavior. Just a refactor. --- src/intel/vulkan/anv_device.c | 73 +++ 1 file changed, 18 insertions(+), 55 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 6a73d6bf6db..67dd8405487 100644 -

[Mesa-dev] [PATCH 1/3] anv: Add anv_outarray

anv_outarray is a wrapper for a Vulkan output array. A Vulkan output array is one that follows the convention of the parameters to vkGetPhysicalDeviceQueueFamilyProperties(). In the upcoming dma_buf extensions, anv_outarray will simplify the code for querying the DRM format modifiers. --- src/int

[Mesa-dev] [PATCH 0/3] anv: Add an anv_outarray_append() macro

The macro anv_outarray_append() deduplicates a lot of nit-picky boilerplate code. It appends to a Vulkan output array, handling null pointers and overflow correctly. (A Vulkan output array, as I'm using the term, is one that follows the convention of the parameters to vkGetPhysicalDeviceQueueFamily

[Mesa-dev] [PATCH 2/3] anv: Use anv_outarray in vkEnumeratePhysicalDevices

No intended change in behavior. Just a refactor. --- src/intel/vulkan/anv_device.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index fbcbd40c61f..6a73d6bf6db 100644 --- a/src/int

[Mesa-dev] [PATCH] dir-locals.el: use appropriate c-file-style

Add .dir-locals.el and .editorconfig files in src/amd/vulkan and src/amd/common since they don't use the coding style defined in the root .dir-locals.el. Also update the styles for other directories that appear to use the Linux kernel style. Signed-off-by: Damien Grassart --- src/amd/common/.dir

Re: [Mesa-dev] [PATCH] dir-locals.el: use appropriate c-file-style

What's the difference between c-file-style linux and stroustrup? On Mon, Mar 6, 2017 at 1:43 PM, Damien Grassart wrote: > Add .dir-locals.el and .editorconfig files in src/amd/vulkan and > src/amd/common since they don't use the coding style defined in the > root .dir-locals.el. Also update the s

[Mesa-dev] [Request for Comments] - Port documentation to Markdown

Hello guys, I want to propose a port of the current HTML documentation to a markdown-like syntax. Current problems Right now I see some problems with the approach used. * People maintaining the documentation must know basic HTML syntax; * There is no easy way to add a new release pa

[Mesa-dev] [PATCH 1/6] build: Replace NEED_RADEON_LLVM with HAVE_GALLIUM_LLVM.

--- configure.ac| 2 -- src/amd/Makefile.common.am | 2 +- src/gallium/drivers/r600/Automake.inc | 2 +- src/gallium/drivers/r600/Makefile.am| 2 +- src/gallium/drivers/radeon/Makefile.am | 2 +- src/gallium/targets/pipe-loader/Ma

[Mesa-dev] [PATCH 5/6] configure.ac: Ensure libva is enabled before invoking pkg-config.

PKG_CHECK_VAR can only check --variable=$NAME, so it cannot handle modversion. --- configure.ac | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index d44a229..d483baa 100644 --- a/configure.ac +++ b/configure.ac @@ -2537,8 +2537,10 @@ AC_SUBST(

[Mesa-dev] [PATCH 6/6] configure.ac: Ensure libomxil-bellagio exists before invoking pkg-config.

I was already tired of seeing the message Package libomxil-bellagio was not found in the pkg-config search path. Perhaps you should add the directory containing `libomxil-bellagio.pc' to the PKG_CONFIG_PATH environment variable No package 'libomxil-bellagio' found on every configu

[Mesa-dev] [PATCH 2/6] configure.ac: Fix error message in radeon_llvm_check().

It printed the version of LLVM ($1): configure: error: 3.6.0 requires libelf when using llvm instead of the driver name ($2): configure: error: r600 requires libelf when using llvm --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configur

[Mesa-dev] [PATCH 3/6] configure.ac: Use PKG_CHECK_VAR for wayland-scanner.

Available since pkg-config-0.28 and pkgconf-0.8.10. The removal of the AC_PATH_PROG is intentional. Use pkg-config. --- configure.ac | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index de54f38..37f6b60 100644 --- a/configure.ac +++ b/configu

[Mesa-dev] [PATCH 4/6] configure.ac: Use PKG_CHECK_VAR for libclc.

--- configure.ac | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 37f6b60..d44a229 100644 --- a/configure.ac +++ b/configure.ac @@ -2018,10 +2018,8 @@ if test "x$enable_opencl" = xyes; then PKG_CONFIG_PATH environment

Re: [Mesa-dev] [PATCH 1/2] st/mesa: don't propagate uniforms when restoring from cache

Reviewed-by: Marek Olšák Marek On Fri, Mar 3, 2017 at 6:59 AM, Timothy Arceri wrote: > We will have already loaded the uniforms when the parameter list > was restored from cache. > --- > src/mesa/program/ir_to_mesa.cpp| 14 +- > src/mesa/program/ir_to_mesa.h

Re: [Mesa-dev] [PATCH 0/6] isl: Fix requests for exact row pitch

On Mon, Mar 6, 2017 at 10:12 AM, Chad Versace wrote: > All callers of isl_surf_init() that set 'min_row_pitch' wanted to > request an *exact* row pitch, as evidenced by nearby asserts, but isl > lacked API for doing so. This series fixes that by adding a field, > isl_surf_init_info::row_pitch. > >

Re: [Mesa-dev] [PATCH] getteximage: avoid to lookup textures with id 0

Does this work on AMD hardware? It regresses every Intel GPU. https://bugs.freedesktop.org/show_bug.cgi?id=100088 Samuel Pitoiset writes: > This fixes the following assertion when the key is 0. > > main/hash.c:181: _mesa_HashLookup_unlocked: Assertion `key' failed. > > Fixes: 633c959fae ("gett

Re: [Mesa-dev] [PATCH] getteximage: avoid to lookup textures with id 0

Fixed with https://cgit.freedesktop.org/mesa/mesa/commit/?id=4317cd96d3022ad0ef7e1d5ffa82f5c2693bb44e. Sorry. On 03/06/2017 09:26 PM, Mark Janes wrote: Does this work on AMD hardware? It regresses every Intel GPU. https://bugs.freedesktop.org/show_bug.cgi?id=100088 Samuel Pitoiset writes:

[Mesa-dev] [PATCH 03/13] anv: Add func anv_get_raw_format()

Like anv_get_format(), but the returned format is not adjusted, not even for the aspect. Add anv_get_raw_isl_format() too, to match anv_get_isl_format(). --- src/intel/vulkan/anv_formats.c | 7 +++ src/intel/vulkan/anv_private.h | 8 2 files changed, 15 insertions(+) diff --git a/sr

[Mesa-dev] [PATCH 00/13] anv: Implement VK_MESAX_image_dma_buf

Patches 1-5 are prep patches, ready for upstreaming. Patches 6-13 are RFC implementation patches, not ready yet for upstreaming. Overview I've been working on a Vulkan extension for importing/exporting dma_bufs, named VK_MESAX_external_image_dma_buf. It's similar to EGL_EXT_image_dma_buf

[Mesa-dev] [PATCH 04/13] anv: Annotate anv_get_*format() as pure

--- src/intel/vulkan/anv_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 60b05186c19..01aeb216597 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -1679,7 +167

[Mesa-dev] [PATCH 05/13] anv: Set anv_surface::offset earlier

Set anv_surface::offset *before* calling add_surface(). No intended change in behavior. This patch prepares for supporting user-provided surface offsets, a feature required for VK_MESAX_external_image_dma_buf. --- src/intel/vulkan/anv_image.c | 15 --- 1 file changed, 12 insertions(+)

[Mesa-dev] [RFC PATCH 08/13] RFC: anv: Implement VK_MESAX_external_memory_dma_buf

For now, we support dma_bufs only for VkBuffers. The VK_MESAX_external_memory_dma_buf spec allows us to support dma_buf VkImages, but we choose to defer that support until VK_MESAX_external_image_dma_buf. --- src/intel/vulkan/anv_device.c | 28 +++- src/intel/vul

[Mesa-dev] [PATCH 01/13] isl: Add func isl_tiling_from_drm_format_mod()

It converts a DRM format modifier to enum isl_tiling. That's all. --- src/intel/isl/isl.c | 23 +++ src/intel/isl/isl.h | 3 +++ 2 files changed, 26 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index ec8424cd48b..c70fac8a176 100644 --- a/src/intel/isl/

[Mesa-dev] [RFC PATCH 06/13] RFC: vulkan: Update registry for MESAX dma_buf extensions

Update vulkan.h and vk.xml from [1]: git://github.com/chadversary/vulkan-spec refs/tags/chadv/test/2017-03-06-VK_MESAX_external This pulls in the following extensions: - VK_EXT_get_image_properties - VK_MESAX_external_memory_dma_buf - VK_MESAX_external_image_dma_buf WARNING: These exten

[Mesa-dev] [PATCH 02/13] isl: Add isl_surf_get_drm_format_mod()

--- src/intel/isl/isl.c | 35 +++ src/intel/isl/isl.h | 15 +++ 2 files changed, 50 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index c70fac8a176..3559c5e4c84 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1947,3

[Mesa-dev] [RFC PATCH 09/13] RFC: anv: Implement VK_MESAX_external_image_dma_buf

For now, we support dma_buf images for only a single format, VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D, single-sample, non-mipmappped, non-array, non-cube. --- src/intel/vulkan/anv_device.c | 4 + src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vu

[Mesa-dev] [RFC PATCH 12/13] RFC: anv: Drop unused anv_image_create()

--- src/intel/vulkan/anv_image.c | 26 ++ src/intel/vulkan/anv_private.h | 5 - 2 files changed, 6 insertions(+), 25 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 60b33fba2ae..998b0b43391 100644 --- a/src/intel/vulkan/an

[Mesa-dev] [RFC PATCH 13/13] RFC: anv: Drop unneeded struct anv_image_create_info

Now that anv_image_create() is gone, there is no need for struct anv_image_create_info. The struct just adds an unused layer of indirection. --- src/intel/vulkan/anv_image.c | 38 +++--- src/intel/vulkan/anv_private.h | 9 - 2 files changed, 11 insertions

[Mesa-dev] [RFC PATCH 11/13] RFC: anv/wsi: Use VK_MESAX_external_image_dma_buf

When creating a VkSurface for X11, we created the underlying VkImage by calling anv_image_create() and passing driver-private info to it. We can now accomplish the same thing without driver-private info, using VK_MESAX_external_image_dma_buf. In anv_wsi.c, replace the combo of anv_image_create(

[Mesa-dev] [RFC PATCH 10/13] RFC: anv: Drop vkCreateDmaBufImageINTEL()

This "extension" function predates Vulkan 1.0 and Vulkan WSI. We created it during the early days of bringing up the Vulkan driver. We used it for testing the early driver because, in those early days, there was no other way to import/export a tiled VkImage and examine it. No VkSurfaceKHR existed y

[Mesa-dev] [RFC PATCH 07/13] RFC: anv: Implement VK_EXT_get_image_properties

--- src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_image.c| 13 + 2 files changed, 14 insertions(+) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 7d7ea5e77ed..eb960b45986 100644 --- a/src/intel/v

[Mesa-dev] [RFC] vulkan: VK_MESAX_external_image_dma_buf

I'm working on Vulkan extensions for importing/exporting dma_bufs. I'm seeking feedback on the extension drafts. But... Sorry, the real RFC is in another castle. Find it at . Reply three, not here. I sent this proxy RFC beca

Re: [Mesa-dev] [PATCH 5/5] gallium/util: replace pipe_condvar_broadcast() with cnd_broadcast()

For the series: Reviewed-by: Marek Olšák Marek On Sun, Mar 5, 2017 at 3:51 AM, Timothy Arceri wrote: > > > On 05/03/17 11:30, Emil Velikov wrote: >> >> On 4 March 2017 at 23:41, Timothy Arceri wrote: >>> >>> pipe_condvar_broadcast() was made unnecessary with fd33a6bcd7f12. >> >> Fwiw I have s

Re: [Mesa-dev] [PATCH 1/7] gallium/util: replace pipe_mutex with mtx_t

For the series: Reviewed-by: Marek Olšák Marek On Sun, Mar 5, 2017 at 2:44 AM, Timothy Arceri wrote: > Patches 5 & 6 were two big for the list. You can view them here [1]. They > are the lock and unlock patches. > > [1] https://github.com/tarceri/Mesa/compare/master...shader-cache-radeonsi5 >

Re: [Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

On Sun, Mar 5, 2017 at 1:43 PM, Constantine Charlamov wrote: > On 28.02.2017 05:44, Dave Airlie wrote: >> On 28 February 2017 at 12:42, Constantine Charlamov >> wrote: >>> On 28.02.2017 05:19, Dave Airlie wrote: On 27 February 2017 at 06:31, Constantine Charlamov wrote: >> Initially

Re: [Mesa-dev] [PATCH 2/6] configure.ac: Fix error message in radeon_llvm_check().

Reviewed-by: Marek Olšák Marek On Mon, Mar 6, 2017 at 8:06 PM, Matt Turner wrote: > It printed the version of LLVM ($1): > >configure: error: 3.6.0 requires libelf when using llvm > > instead of the driver name ($2): > >configure: error: r600 requires libelf when using llvm > --- > con

Re: [Mesa-dev] [PATCH 5/6] radeonsi/ac: move get_image_intr_name to common

Reviewed-by: Marek Olšák Marek On Mon, Mar 6, 2017 at 12:29 AM, Dave Airlie wrote: > From: Dave Airlie > > This code is used in radv, so move to common build code. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_llvm_build.c | 26 ++ > src/amd/common/ac_llv

Re: [Mesa-dev] [PATCH] gallium/util: replace pipe_condvar with cnd_t

Reviewed-by: Marek Olšák Marek On Mon, Mar 6, 2017 at 12:41 AM, Timothy Arceri wrote: > pipe_condvar was made unnecessary with fd33a6bcd7f12. > > Cc: Emil Velikov > --- > src/gallium/auxiliary/os/os_thread.h | 8 ++-- > src/gallium/auxiliary/pipebuffer/pb_bufmgr_slab.c | 2 +-

Re: [Mesa-dev] [PATCH] glapi: fix typo in count_scale

Reviewed-by: Marek Olšák Marek On Mon, Mar 6, 2017 at 5:25 AM, Timothy Arceri wrote: > From: Gregory Hainaut > > 2*4=8 > > Signed-off-by: Gregory Hainaut > Reviewed-by: Timothy Arceri > --- > src/mapi/glapi/gen/gl_API.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [Mesa-dev] [PATCH 4/4] gallium/util: remove unused header from u_queue.c

For the series: Reviewed-by: Marek Olšák Marek On Mon, Mar 6, 2017 at 1:58 AM, Timothy Arceri wrote: > --- > src/gallium/auxiliary/util/u_queue.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/gallium/auxiliary/util/u_queue.c > b/src/gallium/auxiliary/util/u_queue.c > index 9565

Re: [Mesa-dev] [Request for Comments] - Port documentation to Markdown

Hi Jean, On 6 March 2017 at 18:36, Jean Hertel wrote: > Hello guys, > > > I want to propose a port of the current HTML documentation to a > markdown-like syntax. > > > Current problems > > > Right now I see some problems with the approach used. > > People maintaining the documentation must know b

[Mesa-dev] [Bug 100049] "ralloc: Make sure ralloc() allocations match malloc()'s alignment." causes seg fault in 32bit build

https://bugs.freedesktop.org/show_bug.cgi?id=100049 Dieter Nützel changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

[Mesa-dev] [Bug 100049] "ralloc: Make sure ralloc() allocations match malloc()'s alignment." causes seg fault in 32bit build

https://bugs.freedesktop.org/show_bug.cgi?id=100049 --- Comment #5 from Dieter Nützel --- Jonas, you can close after testing Mesa git. Greetings, Dieter -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH 4/6] isl: Let isl_surf_init's caller set the exact row pitch

On Mon, Mar 6, 2017 at 10:12 AM, Chad Versace wrote: > The caller does so by setting the new field > isl_surf_init_info::row_pitch, which overrides isl's row pitch > calculation. > --- > src/intel/isl/isl.c | 11 ++- > src/intel/isl/isl.h | 9 + > 2 files changed, 19 insertions(

Re: [Mesa-dev] [PATCH 6/6] isl: Drop unused isl_surf_init_info::min_pitch

why do we sped two patches refactoring/renaming this field just so we can delete it? On Mon, Mar 6, 2017 at 10:12 AM, Chad Versace wrote: > --- > src/intel/isl/isl.c | 12 ++-- > src/intel/isl/isl.h | 3 --- > 2 files changed, 2 insertions(+), 13 deletions(-) > > diff --git a/src/intel

Re: [Mesa-dev] [PATCH 5/6] intel: Fix requests for exact surface row pitch

Much nicer! On Mon, Mar 6, 2017 at 10:12 AM, Chad Versace wrote: > All callers of isl_surf_init() that set 'min_row_pitch' wanted to > request an *exact* row pitch, as evidenced by nearby asserts, but isl > lacked API for doing so. Now that isl has an API for that, update the > code to use it. >

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: Translate float ir_unop_neg into float MOV with modifier.

Roland Scheidegger writes: > Am 04.03.2017 um 20:45 schrieb Ilia Mirkin: >> Also, how is this happening in the first place? For example, we have: >> >>case ir_unop_bitcast_f2i: >>case ir_unop_bitcast_f2u: >> /* Make sure we don't propagate the negate modifier to integer >> opcodes

[Mesa-dev] [PATCH] radv: Disable HTILE for textures with multiple layers/levels.

It has issues and the fix I'm working on is too complicated for stable, so disable for now. Signed-off-by: Bas Nieuwenhuizen CC: 13.0 17.0 --- src/amd/vulkan/radv_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index 461d6

  1   2   3   >