[Mesa-dev] [PATCH] spirv: handle SpvOpUConvert in proper place.

2017-02-15 Thread Dave Airlie
From: Dave Airlie This was falling into the quantizetof16 path. Signed-off-by: Dave Airlie --- src/compiler/spirv/vtn_alu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_alu.c b/src/compiler/spirv/vtn_alu.c index 55f7f2e..0738fe0 100644 --- a/src/co

[Mesa-dev] [PATCH 1/3] radv/ac: add support for some integer size conversions.

2017-02-15 Thread Dave Airlie
From: Dave Airlie zero extend ->u64 and sign extend ->i64. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 883656d..e9e3d14 100644 --- a/src/amd/com

[Mesa-dev] [PATCH 3/3] nir: handle some 64-bit integer conversions

2017-02-15 Thread Dave Airlie
From: Dave Airlie These are enough for the spir-v generator to handle UConvert and SConvert operations, and fix the 4 tests in CTS. Signed-off-by: Dave Airlie --- src/compiler/nir/nir.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/src/compiler

[Mesa-dev] [PATCH 2/3] nir: handle 64-bit integer types in glsl->nir type conversion.

2017-02-15 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/compiler/nir/nir.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 8bbc41d..d92e6eb 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -688,6 +688,12 @@ nir_get_

[Mesa-dev] nir/radv int64 conversion fixes

2017-02-15 Thread Dave Airlie
These should be applied before radv int64 is enabled. These 3 fix the 64-bit variants of dEQP-VK.spirv_assembly.instruction.compute.uconvert.* dEQP-VK.spirv_assembly.instruction.compute.sconvert.* Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesk

Re: [Mesa-dev] [PATCH 1/5] i965/fs: Fix the inline nir_op_pack_double optimization

2017-02-15 Thread Kenneth Graunke
On Tuesday, February 14, 2017 11:29:47 PM PST Jason Ekstrand wrote: > We can only do the optimization if the source *is* SSA. > > Cc: "13.0 17.0" > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/b

Re: [Mesa-dev] [PATCH 1/2] util: Add helpers for iterating over Vulkan extension structs

2017-02-15 Thread Grazvydas Ignotas
On Wed, Feb 15, 2017 at 2:03 AM, Jason Ekstrand wrote: > --- > src/util/Makefile.sources | 3 ++- > src/util/vk_util.h| 43 +++ > 2 files changed, 45 insertions(+), 1 deletion(-) > create mode 100644 src/util/vk_util.h > > diff --git a/src/util/Ma

Re: [Mesa-dev] [PATCH] spirv: handle SpvOpUConvert in proper place.

2017-02-15 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 15/02/17 08:26, Dave Airlie wrote: From: Dave Airlie This was falling into the quantizetof16 path. Signed-off-by: Dave Airlie --- src/compiler/spirv/vtn_alu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_alu.

Re: [Mesa-dev] [PATCH 3/4] gallium/radeon: add a HUD query for monitoring the CS thread activity

2017-02-15 Thread Nicolai Hähnle
On 14.02.2017 19:10, Marek Olšák wrote: On Mon, Feb 13, 2017 at 4:57 PM, Marek Olšák wrote: On Mon, Feb 13, 2017 at 4:37 PM, Nicolai Hähnle wrote: On 11.02.2017 20:58, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_query.c | 25 ++-

Re: [Mesa-dev] [PATCH] gallium/radeon: add HUD queries for GPU temperature and clocks

2017-02-15 Thread Nicolai Hähnle
On 14.02.2017 18:20, Marek Olšák wrote: On Tue, Feb 14, 2017 at 9:23 AM, Nicolai Hähnle wrote: On 13.02.2017 23:08, Samuel Pitoiset wrote: Only the Radeon kernel driver exposed the GPU temperature and the shader/memory clocks, this implements the same functionality for the AMDGPU kernel drive

Re: [Mesa-dev] [PATCH] gallium/radeon: add HUD queries for GPU temperature and clocks

2017-02-15 Thread Samuel Pitoiset
On 02/15/2017 11:59 AM, Nicolai Hähnle wrote: On 14.02.2017 18:20, Marek Olšák wrote: On Tue, Feb 14, 2017 at 9:23 AM, Nicolai Hähnle wrote: On 13.02.2017 23:08, Samuel Pitoiset wrote: Only the Radeon kernel driver exposed the GPU temperature and the shader/memory clocks, this implements t

[Mesa-dev] [PATCH] getteximage: Return correct error value when texure object is not found

2017-02-15 Thread Eduardo Lima Mitev
glGetTextureSubImage() and glGetCompressedTextureSubImage() are currently returning INVALID_OPERATION error when the passed texture argument does not correspond to an existing texture object. However, the error should be INVALID_VALUE instead. From OpenGL 4.5 spec PDF, section '8.11. Texture Querie

Re: [Mesa-dev] features.txt & EXT_debug_label extension

2017-02-15 Thread Eero Tamminen
Hi, On 14.02.2017 21:06, Ian Romanick wrote: On 02/10/2017 02:56 AM, Eero Tamminen wrote: On 09.02.2017 19:30, Ian Romanick wrote: On 02/09/2017 05:19 PM, Eero Tamminen wrote: When checking GL errors for "Unturned" (Steam top-20 Unity3D based game), I noticed that it uses functions from exten

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-15 Thread Emil Velikov
Hi Matt, Afaics dl_iterate_phdr is available on musl, (some?) BSDs and Solaris - thank you for opting for it. Out of curiosity: Have you checked if on those platforms the "GNU\0" strcmp is applicable and not another string ? Worth adding a note/comment ? On 14 February 2017 at 23:58, Matt Turne

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Emil Velikov
On 14 February 2017 at 21:02, Chad Versace wrote: > On Tue 14 Feb 2017, Kenneth Graunke wrote: >> On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: >> > On Tue 14 Feb 2017, Matt Turner wrote: >> > >> > >> > > static bool >> > > -anv_get_function_timestamp(void *ptr, uint32_t* time

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/wayland: Don't use DRM format codes for SHM

2017-02-15 Thread Emil Velikov
On 13 February 2017 at 17:54, Daniel Stone wrote: > Hi, > > On 13 February 2017 at 17:49, Emil Velikov wrote: >> On 13 February 2017 at 17:34, Daniel Stone wrote: >>> On 13 February 2017 at 17:27, Emil Velikov wrote: Wouldn't it be better to have this in dri2_wl_create_window_surface() ? >

Re: [Mesa-dev] [PATCH 3/4] docs/submittingpatches.html: remove version tag for nominations

2017-02-15 Thread Nicolai Hähnle
On 13.02.2017 20:23, Emil Velikov wrote: From: Emil Velikov The version tag used to nominate has bitten even experienced mesa developers. Not to mention that it deviates from the one used in the kernel leading to further confusion. Simplify things and omit it all together. Signed-off-by: Emil

Re: [Mesa-dev] [PATCH 4/4] docs/submittingpatches.html: document the Fixes tag

2017-02-15 Thread Nicolai Hähnle
Good changes, I think. Except for a comment on patch #3, the series is Reviewed-by: Nicolai Hähnle On 13.02.2017 20:23, Emil Velikov wrote: From: Emil Velikov Provide information and an example. Signed-off-by: Emil Velikov --- docs/submittingpatches.html | 5 + 1 file changed, 5 inser

Re: [Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

2017-02-15 Thread Nicolai Hähnle
On 14.02.2017 16:18, Samuel Pitoiset wrote: Mesa currently doesn't allow to create 3.1+ compatibility profiles mainly because various features are unimplemented and bugs can happen. However, some buggy apps request a compat profile without using any old features unimplemented in mesa, and they f

Re: [Mesa-dev] [PATCH 32/32] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-15 Thread Nicolai Hähnle
On 14.02.2017 23:51, Marek Olšák wrote: On Tue, Feb 14, 2017 at 11:47 PM, Timothy Arceri wrote: On 15/02/17 08:35, Marek Olšák wrote: On Tue, Feb 14, 2017 at 9:53 PM, Timothy Arceri wrote: On 15/02/17 02:14, Marek Olšák wrote: On Tue, Feb 14, 2017 at 1:52 AM, Timothy Arceri wrote: -

Re: [Mesa-dev] [PATCH] getteximage: Return correct error value when texure object is not found

2017-02-15 Thread Nicolai Hähnle
On 15.02.2017 12:14, Eduardo Lima Mitev wrote: glGetTextureSubImage() and glGetCompressedTextureSubImage() are currently returning INVALID_OPERATION error when the passed texture argument does not correspond to an existing texture object. However, the error should be INVALID_VALUE instead. From O

Re: [Mesa-dev] Query with respect to support of x32

2017-02-15 Thread Haridasan, Sujith
Hi, I am getting same result with 17.0.x which I got for version 13 ( of Mesa). Not sure if Qt has something to do with this. I am using Qt version 5.6. Thanks, Sujith H -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Haridasan, Sujith Sent

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] gallivm: Reenable PPC VSX (v3)

2017-02-15 Thread Emil Velikov
Hi Ben, On 10 February 2017 at 23:10, Ben Crocker wrote: > Reenable the PPC64LE Vector-Scalar Extension for LLVM versions >= 3.8.1, > now that LLVM bug 26775 and its corollary, 25503, are fixed. > > Amendment: remove extraneous spaces in macro def & invocations. > > We would prefer a runtime chec

[Mesa-dev] [PATCH] configure.ac: remove unneeded trailing semicolon

2017-02-15 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- configure.ac | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 4b7f2298f7..3ef1dd5e20 100644 --- a/configure.ac +++ b/configure.ac @@ -305,7 +305,7 @@ if test "x$GCC"

Re: [Mesa-dev] Query with respect to support of x32

2017-02-15 Thread Emil Velikov
On 15 February 2017 at 12:57, Haridasan, Sujith wrote: > Hi, > > I am getting same result with 17.0.x which I got for version 13 ( of Mesa). > Not sure if Qt has something to do with this. I am using Qt version 5.6. > In that case I would strongly encourage that you flesh out a simple test app, w

Re: [Mesa-dev] [PATCH 2/3] nir: handle 64-bit integer types in glsl->nir type conversion.

2017-02-15 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Wed, 2017-02-15 at 18:43 +1000, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- >  src/compiler/nir/nir.h | 6 ++ >  1 file changed, 6 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > inde

Re: [Mesa-dev] [PATCH 3/3] nir: handle some 64-bit integer conversions

2017-02-15 Thread Samuel Iglesias Gonsálvez
On Wed, 2017-02-15 at 18:43 +1000, Dave Airlie wrote: > From: Dave Airlie > > These are enough for the spir-v generator to handle UConvert > and SConvert operations, and fix the 4 tests in CTS. > > Signed-off-by: Dave Airlie > --- >  src/compiler/nir/nir.c | 26 +++--- >  1 f

Re: [Mesa-dev] GLSL IR & TGSI on-disk shader cache

2017-02-15 Thread Emil Velikov
Hi all, On 11 February 2017 at 02:44, Pierre-Loup A. Griffais wrote: > Ideally LLVM could expose a version string/number that's granular enough, > and distros/users could be trusted to properly amend that version string if > they make functional changes to something that can affect shader > comp

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Emil Velikov
Hi Matt, On 14 February 2017 at 23:58, Matt Turner wrote: > The --build-id=... ld flag has been present since binutils-2.18, > released 28 Aug 2007. > --- > src/intel/vulkan/Makefile.am | 1 + > src/intel/vulkan/anv_device.c | 28 +++- > 2 files changed, 8 insertions(+)

[Mesa-dev] [PATCH] glsl: link error if unsized array not-last in ssbo

2017-02-15 Thread Jose Maria Casanova Crespo
If an unsized declared array is not the last in an SSBO and an implicit size can not be defined on linking time, the linker should raise an error instead of reaching an assertion on GL. This reverts part of commit 3da08e166415a745139c1127040a24e8a45dc553 getting back to the behavior of commit 5b26

Re: [Mesa-dev] [PATCH] glsl: link error if unsized array not-last in ssbo

2017-02-15 Thread Chema Casanova
I've forgot the --annotate to submit this comment about this patch, so here it is: This patch fixes an incorrect behavior exposed by the piglit tests about SSBOs and unsized arrays submitted by Dave Airlie not yet in master https://lists.freedesktop.org/archives/piglit/2016-May/019852.html Chema

Re: [Mesa-dev] [PATCH 3/4] docs/submittingpatches.html: remove version tag for nominations

2017-02-15 Thread Emil Velikov
On 15 February 2017 at 12:33, Nicolai Hähnle wrote: > On 13.02.2017 20:23, Emil Velikov wrote: >> >> From: Emil Velikov >> >> The version tag used to nominate has bitten even experienced mesa >> developers. Not to mention that it deviates from the one used in the >> kernel leading to further conf

Re: [Mesa-dev] [PATCH] spirv: handle SpvOpUConvert in proper place.

2017-02-15 Thread Jason Ekstrand
Oops... R-b On Feb 15, 2017 12:27 AM, "Dave Airlie" wrote: > From: Dave Airlie > > This was falling into the quantizetof16 path. > > Signed-off-by: Dave Airlie > --- > src/compiler/spirv/vtn_alu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/spirv/vtn_

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] i965/fs: fix indirect load DF uniforms on BSW/BXT

2017-02-15 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-02-14 at 11:11 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > Previously we were emitting two MOV_INDIRECT instructions by > > calculating > > source's indirect offsets for each 32-bit half of a DF source. > > However, > > this is not needed as we can just em

[Mesa-dev] [PATCHv2 2/6] docs/releasing: tweak the glxinfo/glxgear/etc. command lines

2017-02-15 Thread Emil Velikov
From: Emil Velikov Print only the information needed. Namely: *info: the DRI module picked and the vendor/renderer strings *gears: everything but the "...configuration file..." line(s) v2: (Eric) Use "2>&1 |" over "|&", properly escape &. Signed-off-by: Emil Velikov --- docs/releasing.html |

Re: [Mesa-dev] [PATCH] softpipe: implement clear_texture

2017-02-15 Thread Lars Hamre
Happy to rework the implementation. Would creating a util_clear_texture function which pulls out the necessary components from util_clear_render_target be in alignment with what you're imagining? The idea would be to have util_clear_texture take a pipe_resource instead of a pipe_surface. Something

[Mesa-dev] [PATCH] egl: _eglFilterArray's filter is always non-null

2017-02-15 Thread Emil Velikov
From: Emil Velikov Drop the extra handling and assert() if things change in the future. Signed-off-by: Emil Velikov --- src/egl/main/eglarray.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/src/egl/main/eglarray.c b/src/egl/main/eglarray.c ind

[Mesa-dev] [PATCH v2 1/6] autoconf/scons: bump libdrm to 2.4.75

2017-02-15 Thread Emil Velikov
From: Emil Velikov We'll be using the drmGetDevice[s]2 API in src/loader with next patch. v2: Rebase. Signed-off-by: Emil Velikov Reviewed-by: Michel Dänzer (v1) Reviewed-by: Eric Engestrom (v1) --- configure.ac | 2 +- scons/gallium.py | 2 +- 2 files changed, 2 insertions(+), 2 deleti

[Mesa-dev] [PATCH v2 6/6] anv: do not open random render node(s)

2017-02-15 Thread Emil Velikov
From: Emil Velikov drmGetDevices2() provides us with enough flexibility to build heuristics upon. Opening a random node on the other hand will wake up the device, regardless if it's the one we're interested or not. v2: - Explicitly require/check for libdrm. - Zero physicalDeviceCount when drmG

[Mesa-dev] [PATCH v2 4/6] radv/winsys: use drmGetDevice2 API

2017-02-15 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit Cc: Dave Airlie Signed-off-by: Emil Velikov Reviewed-by: Michel Dänzer Reviewed-by: Bas Nieuwenhuizen Reviewed-by: Eric Engestrom --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH v2 5/6] radv: do not open random render node(s)

2017-02-15 Thread Emil Velikov
From: Emil Velikov drmGetDevices2() provides us with enough flexibility to build heuristics upon. Opening a random node on the other hand will wake up the device, regardless if it's the one we're interested or not. v2: Rebase. Cc: Michel Dänzer Cc: Dave Airlie Signed-off-by: Emil Velikov Rev

[Mesa-dev] [PATCH v2 2/6] loader: use drmGetDevice[s]2 API

2017-02-15 Thread Emil Velikov
From: Emil Velikov By this allows us to fetch the device list/info w/o the revision field. At the moment retrieving the latter wakes up the device. Note: kernel patch to resolve that should be in 4.10. Signed-off-by: Emil Velikov Reviewed-by: Michel Dänzer Reviewed-by: Eric Engestrom --- Due

[Mesa-dev] [PATCH v2 3/6] winsys/amdgpu: use drmGetDevice2 API

2017-02-15 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit Signed-off-by: Emil Velikov Reviewed-by: Michel Dänzer Reviewed-by: Marek Olšák Reviewed-by: Eric Engestrom --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/w

[Mesa-dev] [PATCH v2 0/6] Use drmGetDevice[s]2 API

2017-02-15 Thread Emil Velikov
Hi all, This is mostly a resent from v1, with a couple of fixes on the ANV patch and commit message polish as per Eric/Michel's input. In case you've forgotten: Using the non "2" API fetches the PCI revision field, which wakes up the device [even if we don't end up using it], which can lead to

[Mesa-dev] [PATCH] anv: remove spec quote from anv_EnumeratePhysicalDevices

2017-02-15 Thread Emil Velikov
From: Emil Velikov The VK_SUCCESS/VK_INCOMPLETE pattern is quite common. Signed-off-by: Emil Velikov --- Based on top of the drmGetDevice2 series sent earlier. src/intel/vulkan/anv_device.c | 17 - 1 file changed, 17 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/s

Re: [Mesa-dev] [PATCH] util/disk_cache: do not allow space in MESA_GLSL_CACHE_MAX_SIZE

2017-02-15 Thread Emil Velikov
On 9 February 2017 at 13:35, Emil Velikov wrote: > From: Emil Velikov > > No other env var used in mesa allows for space in the variable contents. > > Signed-off-by: Emil Velikov > --- > Worth documenting and/or even renaming them ? Tim, with the documentation going in, we can land this ? We mi

Re: [Mesa-dev] [PATCH v2 6/6] anv: do not open random render node(s)

2017-02-15 Thread Ilia Mirkin
On Wed, Feb 15, 2017 at 10:51 AM, Emil Velikov wrote: > From: Emil Velikov > > drmGetDevices2() provides us with enough flexibility to build heuristics > upon. Opening a random node on the other hand will wake up the device, > regardless if it's the one we're interested or not. > > v2: > - Expli

Re: [Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

2017-02-15 Thread Samuel Pitoiset
On 02/15/2017 05:36 PM, Mark Janes wrote: With this series, I encounter the following crash using wflinfo: wflinfo: src/mesa/drivers/dri/common/xmlconfig.c:1028: driQueryOptionb: Assertion `cache->info[i].name != ((void *)0)' failed. Mmh. Can you provide a full backtrace? Samuel Pitoiset

[Mesa-dev] [RFC] nir/builder: Add support for easily building control-flow

2017-02-15 Thread Jason Ekstrand
--- src/compiler/nir/nir_builder.h | 41 + 1 file changed, 41 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index 194d327..cdfc15b 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h

Re: [Mesa-dev] [RFC] nir/builder: Add support for easily building control-flow

2017-02-15 Thread Jason Ekstrand
Only build-tested. On Wed, Feb 15, 2017 at 8:43 AM, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_builder.h | 41 ++ > +++ > 1 file changed, 41 insertions(+) > > diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_ > builder.h > index 194d

Re: [Mesa-dev] [PATCH v2 6/6] anv: do not open random render node(s)

2017-02-15 Thread Emil Velikov
On 15 February 2017 at 16:38, Ilia Mirkin wrote: >> +anv_enumerate_devices(struct anv_instance *instance) >> +{ >> + /* TODO: Check for more devices ? */ >> + drmDevicePtr devices[8]; >> + VkResult result = VK_SUCCESS; Should read VkResult result = VK_ERROR_INCOMPATIBLE_DRIVER; >> +

Re: [Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

2017-02-15 Thread Mark Janes
With this series, I encounter the following crash using wflinfo: wflinfo: src/mesa/drivers/dri/common/xmlconfig.c:1028: driQueryOptionb: Assertion `cache->info[i].name != ((void *)0)' failed. Samuel Pitoiset writes: > Mesa currently doesn't allow to create 3.1+ compatibility profiles > mainly

Re: [Mesa-dev] [PATCH 32/32] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-15 Thread Marek Olšák
On Wed, Feb 15, 2017 at 1:49 PM, Nicolai Hähnle wrote: > On 14.02.2017 23:51, Marek Olšák wrote: >> >> On Tue, Feb 14, 2017 at 11:47 PM, Timothy Arceri >> wrote: >>> >>> >>> >>> On 15/02/17 08:35, Marek Olšák wrote: On Tue, Feb 14, 2017 at 9:53 PM, Timothy Arceri wrote: >

Re: [Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

2017-02-15 Thread Lionel Landwerlin
Hey Samuel, I think you forgot to define the default value for our driver. I'm not too familiar with this code. Is there a way to have default values for all dri drivers? Thanks, - Lionel On 15/02/17 16:42, Samuel Pitoiset wrote: On 02/15/2017 05:36 PM, Mark Janes wrote: With this series

[Mesa-dev] [PATCH] i965: define default allow_higher_compat_version value

2017-02-15 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Fixes: 9d16f3903e2 ("driconf: add allow_higher_compat_version option") --- src/mesa/drivers/dri/i965/intel_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 83b1f

Re: [Mesa-dev] [PATCH] i965: define default allow_higher_compat_version value

2017-02-15 Thread Samuel Pitoiset
Thanks. Reviewed-by: Samuel Pitoiset On 02/15/2017 05:59 PM, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin Fixes: 9d16f3903e2 ("driconf: add allow_higher_compat_version option") --- src/mesa/drivers/dri/i965/intel_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/m

Re: [Mesa-dev] [PATCH] i965: define default allow_higher_compat_version value

2017-02-15 Thread Matt Turner
Reviewed-by: Matt Turner Please commit ASAP. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] util: Add helpers for iterating over Vulkan extension structs

2017-02-15 Thread Jason Ekstrand
On Wed, Feb 15, 2017 at 2:14 AM, Grazvydas Ignotas wrote: > On Wed, Feb 15, 2017 at 2:03 AM, Jason Ekstrand > wrote: > > --- > > src/util/Makefile.sources | 3 ++- > > src/util/vk_util.h| 43 ++ > + > > 2 files changed, 45 insertions(+), 1 deleti

[Mesa-dev] [PATCH] util: Fix a typo in Makefile.sources

2017-02-15 Thread Jason Ekstrand
--- src/util/Makefile.sources | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/Makefile.sources b/src/util/Makefile.sources index eec0311..aecb7c2 100644 --- a/src/util/Makefile.sources +++ b/src/util/Makefile.sources @@ -45,7 +45,7 @@ MESA_UTIL_FILES :=\ u_

Re: [Mesa-dev] [PATCH] egl: _eglFilterArray's filter is always non-null

2017-02-15 Thread Eric Engestrom
On Wednesday, 2017-02-15 15:36:00 +, Emil Velikov wrote: > From: Emil Velikov > > Drop the extra handling and assert() if things change in the future. > > Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom > --- > src/egl/main/eglarray.c | 27 +-- > 1 file c

Re: [Mesa-dev] [PATCH] util: Fix a typo in Makefile.sources

2017-02-15 Thread Eric Engestrom
Reviewed-by: Eric Engestrom On Wednesday, 2017-02-15 09:30:01 -0800, Jason Ekstrand wrote: > --- > src/util/Makefile.sources | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/Makefile.sources b/src/util/Makefile.sources > index eec0311..aecb7c2 100644 > --- a/src

[Mesa-dev] [PATCH] anv/formats: handle correctly multisamples in gen7

2017-02-15 Thread Juan A. Suarez Romero
According to Ivybridge PRM, Volume 4 Part 1 p73, signed integer formats cannot be multisampled. Also in the same PRM p63, any format with greater than 64 bits per element cannot be multisampled. This fixes the following Vulkan CTS tests in Haswell: dEQP-VK.memory.requirements.image.regular_tilin

Re: [Mesa-dev] [PATCH] anv/formats: handle correctly multisamples in gen7

2017-02-15 Thread Jason Ekstrand
On Wed, Feb 15, 2017 at 10:09 AM, Juan A. Suarez Romero wrote: > According to Ivybridge PRM, Volume 4 Part 1 p73, signed integer formats > cannot be multisampled. > > Also in the same PRM p63, any format with greater than 64 bits per > element cannot be multisampled. > > This fixes the following

Re: [Mesa-dev] [PATCH] getteximage: Return correct error value when texure object is not found

2017-02-15 Thread Eduardo Lima Mitev
On 02/15/2017 01:56 PM, Nicolai Hähnle wrote: > On 15.02.2017 12:14, Eduardo Lima Mitev wrote: >> glGetTextureSubImage() and glGetCompressedTextureSubImage() are currently >> returning INVALID_OPERATION error when the passed texture argument >> does not >> correspond to an existing texture object.

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-15 Thread Matt Turner
On Wed, Feb 15, 2017 at 4:03 AM, Emil Velikov wrote: > Hi Matt, > > Afaics dl_iterate_phdr is available on musl, (some?) BSDs and Solaris > - thank you for opting for it. > > Out of curiosity: > Have you checked if on those platforms the "GNU\0" strcmp is > applicable and not another string ? Wort

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Matt Turner
On Wed, Feb 15, 2017 at 6:05 AM, Emil Velikov wrote: > Hi Matt, > > On 14 February 2017 at 23:58, Matt Turner wrote: >> The --build-id=... ld flag has been present since binutils-2.18, >> released 28 Aug 2007. >> --- >> src/intel/vulkan/Makefile.am | 1 + >> src/intel/vulkan/anv_device.c | 28

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

2017-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #17 from Joeri Capens --- The new patches work great for me. No more brightly colored fog which occurred randomly and often made the game impossible to play. I'm on Gentoo with a 4.9.9 kernel, RX 460 card. Thank you for the amazing

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-15 Thread Jason Ekstrand
On Wed, Feb 15, 2017 at 10:57 AM, Matt Turner wrote: > On Wed, Feb 15, 2017 at 4:03 AM, Emil Velikov > wrote: > > Hi Matt, > > > > Afaics dl_iterate_phdr is available on musl, (some?) BSDs and Solaris > > - thank you for opting for it. > > > > Out of curiosity: > > Have you checked if on those p

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand Thanks for getting this figured out! On Tue, Feb 14, 2017 at 3:58 PM, Matt Turner wrote: > The --build-id=... ld flag has been present since binutils-2.18, > released 28 Aug 2007. > --- > src/intel/vulkan/Makefile.am | 1 + > src/intel/vulkan/anv_device.c | 28 ++

Re: [Mesa-dev] [PATCH] softpipe: implement clear_texture

2017-02-15 Thread Roland Scheidegger
Yes, I guess a new util_clear_texture helper would work - util_clear_render_target and util_clear_depth_stencil are modeled after the respective pipe functions too, so why not have a util_clear_texture modeled after the respective pipe function... Maybe rip out most of the actual implementation of

[Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Matt Turner
The --build-id=... ld flag has been present since binutils-2.18, released 28 Aug 2007. --- src/intel/vulkan/Makefile.am | 1 + src/intel/vulkan/anv_device.c | 28 +++- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel

[Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-15 Thread Matt Turner
Provides the ability to read the .note.gnu.build-id section of ELF binaries, which is inserted by the --build-id=... flag to ld. Reviewed-by: Emil Velikov --- configure.ac | 6 +++ src/util/Makefile.sources | 2 + src/util/build_id.c | 109 +

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

2017-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #18 from Bogomil Vasilev --- I can confirm the same. The blurry colors are gone. The game works perfect so far. David, are you polishing the patches before pushing them? I'm asking is because I don't see any reason not to submit it to

Re: [Mesa-dev] [PATCH 3/4] docs/submittingpatches.html: remove version tag for nominations

2017-02-15 Thread Eric Anholt
Emil Velikov writes: > From: Emil Velikov > > The version tag used to nominate has bitten even experienced mesa > developers. Not to mention that it deviates from the one used in the > kernel leading to further confusion. > > Simplify things and omit it all together. > > Signed-off-by: Emil Velc

Re: [Mesa-dev] [PATCH v3 04/24] i965/fs: double regioning parameters and execsize for DF in IVB/BYT

2017-02-15 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > From: "Juan A. Suarez Romero" > > In IVB and BYT, both regioning parameters and execution sizes are measured as > 32-bits element size. > > So when we have something like: > > mov(8) g2<1>DF g3<4,4,1>DF > > We are not actually moving 8 doubles (our intention),

Re: [Mesa-dev] [PATCH 1/3] radv/ac: add support for some integer size conversions.

2017-02-15 Thread Bas Nieuwenhuizen
On Wed, Feb 15, 2017, at 09:43, Dave Airlie wrote: > From: Dave Airlie > > zero extend ->u64 and sign extend ->i64. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to_llvm.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/amd/common/ac_nir_to_llvm.c > b/src/

Re: [Mesa-dev] [PATCH v3 06/24] i965: Use <0, 2, 1> region for scalar DF sources on IVB/BYT.

2017-02-15 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > From: Matt Turner > > On HSW+, scalar DF sources can be accessed using the normal <0,1,0> > region, but on IVB and BYT DF regions must be programmed in terms of > floats. A <0,2,1> region accomplishes this. > > v2: > - Apply region <0,2,1> in brw_reg_from_fs_r

[Mesa-dev] [Bug 99789] Memory leak on failure to create an ir_constant in calculate_iterations in loop_controls.cpp

2017-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99789 Matt Turner changed: What|Removed |Added CC|damian.di...@gmail.com | --- Comment #1 from Matt Turner --- (you

Re: [Mesa-dev] [PATCH v3 08/24] i965/fs: fix dst stride in IVB/BYT type conversions

2017-02-15 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > From: "Juan A. Suarez Romero" > > When converting a DF to 32-bit conversions, we set dst stride to 2, > to fulfill alignment restrictions because the upper Dword of every > Qword will be written with undefined value. > > But in IVB/BYT, this is not necessary,

Re: [Mesa-dev] [PATCH v3 09/24] i965/fs: fix lower SIMD width for IVB/BYT's MOV_INDIRECT

2017-02-15 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > From: "Juan A. Suarez Romero" > > According to the IVB and HSW PRMs: > > "2.When the destination requires two registers and the sources are > indirect, the sources must use 1x1 regioning mode." > > So for DF instructions the execution size is not limited by t

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Emil Velikov
On 15 February 2017 at 19:00, Matt Turner wrote: > On Wed, Feb 15, 2017 at 6:05 AM, Emil Velikov > wrote: >> Hi Matt, >> >> On 14 February 2017 at 23:58, Matt Turner wrote: >>> The --build-id=... ld flag has been present since binutils-2.18, >>> released 28 Aug 2007. >>> --- >>> src/intel/vulk

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Chad Versace
Series is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 0/3] i965: INTEL_performance_query for pipeline stats

2017-02-15 Thread Robert Bragg
To hopefully make progress towards landing support for OA unit metrics exposed via INTEL_performance_query the idea here is to first just tackle upstreaming the backend rework with an initial implementation supporting pipeline statistics. In case anyone wants to look ahead, my branch with these pa

[Mesa-dev] [PATCH 3/3] i965: Implement INTEL_performance_query backend

2017-02-15 Thread Robert Bragg
This adds a bare-bones backend for the INTEL_performance_query extension that exposes pipeline statistics. Although this could be considered redundant given that the same statistics are already available via query objects, they are a simple starting point for this extension and it's expected to be

[Mesa-dev] [PATCH 2/3] Model INTEL perf query backend after query object BE

2017-02-15 Thread Robert Bragg
Instead of using the same backend interface as AMD_performance_monitor this defines a dedicated INTEL_performance_query interface that is modelled more on the ARB_query_buffer_object interface (considering the similarity of the extensions) with the addition of vfuncs for initializing and enumeratin

[Mesa-dev] [PATCH 1/3] Separate INTEL_performance_query frontend

2017-02-15 Thread Robert Bragg
To allow the backend interfaces for AMD_performance_monitor and INTEL_performance_query to evolve independently based on the more specific requirements of each extension this starts by separating the frontends of these extensions. Even though there wasn't much tying these frontends together, this

Re: [Mesa-dev] How about vk_features.txt?

2017-02-15 Thread Romain Failliot
I won't have time for the next 2 weeks, but after that I'll propose a file formatted in a way that is both easy to parse and easy to edit by a human. 2017-02-12 21:58 GMT-05:00 Jason Ekstrand : > I'm certainly not opposed. I've considered adding such a tracking file > for a while. I'm not sure

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Chad Versace
On Wed 15 Feb 2017, Emil Velikov wrote: > On 14 February 2017 at 21:02, Chad Versace wrote: > > On Tue 14 Feb 2017, Kenneth Graunke wrote: > >> On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: > >> > On Tue 14 Feb 2017, Matt Turner wrote: > >> > > >> > > >> > > static bool > >> >

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

2017-02-15 Thread Jason Ekstrand
On Wed, Feb 15, 2017 at 1:54 PM, Chad Versace wrote: > On Wed 15 Feb 2017, Emil Velikov wrote: > > On 14 February 2017 at 21:02, Chad Versace > wrote: > > > On Tue 14 Feb 2017, Kenneth Graunke wrote: > > >> On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: > > >> > On Tue 14 Feb

[Mesa-dev] [PATCH] [swr] fix windows build

2017-02-15 Thread George Kyriazis
move util/u_upload_mgr.h inside extern "C" --- src/gallium/drivers/swr/swr_context.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/swr_context.cpp b/src/gallium/drivers/swr/swr_context.cpp index 2e37bac..04ff146 100644 --- a/src/gallium/drivers/swr/

Re: [Mesa-dev] [PATCH] [swr] fix windows build

2017-02-15 Thread Ilia Mirkin
I'd rather see the remainder of the headers fixed to be includable from C++ contexts. extern "C" { #include } is an anti-pattern... -ilia On Wed, Feb 15, 2017 at 5:23 PM, George Kyriazis wrote: > move util/u_upload_mgr.h inside extern "C" > --- > src/gallium/drivers/swr/swr_context.cpp | 2 +-

Re: [Mesa-dev] [PATCH] util/disk_cache: do not allow space in MESA_GLSL_CACHE_MAX_SIZE

2017-02-15 Thread Timothy Arceri
On 16/02/17 03:37, Emil Velikov wrote: On 9 February 2017 at 13:35, Emil Velikov wrote: From: Emil Velikov No other env var used in mesa allows for space in the variable contents. Signed-off-by: Emil Velikov --- Worth documenting and/or even renaming them ? Tim, with the documentation goin

Re: [Mesa-dev] [PATCH] [swr] fix windows build

2017-02-15 Thread Kyriazis, George
You mean use extern "C" (inside a c++ guard) on u_upload_mgr.h and friends? Thanks, George > -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Wednesday, February 15, 2017 4:25 PM > To: Kyriazis, George > Cc: mesa-dev@lists.free

Re: [Mesa-dev] [PATCH] [swr] fix windows build

2017-02-15 Thread Ilia Mirkin
Yeah, just like all the other headers: #ifdef __cplusplus extern "C" { #endif define api's #ifdef __cplusplus } #endif You can see examples in, e.g., u_bitcast.h (picked one at random). On Wed, Feb 15, 2017 at 5:45 PM, Kyriazis, George wrote: > You mean use extern "C" (inside a c++ guard) on

[Mesa-dev] [PATCH 2/5] glsl/nir: Use nir_builder's new control-flow helpers

2017-02-15 Thread Jason Ekstrand
--- src/compiler/glsl/glsl_to_nir.cpp | 38 +++--- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index 96d8164..e46fe2c 100644 --- a/src/compiler/glsl/glsl_to_nir.cpp +++ b/src/

[Mesa-dev] [PATCH 1/5] nir/builder: Add support for easily building control-flow

2017-02-15 Thread Jason Ekstrand
Each of the pop functions (and push_else) take a control flow parameter as their second argument. If NULL, it assumes that the builder is in a block that's a direct child of the control-flow node you want to pop off the virtual stack. This is what 90% of consumers will want. The SPIR-V pass, how

[Mesa-dev] [PATCH 4/5] nir/lower_indirect: Use nir_builder control-flow helpers

2017-02-15 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_indirect_derefs.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/src/compiler/nir/nir_lower_indirect_derefs.c b/src/compiler/nir/nir_lower_indirect_derefs.c index 09cc9a3..52adde8 100644 --- a/src/compiler/nir/nir_lower_indi

[Mesa-dev] [PATCH 0/5] nir/builder: Add control-flow helpers

2017-02-15 Thread Jason Ekstrand
I was looking at Ian's int64 lowering code last night and was thinking about what the lowering would look like in NIR. The fact that it uses loops and other control flow for handling division got me thinking about doing control flow in nir_builder again. So I spent a little time this morning and

[Mesa-dev] [PATCH 3/5] nir/lower_gs_intrinsics: Use nir_builder control-flow helpers

2017-02-15 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_gs_intrinsics.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir_lower_gs_intrinsics.c b/src/compiler/nir/nir_lower_gs_intrinsics.c index 3acb742..68e20dd 100644 --- a/src/compiler/nir/nir_lower_gs_intrinsics.c +++ b/

[Mesa-dev] [PATCH 5/5] spirv: Use nir_builder for control flow

2017-02-15 Thread Jason Ekstrand
--- src/compiler/spirv/vtn_cfg.c | 45 ++-- 1 file changed, 14 insertions(+), 31 deletions(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index 3a31657..54248b1 100644 --- a/src/compiler/spirv/vtn_cfg.c +++ b/src/compiler/spirv/

  1   2   >