Re: [Mesa-dev] [PATCH 00/25] anv: A major rework of color attachment surface states

2016-10-27 Thread Pohjolainen, Topi
On Wed, Oct 26, 2016 at 07:11:20PM +0300, Pohjolainen, Topi wrote: > > I had a few qeustions in 1 and 3, but regardless patches 1-7 and 9-13 are: > > Reviewed-by: Topi Pohjolainen 14-17 are also: Reviewed-by: Topi Pohjolainen ___ mesa-dev mailing li

Re: [Mesa-dev] [PATCH v2] glsl: compute lvalues of [in]out parameters before inlined function body

2016-10-27 Thread Nicolai Hähnle
Ping. On 20.10.2016 11:00, Nicolai Hähnle wrote: From: Nicolai Hähnle This is required when an out argument involves an array index that is either a global variable modified by the function or another out argument in the same function call. Fixes the shaders/out-parameter-indexing/vs-inout-in

[Mesa-dev] [PATCH] radeonsi: fix behavior of GLSL findLSB(0)

2016-10-27 Thread Marek Olšák
From: Marek Olšák 12.0 and older need the same fix but elsewhere. Cc: 13.0 --- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c b/src/gallium/drivers/radeo

Re: [Mesa-dev] [PATCH v2 4/6] nv50/ir: restructure postraconstantfolding pass

2016-10-27 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset One minor comment below. On 10/09/2016 11:04 AM, Karol Herbst wrote: we might want to add more folding passes here, so make it a bit more generic v2: leave the comment and reword commit message Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir

[Mesa-dev] [PATCH] vulkan/wsi/x11: handle timeouts properly in next image acquire (v1.1)

2016-10-27 Thread Dave Airlie
From: Dave Airlie For 0 timeout, just poll for an event, and if none, return For UINT64_MAX timeout, just wait for special event blocked For other timeouts get the xcb fd and block on it, decreasing the timeout if we get woken up for non-special events. v1.1: return VK_TIMEOUT for poll timeouts.

Re: [Mesa-dev] [PATCH 3/3] i965: Don't use nir_assign_var_locations for VS/TES/GS outputs.

2016-10-27 Thread Iago Toral
On Sun, 2016-10-23 at 23:44 -0700, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- >  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 - >  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 46 ++-- > >  src/mesa/drivers/dri/i965/brw_nir.c  | 13 +++-

Re: [Mesa-dev] [PATCH 4/4] configure.ac: check for Glamor requirements only when needed

2016-10-27 Thread Marek Olšák
On Mon, Oct 24, 2016 at 7:41 PM, Emil Velikov wrote: > On 24 October 2016 at 18:21, Marek Olšák wrote: >> On Mon, Oct 24, 2016 at 11:33 AM, Emil Velikov >> wrote: >>> On 19 October 2016 at 19:31, Marek Olšák wrote: On Wed, Oct 19, 2016 at 2:40 PM, Emil Velikov wrote: > On 18 Oc

[Mesa-dev] [PATCH 4/5] st/mesa: set RobustAccess true when is supported

2016-10-27 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/state_tracker/st_manager.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index 6922454..0f71e63 100644 --- a/src/mesa/state_tracker/st_manager.c +++ b/src/m

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: critical fixes

2016-10-27 Thread Bas Nieuwenhuizen
For the series: Reviewed-by: Bas Nieuwenhuizen On Tue, Oct 25, 2016 at 12:23 AM, Marek Olšák wrote: > Patch 1: SI fix for MSAA for Mesa 13.0. I don't know the impact of that bug. > Patch 2: Possible GPU hang fix for Hawaii and Fiji when using separate CMASK. > Patch 3: Addrlib integration fix t

[Mesa-dev] [PATCH 3/3] gallium/hud: protect against and initialization race

2016-10-27 Thread Steven Toth
In the event that multiple threads attempt to install a graph concurrently, protect the shared list. Signed-off-by: Steven Toth --- src/gallium/auxiliary/hud/hud_cpufreq.c | 12 ++-- src/gallium/auxiliary/hud/hud_diskstat.c | 13 +++-- src/gallium/auxiliary/hud/hud_nic.c

[Mesa-dev] [PATCH 11/24] gallium/radeon: decrease the size of radeon_surf

2016-10-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 4 +- src/gallium/drivers/radeon/radeon_winsys.h | 62 +++--- src/gallium/winsys/radeon/drm/radeon_drm_surface.c | 4 +- 3 files changed, 36 insertions(+), 34 deletions(-) diff --git a/src/galli

[Mesa-dev] [PATCH 24/24] radeonsi: remove si_resource_create_custom

2016-10-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 6 +++--- src/gallium/drivers/radeonsi/si_cp_dma.c| 7 +++ src/gallium/drivers/radeonsi/si_pipe.h | 8 src/gallium/drivers/radeonsi/si_shader.c| 6 +++--- src/gallium/drivers/radeonsi/si

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: fix mismatch between TGSI BFI/BFE and GLSL

2016-10-27 Thread Nicolai Hähnle
On 24.10.2016 16:44, Ilia Mirkin wrote: On Mon, Oct 24, 2016 at 10:05 AM, Nicolai Hähnle wrote: On 24.10.2016 15:49, Ilia Mirkin wrote: On Mon, Oct 24, 2016 at 9:43 AM, Nicolai Hähnle wrote: On 24.10.2016 15:38, Nicolai Hähnle wrote: On 24.10.2016 15:34, Ilia Mirkin wrote: These work

[Mesa-dev] [PATCH 2/3] st/vdpau: use dri3 to direclty send the buffer to X

2016-10-27 Thread Nayan Deshmukh
this avoids an extra copy which occurs in case of dri2 Suggested-by: Christian König Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/presentation.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/state_trackers/vdpau/presentation.c b/src/gallium/state_

[Mesa-dev] [PATCH 3/6] i965/blit: Remove a bogus assertion

2016-10-27 Thread Jason Ekstrand
This assertion, while valid for linear buffers, doesn't work properly for tiled memory. It used to work most of the time because the offset provided was always to the left-hand edge of the image. However, if you use a byte offset to get to the inside of the image, the height * stride calculation

Re: [Mesa-dev] [PATCH 01/25] intel/isl: Add some basic info about RENDER_SURFACE_STATE to isl_device

2016-10-27 Thread Jason Ekstrand
On Oct 25, 2016 2:18 AM, "Pohjolainen, Topi" wrote: > > On Sat, Oct 22, 2016 at 10:50:32AM -0700, Jason Ekstrand wrote: > > Signed-off-by: Jason Ekstrand > > --- > > src/intel/blorp/blorp_genX_exec.h| 33 -- > > src/intel/isl/isl.c | 19 ++

[Mesa-dev] [PATCH 15/59] glsl: Add 64-bit integer support to uniform initialiser code

2016-10-27 Thread Ian Romanick
From: Dave Airlie Just add support to the double case, same code should work. Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick --- src/compiler/glsl/link_uniform_initializers.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_uniform_initial

Re: [Mesa-dev] [PATCH 03/25] anv: Add a helper for doing buffer copies with nothing but VF and SOL.

2016-10-27 Thread Pohjolainen, Topi
On Sat, Oct 22, 2016 at 10:50:34AM -0700, Jason Ekstrand wrote: > This method of doing copies has the advantage of touching very little of > the GPU state. While it does disable all the shader stages, it doesn't > have to blow away binding tables, viewports, scissors, or any other bits of > dynami

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Tue, Oct 25, 2016 at 11:11:13PM +0100, Andy Furniss wrote: > Nayan Deshmukh wrote: > > Hi Andy, > > > > It seems that you have compiled mesa with DRI3 enabled but > > vl_dri3_screen_create returns > > runs when called in device.c and hence VDPAU fallbacks to using DRI2. > > > > BTW I have sen

[Mesa-dev] [PATCH 10/24] gallium/radeon: pass pipe_resource and other params to surface_init directly

2016-10-27 Thread Marek Olšák
From: Marek Olšák This removes input-only parameters from the radeon_surf structure. Some of the translation logic from pipe_resource to radeon_surf is moved to winsys/radeon. --- src/gallium/drivers/radeon/r600_texture.c | 120 ++--- src/gallium/drivers/radeon/radeon_winsy

[Mesa-dev] [PATCH 38/59] glsl: Add a lowering pass for 64-bit integer sign()

2016-10-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/ir_optimization.h | 1 + src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 8 insertions(+) diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h index 4f8a346..b52b7d1 100644

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
s/runs/null/ On Wed, Oct 26, 2016 at 01:57:12AM +0530, Nayan Deshmukh wrote: > Hi Andy, > > It seems that you have compiled mesa with DRI3 enabled but > vl_dri3_screen_create returns > runs when called in device.c and hence VDPAU fallbacks to using DRI2. > > BTW I have sent in the v1.1 for pat

Re: [Mesa-dev] [PATCH 2/9] glsl: merge layouts into the default one as the last step in interface blocks

2016-10-27 Thread Andres Gomez
On Mon, 2016-10-24 at 12:23 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > > Consider this example: > > > > " #version 150 core > >   #extension GL_ARB_shading_language_420pack: require > >   #extension GL_ARB_explicit_attrib_location: require >

[Mesa-dev] [PATCH 01/24] gallium/radeon: fix a ZPASS comment, EVENT_WRITE_EOP fixups

2016-10-27 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/sid.h | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++-- src/gallium/drivers/radeon/r600_query.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amd/common/sid.h b/src/amd/common/sid.h i

[Mesa-dev] [PATCH] glsl: do not show locp information if it is not available

2016-10-27 Thread Juan A. Suarez Romero
Ignore source file, line number and column in glcpp_error() and glcpp_warning() if those are not available. It fixes 4 piglit tests: spec/glsl-1.10/compiler/version-0.frag: crash pass spec/glsl-1.10/compiler/version-0.vert: crash pass spec/glsl-es-3.00/compiler/version-0.frag: crash pass s

[Mesa-dev] [PATCH 2/2] glsl: Size TCS->TES unsized arrays to gl_MaxPatchVertices for queries.

2016-10-27 Thread Kenneth Graunke
SSO validation and other program interface queries want to see that unsized (non-patch) TCS output/TES input arrays are implicitly sized to gl_MaxPatchVertices. By the time we create the program resource lists, we've sized the arrays to their actual size. (We try to create TCS output arrays to ma

[Mesa-dev] [PATCH 3/8] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

2016-10-27 Thread Andres Gomez
From page 46 (page 52 of the PDF) of the GLSL 4.20 spec: " More than one layout qualifier may appear in a single declaration. If the same layout-qualifier-name occurs in multiple layout qualifiers for the same declaration, the last one overrides the former ones." Consider this examp

[Mesa-dev] [PATCH 56/59] i965: Enable uploading 64-bit integer uniforms

2016-10-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp b/src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp index b752ad5..a45fede 100644

[Mesa-dev] [PATCH 7/8] Revert "glsl: allow layout qualifier overrides with ARB_shading_language_420pack"

2016-10-27 Thread Andres Gomez
This reverts commit aaa69c79cd584db4d9c6ea7794e93d29f3d54572. The commit was erroneous because the ast_layout_expression class is meant to hold a list used for an after check that all the declared values for a layout-qualifier-name are consistent. Therefore, the check for the possibility of dupli

Re: [Mesa-dev] [PATCH 01/25] intel/isl: Add some basic info about RENDER_SURFACE_STATE to isl_device

2016-10-27 Thread Pohjolainen, Topi
On Tue, Oct 25, 2016 at 09:13:59AM -0700, Jason Ekstrand wrote: >On Oct 25, 2016 2:18 AM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@gmail.com> wrote: >> >> On Sat, Oct 22, 2016 at 10:50:32AM -0700, Jason Ekstrand wrote: >> > Signed-off-by: Jason Ekstrand <[2]ja...@jlekstrand.net

[Mesa-dev] [PATCH] radeonsi: set VGT_GS_ONCHIP_CNTL on CIK and later

2016-10-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 42689da..0633b64 100644 --- a/src/gallium/drivers/radeonsi/si_state.c +++ b/src/galli

Re: [Mesa-dev] [PATCH v2] glsl: Add pthread libs to cache_test

2016-10-27 Thread Rhys Kidd
On 26 October 2016 at 00:47, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > > I guess you don't have commit access? > I do not have commit access, so would appreciate if you could please push to master. > > On Wed, 2016-10-26 at 00:13 -0400, Rhys Kidd wrote: > > Fixes the following com

[Mesa-dev] [PATCH 14/59] glsl/varyings: Add 64-bit integer support.

2016-10-27 Thread Ian Romanick
From: Dave Airlie This adds 64-bit ints to the link_varyings 64-bit support. Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick --- src/compiler/glsl/link_varyings.h | 8 1 file changed, 8 insertions(+) diff --git a/src/compiler/glsl/link_varyings.h b/src/compiler/glsl/link_varyi

[Mesa-dev] [PATCH 1/5] nir: add support for counting AoA uniforms in nir_shader_gather_info()

2016-10-27 Thread Timothy Arceri
--- src/compiler/nir/nir_gather_info.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_gather_info.c b/src/compiler/nir/nir_gather_info.c index e5cedd9..7d349d5 100644 --- a/src/compiler/nir/nir_gather_info.c +++ b/src/compiler/nir/nir_gather_info.c @@

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-27 Thread Tapani Pälli
On 10/27/2016 12:16 AM, Rob Clark wrote: So, not quite sure if this is the *correct* solution, but it is at least *a* solution to a problem with android wallpaper vs mesa that I've been debugging. Basically, what happens is: Could you tell more how to trigger this, is this with some particular

[Mesa-dev] [PATCH 2/5] mesa/glsl: copy num_images to gl_program

2016-10-27 Thread Timothy Arceri
We should be able to free gl_linked_shader after linking in order to do so we need to switch to getting values from gl_program instead. --- src/compiler/glsl/glsl_to_nir.cpp | 1 - src/mesa/main/shaderapi.c | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/

[Mesa-dev] [PATCH 3/5] i965: get num_images from shader_info rather than gl_linked_shader

2016-10-27 Thread Timothy Arceri
This is a step towards freeing gl_linked_shader after linking. --- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_context.h | 1 + src/mesa/drivers/dri/i965/brw_cs.c| 5 +++-- src/mesa/drivers/dri/i965/brw_gs.c

[Mesa-dev] [PATCH 4/5] mesa/glsl: copy num_abos to gl_program

2016-10-27 Thread Timothy Arceri
We should be able to free gl_linked_shader after linking in order to do so we need to switch to getting values from gl_program instead. --- src/compiler/glsl/glsl_to_nir.cpp | 1 - src/mesa/main/shaderapi.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/gl

[Mesa-dev] [PATCH 5/5] i965: get num_abos from shader_info rather than gl_linked_shader

2016-10-27 Thread Timothy Arceri
This is a step towards freeing gl_linked_shader after linking. --- src/mesa/drivers/dri/i965/brw_context.h | 1 + src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 5 +++-- src/mesa/drivers/dri/i965/brw_shader.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_tcs_surface_state.c

[Mesa-dev] [PATCH 2/2] radeonsi: fix BFE/BFI lowering for GLSL semantics

2016-10-27 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes spec/arb_gpu_shader5/execution/built-in-functions/*-bitfield{Extract,Insert} Cc: 13.0 --- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 37 +-- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_s

[Mesa-dev] [PATCH 1/2] tgsi: align the definition of BFI & [UI]BFE with GLSL

2016-10-27 Thread Nicolai Hähnle
From: Nicolai Hähnle As previously written, these opcodes use the SM5 semantics which is incompatible with GLSL when bits == 0, offset == 32. At some point we may want to add BFI_SM5 etc. opcodes, but all users currently either want (and expect!) the GLSL semantics or don't care. Bitfield inser

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Andy Furniss
Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox window manager, which does not use compositing - IIRC this has historically shown some

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-27 Thread Timothy Arceri
On Thu, 2016-10-27 at 12:37 +1100, Timothy Arceri wrote: > On Wed, 2016-10-26 at 20:19 -0400, Ilia Mirkin wrote: > > > > On Wed, Oct 26, 2016 at 8:08 PM, Timothy Arceri > > wrote: > > > > > > > > > On Wed, 2016-10-26 at 22:51 +1100, Timothy Arceri wrote: > > > > > > > > > > > > On Wed, 2016-1

[Mesa-dev] [Bug 97804] Later precision statement isn't overriding earlier one

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97804 Eero Tamminen changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #4 from Eero Tammin

Re: [Mesa-dev] [PATCH v2 2/2] glsl: update default precision qualifier when it is set in the shader

2016-10-27 Thread Eero Tamminen
Hi, Glmark2 is fairly common test. Shouldn't this regression bugfix be CC to stable? (Regression happened with https://bugs.freedesktop.org/show_bug.cgi?id=97532) - Eero On 26.10.2016 12:23, Samuel Iglesias Gonsálvez wrote: Default precision qualifier for a data type could be se

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-27 Thread Rob Clark
On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli wrote: > On 10/27/2016 12:16 AM, Rob Clark wrote: >> >> So, not quite sure if this is the *correct* solution, but it is at least >> *a* solution to a problem with android wallpaper vs mesa that I've been >> debugging. Basically, what happens is: > > >

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Andy Furniss
Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox window manager, which does not use compositing - IIRC this has his

Re: [Mesa-dev] [PATCH] radv: split the device local memory heap into two

2016-10-27 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 10/27/2016 11:49 AM, Fredrik Höglund wrote: > Advertise two device local memory heaps; one that is host visible > and one that is not. > > This makes it possible for clients to tell how much host visible > vs. non-host visible memory is available. > --- > src/

Re: [Mesa-dev] [PATCH] intel/blorp: Fix a couple asserts around image copy rectangles

2016-10-27 Thread Eero Tamminen
Hi, Tested. Unreal Engine assert isn't anymore triggered. When this patch goes in, you can mark the bug as verified. - Eero On 26.10.2016 08:53, Jason Ekstrand wrote: With dealing with rectangles in compressed images, you can have a width or height that isn't a multiple of the cor

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Andres Gomez
On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: > Hi, > > recently, we have noticed that we are not receiving some of the mails > that we have sent to the ML. > > The mails are archived, though, but we don't get the copy from the ML.  > > We were checking if this was a problem in our side

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Emil Velikov
On 27 October 2016 at 12:06, Andres Gomez wrote: > On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: >> Hi, >> >> recently, we have noticed that we are not receiving some of the mails >> that we have sent to the ML. >> >> The mails are archived, though, but we don't get the copy from the ML.

Re: [Mesa-dev] [PATCH 06/59] glsl: Add a C++ code generator that uses ir_builder to rebuild a program

2016-10-27 Thread Iago Toral
I spent some time looking at this and trying and I did not find anything that did not look reasonable to me in general. I have a question below, but in any case this is: Reviewed-by: Iago Toral Quiroga BTW, now I also see why you need patch 5, you want to use the ir_builder for things like add()

Re: [Mesa-dev] [PATCH 07/59] glsl/standalone: Add the ability to generate ir_builder code

2016-10-27 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2016-10-25 at 17:59 -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- >  src/compiler/glsl/main.cpp   |  1 + >  src/compiler/glsl/standalone.cpp | 12 >  src/compiler/glsl/standalone.h   |  1 + >  3 fil

Re: [Mesa-dev] [PATCH v2 2/2] glsl: update default precision qualifier when it is set in the shader

2016-10-27 Thread Samuel Iglesias Gonsálvez
On 27/10/16 12:45, Eero Tamminen wrote: > Hi, > > Glmark2 is fairly common test. Shouldn't this regression bugfix be CC > to stable? > They can be added to next stable release but they need another commit more that removes unused namespace support from the symbol table. Emil, they should be pi

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Andres Gomez
On Thu, 2016-10-27 at 12:14 +0100, Emil Velikov wrote: > On 27 October 2016 at 12:06, Andres Gomez wrote: > > On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: > > > Hi, > > > > > > recently, we have noticed that we are not receiving some of the mails > > > that we have sent to the ML. > > >

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Martin Peres
On 27/10/16 14:41, Andres Gomez wrote: On Thu, 2016-10-27 at 12:14 +0100, Emil Velikov wrote: On 27 October 2016 at 12:06, Andres Gomez wrote: On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: Hi, recently, we have noticed that we are not receiving some of the mails that we have sent

[Mesa-dev] [PATCH 3/3] glsl/glcpp: use the prefixed name of the lexer generated functions

2016-10-27 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit. Cc: "12.0 13.0" Signed-off-by: Emil Velikov --- src/compiler/glsl/glcpp/glcpp-lex.l | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/glcpp/glcpp-lex.l b/src/compiler/glsl/glcpp/glcpp-lex.l index d09441a..41

[Mesa-dev] [PATCH 2/3] mesa/program: use the prefixed name of the lexer generated functions

2016-10-27 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit. Cc: "12.0 13.0" Signed-off-by: Emil Velikov --- src/mesa/program/program_lexer.l | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/program_lexer.l b/src/mesa/program/program_lexer.l index dee66cb..019663

[Mesa-dev] [PATCH 1/3] glsl: use the prefixed name of the lexer generated functions

2016-10-27 Thread Emil Velikov
From: Emil Velikov Flex version 2.6.2 does not expand (define) the yy version of some function, thus we fail to compile. Strictly speaking this might be a flex bug, although expanding the few instances is perfectly trivial and works with 2.6.2 and earlier versions of flex. Cc: "12.0 13.0" Cc:

[Mesa-dev] [PATCH 0/3] Flex 2.6.2 build fixes

2016-10-27 Thread Emil Velikov
Hi all, As pointed out by Mike, building Mesa with latest version of flex is not possible. Upon closer look it seems that the following functions are not expanded properly (the #define yyfoo ${prefix}foo is missing). yylex_init_extra yylex_destroy yy_scan_* Not 100% sure if this is flex bug o

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Andres Gomez
On Thu, 2016-10-27 at 14:47 +0300, Martin Peres wrote: > These are know issues and are being investigated by the freedes Thanks Martin! -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listin

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 11:52:13AM +0100, Andy Furniss wrote: > Andy Furniss wrote: > > Michel Dänzer wrote: > > > On 26/10/16 08:07 PM, Andy Furniss wrote: > > > > > > > > The bad = Starting with DRI3 (which is default) I still get trashed > > > > rendering full screen. Windowed including re-sizi

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Felix Schwarz
Am 27.10.2016 um 13:14 schrieb Emil Velikov: > Skimming through the above they have arrived in timely manner over here. > It might be worth checking if it's not something on your end - ISP > and/or local infra. Seems like a fdo issue to me: ,---

Re: [Mesa-dev] [PATCH 06/59] glsl: Add a C++ code generator that uses ir_builder to rebuild a program

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 02:59, Ian Romanick wrote: From: Ian Romanick This is only in libstandalone currently because it will only be used in the stand-alone compiler. v2: Change the signature of the generated function. The ir_factory is created in the generator, and an availability predicate is taken

Re: [Mesa-dev] [PATCH 0/3] Flex 2.6.2 build fixes

2016-10-27 Thread Mike Lothian
Thanks On Thu, 27 Oct 2016 at 12:51 Emil Velikov wrote: > Hi all, > > As pointed out by Mike, building Mesa with latest version of flex is > not possible. > > Upon closer look it seems that the following functions are not expanded > properly (the #define yyfoo ${prefix}foo is missing). > > yylex

Re: [Mesa-dev] [PATCH 11/59] glsl: Add basic ARB_gpu_shader_int64 types

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 02:59, Ian Romanick wrote: From: Dave Airlie This adds the builtins and the lexer support. To avoid too many warnings, it adds basic support to the type in a few other places in mesa, mostly in the trivial places. It also adds a query to be used later for if a type is an integer

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Christian König
Am 27.10.2016 um 13:14 schrieb Emil Velikov: On 27 October 2016 at 12:06, Andres Gomez wrote: On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: Hi, recently, we have noticed that we are not receiving some of the mails that we have sent to the ML. The mails are archived, though, but we d

Re: [Mesa-dev] [PATCH 12/59] mesa: Add support for 64-bit integer uniforms. (v2)

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 02:59, Ian Romanick wrote: From: Dave Airlie This hooks up the API to the internals for 64-bit integer uniforms. v2: update to use non-strict aliased alternatives Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick --- src/mesa/main/uniform_query.cpp | 82 ++

Re: [Mesa-dev] [PATCH 13/59] glsl/ast/ir: Add 64-bit integer constant support

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 02:59, Ian Romanick wrote: From: Dave Airlie This adds support for 64-bit integer constants to the parser, ast and ir. v2: fix a few issues found in testing. v3: Add missing ir_constant copy contructor support. Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick [v2] --- sr

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Andy Furniss
Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 11:52:13AM +0100, Andy Furniss wrote: Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems

Re: [Mesa-dev] [PATCH 31/59] st/glsl_to_tgsi: add support for 64-bit integers. (v2)

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 02:59, Ian Romanick wrote: From: Dave Airlie v2: add conversion opcodes. v3 (idr): Rebase on replacemtn of TGSI_OPCODE_I2U64 with TGSI_OPCODE_I2I64. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 217 ++--- 1 file changed, 1

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Emil Velikov
On 27 October 2016 at 12:41, Andres Gomez wrote: > On Thu, 2016-10-27 at 12:14 +0100, Emil Velikov wrote: >> On 27 October 2016 at 12:06, Andres Gomez wrote: >> > On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: >> > > Hi, >> > > >> > > recently, we have noticed that we are not receiving so

Re: [Mesa-dev] [PATCH] glsl: inspect interfaces in contains_foo()

2016-10-27 Thread Nicolai Hähnle
On 25.10.2016 17:53, Juan A. Suarez Romero wrote: When checking if a type contains doubles, integers, samples, etc. we check if the current type is a record or array, but not if it is an interface. This commit also inspects if the type is an interface. It fixes spec/arb_enhanced_layouts/compil

Re: [Mesa-dev] [PATCH] radeonsi: set VGT_GS_ONCHIP_CNTL on CIK and later

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 01:16, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 42689da..0633b64 100644 --- a/src/gallium/d

Re: [Mesa-dev] [PATCH] gallium/radeon: fix behavior of GLSL findLSB(0)

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 01:17, Marek Olšák wrote: From: Marek Olšák This is for 12.0 and older. A different commit fixes 13.0 and newer. Cc: 11.2 12.0 Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 19 ++- 1 file changed, 14 insertions(+), 5

Re: [Mesa-dev] [PATCH] radeonsi: fix behavior of GLSL findLSB(0)

2016-10-27 Thread Nicolai Hähnle
On 26.10.2016 01:16, Marek Olšák wrote: From: Marek Olšák 12.0 and older need the same fix but elsewhere. Cc: 13.0 --- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shad

Re: [Mesa-dev] [PATCH] radeonsi: set VGT_GS_ONCHIP_CNTL on CIK and later

2016-10-27 Thread Alex Deucher
On Thu, Oct 27, 2016 at 9:40 AM, Nicolai Hähnle wrote: > On 26.10.2016 01:16, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_state.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/src/gallium/drivers/radeonsi/si_state.c >> b/src/galli

Re: [Mesa-dev] [PATCH] radeonsi: set VGT_GS_ONCHIP_CNTL on CIK and later

2016-10-27 Thread Nicolai Hähnle
On 27.10.2016 15:43, Alex Deucher wrote: On Thu, Oct 27, 2016 at 9:40 AM, Nicolai Hähnle wrote: On 26.10.2016 01:16, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_

[Mesa-dev] [Bug 96309] Request for new account

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96309 --- Comment #5 from Rob Clark --- +1 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.o

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Leo Liu
On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ src/gallium/auxiliary/vl/vl_winsys_dri3.c | 89 +++ 2 files changed, 83 insertions(+), 10 deletions(-) diff

[Mesa-dev] [Bug 96309] Request for new account

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96309 Daniel Stone changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 Kai changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 98263, which changed state. Bug 98263 Summary: [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode." https://bugs.freedesktop.org/show_bug.cgi?id=98263 What|Removed

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-27 Thread Emil Velikov
On 17 October 2016 at 10:37, Marek Olšák wrote: > Reverting the whole commit is too much. You can just remove the PIPE BIND > SHARED usage if you need to. > I'd imagine that one wants to check if radeon(s) behave OK with the flag dropped ? Thus it might be better for someone with radeon HW to give

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 --- Comment #3 from Emil Velikov --- Hi Kai, feel free to send a patch which makes the "vulkan: No DRI3 support" message less likely to miss ;-) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee fo

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2016-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 --- Comment #4 from Kai --- The problem was not so much me not seeing that message, the problem was more that I didn't connect "no DRI3 support" equals "this game won't start and segfault. Combine that with the warning "WARNING: radv is not a con

Re: [Mesa-dev] [PATCH 1/5] swr: [rasterizer archrast] Add thread tags to event files.

2016-10-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 26, 2016, at 7:08 PM, George Kyriazis > wrote: > > This allows the post-processor to easily detect the API thread and to > process frame information. The frame information is needed to > optimized how data is processed from worker threads. > --- > src/gall

Re: [Mesa-dev] [PATCH 2/5] swr: [rasterizer core] Remove deprecated simd intrinsics

2016-10-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 26, 2016, at 7:08 PM, George Kyriazis > wrote: > > Used in abandoned all-or-nothing approach to converting to AVX512 > --- > .../drivers/swr/rasterizer/common/simdintrin.h | 633 - > .../drivers/swr/rasterizer/core/format_types.h

Re: [Mesa-dev] [PATCH 4/5] swr: [rasterizer core] Frontend dependency work

2016-10-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 26, 2016, at 7:08 PM, George Kyriazis > wrote: > > Add frontend dependency concept in the DRAW_CONTEXT, which > allows serialization of frontend work if necessary. > --- > src/gallium/drivers/swr/rasterizer/core/api.cpp | 3 +++ > src/gallium/drivers/s

Re: [Mesa-dev] [PATCH 3/5] swr: [rasterizer core] Refactor/cleanup backends

2016-10-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 26, 2016, at 7:08 PM, George Kyriazis > wrote: > > Used for common code reuse and simplification > --- > .../drivers/swr/rasterizer/core/backend.cpp| 561 - > src/gallium/drivers/swr/rasterizer/core/backend.h | 150 +- > 2 fi

Re: [Mesa-dev] [PATCH 5/5] swr: [rasterizer] added EventHandlerFile contructor

2016-10-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 26, 2016, at 7:08 PM, George Kyriazis > wrote: > > --- > .../rasterizer/scripts/templates/ar_eventhandlerfile_h.template| 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git > a/src/gallium/drivers/swr/rasterizer/scripts/template

[Mesa-dev] [PATCH 2/2] egl: Use pkg-config for Android NDK build

2016-10-27 Thread Gurchetan Singh
It's possible to build Mesa for Android using the traditional autotools workflow. To enable this, let's add the required pkg-config checks and link against them. --- configure.ac| 3 +++ src/egl/Makefile.am | 1 + 2 files changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac

[Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-27 Thread Gurchetan Singh
In Android, the pthreads libs are in bionic. When building Mesa for Android with the autotools workflow, we shouldn't set -lpthread or -pthread. --- configure.ac | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 4761c59..3f21cd5 100644 --

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: > > > On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: > > Suggested-by: Leo Liu > > Signed-off-by: Nayan Deshmukh > > --- > > src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ > > src/gallium/auxiliary/vl/vl_winsys_dri3.c | 89 > >

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Leo Liu
On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ src/gallium/auxiliary/vl/vl_w

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > > > On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: > >> On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: >> >>> >>> On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: >>> Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh ---

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:50 PM, Nayan Deshmukh wrote: > > > On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > >> >> >> On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: >> >>> On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: >>> On 10/24/2016 09:55 AM, Nayan Deshmukh wrote:

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Leo Liu
On 10/27/2016 01:20 PM, Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu > wrote: On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: On 10/24/2016 09:55 AM, Nayan Deshmukh

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-27 Thread Robert Foss
I gave this patch a spin on a Qemu+Virgl+AOSP setup, and it seems to work rather well. Thanks Rob! Tested-by: Robert Foss ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-27 Thread Marek Olšák
On Thu, Oct 27, 2016 at 5:23 PM, Emil Velikov wrote: > On 17 October 2016 at 10:37, Marek Olšák wrote: >> Reverting the whole commit is too much. You can just remove the PIPE BIND >> SHARED usage if you need to. >> > I'd imagine that one wants to check if radeon(s) behave OK with the > flag dropp

  1   2   >