Re: [Mesa-dev] [PATCH 13/25] compiler: make uses_sample_qualifier a bitfield and add uses_centroid_qualifier

On Tuesday, October 18, 2016 5:12:16 PM PDT Timothy Arceri wrote: > These need to be bitfields for use with gallium. > --- > src/compiler/glsl/glsl_to_nir.cpp | 2 +- > src/compiler/shader_info.h| 12 +--- > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/src/c

Re: [Mesa-dev] [PATCH] configure.ac: don't require DRM and GBM for surfaceless egl platform

On 18/10/16 01:47 AM, Marek Olšák wrote: From: Deepak Sharma This allows building radeonsi driver for surfaceless platform. Signed-off-by: Deepak Sharma Signed-off-by: Marek Olšák --- configure.ac | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configu

[Mesa-dev] [PATCH] drivers/meta: Accept GL_TEXTURE_3D as target for tex image decompression

An assert is currently raised, preventing decompression of a texture image into a GL_TEXTURE_3D target. I have not found any spec wording that would explain this, or implementation detail that would prevent it. And in any case, the driver should not cause a crash upon user input arguments. Fixes m

Re: [Mesa-dev] [PATCH 02/16] loader: slim down loader_get_pci_id_for_fd implementation(s)

On 11.10.2016 20:31, Emil Velikov wrote: From: Emil Velikov Currently mesa has three code paths in the loader - libudev, manual sysfs and drm ioctl one. Considering the issues we had with libudev - strip those down in favour of the libdrm drm device API. The latter can be implemented in any wa

Re: [Mesa-dev] [PATCH v2 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

On 14.10.2016 20:21, Emil Velikov wrote: From: Emil Velikov Currently not everyone has libudev and with follow-up patches we'll completely remove the divergent codepaths. Use the libdrm drm device API to construct the required ID_PATH_TAG-like string, to preserve the current functionality for

Re: [Mesa-dev] [PATCH] st/va: force to flush the last p frame in idr period

Am 17.10.2016 um 22:31 schrieb Alex Deucher: On Mon, Oct 17, 2016 at 4:16 PM, wrote: From: Boyuan Zhang During dual instance encoding submission, if the second encode task and first encode task have no reference dependency, e.g. p following with idr-frame, there is a chance the second task w

Re: [Mesa-dev] [PATCH] gm107/ir: fix texturing with indirect samplers

On 10/18/2016 05:53 AM, Ilia Mirkin wrote: The indirect handle has to come right after the coordinates, so if there was a sample/bias/depth compare/offset, everything would end up being shifted by one argument position. Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- src

Re: [Mesa-dev] [PATCH 13/25] compiler: make uses_sample_qualifier a bitfield and add uses_centroid_qualifier

On Tue, 2016-10-18 at 00:08 -0700, Kenneth Graunke wrote: > On Tuesday, October 18, 2016 5:12:16 PM PDT Timothy Arceri wrote: > > > > These need to be bitfields for use with gallium. > > --- > >  src/compiler/glsl/glsl_to_nir.cpp |  2 +- > >  src/compiler/shader_info.h| 12 +--- > >

Re: [Mesa-dev] [PATCH 00/16] loader: unify loader codepaths

On 11.10.2016 20:31, Emil Velikov wrote: Hi all, I've been 'threatening' to do this for a while, so here it is: Remove the three separate code paths that we have in the loader giving is a since cleanup and consistent/predictable runtime behaviour across the board. Not to mention some 100 lines

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #13 from Christian König --- John, please double check that you are actually correctly installing VDPAU. E.g. add something like "while(1);" into the VDPAU driver create function or something like this. vdp_imp_device_create_x11() wo

Re: [Mesa-dev] [PATCH] gm107/ir: fix bit offset of tex lod setting for indirect texturing

On 10/18/2016 06:22 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107

Re: [Mesa-dev] [PATCH] st/va: set default rt formats when calling vaCreateConfig

Am 17.10.2016 um 21:40 schrieb Julien Isorce: On Monday, 17 October 2016, Mark Thompson > wrote: On 17/10/16 17:33, Julien Isorce wrote: > As specified in va.h, default value should be set on attributes > not present in the input list. > > Signed-off

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #24 from Marek Olšák --- Hm. Probably none. The patch looks good. BTW, the patch won't apply on master, because the fence_finish function is slightly different there. -- You are receiving this mail because: You are the QA Contact f

Re: [Mesa-dev] [PATCH 06/15] ralloc: add a linear allocator as a child node of ralloc

Reviewed-by: Nicolai Hähnle On 17.10.2016 19:50, Marek Olšák wrote: From: Marek Olšák v2: remove goto, cosmetic changes Tested-by: Edmondo Tommasina (v1) --- src/util/ralloc.c | 353 ++ src/util/ralloc.h | 84 - 2 files chang

Re: [Mesa-dev] [PATCH shader-db 2/2] si-report.py: print more regressed and bad shaders

Both are: Reviewed-by: Nicolai Hähnle On 17.10.2016 22:03, Marek Olšák wrote: From: Marek Olšák --- si-report.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/si-report.py b/si-report.py index 144a229..620b3bd 100755 --- a/si-report.py +++ b/si-report.py @@ -535

Re: [Mesa-dev] [PATCH] gallium/tgsi: add missing #include

Reviewed-by: Nicolai Hähnle On 17.10.2016 15:40, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_util.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.h b/src/gallium/auxiliary/tgsi/tgsi_util.h index ca07bfd..83a930b 10064

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't there be code allows it if the user space doesn't set baseline? I don't know how in gstreamer as it seems to try to use b-frames if you use other than baseline which doesn

Re: [Mesa-dev] [PATCH 01/14] glsl_to_tgsi: use array_id for temp arrays instead of hacking high bits

On 17.10.2016 15:39, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 31 ++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [PATCH 04/14] glsl_to_tgsi: reduce the size of st_dst_reg and st_src_reg

On 17.10.2016 15:39, Marek Olšák wrote: From: Marek Olšák I noticed that glsl_to_tgsi_instruction is too huge. sizeof(glsl_to_tgsi_instruction): 752 -> 464 (-38%) --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 71 +- 1 file changed, 40 insertions(+), 31 deletions

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

Hi, On 18.10.2016 01:07, Jan Ziak wrote: This patch replaces the ir_variable_refcount_entry's linked-list with an array-list. The array-list has local storage which does not require ANY additional allocations if the list has small number of elements. The size of this storage is configurable for

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

Am 18.10.2016 um 11:19 schrieb Andy Furniss: boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't there be code allows it if the user space doesn't set baseline? I don't know how in gstreamer as it seems to try to use b-fra

Re: [Mesa-dev] [PATCH 14/14] mesa: remove gl_shader_compiler_options::EmitNoNoise

Patches 5-12, 14 are Reviewed-by: Nicolai Hähnle Those inline-explosion tests have been bugging me as well, but realistically speaking, the compiler needs to be at least robust enough to just not blow up and instead refuse compilation before any work on proper subroutines. Cheers, Nicolai

Re: [Mesa-dev] [PATCH 6/6] radeonsi: rename prefixes from radeon to si

Makes sense as a cleanup. At some point it would make sense to look into sharing some stuff with radv instead. There's probably not a huge amount because of the NIR/TGSI split, but still. Patches 1 & 4: Acked-by: Nicolai Hähnle Patches 2, 3, 5, 6: Reviewed-by: Nicolai Hähnle On 17.10.2016

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

Christian König wrote: Am 18.10.2016 um 11:19 schrieb Andy Furniss: boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't there be code allows it if the user space doesn't set baseline? I don't know how in gstreamer as it s

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #14 from John --- > John, please double check that you are actually correctly installing VDPAU. > E.g. add something like "while(1);" into the VDPAU driver create function or > something like this. vdp_imp_device_create_x11() would b

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #25 from Suzuki, Shinji --- Thank you for your comments. Patches attached here by me are against 11.2. I'll base on maser when posting diff to the mailing list. -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [PATCH] st/va: set default rt formats when calling vaCreateConfig

Hi Christian, I pushed it before already. I can try to add a git notes if you want. In any case thx for the review. Cheers Julien On 18 October 2016 at 10:09, Christian König wrote: > Am 17.10.2016 um 21:40 schrieb Julien Isorce: > > > > On Monday, 17 October 2016, Mark Thompson wrote: > >>

Re: [Mesa-dev] [PATCH] gm107/ir: fix texturing with indirect samplers

On 10/18/2016 10:50 AM, Samuel Pitoiset wrote: On 10/18/2016 05:53 AM, Ilia Mirkin wrote: The indirect handle has to come right after the coordinates, so if there was a sample/bias/depth compare/offset, everything would end up being shifted by one argument position. Signed-off-by: Ilia Mirk

Re: [Mesa-dev] [PATCH] gm107/ir: fix texturing with indirect samplers

On 10/18/2016 12:33 PM, Samuel Pitoiset wrote: On 10/18/2016 10:50 AM, Samuel Pitoiset wrote: On 10/18/2016 05:53 AM, Ilia Mirkin wrote: The indirect handle has to come right after the coordinates, so if there was a sample/bias/depth compare/offset, everything would end up being shifted b

[Mesa-dev] [Bug 98275] Segmentation fault when using VAAPI acceleration in VLC after installing oibaf's optimized drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98275 --- Comment #4 from Andy Furniss --- (In reply to lesserbrute from comment #0) > libva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/gallium_drv_video.so If obiaf uses recent mesa then the driver name was changed to radeonsi_drv_video.so.

[Mesa-dev] [Bug 98275] Segmentation fault when using VAAPI acceleration in VLC after installing oibaf's optimized drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98275 --- Comment #5 from Andy Furniss --- Another random observation = If you are only concerned with decode/display/deinterlace it's currently best to use vdpau anyway. There are bugs with vaapi that don't affect vdpau. -- You are receiving this m

[Mesa-dev] [PATCH] glsl: Indirect array indexing on non-last SSBO member must fail compilation

After the changes in comit 5b2675093e863a52, we moved this check to the linker, but the spec expects this to be checked at compile-time. There are dEQP tests that expect an error at compile time and the spec seems to confirm that expectation: "Except for the last declared member of a shader storag

[Mesa-dev] [Bug 98132] #version 300 es compute shaders should not be possible

https://bugs.freedesktop.org/show_bug.cgi?id=98132 --- Comment #3 from Iago Toral --- (In reply to Iago Toral from comment #2) > I have sent a couple of patches for review that fix these tests: > > https://lists.freedesktop.org/archives/mesa-dev/2016-October/131942.html This patch has been revi

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

On Tue Oct 18 09:29:59 UTC 2016, Eero Tamminen wrote: > On 18.10.2016 01:07, Jan Ziak wrote: >> - The total number of executed instructions goes down from 64.184 to 63.797 >> giga-instructions when Mesa is compiled with "gcc -O0 ..." > >Please don't do performance related decisions based on data

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

On 18.10.2016 15:07, Jan Ziak wrote: On Tue Oct 18 09:29:59 UTC 2016, Eero Tamminen wrote: On 18.10.2016 01:07, Jan Ziak wrote: - The total number of executed instructions goes down from 64.184 to 63.797 giga-instructions when Mesa is compiled with "gcc -O0 ..." Please don't do performance

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

On Tue, Oct 18, 2016 at 3:12 PM, Nicolai Hähnle wrote: > On 18.10.2016 15:07, Jan Ziak wrote: >> >> On Tue Oct 18 09:29:59 UTC 2016, Eero Tamminen wrote: >>> >>> On 18.10.2016 01:07, Jan Ziak wrote: - The total number of executed instructions goes down from 64.184 to 63.797 g

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #16 from John --- I actually had to use -vo vdpau when I tried against mesa 11.0 (somehow mpv didn't work with ogl-hq on that version) so I know it is problematic. But the bug you link is still interesting to me, as I was wondering w

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #15 from Andy Furniss --- (In reply to John from comment #10) > Correct, I have an mpv config with: > > hwdec=vdpau > hwdec-codecs=all > vo=opengl-hq > > The rest shouldn't matter I believe. If your mpv is not too old then there is

Re: [Mesa-dev] [PATCH] gallivm: Use native packs and unpacks for the lerps

On 18/10/16 02:38, srol...@vmware.com wrote: From: Roland Scheidegger For the texturing packs, things looked pretty terrible. For every lerp, we were repacking the values, and while those look sort of cheap with 128bit, with 256bit we end up with 2 of them instead of just 1 but worse, plus 2 ex

[Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

This patch replaces the ir_variable_refcount_entry's linked-list with an array-list. The array-list has local storage which does not require ANY additional allocations if the list has small number of elements. The size of this storage is configurable for each variable. Benchmark results for "./ru

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

On 17 October 2016 at 23:07, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > - exec_list assign_list; > + arraylist assign_list; > Just an FYI - when people started using C++ for glsl there was an agreement that templating is not to be used. Not sure if it still holds true, nowadays. Emil __

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #17 from Alex Deucher --- amdgpu does not support UVD or VCE on SI parts yet. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #18 from John --- > amdgpu does not support UVD or VCE on SI parts yet. oh, I should have verified in dmesg. Sorry about that. What should I try next? -- You are receiving this mail because: You are the assignee for the bug. You ar

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

On Tue, Oct 18, 2016 at 3:32 PM, Emil Velikov wrote: > On 17 October 2016 at 23:07, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > >> - exec_list assign_list; >> + arraylist assign_list; >> > Just an FYI - when people started using C++ for glsl there was an > agreement that templating is not to

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

Andy Furniss wrote: Christian König wrote: Am 18.10.2016 um 11:19 schrieb Andy Furniss: boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't there be code allows it if the user space doesn't set baseline? I don't know how

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

Hi Michael, thanks for the suggestions about code formatting. I formatted the whole fast_list.h file in the Netbeans editor and uploaded a new revision of the patch. Jan On Tue, Oct 18, 2016 at 1:42 PM, Michael Schellenberger Costa wrote: > Hi Jan, > > On 18.10.2016 00:07, Jan Ziak wrote: >> >>

[Mesa-dev] [PATCH] configure.ac: don't require DRM and GBM for surfaceless egl platform

From: Deepak Sharma This allows building radeonsi driver for surfaceless platform. If we get any other requirements, we'll fix them in the function. Removing the function isn't a solution. v2: cosmetic changes - Marek Signed-off-by: Deepak Sharma (v1) Signed-off-by: Marek Olšák --- configure

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

Hi, On 18.10.2016 16:25, Jan Ziak wrote: On Tue, Oct 18, 2016 at 3:12 PM, Nicolai Hähnle wrote: On 18.10.2016 15:07, Jan Ziak wrote: On Tue Oct 18 09:29:59 UTC 2016, Eero Tamminen wrote: On 18.10.2016 01:07, Jan Ziak wrote: - The total number of executed instructions goes down from 64.184 t

[Mesa-dev] [Bug 98308] llvmpipe crashes with glxgears

https://bugs.freedesktop.org/show_bug.cgi?id=98308 Bug ID: 98308 Summary: llvmpipe crashes with glxgears Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority:

Re: [Mesa-dev] [PATCH] configure.ac: don't require DRM and GBM for surfaceless egl platform

On 17 October 2016 at 19:07, Marek Olšák wrote: > On Mon, Oct 17, 2016 at 7:10 PM, Emil Velikov > wrote: >> On 17 October 2016 at 17:47, Marek Olšák wrote: >>> From: Deepak Sharma >>> >>> This allows building radeonsi driver for surfaceless platform. >>> >>> Signed-off-by: Deepak Sharma >>> S

Re: [Mesa-dev] [PATCH v3 25/25] configure.ac: Add required LLVM versions to the top

On 17 October 2016 at 08:56, Michel Dänzer wrote: > On 14/10/16 07:02 PM, Emil Velikov wrote: >> On 14 October 2016 at 09:45, Michel Dänzer wrote: >>> On 14/10/16 05:14 PM, Emil Velikov wrote: On 14 October 2016 at 01:45, Michel Dänzer wrote: > On 13/10/16 07:14 PM, Emil Velikov wrote:

[Mesa-dev] [Bug 98310] GLES context returned by OpenGL API

https://bugs.freedesktop.org/show_bug.cgi?id=98310 Bug ID: 98310 Summary: GLES context returned by OpenGL API Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: major Priori

[Mesa-dev] [Bug 98310] GLES context returned by OpenGL API

https://bugs.freedesktop.org/show_bug.cgi?id=98310 ajax at nwnk dot net changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEW

Re: [Mesa-dev] [PATCH 07/25] mesa/i965: eliminate gl_tess_ctrl_program and use new shared shader_info

I want to make a few comments on how this series is structured. This is not the way I would have done it and I think the way you structured it makes it substantially less rebasable than it could be and a bit harder to review. The way *I* would have done this would be something like the following:

[Mesa-dev] [Bug 98310] GLES context returned by OpenGL API

https://bugs.freedesktop.org/show_bug.cgi?id=98310 --- Comment #2 from Chad Versace --- Related bug on the real libepoxy bugtracker: https://github.com/anholt/libepoxy/issues/25 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH 07/25] mesa/i965: eliminate gl_tess_ctrl_program and use new shared shader_info

On Mon, Oct 17, 2016 at 11:12 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > --- > src/mesa/drivers/dri/i965/brw_context.h | 6 ++--- > src/mesa/drivers/dri/i965/brw_draw.c | 2 +- > src/mesa/drivers/dri/i965/brw_program.c | 2 +- > src/mesa/driver

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

On 18 October 2016 at 00:58, Jonathan Gray wrote: > On Mon, Oct 17, 2016 at 05:34:02PM +0100, Emil Velikov wrote: >> On 17 October 2016 at 16:39, Eric Engestrom >> wrote: >> > On Monday, 2016-10-17 22:53:20 +1100, Jonathan Gray wrote: >> >> On Mon, Oct 17, 2016 at 12:39:11PM +0100, Emil Velikov

[Mesa-dev] [Bug 92198] eglCreateWindowSurface ERROR

https://bugs.freedesktop.org/show_bug.cgi?id=92198 ajax at nwnk dot net changed: What|Removed |Added Product|epoxy |Mesa QA Contact|airl...@f

Re: [Mesa-dev] [PATCH 07/25] mesa/i965: eliminate gl_tess_ctrl_program and use new shared shader_info

On Tue, Oct 18, 2016 at 8:14 AM, Jason Ekstrand wrote: > I want to make a few comments on how this series is structured. This is > not the way I would have done it and I think the way you structured it > makes it substantially less rebasable than it could be and a bit harder to > review. The wa

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #19 from Christian König --- (In reply to John from comment #18) > What should I try next? Installing an older kernel, see if that works with 12.0 mesa. If yes we have narrowed it down to the kernel, if not we need to stick a bit mo

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

Am 18.10.2016 um 15:42 schrieb Andy Furniss: Andy Furniss wrote: Christian König wrote: Am 18.10.2016 um 11:19 schrieb Andy Furniss: boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't there be code allows it if the user

[Mesa-dev] [Bug 92198] eglCreateWindowSurface ERROR

https://bugs.freedesktop.org/show_bug.cgi?id=92198 Emil Velikov changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

Re: [Mesa-dev] [PATCH 10/25] mesa/nir/radv/anv: add shader_info param to nir_shader builder

On Mon, Oct 17, 2016 at 11:12 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > And pass in a pointer to the shader info in gl_program for ARB programs. > --- > src/amd/vulkan/radv_meta_blit.c | 12 > src/amd/vulkan/radv_meta_blit2d.c | 12

Re: [Mesa-dev] [PATCH v2 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

On 18 October 2016 at 09:49, Nicolai Hähnle wrote: > On 14.10.2016 20:21, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Currently not everyone has libudev and with follow-up patches we'll >> completely remove the divergent codepaths. >> >> Use the libdrm drm device API to construct the requi

Re: [Mesa-dev] [PATCH 00/16] loader: unify loader codepaths

On 18 October 2016 at 09:57, Nicolai Hähnle wrote: > On 11.10.2016 20:31, Emil Velikov wrote: >> >> Hi all, >> >> I've been 'threatening' to do this for a while, so here it is: >> >> Remove the three separate code paths that we have in the loader giving >> is a since cleanup and consistent/predict

[Mesa-dev] [PATCH] st/glsl_to_tgsi: sort input and output decls by TGSI index

From: Nicolai Hähnle Fixes a regression introduced by commit 777dcf81b. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98307 -- Using std::sort here is quite a bit C++-ier than most parts of Mesa. I used it because the standard C library is being its usual lame self. If people think usin

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

On Tue, Oct 18, 2016 at 3:55 PM, Eero Tamminen wrote: > Hi, > > On 18.10.2016 16:25, Jan Ziak wrote: >> >> On Tue, Oct 18, 2016 at 3:12 PM, Nicolai Hähnle >> wrote: >>> >>> On 18.10.2016 15:07, Jan Ziak wrote: On Tue Oct 18 09:29:59 UTC 2016, Eero Tamminen wrote: > > On 18.10.20

[Mesa-dev] [PATCH] radeonsi: eliminate trivial constant VS outputs

From: Marek Olšák These constant value VS PARAM exports: - 0,0,0,0 - 0,0,0,1 - 1,1,1,0 - 1,1,1,1 can be loaded into PS inputs using the DEFAULT_VAL field, and the VS exports can be removed from the IR to save export & parameter memory. After LLVM optimizations, analyze the IR to see which export

Re: [Mesa-dev] [PATCH 6/6] radeonsi: rename prefixes from radeon to si

On 17 October 2016 at 14:44, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_pipe.c | 2 +- > src/gallium/drivers/radeonsi/si_shader.c | 96 ++--- > src/gallium/drivers/radeonsi/si_shader_internal.h | 70 +- > .../driver

Re: [Mesa-dev] [PATCH 6/6] radeonsi: rename prefixes from radeon to si

On Tue, Oct 18, 2016 at 6:28 PM, Emil Velikov wrote: > On 17 October 2016 at 14:44, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_pipe.c | 2 +- >> src/gallium/drivers/radeonsi/si_shader.c | 96 ++--- >> src/gallium/drivers

[Mesa-dev] [PATCH] svga: minor code improvements in svga_validate_pipe_sampler_view()

Use the 'texture' local var in more places. Rename 'pFormat' to 'viewFormat'. --- src/gallium/drivers/svga/svga_state_sampler.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/svga/svga_state_sampler.c b/src/gallium/drivers/svga/svga_state_

[Mesa-dev] [PATCH] egl/surfaceless: Fix segfault in eglSwapBuffers

Since commit 63c5d5c6c46c8472ee7a8241a0f80f13d79cb8cd, the surfaceless platform has allowed creation of pbuffer surfaces. But the vtable entry for eglSwapBuffers has remained NULL. Discovered by running a little pbuffer test. Cc: Gurchetan Singh --- src/egl/drivers/dri2/platform_surfaceless.c |

Re: [Mesa-dev] [PATCH v2 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

On 18.10.2016 18:01, Emil Velikov wrote: On 18 October 2016 at 09:49, Nicolai Hähnle wrote: On 14.10.2016 20:21, Emil Velikov wrote: From: Emil Velikov Currently not everyone has libudev and with follow-up patches we'll completely remove the divergent codepaths. Use the libdrm drm device A

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_tgsi: fix block copies of arrays of structs

For the series: Reviewed-by: Marek Olšák Marek On Mon, Oct 17, 2016 at 7:25 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Use a full writemask in this case. This is relevant e.g. when a function > has an inout argument which is an array of structs. > --- > src/mesa/state_tracker/st_gl

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

> Regarding C++ templates, the compiler doesn't use them. If u_vector > (Dave Airlie?) provides the same functionality as your array, I > suggest we use u_vector instead. Let me repeat what you just wrote, because it is unbelievable: You are advising the use of non-templated collection types in C+

Re: [Mesa-dev] [PATCH 08/11] anv: move to using vk_alloc helpers.

Hi Dave, On 17 October 2016 at 03:07, Dave Airlie wrote: > From: Dave Airlie > > This moves all the alloc/free in anv to the generic helpers. > > Signed-off-by: Dave Airlie > --- > src/intel/vulkan/anv_batch_chain.c| 40 +++--- > src/intel/vulkan/anv_cmd_buffer.c

Re: [Mesa-dev] [PATCH 3/3] [Bug 38970] [bisected]piglit glx/glx-pixmap-multi failed

On 09/29/2016 01:55 PM, Anutex wrote: > I tried to debug this issue with changing the condition to check only bad > magic and Error. > And the test passed. > > Though i am not sure what is the correct behaviour if we are in this > condition. > May be we should make some other condition if the H

Re: [Mesa-dev] [PATCH 11/11] anv: drop pointless struct decl.

On 17 October 2016 at 03:07, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Seems like a typo from the development stage - anv_wsi_inter_a_face 10 and 11 are independent so feel free to land whenever possible. Reviewed-by: Emil Velikov -Emil

Re: [Mesa-dev] [PATCH 01/22] radv/anv/wsi: drop uneeded parameter

Typo in the summary - s/uneeded/unneeded/ -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 07/25] mesa/i965: eliminate gl_tess_ctrl_program and use new shared shader_info

On Tue, Oct 18, 2016 at 8:28 AM, Jason Ekstrand wrote: > On Tue, Oct 18, 2016 at 8:14 AM, Jason Ekstrand > wrote: > >> I want to make a few comments on how this series is structured. This is >> not the way I would have done it and I think the way you structured it >> makes it substantially less

Re: [Mesa-dev] [PATCH 07/22] anv/wsi/x11: abstract WSI interface from internals.

On 17 October 2016 at 05:24, Dave Airlie wrote: > From: Dave Airlie > > This allows the API and the internals to be split, and the > internals shared. > --- > src/intel/vulkan/anv_wsi_x11.c | 33 - > 1 file changed, 24 insertions(+), 9 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 07/25] mesa/i965: eliminate gl_tess_ctrl_program and use new shared shader_info

On Tuesday, October 18, 2016 8:28:02 AM PDT Jason Ekstrand wrote: > On Tue, Oct 18, 2016 at 8:14 AM, Jason Ekstrand > wrote: > > > I want to make a few comments on how this series is structured. This is > > not the way I would have done it and I think the way you structured it > > makes it subst

Re: [Mesa-dev] [PATCH] egl/surfaceless: Fix segfault in eglSwapBuffers

On Tue, Oct 18, 2016 at 9:43 AM, Chad Versace wrote: > Since commit 63c5d5c6c46c8472ee7a8241a0f80f13d79cb8cd, the surfaceless > platform has allowed creation of pbuffer surfaces. But the vtable entry > for eglSwapBuffers has remained NULL. > > Discovered by running a little pbuffer test. > > Cc: G

[Mesa-dev] [PATCH] st/mesa: disable alpha-test, alpha-to-coverage, alpha-to-one for integer FBs

From: Marek Olšák v2: rebased --- src/mesa/state_tracker/st_atom_blend.c | 3 ++- src/mesa/state_tracker/st_atom_depth.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_blend.c b/src/mesa/state_tracker/st_atom_blend.c index 76d6a644..b8d65b

Re: [Mesa-dev] [PATCH] st/mesa: disable alpha-test, alpha-to-coverage, alpha-to-one for integer FBs

Reviewed-by: Brian Paul On 10/18/2016 11:48 AM, Marek Olšák wrote: From: Marek Olšák v2: rebased --- src/mesa/state_tracker/st_atom_blend.c | 3 ++- src/mesa/state_tracker/st_atom_depth.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_a

[Mesa-dev] [PATCH] nv50/ir: silent TGSI_PROPERTY_FS_DEPTH_LAYOUT

Found that information message while replaying a trace from Metro 2033 Redux. Mark that property as useless for now. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codege

Re: [Mesa-dev] [PATCH] nv50/ir: silent TGSI_PROPERTY_FS_DEPTH_LAYOUT

Reviewed-by: Ilia Mirkin This comes into play with Zcull, I think. But since we don't do Zcull yet, wtvr. I had a patch to convert it into a layout(early_fragment_tests) effectively if the various settings matched, but ultimately it didn't seem worthwhile. -ilia On Tue, Oct 18, 2016 at 1:59

Re: [Mesa-dev] [PATCH] nv50/ir: Split 64-bit integer MAD/MUL operations

Hello Ian, Since I am working on a direct SPIR-V to NV50 IR translator, ultimately to be used for OpenCL kernels, I will still need the patch for that work. (I even wrote that patch because I needed it when handling 64-bit addresses. :-) ) But thanks for the heads-up! Pierre On 02:07 pm - Oct 1

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

On Tue, Oct 18, 2016 at 7:12 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: >> Regarding C++ templates, the compiler doesn't use them. If u_vector >> (Dave Airlie?) provides the same functionality as your array, I >> suggest we use u_vector instead. > > Let me repeat what you just wrote, because it

Re: [Mesa-dev] [PATCH] svga: minor code improvements in svga_validate_pipe_sampler_view()

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, October 18, 2016 9:36 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: minor code improvements in svga_validate_pipe_sampler_view() Use the 'texture' local var in

Re: [Mesa-dev] [PATCH 18/22] anv: move common wsi code to x11/wayland common files.

On 17 October 2016 at 05:24, Dave Airlie wrote: > diff --git a/src/intel/vulkan/Makefile.sources > b/src/intel/vulkan/Makefile.sources > index 85df8a5..bd3afc0 100644 > --- a/src/intel/vulkan/Makefile.sources > +++ b/src/intel/vulkan/Makefile.sources > @@ -43,14 +43,17 @@ VULKAN_FILES := \ >

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

Perf stat results for shader-db: This is measured on an AMD Kaveri CPU. gcc-6.2.0 -fno-omit-frame-pointer -g -O2 Unpatched: $ cd shader-db $ ../run-upstream perfstat-u --repeat=5 -- ./run -1 shaders >/dev/null Performance counter stats for './run -1 shaders' (5 runs): 13689.962374

Re: [Mesa-dev] [PATCH 04/11] util: move min/max/clamp macros to util macros.h

THANK YOU! I've been wanting to see this happen for a long time. On Sun, Oct 16, 2016 at 7:07 PM, Dave Airlie wrote: > From: Dave Airlie > > Although the vulkan drivers include mesa macros.h, for > radv I'd like to move away from that. > > Signed-off-by: Dave Airlie > --- > src/mesa/main

Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

On Tue, Oct 18, 2016 at 8:04 PM, Marek Olšák wrote: > On Tue, Oct 18, 2016 at 7:12 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> > wrote: > >> Regarding C++ templates, the compiler doesn't use them. If u_vector > >> (Dave Airlie?) provides the same functionality as your array, I > >> suggest we use u_v

Re: [Mesa-dev] [PATCH 07/11] vulkan: add vk_alloc.h shared allocation inlines.

We already talked on IRC about putting vk_alloc.h in src/util. Assuming that's done, the series is Acked-by: Jason Ekstrand Please make sure you do a fairly complete (fedora config?) build test. I don't want those MIN/MAX macros to cause problems. --Jason On Sun, Oct 16, 2016 at 7:07 PM, Dav

Re: [Mesa-dev] [PATCH 20/22] anv: move to using shared wsi code

Hi Dave, Thanks for doing this. It'll be great to get an Ack from the Intel devs, on the idea. Afaics with 22/22 in place you can drop the vk_alloc2/vk_free2 functions since they are no longer used. Just an extra (small) suggestion below: On 17 October 2016 at 05:24, Dave Airlie wrote: > del

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: sort input and output decls by TGSI index

Reviewed-by: Marek Olšák Marek On Tue, Oct 18, 2016 at 6:06 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes a regression introduced by commit 777dcf81b. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98307 > -- > Using std::sort here is quite a bit C++-ier than most part

Re: [Mesa-dev] [PATCH 11/25] mesa/i965/i915/r200: eliminate gl_vertex_program

I'd like to see two tiny changes: 1. A comment for the IsPositionInvariant field that it can only be true for vertex programs. 2. An assertion or two like assert(p->Target == GL_VERTEX_PROGRAM_ARB || !p->IsPositionInvariant); in reasonable places. I'm thinking: - Where it

[Mesa-dev] [Bug 98308] llvmpipe crashes with glxgears

https://bugs.freedesktop.org/show_bug.cgi?id=98308 Marc Dietrich changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 98308] llvmpipe crashes with glxgears

https://bugs.freedesktop.org/show_bug.cgi?id=98308 --- Comment #2 from Roland Scheidegger --- I'd be interested to know though why it fails, I don't think LTO should cause such failures? Seems like it might be related to the threads created by llvmpipe but I don't really see how. -- You are rec

  1   2   >