[Mesa-dev] [PATCHv2 0/2] scons 2.5.0 support

Again, the main patch is the second, the first is just a cleanup of EOL whitespace. Changes over v1: * rebased on current master; * documented EOL whitespace cleanup shell command; * direct link to Bugzilla, as suggested by Emil; * Cc: the second patch to mesa-stable, again as suggested by Emil.

[Mesa-dev] [PATCHv2 2/2] scons: support 2.5.0

The get_implicit_deps changed in SCons 2.5, expecting a callable rather than a path as third argument. Detect the SCons versions and set the argument appropriately to support both 2.5 and earlier versions. This closes #95211. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95211 Signed-off

[Mesa-dev] [PATCHv2 1/2] scons: whitespace cleanup

This text transformation was done automatically via the following shell command: $ find -name SCons\* -exec sed -i s/\\s\\+$// '{}' \; Signed-off-by: Giuseppe Bilotta --- SConstruct| 14 +++--- src/compiler/SConscript.glsl | 2 +- src/galliu

[Mesa-dev] [PATCH] glsl: handle implicit sized arrays in ssbo

From: Dave Airlie The current code disallows unsized arrays except at the end of an SSBO but it is a bit overzealous in doing so. struct a { int b[]; int f[4]; }; is valid as long as b is implicitly sized within the shader, i.e. it is accessed only by integer indices. I've subm

Re: [Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

On Tue, May 24, 2016 at 8:42 AM, wrote: > From: Mathias Fröhlich > > Replaces a loop that iterates all lights and test > which of them is enabled by a loop only iterating over > the bits set in the enabled bitmask. This takes the code from something very obvious and easy to follow to something

[Mesa-dev] pthread-stubs really now needed to build on linux?

Linux from scratch doesn't use these anymore (seds requirement out of libdrm build) Today I see I can't now build Mesa on linux without them, is this intentional? I normally build OK - but with Python 2, now Python 3 is needed this is the first build with that - just saying in case it's relevant

Re: [Mesa-dev] [PATCH 2/2] tgsi: print TGSI_PROPERTY_NEXT_SHADER value as string, not an integer

For the series: Reviewed-by: Marek Olšák Marek On Wed, May 25, 2016 at 5:05 AM, Ilia Mirkin wrote: > Series is > > Reviewed-by: Ilia Mirkin > > On Tue, May 24, 2016 at 8:43 PM, Brian Paul wrote: >> Print "GEOM" instead of "2", for example. >> >> v2: also update the text parsing code, per Ili

Re: [Mesa-dev] [PATCH] glsl: split out libstandalone

On Tue, May 24, 2016 at 6:39 PM, Rob Clark wrote: > From: Rob Clark > > Split standalone glsl_compiler into a libstandalone.la and a thin > main.cpp. This way drivers can re-use the glsl standalone frontend in > their own standalone compilers. > > Signed-off-by: Rob Clark > --- > v2: fix scons

[Mesa-dev] [PATCH] i965/fs: take into account doubles when emitting system values

Fixes the following cts test: GL42-CTS.vertex_attrib_64bit.limits_test --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index 012492c..

Re: [Mesa-dev] [PATCH] glsl: split out libstandalone

On Wed, May 25, 2016 at 8:23 AM, Rob Herring wrote: > On Tue, May 24, 2016 at 6:39 PM, Rob Clark wrote: >> From: Rob Clark >> >> Split standalone glsl_compiler into a libstandalone.la and a thin >> main.cpp. This way drivers can re-use the glsl standalone frontend in >> their own standalone com

Re: [Mesa-dev] pthread-stubs really now needed to build on linux?

HI Andy, Thanks for brining these up. On 25 May 2016 at 12:20, Andy Furniss wrote: > Linux from scratch doesn't use these anymore (seds requirement out of > libdrm build) > > Today I see I can't now build Mesa on linux without them, is this > intentional? > The package (currently) expands to jus

Re: [Mesa-dev] [PATCH] glsl: split out libstandalone

On 25 May 2016 at 13:43, Rob Clark wrote: > On Wed, May 25, 2016 at 8:23 AM, Rob Herring wrote: >> On Tue, May 24, 2016 at 6:39 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Split standalone glsl_compiler into a libstandalone.la and a thin >>> main.cpp. This way drivers can re-use the glsl

[Mesa-dev] [Bug 96176] Cannot build non-intel drivers without python3.

https://bugs.freedesktop.org/show_bug.cgi?id=96176 --- Comment #1 from Emil Velikov --- I wouldn't call it regression but intentional change ;-) The long term goal is to port the python2 scripts to python3. Thus adding a list of generated sources and/or other heuristics in configure is fragile a

[Mesa-dev] [Bug 95159] Cannot build EGL without x11 headers after interop patchset

https://bugs.freedesktop.org/show_bug.cgi?id=95159 Emil Velikov changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 3/6] spriv: Mark default cases unreachable().

Typo in the commit message: s/spriv/spirv/ On Tue, May 24, 2016 at 01:23:07PM -0700, Matt Turner wrote: > --- > src/compiler/spirv/vtn_alu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/compiler/spirv/vtn_alu.c b/src/compiler/spirv/vtn_alu.c > index 8b9a63c..5730ca4 100644 > --

Re: [Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

On May 25, 2016 6:06 AM, "Erik Faye-Lund" wrote: > > On Tue, May 24, 2016 at 8:42 AM, wrote: > > From: Mathias Fröhlich > > > > Replaces a loop that iterates all lights and test > > which of them is enabled by a loop only iterating over > > the bits set in the enabled bitmask. > > This takes th

[Mesa-dev] [PATCH 1/2] mesa: Allow to invalidate external textures when (re-)binding

To comply with the requirement from the GL_OES_EGL_image_external extension that a call to glBindTexture guarantees that all further sampling will return values that correspond to the values in the external texture at or after the time that glBindTexture was called, do not bail out early from mesa_

[Mesa-dev] [PATCH 2/2] st/mesa: Invalidate external textures when (re-)binding

Use the invalidate_resource pipe callback to invalidate external textures when they are (re-)bound. This is needed to comply with the requirement from the GL_OES_EGL_image_external extension that a call to glBindTexture guarantees that all further sampling will return values that correspond to the

[Mesa-dev] [PATCH] st/dri: fix winsys handle stride calculation for block formats

This fixes the stride calculation for pipe formats with a block width larger than one. Signed-off-by: Philipp Zabel --- src/gallium/state_trackers/dri/dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dr

Re: [Mesa-dev] [PATCH] glsl: handle implicit sized arrays in ssbo

On Wed, 2016-05-25 at 17:39 +1000, Dave Airlie wrote: > From: Dave Airlie > > The current code disallows unsized arrays except at the end of > an SSBO but it is a bit overzealous in doing so. > > struct a { > int b[]; > int f[4]; > }; > > is valid as long as b is implicitly sized wi

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Invalidate external textures when (re-)binding

Iirc invalidate_resource is to allow backend to discard the contents... On May 25, 2016 9:18 AM, "Philipp Zabel" wrote: > Use the invalidate_resource pipe callback to invalidate external > textures when they are (re-)bound. This is needed to comply with the > requirement from the GL_OES_EGL_image

Re: [Mesa-dev] [PATCH] glsl: split out libstandalone

On Wed, May 25, 2016 at 8:51 AM, Emil Velikov wrote: > On 25 May 2016 at 13:43, Rob Clark wrote: >> On Wed, May 25, 2016 at 8:23 AM, Rob Herring wrote: >>> On Tue, May 24, 2016 at 6:39 PM, Rob Clark wrote: From: Rob Clark Split standalone glsl_compiler into a libstandalone.la an

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Invalidate external textures when (re-)binding

Am Mittwoch, den 25.05.2016, 09:23 -0400 schrieb Ilia Mirkin: > Iirc invalidate_resource is to allow backend to discard the contents... Thanks, I didn't know that. So this would need a new callback then? Specifically I want to discard a copy in tiled layout that was derived from a linear external

Re: [Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

Am Dienstag, den 10.05.2016, 17:35 +0200 schrieb Philipp Zabel: > To support the EGL_KHR_fence_sync extension on the DRM EGL platform, > add the DRI2 fence extension to the dri_core_extensions match table. > > Signed-off-by: Philipp Zabel Gentle ping. Is this about the right way to enable the EG

Re: [Mesa-dev] [PATCH 0/5] Resubmit: uninitialized warning fix + unit tests

Two weeks ping. As you can see on Ian email, he gave a Rb for patches 1,2,4. Added some minor comments on patch 3 (but granted the RB as far as I made those changes), and asked to add more unit tests (patch 5). When adding those unit tests, I detected a case where patch 2 was not properly raising

[Mesa-dev] [PATCH 2/3] radeon/llvm: Add helpers for loading and storing data from arrays.

--- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 51 +- 1 file changed, 41 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index 759c674..93bc307 100644 --- a/src/gal

[Mesa-dev] [PATCH] android: drop build of standalone glsl_compiler

From: Rob Clark It's only a tool for debugging the glsl compiler, and should not be installed. Signed-off-by: Rob Clark --- Untested, but should be correct.. src/compiler/Android.glsl.mk | 22 -- 1 file changed, 22 deletions(-) diff --git a/src/compiler/Android.glsl.mk b/

Re: [Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

On Wed, May 25, 2016 at 3:44 PM, Philipp Zabel wrote: > Am Dienstag, den 10.05.2016, 17:35 +0200 schrieb Philipp Zabel: >> To support the EGL_KHR_fence_sync extension on the DRM EGL platform, >> add the DRI2 fence extension to the dri_core_extensions match table. >> >> Signed-off-by: Philipp Zabel

Re: [Mesa-dev] [PATCH] android: drop build of standalone glsl_compiler

On Wed, May 25, 2016 at 9:01 AM, Rob Clark wrote: > From: Rob Clark > > It's only a tool for debugging the glsl compiler, and should not be > installed. > > Signed-off-by: Rob Clark > --- > Untested, but should be correct.. Thanks. I've tested the same change. Tested-by: Rob Herring _

Re: [Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

Am Mittwoch, den 25.05.2016, 16:01 +0200 schrieb Marek Olšák: > On Wed, May 25, 2016 at 3:44 PM, Philipp Zabel wrote: > > Am Dienstag, den 10.05.2016, 17:35 +0200 schrieb Philipp Zabel: > >> To support the EGL_KHR_fence_sync extension on the DRM EGL platform, > >> add the DRI2 fence extension to t

[Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

From: Christian König We support 5.1 for a while now. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_video.c b/src/gallium/drivers/radeon/radeon_video.c index da

[Mesa-dev] [PATCH 3/3] radeon/llvm: Use alloca instructions for larger arrays

We were storing arrays in vectors, which was leading to some really bad spill code for large arrays. allocas instructions are a better fit for arrays and LLVM optimizations are more geared toward dealing with allocas instead of vectors. For arrays that have 16 or less 32-bit elements, we will con

[Mesa-dev] [PATCH 1/3] radeon/llvm: Remove uses_temp_indirect_addressing() function

bld->indirect_files is never set, so this function always returns false. --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 24 +- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/rade

Re: [Mesa-dev] [PATCH 01/29] mesa: Add gl_point_attrib::CoordReplaceBits bitfield.

On 05/23/2016 11:41 PM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > The aim is to replace the CoordReplace array by > a bitfield. Until all drivers are converted, > establish the bitfield in paralell to the parallel > CoordReplace array. As a genera

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

On Wed, May 25, 2016 at 10:57 AM, Christian König wrote: > From: Christian König > > We support 5.1 for a while now. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher CC stable? > --- > src/gallium/drivers/radeon/radeon_video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [Mesa-dev] [PATCH 04/29] r200: convert r200 to use CoordsReplaceBits.

On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Switch over to use the CoordsReplaceBits bitmask. > > Signed-off-by: Mathias Fröhlich > --- > src/mesa/drivers/dri/r200/r200_state.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

On 25 May 2016 at 16:56, Alex Deucher wrote: > On Wed, May 25, 2016 at 10:57 AM, Christian König > wrote: >> From: Christian König >> >> We support 5.1 for a while now. >> >> Signed-off-by: Christian König > > Reviewed-by: Alex Deucher > > CC stable? > If the commit mentions the sha where this

[Mesa-dev] [PATCH 04/14] i965/blorp: Use prog data counters to guide sf/sbe setup

just as core upload logic does. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++- src/mesa/drivers/dri/i965/brw_blorp.h | 8 +++- src/mesa/drivers/dri/i965/gen6_blorp.c | 10 -- src/mesa/drivers/dri/i965/gen7_blorp.c | 10 -- src/mesa/driv

[Mesa-dev] [PATCH 05/14] i965/blorp: Use prog data counters to guide wm/ps setup

just as core upload logic does. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen6_blorp.c | 4 +++- src/mesa/drivers/dri/i965/gen7_blorp.c | 2 ++ src/mesa/drivers/dri/i965/gen8_blorp.c | 5 +++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] i965/fs: take into account doubles when emitting system values

On Wednesday, May 25, 2016 2:26:17 PM PDT Alejandro Piñeiro wrote: > Fixes the following cts test: > GL42-CTS.vertex_attrib_64bit.limits_test > --- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 13/14] i965: Do not flush texture and data port caches for clears

Clears don't sample or blend colors and therefore this is unnecessary. This was a difference between blorp and meta clears. This also drops the flushes for gen6_blorp_hiz_exec() which is used for depth clears and resolves. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.

[Mesa-dev] [PATCH 07/14] i965/urb: Allow blorp to record current settings

This makes it possible to skip urb re-configuration if the subsequent renders agree with the settings. Also allows blorp to allocate the maximun amount of vs entries available. Core upload logic already knows how to calculate this. Helps one synthetic benchmark. Signed-off-by: Topi Pohjolainen -

[Mesa-dev] [PATCH 08/14] i965/blorp: Fix the size requirement for vertex elements

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++- src/mesa/drivers/dri/i965/gen7_blorp.c | 38 ++ src/mesa/drivers/dri/i965/gen8_blorp.c | 2 +- 3 files changed, 28 insertions(+), 15 deletions(-) diff --git a/src/mesa/drivers/dr

[Mesa-dev] [PATCH 09/14] i965/fs: Provide compiler options using a flags argument

Signed-off-by: Topi Pohjolainen --- src/intel/vulkan/anv_pipeline.c | 6 -- src/mesa/drivers/dri/i965/brw_blorp.c | 5 ++--- src/mesa/drivers/dri/i965/brw_blorp.h | 3 +-- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 2 +- src/mesa/drivers/dri/i965/brw_blo

[Mesa-dev] [PATCH 10/14] i965/fs: Add support for repclear without color setup

Fast color clears and resolves ignore the payload. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 11 ++- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) d

[Mesa-dev] [PATCH 03/14] i965/blorp: Use core vertex buffer state setup

Also split the setup from the setup of vertex elements. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen6_blorp.c | 102 - 1 file changed, 36 insertions(+), 66 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/d

[Mesa-dev] [PATCH 11/14] i965/blorp: Ignore color setup in fast clears and resolves

Before: START B0 mov(4) g114<1>Fg2.3<8,2,4>F { align1 WE_all }; sendc(16) null<1>UW g114<8,8,1>F render RT write SIMD16/RepData LastRT Surface = 0 mlen 1 rlen 0 { align1 1H EOT }; END B0 After: START B0 sendc(16) null<1>UW g114<8,8,1>F render RT writ

[Mesa-dev] [PATCH 01/14] i965/draw: Expose vertex buffer state setup

Also change the interface to use start and end offsets. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_draw.h| 13 + src/mesa/drivers/dri/i965/brw_draw_upload.c | 42 - 2 files changed, 37 insertions(+), 18 deletions(-) diff --git a

[Mesa-dev] [PATCH 12/14] i965/blorp/gen7+: Skip disabling already disabled stages

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen7_blorp.c | 16 src/mesa/drivers/dri/i965/gen8_blorp.c | 12 2 files changed, 28 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen7_blorp.c b/src/mesa/drivers/dri/i965/gen7_blorp.c index 3a12bb

[Mesa-dev] [PATCH 02/14] i965/gen8: Fix the vertex buffer size

And refactor to use the same upload logic with earlier gens. On gen >= 8 one doesn't provide ending address but number of bytes available. This is relative to the given offset. Until now we programmed the full size of the buffer regardless of the used offset. Signed-off-by: Topi Pohjolainen ---

[Mesa-dev] [PATCH 14/14] i965/blorp: Disable vertex element swizzling

Without vertex elements originating directly from vertex fetcher are not passed to wm-state correctly. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen7_blorp.c | 11 +-- src/mesa/drivers/dri/i965/gen8_blorp.c | 11 +-- 2 files changed, 18 insertions(+), 4 deleti

[Mesa-dev] [PATCH 06/14] i965/blorp: Let program data tell if push constants are needed

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen6_blorp.c | 8 ++-- src/mesa/drivers/dri/i965/gen7_blorp.c | 16 +++- src/mesa/drivers/dri/i965/gen8_blorp.c | 26 ++ 3 files changed, 35 insertions(+), 15 deletions(-) diff --git a/src/mesa

Re: [Mesa-dev] [PATCH 10/29] mesa: Use bitmask/ffs to iterate enabled lights

On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Replaces loops that iterate all lights and test > which of them is enabled by a loop only iterating over > the bits set in the enabled bitmask. > > Signed-off-by: Mathias Fröhlich > --- > src/mesa/main/light.

Re: [Mesa-dev] [PATCH] android: drop build of standalone glsl_compiler

On 25 May 2016 at 15:01, Rob Clark wrote: > From: Rob Clark > > It's only a tool for debugging the glsl compiler, and should not be > installed. > > Signed-off-by: Rob Clark > --- > Untested, but should be correct.. > Yes it is. Acked-by: Emil Velikov -Emil ___

[Mesa-dev] i965/blorp: Preparing for flat inputs + small optimizations

First three clarify a little how vertex buffers are configured in the command stream. There is a subtle difference between gen8+ and earlier, and I thought it would be clearer to have it documented with bspec quotes. Next four drop some hardcoding in upload logic making the emitters to consult com

Re: [Mesa-dev] [PATCH] glsl: split out libstandalone

On 25 May 2016 at 00:39, Rob Clark wrote: > From: Rob Clark > > Split standalone glsl_compiler into a libstandalone.la and a thin > main.cpp. This way drivers can re-use the glsl standalone frontend in > their own standalone compilers. > > Signed-off-by: Rob Clark > --- > v2: fix scons build an

Re: [Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

On 05/25/2016 03:06 AM, Erik Faye-Lund wrote: > On Tue, May 24, 2016 at 8:42 AM, wrote: >> From: Mathias Fröhlich >> >> Replaces a loop that iterates all lights and test >> which of them is enabled by a loop only iterating over >> the bits set in the enabled bitmask. > > This takes the code fro

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

On Wed, May 25, 2016 at 12:08 PM, Emil Velikov wrote: > On 25 May 2016 at 16:56, Alex Deucher wrote: >> On Wed, May 25, 2016 at 10:57 AM, Christian König >> wrote: >>> From: Christian König >>> >>> We support 5.1 for a while now. >>> >>> Signed-off-by: Christian König >> >> Reviewed-by: Alex D

Re: [Mesa-dev] [PATCH 12/29] tnl: Use bitmask/ffs to iterate enabled lights

On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Replaces loops that iterate all lights and test > which of them is enabled by a loop only iterating over > the bits set in the enabled bitmask. > --- > src/mesa/tnl/t_vb_light.c| 2 +- > src/mesa/tnl/t_vb_

Re: [Mesa-dev] [PATCH 12/29] tnl: Use bitmask/ffs to iterate enabled lights

On Wed, May 25, 2016 at 12:17 PM, Ian Romanick wrote: > On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: >> From: Mathias Fröhlich >> >> Replaces loops that iterate all lights and test >> which of them is enabled by a loop only iterating over >> the bits set in the enabled bitmask. >> ---

[Mesa-dev] [PATCH] egl: Additional attribute validation for eglCreatePbufferSurface

eglCreatePbufferSurface should generate an EGL_BAD_MATCH error if: 1: The EGL_TEXTURE_FORMAT attribute is EGL_NO_TEXTURE and EGL_TEXTURE_TARGET is something other than EGL_NO_TEXTURE 2: EGL_TEXTURE_FORMAT is something other than EGL_NO_TEXTURE and EGL_TEXTURE_TARGET is EGL_NO_TEXTURE. This fixes t

Re: [Mesa-dev] [PATCH 05/29] i915: Convert i915 to use CoordsReplaceBits.

On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Switch over to use the CoordsReplaceBits bitmask. > > Signed-off-by: Mathias Fröhlich > --- > src/mesa/drivers/dri/i915/i915_state.c | 17 +++-- > 1 file changed, 7 insertions(+), 10 deletions(-)

Re: [Mesa-dev] [PATCH 00/29] Make more use of bitmasks

On 05/23/2016 11:41 PM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Hi all, > > following a series with performance improvements > for cpu/draw bound applications. This part makes > more use of the bitmask/ffs technique for iterating > a set of enabled items. The gains are not

[Mesa-dev] [PATCH] i965: Fix shadowing of 'height' parameter

From: Kristian Høgsberg Kristensen The nested declaration of 'height' shadows a parameter and uses uninitialized memory. Fix by renaming to 'plane_height' which also makes the code clearer. This would typically break the bo size computation, but we don't use that except when mmaping, and we don'

Re: [Mesa-dev] [PATCH] mesa: Add .gitignore entries for make check binaries

On Tue, May 24, 2016 at 11:02 PM, Matt Turner wrote: > On Tue, May 24, 2016 at 9:07 PM, Kristian Høgsberg wrote: >> From: Kristian Høgsberg Kristensen >> >> Signed-off-by: Kristian Høgsberg Kristensen >> --- >> src/compiler/.gitignore | 4 >> src/compiler/nir/tests/.gitignore

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

Christian König wrote: From: Christian König We support 5.1 for a while now. I know (well think) vdpau doesn't really mention 5.2 anywhere, but for ffmpeg I've been making this change for some time to say 5.2. Tonga can easily do 5.2, players don't seem to look at this field, but ffmpeg cli

Re: [Mesa-dev] [PATCH] i965: Fix shadowing of 'height' parameter

Yikes. Reviewed-by: Ian Romanick On 05/25/2016 09:33 AM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > The nested declaration of 'height' shadows a parameter and uses > uninitialized memory. Fix by renaming to 'plane_height' which also makes > the code clearer. > > This wo

Re: [Mesa-dev] [PATCH] i965: Fix shadowing of 'height' parameter

On Wed, May 25, 2016 at 09:33:30AM -0700, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > The nested declaration of 'height' shadows a parameter and uses > uninitialized memory. Fix by renaming to 'plane_height' which also makes > the code clearer. > > This would typically brea

Re: [Mesa-dev] [PATCH] swr: [rasterizer] Correctly select optimized primitive assembly.

Reviewed-by: Tim Rowley > On May 24, 2016, at 3:00 PM, Bruce Cherniak wrote: > > Indexed primitives were always using cut-aware primitive assembly, > whether primitive_restart was enabled or not. Correctly pass down > primitive_restart and select optimized PA when possible. > --- > src/gallium

Re: [Mesa-dev] [PATCH] i965: Fix shadowing of 'height' parameter

On 25 May 2016 at 17:33, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > The nested declaration of 'height' shadows a parameter and uses > uninitialized memory. Fix by renaming to 'plane_height' which also makes > the code clearer. > > This would typically break the bo size comp

[Mesa-dev] [AppVeyor] mesa master #1366 failed

Build mesa 1366 failed Commit 89bb4be91e by Kristian Høgsberg Kristensen on 5/25/2016 4:30 PM: i965: Fix shadowing of 'height' parameter\n\nThe nested declaration of 'height' shadows a parameter and uses\nuninitialized memory. Fix by renaming to 'plane_height'

[Mesa-dev] [Bug 95346] Stellaris - Black/super dark planets

https://bugs.freedesktop.org/show_bug.cgi?id=95346 Jure Repinc changed: What|Removed |Added CC||jlp.b...@gmail.com -- You are receiving t

[Mesa-dev] [PATCH] i965/gen9: Remove the halign/valign field setup code in fast copy blit

Experimentation with different values of src/dst horizontal/vertical alignment showed that these fileds are not used on gen9 hardware. A recent update in graphics specs has removed these fields from XY_FAST_COPY_BLT command. Cc: Ben Widawsky Cc: Chad Versace Signed-off-by: Anuj Phogat --- src

[Mesa-dev] [PATCH 3/3] nir/inline: Also rewrite param derefs for texture instructions

--- src/compiler/nir/nir_inline_functions.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir_inline_functions.c b/src/compiler/nir/nir_inline_functions.c index af9a781..d1b80f6 100644 --- a/src/compiler/nir/nir_inline_functions.c

[Mesa-dev] [PATCH 1/3] nir/inline: Make the rewrite_param_derefs helper work on instructions

Now that we have the better nir_foreach_block macro, there's no reason to use the archaic block version for everything. --- src/compiler/nir/nir_inline_functions.c | 53 - 1 file changed, 25 insertions(+), 28 deletions(-) diff --git a/src/compiler/nir/nir_inline_fu

[Mesa-dev] [PATCH 2/3] nir/inline: Break the guts of rewrite_param-derefs into a helper

--- src/compiler/nir/nir_inline_functions.c | 49 - 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/src/compiler/nir/nir_inline_functions.c b/src/compiler/nir/nir_inline_functions.c index e124a77..af9a781 100644 --- a/src/compiler/nir/nir_inline_fun

[Mesa-dev] [PATCH 2/2] mesa: 80-column wrapping for _context_lost_GetSynciv()

--- src/mesa/main/getstring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index 8989b08..1118a44 100644 --- a/src/mesa/main/getstring.c +++ b/src/mesa/main/getstring.c @@ -312,8 +312,8 @@ _mesa_GetError( void ) }

[Mesa-dev] [PATCH 1/2] mesa: add GLAPIENTRY to new _context_lost_X functions

To fix MSVC build. Any function which goes into the dispatch table needs to have the GLAPIENTRY (__stdcall) tag. --- src/mesa/main/getstring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index 125b03a..8989b08 10064

Re: [Mesa-dev] [PATCHv2 0/2] scons 2.5.0 support

Thanks. I'll push these soon. -Brian On 05/25/2016 01:12 AM, Giuseppe Bilotta wrote: Again, the main patch is the second, the first is just a cleanup of EOL whitespace. Changes over v1: * rebased on current master; * documented EOL whitespace cleanup shell command; * direct link to Bugzilla,

Re: [Mesa-dev] [PATCH] i965/gen9: Remove the halign/valign field setup code in fast copy blit

On Wed, May 25, 2016 at 10:52:31AM -0700, Anuj Phogat wrote: > Experimentation with different values of src/dst horizontal/vertical > alignment showed that these fileds are not used on gen9 hardware. > > A recent update in graphics specs has removed these fields from > XY_FAST_COPY_BLT command. >

Re: [Mesa-dev] [PATCH 2/2] mesa: 80-column wrapping for _context_lost_GetSynciv()

Ah right. Thanks, both patches R-b. Kristian > On May 25, 2016, at 10:59, Brian Paul wrote: > > --- > src/mesa/main/getstring.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c > index 8989b08..1118a44 100644 > -

[Mesa-dev] [PATCH] docs: Python3 needed for Intel driver

--- docs/install.html | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/install.html b/docs/install.html index 8b349c4..41a7d79 100644 --- a/docs/install.html +++ b/docs/install.html @@ -34,8 +34,9 @@ 1.1 General -http://www.python.org/";>Python - Python is require

Re: [Mesa-dev] [PATCH] docs: Python3 needed for Intel driver

On Wed, May 25, 2016 at 2:26 PM, Brian Paul wrote: > --- > docs/install.html | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/docs/install.html b/docs/install.html > index 8b349c4..41a7d79 100644 > --- a/docs/install.html > +++ b/docs/install.html > @@ -34,8 +34,9 @@

Re: [Mesa-dev] [PATCH] docs: Python3 needed for Intel driver

On 05/25/2016 12:27 PM, Ilia Mirkin wrote: On Wed, May 25, 2016 at 2:26 PM, Brian Paul wrote: --- docs/install.html | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/install.html b/docs/install.html index 8b349c4..41a7d79 100644 --- a/docs/install.html +++ b/docs/

[Mesa-dev] [PATCH] i965: Don't use fast copy blit in case of logical operations other than GL_COPY

XY_FAST_COPY_BLT command doesn't have a field for raster operation. So, fall back to using XY_SRC_COPY_BLT to handle those cases. Fixes piglit test gl-1.1-xor-copypixels when fast copy blit is enabled for all tiling formats. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_blit.c

Re: [Mesa-dev] [PATCH] docs: Python3 needed for Intel driver

On Wed, May 25, 2016 at 2:27 PM, Ilia Mirkin wrote: > On Wed, May 25, 2016 at 2:26 PM, Brian Paul wrote: >> --- >> docs/install.html | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/docs/install.html b/docs/install.html >> index 8b349c4..41a7d79 100644 >> --- a/do

[Mesa-dev] [PATCH] nvc0: add descriptions for hardware perf counters/metrics

The GALLIUM_HUD does not yet expose a description for each events, but this might be useful for developers who want to have a long description of hw perf counters directly in the source code. Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/nvc0/nvc0_query_hw_metric.c| 65 +++- .../dr

Re: [Mesa-dev] [PATCH] nvc0: add descriptions for hardware perf counters/metrics

On Wed, May 25, 2016 at 2:49 PM, Samuel Pitoiset wrote: > The GALLIUM_HUD does not yet expose a description for each events, but > this might be useful for developers who want to have a long description > of hw perf counters directly in the source code. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH] nvc0: add descriptions for hardware perf counters/metrics

On 05/25/2016 08:52 PM, Ilia Mirkin wrote: On Wed, May 25, 2016 at 2:49 PM, Samuel Pitoiset wrote: The GALLIUM_HUD does not yet expose a description for each events, but this might be useful for developers who want to have a long description of hw perf counters directly in the source code. S

Re: [Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

On Wed, May 25, 2016 at 4:46 PM, Philipp Zabel wrote: > Am Mittwoch, den 25.05.2016, 16:01 +0200 schrieb Marek Olšák: >> On Wed, May 25, 2016 at 3:44 PM, Philipp Zabel >> wrote: >> > Am Dienstag, den 10.05.2016, 17:35 +0200 schrieb Philipp Zabel: >> >> To support the EGL_KHR_fence_sync extension

Re: [Mesa-dev] [PATCH] docs: Python3 needed for Intel driver

On Wed, May 25, 2016 at 11:29 AM, Ilia Mirkin wrote: > On Wed, May 25, 2016 at 2:27 PM, Ilia Mirkin wrote: > > On Wed, May 25, 2016 at 2:26 PM, Brian Paul wrote: > >> --- > >> docs/install.html | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-) > >> > >> diff --git a/docs/install.

[Mesa-dev] [PATCH v2] nvc0: add descriptions for hardware perf counters/metrics

The GALLIUM_HUD does not yet expose a description for each events, but this might be useful for developers who want to have a long description of hw perf counters directly in the source code. v2: - add static const for the arrays of queries/metrics - add spaces before quotes Signed-off-by: Sa

[Mesa-dev] [Bug 96176] Cannot build non-intel drivers without python3.

https://bugs.freedesktop.org/show_bug.cgi?id=96176 --- Comment #2 from Vinson Lee --- Mac OS X and CentOS do not have Python 3. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev m

Re: [Mesa-dev] [PATCH v2] nvc0: add descriptions for hardware perf counters/metrics

Reviewed-by: Ilia Mirkin Of course if these aren't used, you can just have the macro take the extra parameter and do nothing with it. Your call. On Wed, May 25, 2016 at 2:58 PM, Samuel Pitoiset wrote: > The GALLIUM_HUD does not yet expose a description for each events, but > this might be usefu

[Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

This fixes use of compute shaders with some NVIDIA GL 4.3 samples which require a compat profile. Signed-off-by: Samuel Pitoiset --- src/mesa/main/context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index 46444d2..7152f7

Re: [Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

On Wed, May 25, 2016 at 12:17 PM, Samuel Pitoiset wrote: > This fixes use of compute shaders with some NVIDIA GL 4.3 samples which > require a compat profile. I'm confused. The samples you're talking about... use 4.3 compatibility? We already don't support compatibility profile, so you presumabl

Re: [Mesa-dev] [PATCH 12/29] tnl: Use bitmask/ffs to iterate enabled lights

On Wed, May 25, 2016 at 9:17 AM, Ian Romanick wrote: > On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: >> From: Mathias Fröhlich >> >> Replaces loops that iterate all lights and test >> which of them is enabled by a loop only iterating over >> the bits set in the enabled bitmask. >> ---

Re: [Mesa-dev] [PATCH] i965: Don't use fast copy blit in case of logical operations other than GL_COPY

On Wed, May 25, 2016 at 11:40 AM, Anuj Phogat wrote: > XY_FAST_COPY_BLT command doesn't have a field for raster operation. So, fall > back to using XY_SRC_COPY_BLT to handle those cases. > > Fixes piglit test gl-1.1-xor-copypixels when fast copy blit is enabled > for all tiling formats. > > Signed

Re: [Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

On 05/25/2016 09:52 PM, Matt Turner wrote: On Wed, May 25, 2016 at 12:17 PM, Samuel Pitoiset wrote: This fixes use of compute shaders with some NVIDIA GL 4.3 samples which require a compat profile. I'm confused. The samples you're talking about... use 4.3 compatibility? We already don't su

Re: [Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

On Wed, May 25, 2016 at 3:52 PM, Matt Turner wrote: > On Wed, May 25, 2016 at 12:17 PM, Samuel Pitoiset > wrote: >> This fixes use of compute shaders with some NVIDIA GL 4.3 samples which >> require a compat profile. > > I'm confused. > > The samples you're talking about... use 4.3 compatibility?

  1   2   >