Re: [Mesa-dev] [PATCH 07/40] i965/blorp: Use 8k chunk size for urb allocation

2016-04-18 Thread Pohjolainen, Topi
On Sun, Apr 17, 2016 at 10:46:54PM -0700, Kenneth Graunke wrote: > On Saturday, April 16, 2016 4:42:35 PM PDT Topi Pohjolainen wrote: > > Otherwise switch from blorp to compute failes. Note that this now > > follows the normal i965 upload logic found in gen7_upload_urb(). > > > > Effectively vs_si

Re: [Mesa-dev] [PATCH 13/40] i965/blorp: Pipeline upload support for gen8

2016-04-18 Thread Kenneth Graunke
On Saturday, April 16, 2016 4:42:41 PM PDT Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > src/mesa/drivers/dri/i965/brw_blorp.h | 3 + > src/mesa/drivers/dri/i965/gen8_blorp.cpp | 694 ++ +++

Re: [Mesa-dev] [PATCH 10/40] i965/blorp: Prepare render target write for gen8

2016-04-18 Thread Kenneth Graunke
On Saturday, April 16, 2016 4:42:38 PM PDT Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 2 +- > src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 3 ++- > src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 2 +- > src/mesa/d

Re: [Mesa-dev] [PATCH 14/40] i965/blorp: Add support for source swizzle

2016-04-18 Thread Kenneth Graunke
On Saturday, April 16, 2016 4:42:42 PM PDT Topi Pohjolainen wrote: > In order to support cases where gen9 uses RGBA format to back client > requested RGB, one needs to have means to force alpha channel to one > when user requested RGB surface is used as blit source. > > Signed-off-by: Topi Pohjola

Re: [Mesa-dev] [PATCH 16/40] i965/blorp: Add check for supported sample numbers

2016-04-18 Thread Kenneth Graunke
On Saturday, April 16, 2016 4:42:44 PM PDT Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 ++ > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 +++-- > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 18/40] i965/blorp: Enable blits on gen8

2016-04-18 Thread Kenneth Graunke
On Saturday, April 16, 2016 4:42:46 PM PDT Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.cpp | 6 +- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 8 +--- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +-- > 3 files c

Re: [Mesa-dev] [PATCH 13/40] i965/blorp: Pipeline upload support for gen8

2016-04-18 Thread Pohjolainen, Topi
On Mon, Apr 18, 2016 at 12:22:06AM -0700, Kenneth Graunke wrote: > On Saturday, April 16, 2016 4:42:41 PM PDT Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > > src/mesa/drivers/dri/i965/brw_blorp.h | 3 + > > src

Re: [Mesa-dev] [PATCH 32/40] i965/blorp/gen7: Prepare blorp being the very first renderer

2016-04-18 Thread Kenneth Graunke
On Saturday, April 16, 2016 4:43:00 PM PDT Topi Pohjolainen wrote: > I noticed using one synthetic benchmark a sequence where hiz depth > operations are run first followed by a color buffer clear. In such > case there is a difference between blorp and meta clear where meta > configures L3 but blorp

Re: [Mesa-dev] [PATCH 10/40] i965/blorp: Prepare render target write for gen8

2016-04-18 Thread Pohjolainen, Topi
On Mon, Apr 18, 2016 at 12:25:19AM -0700, Kenneth Graunke wrote: > On Saturday, April 16, 2016 4:42:38 PM PDT Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 2 +- > > src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 3 +

Re: [Mesa-dev] [PATCH 10/40] i965/blorp: Prepare render target write for gen8

2016-04-18 Thread Pohjolainen, Topi
On Mon, Apr 18, 2016 at 10:59:25AM +0300, Pohjolainen, Topi wrote: > On Mon, Apr 18, 2016 at 12:25:19AM -0700, Kenneth Graunke wrote: > > On Saturday, April 16, 2016 4:42:38 PM PDT Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > > src/mesa/drivers/dri/i965/brw_blorp_bl

Re: [Mesa-dev] [PATCH 10/40] i965/blorp: Prepare render target write for gen8

2016-04-18 Thread Pohjolainen, Topi
On Mon, Apr 18, 2016 at 12:25:19AM -0700, Kenneth Graunke wrote: > On Saturday, April 16, 2016 4:42:38 PM PDT Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 2 +- > > src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 3 +

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-18 Thread Oded Gabbay
On Fri, Apr 15, 2016 at 2:35 AM, Ilia Mirkin wrote: > On Thu, Apr 14, 2016 at 7:26 PM, Roland Scheidegger > wrote: >> Am 14.04.2016 um 14:18 schrieb Oded Gabbay: >>> This patch adds a new field, called "endian_format", to >>> "struct pipe_resource". The new field is of type "enum pipe_endian" an

[Mesa-dev] [PATCH 2/9] gallivm: Use LLVMSetTarget.

2016-04-18 Thread Jose Fonseca
Instead of LLVM C++ interfaces. --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp index c1e262b..37e2f08 100644 --- a/src/galli

[Mesa-dev] [PATCH 1/9] gallivm: Use LLVMPrintValueToString where available.

2016-04-18 Thread Jose Fonseca
And llvm::raw_string_ostream where not (LLVM 3.3). Thereby eliminating yet another dependency on unstable LLVM interfaces. As a bonus this also gets LLVM IR on OutputDebugMessageA on MSVC (which was disabled, probably due to C++ issues.) Tested `lp_test_arit -v -v` on LLVM 3.3, 3.4 and 3.8. ---

[Mesa-dev] [PATCH 6/9] gallivm: Remove lp_get_module_id.

2016-04-18 Thread Jose Fonseca
Just keep a copy of the module_name in gallivm. --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 7 --- src/gallium/auxiliary/gallivm/lp_bld_debug.h | 4 src/gallium/auxiliary/gallivm/lp_bld_init.c| 15 ++- src/gallium/auxiliary/gallivm/lp_bld_init.h| 1 + 4 f

[Mesa-dev] [PATCH 3/9] scons: Show the unit test full path.

2016-04-18 Thread Jose Fonseca
--- scons/gallium.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/gallium.py b/scons/gallium.py index 94321b2..dd29c75 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -99,7 +99,7 @@ def unit_test(env, test_name, program_target, args=None): cmd = ' '.join(c

[Mesa-dev] [PATCH 5/9] gallivm: Fix MCJIT with LLVM 3.3.

2016-04-18 Thread Jose Fonseca
One needs to call setJITMemoryManager for LLVM 3.3, instead of setMCJITMemoryManager. This regressed in commits 065256df/75ad4fe7 when trying to make the code to build with LLVM 3.6. Testing MCJIT with LLVM 3.3 to 3.6. --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 6 +++--- 1 file changed,

[Mesa-dev] [PATCH 7/9] gallivm: Avoid llvm::sys::getProcessTriple().

2016-04-18 Thread Jose Fonseca
Just use LLVM_HOST_TRIPLE, which is available at least from LLVM 3.3 onwards, and is pretty much what llvm::sys::getProcessTriple() does anyway, --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/galliv

[Mesa-dev] [PATCH 9/9] llvmpipe: Skip false exp2 failure in lp_test_arit due to buggy MSVCRT.

2016-04-18 Thread Jose Fonseca
64bits MSVCRT's exp2f(-inf) returns -inf instead of 0. Tested with MSVC 2013's CRT. (I haven't tried 2015 yet.) Also this does not happen with MinGW. --- src/gallium/drivers/llvmpipe/lp_test_arit.c | 38 ++--- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 4/9] gallivm: Make MCJIT a runtime option.

2016-04-18 Thread Jose Fonseca
On the LLVM versions that support it, so we can easily switch between MCJIT/old-jit for testing. The new option is GALLIVM_MCJIT. Unfortunately setting GALLIVM_MCJIT=1 for LLVM 3.3 or 3.4 causes segfault, both on Linux and Windows. I'm almost certain this used to work, so there probably is a reg

[Mesa-dev] [PATCH 8/9] llvmpipe: Test more vector lengths.

2016-04-18 Thread Jose Fonseca
All power of two of up native vector length. There is actually a bug in lp_build_round for v2, whereby it doesn't round to nearest. Fixing is left to the future, but the test is now able to expect it to fail. --- src/gallium/drivers/llvmpipe/lp_test_arit.c | 43 - 1 f

Re: [Mesa-dev] [PATCH 1/2] glsl: android: add back missing generated glcpp include path

2016-04-18 Thread Chih-Wei Huang
2016-04-16 1:21 GMT+08:00 Emil Velikov : > On 14 April 2016 at 20:40, Rob Herring wrote: >> Commit 4db8f15a2576 ("glsl: move the android build scripts a level up") >> dropped a generated include path for glcpp. Add it back adjusting for the >> new location. >> >> Cc: Emil Velikov >> Signed-off-by

Re: [Mesa-dev] [PATCH] nvc0/lowering: Handle conversions to U64/S64 manually

2016-04-18 Thread Hans de Goede
Hi, On 17-04-16 22:27, Pierre Moreau wrote: On 04:17 PM - Apr 17 2016, Ilia Mirkin wrote: On Sun, Apr 17, 2016 at 4:07 PM, Pierre Moreau wrote: Ping :-) On 10:56 PM - Mar 19 2016, Pierre Moreau wrote: Generating a `cvt u32 $r0 u64 $r1d` or a `cvt u64 $r0d u32 $r2` makes the GPU unhappy. Ins

Re: [Mesa-dev] Why is www.freedesktop.org/wiki/AccountRequests/ so "complicated"?

2016-04-18 Thread Daniel Stone
Hi, On 17 April 2016 at 16:58, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > Secondly, the content of the wiki page feels overly bureaucratic to me. Not > in absolute sense, but in relative sense: when compared to services such as > github.com, the freedesktop.org wiki page feels like a nice example of >

Re: [Mesa-dev] [PATCH v3] math: Import isinf and others to global namespace

2016-04-18 Thread Jose Fonseca
Thanks. I've tweak the version check logic and pushed. Jose On 14/04/16 19:43, Pierre Moreau wrote: Starting from C++11, several math functions, like isinf, moved into the std namespace. Since cmath undefines those functions before redefining them inside the namespace, and glibc 2.23 defines th

Re: [Mesa-dev] [PATCH 18/40] i965/blorp: Enable blits on gen8

2016-04-18 Thread Pohjolainen, Topi
On Mon, Apr 18, 2016 at 12:44:50AM -0700, Kenneth Graunke wrote: > On Saturday, April 16, 2016 4:42:46 PM PDT Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/brw_blorp.cpp | 6 +- > > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 8 +++

Re: [Mesa-dev] [PATCH 16/40] i965/blorp: Add check for supported sample numbers

2016-04-18 Thread Pohjolainen, Topi
On Mon, Apr 18, 2016 at 12:42:34AM -0700, Kenneth Graunke wrote: > On Saturday, April 16, 2016 4:42:44 PM PDT Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 ++ > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c |

Re: [Mesa-dev] [PATCH 7/9] gallivm: Avoid llvm::sys::getProcessTriple().

2016-04-18 Thread Jose Fonseca
On 18/04/16 10:14, Jose Fonseca wrote: Just use LLVM_HOST_TRIPLE, which is available at least from LLVM 3.3 onwards, and is pretty much what llvm::sys::getProcessTriple() does anyway, --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [Mesa-dev] [PATCH v3] math: Import isinf and others to global namespace

2016-04-18 Thread Pierre Moreau
Thanks a lot Jose! If it hasn’t been done yet, could you please revert the commit you pushed that only affected Nouveau, since it’s now unnecessary, and furthermore, didn’t had the glibc check. Thanks! Pierre On 11:21 AM - Apr 18 2016, Jose Fonseca wrote: > Thanks. I've tweak the version check lo

Re: [Mesa-dev] [PATCH] nvc0/lowering: Handle conversions to U64/S64 manually

2016-04-18 Thread Pierre Moreau
On 11:21 AM - Apr 18 2016, Hans de Goede wrote: > Hi, > > On 17-04-16 22:27, Pierre Moreau wrote: > >On 04:17 PM - Apr 17 2016, Ilia Mirkin wrote: > >>On Sun, Apr 17, 2016 at 4:07 PM, Pierre Moreau > >>wrote: > >>>Ping :-) > >>> > >>>On 10:56 PM - Mar 19 2016, Pierre Moreau wrote: > Generati

Re: [Mesa-dev] [PATCH] radeonsi: emit s_waitcnt for shader memory barriers and volatile

2016-04-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Apr 18, 2016 at 12:27 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Turns out that this is needed after all to satisfy some strengthened > coherency tests. Depends on support in LLVM, see > http://reviews.llvm.org/D19203 > --- > Note that this patc

Re: [Mesa-dev] [PATCH v2 12/12] radeonsi: Use CE for all descriptors.

2016-04-18 Thread Marek Olšák
On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen wrote: > v2: Load previous list for new CS instead of re-emitting > all descriptors. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 70 > +++ > 1 file changed, 60 inserti

Re: [Mesa-dev] [PATCH 2/9] gallivm: Use LLVMSetTarget.

2016-04-18 Thread Emil Velikov
Hi Jose, On 18 April 2016 at 10:14, Jose Fonseca wrote: > Instead of LLVM C++ interfaces. > --- > src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp > b/src/gallium/auxiliar

Re: [Mesa-dev] [PATCH 6/9] gallivm: Remove lp_get_module_id.

2016-04-18 Thread Emil Velikov
On 18 April 2016 at 10:14, Jose Fonseca wrote: > @@ -306,6 +309,15 @@ init_gallivm_state(struct gallivm_state *gallivm, const > char *name, > if (!gallivm->context) >goto fail; > > + gallivm->module_name = NULL; > + if (name) { > + size_t size = strlen(name) + 1; > + ga

Re: [Mesa-dev] [PATCH 6/9] gallivm: Remove lp_get_module_id.

2016-04-18 Thread Jose Fonseca
On 18/04/16 13:30, Emil Velikov wrote: On 18 April 2016 at 10:14, Jose Fonseca wrote: @@ -306,6 +309,15 @@ init_gallivm_state(struct gallivm_state *gallivm, const char *name, if (!gallivm->context) goto fail; + gallivm->module_name = NULL; + if (name) { + size_t size =

Re: [Mesa-dev] [PATCH 2/9] gallivm: Use LLVMSetTarget.

2016-04-18 Thread Jose Fonseca
On 18/04/16 13:27, Emil Velikov wrote: Hi Jose, On 18 April 2016 at 10:14, Jose Fonseca wrote: Instead of LLVM C++ interfaces. --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_m

Re: [Mesa-dev] [PATCH 6/9] gallivm: Remove lp_get_module_id.

2016-04-18 Thread Emil Velikov
On 18 April 2016 at 13:51, Jose Fonseca wrote: > On 18/04/16 13:30, Emil Velikov wrote: >> >> On 18 April 2016 at 10:14, Jose Fonseca wrote: >> >>> @@ -306,6 +309,15 @@ init_gallivm_state(struct gallivm_state *gallivm, >>> const char *name, >>> if (!gallivm->context) >>> goto fail; >

[Mesa-dev] [PATCH] glx: Refactor the configure options for glx implementation choice (v3)

2016-04-18 Thread Chuck Atkins
Instead of cascading support for various different implementations of GLX, all three options are now specified through the --enable-glx option: --enable-glx=dri : Enable the DRI-based GLX --enable-glx=xlib : Enable the classic Xlib-based GLX --enable-glx=gallium-xlib : Enabl

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-04-18 Thread Alejandro Piñeiro
On 18/04/16 00:47, Ilia Mirkin wrote: > On Mon, Mar 28, 2016 at 2:50 PM, Alejandro Piñeiro > wrote: >> v2: >> * Take into account out varyings too (Timothy Arceri) >> * Fix style (Timothy Arceri) >> * Use a new ast_expression variable, instead of an >>ast_expression::hir new parameter (Tim

Re: [Mesa-dev] [PATCH 2/9] gallivm: Use LLVMSetTarget.

2016-04-18 Thread Emil Velikov
On 18 April 2016 at 14:16, Jose Fonseca wrote: > On 18/04/16 13:27, Emil Velikov wrote: >> >> Hi Jose, >> >> On 18 April 2016 at 10:14, Jose Fonseca wrote: >>> >>> Instead of LLVM C++ interfaces. >>> --- >>> src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 8 +--- >>> 1 file changed, 5 inse

Re: [Mesa-dev] [PATCH 1/9] gallivm: Use LLVMPrintValueToString where available.

2016-04-18 Thread Roland Scheidegger
Series looks great to me. Thanks for the cleanup. Reviewed-by: Roland Scheidegger Am 18.04.2016 um 11:14 schrieb Jose Fonseca: > And llvm::raw_string_ostream where not (LLVM 3.3). > > Thereby eliminating yet another dependency on unstable LLVM interfaces. > > As a bonus this also gets LLVM IR

Re: [Mesa-dev] [PATCH 4/4] i965: Properly handle integer types in opt_vector_float().

2016-04-18 Thread Iago Toral
On Sun, 2016-04-17 at 23:14 -0700, Kenneth Graunke wrote: > Previously, opt_vector_float() always interpreted MOV sources as > floating point, and always created a MOV with a F-type destination. > > This meant that we could mess up sequences of integer loads, such as: > >mov vgrf6.0.x:D, 0D >

Re: [Mesa-dev] [PATCH 1/4] i965: Rework opt_vector_float() control flow.

2016-04-18 Thread Iago Toral
Patches 1-3 are: Reviewed-by: Iago Toral Quiroga On Sun, 2016-04-17 at 23:14 -0700, Kenneth Graunke wrote: > This reworks opt_vector_float() so that there's only one place that > flushes out any accumulated state and emits a VF. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-18 Thread Oded Gabbay
On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin wrote: > On Thu, Apr 14, 2016 at 11:08 AM, Oded Gabbay wrote: >>> Wouldn't it make more sense to handle such issues in transfer_map? >>> (i.e. create a staging memory area, and decode into it)? This assumes >>> that the transfer_map() call has enough i

Re: [Mesa-dev] [PATCH 4/7] radeonsi: don't use ACQUIRE_MEM on the graphics ring

2016-04-18 Thread Alex Deucher
On Sun, Apr 17, 2016 at 12:11 PM, Marek Olšák wrote: > From: Marek Olšák > > It's only required on the compute ring. This matches the closed driver. > > The compute flag is removed to prevent confusion and Bas's compute shader > patches remove it in the whole function. FWIW, these are effectivel

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-18 Thread Rob Clark
On Mon, Apr 18, 2016 at 10:47 AM, Oded Gabbay wrote: > On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin wrote: >> On Thu, Apr 14, 2016 at 11:08 AM, Oded Gabbay wrote: Wouldn't it make more sense to handle such issues in transfer_map? (i.e. create a staging memory area, and decode into it)?

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-18 Thread Ilia Mirkin
On Mon, Apr 18, 2016 at 10:47 AM, Oded Gabbay wrote: > On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin wrote: >> On Thu, Apr 14, 2016 at 11:08 AM, Oded Gabbay wrote: Wouldn't it make more sense to handle such issues in transfer_map? (i.e. create a staging memory area, and decode into it)?

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

2016-04-18 Thread Emil Velikov
On 18 April 2016 at 04:43, Francisco Jerez wrote: > Grazvydas Ignotas writes: > >> On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov >> wrote: >>> On 16 April 2016 at 02:00, Grazvydas Ignotas wrote: This is mostly for variables that are only used in asserts and cause unused-but-set-varia

Re: [Mesa-dev] [PATCH 1/4] gallivm: convert size query to using a set of parameters.

2016-04-18 Thread Roland Scheidegger
Am 18.04.2016 um 04:49 schrieb Dave Airlie: > From: Dave Airlie > > This isn't currently that easy to expand, so fix it up > before expanding it later to include dynamic samplers. > > Signed-off-by: Dave Airlie > --- > src/gallium/auxiliary/draw/draw_llvm_sample.c | 22 ++- > src/galli

[Mesa-dev] [PATCH] docs: correct name for GL_OES_primitive_bounding_box

2016-04-18 Thread Erik Faye-Lund
When this extension was added, an underscore were mistakenly replaced by a space. Let's correct this, so it's a tad easier to grep for this extension. Signed-off-by: Erik Faye-Lund --- Just a tiny nit I noticed while reading docs... docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [Mesa-dev] [PATCH 8/9] llvmpipe: Test more vector lengths.

2016-04-18 Thread Tom Stellard
On Mon, Apr 18, 2016 at 10:14:35AM +0100, Jose Fonseca wrote: > All power of two of up native vector length. > > There is actually a bug in lp_build_round for v2, whereby it doesn't > round to nearest. Fixing is left to the future, but the test is now > able to expect it to fail. > --- > src/gal

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-18 Thread Marek Olšák
On Mon, Apr 18, 2016 at 5:03 PM, Ilia Mirkin wrote: > On Mon, Apr 18, 2016 at 10:47 AM, Oded Gabbay wrote: >> On Thu, Apr 14, 2016 at 6:44 PM, Ilia Mirkin wrote: >>> On Thu, Apr 14, 2016 at 11:08 AM, Oded Gabbay wrote: > Wouldn't it make more sense to handle such issues in transfer_map? >>>

Re: [Mesa-dev] [PATCH v2 0/2] Fix Gallium RGB565 image support

2016-04-18 Thread Nicolas Dufresne
Le lundi 18 avril 2016 à 11:40 +0900, Michel Dänzer a écrit : > On 17.04.2016 09:49, nico...@ndufresne.ca wrote: > > > > From: Nicolas Dufresne > > > > Sorry for the long delay breaking down this patch. I have now > > rebased > > on top recent mesa tree. First patch creates a new function to > >

[Mesa-dev] [Bug 94994] OSMesaGetProcAdress always fails on mangled OSMesa

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94994 Bug ID: 94994 Summary: OSMesaGetProcAdress always fails on mangled OSMesa Product: Mesa Version: 11.2 Hardware: All OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 91724] GL/gl_mangle.h misses symbols from GLES/gl.h

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91724 Frederic Devernay changed: What|Removed |Added Blocks||94994 -- You are receiving this mai

[Mesa-dev] [Bug 94994] OSMesaGetProcAdress always fails on mangled OSMesa

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94994 Frederic Devernay changed: What|Removed |Added Depends on||91724 CC|

Re: [Mesa-dev] i965: The future of blorp

2016-04-18 Thread Pohjolainen, Topi
On Sat, Apr 16, 2016 at 12:12:46PM -0700, Jason Ekstrand wrote: >All, >With Topi's gen8/9 blorp patches on the list, I wanted to start a brief >discussion about the future of blorp in the hopes of us all being on >the same page and not stepping on each other's toes. I think everyon

Re: [Mesa-dev] [PATCH 2/4] gallivm: prepare for dynamic texture sizes

2016-04-18 Thread Roland Scheidegger
Am 18.04.2016 um 04:49 schrieb Dave Airlie: > From: Dave Airlie > > Currently the texture member functions take a texture unit > number, in order for TXQ to work we want to use a dynamic > value here, so we need to pass in an value reference. > > This means we can't do the assert or add the llvm

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-18 Thread Andres Gomez
Hi, I would really appreciate if you could find some time to review this patch. Thanks! On Mon, 2016-04-04 at 19:50 +0300, Andres Gomez wrote: > This generalizes the validation also to be done for variables inside > interface blocks, which, for some cases, was missing. > > For a discussion abou

Re: [Mesa-dev] [PATCH 3/4] [rfc] gallivm/llvmpipe dynamic samplers support.

2016-04-18 Thread Roland Scheidegger
Am 18.04.2016 um 04:49 schrieb Dave Airlie: > From: Dave Airlie > > This is a first attempt at adding support for dynamic indexing > of samplers to llvmpipe. This is needed for ARB_gpu_shader5 support. > > This uses the sampler function generator to generate functions > for all samplers, then us

Re: [Mesa-dev] [PATCH] docs: correct name for GL_OES_primitive_bounding_box

2016-04-18 Thread Kenneth Graunke
On Monday, April 18, 2016 5:26:33 PM PDT Erik Faye-Lund wrote: > When this extension was added, an underscore were mistakenly replaced > by a space. Let's correct this, so it's a tad easier to grep for this > extension. > > Signed-off-by: Erik Faye-Lund > --- > > Just a tiny nit I noticed while

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

2016-04-18 Thread Francisco Jerez
Emil Velikov writes: > On 18 April 2016 at 04:43, Francisco Jerez wrote: >> Grazvydas Ignotas writes: >> >>> On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov >>> wrote: On 16 April 2016 at 02:00, Grazvydas Ignotas wrote: > This is mostly for variables that are only used in asserts and

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #7 from David Lonie --- > Comment # 1 on bug 94955 from Brian Paul > (In reply to David Lonie from comment #0) > > ==32054== Conditional jump or move depends on uninitialised value(s) > > ==32054==    at 0x5367CF7: util_framebuffer_st

Re: [Mesa-dev] [PATCH] radeonsi: enable GLSL 4.30 and therefore OpenGL 4.3

2016-04-18 Thread Ian Romanick
On 04/15/2016 03:33 AM, Marek Olšák wrote: > The same thing Nicolai said: This can be committed before the UE4 > compile failure is fixed. Is there a bug filed for that problem? Has anyone diagnosed the issue? > Marek > > On Fri, Apr 15, 2016 at 2:10 AM, Edward O'Callaghan > wrote: >> This is

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

2016-04-18 Thread Ian Romanick
On 04/18/2016 08:06 AM, Emil Velikov wrote: > On 18 April 2016 at 04:43, Francisco Jerez wrote: >> Grazvydas Ignotas writes: >> >>> On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov >>> wrote: On 16 April 2016 at 02:00, Grazvydas Ignotas wrote: > This is mostly for variables that are only

Re: [Mesa-dev] [PATCH 1/4] egl: Remove every double semi-colon

2016-04-18 Thread Ian Romanick
On 04/14/2016 09:07 AM, Jakob Sinclair wrote: > Removes all acidental semi-colons in egl. accidental > > Signed-off-by: Jakob Sinclair > --- > src/egl/drivers/dri2/platform_android.c | 2 +- > src/egl/drivers/dri2/platform_surfaceless.c | 2 +- > 2 files changed, 2 insertions(

Re: [Mesa-dev] [PATCH 0/4] Removing all double semi-colons

2016-04-18 Thread Ian Romanick
With the one typo in the commit message of patch 1 fixed, the series is Reviewed-by: Ian Romanick If there are no objections or other comments, I'll go ahead and fix it and push the series in the next day or so. On 04/14/2016 09:07 AM, Jakob Sinclair wrote: > This patch series remove all double

Re: [Mesa-dev] [PATCH 1/4] i965: Rework opt_vector_float() control flow.

2016-04-18 Thread Matt Turner
On Sun, Apr 17, 2016 at 11:14 PM, Kenneth Graunke wrote: > This reworks opt_vector_float() so that there's only one place that > flushes out any accumulated state and emits a VF. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 63 > +++

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #8 from Roland Scheidegger --- (In reply to David Lonie from comment #7) > > Comment # 4 on bug 94955 from Roland Scheidegger > > FWIW the trace has some issues, namely it requests a 4.5 context thus needs > > overrides to run. Not su

Re: [Mesa-dev] [PATCH 4/4] i965: Properly handle integer types in opt_vector_float().

2016-04-18 Thread Matt Turner
On Mon, Apr 18, 2016 at 7:20 AM, Iago Toral wrote: > On Sun, 2016-04-17 at 23:14 -0700, Kenneth Graunke wrote: >> Previously, opt_vector_float() always interpreted MOV sources as >> floating point, and always created a MOV with a F-type destination. >> >> This meant that we could mess up sequences

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94955 David Lonie changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: [Mesa-dev] [PATCH 4/4] i965: Properly handle integer types in opt_vector_float().

2016-04-18 Thread Matt Turner
On Sun, Apr 17, 2016 at 11:14 PM, Kenneth Graunke wrote: > Previously, opt_vector_float() always interpreted MOV sources as > floating point, and always created a MOV with a F-type destination. > > This meant that we could mess up sequences of integer loads, such as: > >mov vgrf6.0.x:D, 0D >

Re: [Mesa-dev] [PATCH 00/13] i965/compiler: Use ISL for image_load_store format

2016-04-18 Thread Emil Velikov
On 17 April 2016 at 00:47, Jason Ekstrand wrote: > On Sat, Apr 16, 2016 at 4:40 PM, Emil Velikov > wrote: >> >> On 16 April 2016 at 20:45, Jason Ekstrand wrote: >> > This little series switches our back-end compiler to use libisl for the >> > surface format introspection it needs for doing image

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-04-18 Thread Alejandro Piñeiro
On 18/04/16 16:11, Alejandro Piñeiro wrote: > On 18/04/16 00:47, Ilia Mirkin wrote: >> On Mon, Mar 28, 2016 at 2:50 PM, Alejandro Piñeiro >> wrote: >>> v2: >>> * Take into account out varyings too (Timothy Arceri) >>> * Fix style (Timothy Arceri) >>> * Use a new ast_expression variable, inst

[Mesa-dev] [Bug 94271] oclHashcat fails with ERROR: clGetDeviceInfo() : -30 : CL_INVALID_VALUE

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94271 ros...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 95003] [Clover / OpenCL] CL_DEVICE_WAVEFRONT_WIDTH_AMD - 0x4043 unimplemented

2016-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95003 Bug ID: 95003 Summary: [Clover / OpenCL] CL_DEVICE_WAVEFRONT_WIDTH_AMD - 0x4043 unimplemented Product: Mesa Version: 11.2 Hardware: x86-64 (AMD64) OS: Linux

[Mesa-dev] [PATCH] swr: dereference cbuf/zbuf/views on context destroy

2016-04-18 Thread Tim Rowley
Fixes resource memory leaks. --- src/gallium/drivers/swr/swr_context.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/drivers/swr/swr_context.cpp b/src/gallium/drivers/swr/swr_context.cpp index 46c79a1..5d311dd 100644 --- a/src/gallium/drivers/swr/swr_context.c

Re: [Mesa-dev] [PATCH] swr: dereference cbuf/zbuf/views on context destroy

2016-04-18 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin It has been pointed out to me on several occasions that the state tracker should be unbinding all these, and I seem to recall finding that code. But for some reason I've had to do the same thing to avoid leaks. On Mon, Apr 18, 2016 at 4:29 PM, Tim Rowley wrote: > Fixes

[Mesa-dev] [PATCH] glsl: add forgotten textureOffset function for sampler2DArrayShadow

2016-04-18 Thread sroland
From: Roland Scheidegger This was part of EXT_gpu_shader4 - as such it should have been supported by glsl 130. It was however forgotten, and not added until glsl 430 - with the wrong syntax no less (glsl 430 mentions it was overlooked). glsl 440 (but revision 8 only) fixed this finally for good.

Re: [Mesa-dev] [PATCH 3/4] [rfc] gallivm/llvmpipe dynamic samplers support.

2016-04-18 Thread Dave Airlie
On 19 April 2016 at 03:40, Roland Scheidegger wrote: > Am 18.04.2016 um 04:49 schrieb Dave Airlie: >> From: Dave Airlie >> >> This is a first attempt at adding support for dynamic indexing >> of samplers to llvmpipe. This is needed for ARB_gpu_shader5 support. >> >> This uses the sampler function

[Mesa-dev] [PATCH] anv_device: Set the compressed texture feature flags correctly

2016-04-18 Thread Nanley Chery
From: Nanley Chery Sampling from an ETC2 texture is supported from Gen8 onwards. While ASTC_LDR is supported on Gen9, the logic to handle such formats has not yet been implemented in the driver. Fixes dEQP-VK.api.info.format_properties.compressed_formats. Bugzilla: https://bugs.freedesktop.org/

Re: [Mesa-dev] [PATCH] radeonsi: enable GLSL 4.30 and therefore OpenGL 4.3

2016-04-18 Thread Bas Nieuwenhuizen
On Mon, Apr 18, 2016 at 7:58 PM, Ian Romanick wrote: > On 04/15/2016 03:33 AM, Marek Olšák wrote: >> The same thing Nicolai said: This can be committed before the UE4 >> compile failure is fixed. > > Is there a bug filed for that problem? Has anyone diagnosed the issue? > I just filed a bug for

Re: [Mesa-dev] [PATCH] glsl: add forgotten textureOffset function for sampler2DArrayShadow

2016-04-18 Thread Ian Romanick
On 04/18/2016 02:05 PM, srol...@vmware.com wrote: > From: Roland Scheidegger > > This was part of EXT_gpu_shader4 - as such it should have been supported > by glsl 130. > It was however forgotten, and not added until glsl 430 - with the wrong > syntax no less (glsl 430 mentions it was overlooked)

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-18 Thread Timothy Arceri
On Mon, 2016-04-18 at 19:44 +0300, Andres Gomez wrote: > Hi, > > I would really appreciate if you could find some time to review this > patch. Is there a patch somewhere that makes use of this change?  > > Thanks! > > On Mon, 2016-04-04 at 19:50 +0300, Andres Gomez wrote: > > > > This general

[Mesa-dev] [PATCH 2/2] i965/vec4: Unrestrict constant propagation into integer multiply.

2016-04-18 Thread Matt Turner
Analogous to commit 81deefc45b in the i965/fs backend. --- No shader-db changes because the vec4 copy propagation pass is local-only. src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH] swr: fix resource backed constant buffers

2016-04-18 Thread Tim Rowley
Code was using an incorrect address for the base pointer. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94979 --- src/gallium/drivers/swr/swr_state.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/swr_state.cpp b/src/gallium/drivers/s

[Mesa-dev] [PATCH 1/2] i965/vec4: Lower integer multiplication after optimizations.

2016-04-18 Thread Matt Turner
Analogous to commit 1e4e17fbd in the i965/fs backend. Because the copy propagation pass in the vec4 backend is strictly local, we look at the immediate values coming from NIR and emit the multiplies we need directly. If the copy propagation pass becomes smarter in the future, we can reduce the nir

Re: [Mesa-dev] [PATCH 3/4] [rfc] gallivm/llvmpipe dynamic samplers support.

2016-04-18 Thread Roland Scheidegger
Am 18.04.2016 um 23:10 schrieb Dave Airlie: > On 19 April 2016 at 03:40, Roland Scheidegger wrote: >> Am 18.04.2016 um 04:49 schrieb Dave Airlie: >>> From: Dave Airlie >>> >>> This is a first attempt at adding support for dynamic indexing >>> of samplers to llvmpipe. This is needed for ARB_gpu_sh

[Mesa-dev] [PATCH v3 0/2] Remainder radeonsi compute patches.

2016-04-18 Thread Bas Nieuwenhuizen
I added some CS_PARTIAL_FLUSH events after MArek's response. I haven't been able to detect anything wrong without them. However at least theoretically some event has to wait on CS shaders at the new points.(e.g fbo change clearly has a potential write after read hazard otherwise). I also upda

[Mesa-dev] [PATCH v3 2/2] radeonsi: enable TGSI support cap for compute shaders

2016-04-18 Thread Bas Nieuwenhuizen
v2: Use chip_class instead of family. v3: Check kernel version for SI. Signed-off-by: Bas Nieuwenhuizen --- docs/GL3.txt | 4 ++-- docs/relnotes/11.3.0.html | 1 + src/gallium/drivers/radeon/r600_pipe_common.c | 21 - sr

[Mesa-dev] [PATCH v3 1/2] radeonsi: do not do two full flushes on every compute dispatch

2016-04-18 Thread Bas Nieuwenhuizen
v2: Add more CS_PARTIAL_FLUSH events. Essentially every place with waits on finishing for pixel shaders also has a write after read hazard with compute shaders. Invalidating L2 waits implicitly on pixel and compute shaders, so, we don't need a CS_PARTIAL_FLUSH for switching FBO. v3: Add CS_PARTI

Re: [Mesa-dev] [PATCH 4/4] i965: Properly handle integer types in opt_vector_float().

2016-04-18 Thread Kenneth Graunke
On Monday, April 18, 2016 4:20:50 PM PDT Iago Toral wrote: > On Sun, 2016-04-17 at 23:14 -0700, Kenneth Graunke wrote: > > Previously, opt_vector_float() always interpreted MOV sources as > > floating point, and always created a MOV with a F-type destination. > > > > This meant that we could mess

Re: [Mesa-dev] [PATCH] glsl: add forgotten textureOffset function for sampler2DArrayShadow

2016-04-18 Thread Roland Scheidegger
Am 19.04.2016 um 00:43 schrieb Ian Romanick: > On 04/18/2016 02:05 PM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> This was part of EXT_gpu_shader4 - as such it should have been supported >> by glsl 130. >> It was however forgotten, and not added until glsl 430 - with the wrong >>

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: Lower integer multiplication after optimizations.

2016-04-18 Thread Ian Romanick
On 04/18/2016 04:14 PM, Matt Turner wrote: > Analogous to commit 1e4e17fbd in the i965/fs backend. > > Because the copy propagation pass in the vec4 backend is strictly local, > we look at the immediate values coming from NIR and emit the multiplies > we need directly. If the copy propagation pass

[Mesa-dev] [PATCH 00/18] anv: Switch to a new emit macro

2016-04-18 Thread Jason Ekstrand
The first patch in this series adds a short style guide for the Vulkan driver. The rest adds a new emit macro and updates the entire driver to use it and, while we're there, makes the style more consistent. Jason Ekstrand (18): anv: Add a short style guide anv: Add a new block-based batch emi

[Mesa-dev] [PATCH 11/18] anv/genX_pipeline: Use the new emit macro

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_pipeline.c | 25 +++ src/intel/vulkan/genX_pipeline_util.h | 58 +++ 2 files changed, 45 insertions(+), 38 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index cc8841e..776415

[Mesa-dev] [PATCH 13/18] anv/state: Use the new emit macro

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_state.c | 155 +- 1 file changed, 78 insertions(+), 77 deletions(-) diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c index 900f6dc..b997e1b 100644 --- a/src/intel/vulkan/genX_state.c +++ b/src/intel/vulkan

[Mesa-dev] [PATCH 08/18] anv/cmd_buffer: Use the new emit macro for DRAWING_RECTANGLE

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 4a75825..abf0961 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/gen

[Mesa-dev] [PATCH 07/18] anv/cmd_buffer: Use the new emit macro for compute shader dispatch

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 116 - 1 file changed, 64 insertions(+), 52 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 45b009b..4a75825 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/

[Mesa-dev] [PATCH 04/18] anv/cmd_buffer: Use the new emit macro for PIPE_CONTROL and STATE_BASE_ADDRESS

2016-04-18 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 138 - 1 file changed, 76 insertions(+), 62 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index b21ff97..932ba65 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/

  1   2   >