Re: [Mesa-dev] [PATCH v3] mesa: fix interface matching done in validate_io

On Wed, 2015-12-16 at 08:24 +0200, Tapani Pälli wrote: > Patch makes following changes for interface matching: > >- do not try to match builtin variables >- handle swizzle in input name, as example 'a.z' should > match with 'a' >- add matching by location >- check that amount

Re: [Mesa-dev] [Libva] [PATCH] st/va: retrieve size from the temporary img variable

Yeah, agree reviewing them on the mesa list is probably more appropriate. Anyway patch lgtm as well and is Reviewed-by: Christian König Regards, Christian. On 15.12.2015 18:53, Julien Isorce wrote: + mesa-dev of course :) Thx Sean On 15 December 2015 at 17:46, Sean V Kelley

[Mesa-dev] [PATCH v2 1/2] mesa: Add a _mesa_active_fragment_shader_has_side_effects helper

Some drivers can disable the FS unit if there is nothing in the shader code that writes to an output (i.e. color, depth, etc). Right now, mesa has a function to check for atomic buffers and the i965 driver also checks for images. Refactor this logic into a generic function that we can use for any s

[Mesa-dev] [PATCH v2 2/2] mesa: add SSBOs to the list of fragment shader side effects

The i965 driver uses this function to decide if it can disable the FS unit in the absence of color/depth writes. We don't want to disable the unit in the presence of SSBOs, since the fragment shader could be writing to it. We could go a step further and check not just for the presence of SSBOs but

[Mesa-dev] [PATCH v2] i965/gen8/cs: Gen8 requires 64 byte alignment for push constant data

The BDW PRM Vol2a: Command Reference: Instructions, section MEDIA_CURBE_LOAD, says that 'CURBE Total Data Length' and 'CURBE Data Start Address' are 64-byte aligned. This is different from previous gens, that were 32-byte aligned. v2 (Jordan): - CURBE Data Start Address is also 64-byte aligned.

Re: [Mesa-dev] [PATCH 2/5] main: Allow compute shaders to be compiled with OpenGLES 3.1

Reviewed-by: Marta Lofstedt > -Original Message- > From: Justen, Jordan L > Sent: Wednesday, December 16, 2015 1:08 AM > To: mesa-dev@lists.freedesktop.org > Cc: Justen, Jordan L; Lofstedt, Marta > Subject: [PATCH 2/5] main: Allow compute shaders to be compiled with > OpenGLES 3.1 > > P

Re: [Mesa-dev] [PATCH 4/5] i965: Enable compute shaders in more cases for OpenGLES 3.1

Reviewed-by: Marta Lofstedt > -Original Message- > From: Justen, Jordan L > Sent: Wednesday, December 16, 2015 1:08 AM > To: mesa-dev@lists.freedesktop.org > Cc: Justen, Jordan L; Lofstedt, Marta > Subject: [PATCH 4/5] i965: Enable compute shaders in more cases for > OpenGLES 3.1 > > Pr

Re: [Mesa-dev] [PATCH 5/5] i965/screen: Allow OpenGLES 3.1 for gen8+

Reviewed-by: Marta Lofstedt > -Original Message- > From: Justen, Jordan L > Sent: Wednesday, December 16, 2015 1:08 AM > To: mesa-dev@lists.freedesktop.org > Cc: Justen, Jordan L; Ian Romanick; Lofstedt, Marta > Subject: [PATCH 5/5] i965/screen: Allow OpenGLES 3.1 for gen8+ > > OpenGLES

Re: [Mesa-dev] [PATCH v2] i965/gen8/cs: Gen8 requires 64 byte alignment for push constant data

Reviewed-by: Marta Lofstedt > -Original Message- > From: Iago Toral Quiroga [mailto:ito...@igalia.com] > Sent: Wednesday, December 16, 2015 10:02 AM > To: mesa-dev@lists.freedesktop.org > Cc: Lofstedt, Marta; Palli, Tapani; Justen, Jordan L; Iago Toral Quiroga > Subject: [PATCH v2] i965/g

Re: [Mesa-dev] [PATCH] mesa: update gl_HelperInvocation support status in docs

Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tapani Pälli > Sent: Wednesday, December 16, 2015 7:42 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] mesa: update gl_HelperInvocation su

Re: [Mesa-dev] AppVeyor: Build failed: mesa 58

There hasn't been a single spurious build failure since my commit a9a0c693e5cfaf25fbda09d226d4965942baf348 to avoid downloading winflexbison from SourceForge by caching it. So I've just re-enabled notification emails to this list. Jose On 07/12/15 19:00, Jose Fonseca wrote: Once again sorry

Re: [Mesa-dev] [PATCH 6/8] st/va: remove fence handling

Hi Christian, Sorry for the delay, I confirm the flush is required with that config described before. Also in order to only affects that particular I wanted to do this: +if (buf->export_refcount > 0) drv->pipe->flush(drv->pipe, NULL, 0); But this is not the same kind of vlVaBuffer, so not pos

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

This is not well defined in gallium, but r600g and radeonsi use these default swizzles for depth and stencil surfaces and it's probably the only reasonable thing to do: Format = Default swizzle Z24X8 = (Z) Z24S8 = (Z) X24S8 = (S) X8Z24 = (Z) S8Z24 = (Z) S8X24 = (S) Z3

Re: [Mesa-dev] [PATCH] ir_to_mesa: Skip useless comparison instructions.

Reviewed-by: Marek Olšák Marek On Mon, Dec 7, 2015 at 7:50 PM, Matt Turner wrote: > --- > With this, we generate the same number of Mesa IR instructions before > and after my series. all() is the same as well. > > src/mesa/program/ir_to_mesa.cpp | 8 +++- > 1 file changed, 7 insertions(+),

[Mesa-dev] [PATCH v5 0/4] nouveau: add support for vaapi

v5: h264 is now working properly since: http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/state_trackers/va?id=e483cba9f5ff45395fdb1cd40a796799707eb1e0 Just rebased these 4 patches (only one minor conflict due to commit http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/drivers/nouveau

[Mesa-dev] [PATCH v5 1/4] nouveau: split nouveau_vp3_bsp in begin/next/end

It allows to call nouveau_vp3_bsp_next multiple times between one begin/end. It is required to support st/va. https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nouveau_vp3_video.h| 16 +++- .../drivers/nouveau/nouveau_vp3_video_

[Mesa-dev] [PATCH v5 2/4] nvc0: add support for st/va

- split nvc0_decoder_bsp in begin/next/end - preserve content buffer when calling nvc0_decoder_bsp_next - implement pipe_video_codec::begin_frame/end_frame https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nouveau_vp3_video.h|

[Mesa-dev] [PATCH v5 4/4] build: enable st/va with nouveau driver

vainfo fails in vaDriverInit because "dd_create_screen" does not reach strcmp(driver_name, "nouveau") code. Indeed when compiling the va target.c, the macro GALLIUM_NOUVEAU is not defined. This patch define the macro the same it is done for dri and vdpau targets. Tested with: ./autogen.sh --enable

[Mesa-dev] [PATCH v5 3/4] nouveau: fix chunk decoding by updating number of slices

https://bugs.freedesktop.org/show_bug.cgi?id=89969 Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nouveau_vp3_video.h | 3 +++ src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c | 17 +++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/galliu

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions > viewport width/height are not displayed

https://bugs.freedesktop.org/show_bug.cgi?id=80183 --- Comment #16 from cgerlac...@gmail.com --- I have checked mesa version 10.6.9 and 11.0.7 both with llvm 3.4 and the clipping problem is still reproducible here. I have also tried to provide an apitrace. The tool works fine, as long as I stick

[Mesa-dev] [PATCH] Revert "i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals"

This reverts commit 839793680f99b8387bee9489733d5071c10f3ace. The patch was breaking DRI3 because driGLFormatToImageFormat does not handle MESA_FORMAT_B8G8R8X8_SRGB which ended up making it fail to create the renderbuffer and it would later crash. It's not trivial to add this format because there

Re: [Mesa-dev] [PATCH] Add .mailmap

On Tue, Dec 15, 2015 at 4:40 PM, Giuseppe Bilotta wrote: > This adds a first tentative .mailmap file, to canonicize contributor > name/emails in shortlogs and other statistical endeavours. > > There's a couple of root and richard entries which I don't know who > they belong to, and hopefully not t

Re: [Mesa-dev] [PATCH] Add .mailmap

On Wed, Dec 16, 2015 at 4:00 PM, Alex Deucher wrote: > > I believe all of the following are Richard Li: > > +Richard Li > > +richard > +richard > > +root Thanks. I'll move them (maybe put a comment to remark it's not 100% sure). The other root@ are most probably Brian, I'll move them there (

Re: [Mesa-dev] [PATCH] Add .mailmap

On 12/16/2015 08:24 AM, Giuseppe Bilotta wrote: On Wed, Dec 16, 2015 at 4:00 PM, Alex Deucher wrote: I believe all of the following are Richard Li: +Richard Li +richard +richard +root Thanks. I'll move them (maybe put a comment to remark it's not 100% sure). The other root@ are most

[Mesa-dev] [PATCH 0/2] trivial cleanups

Here's some trivial cleanups I found while diving into something else. Instead of them collecting dust in my tree, perhaps we could apply them to the central tree? Erik Faye-Lund (2): gallium/util: removed unused header-file main: get rid of needless conditional src/gallium/auxiliary/Makefi

[Mesa-dev] [PATCH 2/2] main: get rid of needless conditional

We already check if the driver changed the completeness, we don't need to duplicate that check. Let's just early out there instead. Signed-off-by: Erik Faye-Lund --- src/mesa/main/fbobject.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src/mesa/

Re: [Mesa-dev] [PATCH] draw: don't set start_instance and instance id for pt emit

On 15/12/15 00:58, srol...@vmware.com wrote: From: Roland Scheidegger This just adds confusion, these parameters are used when fetching vertices by translate, but certainly not when emitting hw vertices for drivers, they make no sense there (setting them has no consequences otherwise since ther

Re: [Mesa-dev] [PATCH] svga: don't use debug code in update_state() in release builds

On 16/12/15 00:58, Brian Paul wrote: --- src/gallium/drivers/svga/svga_state.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/svga/svga_state.c b/src/gallium/drivers/svga/svga_state.c index 722b369..4479a27 100644 --- a/src/gallium/drivers/svga/svga_state.c +++ b/

[Mesa-dev] [PATCH 1/2] gallium/util: removed unused header-file

This hasn't been in use since c476305 ("gallium/util: pregenerate half float tables"), where the last bit of run-time init using this was killed. So let's just get rid of the pointless header. Signed-off-by: Erik Faye-Lund --- src/gallium/auxiliary/Makefile.sources | 1 - src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

Am 16.12.2015 um 12:52 schrieb Marek Olšák: > This is not well defined in gallium, but r600g and radeonsi use these > default swizzles for depth and stencil surfaces and it's probably the > only reasonable thing to do: > > Format = Default swizzle > Z24X8 = (Z) > Z24S8 = (Z) > X24S8 = YY

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions > viewport width/height are not displayed

https://bugs.freedesktop.org/show_bug.cgi?id=80183 --- Comment #17 from Roland Scheidegger --- (In reply to cgerlach42 from comment #16) > I have checked mesa version 10.6.9 and 11.0.7 both with llvm 3.4 and the > clipping problem is still reproducible here. That would be too old for these fixes,

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: > --- > src/mesa/Makefile.sources | 1 + > src/mesa/state_tracker/st_atifs_to_tgsi.c | 798 > ++ > src/mesa/state_tracker/st_atifs_to_tgsi.h | 49 ++ > src/mesa/state_tracker/st_atom_constbuf.c |

mesa-dev@lists.freedesktop.org

What is this good for? Marek On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: > this works with radeonsi, but crashes with llvmpipe > --- > src/mesa/main/context.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/main/context.c b/src/mesa/main/con

Re: [Mesa-dev] [PATCH 06/11] st/mesa: fix handling the fallback texture

On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: > --- > src/mesa/state_tracker/st_atom_sampler.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_atom_sampler.c > b/src/mesa/state_tracker/st_atom_sampler.c > index 4252c27..7d3d8e7 10064

[Mesa-dev] [Bug 92706] glBlitFramebuffer refuses to blit RGBA to RGB with MSAA

https://bugs.freedesktop.org/show_bug.cgi?id=92706 Neil Roberts changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

On Wed, Dec 16, 2015 at 5:18 PM, Roland Scheidegger wrote: > Am 16.12.2015 um 12:52 schrieb Marek Olšák: >> This is not well defined in gallium, but r600g and radeonsi use these >> default swizzles for depth and stencil surfaces and it's probably the >> only reasonable thing to do: >> >> Format =

Re: [Mesa-dev] [PATCH 10/11] [RFC] mesa: optimize out the realloc from glCopyTexImagexD()

On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: > Apitrace showed this call to be 5ms (9 times per frame), > but in reality it's about 500us. This shortcut makes it 20us. > --- > src/mesa/main/teximage.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

Am 16.12.2015 um 17:39 schrieb Marek Olšák: > On Wed, Dec 16, 2015 at 5:18 PM, Roland Scheidegger > wrote: >> Am 16.12.2015 um 12:52 schrieb Marek Olšák: >>> This is not well defined in gallium, but r600g and radeonsi use these >>> default swizzles for depth and stencil surfaces and it's probably

Re: [Mesa-dev] [PATCH 8/9] nir: move to compiler

On 16 December 2015 at 01:13, Jason Ekstrand wrote: > On Sat, Nov 28, 2015 at 8:45 AM, Emil Velikov > wrote: >> On 27 November 2015 at 20:45, Jason Ekstrand wrote: >>> On Nov 27, 2015 11:26 AM, "Matt Turner" wrote: On Fri, Nov 27, 2015 at 6:50 AM, Emil Velikov wrote: > On 25 No

Re: [Mesa-dev] [PATCH] Revert "i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals"

Ack On Dec 16, 2015 6:53 AM, "Neil Roberts" wrote: > This reverts commit 839793680f99b8387bee9489733d5071c10f3ace. > > The patch was breaking DRI3 because driGLFormatToImageFormat does not > handle MESA_FORMAT_B8G8R8X8_SRGB which ended up making it fail to > create the renderbuffer and it would l

Re: [Mesa-dev] [PATCH] Add .mailmap

On Wed, Dec 16, 2015 at 4:38 PM, Brian Paul wrote: > On 12/16/2015 08:24 AM, Giuseppe Bilotta wrote: >> >> >> Thanks. I'll move them (maybe put a comment to remark it's not 100% >> sure). The other root@ are most probably Brian, I'll move them there >> (again with the comment). > > > I found three

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

On Wed, Dec 16, 2015 at 6:52 AM, Marek Olšák wrote: > This is not well defined in gallium, but r600g and radeonsi use these > default swizzles for depth and stencil surfaces and it's probably the > only reasonable thing to do: > > Format = Default swizzle > Z24X8 = (Z) > Z24S8 = (Z) > X2

[Mesa-dev] Build failed: mesa 132

Build mesa 132 failed Commit 61cdb7665f by Neil Roberts on 12/16/2015 2:53 PM: Revert "i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals"\n\nThis reverts commit 839793680f99b8387bee9489733d5071c10f3ace.\n\nThe patch was breaking DRI3 because driGLFormatToImag

Re: [Mesa-dev] [PATCH 1/7] mesa/vbo: Add draw_id field to struct _mesa_prim

On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: > The drivers will need this for passing in gl_DrawIDARB. For indirect > multidraw calls, we get the prim array and prim[i].draw_id == i and is > redundant. But for non-indirect calls, we get one primitive at a time > and need the draw_id

[Mesa-dev] [PATCH] glsl: Remove inverse() from GLSL 1.20 and 1.30.

I apparently regressed this in 722eff674b832e2321f791c68358ef52d2a1ff25. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93387 Signed-off-by: Kenneth Graunke --- src/glsl/builtin_functions.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/glsl/builti

Re: [Mesa-dev] Build failed: mesa 132

No spurious build failures for a whole week, and as soon as I re-enable notifications we get one... :( This is different from the winflexbison issue. It's te=he: "Failed to provision build worker virtual machine in Google Compute Engine cloud. Try restarting build later." that happened on

Re: [Mesa-dev] Build failed: mesa 132

Seems like the likelihood of false positives is correlated with the number of people being notified :) On Wed, Dec 16, 2015 at 1:11 PM, Jose Fonseca wrote: > No spurious build failures for a whole week, and as soon as I re-enable > notifications we get one... :( > > This is different from the win

Re: [Mesa-dev] [PATCH] glsl: Remove inverse() from GLSL 1.20 and 1.30.

Reviewed-by: Ilia Mirkin Commit 7ddc312c1b2c61 may be the more relevant one to mention, or perhaps 76d2f73643f which actually switched over. On Wed, Dec 16, 2015 at 1:07 PM, Kenneth Graunke wrote: > I apparently regressed this in 722eff674b832e2321f791c68358ef52d2a1ff25. > > Bugzilla: https://b

Re: [Mesa-dev] [PATCH 7/8] nir: Silence unused parameter warnings

On Monday, December 14, 2015 03:34:31 PM Ian Romanick wrote: > From: Ian Romanick > > Number of total warnings in my build reduced from 1485 to 1476 > (reduction of 9). > > Signed-off-by: Ian Romanick > --- > src/glsl/nir/glsl_to_nir.cpp | 2 +- > src/glsl/nir/nir.c

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

On Monday, December 14, 2015 03:34:25 PM Ian Romanick wrote: > From: Ian Romanick > > nir/nir.h: In function 'nir_src_for_ssa': > nir/nir.h:552:4: warning: missing initializer for field 'use_link' of > 'nir_src' > [-Wmissing-field-initializers] > nir_src src = NIR_SRC_INIT; > ^ > In file

Re: [Mesa-dev] [PATCH 3/8] nir: Silence missing field initializer warnings for nir_alu_src

On Monday, December 14, 2015 03:34:27 PM Ian Romanick wrote: > From: Ian Romanick > > nir/nir_builder.h:234:4: warning: missing initializer for field 'use_link' of > 'n > ir_src' [-Wmissing-field-initializers] > nir_alu_src alu_src = { NIR_SRC_INIT }; > ^ > > Number of total warnings in

Re: [Mesa-dev] [PATCH 6/8] nir: Trivial clean ups in the generated nir_constant_expressions.c

On Monday, December 14, 2015 03:34:30 PM Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/glsl/nir/nir_constant_expressions.py | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/src/glsl/nir/nir_constant_expressions.py >

Re: [Mesa-dev] [PATCH v2] i965/gen8/cs: Gen8 requires 64 byte alignment for push constant data

On Wednesday, December 16, 2015 10:02:16 AM Iago Toral Quiroga wrote: > The BDW PRM Vol2a: Command Reference: Instructions, section MEDIA_CURBE_LOAD, > says that 'CURBE Total Data Length' and 'CURBE Data Start Address' are > 64-byte aligned. This is different from previous gens, that were 32-byte >

[Mesa-dev] [PATCH] util/macros: Simplify DIV_ROUND_UP() definition

From: Nanley Chery Commit 64880d073ab21ae1abad0c049ea2d6a1169a3cfa consolidated two DIV_ROUND_UP() definitions to one, but chose the more compute-intensive version in the process. Use the simpler version instead. Reduces .text size by 1360 bytes. Output of `size lib/i965_dri.so`: textd

[Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

From: Christian König Otherwise we might crash with MPV. Signed-off-by: Christian König --- src/gallium/state_trackers/va/buffer.c | 69 +- src/gallium/state_trackers/va/context.c| 6 +++ src/gallium/state_trackers/va/image.c | 68 +

[Mesa-dev] [PATCH 8/9] vl: use preferred format for deinterlacing

From: Christian König Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_deint_filter.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_deint_filter.c b/src/gallium/auxiliary/vl/vl_deint_filter.c index f919867..9e782e5 100644 -

[Mesa-dev] [PATCH 6/9] st/va: add BOB deinterlacing v2

From: Christian König Tested with MPV. v2: correctly handle compositor deinterlacing as well. Signed-off-by: Christian König --- src/gallium/state_trackers/va/postproc.c | 74 src/gallium/state_trackers/va/surface.c | 16 ++- 2 files changed, 79 insertion

[Mesa-dev] [PATCH 9/9] st/va: add motion adaptive deinterlacing

From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/context.c| 5 +++ src/gallium/state_trackers/va/postproc.c | 63 -- src/gallium/state_trackers/va/surface.c| 22 +-- src/gallium/state_trackers/va/va_private.h |

[Mesa-dev] [PATCH 5/9] st/va: add NV12 -> NV12 post processing v2

From: Christian König Usefull for mpv and GStreamer. v2: use common functionality for size adjustment. Signed-off-by: Indrajit-kumar Das Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture.c | 10 +- src/gallium/state_trackers/va/postproc.c | 151 ++

[Mesa-dev] [PATCH 7/9] vl: improve motion adaptive deinterlacer

From: Christian König Handle other formats than YV12 as well. Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_deint_filter.c | 69 +- src/gallium/auxiliary/vl/vl_deint_filter.h | 2 +- 2 files changed, 49 insertions(+), 22 deletions(-) diff --git a/

[Mesa-dev] [PATCH 4/9] st/va: use vl_video_buffer_adjust_size

From: Christian König Use the new helper function instead of open coding it. Signed-off-by: Christian König --- src/gallium/state_trackers/va/image.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_tra

[Mesa-dev] [PATCH 3/9] st/vdpau: use vl_video_buffer_adjust_size

From: Christian König Use the new helper function instead of open coding it. Signed-off-by: Christian König --- src/gallium/state_trackers/vdpau/surface.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/vdpau/surface.c b/src/galliu

[Mesa-dev] [PATCH 2/9] vl/buffers: extract vl_video_buffer_adjust_size helper

From: Christian König Useful for the state trackers as well. Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_video_buffer.c | 10 ++ src/gallium/auxiliary/vl/vl_video_buffer.h | 18 ++ 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/src/ga

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

> -Original Message- > From: Kristian Høgsberg [mailto:hoegsb...@gmail.com] > Sent: Tuesday, December 15, 2015 4:09 AM > To: Song, Ruiling ; k...@bitplanet.net; Winiarski, > Michal > Cc: intel-...@lists.freedesktop.org; mesa-dev@lists.freedesktop.org; Ben > Widawsky ; dri-de...@lists.fre

Re: [Mesa-dev] [PATCH 3/7] i965: Assert that SYSTEM_VALUE_VERTEX_ID gets lowered

Ian Romanick writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> fs_visitor::emit_vs_system_value() looks like it's trying to handle >> SYSTEM_VALUE_VERTEX_ID, but we should never see that value in the >> backend. >> --- >> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1 +

Re: [Mesa-dev] [PATCH 2/7] mesa: Add core mesa support for GL_ARB_shader_draw_parameters

Ian Romanick writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> --- >> src/glsl/builtin_variables.cpp | 5 + >> src/glsl/glsl_parser_extras.cpp | 1 + >> src/glsl/glsl_parser_extras.h | 2 ++ >> src/glsl/nir/nir.c | 8 >> src

Re: [Mesa-dev] [PATCH 4/7] i965: Add support for gl_BaseVertexARB and gl_BaseInstanceARB

Ian Romanick writes: > This patch is really doing two different things. It changes the > existing SYSTEM_VALUE_BASE_VERTEX to be independent from > SYSTEM_VALUE_VERTEX_ID_ZERO. It also adds SYSTEM_VALUE_BASE_INSTANCE > support. > > I was going to let that go, but because the two things happened

Re: [Mesa-dev] [PATCH 8/9] nir: move to compiler

On Wed, Dec 16, 2015 at 8:53 AM, Emil Velikov wrote: > On 16 December 2015 at 01:13, Jason Ekstrand wrote: >> On Sat, Nov 28, 2015 at 8:45 AM, Emil Velikov >> wrote: >>> On 27 November 2015 at 20:45, Jason Ekstrand wrote: On Nov 27, 2015 11:26 AM, "Matt Turner" wrote: > On Fri, Nov 2

[Mesa-dev] [PATCH] nvc0: fix metric-achieved_occupancy calculation on Kepler

The maximum number of resident warps per multiprocessor is 64 on Kepler instead of 48 on Fermi. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_metric.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0

Re: [Mesa-dev] [PATCH 4/8] nir: Silence missing field initializer warnings for vectors in nir_constant_expressions

On Monday, December 14, 2015 03:34:28 PM Ian Romanick wrote: > From: Ian Romanick > > nir/nir_constant_expressions.c: In function 'evaluate_ball2': > nir/nir_constant_expressions.c:279:7: warning: missing initializer for field > 'z' of 'struct bool_vec' [-Wmissing-field-initializers] >};

Re: [Mesa-dev] [PATCH 8/9] nir: move to compiler

On 16 December 2015 at 20:24, Matt Turner wrote: > On Wed, Dec 16, 2015 at 8:53 AM, Emil Velikov > wrote: >> On 16 December 2015 at 01:13, Jason Ekstrand wrote: >>> On Sat, Nov 28, 2015 at 8:45 AM, Emil Velikov >>> wrote: On 27 November 2015 at 20:45, Jason Ekstrand wrote: > On Nov

[Mesa-dev] [PATCH] nvc0: free memory allocated by the prog which reads MP perf counters

This fixes a long time ago memory leak (even before all my query related changes). Signed-off-by: Samuel Pitoiset --- I just notified this by running 'valgrind --leak-check=yes' while monitoring some performance counters on my GF119. src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + 1 file

Re: [Mesa-dev] [PATCH] nvc0: free memory allocated by the prog which reads MP perf counters

Reviewed-by: Ilia Mirkin Cc: "11.0 11.1" On Wed, Dec 16, 2015 at 3:51 PM, Samuel Pitoiset wrote: > This fixes a long time ago memory leak (even before all my query > related changes). > > Signed-off-by: Samuel Pitoiset > --- > > I just notified this by running 'valgrind --leak-check=yes' while

Re: [Mesa-dev] [PATCH 5/8] nir: Silence unused parameter warnings in nir_constant_expression.c

On Dec 14, 2015 3:34 PM, "Ian Romanick" wrote: > > From: Ian Romanick > > nir/nir_constant_expressions.c:290:25: warning: unused parameter 'num_components' [-Wunused-parameter] > evaluate_ball3(unsigned num_components, nir_const_value *_src) > ^ > nir/nir_constant_expres

Re: [Mesa-dev] [PATCH v3] nv50, nvc0: optimize coherent buffer checking at draw time

On Thu, Dec 10, 2015 at 4:58 PM, Samuel Pitoiset wrote: > Instead of iterating over all the buffer resources looking for coherent > buffers, we keep track of a context-wide count. This will save some > iterations (and CPU cycles) in 99.99% case because usually coherent > buffers are not so used. >

Re: [Mesa-dev] [PATCH 4/8] nir: Silence missing field initializer warnings for vectors in nir_constant_expressions

On Dec 16, 2015 12:36 PM, "Kenneth Graunke" wrote: > > On Monday, December 14, 2015 03:34:28 PM Ian Romanick wrote: > > From: Ian Romanick > > > > nir/nir_constant_expressions.c: In function 'evaluate_ball2': > > nir/nir_constant_expressions.c:279:7: warning: missing initializer for field 'z' of

Re: [Mesa-dev] [PATCH 3/5] main/version: Don't require ARB_compute_shader for OpenGLES 3.1

On Tue, Dec 15, 2015 at 8:45 PM, Ian Romanick wrote: > On 12/15/2015 05:01 PM, Jordan Justen wrote: >> On 2015-12-15 16:50:39, Ian Romanick wrote: >>> On 12/15/2015 04:08 PM, Jordan Justen wrote: The OpenGL ARB_compute_shader extension specfication requires at least 1024 for GL_MAX_COMPU

[Mesa-dev] [PATCH] nv50, nvc0: free memory allocated by performance metrics

The destroy_query() helper was actually never called. This fixes a memory leak while monitoring performance metrics. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query_hw.c| 6 ++ src/gallium/drivers/nouveau/nv50/nv50_query_hw_metric.c | 3 ++- src/gallium

Re: [Mesa-dev] [PATCH] nv50, nvc0: free memory allocated by performance metrics

Acked-by: Ilia Mirkin This conditional stuff is very confusing but... meh. On Wed, Dec 16, 2015 at 4:47 PM, Samuel Pitoiset wrote: > The destroy_query() helper was actually never called. This fixes > a memory leak while monitoring performance metrics. > > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [PATCH] nv50: free memory allocated by the prog which reads MP perf counters

This fixes a memory leak introduced in 6a9c151 ("nv50: add compute-related MP perf counters on G84+") Untested patch, but it's exactly the same code as nvc0. Signed-off-by: Samuel Pitoiset Cc: "11.1" --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 5 + 1 file changed, 5 insertions(+)

Re: [Mesa-dev] [PATCH 1/2] osmesa: add new OSMesaCreateContextAttribs function

On 16/12/15 00:59, Brian Paul wrote: This allows specifying a GL profile and version so one can get a core- profile context. --- docs/relnotes/11.2.0.html| 2 + include/GL/osmesa.h | 45 - src/mesa/drivers/osmesa/osmesa.c | 104 +

Re: [Mesa-dev] [PATCH] nv50: free memory allocated by the prog which reads MP perf counters

If someone want to try this patch: GALLIUM_HUD="instructions" valgrind --leak-check=yes glxgears Thanks! On 12/16/2015 10:54 PM, Samuel Pitoiset wrote: This fixes a memory leak introduced in 6a9c151 ("nv50: add compute-related MP perf counters on G84+") Untested patch, but it's exactly the sam

Re: [Mesa-dev] [PATCH 3/5] main/version: Don't require ARB_compute_shader for OpenGLES 3.1

On 2015-12-16 13:27:07, Ilia Mirkin wrote: > On Tue, Dec 15, 2015 at 8:45 PM, Ian Romanick wrote: > > On 12/15/2015 05:01 PM, Jordan Justen wrote: > >> On 2015-12-15 16:50:39, Ian Romanick wrote: > >>> On 12/15/2015 04:08 PM, Jordan Justen wrote: > The OpenGL ARB_compute_shader extension spec

Re: [Mesa-dev] [PATCH 3/5] main/version: Don't require ARB_compute_shader for OpenGLES 3.1

On Wed, Dec 16, 2015 at 5:02 PM, Jordan Justen wrote: > On 2015-12-16 13:27:07, Ilia Mirkin wrote: >> On Tue, Dec 15, 2015 at 8:45 PM, Ian Romanick wrote: >> > On 12/15/2015 05:01 PM, Jordan Justen wrote: >> >> On 2015-12-15 16:50:39, Ian Romanick wrote: >> >>> On 12/15/2015 04:08 PM, Jordan Just

Re: [Mesa-dev] [PATCH 8/9] nir: move to compiler

On Wed, Dec 16, 2015 at 12:51 PM, Emil Velikov wrote: > On 16 December 2015 at 20:24, Matt Turner wrote: >> On Wed, Dec 16, 2015 at 8:53 AM, Emil Velikov >> wrote: >>> On 16 December 2015 at 01:13, Jason Ekstrand wrote: On Sat, Nov 28, 2015 at 8:45 AM, Emil Velikov wrote: > On

Re: [Mesa-dev] [PATCH 3/8] nir: Silence missing field initializer warnings for nir_alu_src

On Wed, Dec 16, 2015 at 11:12 AM, Kenneth Graunke wrote: > On Monday, December 14, 2015 03:34:27 PM Ian Romanick wrote: >> From: Ian Romanick >> >> nir/nir_builder.h:234:4: warning: missing initializer for field 'use_link' >> of 'n >> ir_src' [-Wmissing-field-initializers] >> nir_alu_src alu

Re: [Mesa-dev] [PATCH 2/2] main: get rid of needless conditional

On Wed, 2015-12-16 at 17:09 +0100, Erik Faye-Lund wrote: > We already check if the driver changed the completeness, we don't > need to duplicate that check. Let's just early out there instead. > > Signed-off-by: Erik Faye-Lund > Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

On Wed, Dec 16, 2015 at 5:28 PM, Miklós Máté wrote: >>> + if (srcReg->argMod & GL_NEGATE_BIT_ATI) { >>> + struct ureg_src modsrc[2]; >>> + modsrc[0] = ureg_src(arg); >>> + modsrc[1] = ureg_imm1f(t->ureg, -1.0); >>> + >>> + emit_insn(t, TGSI_OPCODE_MUL, &arg, 1, modsrc, 2); >>

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: > + } else if (desc->special == 3) { > + src[0] = args[0]; > + src[1] = args[1]; > + src[2] = ureg_swizzle(args[2], > +TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z); > + emit_insn(t, TGSI_OPCODE

[Mesa-dev] [Bug 92945] [llvmpipe] [softpipe] piglit fs-ldexp-dvec4 regression

https://bugs.freedesktop.org/show_bug.cgi?id=92945 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2] i965/gen8/cs: Gen8 requires 64 byte alignment for push constant data

On 2015-12-16 11:39:00, Kenneth Graunke wrote: > On Wednesday, December 16, 2015 10:02:16 AM Iago Toral Quiroga wrote: > > The BDW PRM Vol2a: Command Reference: Instructions, section > > MEDIA_CURBE_LOAD, > > says that 'CURBE Total Data Length' and 'CURBE Data Start Address' are > > 64-byte aligne

Re: [Mesa-dev] [PATCH] docs: add freedreno to GL3.txt

On Sun, Nov 29, 2015 at 3:16 PM, Ian Romanick wrote: > On 11/24/2015 12:37 PM, Ilia Mirkin wrote: >> The Adreno A4xx GPU should be capable of a large fraction if not >> all of the desktop GL 4.5 features. >> >> Signed-off-by: Ilia Mirkin >> --- >> docs/GL3.txt | 70 >> ++

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

Am 16.12.2015 um 23:40 schrieb Ilia Mirkin: > On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: >> + } else if (desc->special == 3) { >> + src[0] = args[0]; >> + src[1] = args[1]; >> + src[2] = ureg_swizzle(args[2], >> +TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z,

Re: [Mesa-dev] [PATCH 7/7] i965: Reduce vertex state reemission

Ian Romanick writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> We can inspect VS prog_data for iterations i > 0, and only flag >> BRW_NEW_VERTICES when one of our system values change. >> >> This change also flags BRW_NEW_VERTICES in one case we were missing >> before: if

[Mesa-dev] [PATCH v2 1/7] mesa/vbo: Add draw_id field to struct _mesa_prim

From: Kristian Høgsberg Kristensen The drivers will need this for passing in gl_DrawIDARB. For indirect multidraw calls, we get the prim array and prim[i].draw_id == i and is redundant. But for non-indirect calls, we get one primitive at a time and need the draw_id field. Reviewed-by: Anuj Phoga

[Mesa-dev] [PATCH v2 5/7] i965: Add support for gl_DrawIDARB and enable extension

From: Kristian Høgsberg Kristensen We have to break open a new vec4 for gl_DrawIDARB. We've used up all space in the vec4 we use for SGVS and gl_DrawIDARB has to come from its own separate vertex buffer anyway. This is because we point the vb for base vertex and base instance into the draw param

[Mesa-dev] [PATCH v2 3/7] i965: Assert that SYSTEM_VALUE_VERTEX_ID gets lowered

From: Kristian Høgsberg Kristensen fs_visitor::emit_vs_system_value() looks like it's trying to handle SYSTEM_VALUE_VERTEX_ID, but we should never see that value in the backend. Reviewed-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1 + 1 file changed, 1 insertion(+) dif

[Mesa-dev] [PATCH v2 0/7] GL_ARB_shader_draw_parameters

From: Kristian Høgsberg Kristensen Here's v2 of the GL_ARB_shader_draw_parameters series. I fixed up the rebase damage and moved the flagging of BRW_NEW_VERTICES for gl_DrawIDARB into the commit that adds that builtin. Kristian Kristian Høgsberg Kristensen (7): mesa/vbo: Add draw_id field to

[Mesa-dev] [PATCH v2 6/7] nir: Teach nir_opt_algebraic about adding and subtracting the same thing

From: Kristian Høgsberg Kristensen This optimizes a + b - b to just a. Modest shader-db results (BDW): total instructions in shared programs: 7842452 -> 7841862 (-0.01%) instructions in affected programs: 61938 -> 61348 (-0.95%) total loops in shared programs:2131 -> 2131 (0.00

[Mesa-dev] [PATCH v2 2/7] mesa: Add core mesa support for GL_ARB_shader_draw_parameters

From: Kristian Høgsberg Kristensen Reviewed-by: Anuj Phogat --- src/glsl/builtin_variables.cpp | 5 + src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/glsl/nir/nir.c | 8 src/glsl/nir/nir_intrinsics.h | 2 ++

  1   2   >