[Mesa-dev] [PATCH 0/2] Add a SSBO load optimization pass

The general idea of this optimization is explained in the commit log of the first patch, but it basically allows to re-use the results of previous SSBO loads in situations that should be safe instead of issuing a new SSBO load every time. Makes the following shader: buffer SSBO { mat4 sm4; };

[Mesa-dev] [PATCH 2/2] i965: Use the ssbo load cache optimization

We only really want to do this once since no passes other than lower_ubo_reference can inject ssbo loads in the IR. We want to run this late after other optimizations have kicked in to maximize the chances of seeing constants for block and offset arguments to the ssbo loads (since these are the one

[Mesa-dev] [PATCH 1/2] glsl: Implement a SSBO load optimization pass

This allows us to re-use the results of previous ssbo loads in situations that are safe (i.e. when there are no stores, atomic operations or memory barriers in between). This is particularly useful for things like matrix multiplications, where for a mat4 buffer variable we cut the number of loads

[Mesa-dev] [PATCH] i965/fs: Disable CSE optimization for untyped & typed surface reads

An untyped surface read is volatile because it might be affected by a write. In the ES31-CTS.compute_shader.resources-max test, two back to back read/modify/writes of an SSBO variable looked something like this: r1 = untyped_surface_read(ssbo_float) r2 = r1 + 1 untyped_surface_write(ssbo_fl

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

https://bugs.freedesktop.org/show_bug.cgi?id=92552 Bug ID: 92552 Summary: [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression Product: Mesa Version: git Hardware: x86-64 (AMD

Re: [Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

On 17.10.2015 22:09, Marek Olšák wrote: > From: Marek Olšák > > All tests pass. We don't need to do much - just set CUBE if the view > target is CUBE or CUBE_ARRAY, otherwise set the resource target. > > The reason this is so simple can be that texture instructions > have a greater effect on the

Re: [Mesa-dev] [PATCH] i965/fs: Disable CSE optimization for untyped & typed surface reads

On Tue, 2015-10-20 at 00:12 -0700, Jordan Justen wrote: > An untyped surface read is volatile because it might be affected by a > write. > > In the ES31-CTS.compute_shader.resources-max test, two back to back > read/modify/writes of an SSBO variable looked something like this: > > r1 = untyped_

Re: [Mesa-dev] [PATCH 1/3] i965: Don't use message headers for typed/untyped reads

On 2015-10-19 12:23:27, Kristian Høgsberg wrote: > On Mon, Oct 19, 2015 at 3:19 AM, Francisco Jerez > wrote: > > Hey Kristian, > > > > Kristian Høgsberg Kristensen writes: > > > >> We always set the mask to 0x, which is what it defaults to when no > >> header is present. Let's drop the heade

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

I wrote a similar patch a while back because I was annoyed by how this was causing the send disassembly to not be as nice. :) I dropped it from my branch at some point, but I still think it is a good idea. Reviewed-by: Jordan Justen On 2015-10-18 21:31:43, Kristian Høgsberg Kristensen wrote: > A

Re: [Mesa-dev] [PATCH 2/7] i965/gen9: Don't call tr_mode_vertical_texture_alignment() for 1D textures

On Mon, Oct 19, 2015 at 02:29:04PM -0700, Anuj Phogat wrote: > On Thu, Aug 13, 2015 at 2:51 PM, Anuj Phogat wrote: > > Vertical alignment is not applicable to 1D textures. > > > > Signed-off-by: Anuj Phogat > > --- > > src/mesa/drivers/dri/i965/brw_tex_layout.c | 4 +++- > > 1 file changed, 3 in

Re: [Mesa-dev] [PATCH 1/9] i965/vec4: Don't emit MOVs for unused URB slots.

On Mon, 2015-10-19 at 21:08 -0700, Matt Turner wrote: > Otherwise we'd emit a MOV from the null register (which isn't allowed). > > Helps 24 programs in shader-db (the geometry shaders in GSCloth): > > instructions in affected programs: 302 -> 262 (-13.25%) Makes sense to me, Reviewed-by: I

Re: [Mesa-dev] [PATCH 1/4] radeonsi: link ES-GS just like LS-HS

On 19.10.2015 02:13, Marek Olšák wrote: > From: Marek Olšák > > This reduces the shader key for ES. > > Use a fixed attrib location based on (semantic name, index). > > The ESGS item size is determined by the physical index of the highest ES > output, so it's almost always larger than before,

Re: [Mesa-dev] [PATCH] i915/aa: fixing anti-aliasing bug for thinnest width lines

> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Monday, October 19, 2015 6:04 PM > To: Predut, Marius > Cc: mesa-dev@lists.freedesktop.org; Iago Toral Quiroga > Subject: Re: [Mesa-dev] [PATCH] i915/aa: fixing anti-aliasing bug for thinnest > width l

Re: [Mesa-dev] [PATCH 2/9] i965/vec4: Initialize LOD to 0.0f.

On Mon, 2015-10-19 at 23:11 -0700, Matt Turner wrote: > On Mon, Oct 19, 2015 at 9:09 PM, Matt Turner wrote: > > We implement textureQueryLevels (which takes no arguments, save the > > sampler) using the resinfo message (which takes an argument of LOD). > > Without initializing it, we'd generate a

Re: [Mesa-dev] Fuzz testing the stand alone glsl compiler

Steve Lynch writes: > Hi, > > I've been using afl (http://lcamtuf.coredump.cx/afl/) on the standalone > glsl compiler. > > It found four different crashes in the latest code in master and I have > minimised the test cases that cause the crashes. I spent a couple of hours > poking around but haven

Re: [Mesa-dev] [PATCH 3/9] i965: Add devinfo parameter to brw_compact_inst_* funcs.

Reviewed-by: Iago Toral Quiroga On Mon, 2015-10-19 at 21:09 -0700, Matt Turner wrote: > The next commit will add assertions dependent on devinfo->gen. > > Use compact()/uncompact() macros where possible, like the 3-src code > does. > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 118 > +++

Re: [Mesa-dev] [PATCH 4/9] i965: Compact acc_wr_control only on Gen6+.

On Mon, 2015-10-19 at 21:09 -0700, Matt Turner wrote: > It only exists on Gen6+, and the next patches will add compaction > support for the (unused) field in the same location on earlier > platforms. The docs say that this exists also in ILK at least. See Page 131 of: https://01.org/sites/default/

Re: [Mesa-dev] [PATCH 2/2] vc4: Use nir_foreach_variable

Boyan Ding writes: > Signed-off-by: Boyan Ding > --- > src/gallium/drivers/vc4/vc4_nir_lower_blend.c | 2 +- > src/gallium/drivers/vc4/vc4_nir_lower_io.c| 4 ++-- > src/gallium/drivers/vc4/vc4_program.c | 8 > 3 files changed, 7 insertions(+), 7 deletions(-) Pushed the vc4

[Mesa-dev] [PATCH 1/2] i965: Remove block arg from foreach_inst_in_block_*_starting_from

Since 49374fab5d793 these macros no longer actually use the block argument. I think this is worth doing to make the macros easier to use because they already have really long names and a confusing set of arguments. --- src/mesa/drivers/dri/i965/brw_cfg.h | 4 ++-- src/mesa/dr

[Mesa-dev] [PATCH 2/2] i965/fs: Improve search for the argument source in opt_zero_samples

The opt_zero_samples instruction tries to find the corresponding load_payload instruction for each sample instruction. However it was previously only looking at the previous instruction. This patch makes it search back within the block to whatever was the last instruction to write to each individua

[Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

UniformRemapTable is used only for remapping user specified uniform locations to driver internally used ones, shader storage buffer variables should not utilize uniform locations. Signed-off-by: Tapani Pälli --- src/glsl/link_uniforms.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

[Mesa-dev] [PATCH 2/3] glsl: do not try to reserve explicit locations for buffer variables

Explicit locations are only used with uniform variables. Signed-off-by: Tapani Pälli --- src/glsl/linker.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 25ca928..481481b 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/li

[Mesa-dev] [PATCH 3/3] glsl: fix record type detection in explicit location assign

Check current_var directly instead of using the passed in record_type. This fixes following failing CTS test: ES31-CTS.explicit_uniform_location.uniform-loc-types-structs No Piglit regressions. Signed-off-by: Tapani Pälli --- src/glsl/link_uniforms.cpp | 2 +- 1 file changed, 1 inserti

[Mesa-dev] [PATCH] i965/fs: Disable opt_sampler_eot for more message types

In bfdae9149e0 I disabled the opt_sampler_eot optimisation for TG4 message types because I found by experimentation that it doesn't work. I wrote in the comment that I couldn't find any documentation for this problem. However I've now found the documentation and it has additional restrictions on fu

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

If you also remove the uniforms[i].array_elements in the same manner, the assert in: ES31-CTS.explicit_uniform_location.uniform-loc-arrays-of-arrays Is also avoided. > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tapani Pälli > Sent:

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

Kristian Høgsberg writes: > On Mon, Oct 19, 2015 at 4:19 AM, Francisco Jerez > wrote: >> Neil Roberts writes: >> >>> Just a thought, would it be better to move this check into the >>> eliminate_find_live_channel optimisation? That way it could catch >>> sources that become immediates through l

Re: [Mesa-dev] [PATCH 1/2] glsl: Implement a SSBO load optimization pass

Iago Toral Quiroga writes: > This allows us to re-use the results of previous ssbo loads in situations > that are safe (i.e. when there are no stores, atomic operations or > memory barriers in between). > > This is particularly useful for things like matrix multiplications, where > for a mat4 buf

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

On 10/20/2015 01:11 PM, Lofstedt, Marta wrote: If you also remove the uniforms[i].array_elements in the same manner, the assert in: ES31-CTS.explicit_uniform_location.uniform-loc-arrays-of-arrays Is also avoided. Are you referring to one of the loops iterating uniforms in this same place t

Re: [Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

On Tue, Oct 20, 2015 at 9:42 AM, Michel Dänzer wrote: > On 17.10.2015 22:09, Marek Olšák wrote: >> From: Marek Olšák >> >> All tests pass. We don't need to do much - just set CUBE if the view >> target is CUBE or CUBE_ARRAY, otherwise set the resource target. >> >> The reason this is so simple ca

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

> -Original Message- > From: Palli, Tapani > Sent: Tuesday, October 20, 2015 12:25 PM > To: Lofstedt, Marta; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling > UniformRemapTable > > > > On 10/20/2015 01:11 PM, Lofstedt, Marta w

Re: [Mesa-dev] [RFCv0 0/8] gallium: add support for NIR as alternate IR

On Tue, Oct 20, 2015 at 3:51 AM, Rob Clark wrote: > On Mon, Oct 19, 2015 at 8:53 PM, Marek Olšák wrote: >> Yes, drivers need to "dup" tokens if they want to keep them. Their >> lifetime is the create function and that's it. st/mesa only keeps the >> tokens for vertex shaders, because it needs for

Re: [Mesa-dev] [PATCH 1/2] glsl: Implement a SSBO load optimization pass

On Tue, 2015-10-20 at 13:22 +0300, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > This allows us to re-use the results of previous ssbo loads in situations > > that are safe (i.e. when there are no stores, atomic operations or > > memory barriers in between). > > > > This is particular

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

On 10/20/2015 01:40 PM, Lofstedt, Marta wrote: -Original Message- From: Palli, Tapani Sent: Tuesday, October 20, 2015 12:25 PM To: Lofstedt, Marta; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable On 10/20/2

Re: [Mesa-dev] [PATCH] i915/aa: fixing anti-aliasing bug for thinnest width lines

On Tue, Oct 20, 2015 at 08:15:32AM +, Predut, Marius wrote: > > -Original Message- > > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > > Sent: Monday, October 19, 2015 6:04 PM > > To: Predut, Marius > > Cc: mesa-dev@lists.freedesktop.org; Iago Toral Quiroga > > Subject: Re:

Re: [Mesa-dev] [PATCH 1/2] glsl: Implement a SSBO load optimization pass

Iago Toral writes: > On Tue, 2015-10-20 at 13:22 +0300, Francisco Jerez wrote: >> Iago Toral Quiroga writes: >> >> > This allows us to re-use the results of previous ssbo loads in situations >> > that are safe (i.e. when there are no stores, atomic operations or >> > memory barriers in between)

Re: [Mesa-dev] [PATCH 1/2] glsl: Implement a SSBO load optimization pass

On Tue, 2015-10-20 at 14:18 +0300, Francisco Jerez wrote: > Iago Toral writes: > > > On Tue, 2015-10-20 at 13:22 +0300, Francisco Jerez wrote: > >> Iago Toral Quiroga writes: > >> > >> > This allows us to re-use the results of previous ssbo loads in situations > >> > that are safe (i.e. when th

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

> -Original Message- > From: Palli, Tapani > Sent: Tuesday, October 20, 2015 12:55 PM > To: Lofstedt, Marta; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling > UniformRemapTable > > > > On 10/20/2015 01:40 PM, Lofstedt, Marta w

Re: [Mesa-dev] [RFCv0 0/8] gallium: add support for NIR as alternate IR

On Tue, Oct 20, 2015 at 6:49 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 3:51 AM, Rob Clark wrote: >> On Mon, Oct 19, 2015 at 8:53 PM, Marek Olšák wrote: >>> Yes, drivers need to "dup" tokens if they want to keep them. Their >>> lifetime is the create function and that's it. st/mesa only ke

Re: [Mesa-dev] [RFCv0 0/8] gallium: add support for NIR as alternate IR

On Tue, Oct 20, 2015 at 2:37 PM, Rob Clark wrote: > On Tue, Oct 20, 2015 at 6:49 AM, Marek Olšák wrote: >> On Tue, Oct 20, 2015 at 3:51 AM, Rob Clark wrote: >>> On Mon, Oct 19, 2015 at 8:53 PM, Marek Olšák wrote: Yes, drivers need to "dup" tokens if they want to keep them. Their lifet

Re: [Mesa-dev] [Mesa-stable] [RFC 01/21] mesa/texcompress: Restrict FXT1 format to desktop GL subset

On 10/19/2015 05:36 PM, Nanley Chery wrote: > From: Nanley Chery > > In agreement with the extension spec and commit > dd0eb004874645135b9aaac3ebbd0aaf274079ea, filter FXT1 formats to the > desktop GL profiles. Now we no longer advertise such formats as supported > in an ES context and then throw

Re: [Mesa-dev] [PATCH 2/4] gallium: add new properties for clip and cull distance usage

Am 19.10.2015 um 23:44 schrieb Marek Olšák: > On Mon, Oct 19, 2015 at 11:31 PM, Roland Scheidegger > wrote: >> Yes, but I still don't see much change from getting this information >> from the property rather than how tgsi_scan does it now, which is by >> just using the usage mask from the output

Re: [Mesa-dev] [RFC 01/21] mesa/texcompress: Restrict FXT1 format to desktop GL subset

On 10/19/2015 05:58 PM, Nanley Chery wrote: > > > On Mon, Oct 19, 2015 at 3:47 PM, Ilia Mirkin > wrote: > > On Mon, Oct 19, 2015 at 6:36 PM, Nanley Chery > wrote: > > From: Nanley Chery

Re: [Mesa-dev] [PATCH 4/9] i965: Compact acc_wr_control only on Gen6+.

On Tue, 2015-10-20 at 10:51 +0200, Iago Toral wrote: > On Mon, 2015-10-19 at 21:09 -0700, Matt Turner wrote: > > It only exists on Gen6+, and the next patches will add compaction > > support for the (unused) field in the same location on earlier > > platforms. > > The docs say that this exists als

Re: [Mesa-dev] [PATCH 2/4] gallium: add new properties for clip and cull distance usage

On Tue, Oct 20, 2015 at 3:25 PM, Roland Scheidegger wrote: > Am 19.10.2015 um 23:44 schrieb Marek Olšák: >> On Mon, Oct 19, 2015 at 11:31 PM, Roland Scheidegger >> wrote: >>> Yes, but I still don't see much change from getting this information >>> from the property rather than how tgsi_scan does

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

Series is Reviewed-by: Samuel Iglesias Gonsálvez Thanks, Sam On 20/10/15 11:24, Tapani Pälli wrote: > UniformRemapTable is used only for remapping user specified uniform > locations to driver internally used ones, shader storage buffer > variables should not utilize uniform locations. > > Sig

Re: [Mesa-dev] [PATCH 8/9] i965: Add const to brw_compact_inst_bits.

Reviewed-by: Iago Toral Quiroga On Mon, 2015-10-19 at 21:09 -0700, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_inst.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_inst.h > b/src/mesa/drivers/dri/i965/brw_inst.h > index

Re: [Mesa-dev] [PATCH 9/9] i965: Mark compacted 3-src instructions as Gen8+.

Reviewed-by: Iago Toral Quiroga On Mon, 2015-10-19 at 21:09 -0700, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_inst.h | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_inst.h > b/src/mesa/drive

[Mesa-dev] [PATCH 3/4] mesa: Draw Indirect return wrong error code on unalinged

From: Marta Lofstedt From OpenGL 4.4 specification, section 10.4 and Open GL Es 3.1 section 10.5: "An INVALID_VALUE error is generated if indirect is not a multiple of the size, in basic machine units, of uint." However, the current code follow the ARB_draw_indirect: https://www.opengl.org/regis

[Mesa-dev] [PATCH 4/4] mesa: Draw indirect is not allowed when xfb is active and unpaused

From: Marta Lofstedt OpenGL ES 3.1 specification, section 10.5: "An INVALID_OPERATION error is generated if transform feedback is active and not paused." Signed-off-by: Marta Lofstedt --- src/mesa/main/api_validate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/ap

[Mesa-dev] [PATCH 0/4] Updates to Draw Indirect for OpenGL ES 3.1

This patchset fixes 7 API related tests of the OpenGL ES 3.1 CTS. I would consider squashing these into one patch, but to avoid confusion when we discuss my solution I preferr to keep the discussions separated for each patch for now. Marta Lofstedt (4): mesa: Draw indirect is not allowed if the

[Mesa-dev] [PATCH 1/4] mesa: Draw indirect is not allowed if the default VAO is bound.

From: Marta Lofstedt From OpenGL ES 3.1 specification, section 10.5: "DrawArraysIndirect requires that all data sourced for the command, including the DrawArraysIndirectCommand structure, be in buffer objects, and may not be called when the default vertex array object is bound." Signed-off-by:

[Mesa-dev] [PATCH 2/4] mesa: Draw Indirect is not allowed when no vertex array binding exists.

From: Marta Lofstedt OpenGL ES 3.1 spec. section 10.5: "An INVALID_OPERATION error is generated if zero is bound to VERTEX_ARRAY_BINDING, DRAW_INDIRECT_BUFFER or to any enabled vertex array." Signed-off-by: Marta Lofstedt --- src/mesa/main/api_validate.c | 14 ++ 1 file changed, 14

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote: > From: Nanley Chery > > - { "GL_SUN_multi_draw_arrays", o(dummy_true), > GLL,1999 }, > +#define EXT(name_str, driver_cap, api_flags, ) \ > +{ .name = "GL_" #name_str, .

Re: [Mesa-dev] [PATCH 2/4] gallium: add new properties for clip and cull distance usage

Am 20.10.2015 um 15:40 schrieb Marek Olšák: > On Tue, Oct 20, 2015 at 3:25 PM, Roland Scheidegger > wrote: >> Am 19.10.2015 um 23:44 schrieb Marek Olšák: >>> On Mon, Oct 19, 2015 at 11:31 PM, Roland Scheidegger >>> wrote: Yes, but I still don't see much change from getting this information

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

https://bugs.freedesktop.org/show_bug.cgi?id=92552 Boyan Ding changed: What|Removed |Added CC||ramix.ben.hass...@intel.com --- Comment #1

[Mesa-dev] [Bug 92536] [BSW] [Regrassion] piglit spec/egl_khr_create_context/valid forward-compatible flag gl fail

https://bugs.freedesktop.org/show_bug.cgi?id=92536 Boyan Ding changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

https://bugs.freedesktop.org/show_bug.cgi?id=92552 --- Comment #2 from Matthew Waters --- Created attachment 119006 --> https://bugs.freedesktop.org/attachment.cgi?id=119006&action=edit egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS This fixes that issue for me.

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund wrote: > On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote: >> From: Nanley Chery >> >> - { "GL_SUN_multi_draw_arrays", o(dummy_true), >>GLL,1999 }, >> +#define EXT(name_str, driver_

Re: [Mesa-dev] [RFCv0 0/8] gallium: add support for NIR as alternate IR

On Tue, Oct 20, 2015 at 9:10 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 2:37 PM, Rob Clark wrote: >> On Tue, Oct 20, 2015 at 6:49 AM, Marek Olšák wrote: >>> On Tue, Oct 20, 2015 at 3:51 AM, Rob Clark wrote: On Mon, Oct 19, 2015 at 8:53 PM, Marek Olšák wrote: > Yes, drivers need

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

Also, the FIXME comment should be on its own line. Marek On Tue, Oct 20, 2015 at 5:14 PM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund wrote: >> On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote: >>> From: Nanley Chery >>> >>> - { "GL_SUN_multi_draw_arrays",

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

https://bugs.freedesktop.org/show_bug.cgi?id=92552 --- Comment #3 from Matthew Waters --- Note: I don't have commit access so if this is good, then someone else has to push ;). -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [RFCv0 0/8] gallium: add support for NIR as alternate IR

On Tue, Oct 20, 2015 at 5:17 PM, Ilia Mirkin wrote: > On Tue, Oct 20, 2015 at 9:10 AM, Marek Olšák wrote: >> On Tue, Oct 20, 2015 at 2:37 PM, Rob Clark wrote: >>> On Tue, Oct 20, 2015 at 6:49 AM, Marek Olšák wrote: On Tue, Oct 20, 2015 at 3:51 AM, Rob Clark wrote: > On Mon, Oct 19, 20

Re: [Mesa-dev] [PATCH 1/4] mesa: Draw indirect is not allowed if the default VAO is bound.

On Tue, Oct 20, 2015 at 10:19 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > From OpenGL ES 3.1 specification, section 10.5: > "DrawArraysIndirect requires that all data sourced for the > command, including the DrawArraysIndirectCommand > structure, be in buffer objects, and may not be ca

Re: [Mesa-dev] [RFCv0 0/8] gallium: add support for NIR as alternate IR

On Tue, Oct 20, 2015 at 11:21 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 5:17 PM, Ilia Mirkin wrote: >> On Tue, Oct 20, 2015 at 9:10 AM, Marek Olšák wrote: >>> On Tue, Oct 20, 2015 at 2:37 PM, Rob Clark wrote: On Tue, Oct 20, 2015 at 6:49 AM, Marek Olšák wrote: > On Tue, Oct 20,

Re: [Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

On Sat, Oct 17, 2015 at 9:09 AM, Marek Olšák wrote: > + /* This is not needed if state trackers set last_layer correctly. */ > + if (state->target == PIPE_TEXTURE_1D || > + state->target == PIPE_TEXTURE_2D || > + state->target == PIPE_TEXTURE_RECT || > + s

Re: [Mesa-dev] [RFC 09/21] mesa: Generate a helper function for each extension

On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery wrote: > From: Nanley Chery > > Generate functions which determine if an extension is supported in the > current context. Initially, enums were going to be explicitly used with > _mesa_extension_supported(). The idea to embed the function and enums >

Re: [Mesa-dev] [RFC 15/21] mesa: Fix EXT_texture_sRGB functionality leaks

On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery wrote: > From: Nanley Chery > > Stop leaks into the following contexts: >* GLES in _mesa_base_tex_format() and lookup_view_class(). >* Pre-1.1 GL legacy contexts in all uses. Fixing OpenGL 1.0? Seriously? Come on. :) Marek _

Re: [Mesa-dev] [RFC 01/21] mesa/texcompress: Restrict FXT1 format to desktop GL subset

On Tue, Oct 20, 2015 at 6:26 AM, Ian Romanick wrote: > On 10/19/2015 05:58 PM, Nanley Chery wrote: > > > > > > On Mon, Oct 19, 2015 at 3:47 PM, Ilia Mirkin > > wrote: > > > > On Mon, Oct 19, 2015 at 6:36 PM, Nanley Chery > > wro

Re: [Mesa-dev] [RFC 16/21] mesa: Fix ARB_texture_compression_bptc functionality leaks

NAK. I'd like this extension in compatibility contexts. The fact the spec requires OpenGL 3.1 was just authors' laziness. Marek On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery wrote: > From: Nanley Chery > > Stop leaks into the following contexts: >* GLES in _mesa_target_can_be_compressed().

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

On Tue, Oct 20, 2015 at 8:14 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund > wrote: > > On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery > wrote: > >> From: Nanley Chery > >> > >> - { "GL_SUN_multi_draw_arrays", o(dummy_true), >

Re: [Mesa-dev] [PATCH 2/7] st/va: properly defines VAImageFormat formats and improve VaCreateImage

On 17 October 2015 at 00:25, Ilia Mirkin wrote: > Not sure how VA specifies things, but if the RGBA8 stuff is supposed > to be in CPU-endian as packed 32-bit ints, I think you're meant to use > PIPE_FORMAT_RGBA_UNORM and so on. However if it's always supposed > to be little-endian or array-ba

Re: [Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

On Tue, Oct 20, 2015 at 5:26 PM, Ilia Mirkin wrote: > On Sat, Oct 17, 2015 at 9:09 AM, Marek Olšák wrote: >> + /* This is not needed if state trackers set last_layer correctly. */ >> + if (state->target == PIPE_TEXTURE_1D || >> + state->target == PIPE_TEXTURE_2D || >> +

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote: > Also, the FIXME comment should be on its own line. > > I moved it aside to make editing the table easier. However, since the formatting of the table is unlikely to change much after this series, I agree that I should move it back to its origin

Re: [Mesa-dev] [RFC 17/21] mesa: Fix ARB_ES3_compatibility functionality leaks

NAK. I'd like this extension in compatibility contexts. The fact the spec requires OpenGL 3.3 was just authors' laziness. Generally, when a spec requires 3.3, we should allow 3.0 at least, because Mesa doesn't support 3.3 compatibility contexts. Unless you have a very good _technical_ reason not

Re: [Mesa-dev] [RFC 09/21] mesa: Generate a helper function for each extension

On Tue, Oct 20, 2015 at 8:26 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery > wrote: > > From: Nanley Chery > > > > Generate functions which determine if an extension is supported in the > > current context. Initially, enums were going to be explicitly used with > > _me

Re: [Mesa-dev] [RFC 18/21] mesa/extensions: Remove extra memsets on gl_extensions

On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery wrote: > From: Nanley Chery > > Aside from those modified in this commit, all gl_extensions structs are > zero-initialized by default. There is therefore no need to memset the > structs to 0. Also, remove the open-coded memset in > _mesa_init_extensi

Re: [Mesa-dev] [RFC 15/21] mesa: Fix EXT_texture_sRGB functionality leaks

On Tue, Oct 20, 2015 at 8:32 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery > wrote: > > From: Nanley Chery > > > > Stop leaks into the following contexts: > >* GLES in _mesa_base_tex_format() and lookup_view_class(). > >* Pre-1.1 GL legacy contexts in all uses.

Re: [Mesa-dev] [RFC 21/21] mesa/extensions: Declare _mesa_init_extensions() static inline

On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery wrote: > From: Nanley Chery > > Avoid the function call overhead for this one-liner. Can you measure the overhead? If not, there is no reason for this change. Marek ___ mesa-dev mailing list mesa-dev@list

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

On 19 October 2015 at 17:16, Emil Velikov wrote: > On 17 October 2015 at 00:14, Julien Isorce > wrote: > > This patch allows to use gallium vaapi without requiring > > a X server running for your second graphic card. > > > I've sent a lengthy series which should mitigate the need of some hunks.

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

https://bugs.freedesktop.org/show_bug.cgi?id=92552 Boyan Ding changed: What|Removed |Added Component|Mesa core |EGL --- Comment #4 from Boyan Ding --- (In

Re: [Mesa-dev] [RFC 21/21] mesa/extensions: Declare _mesa_init_extensions() static inline

On Tue, Oct 20, 2015 at 8:57 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery > wrote: > > From: Nanley Chery > > > > Avoid the function call overhead for this one-liner. > > Can you measure the overhead? If not, there is no reason for this change. > > The .text size does

Re: [Mesa-dev] [RFC 21/21] mesa/extensions: Declare _mesa_init_extensions() static inline

On Tue, Oct 20, 2015 at 6:25 PM, Nanley Chery wrote: > > > On Tue, Oct 20, 2015 at 8:57 AM, Marek Olšák wrote: >> >> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery >> wrote: >> > From: Nanley Chery >> > >> > Avoid the function call overhead for this one-liner. >> >> Can you measure the overhead

[Mesa-dev] [PATCH v2 5/7] st/va: implement dmabuf import for VaCreateSurfaces2

For now it is limited to RGBA, BGRA, RGBX, BGRX surfaces. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/surface.c | 97 - 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_tr

[Mesa-dev] [PATCH v2 2/7] st/va: properly defines VAImageFormat formats and improve VaCreateImage

Also add RGBA, RGBX and BGRX. Also extend ChromaToPipe and implement PipeToYCbCr. Note that gstreamer-vaapi check all the VAImageFormat fields. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/image.c | 18 +++--- src/gallium/state_trackers/va/va_private.h | 38 ++

[Mesa-dev] [PATCH v2 3/7] st/va: do not destroy old buffer when new one failed

If formats are not the same vlVaPutImage re-creates the video buffer with the right format. But if the creation of this new video buffer fails then the surface looses its current buffer. Let's just destroy the previous buffer on success. Signed-off-by: Julien Isorce --- src/gallium/state_tracker

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

On 20 October 2015 at 17:06, Julien Isorce wrote: > > > On 19 October 2015 at 17:16, Emil Velikov wrote: >> >> On 17 October 2015 at 00:14, Julien Isorce >> wrote: >> > This patch allows to use gallium vaapi without requiring >> > a X server running for your second graphic card. >> > >> I've sen

[Mesa-dev] [PATCH v2 1/7] nvc0: fix crash when nv50_miptree_from_handle fails

Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nvc0/nvc0_resource.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_resource.c b/src/gallium/drivers/nouveau/nvc0/nvc0_resource.c index 12b5a02..15c803c 100644 --- a/src/gall

[Mesa-dev] [PATCH v2 4/7] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

Inspired from http://cgit.freedesktop.org/vaapi/intel-driver/ especially src/i965_drv_video.c::i965_CreateSurfaces2. This patch is mainly to support gstreamer-vaapi and tools that uses this newer libva API. The first advantage of using VaCreateSurfaces2 over existing VaCreateSurfaces, is that it i

Re: [Mesa-dev] [RFC 21/21] mesa/extensions: Declare _mesa_init_extensions() static inline

On Tue, Oct 20, 2015 at 9:31 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 6:25 PM, Nanley Chery > wrote: > > > > > > On Tue, Oct 20, 2015 at 8:57 AM, Marek Olšák wrote: > >> > >> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery > >> wrote: > >> > From: Nanley Chery > >> > > >> > Avoid the f

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

On Tue, Oct 20, 2015 at 6:35 PM, Emil Velikov wrote: > On 20 October 2015 at 17:06, Julien Isorce > wrote: > > > > > > On 19 October 2015 at 17:16, Emil Velikov > wrote: > >> > >> On 17 October 2015 at 00:14, Julien Isorce > >> wrote: > >> > This patch allows to use gallium vaapi without requi

[Mesa-dev] [PATCHv4 4/7] nir: add shader_clock intrinsic

v2: Add flags and inline comment/description. v3: None of the input/outputs are variables v4: Drop clockARB reference, relate code motion barrier comment wrt intrinsic flag. Signed-off-by: Emil Velikov --- Matt, Hopefully the updated comment makes more sense (the clockARB reference was an unin

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

https://bugs.freedesktop.org/show_bug.cgi?id=92552 --- Comment #5 from Matthew Waters --- (In reply to Boyan Ding from comment #4) > The spec of EGL_KHR_create_context says: > requesting a forward-compatible context for OpenGL versions less > than 3.0 will generate an error > > The code

[Mesa-dev] [PATCH 5/7] i965/fs: move the fs_reg::smear() from get_timestamp() to the callers

We're about to reuse get_timestamp() for the nir_intrinsic_shader_clock. In the latter the generalisation does not apply, so move the smear() where needed. This also makes the function analogous to the vec4 one. v2: Tweak the comment - The caller -> We (Matt, Connor). Signed-off-by: Emil Velikov

[Mesa-dev] [PATCHv2 6/7] i965: Implement nir_intrinsic_shader_clock

v2: - Add a few const qualifiers for good measure. - Drop unneeded retype()s (Matt) - Convert timestamp to SIMD8/16, as fs_visitor::get_timestamp() returns SIMD4 (Connor) Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 11 +++ src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [RFC 18/21] mesa/extensions: Remove extra memsets on gl_extensions

On Tue, Oct 20, 2015 at 8:49 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery > wrote: > > From: Nanley Chery > > > > Aside from those modified in this commit, all gl_extensions structs are > > zero-initialized by default. There is therefore no need to memset the > > stru

Re: [Mesa-dev] [PATCH v2 1/7] nvc0: fix crash when nv50_miptree_from_handle fails

Is there a particular situation where nv50_miptree_from_handle() fails? And did you check nv50? Anyway, this patch is: Reviewed-by: Samuel Pitoiset On 20/10/2015 18:34, Julien Isorce wrote: Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nvc0/nvc0_resource.c | 3 ++- 1 file c

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Read all components of a SSBO field with one send

Reviewed-by: Jordan Justen On 2015-10-18 21:31:44, Kristian Høgsberg Kristensen wrote: > Instead of looping through single-component reads, read all components > in one go. > > Signed-off-by: Kristian Høgsberg Kristensen > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 25 +++

Re: [Mesa-dev] [PATCH 0/7] ARB_shader_clock support

On 19 October 2015 at 19:39, Matt Turner wrote: > On Mon, Oct 19, 2015 at 7:45 AM, Emil Velikov > wrote: >> Hi all, >> >> This is a resent of the previous RFC series with a few minor changes >> - fs_reg:;smear() has been moved out of get_timestamp() >> - clock2x32ARB() has proper return value

[Mesa-dev] Introducing OpenSWR: High performance software rasterizer

Hi. I'd like to introduce the Mesa3D community to a software project that we hope to upstream. We're a small team at Intel working on software defined visualization (http://sdvis.org/), and have opensource projects in both the raytracing (Embree, OSPRay) and rasterization (OpenSWR) realms. We're

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

[re-adding mesa-dev, dropped accidentally] On Tue, Oct 20, 2015 at 1:43 PM, Ilia Mirkin wrote: > On Tue, Oct 20, 2015 at 1:11 PM, Rowley, Timothy O > wrote: >> Does one build work on both AVX and AVX2? >> - >> >> * Unfortunately, no. The architecture sup

  1   2   >