[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92265 --- Comment #7 from Pekka Paalanen --- I don't think you mean GL_EXT_abgr, I don't see Weston using that. Weston is using GL_BGRA_EXT format, when GL_EXT_texture_format_BGRA extension is available. Weston's GL-renderer refuses to start witho

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92265 Pekka Paalanen changed: What|Removed |Added CC||ppaala...@gmail.com -- You are receivi

[Mesa-dev] [PATCH] i965: Make vec4_visitor's destructor virtual

2015-10-05 Thread Iago Toral Quiroga
We need a virtual destructor when at least one of the class' methods is virtual. Failure to do so leads to undefined behavior when destructing derived classes. Fixes the following warning: brw_vec4_gs_visitor.cpp: In function 'const unsigned int* brw::brw_gs_emit(brw_context*, gl_shader_program*,

[Mesa-dev] [PATCH 1/2] glsl: mark packed varyings during lower_packed_varyings

2015-10-05 Thread Tapani Pälli
This makes it easier and faster to identify a packed varying in shader queries. Signed-off-by: Tapani Pälli --- src/glsl/ir.h | 5 + src/glsl/lower_packed_varyings.cpp | 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/glsl/ir.h b/src/glsl/ir.h index 43a2bf0..d33

[Mesa-dev] [PATCH 2/2] mesa: fix GetProgramiv/GetActiveAttrib regression

2015-10-05 Thread Tapani Pälli
Commit 4639cea2921669527eb43dcb49724c05afb27e8e added packed varyings as part of program resource list. We need to take this to account with all functions dealing with active input attributes. Patch fixes the issue by adding additional check to is_active_attrib and iterating only active attribs (n

Re: [Mesa-dev] [PATCH 2/2] mesa: fix GetProgramiv/GetActiveAttrib regression

2015-10-05 Thread Ilia Mirkin
On Mon, Oct 5, 2015 at 3:14 AM, Tapani Pälli wrote: > Commit 4639cea2921669527eb43dcb49724c05afb27e8e added packed varyings > as part of program resource list. We need to take this to account with > all functions dealing with active input attributes. Don't you have this same problem with output a

Re: [Mesa-dev] [PATCH 2/2] mesa: fix GetProgramiv/GetActiveAttrib regression

2015-10-05 Thread Tapani Pälli
On 10/05/2015 10:21 AM, Ilia Mirkin wrote: On Mon, Oct 5, 2015 at 3:14 AM, Tapani Pälli wrote: Commit 4639cea2921669527eb43dcb49724c05afb27e8e added packed varyings as part of program resource list. We need to take this to account with all functions dealing with active input attributes. Don

Re: [Mesa-dev] [PATCH 2/2] mesa: fix GetProgramiv/GetActiveAttrib regression

2015-10-05 Thread Ilia Mirkin
On Mon, Oct 5, 2015 at 3:33 AM, Tapani Pälli wrote: > > > On 10/05/2015 10:21 AM, Ilia Mirkin wrote: >> >> On Mon, Oct 5, 2015 at 3:14 AM, Tapani Pälli >> wrote: >>> >>> Commit 4639cea2921669527eb43dcb49724c05afb27e8e added packed varyings >>> as part of program resource list. We need to take thi

Re: [Mesa-dev] [PATCH 2/2] mesa: fix GetProgramiv/GetActiveAttrib regression

2015-10-05 Thread Tapani Pälli
On 10/05/2015 10:38 AM, Ilia Mirkin wrote: On Mon, Oct 5, 2015 at 3:33 AM, Tapani Pälli wrote: On 10/05/2015 10:21 AM, Ilia Mirkin wrote: On Mon, Oct 5, 2015 at 3:14 AM, Tapani Pälli wrote: Commit 4639cea2921669527eb43dcb49724c05afb27e8e added packed varyings as part of program resourc

[Mesa-dev] [PATCH] glsl: Fix variable_referenced() for vector_{extract, insert} expressions

2015-10-05 Thread Iago Toral Quiroga
We get these when we operate on vector variables with array accessors (i.e. things like a[0] where 'a' is a vec4). When we call variable_referenced() on these expressions we want to return a reference to 'a' instead of NULL. This fixes a problem where we pass a[0] as the first argument to an atomi

[Mesa-dev] [PATCH] glsl: set glsl error if binding qualifier used on global scope

2015-10-05 Thread Tapani Pälli
Fixes following Piglit test: global-scope-binding-qualifier.frag Signed-off-by: Tapani Pälli --- src/glsl/glsl_parser.yy | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index f0abeb0..c1b 100644 --- a/src/glsl/glsl_pa

Re: [Mesa-dev] [PATCH] i965: Make vec4_visitor's destructor virtual

2015-10-05 Thread Francisco Jerez
Iago Toral Quiroga writes: > We need a virtual destructor when at least one of the class' methods is > virtual. > Failure to do so leads to undefined behavior when destructing derived classes. > Fixes the following warning: > > brw_vec4_gs_visitor.cpp: In function 'const unsigned int* > brw::br

Re: [Mesa-dev] [PATCH] glsl: set glsl error if binding qualifier used on global scope

2015-10-05 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 05/10/15 12:02, Tapani Pälli wrote: > Fixes following Piglit test: > global-scope-binding-qualifier.frag > > Signed-off-by: Tapani Pälli > --- > src/glsl/glsl_parser.yy | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/gl

Re: [Mesa-dev] [PATCH] i965: Make vec4_visitor's destructor virtual

2015-10-05 Thread Iago Toral
On Mon, 2015-10-05 at 13:08 +0300, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > We need a virtual destructor when at least one of the class' methods is > > virtual. > > Failure to do so leads to undefined behavior when destructing derived > > classes. > > Fixes the following warnin

Re: [Mesa-dev] [PATCH 4/6] i965: dump scheduling cycle estimates

2015-10-05 Thread Iago Toral
On Fri, 2015-10-02 at 17:43 -0400, Connor Abbott wrote: > On Fri, Oct 2, 2015 at 5:37 PM, Connor Abbott wrote: > > The heuristic we're using is rather lame, since it assumes everything is > > non-uniform and loops execute 50 times, but it should be enough for > > measuring improvements in the sche

[Mesa-dev] [PATCH 1/2] i965: Add a second successor to BRW_OPCODE_WHILE

2015-10-05 Thread Neil Roberts
It is possible to directly predicate the WHILE instruction. In this case there will be a second successor block because the execution can resume from the instruction after the loop. This will be used in a subsequent patch. --- src/mesa/drivers/dri/i965/brw_cfg.cpp | 4 1 file changed, 4 inser

[Mesa-dev] [PATCH v3 2/2] i965/fs: Handle non-const sample number in interpolateAtSample

2015-10-05 Thread Neil Roberts
If a non-const sample number is given to interpolateAtSample it will now generate an indirect send message with the sample ID similar to how non-const sampler array indexing works. Previously non-const values were ignored and instead it ended up using a constant 0 value. The generator will try to

[Mesa-dev] [Bug 92286] Distant geometry renders in front of closer geometry (depth test fail) in DarkRadiant / wxWidgets

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92286 Bug ID: 92286 Summary: Distant geometry renders in front of closer geometry (depth test fail) in DarkRadiant / wxWidgets Product: Mesa Version: unspecified Hardware: x86-64

[Mesa-dev] [Bug 92286] Distant geometry renders in front of closer geometry (depth test fail) in DarkRadiant / wxWidgets

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92286 MirceaKitsune changed: What|Removed |Added CC||sonichedgehog_hyperblast00@

Re: [Mesa-dev] [RFC 0/2] Use hash tables for opt_constant_propagation() acp sets

2015-10-05 Thread Rhys Kidd
On 20 September 2015 at 19:54, Rhys Kidd wrote: > Kenneth Graunke in 4654439fdd766f79a78fe0d812fd916f5815e7e6 refactored > kill sets in opt_constant_propagation() to use hash tables. This patch set > makes the suggested changes to use hash tables for acp sets, as well as > correcting documentatio

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

2015-10-05 Thread Roland Scheidegger
FWIW from a high level point of view this makes all sense to me. It is however definitely not my field of expertise, but whatever makes it easier to have multiple drivers installed is imho a good thing... Some more feedback from mesa people which are more familiar with the gl api dispatch stuff (al

[Mesa-dev] [RFC] ARB_shader_clock, hardware counters and i965

2015-10-05 Thread Emil Velikov
Hi all, I am looking at ARB_shader_clock with i965 in mind. So far I've got the most of the infra/plumbing, and a fancy a new intrinsic :) On the hardware side, I was thinking about using the Observability Architecture (OA) counters. The fun part is that those tend to vary quite a bit based on t

Re: [Mesa-dev] [PATCH v2] i915/aa: fixing anti-aliasing bug for thinnest width lines

2015-10-05 Thread Predut, Marius
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of > Ian Romanick > Sent: Wednesday, September 09, 2015 9:11 PM > To: Predut, Marius; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2] i915/aa: fixing anti-aliasing bug for > t

[Mesa-dev] [PATCH] i915/aa: fixing anti-aliasing bug for thinnest width lines

2015-10-05 Thread Marius Predut
On PNV platform, for 1 pixel line thickness or less, the general anti-aliasing algorithm gives up, and a garbage line is generated. Setting a Line Width of 0.0 specifies the rasterization of the "thinnest" (one-pixel-wide), non-antialiased lines. Lines rendered with zero Line Width are rasterized u

Re: [Mesa-dev] [RFC] ARB_shader_clock, hardware counters and i965

2015-10-05 Thread Connor Abbott
On Mon, Oct 5, 2015 at 11:36 AM, Emil Velikov wrote: > Hi all, > > I am looking at ARB_shader_clock with i965 in mind. > > So far I've got the most of the infra/plumbing, and a fancy a new intrinsic :) > > On the hardware side, I was thinking about using the Observability > Architecture (OA) count

[Mesa-dev] [Bug 92293] A compilation error happen when update mesa from 10.6.7 to 11.0.2

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92293 Bug ID: 92293 Summary: A compilation error happen when update mesa from 10.6.7 to 11.0.2 Product: Mesa Version: 11.0 Hardware: x86-64 (AMD64) OS: Linux (All

[Mesa-dev] [Bug 92293] A compilation error happen when update mesa from 10.6.7 to 11.0.2

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92293 --- Comment #1 from marius predut --- Seems dri_interface.h is missing from intel_screen.c file. But even adding it ,mesa have compilation error: no rule to make target nir/nir_... From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] O

Re: [Mesa-dev] [Bug 92293] A compilation error happen when update mesa from 10.6.7 to 11.0.2

2015-10-05 Thread Predut, Marius
Seems dri_interface.h is missing from intel_screen.c file. But even adding it ,mesa have compilation error: no rule to make target nir/nir_... From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of bugzilla-dae...@freedesktop.org Sent: Monday, October 05, 2015 6:13 PM To: me

[Mesa-dev] [Bug 92293] A compilation error happen when update mesa from 10.6.7 to 11.0.2

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92293 --- Comment #2 from Neil Roberts --- I think the general problem is that if you install an old version of Mesa somewhere and then try and build a new version while specifying the install prefix of the old version as an include path with -I in the

Re: [Mesa-dev] [RFC] ARB_shader_clock, hardware counters and i965

2015-10-05 Thread Emil Velikov
On 5 October 2015 at 17:11, Connor Abbott wrote: > On Mon, Oct 5, 2015 at 11:36 AM, Emil Velikov > wrote: >> Hi all, >> >> I am looking at ARB_shader_clock with i965 in mind. >> >> So far I've got the most of the infra/plumbing, and a fancy a new intrinsic >> :) >> >> On the hardware side, I wa

[Mesa-dev] [Bug 92293] A compilation error happen when update mesa from 10.6.7 to 11.0.2

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92293 --- Comment #3 from Emil Velikov --- (In reply to marius predut from comment #1) > Created attachment 118675 [details] > attachment-24069-0.html > > Seems dri_interface.h is missing from intel_screen.c file. > But even adding it ,mesa have compi

[Mesa-dev] [Bug 92293] A compilation error happen when update mesa from 10.6.7 to 11.0.2

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92293 --- Comment #4 from Emil Velikov --- As a quick test, I would suggest dropping the CPPFLAGS and (optionally LDFLAGS). PKG_CONFIG_PATH will provide the relevant bits as needed. -- You are receiving this mail because: You are the QA Contact for t

[Mesa-dev] [Bug 92293] A compilation error happen when update mesa from 10.6.7 to 11.0.2

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92293 --- Comment #5 from Emil Velikov --- (In reply to Neil Roberts from comment #2) > I think the general problem is that if you install an old version of Mesa > somewhere and then try and build a new version while specifying the install > prefix of

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-10-05 Thread Kristian Høgsberg
On Mon, Oct 5, 2015 at 7:03 AM, Michel Thierry wrote: > On 9/14/2015 2:54 PM, Michał Winiarski wrote: >> >> On Thu, Sep 03, 2015 at 03:23:58PM +0100, Michel Thierry wrote: >>> >>> Gen8+ supports 48-bit virtual addresses, but some objects must always be >>> allocated inside the 32-bit address range

Re: [Mesa-dev] [PATCH 2/2] i965: Fix intel_miptree_is_fast_clear_capable()

2015-10-05 Thread Chad Versace
On Thu 01 Oct 2015, Ben Widawsky wrote: > On Thu, Oct 01, 2015 at 08:20:07AM -0700, Chad Versace wrote: > > There are three types of fast clears: > > a. fast depth clears > > b. fast singlesample color clears > > c. fast multisample color clears > > Function intel_miptree_is_fast_clear_capabl

[Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

2015-10-05 Thread Brian Paul
Callers of create_texture() will either pass target=0 or a validated GL texture target enum so no need to do another error check inside the loop. --- src/mesa/main/texobj.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj

[Mesa-dev] [PATCH 3/3] mesa: move gl_texture_object::TargetIndex initializations

2015-10-05 Thread Brian Paul
Before, we were unconditionally assigning the TargetIndex field in _mesa_BindTexture(), even if it was already set properly. Now we initialize TargetIndex wherever we initialize the Target field, in _mesa_initialize_texture_object(), finish_texture_init(), etc. --- src/mesa/main/shared.c |

[Mesa-dev] [PATCH 2/3] mesa: remove unused _mesa_create_nameless_texture()

2015-10-05 Thread Brian Paul
--- src/mesa/main/texobj.c | 20 src/mesa/main/texobj.h | 3 --- 2 files changed, 23 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index aa4b38c..66eacf8 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -1185,26 +1185,6 @@ inval

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-10-05 Thread Michel Thierry
On 9/14/2015 2:54 PM, Michał Winiarski wrote: On Thu, Sep 03, 2015 at 03:23:58PM +0100, Michel Thierry wrote: Gen8+ supports 48-bit virtual addresses, but some objects must always be allocated inside the 32-bit address range. In specific, any resource used with flat/heapless (0x-0xf

[Mesa-dev] [RFC v4] i965/gen8+: bo in state base address must be in 32-bit address range

2015-10-05 Thread Michel Thierry
Gen8+ supports 48-bit virtual addresses, but some objects must always be allocated inside the 32-bit address range. In specific, any resource used with flat/heapless (0x-0xf000) General State Heap or Instruction State Heap must be in a 32-bit range (GSH / ISH), because the General Stat

Re: [Mesa-dev] [PATCH] glsl: Fix variable_referenced() for vector_{extract,insert} expressions

2015-10-05 Thread Markus Wick
Am 2015-10-05 11:42, schrieb Iago Toral Quiroga: We get these when we operate on vector variables with array accessors (i.e. things like a[0] where 'a' is a vec4). When we call variable_referenced() on these expressions we want to return a reference to 'a' instead of NULL. This fixes a proble

Re: [Mesa-dev] [PATCH] mesa: Add missing _mm_mfence() before streaming loads.

2015-10-05 Thread Matt Turner
On Thu, Oct 1, 2015 at 11:20 AM, Jordan Justen wrote: > On 2015-10-01 10:11:33, Matt Turner wrote: >> According to the Intel Software Development Manual: > > How about a more specific doc location? > > According to the Intel Software Development Manual (Volume 1: Basic > Architecture, 12.10.3 Stre

[Mesa-dev] [Bug 92286] Distant geometry renders in front of closer geometry (depth test fail) in DarkRadiant / wxWidgets

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92286 MirceaKitsune changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from MirceaKitsu

Re: [Mesa-dev] [PATCH] mesa: Add missing _mm_mfence() before streaming loads.

2015-10-05 Thread Jordan Justen
On 2015-10-05 11:55:57, Matt Turner wrote: > On Thu, Oct 1, 2015 at 11:20 AM, Jordan Justen > wrote: > > On 2015-10-01 10:11:33, Matt Turner wrote: > >> According to the Intel Software Development Manual: > > > > How about a more specific doc location? > > > > According to the Intel Software Devel

[Mesa-dev] [PATCH 0/5] nvc0: split HW/SQ queries in different files

2015-10-05 Thread Samuel Pitoiset
Hi there, This series splits HW (including MP performance counters) and SW queries in different files to improve readability of this area of the nvc0 driver. This also prepares the way for landing global performance counters (PCOUNTER) in the next few weeks. I tested this series on Fermi and Kep

[Mesa-dev] [Bug 92122] [bisected, cts] Regression with Assault Android Cactus

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92122 Mark Janes changed: What|Removed |Added Summary|[bisected] Regression with |[bisected, cts] Regression

Re: [Mesa-dev] [RFC] ARB_shader_clock, hardware counters and i965

2015-10-05 Thread Marek Olšák
On Mon, Oct 5, 2015 at 5:36 PM, Emil Velikov wrote: > P.S. Does anyone recall the consensus wrt adding the 2015 extensions > to GL3.txt ? I think the decision was that the list wouldn't contain any non-core extensions. Marek ___ mesa-dev mailing list m

[Mesa-dev] [PATCH] nouveau: make sure there's always room to emit a fence

2015-10-05 Thread Ilia Mirkin
I started seeing a lot of situations on nv30 where fence emission wouldn't fit into the previous buffer (causing assertions). This ensures that whenever checking for space, we always leave a bit of extra room for the fence emission commands. Adjusts the nv30 and nvc0 fence emission logic to bypass

[Mesa-dev] [PATCH 1/5] nvc0: add a header file for nvc0_query

2015-10-05 Thread Samuel Pitoiset
This will allow to split SW and HW queries in an upcoming patch. While we are at it, make use of nvc0_query struct instead of pipe_query. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 12 +- s

[Mesa-dev] [PATCH 2/5] nvc0: move nvc0_so_target_save_offset() to its correct location

2015-10-05 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 21 - src/gallium/drivers/nouveau/nvc0/nvc0_query.h | 3 --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 19 +++ 3 files changed, 19 insertions(+), 24 deletions(-) diff --g

[Mesa-dev] [PATCH 5/5] nvc0: move HW SM queries to nvc0_query_hw_sm.c/h files

2015-10-05 Thread Samuel Pitoiset
Global performance counters (PCOUNTER) will be added to nvc0_query_hw_pm.c/h files. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources | 2 + src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c | 707 +-- src/gallium/drivers/nouveau/nvc0/nvc0_q

[Mesa-dev] [PATCH 4/5] nvc0: move HW queries to nvc0_query_hw.c/h files

2015-10-05 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources |2 + src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 1122 +-- src/gallium/drivers/nouveau/nvc0/nvc0_query.h | 121 --- src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c | 1128 +

[Mesa-dev] [PATCH 3/5] nvc0: move SW queries to nvc0_query_sw.c/h files

2015-10-05 Thread Samuel Pitoiset
Loosely based on freedreno driver. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources | 2 + src/gallium/drivers/nouveau/nvc0/nvc0_query.c| 31 src/gallium/drivers/nouveau/nvc0/nvc0_query.h| 56 +++ src/gallium/drivers/nouveau/nvc0/n

Re: [Mesa-dev] [Nouveau] [PATCH] nouveau: make sure there's always room to emit a fence

2015-10-05 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 10/05/2015 09:21 PM, Ilia Mirkin wrote: I started seeing a lot of situations on nv30 where fence emission wouldn't fit into the previous buffer (causing assertions). This ensures that whenever checking for space, we always leave a bit of extra room for the fence

[Mesa-dev] [Bug 92286] Distant geometry renders in front of closer geometry (depth test fail) in DarkRadiant / wxWidgets

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92286 --- Comment #2 from Roland Scheidegger --- (In reply to MirceaKitsune from comment #1) > I guess the question of this bug report remains whether Mesa is doing > something wrong here. On the proprietary video drivers, it's ok to leave the > attrib

[Mesa-dev] [PATCH v2 08/23] i965/vs: Fix a subtlety in the nr_attributes == 0 workaround.

2015-10-05 Thread Kenneth Graunke
nr_attributes is used to compute first_non_payload_grf, which is the first register we're allowed to use for ordinary register allocation. The hardware requires us to read at least one pair of values, but we're completely free to overwrite that garbage register with whatever we like. Instead of a

Re: [Mesa-dev] [PATCH] glsl: Remove CSE pass.

2015-10-05 Thread Kenneth Graunke
On Saturday, October 03, 2015 10:57:38 AM Matt Turner wrote: > With NIR, it actually hurts things. > > total instructions in shared programs: 6529329 -> 652 (-0.01%) > instructions in affected programs: 14833 -> 14392 (-2.97%) > helped:299 > HURT:

Re: [Mesa-dev] [PATCH] mesa/state_tracker: Fix draw-pixel-with-texture piglit test.

2015-10-05 Thread Matthew Dawson
On October 5, 2015 03:11:16 AM Marek Olšák wrote: > Thank you for the patch, but it's not applicable on my (private) > branch where I'm reworking st/mesa's shader compilation, including > DrawPixels shaders. Your patch helped to fix it in the new > implementation at least. > > Sorry for ignoring i

[Mesa-dev] [PATCH] mesa: Remove GL_ARB_sampler_object depth compare error checking.

2015-10-05 Thread Stefan Dösinger
Version 3: Simplify the code comment, word wrap commit description. Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of pretending to store the value as suggested by Brian Paul. This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a

Re: [Mesa-dev] [RFC] ARB_shader_clock, hardware counters and i965

2015-10-05 Thread Connor Abbott
On Mon, Oct 5, 2015 at 1:06 PM, Emil Velikov wrote: > On 5 October 2015 at 17:11, Connor Abbott wrote: >> On Mon, Oct 5, 2015 at 11:36 AM, Emil Velikov >> wrote: >>> Hi all, >>> >>> I am looking at ARB_shader_clock with i965 in mind. >>> >>> So far I've got the most of the infra/plumbing, and a

Re: [Mesa-dev] [PATCH] mesa/state_tracker: Fix draw-pixel-with-texture piglit test.

2015-10-05 Thread Marek Olšák
On Mon, Oct 5, 2015 at 11:27 PM, Matthew Dawson wrote: > On October 5, 2015 03:11:16 AM Marek Olšák wrote: >> Thank you for the patch, but it's not applicable on my (private) >> branch where I'm reworking st/mesa's shader compilation, including >> DrawPixels shaders. Your patch helped to fix it in

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

2015-10-05 Thread Mark Janes
I tested this patch and found: regressions: spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) expected[1] = 1.00. Read value: 0.00 spec.arb_copy_image.arb_copy_image-srgb-copy (assertion) arb_copy_image-srgb-copy: src/mesa/main/texobj.c:1739: _mesa_Bi

Re: [Mesa-dev] [RFC 0/3] V2: Improve GLSL support of GL_ARB_separate_shader_objects

2015-10-05 Thread gregory hainaut
On Sat, 3 Oct 2015 11:59:49 +0200 gregory hainaut wrote: > On Sat, 03 Oct 2015 09:35:49 + > Mike Lothian wrote: > > > Would it be better to have is_interstage=0 rather than a double negative? > > > Yes. I think it just need to set 1 in the constructor (forget to > update it by the way...)

[Mesa-dev] [Bug 92221] Unintended code changes in _mesa_base_tex_format commit

2015-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92221 --- Comment #4 from Nanley Chery --- (In reply to Nanley Chery from comment #2) > (In reply to Mark Janes from comment #1) > > Nanley, should there have been a piglit failure associated with ASTC > > functionality that was disabled? > > Not at t

[Mesa-dev] [PATCH 01/17] mesa: call ProgramStringNotify for fixed-function vertex programs

2015-10-05 Thread Marek Olšák
From: Marek Olšák Drivers weren't notified about this at all. This allows disabling on-demand compilation in drivers. --- src/mesa/main/ffvertex_prog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/main/ffvertex_prog.c index a6183b

[Mesa-dev] [PATCH 17/17] st/mesa: release the glsl_to_tgsi visitor after translation

2015-10-05 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_program.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index 3317071..6a69ba7 100644 --- a/src/mesa/state_tracker/st_program.c ++

[Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

2015-10-05 Thread Marek Olšák
From: Marek Olšák - there is no connection to user fragment shaders, so having these as shader variants makes no sense - don't use Mesa IR, use TGSI - don't create gl_fragment_program, just create the shader CSO --- src/mesa/state_tracker/st_cb_drawpixels.c | 185 +++---

[Mesa-dev] [PATCH 06/17] st/mesa: use TGSI utility to emulate features for VS variants

2015-10-05 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_program.c | 41 ++--- 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index 9e100db..6ace352 100644 --- a/src/mesa/state_trac

[Mesa-dev] [PATCH 13/17] st/mesa: translate vertex shaders into TGSI when we get them

2015-10-05 Thread Marek Olšák
From: Marek Olšák The translate functions is split into two: - translation to TGSI - creating the variant (TGSI transformations only) --- src/mesa/state_tracker/st_cb_program.c | 4 +- src/mesa/state_tracker/st_program.c| 72 +- src/mesa/state_tracker/st_prog

[Mesa-dev] [PATCH 09/17] st/mesa: implement glBitmap shader transformation using tgsi_transform_shader

2015-10-05 Thread Marek Olšák
From: Marek Olšák --- src/mesa/Makefile.sources| 1 + src/mesa/state_tracker/st_cb_bitmap.c| 145 -- src/mesa/state_tracker/st_cb_bitmap.h| 11 +- src/mesa/state_tracker/st_cb_bitmap_shader.c | 174 +++ src/mesa/s

[Mesa-dev] [PATCH 15/17] st/mesa: translate geometry shaders into TGSI when we get them

2015-10-05 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_program.c | 2 ++ src/mesa/state_tracker/st_program.c| 38 -- src/mesa/state_tracker/st_program.h| 5 + 3 files changed, 30 insertions(+), 15 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_p

[Mesa-dev] [PATCH 11/17] st/mesa: implement DrawPixels shader transformation using tgsi_transform_shader

2015-10-05 Thread Marek Olšák
From: Marek Olšák --- src/mesa/Makefile.sources| 1 + src/mesa/state_tracker/st_atom_pixeltransfer.c | 225 +--- src/mesa/state_tracker/st_cb_drawpixels.c| 118 +-- src/mesa/state_tracker/st_cb_drawpixels.h| 9 +- src/mesa/sta

[Mesa-dev] [PATCH 03/17] tgsi/scan: add info about declared samplers

2015-10-05 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 00b07c8..1c45748 100644 --- a/src/gallium/auxil

[Mesa-dev] [PATCH 08/17] st/mesa: remove old emulation for VS and FS variants

2015-10-05 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 48 +++- src/mesa/state_tracker/st_glsl_to_tgsi.h | 4 +-- src/mesa/state_tracker/st_mesa_to_tgsi.c | 50 +++--- src/mesa/state_tracker/st_mesa_to_tgsi.h | 4 +-- src/mesa/s

[Mesa-dev] [PATCH 16/17] st/mesa: translate tessellation shaders into TGSI when we get them

2015-10-05 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_program.c | 4 ++ src/mesa/state_tracker/st_program.c| 86 -- src/mesa/state_tracker/st_program.h| 10 3 files changed, 64 insertions(+), 36 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_pr

[Mesa-dev] [PATCH 04/17] st/mesa: inline st_prepare_vertex_program

2015-10-05 Thread Marek Olšák
From: Marek Olšák No other shader stage has a "prepare" function. This will allow removing some variables from st_vertex_program. Also, prepare_fragment_program was a dead prototype. --- src/mesa/state_tracker/st_program.c | 41 ++--- src/mesa/state_tracker/st_pr

[Mesa-dev] [PATCH 05/17] st/mesa: decrease the size of st_vertex_program

2015-10-05 Thread Marek Olšák
From: Marek Olšák The other variables can't be moved. --- src/mesa/state_tracker/st_program.c | 94 +++-- src/mesa/state_tracker/st_program.h | 5 -- 2 files changed, 48 insertions(+), 51 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/

[Mesa-dev] [PATCH 12/17] st/mesa: fix glDrawPixels with a texture

2015-10-05 Thread Marek Olšák
From: Marek Olšák The samplers for DrawPixels data and the pixel map are assigned to slots which don't overlap with the existing sampler slots. The texture coordinates for the user texture are uploaded as a constant. --- src/mesa/state_tracker/st_cb_drawpixels.c| 52 +---

[Mesa-dev] [PATCH 07/17] st/mesa: use TGSI utility to emulate features for FS variants

2015-10-05 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_program.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index 6ace352..bf6b492 100644 --- a/src/mesa/state_tracker/st_prog

[Mesa-dev] [PATCH 14/17] st/mesa: translate fragment shaders into TGSI when we get them

2015-10-05 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_program.c | 2 + src/mesa/state_tracker/st_debug.c | 2 +- src/mesa/state_tracker/st_program.c| 81 -- src/mesa/state_tracker/st_program.h| 7 ++- 4 files changed, 55 insertions(+), 37 deletions(-)

[Mesa-dev] [PATCH 00/17] Rework Mesa/ST shader compilation logic (Part 1)

2015-10-05 Thread Marek Olšák
Hi, This is a start of reworking how st/mesa translates and creates shaders. The result of this patch series is this: In LinkShader or ProgramStringNotify, the shader is translated to TGSI as-is. There are no shader code modifications for shader variants. The glsl-to-tgsi visitor is released.

[Mesa-dev] [PATCH 02/17] tgsi: add a utility for emulating some GL features

2015-10-05 Thread Marek Olšák
From: Marek Olšák st/mesa will use this, but drivers can use it too. --- src/gallium/auxiliary/Makefile.sources| 2 + src/gallium/auxiliary/tgsi/tgsi_emulate.c | 168 ++ src/gallium/auxiliary/tgsi/tgsi_emulate.h | 38 +++ 3 files changed, 208 insertions(+)

Re: [Mesa-dev] [Patchwork] The infrequent patchwork update #1

2015-10-05 Thread Timothy Arceri
On Tue, 2015-09-29 at 16:33 +0100, Damien Lespiau wrote: > Hi all, > > You may have noticed already, patchwork.freedesktop.org looks > different. > > That new version includes: > - Some re-design. Design is very much an iterative process, > thoughts > and comments are welcome, > - Showing

Re: [Mesa-dev] [PATCH v2] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

2015-10-05 Thread Iago Toral
Hi, On Tue, 2015-09-29 at 09:25 +0200, Iago Toral Quiroga wrote: > NIR is typeless so this is the only way to keep track of the > type to select the proper atomic to use. > > v2: > - Use imin,imax,umin,umax for the intrinsic names (Connor Abbott) > - Change message for unreachable paths (Mich

Re: [Mesa-dev] [PATCH v2 08/23] i965/vs: Fix a subtlety in the nr_attributes == 0 workaround.

2015-10-05 Thread Iago Toral
On Mon, 2015-10-05 at 13:41 -0700, Kenneth Graunke wrote: > nr_attributes is used to compute first_non_payload_grf, which is the > first register we're allowed to use for ordinary register allocation. > > The hardware requires us to read at least one pair of values, but we're > completely free to