Re: [Mesa-dev] [PATCH 05/25] glsl: add support for initialising sampler AoA

2015-08-21 Thread Timothy Arceri
On Thu, 2015-08-20 at 10:41 -0700, Ian Romanick wrote: > This patch is > > Reviewed-by: Ian Romanick I've just rebased this [1] on the changes curro pushed yesterday can I still add your r-b to this. [1] https://github.com/tarceri/Mesa_arrays_of_arrays/commit/93cfad2b93045aa21a fa4c55c9fe0aadab

Re: [Mesa-dev] [PATCH 02/25] glsl: dont allow gl_PerVertex to be redeclared as an array of arrays

2015-08-21 Thread Timothy Arceri
On Thu, 2015-08-20 at 10:56 -0700, Ian Romanick wrote: > On 08/20/2015 10:24 AM, Ian Romanick wrote: > > On 08/19/2015 09:37 PM, Timothy Arceri wrote: > > > V2: move single dimensional array detection into a helper > > > > > > Signed-off-by: Timothy Arceri > > > Reviewed-by: Samuel Iglesias Gonsá

[Mesa-dev] [PATCH 6/6] i965: enable OES_texture_storage_multisample_2d_array

2015-08-21 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 4365b71..3a47b85 100644 --- a/src/mesa/drivers/dri/i965/intel_extensi

[Mesa-dev] [PATCH 3/6] mesa: Add extension enable for OES_texture_storage_multisample_2d_array

2015-08-21 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 4a3c231..d3f43cc 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.

[Mesa-dev] [PATCH 1/6] mesa: GetTexLevelParameter{if}v changes for OpenGL ES 3.1

2015-08-21 Thread Tapani Pälli
Patch refactors existing parameters check to first check common enums between desktop GL and GLES 3.1 and modifies get_tex_level_parameter_image to be compatible with enums specified in 3.1. Signed-off-by: Tapani Pälli --- src/mesa/main/texparam.c | 34 +++--- 1 file

[Mesa-dev] [PATCH 2/6] glapi: add GL_OES_texture_storage_multisample_2d_array extension

2015-08-21 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mapi/glapi/gen/es_EXT.xml | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mapi/glapi/gen/es_EXT.xml b/src/mapi/glapi/gen/es_EXT.xml index 642e3b3..cfca5a9 100644 --- a/src/mapi/glapi/gen/es_EXT.xml +++ b/src/mapi/glapi/gen/es_EXT.xm

[Mesa-dev] [PATCH 4/6] glsl: add support for OES_texture_storage_multisample_2d_array

2015-08-21 Thread Tapani Pälli
Patch adds extension enable bit and enables required keywords and builtin functions for the extension. Signed-off-by: Tapani Pälli --- src/glsl/builtin_functions.cpp | 5 +++-- src/glsl/builtin_types.cpp | 3 ++- src/glsl/glcpp/glcpp-parse.y| 2 ++ src/glsl/glsl_lexer.ll | 6 +

[Mesa-dev] [PATCH 0/6] OES_texture_storage_multisample_2d_array

2015-08-21 Thread Tapani Pälli
Hi; This patchset enables OES_texture_storage_multisample_2d_array. I've tested that all 59 tests of ES31-CTS.texture_storage_multisample.* pass (includes tests for extensions + testing possible regressions) and there are no Piglit regressions. Note that patch 1 is a resend, I wanted to base patch

[Mesa-dev] [PATCH 5/6] mesa: enable enums for OES_texture_storage_multisample_2d_array

2015-08-21 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/main/get_hash_params.py | 6 +++--- src/mesa/main/texobj.c | 6 -- src/mesa/main/texparam.c | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py ind

Re: [Mesa-dev] [PATCH 18/25] glsl: disable interface block AoA

2015-08-21 Thread Timothy Arceri
On Thu, 2015-08-20 at 11:28 -0700, Ian Romanick wrote: > On 08/19/2015 09:37 PM, Timothy Arceri wrote: > > Desktop GL supports interface block AoA however AMD and Nvidia > > dont support it in their drivers curently so we can get away > > with disabling it for now. > > --- > > src/glsl/ast_to_hir.

Re: [Mesa-dev] [PATCH 23/25] glsl: Allow arrays of arrays in GLSL ES 3.10 and GLSL 4.30

2015-08-21 Thread Timothy Arceri
On Thu, 2015-08-20 at 11:30 -0700, Ian Romanick wrote: > On 08/19/2015 09:37 PM, Timothy Arceri wrote: > > V2: add missing 's' to the extension name in error messages > > and add decimal place in version string > > > > Reviewed-by: Ilia Mirkin > > --- > > src/glsl/ast_to_hir.cpp | 13

[Mesa-dev] [PATCH] shader dump and debug functionality

2015-08-21 Thread Tapani Pälli
Hi; Eero asked me to provide this utility for some shader investigations. This is a cleaned up version of older hack patch I had when I debugged UE4 engine failures. Would it be useful to have this included in Mesa, maybe under compiler flag option or under a environment variable? Any suggestions

[Mesa-dev] [PATCH] mesa: debug facility to replace shaders when running apps

2015-08-21 Thread Tapani Pälli
Patch adds shader source and replace functionality in to the compiler. This can be used to debug individual (failing) shaders and measure performance impact of each shader. Functionality is controlled via 2 environment variables: MESA_SHADER_DUMP - path where shader sources are dumped MESA_SHADER

[Mesa-dev] [Bug 91673] Segfault when calling glTexSubImage2D on storage texture to bound FBO

2015-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91673 Tapani Pälli changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Mesa-dev] [Bug 91711] mesa-9.1.3: undefined reference to `wglGetProcAddress@4'

2015-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91711 Bug ID: 91711 Summary: mesa-9.1.3: undefined reference to `wglGetProcAddress@4' Product: Mesa Version: 9.1 Hardware: x86 (IA32) OS: Linux (All)

[Mesa-dev] [Bug 91711] mesa-9.1.3: undefined reference to `wglGetProcAddress@4'

2015-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91711 YuGiOhJCJ changed: What|Removed |Added CC||yugioh...@1s.fr -- You are receiving this m

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-21 Thread Serge Martin (EdB)
On Wednesday 19 August 2015 11:56:08 Zoltan Gilian wrote: > There is no MDOperand in llvm 3.5. > > v2: Check if kernel metadata is present to avoid crash (EdB). > v3: Second attempt to avoid crash: switch off metadata query for llvm < 3.6. Since the change you made for image support won't be back

[Mesa-dev] [PATCH] mesa-demos: xeglthreads needs to add "-lX11 -lpthread" itself

2015-08-21 Thread Stefan Dirsch
Hi This is just a simple buildfix for current mesa-demos git master branch. Thanks, Stefan Author: Stefan Dirsch Subject: xeglthreads needs to add "-lX11 -lpthread" itself Signed-off-by: Stefan Dirsch xeglthreads no longer can rely on the toolchain to add the required libs, it uses directly.

Re: [Mesa-dev] [PATCH 01/12] nir/builder: include nir.h

2015-08-21 Thread Emil Velikov
On 14/08/15 23:30, Connor Abbott wrote: > This makes intelligent autocomplete plugins much happier. > "Include nir.h as we're using the structs and others defined within" - sounds a tad better, than blaiming it on the tool :P Normally you want headers in such a form that they can be used irrespec

Re: [Mesa-dev] [PATCH v3 1/2] mesa: Fix order of format + type and internal format checks for glTexImage ops

2015-08-21 Thread Eduardo Lima Mitev
On 08/18/2015 10:34 PM, Mark Janes wrote: > This patch regresses the following tests: > > piglit.spec.oes_compressed_paletted_texture.basic api > piglit.spec.oes_compressed_paletted_texture.basic api > piglit.spec.oes_compressed_etc1_rgb8_texture.basic > > When you submit v4, please verify that t

Re: [Mesa-dev] [PATCH] mesa: debug facility to replace shaders when running apps

2015-08-21 Thread Eero Tamminen
Hi, MESA_GLSL environment variable has few options which also dump shaders, but they're not useful for this because: * "dump": outputs "mangled" (per-processed) GLSL, to stdout * "log": outputs GLSL to file, but it goes to current directory (which app can change), adds comment to beginning o

Re: [Mesa-dev] [PATCH 4/6] glsl: add support for OES_texture_storage_multisample_2d_array

2015-08-21 Thread Lofstedt, Marta
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tapani Pälli > Sent: Friday, August 21, 2015 9:22 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH 4/6] glsl: add support for > OES_texture_storage_multisample_2d_array >

[Mesa-dev] [Bug 91673] Segfault when calling glTexSubImage2D on storage texture to bound FBO

2015-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91673 --- Comment #6 from Dongseong Hwang --- Wow, cool. Tapani Pälli, thank you for this quick fix. -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mes

[Mesa-dev] [PATCH] st/nine: Disable NV path, it's broken right now.

2015-08-21 Thread Krzysztof A. Sobiecki
st/nine: Disable NV path, it's broken right now. Signed-off-by: Krzysztof Sobiecki --- src/gallium/state_trackers/nine/device9.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c index 673

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-21 Thread Francisco Jerez
"Serge Martin (EdB)" writes: > On Wednesday 19 August 2015 11:56:08 Zoltan Gilian wrote: >> There is no MDOperand in llvm 3.5. >> >> v2: Check if kernel metadata is present to avoid crash (EdB). >> v3: Second attempt to avoid crash: switch off metadata query for llvm < 3.6. > > Since the change

Re: [Mesa-dev] [PATCH] st/mesa: pass through 4th opcode argument in bitmap/pixel visitors

2015-08-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Aug 21, 2015 at 2:07 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [PATCH] st/mesa: fix assignments with 4-operand arguments (i.e. BFI)

2015-08-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Aug 21, 2015 at 2:00 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > Cc: "10.6" > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [PATCH] mesa: update fbo state in glTexStorage

2015-08-21 Thread Brian Paul
On Thu, Aug 20, 2015 at 1:52 AM, Tapani Pälli wrote: > We have to re-validate FBOs rendering to the texture like is done > with TexImage and CopyTexImage. > > Signed-off-by: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91673 > Cc: "10.6" > --- > src/mesa/main/texstorag

Re: [Mesa-dev] Last try at AoA for Mesa 11 v4

2015-08-21 Thread Timothy Arceri
There is a new branch 'mesa_12' that addresses all Ian's comments. https://github.com/tarceri/Mesa_arrays_of_arrays.git In that branch 16/23 patches remain unreviewed. 3, 4 (r-b Ian but merged with Curro's changes), 7, 9, 10, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22 ___

Re: [Mesa-dev] [PATCH] mesa: debug facility to replace shaders when running apps

2015-08-21 Thread Brian Paul
On Fri, Aug 21, 2015 at 2:17 AM, Tapani Pälli wrote: > Patch adds shader source and replace functionality in to the compiler. > I had some very primitive support for this sort of thing already. See SHADER_SUBST in shaderapi.c However, feel free to replace it with something better/nicer. Also,

[Mesa-dev] [PATCH] i965: allow image_size on float images

2015-08-21 Thread Martin Peres
This got missed because the piglit test only tested int images to avoid a combinatiorial explosion of format, targets, stages and sizes which takes more than 5 minutes to test on nvidia's driver. This patch also drops the IMAGE_FUNCTION_AVAIL_ATOMIC which is not applicable to the image_size codepa

[Mesa-dev] [PATCH 1/2] nir: Replace fcsel with fmov instead of imov in nir_opt_undef

2015-08-21 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/glsl/nir/nir_opt_undef.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_opt_undef.c b/src/glsl/nir/nir_opt_undef.c index 4ab27a8..fb9c6bb 100644 --- a/src/glsl/nir/nir_opt_undef.c +++ b/src/glsl/nir/nir_opt_undef.c @@ -63,7 +

[Mesa-dev] [PATCH 2/2] i965/nir: Make use of nir_opt_undef

2015-08-21 Thread Boyan Ding
Shader-db result on Ivy Bridge: total instructions in shared programs: 145484 -> 145445 (-0.03%) instructions in affected programs: 225 -> 186 (-17.33%) helped:5 HURT: 0 Signed-off-by: Boyan Ding --- src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH] egl/wayland: define set_cloexec_or_close only when mkostemp is not present

2015-08-21 Thread Boyan Ding
Fixes a compiler warning of defined but not used function when HAVE_MKOSTEMP is defined. Signed-off-by: Boyan Ding --- src/egl/drivers/dri2/platform_wayland.c | 4 1 file changed, 4 insertions(+) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.

Re: [Mesa-dev] [PATCH] i965: allow image_size on float images

2015-08-21 Thread Francisco Jerez
The commit message should be prefixed "glsl:", this fix isn't i965-specific. Martin Peres writes: > This got missed because the piglit test only tested int images to avoid a > combinatiorial explosion of format, targets, stages and sizes which > takes more than 5 minutes to test on nvidia's dri

Re: [Mesa-dev] [PATCH 1/6] mesa: GetTexLevelParameter{if}v changes for OpenGL ES 3.1

2015-08-21 Thread Ilia Mirkin
On Fri, Aug 21, 2015 at 3:22 AM, Tapani Pälli wrote: > Patch refactors existing parameters check to first check common enums > between desktop GL and GLES 3.1 and modifies get_tex_level_parameter_image > to be compatible with enums specified in 3.1. > > Signed-off-by: Tapani Pälli > --- > src/me

Re: [Mesa-dev] [PATCH] i965: allow image_size on float images

2015-08-21 Thread Martin Peres
On 21/08/15 16:52, Francisco Jerez wrote: The commit message should be prefixed "glsl:", this fix isn't i965-specific. Martin Peres writes: This got missed because the piglit test only tested int images to avoid a combinatiorial explosion of format, targets, stages and sizes which takes mor

[Mesa-dev] [PATCH] i965: Move control flush into pipelined conditional render

2015-08-21 Thread Chris Wilson
The nv_conditional_render piglits were sporadically failing. Moving the control flush from the write and placing it just before the read was sufficient to make the piglits pass a 1000/1000 times. The bspec says that the flush enable bit "waits until all previous writes of immediate data from post s

Re: [Mesa-dev] [PATCH] i965: allow image_size on float images

2015-08-21 Thread Martin Peres
On 21/08/15 17:47, Martin Peres wrote: On 21/08/15 16:52, Francisco Jerez wrote: The commit message should be prefixed "glsl:", this fix isn't i965-specific. Ilia just warned me on IRC that I completely missed this comment... I guess the top-posting threw me off (even if it was entirely ju

Re: [Mesa-dev] [PATCH] i965: Move control flush into pipelined conditional render

2015-08-21 Thread Chris Wilson
On Fri, Aug 21, 2015 at 04:14:25PM +0100, Chris Wilson wrote: > The nv_conditional_render piglits were sporadically failing. Moving > the control flush from the write and placing it just before the read > was sufficient to make the piglits pass a 1000/1000 times. The bspec > says that the flush ena

[Mesa-dev] vlVaQueryImageFormats and vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities also return unsupported formats

2015-08-21 Thread Julien Isorce
Hi, vlVaQueryImageFormats (or vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities) implementation call pscreen->is_video_format_supported with input profile equal to PIPE_VIDEO_PROFILE_UNKNOWN. Problem is that "nouveau_vp3_screen_video_supported" or "rvid_is_format_supported" will returns several f

Re: [Mesa-dev] vlVaQueryImageFormats and vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities also return unsupported formats

2015-08-21 Thread Ilia Mirkin
On Fri, Aug 21, 2015 at 12:22 PM, Julien Isorce wrote: > What is the purpose of checking PIPE_VIDEO_PROFILE_UNKNOWN : > http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/nouveau_vp3_video.c#n486 > and > http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/radeon/rade

[Mesa-dev] End of my GSoC - Where to find the code

2015-08-21 Thread Thomas Helland
Hi all, Today is the "pencils down" date for Googles Summer of Code. I've cleaned up the loop analysis, LCSSA, and range propagation work I've done, and pushed them to my github repo at [1]. They are located in the branches gsoc-final- I'll leave them as is for a while, so that people have a

Re: [Mesa-dev] vlVaQueryImageFormats and vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities also return unsupported formats

2015-08-21 Thread Christian König
On 21.08.2015 18:30, Ilia Mirkin wrote: On Fri, Aug 21, 2015 at 12:22 PM, Julien Isorce wrote: What is the purpose of checking PIPE_VIDEO_PROFILE_UNKNOWN : http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/nouveau_vp3_video.c#n486 and http://cgit.freedesktop.org/mesa/mesa/t

Re: [Mesa-dev] [PATCH 00/12] bmake inspired fixes

2015-08-21 Thread Emil Velikov
On 03/08/15 19:09, Emil Velikov wrote: > On 3 August 2015 at 17:17, Matt Turner wrote: >> On Fri, Jul 17, 2015 at 11:53 AM, Emil Velikov >> wrote: >>> On 17 July 2015 at 19:09, Matt Turner wrote: On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov wrote: > Hello all, > > A fe

[Mesa-dev] [PATCH] glsl: fix error message when validating tcs output decls

2015-08-21 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index c7ce409..046390d 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -3317,7 +3317,7 @@ handle_tess_

Re: [Mesa-dev] [PATCH] glsl: fix error message when validating tcs output decls

2015-08-21 Thread Marek Olšák
"tess" -> "tessellation", with that done: Reviewed-by: Marek Olšák Marek On Fri, Aug 21, 2015 at 9:08 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/glsl/ast_to_hir.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/gls

Re: [Mesa-dev] [PATCH] glsl: fix error message when validating tcs output decls

2015-08-21 Thread Ilia Mirkin
Oh wow, I was *sure* that wasn't going to fit, but it *just* fits into 80 chars :) Fixing and pushing. On Fri, Aug 21, 2015 at 3:14 PM, Marek Olšák wrote: > "tess" -> "tessellation", with that done: > > Reviewed-by: Marek Olšák > > Marek > > On Fri, Aug 21, 2015 at 9:08 PM, Ilia Mirkin wrote:

Re: [Mesa-dev] [PATCH] st/nine: Disable NV path, it's broken right now.

2015-08-21 Thread Axel Davy
This patch is the result of several discussions on our irc channels. I amended the commit message to: st/nine: Always use user constant buffers We had several reports of users hitting bugs with the other path to upload constants, and switching to the user constant buffer path solves the bugs.

Re: [Mesa-dev] [PATCH] st/nine: Disable NV path, it's broken right now.

2015-08-21 Thread Ilia Mirkin
On Fri, Aug 21, 2015 at 3:54 PM, Axel Davy wrote: > This patch is the result of several discussions on our irc channels. > > I amended the commit message to: > > st/nine: Always use user constant buffers > > We had several reports of users hitting bugs > with the other path to upload constants, >

Re: [Mesa-dev] [PATCH 02/71] target/d3dadapter9: Return Windows like card names

2015-08-21 Thread Axel Davy
As far as I know, the mapping is not an official one. Games usually do not use the card name to apply card specific workarounds, instead they use the vendor or the device id. However the names are sometimes used in configuration files to match the user set configuration to a card (and reset if t

Re: [Mesa-dev] [PATCH] mesa: GetTexLevelParameter{if}v changes for OpenGL ES 3.1

2015-08-21 Thread Anuj Phogat
On Tue, Aug 18, 2015 at 12:43 AM, Tapani Pälli wrote: > Patch refactors existing parameters check to first check common enums > between desktop GL and GLES 3.1 and modifies get_tex_level_parameter_image > to be compatible with enums specified in 3.1. > > Signed-off-by: Tapani Pälli > --- > src/m

Re: [Mesa-dev] [PATCH 1/2] mesa/formats: only do type and component lookup for uncompressed formats

2015-08-21 Thread Chad Versace
On Wed 19 Aug 2015, Nanley Chery wrote: > From: Nanley Chery > > Only uncompressed formats have a non-void type and actual components per > pixel. > Rename _mesa_format_to_type_and_comps to > _mesa_uncompressed_format_to_type_and_comps and require callers to check if > the format is not compress

Re: [Mesa-dev] [PATCH] st/nine: Disable NV path, it's broken right now.

2015-08-21 Thread Marek Olšák
On Fri, Aug 21, 2015 at 9:59 PM, Ilia Mirkin wrote: > On Fri, Aug 21, 2015 at 3:54 PM, Axel Davy wrote: >> This patch is the result of several discussions on our irc channels. >> >> I amended the commit message to: >> >> st/nine: Always use user constant buffers >> >> We had several reports of us

Re: [Mesa-dev] [PATCH 2/2] mesa/formats: make format testing a gtest

2015-08-21 Thread Chad Versace
On Wed 19 Aug 2015, Nanley Chery wrote: > From: Nanley Chery > > We currently check that our format info table is sane during context > initialization in debug builds. Perform this check during > `make check` instead. This enables format testing in release builds > and removes the requirement of

Re: [Mesa-dev] [PATCH v3] mesa/formats: refactor by removing compressed formats

2015-08-21 Thread Chad Versace
On Wed 19 Aug 2015, Nanley Chery wrote: > From: Nanley Chery > > All compressed formats return GL_FALSE and there isn't any evidence to > support that this behaviour would change. Remove all switch cases for > compressed formats. > > v2. Since the exhaustive switch is removed, add a gtest to ens

Re: [Mesa-dev] [PATCH 1/2] nir: Replace fcsel with fmov instead of imov in nir_opt_undef

2015-08-21 Thread Matt Turner
On Fri, Aug 21, 2015 at 6:42 AM, Boyan Ding wrote: > Signed-off-by: Boyan Ding > --- > src/glsl/nir/nir_opt_undef.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/nir/nir_opt_undef.c b/src/glsl/nir/nir_opt_undef.c > index 4ab27a8..fb9c6bb 100644 > --- a/src/gls

Re: [Mesa-dev] [PATCH 2/2] i965/nir: Make use of nir_opt_undef

2015-08-21 Thread Matt Turner
On Fri, Aug 21, 2015 at 6:42 AM, Boyan Ding wrote: > Shader-db result on Ivy Bridge: > total instructions in shared programs: 145484 -> 145445 (-0.03%) > instructions in affected programs: 225 -> 186 (-17.33%) > helped:5 > HURT:

Re: [Mesa-dev] [PATCH] egl/wayland: define set_cloexec_or_close only when mkostemp is not present

2015-08-21 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3] mesa: Implement glMemoryBarrierByRegion

2015-08-21 Thread Rob Clark
so this one appears to break gles dispatch (on i965, but probably others).. Somehow glCheckFramebufferStatus() ends up in _mesa_DeleteFramebuffers(), which doesn't go so well.. not sure I understand the dispatch code to understand what the issue is. But could someone either fix it or revert this

[Mesa-dev] [PATCH 1/3] i965: Abort tiled_memcpy path for ReadPixels in case of transfer operations

2015-08-21 Thread Anuj Phogat
We have a similar check in meta pbo path. Cc: Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_pixel_read.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c b/src/mesa/drivers/dri/i965/intel_pixel_read.c index 3fe506e..55f6852 1

[Mesa-dev] [PATCH 3/3] meta: Abort meta pbo path if TexSubImage need signed unsigned conversion

2015-08-21 Thread Anuj Phogat
See similar fix for Readpixels in mesa commit 0d20790. Jason suggested we need that for TexSubImage as well. Cc: Cc: Jason Ekstrand Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta_tex_subimage.c | 43 + 1 file changed, 25 insertions(+), 18 deletions(-)

[Mesa-dev] [PATCH 2/3] i965: Abort tiled_memcpy path for TexSubImage in case of transfer operations

2015-08-21 Thread Anuj Phogat
We have a similar check in meta pbo path. Cc: Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965/intel_tex_subimage.c index 31e511f..74bf

Re: [Mesa-dev] [PATCH] egl/wayland: define set_cloexec_or_close only when mkostemp is not present

2015-08-21 Thread Thomas Helland
2015-08-21 15:44 GMT+02:00 Boyan Ding : > Fixes a compiler warning of defined but not used function when > HAVE_MKOSTEMP is defined. > > Signed-off-by: Boyan Ding > --- > src/egl/drivers/dri2/platform_wayland.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/egl/drivers/dri2/plat

Re: [Mesa-dev] [PATCH 2/2] i965/nir: Make use of nir_opt_undef

2015-08-21 Thread Thomas Helland
2015-08-21 15:42 GMT+02:00 Boyan Ding : > Shader-db result on Ivy Bridge: > total instructions in shared programs: 145484 -> 145445 (-0.03%) > instructions in affected programs: 225 -> 186 (-17.33%) > helped:5 > HURT: 0 > I can r

Re: [Mesa-dev] [PATCH 1/2] nir: Replace fcsel with fmov instead of imov in nir_opt_undef

2015-08-21 Thread Boyan Ding
2015-08-22 5:36 GMT+08:00 Matt Turner : > On Fri, Aug 21, 2015 at 6:42 AM, Boyan Ding wrote: >> Signed-off-by: Boyan Ding >> --- >> src/glsl/nir/nir_opt_undef.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/glsl/nir/nir_opt_undef.c b/src/glsl/nir/nir_opt_undef.c

Re: [Mesa-dev] [PATCH 2/2] i965/nir: Make use of nir_opt_undef

2015-08-21 Thread Boyan Ding
2015-08-22 7:13 GMT+08:00 Thomas Helland : > 2015-08-21 15:42 GMT+02:00 Boyan Ding : >> Shader-db result on Ivy Bridge: >> total instructions in shared programs: 145484 -> 145445 (-0.03%) >> instructions in affected programs: 225 -> 186 (-17.33%) >> helped:5 >> H

Re: [Mesa-dev] [PATCH] i965: Move control flush into pipelined conditional render

2015-08-21 Thread Kenneth Graunke
On Friday, August 21, 2015 04:14:25 PM Chris Wilson wrote: > The nv_conditional_render piglits were sporadically failing. Moving > the control flush from the write and placing it just before the read > was sufficient to make the piglits pass a 1000/1000 times. The bspec > says that the flush enable

[Mesa-dev] [PATCH 2/2] nir: Use nir_shader::stage rather than passing it around.

2015-08-21 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/glsl/nir/glsl_to_nir.cpp| 10 -- src/glsl/nir/nir.h | 3 +-- src/glsl/nir/nir_lower_samplers.cpp | 6 +++--- src/mesa/drivers/dri/i965/brw_nir.c | 2 +- 4 files changed, 9 insertions(+), 12 deletions(-) diff --git a/src/g

[Mesa-dev] [PATCH 1/2] nir: Store gl_shader_stage in nir_shader.

2015-08-21 Thread Kenneth Graunke
This makes it easy for NIR passes to inspect what kind of shader they're operating on. Thanks to Michel Dänzer for helping me figure out where TGSI stores the shader stage information. Signed-off-by: Kenneth Graunke --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 25 + src

Re: [Mesa-dev] [PATCH 2/3 v2] i965: Swap the order of the vertex ID and edge flag attributes

2015-08-21 Thread Ben Widawsky
top-post to start from fresh... Okay, so after a serious attempt at attempting to write something which I think is "more" correct, I failed. I'm planning to just push your patches (with my r-b and t-b) after I finish a jenkins run. Unless anyone has arguments. My biggest confusion is the use of t

Re: [Mesa-dev] [PATCH 2/3 v2] i965: Swap the order of the vertex ID and edge flag attributes

2015-08-21 Thread Kristian Høgsberg
On Fri, Aug 21, 2015 at 10:14 PM, Ben Widawsky wrote: > top-post to start from fresh... > > Okay, so after a serious attempt at attempting to write something which I > think > is "more" correct, I failed. I'm planning to just push your patches (with my > r-b and t-b) after I finish a jenkins run.