[Mesa-dev] [PATCH 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-02 Thread Oded Gabbay
This patch fixes a bug that is manifested in the read path of mesa when running on big-endian machines. The effects can be seen when running piglit sanity test and/or taking a screen capture. The bug is caused when _mesa_format_convert receives src_format as mesa_format, which it thens changes to

[Mesa-dev] [PATCH 1/2] mesa: clear existing swizzle info before bitwise-OR

2015-08-02 Thread Oded Gabbay
This patch fixes a bug in big-endian handling, where the previous swizzle info wasn't cleared before a new swizzle info was inserted into the format field using a bitwise-OR operation. Signed-off-by: Oded Gabbay CC: "10.5 10.6" --- src/mesa/main/formats.h | 3 +++ 1 file changed, 3 insertions(+

[Mesa-dev] [Bug 91468] LLVM 3.8(svn): llvm changes llvm-config output again?

2015-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91468 --- Comment #8 from Krzysztof A. Sobiecki --- I was trying to contact maintainer of http://llvm.org/apt/unstable/, now I will fill a bug on llvms bugzilla. -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 91468] LLVM 3.8(svn): llvm changes llvm-config output again?

2015-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91468 Krzysztof A. Sobiecki changed: What|Removed |Added URL||https://llvm.org/bugs/show_

[Mesa-dev] [PATCH 1/3] r600g: fix the single-sample fast clear setup

2015-08-02 Thread Marek Olšák
From: Marek Olšák No effect, but this is what we should be doing. --- src/gallium/drivers/r600/evergreen_state.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c index 7065af9..5c8

[Mesa-dev] [PATCH 3/3] r600g: re-enable single-sample fast clear

2015-08-02 Thread Marek Olšák
From: Marek Olšák Fixed by the CB_SHADER_MASK fix. --- src/gallium/drivers/r600/r600_blit.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/drivers/r600/r600_blit.c index 1c59230..8664e03 100644 --- a/src/gallium/drive

[Mesa-dev] [PATCH 2/3] r600g: fix the CB_SHADER_MASK setup

2015-08-02 Thread Marek Olšák
From: Marek Olšák This fixes the single-sample fast clear hang. Cc: 10.6 --- src/gallium/drivers/r600/evergreen_state.c | 8 src/gallium/drivers/r600/r600_shader.c | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/s

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2015-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 88780, which changed state. Bug 88780 Summary: Several Unity3D-based games render with "foggy blueish overlay" https://bugs.freedesktop.org/show_bug.cgi?id=88780 What|Removed |Added ---

Re: [Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_FS_PROG_DATA in gen6_renderbuffer_surfaces.

2015-08-02 Thread Kenneth Graunke
On Saturday, August 01, 2015 05:43:26 PM Emil Velikov wrote: > On 6 July 2015 at 21:40, Kenneth Graunke wrote: > > On Monday, July 06, 2015 12:18:18 PM Matt Turner wrote: > >> On Mon, Jul 6, 2015 at 9:55 AM, Kenneth Graunke > >> wrote: > >> > It looks like this was forgotten in commit 3c9dc2d31b

Re: [Mesa-dev] [PATCH 1/3] r600g: fix the single-sample fast clear setup

2015-08-02 Thread Dieter Nützel
Am 02.08.2015 15:36, schrieb Marek Olšák: From: Marek Olšák No effect, but this is what we should be doing. Hello Marek, who should test this on which stuff? BTW Do you think, we see GL 4.1 on r600g (Turks ;-) with 11.0.1? Great work! -Dieter --- src/gallium/drivers/r600/evergreen_state

[Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Alejandro Seguí
--- src/glsl/ir_print_visitor.cpp | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/glsl/ir_print_visitor.cpp b/src/glsl/ir_print_visitor.cpp index 78475f3..641a996 100644 --- a/src/glsl/ir_print_visitor.cpp +++ b/src/glsl/ir_print_visitor.cpp @@ -25,7 +2

[Mesa-dev] [PATCH] clover: clEnqueue* should block when asked for

2015-08-02 Thread EdB
As a side effect, this fix clRetain/ReleaseEvent Piglit test --- src/gallium/state_trackers/clover/api/transfer.cpp | 29 -- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/transfer.cpp b/src/gallium/state_trackers/clover/ap

Re: [Mesa-dev] [PATCH 3/3] r600g: re-enable single-sample fast clear

2015-08-02 Thread Dieter Nützel
Am 02.08.2015 15:36, schrieb Marek Olšák: From: Marek Olšák Fixed by the CB_SHADER_MASK fix. Hurray, r600g (Turks) ~10% performance drop for Mesa's 'objview' is _mostly_ fixed. Mostly 'cause it is NOT on par as before (the 'broken') version. E.g. 'buddha' was stable at 600 FPS (see below).

Re: [Mesa-dev] [PATCH 1/3] r600g: fix the single-sample fast clear setup

2015-08-02 Thread Marek Olšák
On Sun, Aug 2, 2015 at 7:05 PM, Dieter Nützel wrote: > Am 02.08.2015 15:36, schrieb Marek Olšák: >> >> From: Marek Olšák >> >> No effect, but this is what we should be doing. > > > Hello Marek, > > who should test this on which stuff? I've tested it. > BTW Do you think, we see GL 4.1 on r600g (

Re: [Mesa-dev] [PATCH 3/3] r600g: re-enable single-sample fast clear

2015-08-02 Thread Dieter Nützel
Am 02.08.2015 19:54, schrieb Dieter Nützel: Am 02.08.2015 15:36, schrieb Marek Olšák: From: Marek Olšák Fixed by the CB_SHADER_MASK fix. Hurray, r600g (Turks) ~10% performance drop for Mesa's 'objview' is _mostly_ fixed. Mostly 'cause it is NOT on par as before (the 'broken') version. E.g

Re: [Mesa-dev] [PATCH 3/3] r600g: re-enable single-sample fast clear

2015-08-02 Thread Marek Olšák
On Sun, Aug 2, 2015 at 9:03 PM, Dieter Nützel wrote: > Am 02.08.2015 19:54, schrieb Dieter Nützel: >> >> Am 02.08.2015 15:36, schrieb Marek Olšák: >>> >>> From: Marek Olšák >>> >>> Fixed by the CB_SHADER_MASK fix. >> >> >> Hurray, >> >> r600g (Turks) ~10% performance drop for Mesa's 'objview' is

Re: [Mesa-dev] [PATCH 3/3] r600g: re-enable single-sample fast clear

2015-08-02 Thread Dieter Nützel
Am 02.08.2015 21:11, schrieb Marek Olšák: On Sun, Aug 2, 2015 at 9:03 PM, Dieter Nützel wrote: Am 02.08.2015 19:54, schrieb Dieter Nützel: Am 02.08.2015 15:36, schrieb Marek Olšák: From: Marek Olšák Fixed by the CB_SHADER_MASK fix. Hurray, r600g (Turks) ~10% performance drop for Mesa'

Re: [Mesa-dev] [PATCH 1/3] r600g: fix the single-sample fast clear setup

2015-08-02 Thread Dave Airlie
For the series, Reviewed-by: Dave Airlie On 2 August 2015 at 23:36, Marek Olšák wrote: > From: Marek Olšák > > No effect, but this is what we should be doing. > --- > src/gallium/drivers/r600/evergreen_state.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/sr

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Timothy Arceri
On Sun, 2015-08-02 at 19:50 +0200, Alejandro Seguí wrote: Maybe just for completeness you could add this to the commit message The util/hash_table was intended to be a fast hash table replacement for the program/hash_table see 35fd61bd99c1 and 72e55bb6888ff. > --- > src/glsl/ir_print_visitor.cp

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Chris Forbes
Some perf numbers would be nice. How much is this winning? - Chris On Mon, Aug 3, 2015 at 11:18 AM, Timothy Arceri wrote: > On Sun, 2015-08-02 at 19:50 +0200, Alejandro Seguí wrote: > > Maybe just for completeness you could add this to the commit message > > The util/hash_table was intended to b

[Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Alejandro Seguí
The util/hash_table was intended to be a fast hash table replacement for the program/hash_table see 35fd61bd99c1 and 72e55bb6888ff. --- src/glsl/ir_print_visitor.cpp | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/glsl/ir_print_visitor.cpp b/src/glsl/ir_

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Ilia Mirkin
Given that this is a debug-only thing, I doubt perf numbers are that interesting. I have no clue what the diff is between the two hash tables, but if one is allegedly faster than the other, that should be determined, and we should just mass-migrate... -ilia On Sun, Aug 2, 2015 at 8:05 PM, Chri

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Chris Forbes
Oh, fair enough then. On Aug 3, 2015 12:39 PM, "Ilia Mirkin" wrote: > Given that this is a debug-only thing, I doubt perf numbers are that > interesting. > > I have no clue what the diff is between the two hash tables, but if > one is allegedly faster than the other, that should be determined, an

[Mesa-dev] help: mesa GL_OES_mapbuffer

2015-08-02 Thread ????????
it did not work. off screen rendering might be a walkaround, but would it work for pixel buffer surface? thanks. hilbert___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] help:eglCopyBuffers

2015-08-02 Thread ????????
background: 1)ubuntu 2)libgles1-mesa-dev libgles2-mesa-dev installed problem surface=eglCreatePbufferSurface Pixmap = XCreatePixmap(d,w,width,height,32); eglCopyBuffers(dpy,sur, EGLNativePixmap)pixmap) returns EGL_FALSE; eglGetError()= 0x3000 Question: 1) was what I did right? 2)I got X Erro

Re: [Mesa-dev] help: mesa GL_OES_mapbuffer

2015-08-02 Thread Ilia Mirkin
https://www.khronos.org/registry/gles/extensions/OES/OES_mapbuffer.txt This extension adds to the vertex buffer object functionality supported by OpenGL ES 1.1 or ES 2.0 by allowing the entire data storage of a buffer object to be mapped into the client's address space. So this only a

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Alejandro Seguí Díaz
I'm starting to contribute and Timothy Arceri told me about this task. The change was made at that sole file because we talked about no need to migrate all tables at once, but we discuss this and I take note to migrate all hash tables at once if everyone agrees. PS.: I forgot to add Reviewed-by Ti

[Mesa-dev] [PATCH 1/2] glsl: add variable mode check to build_stageref

2015-08-02 Thread Tapani Pälli
Currently stage reference mask is built using the variable name only. However it can happen that input of one stage has same name as output from another stage. Adding check of variable mode makes sure we do not pick wrong variable. Fixes some subcases from ES31-CTS.program_interface_query.no-lo

[Mesa-dev] [PATCH 2/2] mesa: fix ARRAY_SIZE query for GetProgramResourceiv

2015-08-02 Thread Tapani Pälli
Fixes rest of the failures with ES31-CTS.program_interface_query.no-locations Signed-off-by: Tapani Pälli --- src/mesa/main/shader_query.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index b49fd38

Re: [Mesa-dev] [PATCH] mesa: fix type for array indexing validation

2015-08-02 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 08/02/2015 04:47 AM, Timothy Arceri wrote: parse_program_resource_name returns -1 when the index is invalid this needs to be tested before assigning the value to the unsigned array_index. In link_varyings.cpp (the other place parse_program_resource_name is used) af

[Mesa-dev] [PATCH 00/21] Resolve GCC sign-compare warnings patchset

2015-08-02 Thread Rhys Kidd
GCC warns on -Wsign-compare in a number of locations within i965. This patchset goes a significant way to addressing these compiler warnings. Changes have been made with preference to remain consistent with immediate context of that file, rather than the whole patchset adopting one approach. No p

[Mesa-dev] [PATCH 03/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/intel_fbo.c: In function 'intel_blit_framebuffer_with_blitter': mesa/src/mesa/drivers/dri/i965/intel_fbo.c:836:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < drawFb->_NumColorDrawBuffers; i++) {

[Mesa-dev] [PATCH 04/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/intel_screen.c: In function 'aub_dump_bmp': mesa/src/mesa/drivers/dri/i965/intel_screen.c:125:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < fb->_NumColorDrawBuffers; i++) { ^ Si

[Mesa-dev] [PATCH 10/21] mesa/gbm: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/gbm/main/backend.c: In function 'find_backend': mesa/src/gbm/main/backend.c:70:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(backends); ++i) { ^ mesa/src/gbm/main/backend.c: In function '_gbm_creat

[Mesa-dev] [PATCH 14/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_primitive_restart.c: In function 'can_cut_index_handle_prims': mesa/src/mesa/drivers/dri/i965/brw_primitive_restart.c:94:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < nr_prims; i++) {

[Mesa-dev] [PATCH 12/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_draw.c: In function 'brw_draw_destroy': mesa/src/mesa/drivers/dri/i965/brw_draw.c:630:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < brw->vb.nr_buffers; i++) { ^ mesa/src/mesa/drivers

[Mesa-dev] [PATCH 18/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c: In function 'brw_upload_abo_surfaces': mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c:961:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < prog->NumAtomicBuffers; i++) {

[Mesa-dev] [PATCH 05/21] mesa: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/common/utils.c: In function 'driGetConfigAttrib': mesa/src/mesa/drivers/dri/common/utils.c:457:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(attribMap); i++) ^ Signed-off-by: Rh

[Mesa-dev] [PATCH 11/21] mesa/egl: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/egl/drivers/dri2/platform_drm.c: In function 'release_buffer': mesa/src/egl/drivers/dri2/platform_drm.c:73:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(dri2_surf->color_buffers); i++) { ^ mesa/src

[Mesa-dev] [PATCH 02/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_wm_state.c: In function 'brw_color_buffer_write_enabled': mesa/src/mesa/drivers/dri/i965/brw_wm_state.c:53:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->DrawBuffer->_NumColorDrawBuffers; i++) {

[Mesa-dev] [PATCH 08/21] mesa/glx: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/glx/dri_common.c: In function 'scalarEqual': mesa/src/glx/dri_common.c:259:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(attribMap); i++) ^ Signed-off-by: Rhys Kidd --- src/glx/dri_common.c | 2

[Mesa-dev] [PATCH 01/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_draw.c: In function 'brw_postdraw_set_buffers_need_resolve': mesa/src/mesa/drivers/dri/i965/brw_draw.c:390:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < fb->_NumColorDrawBuffers; i++) {

[Mesa-dev] [PATCH 09/21] mesa/glx: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/glx/dri_common_query_renderer.c: In function 'dri2_convert_glx_query_renderer_attribs': mesa/src/glx/dri_common_query_renderer.c:61:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(query_renderer_map); i++)

[Mesa-dev] [PATCH 15/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_state_cache.c: In function 'brw_try_upload_using_copy': mesa/src/mesa/drivers/dri/i965/brw_state_cache.c:216:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < cache->size; i++) { ^ Sig

[Mesa-dev] [PATCH 19/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_vs_surface_state.c: In function 'brw_upload_pull_constants': mesa/src/mesa/drivers/dri/i965/brw_vs_surface_state.c:84:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < prog_data->nr_pull_params; i++) {

[Mesa-dev] [PATCH 16/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_tex_layout.c: In function 'brw_miptree_layout_texture_array': mesa/src/mesa/drivers/dri/i965/brw_tex_layout.c:560:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int q = 0; q < mt->level[level].depth; q++) {

[Mesa-dev] [PATCH 13/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c: In function 'brw_prepare_vertices': mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c:434:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = j = 0; i < brw->vb.nr_enabled; i++) {

[Mesa-dev] [PATCH 06/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/intel_fbo.c: In function 'intel_validate_framebuffer': mesa/src/mesa/drivers/dri/i965/intel_fbo.c:734:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(fb->Attachment); i++) { ^

[Mesa-dev] [PATCH 07/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/intel_screen.c: In function 'intel_screen_make_configs': mesa/src/mesa/drivers/dri/i965/intel_screen.c:1222:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < ARRAY_SIZE(formats); i++) {

[Mesa-dev] [PATCH 17/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c: In function 'brw_upload_ubo_surfaces': mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c:901:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < shader->NumUniformBlocks; i++) {

[Mesa-dev] [PATCH 20/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c: In function 'gen6_upload_push_constants': mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c:85:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < prog_data->nr_params; i++) {

[Mesa-dev] [PATCH 21/21] i965/gen7: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/gen7_sol_state.c: In function 'gen7_upload_3dstate_so_decl_list': mesa/src/mesa/drivers/dri/i965/gen7_sol_state.c:119:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < linked_xfb_info->NumOutputs; i++) {

Re: [Mesa-dev] [PATCH 2/2] mesa: fix ARRAY_SIZE query for GetProgramResourceiv

2015-08-02 Thread Tapani Pälli
Sorry, this is not right, forget about this patch :/ On 08/03/2015 09:02 AM, Tapani Pälli wrote: Fixes rest of the failures with ES31-CTS.program_interface_query.no-locations Signed-off-by: Tapani Pälli --- src/mesa/main/shader_query.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 d

Re: [Mesa-dev] [PATCH 01/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Matt Turner
On Sun, Aug 2, 2015 at 11:09 PM, Rhys Kidd wrote: > mesa/src/mesa/drivers/dri/i965/brw_draw.c: In function > 'brw_postdraw_set_buffers_need_resolve': > mesa/src/mesa/drivers/dri/i965/brw_draw.c:390:22: warning: comparison between > signed and unsigned integer expressions [-Wsign-compare] > f

Re: [Mesa-dev] [PATCH 06/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Matt Turner
On Sun, Aug 2, 2015 at 11:09 PM, Rhys Kidd wrote: > mesa/src/mesa/drivers/dri/i965/intel_fbo.c: In function > 'intel_validate_framebuffer': > mesa/src/mesa/drivers/dri/i965/intel_fbo.c:734:18: warning: comparison > between signed and unsigned integer expressions [-Wsign-compare] > for (i = 0

Re: [Mesa-dev] [PATCH] mesa: fix type for array indexing validation

2015-08-02 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev