Re: [Mesa-dev] [PATCH v2] auxiliary/vl: use the correct screen index

2015-07-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jul 10, 2015 at 10:27 PM, Emil Velikov wrote: > Inspired (copied) from Marek's commit for egl/x11 > commit 0b56e23e7f3(egl/dri2: use the correct screen index) > > v2: Fix copy/pasta errors. > > Cc: 10.6 > Cc: Marek Olšák > Signed-off-by: Emil Velikov >

Re: [Mesa-dev] [PATCH 3/4] radeon, r200: allow hyperz for radeon DRM module v2

2015-07-11 Thread Marek Olšák
On Fri, Jul 10, 2015 at 11:02 PM, Roland Scheidegger wrote: > Am 10.07.2015 um 19:41 schrieb Emil Velikov: >> On 10 July 2015 at 13:18, Roland Scheidegger wrote: >>> Am 10.07.2015 um 05:44 schrieb Michel Dänzer: On 10.07.2015 05:13, Emil Velikov wrote: > The original code only half consi

Re: [Mesa-dev] [PATCH] i965: Replace illegal compacted NOP with valid compact instruction

2015-07-11 Thread Zhenyu Wang
On 2015.07.10 12:13:39 -0700, Matt Turner wrote: > > With those small changes, this patch is > > Reviewed-by: Matt Turner > > I'd be happy to make the changes myself and commit the patch if you'd > like -- just tell me so. :) > yeah, please go ahead! ;) Thanks for the review, Matt. -- Open

Re: [Mesa-dev] [PATCH 1/2] gallium/drivers: Add threadsafe wrappers for pipe_context v2

2015-07-11 Thread Marek Olšák
Hi, the surface_destroy and sampler_view_destroy wrappers won't be called, because surface->context and view->context are always used for those calls and "context" points to the driver context in this case. The solution is to update the "context" pointer in create_sampler_view and create_surface i

Re: [Mesa-dev] [PATCH 2/2] clover: Use threadsafe wrappers for pipe_context v2

2015-07-11 Thread Francisco Jerez
Tom Stellard writes: > Events can be added to an OpenCL command queue concurrently from multiple > threads, but pipe_context bjects are not threadsafe. The threadsafe > wrappers protect all pipe_context function calls with a mutex, so we > can safely use them with multiple threads. > > v2: > -

Re: [Mesa-dev] [PATCH] clover: Fix bug with computing hard_event status

2015-07-11 Thread Francisco Jerez
Tom Stellard writes: > pipe_context::flush() can return a NULL fence if the queue is already > empty, so we should not assume that an event with a NULL fence > has the status of CL_QUEUED. > This seems suspicious... On the one hand it doesn't seem to be a documented "feature" of pipe_context::f

Re: [Mesa-dev] [PATCH 3/4] radeon, r200: allow hyperz for radeon DRM module v2

2015-07-11 Thread Roland Scheidegger
Am 11.07.2015 um 11:25 schrieb Marek Olšák: > On Fri, Jul 10, 2015 at 11:02 PM, Roland Scheidegger > wrote: >> Am 10.07.2015 um 19:41 schrieb Emil Velikov: >>> On 10 July 2015 at 13:18, Roland Scheidegger wrote: Am 10.07.2015 um 05:44 schrieb Michel Dänzer: > On 10.07.2015 05:13, Emil V

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #34 from Heiko --- I'm also in for the tooltip corruption. I'd say it started around the time when chromium added/enabled aura/ash or what that custom OpenGL-based frontend is called. Though, I thought it's something specific to my ma

[Mesa-dev] [PATCH] nvc0: fix geometry program revalidation of clipping params

2015-07-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- Even though in practice a geometry program will never be using UCP's, we still were revalidating (aka recompiling) the program when more clip planes became enabled (which also are used for regular clip distances). This seems li

[Mesa-dev] [PATCH v2] glsl: avoid compiler's segfault when processing operators with void arguments

2015-07-11 Thread Renaud Gaubert
This is done by returning an rvalue of type void in the ast_function_expression::hir function instead of a void expression. This produces (in the case of the ternary) an hir with a call to the void returning function and an assignment of a void variable which will be optimized out (the assignment)

Re: [Mesa-dev] [PATCH] [v3] i965: Split out gen8 push constant state upload

2015-07-11 Thread Kenneth Graunke
On Thursday, July 09, 2015 11:00:40 AM Ben Widawsky wrote: > While implementing the workaround in the previous patch I noticed things were > starting to get a bit messy. Since gen8 works differently enough from gen7, I > thought splitting it out with be good. IMHO this is still a bit messy. What

Re: [Mesa-dev] [PATCH 5/5] i965: Optimize batchbuffer macros.

2015-07-11 Thread Chris Wilson
On Fri, Jul 10, 2015 at 11:44:59AM -0700, Matt Turner wrote: > Previously OUT_BATCH was just a macro around an inline function which > does > >brw->batch.map[brw->batch.used++] = dword; > > When making consecutive calls to intel_batchbuffer_emit_dword() the > compiler isn't able to recognize

Re: [Mesa-dev] [PATCH 2/5] i965: Turn emit_vertex_buffer_state() into a macro.

2015-07-11 Thread Chris Wilson
On Fri, Jul 10, 2015 at 11:44:56AM -0700, Matt Turner wrote: > Its uses of OUT_BATCH will need a local variable defined by BEGIN_BATCH. > > Increases .text size by 8 bytes. I don't like having to replace functions with macros, so I would suggest you pass idx in and then return it from the functio

Re: [Mesa-dev] [PATCH 4/5] i965: Split batch emission from relocation functions.

2015-07-11 Thread Chris Wilson
On Fri, Jul 10, 2015 at 11:44:58AM -0700, Matt Turner wrote: > So that everything writing to the batch between BEGIN_BATCH() and > ADVANCE_BATCH() goes through OUT_BATCH. Reviewed-by: Chris Wilson > +#define OUT_RELOC64(buf, read_domains, write_domain, delta) do {\ > + uint64_t reloc64

[Mesa-dev] [PATCHv2 7/7] configure.ac: check for mkostemp()

2015-07-11 Thread Emil Velikov
We can make use of it over mkstemp + fcntl in the egl/wayland code. Cc: Axel Davy Suggested-by: Matt Turner Signed-off-by: Emil Velikov --- v2: define HAVE_MKOSTEMP in order to use mkostemp rather than nuking it. configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b

[Mesa-dev] [PATCH 2/4] radeon/r200: mark state atoms as dirty after blits

2015-07-11 Thread sroland
From: Roland Scheidegger Blit submits lots of packets which are usually handled by state atoms, so these must be dirtied. Not sure if this fixes anything, but it was a concern raised by bug 51658 (with this all issues there seen as actual bugs should be fixed, with the exception of the patch to u

[Mesa-dev] [PATCH 1/4] r200: fix fbo rendering by disabling optimized texture format chooser

2015-07-11 Thread sroland
From: Roland Scheidegger It is rather unfortunate that we don't know if a texture is going to be used as a rt later, and we lack the means to do something about a format chosen which we can't render to directly, so disable this and always chose renderable format for rgba8 textures. This addresses

[Mesa-dev] [PATCH 3/4] radeon: fix some potential big endian issues

2015-07-11 Thread sroland
From: Roland Scheidegger The formats chosen (both by texture format choser, fbo storage allocation) are different for big endian not just for rgba8 but also lower bit width formats (why I don't actually know). Even the function to test for renderable formats used different formats, however the ac

[Mesa-dev] [PATCH 4/4] r200: fix some potential big endian issues

2015-07-11 Thread sroland
From: Roland Scheidegger The formats chosen (both by texture format choser, fbo storage allocation) are different for big endian not just for rgba8 but also lower bit width formats (why I don't actually know). Even the function to test for renderable formats used different formats, however the ac

[Mesa-dev] [Bug 90073] Leaks in xcb_dri3_open_reply_fds() and get_render_node_from_id_path_tag

2015-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90073 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 0/2] doxygen: Properly handle doxygen_sqlite3.db output file

2015-07-11 Thread Emil Velikov
On 27 June 2015 at 04:14, Rhys Kidd wrote: > A simple patch set for my first proposed Mesa contribution. > > Modern doxygen uses a SQLite intermediate output file when producing > documentation from source code. Mesa's Makefile and .gitignore in doxygen/ > could better handle this output file, whi

[Mesa-dev] Mesa 10.6.2

2015-07-11 Thread Emil Velikov
Mesa 10.6.2 is now available. This time around we have a considerable list of fixes, most of which in the glsl, core mesa, and i965 & nouveau codebases. From a users perspective that relates to GPU lockup and incorrect rendering patches, removed unneeded dependency of external SHA1 implementation

[Mesa-dev] Mesa 10.6.2

2015-07-11 Thread Emil Velikov
Mesa 10.6.2 is now available. This time around we have a considerable list of fixes, most of which in the glsl, core mesa, and i965 & nouveau codebases. From a users perspective that relates to GPU lockup and incorrect rendering patches, removed unneeded dependency of external SHA1 implementation

Re: [Mesa-dev] [PATCH 4/4] r200: fix some potential big endian issues

2015-07-11 Thread Marek Olšák
I can't really tell if this works or not, but it looks reasonable. For the series: Acked-by: Marek Olšák Marek On Sat, Jul 11, 2015 at 8:39 PM, wrote: > From: Roland Scheidegger > > The formats chosen (both by texture format choser, fbo storage allocation) > are different for big endian not

[Mesa-dev] [PATCH] glsl: remove dead code in a single pass

2015-07-11 Thread Timothy Arceri
Currently only one ir assignment is removed for each var in a single dead code optimisation pass. This means if a var has more than one assignment, then it requires all the glsl optimisations to be run again for each additional assignment to be removed. Another pass is also required to remove the v

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-11 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 4:54 PM, Jose Fonseca wrote: > On 02/07/15 19:45, Ilia Mirkin wrote: >> >> On Thu, Jul 2, 2015 at 2:31 PM, Jose Fonseca wrote: >>> >>> On 02/07/15 17:49, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jose Fonseca wrote: > > > On 02/07/

[Mesa-dev] [PATCH] radeonsi: ARB_gpu_shader_fp64 + ARB_vertex_attrib_64bit support.

2015-07-11 Thread Dave Airlie
From: Dave Airlie This adds the translation from TGSI to AMDGPU llvm backend, for the 64-bit opcodes. The backend pretty much handles everything for us fine. There is one patch required for SI DFRAC support, that I know off. Signed-off-by: Dave Airlie --- docs/GL3.txt

Re: [Mesa-dev] [PATCH 09/19] glsl/ir: add subroutine information storage to ir_function (v1.1)

2015-07-11 Thread Dave Airlie
On 10 July 2015 at 07:15, Chris Forbes wrote: > Do you really need is_subroutine_def ? It seems redundant with > num_subroutine_types>0. I'm not sure, the spec isn't very clear on whether a subroutine definition with no subroutine types is legal GLSL or not. Dave. ___

Re: [Mesa-dev] [PATCH 09/19] glsl/ir: add subroutine information storage to ir_function (v1.1)

2015-07-11 Thread Dave Airlie
On 12 July 2015 at 13:02, Dave Airlie wrote: > On 10 July 2015 at 07:15, Chris Forbes wrote: >> Do you really need is_subroutine_def ? It seems redundant with >> num_subroutine_types>0. > > I'm not sure, the spec isn't very clear on whether a subroutine > definition with no subroutine types is le

[Mesa-dev] [PATCH V2] glsl: remove dead code in a single pass

2015-07-11 Thread Timothy Arceri
Currently only one ir assignment is removed for each var in a single dead code optimisation pass. This means if a var has more than one assignment, then it requires all the glsl optimisations to be run again for each additional assignment to be removed. Another pass is also required to remove the v