[Mesa-dev] [Bug 90466] arm: linker error ndefined reference to `nir_metadata_preserve'

2015-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90466 Bug ID: 90466 Summary: arm: linker error ndefined reference to `nir_metadata_preserve' Product: Mesa Version: git Hardware: Other OS: All Status

[Mesa-dev] [RFC 01/16] glsl: Add tracking for GLSL precision qualifiers

2015-05-15 Thread Topi Pohjolainen
From: Iago Toral Quiroga Currently, we only consider precision qualifiers at compile-time. This patch adds precision information to ir_variable so we can also do link time checks. Specifically, from the GLSL ES3 spec, 4.5.3 Precision Qualifiers: "The same uniform declared in different shaders th

[Mesa-dev] [RFC 12/16] nir: Consider float precision when deciding between int/float: part2

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/nir/glsl_to_nir.cpp | 61 ++-- 1 file changed, 25 insertions(+), 36 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 1267475..5b3c2ad 100644 --- a/src/glsl/nir/glsl_to_

[Mesa-dev] [RFC 15/16] nir: Consider float precision when deciding opcode

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/nir/glsl_to_nir.cpp | 61 +--- 1 file changed, 35 insertions(+), 26 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 4cb250a..b4777aa 100644 --- a/src/glsl/nir/glsl_to_

[Mesa-dev] [RFC 03/16] mesa: Add half float uniform support

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/main/uniform_query.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 728bd1b..4cdb682 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/src/mesa/main/uni

[Mesa-dev] [RFC 08/16] glsl: Add support for half float loop control

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/loop_controls.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/loop_controls.cpp b/src/glsl/loop_controls.cpp index 51804bb..4ba3049 100644 --- a/src/glsl/loop_controls.cpp +++ b/src/glsl/loop_controls.cpp @@ -132,6 +132,7 @@ calculate_

[Mesa-dev] [RFC 13/16] nir: Consider float precision when deciding between uint/int/float

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/nir/glsl_to_nir.cpp | 55 +++- 1 file changed, 13 insertions(+), 42 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 5b3c2ad..5da4122 100644 --- a/src/glsl/nir/glsl_to_

[Mesa-dev] [RFC 09/16] glsl/ast: Use half float type for medium and low precisions

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/ast_to_hir.cpp | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 332de5b..a8909ce 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -1962,17

[Mesa-dev] [RFC 05/16] glsl: Allow half float type to be used where-ever float is supported

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/glsl_types.h| 2 +- src/glsl/ir_validate.cpp | 36 2 files changed, 25 insertions(+), 13 deletions(-) diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h index d58718e..b90aa28 100644 --- a/src/glsl/gls

[Mesa-dev] [RFC 04/16] glsl: Add half float type generation

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/builtin_type_macros.h | 16 +++ src/glsl/builtin_types.cpp | 31 + src/glsl/glsl_types.cpp| 44 +++--- src/glsl/glsl_types.h | 6 +- 4 files changed,

[Mesa-dev] [RFC 07/16] glsl: Add ubo lowering support for half floats

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/lower_ubo_reference.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index 4ea4ccb..15e783b 100644 --- a/src/glsl/lower_ubo_reference.cpp +++ b/src/

[Mesa-dev] [RFC 10/16] nir: Introduce half float opcodes

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/nir/nir.h | 2 + src/glsl/nir/nir_constant_expressions.py | 8 +++- src/glsl/nir/nir_opcodes.py | 78 +++- 3 files changed, 86 insertions(+), 2 deletions(-) diff --git a/src/glsl/nir/nir

[Mesa-dev] [RFC 14/16] nir: Consider float precision when deciding between uint/float

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/nir/glsl_to_nir.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 5da4122..4cb250a 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/glsl/nir/glsl_to_n

[Mesa-dev] [RFC 11/16] nir: Consider float precision when deciding between int/float

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/nir/glsl_to_nir.cpp | 39 +-- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 7a20e1a..1267475 100644 --- a/src/glsl/nir/glsl_to_nir.c

[Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Topi Pohjolainen
I wanted to kick-off discussion on how to support floating point precision qualifiers in NIR. This is purely on optimization for GLES where one can reduce the number of GPU cycles. At the moment the compiler discards the qualifiers early when abstract syntax tree (AST) is transformed into intermedi

[Mesa-dev] [RFC 06/16] glsl: Add support for half floats in optimization passes

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/ir_print_visitor.cpp | 1 + src/glsl/opt_algebraic.cpp| 11 --- src/glsl/opt_constant_propagation.cpp | 1 + src/glsl/opt_minmax.cpp | 2 ++ 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/sr

[Mesa-dev] [RFC 16/16] nir: Consider float precision when deciding opcode: part 2

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/nir/glsl_to_nir.cpp | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index b4777aa..14c4324 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++

[Mesa-dev] [RFC 02/16] glsl: Add half float type

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/glsl/ast_to_hir.cpp| 1 + src/glsl/glsl_types.cpp| 2 ++ src/glsl/glsl_types.h | 9 + src/glsl/ir_clone.cpp | 1 + src/glsl/link_uniform_initializers.c

Re: [Mesa-dev] [PATCH 04/15] egl: import headers from Khronos EGL registry

2015-05-15 Thread Daniel Stone
Hi, On 14 May 2015 at 23:33, Emil Velikov wrote: > Hi Marek, > On 12/05/15 22:54, Marek Olšák wrote: >> -#elif defined(__WINSCW__) || defined(__SYMBIAN32__) /* Symbian */ >> +#elif defined(__APPLE__) || defined(__WINSCW__) || defined(__SYMBIAN32__) >> /* Symbian */ >> >> typedef int EGLNati

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Fredrik Höglund
On Friday 15 May 2015, Michel Dänzer wrote: > On 14.05.2015 22:52, fred...@kemper.freedesktop.org (Fredrik HXXglund) > wrote: > > > > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b284f08ab399154ad10e2166440b44cbbdcb2c5 > > Author: Laura Ekstrand > > Date: Tue Feb 3 14:47:00 2015 -08

[Mesa-dev] [Bug 90466] arm: linker error ndefined reference to `nir_metadata_preserve'

2015-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90466 --- Comment #1 from Emil Velikov --- This issue is not ARM specific. It is present if one tries to use nir in their driver, but libnir is missing from the final link stage (i.e. targets/foo). I've had some patches that address these [1] but forgo

Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-15 Thread Brian Paul
Let's play it safe. Update your patch series and re-post it to the list for a final review, please. -Brian On 05/14/2015 06:01 PM, Alexander von Gluck IV wrote: Good evening Brian, Thanks, these were fixed. I just realized that I can drop os_thread.h from our C++ code as we no longer depen

[Mesa-dev] [Bug 90457] New Account Request

2015-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90457 --- Comment #3 from Brian Paul --- Normally we don't give git privileges until after the individual has some history of submitting some good patches. Carl, is Nanley is a coworker of your's at Intel? -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-15 Thread Alexander von Gluck IV
can-do. I actually think I spotted one more extern "C" reduction I can do. Thanks! -- Alex On , Brian Paul wrote: Let's play it safe. Update your patch series and re-post it to the list for a final review, please. -Brian On 05/14/2015 06:01 PM, Alexander von Gluck IV wrote: Good evenin

Re: [Mesa-dev] [PATCH 4/5] gallium/st: Move st_api creation to st and extern "C" it

2015-05-15 Thread Emil Velikov
On 14/05/15 22:39, Alexander von Gluck IV wrote: > --- > src/gallium/state_trackers/hgl/hgl.c | 16 > src/gallium/state_trackers/hgl/hgl_context.h | 14 ++ > 2 files changed, 22 insertions(+), 8 deletions(-) > > diff --git a/src/gallium/state_trackers/hgl/

Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-15 Thread Emil Velikov
On 14/05/15 22:39, Alexander von Gluck IV wrote: > We also reduce the amount of need-to-know information about st_api > to require one less extern "C" in st_manager.h > --- > .../targets/haiku-softpipe/GalliumContext.cpp | 23 +++ > .../targets/haiku-softpipe/GalliumContext.

Re: [Mesa-dev] Problem with ___glapi_noop_table

2015-05-15 Thread Brian Paul
On 05/14/2015 11:26 AM, Shervin Sharifi wrote: Hi, I am trying to build Mesa for OpenGL ES (with llvmpipe) under windows with MSVC. I'm getting an error due to an unresolved external symbol (___glapi_noop_table). There is no definition of ___glapi_noop_table in the code. Am I missing some

Re: [Mesa-dev] [PATCH] mesa: Restore functionality to dispatch sanity test

2015-05-15 Thread Brian Paul
On 05/04/2015 12:32 PM, Ian Romanick wrote: On 04/29/2015 02:44 PM, Brian Paul wrote: On 04/29/2015 02:53 PM, Ian Romanick wrote: On 04/29/2015 12:07 PM, Ian Romanick wrote: From: Ian Romanick Along with a couple secondary goals, the dispatch sanity test had two major, primary goals. 1. Ens

[Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-15 Thread Brian Paul
Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher (which live in libGL.so). The calls to those functions from context.c would be undefined (i.e. an ABI break) if the libGL used at runtime was older. For the time being, use th

Re: [Mesa-dev] [PATCH 06/15] egl: fix setting context flags

2015-05-15 Thread Marek Olšák
Yes, I'll add the Cc note. Marek On Fri, May 15, 2015 at 12:40 AM, Emil Velikov wrote: > On 12/05/15 22:54, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/egl/main/eglcontext.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/src/egl/main/eglcontext.c

Re: [Mesa-dev] [RFC 02/16] glsl: Add half float type

2015-05-15 Thread Ilia Mirkin
On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/glsl/ast_to_hir.cpp| 1 + > src/glsl/glsl_types.cpp| 2 ++ > src/glsl/glsl_types.h | 9 + > src/glsl/ir_clone.cp

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Rob Clark
On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen wrote: > I wanted to kick-off discussion on how to support floating point > precision qualifiers in NIR. This is purely on optimization for > GLES where one can reduce the number of GPU cycles. At the moment > the compiler discards the qualifiers e

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Fredrik Höglund
On Friday 15 May 2015, Fredrik Höglund wrote: > On Friday 15 May 2015, Michel Dänzer wrote: > > On 14.05.2015 22:52, fred...@kemper.freedesktop.org (Fredrik HXXglund) > > wrote: > > > > > > URL: > > http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b284f08ab399154ad10e2166440b44cbbdcb2c5 > > > Aut

Re: [Mesa-dev] [RFC 02/16] glsl: Add half float type

2015-05-15 Thread Roland Mainz
On Fri, May 15, 2015 at 5:43 PM, Ilia Mirkin wrote: > On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen > wrote: >> Signed-off-by: Topi Pohjolainen >> --- >> src/glsl/ast_to_hir.cpp| 1 + >> src/glsl/glsl_types.cpp| 2 ++ >> src/glsl/glsl_types.h

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-15 Thread Emil Velikov
On 15/05/15 15:13, Brian Paul wrote: > Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and > _glapi_set_nop_handler() functions in the glapi dispatcher (which > live in libGL.so). The calls to those functions from context.c > would be undefined (i.e. an ABI break) if the libGL used at r

Re: [Mesa-dev] [PATCH 10/15] egl: add eglWaitSync

2015-05-15 Thread Marek Olšák
On Fri, May 15, 2015 at 1:23 AM, Emil Velikov wrote: > On 12/05/15 22:54, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/egl/main/eglapi.c | 12 >> 1 file changed, 12 insertions(+) >> >> diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c >> index 60df297..544f7e4 1

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Pohjolainen, Topi
On Fri, May 15, 2015 at 11:59:25AM -0400, Rob Clark wrote: > On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen > wrote: > > I wanted to kick-off discussion on how to support floating point > > precision qualifiers in NIR. This is purely on optimization for > > GLES where one can reduce the number

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Rob Clark
On Fri, May 15, 2015 at 12:22 PM, Pohjolainen, Topi wrote: > On Fri, May 15, 2015 at 11:59:25AM -0400, Rob Clark wrote: >> On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen >> wrote: >> > I wanted to kick-off discussion on how to support floating point >> > precision qualifiers in NIR. This is pu

Re: [Mesa-dev] [PATCH 10/15] egl: add eglWaitSync

2015-05-15 Thread Emil Velikov
On 15/05/15 16:18, Marek Olšák wrote: > On Fri, May 15, 2015 at 1:23 AM, Emil Velikov > wrote: >> On 12/05/15 22:54, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> --- >>> src/egl/main/eglapi.c | 12 >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/src/egl/main/eglapi.c

Re: [Mesa-dev] [RFC 4/6] i965: Implement INTEL_performance_query extension

2015-05-15 Thread Robert Bragg
On Mon, May 11, 2015 at 4:28 PM, Samuel Pitoiset wrote: > > > On 05/06/2015 02:53 AM, Robert Bragg wrote: >> >> This adds a bare-bones backend for the INTEL_performance_query extension >> that exposes the pipeline statistics on gen 6 and 7 hardware. >> >> Although this could be considered redundan

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Pohjolainen, Topi
On Fri, May 15, 2015 at 12:32:52PM -0400, Rob Clark wrote: > On Fri, May 15, 2015 at 12:22 PM, Pohjolainen, Topi > wrote: > > On Fri, May 15, 2015 at 11:59:25AM -0400, Rob Clark wrote: > >> On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen > >> wrote: > >> > I wanted to kick-off discussion on how

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-15 Thread Francisco Jerez
Jason Ekstrand writes: > I haven't said much about this series up until now. I've mostly sat > and watched and focused my time on other things. As I said in the > meeting today, I think that part of the problem here is that there are > at least 3 "refactors" in here besides the new feature. By

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-15 Thread Emil Velikov
On 12/05/15 22:54, Marek Olšák wrote: > From: Marek Olšák > > --- > src/egl/main/eglapi.c | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c > index 6457798..34a113b 100644 > --- a/src/egl/main/eglapi.c

Re: [Mesa-dev] [Mesa-stable] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2015-05-15 Thread Emil Velikov
On 09/04/15 16:05, Emil Velikov wrote: > Hi Boyan, > > On 9 April 2015 at 16:08, Boyan Ding wrote: >> For the same reason as the i965 one, as suggested by Chih-Wei Huang. >> >> Cc: "10.4 10.5" >> Signed-off-by: Boyan Ding >> --- > > Did you run this and the i965 patch through piglit ? Consider

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Marek Olšák
Hi Fredrik, I'd prefer flushing the bitmap cache in st_BlitFramebuffer. We might have more bugs like this in st/mesa. Marek On Fri, May 15, 2015 at 5:59 PM, Fredrik Höglund wrote: > On Friday 15 May 2015, Fredrik Höglund wrote: >> On Friday 15 May 2015, Michel Dänzer wrote: >> > On 14.05.2015

Re: [Mesa-dev] [PATCH] i915: add mock implementation of GL_OES_EGL_image_external

2015-05-15 Thread Emil Velikov
On 02/04/15 15:17, Chih-Wei Huang wrote: > This is similar to commit 7420c9dab4aaf87e6b840410226c296c4668a48f > but for the i915 driver. It's necessary to support android-x86. > There is one major difference between this and the mentioned commit. This one unconditionally enables the extension - ca

Re: [Mesa-dev] CompressedTexImage3D spec bug?

2015-05-15 Thread Marek Olšák
From ARB_texture_cube_map_array: Accepted by the parameter of TexImage3D, TexSubImage3D, CompressedTeximage3D, CompressedTexSubImage3D and CopyTexSubImage3D: TEXTURE_CUBE_MAP_ARRAY_ARB So the extension spec "fixes" the core spec. Marek On Fri, May 15, 2015 at 4:49 AM, Roland Schei

Re: [Mesa-dev] [PATCH 00/20] i915: Pile of fixes and cleanups

2015-05-15 Thread Emil Velikov
Hi Ville, On 13/04/15 11:00, Ville Syrjälä wrote: > On Mon, Mar 23, 2015 at 02:47:16PM +0200, ville.syrj...@linux.intel.com wrote: >> From: Ville Syrjälä >> >> I've had some of these i915 patches lying around for half a year or more, >> so I figured it's time to post them. >> >> This series fixes

[Mesa-dev] [RFC v2] Model INTEL perf query backend after query object BE

2015-05-15 Thread Robert Bragg
Instead of using the same backend interface as AMD_performance_monitor this defines a dedicated INTEL_performance_query interface that is based on the ARB_query_buffer_object interface (considering the similarity of the extensions) with the addition of vfuncs for enumerating queries and their count

Re: [Mesa-dev] CompressedTexImage3D spec bug?

2015-05-15 Thread Roland Scheidegger
I don't think so. This just refers to generally accepting TEXTURE_CUBE_MAP_ARRAY for these calls. It does however not refer to specific compressed formats, which is what the core spec bit is about (what this really wanted to forbid there is specifying TEXTURE_3D). Roland Am 15.05.2015 um 19:05 sc

[Mesa-dev] [counter-RFC 1/3] nir: s/nir_type_unsigned/nir_type_uint

2015-05-15 Thread Jason Ekstrand
--- src/glsl/nir/glsl_to_nir.cpp | 2 +- src/glsl/nir/nir.h | 2 +- src/glsl/nir/nir_constant_expressions.py | 4 +- src/glsl/nir/nir_opcodes.py | 78 src/glsl/nir/nir_search.c| 4 +- src/mesa/drive

[Mesa-dev] [counter-RFC 0/3] Add a concept of a bit-size to NIR

2015-05-15 Thread Jason Ekstrand
WARNING: This is possibly the hackiest thing I've ever sent to the list. I've been meaning to type it up properly but have never gotten around to it. When Topi sent his series this morning, I decided that it would be worth dropping my thoughts on the list so that we can have something of a compari

[Mesa-dev] [counter-RFC 3/3] nir: Add a bit_size to nir_register and nir_ssa_def

2015-05-15 Thread Jason Ekstrand
This really hacky commit adds a bit size to registers and SSA values. It also adds rules in the validator to validate that they do the right things. It's still an open question as to whether or not we want a bit_size in nir_alu_instr or if we just want to let it inherit from the destination. I'm

[Mesa-dev] [counter-RFC 2/3] nir: Add explicitly sized types

2015-05-15 Thread Jason Ekstrand
--- src/glsl/nir/nir.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index bc8f063..8dfc68d 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -644,9 +644,23 @@ typedef enum { nir_type_float, nir_type_i

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Jason Ekstrand
On Fri, May 15, 2015 at 2:39 AM, Topi Pohjolainen wrote: > I wanted to kick-off discussion on how to support floating point > precision qualifiers in NIR. This is purely on optimization for > GLES where one can reduce the number of GPU cycles. At the moment > the compiler discards the qualifiers e

[Mesa-dev] [PATCH] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-15 Thread Brian Paul
If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() error would generate GL_STACK_UNDERFLOW. Now push a dummy attribute in that case to prevent the error. Mesa now matches nvidia's behavior. --- src/mesa/main/attrib.c |

Re: [Mesa-dev] [PATCH 11/20] glapi: Remove static dispatch for functions that didn't exist in fglrx

2015-05-15 Thread Ian Romanick
On 05/14/2015 03:01 PM, Emil Velikov wrote: > On 13/05/15 19:44, Ian Romanick wrote: >> From: Ian Romanick >> >> Comparing the output of >> >> nm -D arch/x86_64/usr/X11R6/lib64/fglrx/fglrx-libGL.so.1.2 |\ >> grep ' T gl[^X]' | sed 's/.* T //' >> >> between Catalyst 14.6 Beta and this c

[Mesa-dev] [PATCH 4/5] st/hgl: Move st_api creation to st and extern "C" it

2015-05-15 Thread Alexander von Gluck IV
--- src/gallium/state_trackers/hgl/hgl.c | 16 src/gallium/state_trackers/hgl/hgl_context.h | 14 ++ 2 files changed, 22 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/hgl/hgl.c b/src/gallium/state_trackers/hgl/hgl.c index 77f7c22..

[Mesa-dev] [PATCH 3/5] winsys/hgl: Add needed extern "C" to hgl winsys

2015-05-15 Thread Alexander von Gluck IV
--- src/gallium/winsys/sw/hgl/hgl_sw_winsys.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/gallium/winsys/sw/hgl/hgl_sw_winsys.h b/src/gallium/winsys/sw/hgl/hgl_sw_winsys.h index bdcddfb..a81f890 100644 --- a/src/gallium/winsys/sw/hgl/hgl_sw_winsys.h +++ b/sr

[Mesa-dev] [PATCH 2/5] gallium/drivers: Add extern "C" wrappers to public entry

2015-05-15 Thread Alexander von Gluck IV
--- src/gallium/drivers/llvmpipe/lp_public.h |8 src/gallium/drivers/rbug/rbug_public.h |8 src/gallium/drivers/softpipe/sp_public.h |8 3 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_public.h b/src/gallium/

[Mesa-dev] [PATCH 5/5] target/haiku-softpipe: Move api init into st code

2015-05-15 Thread Alexander von Gluck IV
We also reduce the amount of need-to-know information about st_api to require one less extern "C" in st_manager.h --- .../targets/haiku-softpipe/GalliumContext.cpp | 23 +++ .../targets/haiku-softpipe/GalliumContext.h|6 + 2 files changed, 10 insertions(+), 1

[Mesa-dev] [PATCH 1/5] gallium/aux: Add needed extern "C" wrappers

2015-05-15 Thread Alexander von Gluck IV
--- src/gallium/auxiliary/postprocess/postprocess.h |9 + src/gallium/auxiliary/util/u_tests.h|8 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/gallium/auxiliary/postprocess/postprocess.h b/src/gallium/auxiliary/postprocess/postprocess.h

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Jason Ekstrand
Hey Topi! Thanks for working on this! I've been meaning to do something for fp16 and fp64 in NIR for a while and just haven't gotten to it. I just sent out three "patches" laying out how I was intending to do it. I put "patches" in quotes because they're so half-baked they barely compile. It's

Re: [Mesa-dev] [PATCH 02/20] mesa: Remove all vestiges of glFramebufferTextureFaceARB

2015-05-15 Thread Ian Romanick
On 05/14/2015 02:44 PM, Emil Velikov wrote: > On 13/05/15 19:44, Ian Romanick wrote: >> From: Ian Romanick >> >> Mesa does not (and probably never will) support GL_ARB_geometry_shader4, >> so this function will never exist. > In the (very unlikely) event that we do support the extension, won't > t

Re: [Mesa-dev] [PATCH 5/5] target/haiku-softpipe: Move api init into st code

2015-05-15 Thread Brian Paul
Series looks OK to me (though I didn't look too closely at the specific Haiku changes). Reviewed-by: Brian Paul On 05/15/2015 11:29 AM, Alexander von Gluck IV wrote: We also reduce the amount of need-to-know information about st_api to require one less extern "C" in st_manager.h --- .../tar

Re: [Mesa-dev] [PATCH] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-15 Thread Brian Paul
On 05/15/2015 11:31 AM, Brian Paul wrote: If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() error I'll s/error/call/ there. would generate GL_STACK_UNDERFLOW. Now push a dummy attribute in that case to prevent the

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-15 Thread Jason Ekstrand
On Fri, May 15, 2015 at 9:51 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> I haven't said much about this series up until now. I've mostly sat >> and watched and focused my time on other things. As I said in the >> meeting today, I think that part of the problem here is that there ar

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Pohjolainen, Topi
On Fri, May 15, 2015 at 10:32:44AM -0700, Jason Ekstrand wrote: > Hey Topi! Thanks for working on this! > > I've been meaning to do something for fp16 and fp64 in NIR for a while > and just haven't gotten to it. I just sent out three "patches" laying > out how I was intending to do it. I put "p

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-15 Thread Brian Paul
On 05/15/2015 11:14 AM, Emil Velikov wrote: On 15/05/15 15:13, Brian Paul wrote: Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher (which live in libGL.so). The calls to those functions from context.c would be undefined (i.

[Mesa-dev] [PATCH] st/mesa: Flush the bitmap cache in st_BlitFramebuffer

2015-05-15 Thread Fredrik Höglund
With DSA we can no longer rely on this being done in st_validate_state in response to the framebuffer bindings having changed. This fixes the ext_framebuffer_multisample-bitmap piglit test. --- src/mesa/state_tracker/st_cb_blit.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/st

Re: [Mesa-dev] [PATCH 11/20] glapi: Remove static dispatch for functions that didn't exist in fglrx

2015-05-15 Thread Emil Velikov
On 15/05/15 17:29, Ian Romanick wrote: > On 05/14/2015 03:01 PM, Emil Velikov wrote: >> On 13/05/15 19:44, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Comparing the output of >>> >>> nm -D arch/x86_64/usr/X11R6/lib64/fglrx/fglrx-libGL.so.1.2 |\ >>> grep ' T gl[^X]' | sed 's/.* T

Re: [Mesa-dev] [PATCH 02/20] mesa: Remove all vestiges of glFramebufferTextureFaceARB

2015-05-15 Thread Emil Velikov
On 15/05/15 17:35, Ian Romanick wrote: > On 05/14/2015 02:44 PM, Emil Velikov wrote: >> On 13/05/15 19:44, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Mesa does not (and probably never will) support GL_ARB_geometry_shader4, >>> so this function will never exist. >> In the (very unlikely) ev

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Ian Romanick
On 05/15/2015 05:26 AM, Fredrik Höglund wrote: > On Friday 15 May 2015, Michel Dänzer wrote: >> On 14.05.2015 22:52, fred...@kemper.freedesktop.org (Fredrik HXXglund) >> wrote: >>> >>> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b284f08ab399154ad10e2166440b44cbbdcb2c5 >>> Author: Laur

Re: [Mesa-dev] [PATCH 11/20] glapi: Remove static dispatch for functions that didn't exist in fglrx

2015-05-15 Thread Ian Romanick
On 05/15/2015 12:11 PM, Emil Velikov wrote: > On 15/05/15 17:29, Ian Romanick wrote: >> On 05/14/2015 03:01 PM, Emil Velikov wrote: >>> On 13/05/15 19:44, Ian Romanick wrote: From: Ian Romanick Comparing the output of nm -D arch/x86_64/usr/X11R6/lib64/fglrx/fglrx-libGL

Re: [Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-15 Thread Ian Romanick
On 05/14/2015 12:51 PM, Ilia Mirkin wrote: > Don't you have to add the checks either way? And should these have just been > > if (ctx->API != CORE && (ctx->API != COMPAT || ctx->Version < 20)) { > ... > } > > And removing compat will just reduce these checks to > > if (ctx->API != CORE) > > ?

Re: [Mesa-dev] [PATCH] st/mesa: Flush the bitmap cache in st_BlitFramebuffer

2015-05-15 Thread Brian Paul
On 05/15/2015 12:10 PM, Fredrik Höglund wrote: With DSA we can no longer rely on this being done in st_validate_state in response to the framebuffer bindings having changed. This fixes the ext_framebuffer_multisample-bitmap piglit test. --- src/mesa/state_tracker/st_cb_blit.c | 4 1 file

Re: [Mesa-dev] [PATCH 00/20] glapi yak shaving and GLES 3.1 enabling

2015-05-15 Thread Ian Romanick
On 05/14/2015 03:01 PM, Emil Velikov wrote: > Hi Ian, > > On 13/05/15 19:44, Ian Romanick wrote: >> We've known for a long time that having all those tags in the >> entries in the XML is bad. For example, people cut-and-paste for >> everything, and, as a result, we export a bunch of functions th

Re: [Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-15 Thread Ilia Mirkin
On Fri, May 15, 2015 at 2:29 PM, Ian Romanick wrote: > On 05/14/2015 12:51 PM, Ilia Mirkin wrote: >> Don't you have to add the checks either way? And should these have just been >> >> if (ctx->API != CORE && (ctx->API != COMPAT || ctx->Version < 20)) { >> ... >> } >> >> And removing compat will

[Mesa-dev] [PATCH 02/12] android: make the code be compatible with stlport

2015-05-15 Thread Chih-Wei Huang
The android's stlport doesn't have tr1/unordered_set but unordered_set. Signed-off-by: Chih-Wei Huang --- src/egl/main/Android.mk | 5 +++-- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/egl/main/

[Mesa-dev] [PATCH 06/12] android: add rules to build gallium_dri

2015-05-15 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/gallium/Android.mk | 7 +- src/gallium/targets/dri/Android.mk | 110 +++ src/gallium/winsys/sw/dri/Android.mk | 35 ++ src/gallium/winsys/sw/kms-dri/Android.mk | 37 +++ 4 files chang

[Mesa-dev] [PATCH 01/12] nv50/ir: optimize the use of std::tr1::unordered_set

2015-05-15 Thread Chih-Wei Huang
Instead of using unordered_set directly, the patch changes to use unordered_set and adds a wrapper template class to convert the iterators to the expected user-defined type. This avoid instantiating the template multiple times and make it be more compatible with stlport. Signed-off-by: Chih-Wei H

[Mesa-dev] [PATCH 04/12] android: export more dirs from libmesa_dri_common

2015-05-15 Thread Chih-Wei Huang
The include paths of libmesa_dri_common are also used by modules that need libmesa_dri_common. Signed-off-by: Chih-Wei Huang --- src/mesa/drivers/dri/common/Android.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/common/Android.mk b/src/mesa/driver

[Mesa-dev] [PATCH 07/12] android: enable the rules to build gallium st/dri

2015-05-15 Thread Chih-Wei Huang
The libmesa_dri_common and libmesa_egl_dri2 should not be limited to the classical drivers only. Allow them to be built with the gallium drivers. Signed-off-by: Chih-Wei Huang --- Android.mk | 6 +- src/egl/main/Android.mk | 8 ++-- 2 files changed, 3 insertions(+), 11 delet

[Mesa-dev] [PATCH 09/12] egl/main: let EGL_RECORDABLE_ANDROID be a valid attrib

2015-05-15 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/egl/main/eglconfig.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/main/eglconfig.h b/src/egl/main/eglconfig.h index 84cb227..7121b3d 100644 --- a/src/egl/main/eglconfig.h +++ b/src/egl/main/eglconfig.h @@ -86,6 +86,7 @@ struct _egl_config

[Mesa-dev] [PATCH 00/12] More Android patches

2015-05-15 Thread Chih-Wei Huang
This is another series of patches for Android. Summary of the changes: * Fix nouveau driver build with Android stlport. * Add gallium_dri.so for Android. This fixes gallium support since 5564c36. * Enable radeonsi driver for Android. * Miscellaneous fixes. Chih-Wei Huang (12): nv50/ir: optimize

[Mesa-dev] [PATCH 05/12] android: add rules to build gallium/state_trackers/dri

2015-05-15 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/gallium/Android.mk| 5 ++- src/gallium/state_trackers/dri/Android.mk | 64 +++ 2 files changed, 67 insertions(+), 2 deletions(-) create mode 100644 src/gallium/state_trackers/dri/Android.mk diff --git a/src/g

[Mesa-dev] [PATCH 12/12] android: enable the radeonsi driver

2015-05-15 Thread Chih-Wei Huang
Based on the nice work of Paulo Sergio Travaglia . The main modifications are: - Include paths for LLVM header files and shared/static libraries - Set C++ flag "c++11" to avoid compiling errors on LLVM header files - Set defines for LLVM - Add GALLIVM source files - Changes path of libelf library

[Mesa-dev] [PATCH 08/12] android: clean up the makefile of libGLES_mesa

2015-05-15 Thread Chih-Wei Huang
Most of the logic for the gallium drivers has been moved to src/gallium/targets/dri/Android.mk. Signed-off-by: Chih-Wei Huang --- src/egl/main/Android.mk | 79 ++--- 1 file changed, 2 insertions(+), 77 deletions(-) diff --git a/src/egl/main/Android.mk

[Mesa-dev] [PATCH 10/12] android: fix building errors with stlport

2015-05-15 Thread Chih-Wei Huang
In Android the nouveau driver is built with stlport by including libstlport.mk. However, it changes the include paths order to be in favor of external/stlport/stlport. The assert.h defined in it is chosen that causes the building errors on compiling C code. Strictly speaking, stlport should only b

[Mesa-dev] [PATCH 03/12] android: loader: export the path to be included

2015-05-15 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/egl/drivers/dri2/Android.mk | 1 - src/loader/Android.mk | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/Android.mk b/src/egl/drivers/dri2/Android.mk index 5931ce8..d4d809b 100644 --- a/src/egl/drivers/dri2

[Mesa-dev] [PATCH 11/12] android: generate files by $(call es-gen)

2015-05-15 Thread Chih-Wei Huang
Use the pre-defined macro es-gen to generate new added files instead of writing new rules manually. The handmade rules that may generate the files before the directory is created result in such an error: /bin/bash: out/target/product/x86/gen/STATIC_LIBRARIES/libmesa_st_mesa_intermediates/main/for

[Mesa-dev] [PATCH] Fix symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2015-05-15 Thread Yunlian Jiang
This is just a re-post of the patch submitted by Tomasz at https://bugs.freedesktop.org/show_bug.cgi?id=89599 Thanks diff -Naur mesa-10.5.2/src/mapi/entry_x86-64_tls.h mesa-10.5.2.tpg/src/mapi/entry_x86-64_tls.h --- mesa-10.5.2/src/mapi/entry_x86-64_tls.h 2015-03-28 18:20:39.0 + +++

Re: [Mesa-dev] [PATCH 01/12] nv50/ir: optimize the use of std::tr1::unordered_set

2015-05-15 Thread Ilia Mirkin
Please elaborate why this is necessary. I have, in the past, had requests to move to the C++11 std::unordered_set -- would that work for you? I'd be happy with a #if c++11 is available, use std::unordered_set. Otherwise use std::tr1::unordered_set. On Fri, May 15, 2015 at 2:42 PM, Chih-Wei Huang

[Mesa-dev] [PATCH] i965: Fix FS unit tests

2015-05-15 Thread Ian Romanick
From: Ian Romanick Commit 3687d75 changed the fs_visitor constructors, but it didn't update all the users. As a result, 'make check' fails. I added the explicit cast to the gl_program* parameter to make it more clear which NULL was which. Signed-off-by: Ian Romanick Cc: Kenneth Graunke ---

Re: [Mesa-dev] [PATCH 01/20] t_dd_dmatmp: Kill the paths rendering quads/quad strips via indexed vertices

2015-05-15 Thread Ian Romanick
On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > No driver supports elts currently, and these make the validate_render > code a bit hard to follow. Just kill them. It looks like both r200_tcl.c and radeon_tcl.c define HAVE_TRI_STRIPS and HAVE_ELTS, but I gue

Re: [Mesa-dev] [PATCH] i965: Fix FS unit tests

2015-05-15 Thread Kenneth Graunke
On Friday, May 15, 2015 11:57:16 AM Ian Romanick wrote: > From: Ian Romanick > > Commit 3687d75 changed the fs_visitor constructors, but it didn't update > all the users. As a result, 'make check' fails. > > I added the explicit cast to the gl_program* parameter to make it more > clear which NU

Re: [Mesa-dev] [PATCH 02/20] t_dd_dmatmp: Allow flat shaded polygons with tri fans

2015-05-15 Thread Ian Romanick
On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We can allow rendering flat shaded polygons using tri fans if we check > the provoking vertex convention. This sounds reasonable since it matches the DX behavior. Is there a piglit test that would hit this?

Re: [Mesa-dev] [PATCH] i965: Fix FS unit tests

2015-05-15 Thread Matt Turner
On Fri, May 15, 2015 at 12:06 PM, Kenneth Graunke wrote: > Sorry! > > Reviewed-by: Kenneth Graunke Capital W in your email. idr, please fix this before you commit. :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org

Re: [Mesa-dev] [PATCH 03/20] t_dd_dmatmp: Disallow flat shading when rendering quad strips via tri strips

2015-05-15 Thread Ian Romanick
On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > When rendering quad strips via tri strips we can't get the provoking > vertex right, so disallow flat shading. Same comments as for patch 2. > Signed-off-by: Ville Syrjälä > --- > src/mesa/tnl_dd/t_dd_dmatm

Re: [Mesa-dev] [PATCH 08/20] i915: Fix collision between I830_UPLOAD_RASTER_RULES and I830_UPLOAD_TEX(0)

2015-05-15 Thread Ian Romanick
This patch seems obviously correct and is Reviewed-by: Ian Romanick On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > I830_UPLOAD_RASTER_RULES and I830_UPLOAD_TEX(0) are trying to occupy > the same bit. Move the texture bits upwards a bit to make room for >

  1   2   >