Re: [Mesa-dev] [PATCH 1/5] glsl/cse: Use ir_rvalue_enter_visitor instead of ir_rvalue_visitor

2015-04-09 Thread Matt Turner
On Wed, Apr 8, 2015 at 4:38 PM, Ian Romanick wrote: > From: Ian Romanick > > ir_rvalue_visitor visits each rvalue on exit. When visiting a large > expression, the leaf expressions will be visited and eliminated first. > Once one leaf expression was replaced, it would no longer match a > potentia

Re: [Mesa-dev] [PATCH 2/2] gallium/ttn: add TXQ support

2015-04-09 Thread Rob Clark
On Thu, Apr 9, 2015 at 3:43 PM, Rob Clark wrote: > From: Rob Clark > > Split out from ttn_tex() since it is kind of a weird instruction that > maps to two NIR opcodes, and it was cleaner this way. > as Ilia pointed out on IRC, query_levels should have no src args.. I've fixed that locally (but f

Re: [Mesa-dev] [PATCH 02/38] main: Add glCreateFramebuffers.

2015-04-09 Thread Fredrik Höglund
There should probably be two empty lines between the functions, but aside from that nitpick, this patch is: Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 + > src/mesa/main/fbobject.c

Re: [Mesa-dev] [PATCH 04/38] main: Rename framebuffer renderbuffer software fallback.

2015-04-09 Thread Fredrik Höglund
I don't know if we reached a consensus on the naming of fallback functions, but I would prefer _mesa_framebuffer_renderbuffer_fallback. With either name, this patch is: Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > Rename _mesa_framebuffer_renderbuffer to _mes

[Mesa-dev] New stable-branch 10.5 candidate pushed

2015-04-09 Thread Emil Velikov
Hello list, The candidate for the Mesa 10.5.3 is now available. The current patch queue is as follows: - 18 queued - 13 nominated (outstanding) - and 2 rejected (obsolete) patches This release addresses bugs in our OpenCL state-tracker (clover) and nearly every dri driver. The compilation proc

Re: [Mesa-dev] [PATCH 3/5] i965/vs: Add src_reg::negative_equals method

2015-04-09 Thread Matt Turner
On Thu, Apr 9, 2015 at 9:31 AM, Matt Turner wrote: > I think the function does what it advertises. I just don't think that > happens to be the thing you really want. See next patch's reply. Oh, never mind. I missed the non-immediate case. Even still, I guess I expected your more general case to

[Mesa-dev] [PATCH 2/2] gallium/ttn: add TXQ support

2015-04-09 Thread Rob Clark
From: Rob Clark Split out from ttn_tex() since it is kind of a weird instruction that maps to two NIR opcodes, and it was cleaner this way. Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 61 - 1 file changed, 53 insertions(+), 8 deletions

Re: [Mesa-dev] [PATCH] st/mesa: convert sub image for cube map arrays to 2d arrays for upload

2015-04-09 Thread Marek Olšák
Reviewed-by: Marek Olšák I'd like to have both fixes in master. Either or both can be candidates for stable. Marek On Wed, Apr 8, 2015 at 3:00 AM, Dave Airlie wrote: > From: Dave Airlie > > Since we can subimage upload a number of cube map array layers, > that aren't a complete cube map array

Re: [Mesa-dev] [Mesa-stable] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2015-04-09 Thread Emil Velikov
Hi Boyan, On 9 April 2015 at 16:08, Boyan Ding wrote: > For the same reason as the i965 one, as suggested by Chih-Wei Huang. > > Cc: "10.4 10.5" > Signed-off-by: Boyan Ding > --- Did you run this and the i965 patch through piglit ? Considering how quiet things are having the information that i

Re: [Mesa-dev] Problem with LLVM on Windows with MSVC

2015-04-09 Thread Predut, Marius
Indeed seems you have some incompatible libraries (one build static and other dynamic –dll) https://bugzilla.mozilla.org/show_bug.cgi?id=732124 but what suppose `libgl-gd' target? Is this a typo mismatch? Try to build llvm in a dynamic mode , may be it will solve your problems marius From:

Re: [Mesa-dev] Problem with LLVM on Windows with MSVC

2015-04-09 Thread Olivier PENA
Hi, Try use llvm cmake options : LLVM_USE_CRT_DEBUG=MTd LLVM_USE_CRT_RELEASE =MT De : mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] De la part de Shervin Sharifi Envoyé : jeudi 9 avril 2015 01:57 À : mesa-dev@lists.freedesktop.org Objet : [Mesa-dev] Problem with LLVM on Windows with M

Re: [Mesa-dev] [PATCH 1/2] egl/dri2: implement platform_null (v2).

2015-04-09 Thread Chad Versace
On Wed 08 Apr 2015, Frank Henigman wrote: On Wed, Apr 8, 2015 at 1:28 AM, Chad Versace wrote: On Tue 07 Apr 2015, Kristian Høgsberg wrote: On Tue, Apr 7, 2015 at 6:46 PM, Frank Henigman wrote: The name "surfaceless" suits me. Does this platform need to provide a hint to the user about buf

Re: [Mesa-dev] Problem with LLVM on Windows with MSVC

2015-04-09 Thread Shervin Sharifi
Thank you. I have compiled llvm with /MDd options, but Mesa doesn't accept that and asks for /MTd. So I compiled llvm with /MTd and it worked. However, I prefer to change Mesa to dynamic option, but I don't know how to do that. I tried the following, but got another error: The only thing I found i

Re: [Mesa-dev] [PATCH 3/5] i965/vs: Add src_reg::negative_equals method

2015-04-09 Thread Matt Turner
On Wed, Apr 8, 2015 at 4:38 PM, Ian Romanick wrote: > From: Ian Romanick > > This method is similar to the existing ::equals method. Instead of > testing that two src_regs are equal to each other, it tests that one is > the negation of the other. > > Signed-off-by: Ian Romanick > --- > src/mes

Re: [Mesa-dev] [PATCH 4/5] i965/vs: Allow CSE to handle MULs with negated arguments.

2015-04-09 Thread Ian Romanick
On 04/09/2015 09:37 AM, Matt Turner wrote: > On Wed, Apr 8, 2015 at 4:38 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This is similar to commit (47c4b38: i965/fs: Allow CSE to handle MULs >> with negated arguments.), but it uses a slightly different approach. > > Just repeating myself...

Re: [Mesa-dev] [PATCH 4/5] i965/vs: Allow CSE to handle MULs with negated arguments.

2015-04-09 Thread Matt Turner
On Wed, Apr 8, 2015 at 4:38 PM, Ian Romanick wrote: > From: Ian Romanick > > This is similar to commit (47c4b38: i965/fs: Allow CSE to handle MULs > with negated arguments.), but it uses a slightly different approach. Just repeating myself... I don't know why this is different if it doesn't do s

Re: [Mesa-dev] [PATCH 06/38] main: Removed tabs in framebuffer_texture.

2015-04-09 Thread Fredrik Höglund
Reviewed-by: Fredrik Höglund On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mesa/main/fbobject.c | 49 > > 1 file changed, 25 insertions(+), 24 deletions(-) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > in

Re: [Mesa-dev] st_TexSubImage: unaligned memcpy performance

2015-04-09 Thread Vasilis Liaskovitis
Hi, On Wed, Apr 8, 2015 at 1:24 PM, Daniel Stone wrote: > Hi, > > On 8 April 2015 at 10:57, Vasilis Liaskovitis wrote: > > I have an issue where st_TexSubImage causes very high CPU load in > > __memcpy_sse2_unaligned (Mesa 10.1.3, Xorg 1.15.1, radeon driver, HD > 7870). > > > > Any obvious caus

[Mesa-dev] Valve games for Mesa/DRI developers

2015-04-09 Thread Daniel Stone
Hi, At Collabora (my lovely dayjob), we've been working with Valve on SteamOS. Valve are keen to give back to the community, and we've been discussing ways they can help do that, including providing free access to Valve games on Steam to Debian developers last year. We're happy to say that this ha

[Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2015-04-09 Thread Boyan Ding
For the same reason as the i965 one, as suggested by Chih-Wei Huang. Cc: "10.4 10.5" Signed-off-by: Boyan Ding --- src/mesa/drivers/dri/i915/intel_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i915/intel_screen.c b/src/mesa/drivers/dri/i915

Re: [Mesa-dev] [PATCH] gallivm: Fix build since llvm-3.7.0svn r234460.

2015-04-09 Thread Tom Stellard
On Wed, Apr 08, 2015 at 10:56:37PM -0700, Vinson Lee wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89963 > Signed-off-by: Vinson Lee Reviewed-by: Tom Stellard > --- > src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/sr

Re: [Mesa-dev] [PATCH 05/38] main: Add entry point for NamedFramebufferRenderbuffer.

2015-04-09 Thread Fredrik Höglund
On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 ++ > src/mesa/main/fbobject.c | 139 > + > src/mesa/main/fbobject.h | 12 +++ > src/mesa/main/tests/dispatch_sanity.

[Mesa-dev] [PATCH 1/2] gallium/ttn: split out helper to get texture info

2015-04-09 Thread Rob Clark
From: Rob Clark We'll need this as well for TXQ. Split this out first to reduce noise in the next patch. Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 112 +--- 1 file changed, 59 insertions(+), 53 deletions(-) diff --git a/src/gallium/aux

Re: [Mesa-dev] [PATCH 10/12] nir: Store num_direct_uniforms in the nir_shader.

2015-04-09 Thread Jason Ekstrand
On Wed, Apr 8, 2015 at 12:48 PM, Ian Romanick wrote: > On 04/08/2015 12:06 AM, Kenneth Graunke wrote: >> Storing this here is pretty sketchy - I don't know if any driver other >> than i965 will want to use it. But this will make it a lot easier to >> generate NIR code at link time. We'll probabl

[Mesa-dev] [Bug 89963] lp_bld_debug.cpp:100:31: error: no matching function for call to ‘llvm?=::raw ostream::raw ostream()=?UTF-8?Q?’

2015-04-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89963 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 3/5] i965/vs: Add src_reg::negative_equals method

2015-04-09 Thread Ian Romanick
On 04/09/2015 09:31 AM, Matt Turner wrote: > On Wed, Apr 8, 2015 at 4:38 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This method is similar to the existing ::equals method. Instead of >> testing that two src_regs are equal to each other, it tests that one is >> the negation of the other.

Re: [Mesa-dev] [PATCH 01/38] main: Add utility function _mesa_lookup_framebuffer_err.

2015-04-09 Thread Fredrik Höglund
On Wednesday 04 March 2015, Laura Ekstrand wrote: > --- > src/mesa/main/fbobject.c | 18 ++ > src/mesa/main/fbobject.h | 4 > 2 files changed, 22 insertions(+) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index f8d0d92..8c2eb25 100644 > --- a/src/me

[Mesa-dev] [Bug 80821] When LIBGL_ALWAYS_SOFTWARE is set, KHR_create_context is not supported

2015-04-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80821 Charles Huber changed: What|Removed |Added CC||genpfa...@gmail.com -- You are receivin

Re: [Mesa-dev] [PATCH 03/23] i965/fs: Use MOV.nz instead of AND.nz to generate flag on GEN6+

2015-04-09 Thread Ian Romanick
On 04/06/2015 11:35 AM, Matt Turner wrote: > On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> On SNB+, the Boolean result is always 0 or ~0, so MOV.nz produces the >> same effect as AND.nz. However, later cmod propagation passes can >> handle the MOV.nz, but they

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

2015-04-09 Thread Kristian Høgsberg
On Wed, Apr 8, 2015 at 11:37 AM, Emil Velikov wrote: > Hi all, > > Can we get a pair of eyes on this patch please ? Reviewed-by: Kristian Høgsberg Thanks for the reminder. Kristian > > Boyan > For the future can you please include the CC mesa-stable line in the > commit message. It will make

Re: [Mesa-dev] [PATCH] st/mesa: align cube map arrays layers

2015-04-09 Thread Marek Olšák
This will prevent similar bugs in the future. It should be a candidate for stable. Whether the alignment is done unconditionally (like Ilia suggested) or not: Reviewed-by: Marek Olšák Marek On Wed, Apr 8, 2015 at 2:02 AM, Dave Airlie wrote: > From: Dave Airlie > > We create textures internal

Re: [Mesa-dev] [PATCH 2/5] glsl: Propagate negates through multiplication chains.

2015-04-09 Thread Matt Turner
On Wed, Apr 8, 2015 at 4:38 PM, Ian Romanick wrote: > From: Matt Turner > > We propagate negations to the right-most leaves of the multiplication > expression trees: > > - mul(neg(x), neg(y)) -> mul(x, y) > - mul(neg(x), y) -> neg(mul(x, y)) > - mul(x, neg(y)) -> neg(mul(x, y)) I've had an up

Re: [Mesa-dev] [PATCH 4/5] i965/vs: Allow CSE to handle MULs with negated arguments.

2015-04-09 Thread Jason Ekstrand
On Apr 8, 2015 4:38 PM, "Ian Romanick" wrote: > > From: Ian Romanick > > This is similar to commit (47c4b38: i965/fs: Allow CSE to handle MULs > with negated arguments.), but it uses a slightly different approach. > > Shader-db results: > > GM45: > total instructions in shared programs: 4060813 -

Re: [Mesa-dev] Problem with LLVM on Windows with MSVC

2015-04-09 Thread Jose Fonseca
Please read http://mesa3d.org/llvmpipe.html , "Requirements" sections. It's explained there how to tell which runtime to use when building LLVM. That said, you probably want to pass build=release to scons command. As SCons defaults to debug build. scons build=release ... Jose On 09/04/1

Re: [Mesa-dev] [PATCH] st/mesa: align cube map arrays layers

2015-04-09 Thread Marek Olšák
On Wed, Apr 8, 2015 at 2:43 AM, Ilia Mirkin wrote: > On Tue, Apr 7, 2015 at 8:02 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> We create textures internally for texsubimage, and we use >> the values from sub image to create a new texture, however >> we don't align these to valid sizes, and c