V2: make array processing functions static
---
src/glsl/lower_named_interface_blocks.cpp | 51 ++-
1 file changed, 37 insertions(+), 14 deletions(-)
diff --git a/src/glsl/lower_named_interface_blocks.cpp
b/src/glsl/lower_named_interface_blocks.cpp
index 7304c51..5f0d9
Le 24/03/2015 06:50, Zhang, Xiong Y a écrit :
You seem to miss the case when one is None and not the other.
It should return BadDrawable too.
This particular case seems not handled by the dri2 code either, and the gallium
state tracker seems to handle it in bindContext, but not the intel code fo
> Le 24/03/2015 06:50, Zhang, Xiong Y a écrit :
> >> You seem to miss the case when one is None and not the other.
> >> It should return BadDrawable too.
> >>
> >> This particular case seems not handled by the dri2 code either, and
> >> the gallium state tracker seems to handle it in bindContext, b
On 24/03/2015 08:33, Zhang, Xiong Y wrote :
Yes.
I imagine putting it into MakeContextCurrent is not a solution, since it means
GLXBadContext will be returned instead of GLXBadDrawable.
[Zhang, Xiong Y] Yes, I agree with you.
But it is strange that both macro GLXBadContext and Success are val
On 24/03/15 00:12, Laura Ekstrand wrote:
On Mon, Mar 23, 2015 at 12:04 PM, Martin Peres
mailto:martin.pe...@linux.intel.com>>
wrote:
v2:
- improve an error message
Reviewed-by: Laura Ekstrand mailto:la...@jlekstrand.net>>
v3:
- move a test to less generic functions
On 24/03/15 00:37, Laura Ekstrand wrote:
On Mon, Mar 23, 2015 at 12:14 PM, Martin Peres
mailto:martin.pe...@linux.intel.com>>
wrote:
v2: Review from Laura Ekstrand
- get rid of a change that should not have happened in this patch
- improve the error messages
- fix alignments
On 24.03.2015 04:28, Matthew Dawson wrote:
>
> Moving forward, I'd like to work on making piglit pass on my hardware
> (basically r600/radeonsi right now) for the non-skipped tests. Would that be
> ok to push forward within mesa, even it touches similar obscure "features"?
> Or would it be pr
Reviewed-by: Marek Olšák
Marek
On Mon, Mar 23, 2015 at 3:53 PM, Tom Stellard wrote:
> v2:
> - Fix typo
> ---
> src/gallium/drivers/radeonsi/si_pipe.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
> b/src/gallium/drivers/
Reviewed-by: Tapani Palli
On 03/23/2015 02:00 PM, Ilia Mirkin wrote:
Earlier commit 53bf7c8fd2e changed the logic to always call
base_alignment on structs. 1ec715ce8b12 hacked the function to return 0
for sampler fields, but didn't handle sampler arrays. Instead of
extending the hack, avoid cal
On 03/20/2015 10:58 PM, Ian Romanick wrote:
From: Ian Romanick
With previous changes to emit more ir_triop_csel, the i965 channel
expressions pass can generate sequences like:
mov(8) g45<1>F 1F
(+f0) sel(8)g40<1>F g45<8,8,1>F 1F
There are no shader-db changes
On Sat, 2015-03-21 at 09:27 -0700, Jason Ekstrand wrote:
>
> On Mar 21, 2015 2:49 AM, "Timothy Arceri"
> wrote:
> >
> > This series adds most of the remaining glsl arrays of arrays
> support. Support for uniform blocks is still missing, I've played
> around with this but don't have anything worki
We could already handle vector arguments to these -- we just couldn't
handle mixed scalar and vector arguments. So change the commit message
to something like "nir: Handle mixed scalar/vector arguments to
logical and/or/xor." and fix the typo and then this is
Reviewed-by: Connor Abbott
On Mon, M
https://bugs.freedesktop.org/show_bug.cgi?id=89726
Ilia Mirkin changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
v2:
- improve an error message
Reviewed-by: Laura Ekstrand
v3:
- move a test to less generic functions
- fix an alignment
v4:
- take the caller as a parameter instead of bool dsa
- check that the lookup returns a valid renderbuffer
Signed-off-by: Martin Peres
---
src/mapi/glapi/gen/ARB_direc
v2: Review from Laura Ekstrand
- get rid of a change that should not have happened in this patch
- improve the error messages
- fix alignments
- fix a capitalization in a function name in an error message
v3: Review from Laura Ekstrand
- move the test for the validity of the renderbuffer to less g
Am 20.03.2015 14:13, schrieb Glenn Kennard:
Add SV_GEOMETRY_EMIT special variable type to track the
implicit dependencies between CUT/EMIT_VERTEX/MEM_RING
instructions so GCM/scheduler doesn't reorder them.
Mark emit instructions as unkillable so DCE doesn't eat them.
Signed-off-by: Glenn Kenna
This patch enables clover to return the correct value for
CL_KERNEL_COMPILE_WORK_GROUP_SIZE and also verify that the correct
local_work_size is used when enqueuing kernels with this attribute.
---
src/gallium/state_trackers/clover/api/kernel.cpp | 9 +++-
src/gallium/state_trackers/clover/core/
---
.../state_trackers/clover/llvm/invocation.cpp | 71 +-
1 file changed, 41 insertions(+), 30 deletions(-)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
index 4da62b9..28198a5 100644
--- a/src
Tom Stellard writes:
> ---
> .../state_trackers/clover/llvm/invocation.cpp | 71
> +-
> 1 file changed, 41 insertions(+), 30 deletions(-)
>
This seems kind of ugly to me, what are you trying to achieve exactly?
> diff --git a/src/gallium/state_trackers/clover/llvm/inv
On Tue, Mar 24, 2015 at 06:51:31PM +0200, Francisco Jerez wrote:
> Tom Stellard writes:
>
> > ---
> > .../state_trackers/clover/llvm/invocation.cpp | 71
> > +-
> > 1 file changed, 41 insertions(+), 30 deletions(-)
> >
>
> This seems kind of ugly to me, what are you tr
Tom Stellard writes:
> This patch enables clover to return the correct value for
> CL_KERNEL_COMPILE_WORK_GROUP_SIZE and also verify that the correct
> local_work_size is used when enqueuing kernels with this attribute.
I doubt it makes sense to pass these around as kernel arguments.
module::arg
Thank you Ilia and Rob for your responses.
On Mon, Mar 23, 2015 at 3:39 PM, Rob Clark wrote:
> On Mon, Mar 23, 2015 at 3:59 PM, Ilia Mirkin wrote:
> > On Mon, Mar 23, 2015 at 3:57 PM, Shervin Sharifi
> wrote:
> >> Hi,
> >>
> >> I'm new to Mesa and I'm trying to understand the status of OpenGL
shader-db results for fragment shaders on i965:
total instructions in shared programs: 2908521 -> 2921865 (0.46%)
instructions in affected programs: 2203215 -> 2216559 (0.61%)
helped:2637
HURT: 5084
shader-db results
On 03/23/2015 05:00 AM, Ilia Mirkin wrote:
> Earlier commit 53bf7c8fd2e changed the logic to always call
> base_alignment on structs. 1ec715ce8b12 hacked the function to return 0
> for sampler fields, but didn't handle sampler arrays. Instead of
> extending the hack, avoid calling base_alignment in
On Tue, Mar 24, 2015 at 1:55 PM, Ian Romanick wrote:
> On 03/23/2015 05:00 AM, Ilia Mirkin wrote:
>> diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp
>> index 799c74b..59adc29 100644
>> --- a/src/glsl/link_uniforms.cpp
>> +++ b/src/glsl/link_uniforms.cpp
>> @@ -547,6 +547,8 @@
On Fri, Feb 20, 2015 at 2:31 PM, Neil Roberts wrote:
> On Gen9+ the 1D miptree is laid out with all of the mipmap levels in a
> horizontal line.
> ---
> src/mesa/drivers/dri/i965/brw_tex_layout.c | 62
> +-
> 1 file changed, 60 insertions(+), 2 deletions(-)
>
> diff -
From: Ian Romanick
The downcast functions for non-leaf classes were previously implemented
"by hand." Now they are implemented using macros based on the is_foo
functions added in the previous patch.
Signed-off-by: Ian Romanick
Cc: Francisco Jerez
---
src/glsl/ir.h | 40 +-
From: Ian Romanick
Now that they're all implemented using macros, this is trivial.
Signed-off-by: Ian Romanick
Cc: Francisco Jerez
---
src/glsl/ir.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/glsl/ir.h b/src/glsl/ir.h
index ff30263..7294629 100644
--- a/src/glsl/ir.h
From: Ian Romanick
v2: Don't be lazy. Constify the as_foo functions and use those instead
of ugly casts. Suggested by Curro.
Signed-off-by: Ian Romanick
Cc: Francisco Jerez
---
src/glsl/ir.h | 21 ++---
src/glsl/ir_equals.cpp | 20
2 files chang
From: Ian Romanick
These functions deteremine when an IR node is one of the non-leaf
classes.
Signed-off-by: Ian Romanick
Cc: Francisco Jerez
---
src/glsl/ir.h | 25 +
1 file changed, 25 insertions(+)
diff --git a/src/glsl/ir.h b/src/glsl/ir.h
index fdc22ed..b2b4822 1
Thanks for the review! Please see some comments inline:
On 03/23/2015 06:53 PM, Laura Ekstrand wrote:
> I'm glad you found this target checking problem. I have come across the
> same problem in other texture functions, but I have been too busy to
> find all instances of this. It's kind of a natu
On 23/03/15 20:45, Bernd Kuhls wrote:
> Matt Turner wrote in
> news:caedq38ela86kqtjkagscovt70ep8ato3aeqtowbuvk-+xuf...@mail.gmail.com:
>
>> so maybe uclibc just needs to add them.
>
> Hi,
>
> they did :) http://git.uclibc.org/uClibc/commit/?id=
> 6c4538905e65ceb203f59aaa9a61728e81c6bc0a
>
>
On Tue, 24 Mar 2015 17:21:35 +0100, Dieter Nützel
wrote:
Am 20.03.2015 14:13, schrieb Glenn Kennard:
Add SV_GEOMETRY_EMIT special variable type to track the
implicit dependencies between CUT/EMIT_VERTEX/MEM_RING
instructions so GCM/scheduler doesn't reorder them.
Mark emit instructions as u
https://bugs.freedesktop.org/show_bug.cgi?id=89586
--- Comment #25 from Dan Sebald ---
I will attach an initial attempt at a Piglit test suite for glPixelZoom() in
combination with glDrawPixels(). I tried (but failed) to set something up in
which if a test fails the associated image is displayed
https://bugs.freedesktop.org/show_bug.cgi?id=89586
--- Comment #26 from Dan Sebald ---
Created attachment 114591
--> https://bugs.freedesktop.org/attachment.cgi?id=114591&action=edit
Piglit pixelzoom test suite
See https://bugs.freedesktop.org/show_bug.cgi?id=89586#c25 for a description of
thi
https://bugs.freedesktop.org/show_bug.cgi?id=89586
--- Comment #27 from Dan Sebald ---
Created attachment 114592
--> https://bugs.freedesktop.org/attachment.cgi?id=114592&action=edit
swrast legacy Piglit test images
SWRAST_DRI.SO LEGACY
This is the current repository version of the legacy swr
https://bugs.freedesktop.org/show_bug.cgi?id=89586
--- Comment #28 from Dan Sebald ---
Created attachment 114593
--> https://bugs.freedesktop.org/attachment.cgi?id=114593&action=edit
swrast legacy with patch Piglit test images
SWRAST_DRI.SO LEGACY PATCH
With the Mesa changeset I attached to t
https://bugs.freedesktop.org/show_bug.cgi?id=89586
--- Comment #29 from Dan Sebald ---
Created attachment 114594
--> https://bugs.freedesktop.org/attachment.cgi?id=114594&action=edit
swrast Gallium Piglit test images
SWRAST_DRI.SO GALLIUM
The test images illustrate how the Gallium/LLVM driver
https://bugs.freedesktop.org/show_bug.cgi?id=89586
--- Comment #30 from Dan Sebald ---
Created attachment 114595
--> https://bugs.freedesktop.org/attachment.cgi?id=114595&action=edit
swrast Gallium with patch Piglit test images
SWRAST_DRI.SO GALLIUM PATCH
By making that simple change in src/m
On 23/03/15 16:15, Emil Velikov wrote:
During 'make dist' the path of the symbolic link (x11/dri2.c) becomes
too long, and tar converts it to hard one. To make it more complicated
on Haiku tar errors out (due to lack of hardlink support) rather than
falling back to the next best thing.
So remove
Cc: 10.5 10.4
---
src/gallium/state_trackers/clover/core/program.cpp | 6 +-
src/gallium/state_trackers/clover/core/program.hpp | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/clover/core/program.cpp
b/src/gallium/state_trackers/clover/core/pro
https://bugs.freedesktop.org/show_bug.cgi?id=89586
--- Comment #31 from Dan Sebald ---
Created attachment 114596
--> https://bugs.freedesktop.org/attachment.cgi?id=114596&action=edit
swrast legacy Piglit test images
SWRAST_DRI.SO LEGACY
This is the current repository version of the legacy swr
https://bugs.freedesktop.org/show_bug.cgi?id=89586
--- Comment #32 from Dan Sebald ---
Created attachment 114597
--> https://bugs.freedesktop.org/attachment.cgi?id=114597&action=edit
swrast legacy with patch Piglit test images
SWRAST_DRI.SO LEGACY PATCH
With the Mesa changeset I attached to t
https://bugs.freedesktop.org/show_bug.cgi?id=89586
--- Comment #33 from Dan Sebald ---
Created attachment 114598
--> https://bugs.freedesktop.org/attachment.cgi?id=114598&action=edit
swrast Gallium Piglit test images
SWRAST_DRI.SO GALLIUM
The test images illustrate how the Gallium/LLVM driver
https://bugs.freedesktop.org/show_bug.cgi?id=89586
--- Comment #34 from Dan Sebald ---
Created attachment 114599
--> https://bugs.freedesktop.org/attachment.cgi?id=114599&action=edit
swrast Gallium with patch Piglit test images
SWRAST_DRI.SO GALLIUM PATCH
By making that simple change in src/m
https://bugs.freedesktop.org/show_bug.cgi?id=89586
Dan Sebald changed:
What|Removed |Added
Attachment #114593|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=89586
Dan Sebald changed:
What|Removed |Added
Attachment #114592|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=89586
Dan Sebald changed:
What|Removed |Added
Attachment #114595|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=89586
Dan Sebald changed:
What|Removed |Added
Attachment #114594|0 |1
is obsolete|
Tom Stellard writes:
> Cc: 10.5 10.4
> ---
> src/gallium/state_trackers/clover/core/program.cpp | 6 +-
> src/gallium/state_trackers/clover/core/program.hpp | 1 +
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/clover/core/program.cpp
> b/src/
On Tue, 2015-03-24 at 22:24 +0200, Francisco Jerez wrote:
> Tom Stellard writes:
>
> > Cc: 10.5 10.4
> > ---
> > src/gallium/state_trackers/clover/core/program.cpp | 6 +-
> > src/gallium/state_trackers/clover/core/program.hpp | 1 +
> > 2 files changed, 6 insertions(+), 1 deletion(-)
> >
>
Jan Vesely writes:
> On Tue, 2015-03-24 at 22:24 +0200, Francisco Jerez wrote:
>> Tom Stellard writes:
>>
>> > Cc: 10.5 10.4
>> > ---
>> > src/gallium/state_trackers/clover/core/program.cpp | 6 +-
>> > src/gallium/state_trackers/clover/core/program.hpp | 1 +
>> > 2 files changed, 6 inse
On 21/03/15 17:12, Matt Turner wrote:
> On Sat, Mar 21, 2015 at 10:10 AM, Emil Velikov
> wrote:
>> On 17/03/15 23:44, Emil Velikov wrote:
>>> On 17/03/15 01:25, Jonathan Gray wrote:
On Mon, Mar 16, 2015 at 08:37:28PM +, Emil Velikov wrote:
> On 26/02/15 13:49, Jose Fonseca wrote:
>>>
On Tue, Mar 24, 2015 at 10:36:19PM +0200, Francisco Jerez wrote:
> Jan Vesely writes:
>
> > On Tue, 2015-03-24 at 22:24 +0200, Francisco Jerez wrote:
> >> Tom Stellard writes:
> >>
> >> > Cc: 10.5 10.4
> >> > ---
> >> > src/gallium/state_trackers/clover/core/program.cpp | 6 +-
> >> > src
On 23/03/15 17:16, Matt Turner wrote:
> Thanks Emil. For the series
>
> Reviewed-by: Matt Turner
>
YW. I'll get those in asap, seeing that Ken has been having fun on
(somewhat related) topic.
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.
Cc: 10.5 10.4
---
src/gallium/state_trackers/clover/api/program.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/state_trackers/clover/api/program.cpp
b/src/gallium/state_trackers/clover/api/program.cpp
index 60184ed..fcec1d7 100644
--- a/src/gallium/state_trackers/clover/
Hi Ken,
On 24/03/15 00:37, Kenneth Graunke wrote:
> Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass.
>
> Not compiled on SCons, like the rest of NIR.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/Makefile.am|2 +
> src/mesa/Makefile.sources |5
On Tue, 2015-03-24 at 22:36 +0200, Francisco Jerez wrote:
> Jan Vesely writes:
>
> > On Tue, 2015-03-24 at 22:24 +0200, Francisco Jerez wrote:
> >> Tom Stellard writes:
> >>
> >> > Cc: 10.5 10.4
> >> > ---
> >> > src/gallium/state_trackers/clover/core/program.cpp | 6 +-
> >> > src/galliu
On Tue, Mar 24, 2015 at 11:25 AM, Ian Romanick wrote:
> From: Ian Romanick
>
> These functions deteremine when an IR node is one of the non-leaf
> classes.
>
> Signed-off-by: Ian Romanick
> Cc: Francisco Jerez
> ---
> src/glsl/ir.h | 25 +
> 1 file changed, 25 insertion
I didn't meant to remove the 'if not os.path.exists(filename)' statement.
---
src/mesa/SConscript | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/mesa/SConscript b/src/mesa/SConscript
index a563fd2..5b80a21 100644
--- a/src/mesa/SConscript
+++ b/src/mesa/SConscript
@
Useless, as there are no drivers for it.
---
src/SConscript | 2 +-
src/egl/main/Makefile.am | 1 -
src/egl/main/SConscript | 11 +--
3 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/src/SConscript b/src/SConscript
index 188ab08..40b7fc1 100644
--- a/src/SConscr
MSVC's implementation of signbit(x) uses sizeof(x) with expressions to
dispatch to an internal function based on the argument's type (float,
double, etc), but that raises a flag with MSVC's own static analyzer,
and because this is an inline function in a header it causes substantial
warning spam.
-
MSVC 2013 declares these functions, both for C and C++ source files.
This was caught with MSVC in analyze mode.
---
include/c99_math.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/c99_math.h b/include/c99_math.h
index 5b01d53..ee0dd10 100644
--- a/include/c99_math
There doesn't seem much interest on osmesa on Windows, particularly classic
osmesa.
If there is indeed interest in osmesa on Windows, we should instead
integrate src/gallium/targets/osmesa into SCons.
---
src/mesa/drivers/SConscript| 2 --
src/mesa/drivers/osmesa/SConscript | 39 ---
Somehow, merely including any of the *intrin.h headers causes dozens of
this warnings (when compiling pretty much every source file). MSVC does
not always complain the same -- so it's possible we're doing something
weird --, but silence these warnings in the meanwhile.
---
scons/gallium.py | 1 +
EGL was the last user.
---
src/SConscript | 3 ++-
src/loader/Makefile.am | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/SConscript b/src/SConscript
index 40b7fc1..b0578e8 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -12,7 +12,8 @@ if env['hostonly']:
These are due how we implemented the atomic tests, not the atomic
implementation itself. It's also difficult to refactor the code to
avoid the warnings due to the use of macros -- the code would be quite
hairy.
---
src/util/u_atomic_test.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/
On 03/24/2015 02:14 PM, Matt Turner wrote:
> On Tue, Mar 24, 2015 at 11:25 AM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> These functions deteremine when an IR node is one of the non-leaf
>> classes.
>>
>> Signed-off-by: Ian Romanick
>> Cc: Francisco Jerez
>> ---
>> src/glsl/ir.h | 25 +++
Tom Stellard writes:
> Cc: 10.5 10.4
> ---
> src/gallium/state_trackers/clover/api/program.cpp | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/gallium/state_trackers/clover/api/program.cpp
> b/src/gallium/state_trackers/clover/api/program.cpp
> index 60184ed..fcec1d7 100644
>
On Mon, Mar 23, 2015 at 8:37 PM, Kenneth Graunke wrote:
> Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass.
>
> Not compiled on SCons, like the rest of NIR.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/Makefile.am|2 +
> src/mesa/Makefile.sources |
On 03/24/2015 05:01 AM, Tapani Pälli wrote:
>
> On 03/20/2015 10:58 PM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> With previous changes to emit more ir_triop_csel, the i965 channel
>> expressions pass can generate sequences like:
>>
>> mov(8) g45<1>F 1F
>> (+f0) sel(
On Tuesday, March 24, 2015 08:52:01 PM Emil Velikov wrote:
> Hi Ken,
>
> On 24/03/15 00:37, Kenneth Graunke wrote:
> > Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass.
> >
> > Not compiled on SCons, like the rest of NIR.
> >
> > Signed-off-by: Kenneth Graunke
> > ---
> > src/mesa/Ma
I think this is being both too aggressive and not aggressive enough.
First, the too aggressive part. Imagine if we have something like:
a = mul b, c;
d = add a, 1.0;
e = add a, 2.0;
f = add a, 3.0;
In this case, we don't want to turn this into a series of 3 mad's
since the 3 load immediate instru
On 03/24/2015 03:16 PM, Jose Fonseca wrote:
These are due how we implemented the atomic tests, not the atomic
implementation itself. It's also difficult to refactor the code to
avoid the warnings due to the use of macros -- the code would be quite
hairy.
---
src/util/u_atomic_test.c | 5 +
First off, these are all heuristics and we need to keep that in mind.
On Tue, Mar 24, 2015 at 3:39 PM, Connor Abbott wrote:
> I think this is being both too aggressive and not aggressive enough.
> First, the too aggressive part. Imagine if we have something like:
>
> a = mul b, c;
> d = add a, 1.
We already have a lower_negate compiler option, so I think it would be
better to add the 1 line of code to lower sub -> neg predicated on
!lower_neg to nir_opt_algebraic.
On Mon, Mar 23, 2015 at 8:37 PM, Kenneth Graunke wrote:
> prog_to_nir uses this for OPCODE_SUB.
>
> Signed-off-by: Kenneth Gra
On Tue, Mar 24, 2015 at 11:34 AM, Eduardo Lima Mitev
wrote:
> Thanks for the review! Please see some comments inline:
>
> On 03/23/2015 06:53 PM, Laura Ekstrand wrote:
> > I'm glad you found this target checking problem. I have come across the
> > same problem in other texture functions, but I h
This looks good.
Reviewed-by: Laura Ekstrand
On Tue, Mar 24, 2015 at 7:42 AM, Martin Peres
wrote:
> v2:
> - improve an error message
>
> Reviewed-by: Laura Ekstrand
>
> v3:
> - move a test to less generic functions
> - fix an alignment
>
> v4:
> - take the caller as a parameter instead of boo
Looks good to me.
Reviewed-by: Laura Ekstrand
On Tue, Mar 24, 2015 at 7:43 AM, Martin Peres
wrote:
> v2: Review from Laura Ekstrand
> - get rid of a change that should not have happened in this patch
> - improve the error messages
> - fix alignments
> - fix a capitalization in a function name
On Tue, Mar 24, 2015 at 3:39 PM, Connor Abbott wrote:
> I think this is being both too aggressive and not aggressive enough.
> First, the too aggressive part. Imagine if we have something like:
>
> a = mul b, c;
> d = add a, 1.0;
> e = add a, 2.0;
> f = add a, 3.0;
>
> In this case, we don't want
Kenneth Graunke writes:
> Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass.
>
> Not compiled on SCons, like the rest of NIR.
>
> Signed-off-by: Kenneth Graunke
Nice. I think at some point we'll want a lowering pass for texture
projection. The recommendation to do fsub in algebraic i
Hi,
I'm new to Mesa.
I'm trying to build Mesa for Windows using Visual Studio, but couldn't
find instructions for that. The related threads on this mailing list also
seem outdated.
Could anyone give me some hint or point me to instructions if there is
any?
Thanks,
Shervin
From: Kristian Høgsberg
We were building libglsl_util.la without our visibility flags and
leaking hash_table_* symbols.
Signed-off-by: Kristian Høgsberg
---
src/Makefile.am | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/Makefile.am b/src/Makefile.am
index 8edf333..874a333 100644
--
https://bugs.freedesktop.org/show_bug.cgi?id=89754
Bug ID: 89754
Summary: vertexAttrib fails WebGL Conformance test with mesa
drivers
Product: Mesa
Version: unspecified
Hardware: Other
OS: All
St
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=89754
--- Comment #1 from Tapani Pälli ---
test passes on i965 driver
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
___
mesa-dev mailing list
mul x, -y is equivalent to mul -x, y; and mul x, y is the negation of
mul x, -y.
Without NIR:
total instructions in shared programs: 6192304 -> 6185280 (-0.11%)
instructions in affected programs: 987931 -> 980907 (-0.71%)
helped:4146
HURT:
On 2015-03-23 17:37:58, Kenneth Graunke wrote:
> Our fragment program backend implements support for TXP directly, and
> there's no NIR lowering pass to remove the projection. When we switch
> fragment program support over to NIR, we need to support it somehow.
>
> It's easy enough to support dir
On 03/25/2015 12:02 AM, Laura Ekstrand wrote:
> > + if (_mesa_is_gles3(ctx)) {
> > + /* Validation of format and type for ES3 has to be done here
> > + * after the texture image is resolved, because the internal
> > + * format is needed for the ver
On 2015-03-23 17:37:59, Kenneth Graunke wrote:
> Use prog_to_nir where we would normally call glsl_to_nir, handle program
> parameter lists, and skip a few things that don't exist.
>
> Using NIR generates much better shader code than Mesa IR, since we get
> real optimizations, as opposed to prog_o
On 2015-03-23 17:38:00, Kenneth Graunke wrote:
> Everything is already in place; we simply have to take the scalar code
> generation path. This gives us SIMD8 VS programs, instead of SIMD4x2.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_vec4.cpp | 14 ++
>
91 matches
Mail list logo
