Re: [Mesa-dev] [PATCH] glx: Handle out-of-sequence swap completion events correctly. (v2)

2015-03-16 Thread Michel Dänzer
On 13.03.2015 04:34, Mario Kleiner wrote: > The code for emitting INTEL_swap_events swap completion > events needs to translate from 32-Bit sbc on the wire to > 64-Bit sbc for the events and handle wraparound accordingly. > > It assumed that events would be sent by the server in the > order their

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #1 from Ronie Salgado --- Created attachment 114336 --> https://bugs.freedesktop.org/attachment.cgi?id=114336&action=edit LLVM AMDGPU get_global_offset() patch -- You are receiving this mail because: You are the assignee for the b

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 Ronie Salgado changed: What|Removed |Added CC||ronies...@gmail.com --- Comment #2 from

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #3 from Ronie Salgado --- I checked the latest version of the clover codebase and it pushes the global offsets into the end of the input buffer. I made it work with AMD capeverde(HD7770) by adding the intrinsics needed to implement O

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 Bug ID: 89586 Summary: Drivers/DRI/swrast Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: normal Priority: medium

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #1 from Dan Sebald --- Created attachment 114339 --> https://bugs.freedesktop.org/attachment.cgi?id=114339&action=edit Minimal changeset to fix vertical lines when -1 < xfactor < 1 -- You are receiving this mail because: You are t

[Mesa-dev] [PATCH v2] i965/fs: in MAD optimizations, switch last argument to be immediate

2015-03-16 Thread Tapani Pälli
Commit bb33a31 introduced optimizations that transform cases of MAD in to simpler forms but it did not take in to account that src[0] can not be immediate and did not report progress. Patch switches src[0] and src[1] if src[0] is immediate and adds progress reporting. If both sources are immediates

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #2 from Dan Sebald --- Created attachment 114340 --> https://bugs.freedesktop.org/attachment.cgi?id=114340&action=edit Illustration of why ceil() is the correct operation to apply to zoom box -- You are receiving this mail because

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 Dan Sebald changed: What|Removed |Added Attachment #114338|text/plain |image/png mime type|

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #3 from Dan Sebald --- Created attachment 114341 --> https://bugs.freedesktop.org/attachment.cgi?id=114341&action=edit Example gradient image resulting after changeset applied. Vertical lines gone. -- You are receiving this mail

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #4 from Dan Sebald --- I'm now going to attach the full patch which fixes what I believe is another subtle bug and attempts to make things slightly more efficient in the innermost loop. I notice in the following hunk of code from s_z

Re: [Mesa-dev] [PATCH v2] i965/fs: in MAD optimizations, switch last argument to be immediate

2015-03-16 Thread Kenneth Graunke
On Monday, March 16, 2015 10:08:08 AM Tapani Pälli wrote: > Commit bb33a31 introduced optimizations that transform cases of MAD > in to simpler forms but it did not take in to account that src[0] > can not be immediate and did not report progress. Patch switches > src[0] and src[1] if src[0] is imm

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #5 from Dan Sebald --- Created attachment 114342 --> https://bugs.freedesktop.org/attachment.cgi?id=114342&action=edit Changeset to fix vertical lines and fine tune positive_unzoom_x() and negative_unzoom_x() -- You are receiving

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #6 from Dan Sebald --- One last comment about the efficiency of the pixel zooming. This routine seems slow when I rescale the image; it's tolerable, but could be faster. There is a setup of the memory addresses and context for every

Re: [Mesa-dev] [PATCH] i965: Emit IF/ELSE/ENDIF/WHILE JIP with type W on Gen7

2015-03-16 Thread Antía Puentes
Hi!, On vie, 2015-03-13 at 10:42 -0700, Matt Turner wrote: > On Fri, Mar 13, 2015 at 3:41 AM, Antia Puentes wrote: > > IvyBridge and Haswell PRM say that the JIP should be emitted > > with type W but we were using UD. The previous implementation > > did not show adverse effects, however changing

Re: [Mesa-dev] [PATCH 00/10] radeonsi: Line and polygon smoothing

2015-03-16 Thread Marek Olšák
I'm pretty sure this was first supported in SI. See register deltas or DB block deltas. Marek On Sun, Mar 15, 2015 at 11:07 PM, Alex Deucher wrote: > On Sun, Mar 15, 2015 at 3:48 PM, Marek Olšák wrote: >> This mainly adds support for line and polygon smoothing. Only GCN supports >> it in hardw

[Mesa-dev] [Bug 79629] [Dri3 bisected] piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fail

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79629 Gordon Jin changed: What|Removed |Added Priority|highest |high -- You are receiving this mail becaus

[Mesa-dev] [PATCH] gallium/sw/kms: trivial cleanups

2015-03-16 Thread Emil Velikov
Remove the forward declaration and make use of the DEBUG_PRINT macro for debug builds. Signed-off-by: Emil Velikov --- src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c b/

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Tapani Pälli
Hi Ian; Is there some particular Piglit test case that hits this path and is it possible with gen>5 (by removing gen check)? I've tried this with handicrafted shader_test and also shader-db and cannot hit the conditions for changes to happen. Would be nice to be able to run examine changes an

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-16 Thread Martin Peres
On 13/03/15 19:24, Laura Ekstrand wrote: We should try to steer people away from just writing Piglit tests for GSoC, unless they have a specific mentor in mind and have already talked to him or her. In my experience, Piglit tests are difficult to do well because each one is drastically differe

Re: [Mesa-dev] [PATCH 02/23] mesa/glsl: build list of program resources during linking

2015-03-16 Thread Tapani Pälli
On 03/13/2015 06:16 PM, Ilia Mirkin wrote: On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: Patch adds ProgramResourceList to gl_shader_program structure. List contains references to active program resources and is constructed during linking phase. This list will be used by follow-up pat

[Mesa-dev] Merging rbug-gui into mesa

2015-03-16 Thread Emil Velikov
Hi all, As mentioned in another thread [1] there is interest in keeping the rbug driver. Although it's user - rbug-gui, lives in a repo outside of mesa leading to issues whenever we change/re-factor mesa. Considering that the tool/repo does not have branches that follow mesa's and the mesa and

Re: [Mesa-dev] [PATCH 11/13] i965: Add untyped surface write opcode.

2015-03-16 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Fri, Feb 27, 2015 at 05:34:54PM +0200, Francisco Jerez wrote: >> --- >> src/mesa/drivers/dri/i965/brw_defines.h| 1 + >> src/mesa/drivers/dri/i965/brw_eu.h | 7 +++ >> src/mesa/drivers/dri/i965/brw_eu_emit.c| 51 >> +

[Mesa-dev] [PATCH 1/2] tools/rbug-gui: add it to the existing automake build

2015-03-16 Thread Emil Velikov
Signed-off-by: Emil Velikov --- Makefile.am| 3 ++- configure.ac | 15 +++ src/gallium/Makefile.am| 6 +- src/gallium/tools/rbug-gui/.gitignore | 1 + src/gallium/tools/rbug-gui/Makefile.am | 27

[Mesa-dev] [PATCH 2/2] rbug: update the READMEs to reflect the import of rbug-gui

2015-03-16 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/auxiliary/rbug/README | 2 +- src/gallium/docs/source/debugging.rst | 4 ++-- src/gallium/docs/source/distro.rst| 2 +- src/gallium/drivers/rbug/README | 5 ++--- src/gallium/tools/rbug-gui/README | 28 +---

Re: [Mesa-dev] [PATCH] i965: Set nr_params to the number of uniform components in the VS/GS path.

2015-03-16 Thread Francisco Jerez
Francisco Jerez writes: > Both do_vs_prog and do_gs_prog initialize brw_stage_prog_data::nr_params to > the number of uniform *vectors* required by the shader rather than the number > of uniform components, contradicting the comment. This is inconsistent with > what the state upload code and sca

[Mesa-dev] [Bug 89590] Crash in glLinkProgram with shaders with multiple constant arrays

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89590 Bug ID: 89590 Summary: Crash in glLinkProgram with shaders with multiple constant arrays Product: Mesa Version: 10.5 Hardware: Other OS: All Sta

Re: [Mesa-dev] [PATCH 00/10] radeonsi: Line and polygon smoothing

2015-03-16 Thread Alex Deucher
On Mon, Mar 16, 2015 at 7:20 AM, Marek Olšák wrote: > I'm pretty sure this was first supported in SI. See register deltas or > DB block deltas. The DB_EQAA stuff was added in cayman, but I don't remember what specific features it supported relative to SI. You would probably know better. Alex >

Re: [Mesa-dev] [PATCH 2/2] radeonsi: implement TGSI_OPCODE_BFI (v2)

2015-03-16 Thread Tom Stellard
On Sun, Mar 15, 2015 at 07:59:52PM +0100, Marek Olšák wrote: > From: Marek Olšák > > v2: Don't use the intrinsics, the shader backend can recognize these > patterns and generates optimal code automatically. Reviewed-by: Tom Stellard > --- > .../drivers/radeon/radeon_setup_tgsi_llvm.c

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add a helper for extracting bitfields from parameters (v2)

2015-03-16 Thread Tom Stellard
On Sun, Mar 15, 2015 at 07:59:51PM +0100, Marek Olšák wrote: > From: Marek Olšák > > This will be used a lot (especially by tessellation). > > v2: don't use the bfe intrinsic Reviewed-by: Tom Stellard > --- > src/gallium/drivers/radeonsi/si_shader.c | 43 > >

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-16 Thread Marek Olšák
On Fri, Mar 13, 2015 at 6:24 PM, Laura Ekstrand wrote: > We should try to steer people away from just writing Piglit tests for GSoC, > unless they have a specific mentor in mind and have already talked to him or > her. In my experience, Piglit tests are difficult to do well because each > one is

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #4 from Tom Stellard --- Comment on attachment 114336 --> https://bugs.freedesktop.org/attachment.cgi?id=114336 LLVM AMDGPU get_global_offset() patch Review of attachment 114336:

Re: [Mesa-dev] [PATCH 3/4] util: Change util/set to use quadratic probing

2015-03-16 Thread Thomas Helland
2015-03-16 6:49 GMT+01:00 Connor Abbott : > Ok, so I think I managed to find the source of the bug. When inserting > elements into the set/hash table, we computed the initial probe > address *before* doing the rehash. In the case where inserting an > element led to a rehash, this meant that we'd us

Re: [Mesa-dev] [PATCH] Allow static libstdc++/libgcc linking if selected

2015-03-16 Thread Vivek Das Mohapatra
You do realize that statically linking libstdc++ and libgcc_s while dynamically linking LLVM won't work around the problem caused by Steam overriding an older version of libstdc++, because LLVM will still be dynamically linked against that? As you'll note from my first submission, I sent a patch

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #5 from Tom Stellard --- Comment on attachment 114337 --> https://bugs.freedesktop.org/attachment.cgi?id=114337 libclc get_global_offset() and get_global_id() patch Review of attachment 114337: -

Re: [Mesa-dev] [PATCH] gallium/sw/kms: trivial cleanups

2015-03-16 Thread Brian Paul
On 03/16/2015 05:50 AM, Emil Velikov wrote: Remove the forward declaration and make use of the DEBUG_PRINT macro for debug builds. Signed-off-by: Emil Velikov --- src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/g

Re: [Mesa-dev] [PATCH] egl: don't fill client apis string forever.

2015-03-16 Thread Brian Paul
On 03/15/2015 11:22 PM, Dave Airlie wrote: We never reset the string on eglTerminate, so it grows for ever on multiple eglInitialise. Signed-off-by: Dave Airlie --- src/egl/main/eglapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index b

Re: [Mesa-dev] [PATCH] common.py: Fix PEP 8 issues.

2015-03-16 Thread Brian Paul
Reviewed-by: Brian Paul On 03/14/2015 02:46 AM, Vinson Lee wrote: Signed-off-by: Vinson Lee --- common.py | 97 ++- 1 file changed, 53 insertions(+), 44 deletions(-) diff --git a/common.py b/common.py index 1d2d586..7a93941 100644

[Mesa-dev] [PATCH 3/3] r600g: constify r600_shader_tgsi_instruction lists.

2015-03-16 Thread Emil Velikov
Massive list of constant data. Annotate it as such. Signed-off-by: Emil Velikov --- src/gallium/drivers/r600/r600_shader.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index acac89f

[Mesa-dev] [PATCH 1/3] r600g: use the tgsi opcode from parse.FullToken.FullInstruction

2015-03-16 Thread Emil Velikov
... rather than the local one in inst_info->tgsi_opcode. This will allow us to simplify struct r600_shader_tgsi_instruction. Signed-off-by: Emil Velikov --- src/gallium/drivers/r600/r600_shader.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/gallium/drive

[Mesa-dev] [PATCH 2/3] r600g: kill off r600_shader_tgsi_instruction::{tgsi_opcode, is_op3}

2015-03-16 Thread Emil Velikov
Both of which are no longer used. Use designated initializer to make things obvious as people add/remove TGSI_OPCODEs. Signed-off-by: Emil Velikov --- src/gallium/drivers/r600/r600_shader.c | 1180 1 file changed, 589 insertions(+), 591 deletions(-) diff --git a

[Mesa-dev] [PATCH 0/3] r600g: simplify the r600_shader_tgsi_instruction lists

2015-03-16 Thread Emil Velikov
Hi all, Short series inspired by Marek's 216543ea547(gallium: add FMA and DFMA opcodes (v3)) Some numbers for the megadri driver (r600g & swrastg). Before textdata bss dec hex filename 17616701 916208 2029152 20562061139c08d r600_dri.so After textdata

Re: [Mesa-dev] [PATCH] gallivm: abort properly when running out of buffer space in lp_disassembly

2015-03-16 Thread Brian Paul
On 03/13/2015 04:46 PM, srol...@vmware.com wrote: From: Roland Scheidegger Before this actually ran into an infinite loop printing out "invalid"... --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/

[Mesa-dev] [Bug 89584] Minor bug in OpenCL example

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89584 Tom Stellard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 1/3] auxiliary/os: fix the android build - s/drm_munmap/os_munmap/

2015-03-16 Thread Emil Velikov
Squash this silly typo introduced with commit c63eb5dd5ec(auxiliary/os: get the mmap/munmap wrappers working with android) Cc: "10.4 10.5" Signed-off-by: Emil Velikov --- src/gallium/auxiliary/os/os_mman.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxil

[Mesa-dev] [PATCH 2/3] st/dri: remove unused include from the automake/scons build

2015-03-16 Thread Emil Velikov
st/dri/common hasn't been around for a while. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/Makefile.am | 1 - src/gallium/state_trackers/dri/SConscript | 1 - 2 files changed, 2 deletions(-) diff --git a/src/gallium/state_trackers/dri/Makefile.am b/src/gallium/state_trackers

Re: [Mesa-dev] [PATCH] egl: don't fill client apis string forever.

2015-03-16 Thread Matt Turner
On Sun, Mar 15, 2015 at 10:22 PM, Dave Airlie wrote: > We never reset the string on eglTerminate, so it grows > for ever on multiple eglInitialise. > > Signed-off-by: Dave Airlie > --- > src/egl/main/eglapi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/egl/main/eglapi.c b/src/eg

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 88781, which changed state. Bug 88781 Summary: Unity3D based games exhibit problems with texture scaling in menus on high resolutions https://bugs.freedesktop.org/show_bug.cgi?id=88781 What|Removed

Re: [Mesa-dev] [PATCH 1/3] auxiliary/os: fix the android build - s/drm_munmap/os_munmap/

2015-03-16 Thread Emil Velikov
On 16/03/15 15:00, Emil Velikov wrote: > Squash this silly typo introduced with commit c63eb5dd5ec(auxiliary/os: get > the mmap/munmap wrappers working with android) > A couple of bits: - More is needed than this patch to get master (and the stable branches) building properly. Those will be comi

Re: [Mesa-dev] [PATCH 1/1] Fix runtime error with uClibc

2015-03-16 Thread Emil Velikov
Hi Bernd, On 15/03/15 11:27, Bernd Kuhls wrote: > Patch inspired by > https://www.winehq.org/pipermail/wine-bugs/2011-September/288987.html > http://git.alpinelinux.org/cgit/aports/tree/main/wine/uclibc-fmaxf-fminf.patch?id=c9b491b6099eec02a835ffd05539b5c783c6c43a > > Starting an app using mesa3d

Re: [Mesa-dev] [PATCH] gallivm: abort properly when running out of buffer space in lp_disassembly

2015-03-16 Thread Jose Fonseca
On 13/03/15 22:46, srol...@vmware.com wrote: From: Roland Scheidegger Before this actually ran into an infinite loop printing out "invalid"... --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxil

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-16 Thread Laura Ekstrand
That was basically my background (mechanical engineering + lots of OpenGL) when I started six months ago, but I have found the lack of mentoring to be a large roadblock. At that time, I wrote tests, but there were few people willing to review them and give timely feedback. I was advised to go ahe

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Matt Turner
On Mon, Mar 16, 2015 at 4:54 AM, Tapani Pälli wrote: > Is there some particular Piglit test case that hits this path and is it > possible with gen>5 (by removing gen check)? I've tried this with > handicrafted shader_test and also shader-db and cannot hit the conditions > for changes to happen. Wo

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Matt Turner
On Wed, Mar 11, 2015 at 1:44 PM, Ian Romanick wrote: > From: Ian Romanick > > On platforms that do not natively generate 0u and ~0u for Boolean > results, b2f expressions that look like > >f = b2f(expr cmp 0) > > will generate better code by pretending the expression is > > f = ir_triop_s

Re: [Mesa-dev] [PATCH 06/23] mesa: glGetProgramResourceLocation

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Patch adds required helper functions to shaderapi.h and > the actual implementation. > > corresponding Piglit test: >arb_program_interface_query-resource-location > > The added functionality can be tested by tests for following > functions

Re: [Mesa-dev] [PATCH 05/23] mesa: glGetProgramResourceName

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Patch adds required helper functions to shaderapi.h and > the actual implementation. > > Name generation copied from '_mesa_get_uniform_name' which can > be removed later by refactoring functions to use resource list. > > The added functionali

Re: [Mesa-dev] [PATCH 1/3] auxiliary/os: fix the android build - s/drm_munmap/os_munmap/

2015-03-16 Thread Brian Paul
On 03/16/2015 09:00 AM, Emil Velikov wrote: Squash this silly typo introduced with commit c63eb5dd5ec(auxiliary/os: get the mmap/munmap wrappers working with android) Cc: "10.4 10.5" Signed-off-by: Emil Velikov --- src/gallium/auxiliary/os/os_mman.h | 4 ++-- 1 file changed, 2 insertions(+)

Re: [Mesa-dev] [PATCH 2/3] st/dri: remove unused include from the automake/scons build

2015-03-16 Thread Brian Paul
On 03/16/2015 09:00 AM, Emil Velikov wrote: st/dri/common hasn't been around for a while. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/Makefile.am | 1 - src/gallium/state_trackers/dri/SConscript | 1 - 2 files changed, 2 deletions(-) diff --git a/src/gallium/state_track

[Mesa-dev] [PATCH] i965: Mark paths in linear <-> tiled functions as unreachable().

2015-03-16 Thread Matt Turner
textdata bss dec hex filename 9663 0 0966325bf intel_tiled_memcpy.o before 8215 0 082152017 intel_tiled_memcpy.o after --- src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 16 1 file changed, 16 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Ian Romanick
On 03/16/2015 09:37 AM, Matt Turner wrote: > On Mon, Mar 16, 2015 at 4:54 AM, Tapani Pälli wrote: >> Is there some particular Piglit test case that hits this path and is it >> possible with gen>5 (by removing gen check)? I've tried this with >> handicrafted shader_test and also shader-db and canno

Re: [Mesa-dev] [PATCH 07/23] mesa: glGetProgramResourceLocationIndex

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Patch adds required helper functions to shaderapi.h and > the actual implementation. > > The added functionality can be tested by tests for following > functions that are refactored by later patches: > >GetFragDataIndex > > Signed-off-by:

Re: [Mesa-dev] [PATCH] i965: Mark paths in linear <-> tiled functions as unreachable().

2015-03-16 Thread Carl Worth
On Mon, Mar 16 2015, Matt Turner wrote: > textdata bss dec hex filename > 9663 0 0966325bf intel_tiled_memcpy.o before > 8215 0 082152017 intel_tiled_memcpy.o after Reviewed-by: Carl Worth -Carl pgp1BOJRVmNZE.pgp Description: PGP sig

Re: [Mesa-dev] [PATCH 08/23] mesa: implementation of glGetProgramResourceiv

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Patch adds required helper functions to shaderapi.h and > the actual implementation. > > The property query functionality can be tested with tests for > following functions that are refactored by later patches: > >GetActiveAtomicCounterBuf

Re: [Mesa-dev] [PATCH] i965/skl: Fix the maximum thread count format for the PS

2015-03-16 Thread Kenneth Graunke
On Friday, February 27, 2015 07:20:37 PM Neil Roberts wrote: > According to the bspec for some reason the format of the maximum > number of threads field has changed from U8-2 to U8-1 for the PS. > > I've run this through Piglit and it doesn't cause any regressions. > --- > src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH] i965: Set nr_params to the number of uniform components in the VS/GS path.

2015-03-16 Thread Kenneth Graunke
On Thursday, January 22, 2015 06:32:21 PM Francisco Jerez wrote: > Both do_vs_prog and do_gs_prog initialize brw_stage_prog_data::nr_params to > the number of uniform *vectors* required by the shader rather than the number > of uniform components, contradicting the comment. This is inconsistent wi

Re: [Mesa-dev] [PATCH] i965: Set nr_params to the number of uniform components in the VS/GS path.

2015-03-16 Thread Francisco Jerez
Kenneth Graunke writes: > On Thursday, January 22, 2015 06:32:21 PM Francisco Jerez wrote: >> Both do_vs_prog and do_gs_prog initialize brw_stage_prog_data::nr_params to >> the number of uniform *vectors* required by the shader rather than the number >> of uniform components, contradicting the co

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Ian Romanick
On 03/16/2015 10:06 AM, Matt Turner wrote: > On Wed, Mar 11, 2015 at 1:44 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> On platforms that do not natively generate 0u and ~0u for Boolean >> results, b2f expressions that look like >> >>f = b2f(expr cmp 0) >> >> will generate better code b

Re: [Mesa-dev] [PATCH 13/23] main: Minor whitespace fixes in ClearNamedBuffer[Sub]Data.

2015-03-16 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mesa/main/bufferobj.c | 4 ++-- > src/mesa/main/bufferobj.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/buffer

Re: [Mesa-dev] [PATCH 14/23] main: Refactor MapBuffer[Range].

2015-03-16 Thread Fredrik Höglund
Aside from some nitpicks below, this patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > v2: review from Jason Ekstrand >- Split refactor from addition of DSA entry points. > review from Ian Romanick >- Remove "_mesa" from static software fall

Re: [Mesa-dev] [PATCH 15/23] main: Add entry points for MapNamedBuffer[Range].

2015-03-16 Thread Fredrik Höglund
On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 14 + > src/mesa/main/bufferobj.c | 42 > ++ > src/mesa/main/bufferobj.h | 14 +++-- > src/mesa/main/tests/dis

Re: [Mesa-dev] [PATCH 16/23] main: Add entry point for UnmapNamedBuffer.

2015-03-16 Thread Fredrik Höglund
On Thursday 12 February 2015, Laura Ekstrand wrote: > v2: review from Ian Romanick >- Restore VBO_DEBUG and BOUNDS_CHECK >- Remove _mesa from static software fallback unmap_buffer. > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 5 +++ > src/mesa/main/bufferobj.c

Re: [Mesa-dev] [PATCH 18/23] main: Add entry point for FlushMappedNamedBufferRange.

2015-03-16 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ > src/mesa/main/bufferobj.c | 16 > src/mesa/main/bufferobj.h | 4

Re: [Mesa-dev] [PATCH 19/23] main: Refactor GetBufferParameteri[64]v.

2015-03-16 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > v2: Split into a refactor commit and an entry point commit. > --- > src/mesa/main/bufferobj.c | 119 > ++ > 1 file changed, 45 insertions(+), 74 deletio

Re: [Mesa-dev] [PATCH 17/23] main: Refactor FlushMappedBufferRange.

2015-03-16 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > v2:-Remove "_mesa" from in front of static software fallback. >-Split out the refactor from the addition of the DSA entry points. > --- > src/mesa/main/bufferobj.c | 60 > +

Re: [Mesa-dev] [PATCH 1/3] auxiliary/os: fix the android build - s/drm_munmap/os_munmap/

2015-03-16 Thread Emil Velikov
On 16/03/15 17:19, Brian Paul wrote: > On 03/16/2015 09:00 AM, Emil Velikov wrote: >> Squash this silly typo introduced with commit >> c63eb5dd5ec(auxiliary/os: get >> the mmap/munmap wrappers working with android) >> >> Cc: "10.4 10.5" >> Signed-off-by: Emil Velikov >> --- >> src/gallium/auxil

Re: [Mesa-dev] [PATCH 20/23] main: Add entry points for GetBufferParameteri[64]v.

2015-03-16 Thread Fredrik Höglund
The commit message should say NamedBufferParameter. With that fixed, this patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 12 > src/mesa/main/bufferobj.c | 39 > ++

Re: [Mesa-dev] [PATCH 22/23] main: Add entry point for glGetNamedBufferSubData.

2015-03-16 Thread Fredrik Höglund
Having a gl prefix in the commit message is inconsistent with the other patches in this series. Aside from that, and a comment below, this patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7

Re: [Mesa-dev] [PATCH 21/23] main: Add entry point for GetNamedBufferPointerv.

2015-03-16 Thread Fredrik Höglund
On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ > src/mesa/main/bufferobj.c | 27 > +++--- > src/mesa/main/bufferobj.h | 4 > src/mesa/main/tests/dispatch_sa

Re: [Mesa-dev] [PATCH 23/23] main: Cosmetic changes to GetBufferSubData.

2015-03-16 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mesa/main/bufferobj.c | 2 +- > src/mesa/main/bufferobj.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferob

Re: [Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-16 Thread Emil Velikov
On 06/03/15 18:26, Brian Paul wrote: > On Fri, Mar 6, 2015 at 9:32 AM, Emil Velikov > wrote: > > Used for aligned_alloc and other C11 functions missing from the header. > > Signed-off-by: Emil Velikov > > --- >

Re: [Mesa-dev] [PATCH] gallium/util: Define ffsll on OpenBSD.

2015-03-16 Thread Emil Velikov
On 26/02/15 13:49, Jose Fonseca wrote: > On 26/02/15 13:42, Jose Fonseca wrote: >> On 26/02/15 03:55, Jonathan Gray wrote: >>> On Wed, Feb 25, 2015 at 07:09:26PM -0800, Matt Turner wrote: On Wed, Feb 25, 2015 at 7:03 PM, Jonathan Gray wrote: > On Wed, Feb 25, 2015 at 06:53:14PM -0800, Mat

Re: [Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

2015-03-16 Thread Matt Turner
On Sun, Mar 15, 2015 at 12:05 PM, Erik Faye-Lund wrote: > _mesa_strtod and _mesa_strtof are only used from the GLSL compiler, > so the locale doesn't need to be initialized before the first context > gets initialized. So let's use explicit initialization from the > one-time init code instead of de

Re: [Mesa-dev] [PATCH 08/18] i965/cs: Mark g0 as used by CS_OPCODE_CS_TERMINATE

2015-03-16 Thread Kenneth Graunke
On Saturday, March 14, 2015 09:54:18 PM Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp > b/src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH] i965: Mark paths in linear <-> tiled functions as unreachable().

2015-03-16 Thread Jason Ekstrand
LGTM On Mon, Mar 16, 2015 at 10:25 AM, Matt Turner wrote: > textdata bss dec hex filename > 9663 0 0966325bf intel_tiled_memcpy.o before > 8215 0 082152017 intel_tiled_memcpy.o after > --- > src/mesa/drivers/dri/i965/intel_tiled_memcpy.

Re: [Mesa-dev] [PATCH 14/18] i965/fs: Don't assign high regs for CS termination send

2015-03-16 Thread Kenneth Graunke
On Saturday, March 14, 2015 09:54:24 PM Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp > b/src/mesa/drivers/d

Re: [Mesa-dev] [PATCH] glx: Handle out-of-sequence swap completion events correctly. (v2)

2015-03-16 Thread Emil Velikov
On 12/03/15 19:34, Mario Kleiner wrote: > The code for emitting INTEL_swap_events swap completion > events needs to translate from 32-Bit sbc on the wire to > 64-Bit sbc for the events and handle wraparound accordingly. > > It assumed that events would be sent by the server in the > order their co

[Mesa-dev] [Bug 89530] FTBFS in loader: missing fstat

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89530 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 88534] include/c11/threads_posix.h PTHREAD_MUTEX_RECURSIVE_NP not defined

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88534 Emil Velikov changed: What|Removed |Added Resolution|MOVED |FIXED --- Comment #2 from Emil Velikov -

Re: [Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

2015-03-16 Thread Emil Velikov
On 15/03/15 19:05, Erik Faye-Lund wrote: > _mesa_strtod and _mesa_strtof are only used from the GLSL compiler, > so the locale doesn't need to be initialized before the first context > gets initialized. So let's use explicit initialization from the > one-time init code instead of depending on a C++

Re: [Mesa-dev] [PATCH] i965/skl: Send a message header when doing constant loads SIMD4x2

2015-03-16 Thread Anuj Phogat
This patch fixes the misrendering in etqw-demo. https://bugs.freedesktop.org/show_bug.cgi?id=89039 Tested-by: Anuj Phogat On Fri, Mar 13, 2015 at 9:29 AM, Neil Roberts wrote: > Commit 0ac4c272755c7 made it add a header for the send message when > using SIMD4x2 on Skylake because without this it

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-16 Thread Kenneth Graunke
On Monday, March 16, 2015 07:54:45 AM Tapani Pälli wrote: > My first attempt to fix the bug 89569 was to add check in combine > constants but for some reason I did not get it to work. One reason is > that inst->sources cannot be trusted I certainly hope we can trust it. If it's wrong, we need t

Re: [Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

2015-03-16 Thread Erik Faye-Lund
On Mon, Mar 16, 2015 at 10:13 PM, Emil Velikov wrote: > On 15/03/15 19:05, Erik Faye-Lund wrote: >> _mesa_strtod and _mesa_strtof are only used from the GLSL compiler, >> so the locale doesn't need to be initialized before the first context >> gets initialized. So let's use explicit initialization

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-16 Thread Matt Turner
On Mon, Mar 16, 2015 at 2:44 PM, Kenneth Graunke wrote: > On Monday, March 16, 2015 07:54:45 AM Tapani Pälli wrote: >> My first attempt to fix the bug 89569 was to add check in combine >> constants but for some reason I did not get it to work. One reason is >> that inst->sources cannot be trusted

Re: [Mesa-dev] [PATCH 09/23] mesa: enable GL_ARB_program_interface_query extension

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > (and mark it as DONE in docs/GL3.txt) And add to relnotes? > > Signed-off-by: Tapani Pälli > --- > docs/GL3.txt | 4 ++-- > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 1 + > 3 files changed, 4 insertions

[Mesa-dev] [Bug 89599] symbol 'x86_64_entry_start' is already defined

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89599 Bug ID: 89599 Summary: symbol 'x86_64_entry_start' is already defined Product: Mesa Version: 10.5 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Sev

Re: [Mesa-dev] [PATCH 10/23] mesa: refactor GetActiveAttrib

2015-03-16 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin One minor note -- not sure if it makes sense to call the _mesa_program_resource_prop helpers, but it is nicely generic. However you already have the ir_variable *var, so might as well use it? Your call. On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Instead of i

[Mesa-dev] [PATCH 1/2] docs/GL3: don't list r300

2015-03-16 Thread Marek Olšák
From: Marek Olšák r300g already supports everything it can. There's no point in listing the driver here. --- docs/GL3.txt | 56 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 5d59341..1ca4

[Mesa-dev] [PATCH 2/2] docs/GL3: don't list swrast

2015-03-16 Thread Marek Olšák
From: Marek Olšák Let's face it: This driver is unlikely to get more love. --- docs/GL3.txt | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 1ca4502..bd17743 100644 --- a/docs/GL3.txt +++ b/docs/GL3

Re: [Mesa-dev] [PATCH 11/23] mesa: refactor GetAttribLocation

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Use program_resource_location to fetch location. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/shader_query.cpp | 33 ++--- > 1 file changed, 10 insertions(+), 23 deletions(-) > > diff --git a/src/mesa/mai

Re: [Mesa-dev] [PATCH 12/23] mesa: refactor GetFragDataLocation

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Use program_resource_location to fetch location. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/shader_query.cpp | 28 ++-- > 1 file changed, 6 insertions(+), 22 deletions(-) > > diff --git a/src/mesa/main/shad

  1   2   >