Re: [Mesa-dev] [PATCH 07/43] st/nine: Fix use of D3DSP_NOSWIZZLE

2015-01-31 Thread Henri Verbeet
On 30 January 2015 at 21:34, Axel Davy wrote: > @@ -2778,7 +2778,7 @@ sm1_parse_get_param(struct shader_translator *tx, DWORD > *reg, DWORD *rel) > *rel = (1 << 31) | > ((D3DSPR_ADDR << D3DSP_REGTYPE_SHIFT2) & > D3DSP_REGTYPE_MASK2) | > ((D3DSPR_ADD

Re: [Mesa-dev] [PATCH] i965/pixel_read: Don't try to do a tiled_memcpy from a multisampled buffer

2015-01-31 Thread Kenneth Graunke
On Friday, January 30, 2015 06:56:22 PM Jason Ekstrand wrote: > The GL spec guarantees that glGetTexImage will never get a multisampled > texture, but this is not true for glReadPixels. If we get a multisampled > buffer, we have to do a multisample resolve on it before we can pull the > data down

Re: [Mesa-dev] [PATCH] nir: Add an ALU op builder kind of like ir_builder.h

2015-01-31 Thread Kenneth Graunke
On Friday, January 30, 2015 07:27:50 PM Connor Abbott wrote: > I mentioned this on IRC, but it would be good to add the ability to > append the sequence of instructions before/after an instruction as > well as at the beginning or end of a basic block. We would need to > store the current basic bloc

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 Alberto Salvia Novella changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #19 from Albert

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #20 from Alberto Salvia Novella --- It looks like if the computer has been on for a while, is harder to make it to hang. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. _

[Mesa-dev] [PATCH v2] dir-locals.el: Don't set variables for non-programming modes

2015-01-31 Thread Neil Roberts
This limits the style changes to modes inherited from prog-mode. The main reason to do this is to avoid setting fill-column for people using Emacs to edit commit messages because 78 characters is too many to make it wrap properly in git log. Note that makefile-mode also inherits from prog-mode so t

Re: [Mesa-dev] [PATCH 01/43] st/nine: Explicit nine requirements

2015-01-31 Thread Ilia Mirkin
On Fri, Jan 30, 2015 at 3:34 PM, Axel Davy wrote: > This patch raises nine requirements and disables nine for old > hw that don't match them. > > Currently for these cards only games that don't have tight requirements > would work well with nine. However nine is missing several checks > regarding

Re: [Mesa-dev] [PATCH 02/43] st/nine: Refactor how user constbufs sizes are calculated

2015-01-31 Thread Ilia Mirkin
On Fri, Jan 30, 2015 at 3:34 PM, Axel Davy wrote: > Count explicitly the slots for float, int and bool constants, > and deduce the constbuf size in nine_shader. > > Signed-off-by: Axel Davy > --- > src/gallium/state_trackers/nine/nine_shader.c | 17 ++--- > src/gallium/state_tracke

Re: [Mesa-dev] [PATCH 20/43] st/nine: Implement AMD alpha to coverage

2015-01-31 Thread Ilia Mirkin
On Fri, Jan 30, 2015 at 3:34 PM, Axel Davy wrote: > This D3D hack is supposed to be supported > by all AMD SM2+ cards. Apps use it without > checking if they are on AMD. > > Signed-off-by: Axel Davy > --- > src/gallium/state_trackers/nine/device9.c| 17 +++-- > src/gallium/state_

[Mesa-dev] [PATCH 5/8] mesa: Validate original image internal format rather than derived mesa format.

2015-01-31 Thread Francisco Jerez
This matches what _mesa_BindImageTextures() does. The derived image format (gl_texture_image::TexFormat) isn't necessarily equivalent to the internal format of the texture image. If a forbidden internal format has been specified we need to mark the image unit as invalid as required by the spec, r

[Mesa-dev] [PATCH 6/8] mesa: Implement image uniform queries.

2015-01-31 Thread Francisco Jerez
--- src/mesa/main/uniform_query.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 32870d0..82e5e38 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/src/mesa/main/uniform_query.cpp @@ -362,7 +362,8 @@

[Mesa-dev] [PATCH 1/8] mesa: Export shader image format to mesa format conversion function.

2015-01-31 Thread Francisco Jerez
This function will be useful for back-ends to translate an image internal format as specified in GLSL code into a mesa format. --- src/mesa/main/shaderimage.c | 10 +- src/mesa/main/shaderimage.h | 7 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/sh

[Mesa-dev] [PATCH 4/8] mesa: Call _mesa_test_texobj_completeness() before using _MaxLevel in image validation.

2015-01-31 Thread Francisco Jerez
gl_texture_object::_MaxLevel doesn't have any meaningful value until _mesa_test_texobj_completeness() has been run. Fixes the "level" ARB_shader_image_load_store piglit test. --- src/mesa/main/shaderimage.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/s

[Mesa-dev] [PATCH 3/8] mesa: Add support for binding a buffer texture to a shader image unit.

2015-01-31 Thread Francisco Jerez
--- src/mesa/main/shaderimage.c | 73 ++--- 1 file changed, 42 insertions(+), 31 deletions(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index f812073..005698c 100644 --- a/src/mesa/main/shaderimage.c +++ b/src/mesa/main/shaderim

[Mesa-dev] [PATCH 2/8] mesa: Add extern "C" guards to shaderimage.h to allow inclusion from C++ code.

2015-01-31 Thread Francisco Jerez
--- src/mesa/main/shaderimage.h | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/main/shaderimage.h b/src/mesa/main/shaderimage.h index 4aa859c..1c7d1e0 100644 --- a/src/mesa/main/shaderimage.h +++ b/src/mesa/main/shaderimage.h @@ -30,6 +30,10 @@ #include "glheader.h" #includ

[Mesa-dev] [PATCH 7/8] mesa: Initialize image units to default state on context creation.

2015-01-31 Thread Francisco Jerez
This is the required initial image unit state according to "Table 23.45. Image State (state per image unit)" of the OpenGL 4.3 specification. --- src/mesa/main/context.c | 2 ++ src/mesa/main/shaderimage.c | 13 + src/mesa/main/shaderimage.h | 6 ++ 3 files changed, 21 insert

[Mesa-dev] [PATCH 8/8] mesa: Update image unit state when glBindImageTexture is called with texture=0.

2015-01-31 Thread Francisco Jerez
There's no indication in the spec that the image unit state other than the bound texture object shouldn't be updated when glBindImageTexture() is called passing the zero texture as argument. It's very unlikely that any application would ever have relied on this, but it's easy to get right, and it

[Mesa-dev] [Bug 88534] include/c11/threads_posix.h PTHREAD_MUTEX_RECURSIVE_NP not defined

2015-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88534 --- Comment #1 from felix.ja...@posteo.de --- Patch now sent instead to mesa-dev. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.free

[Mesa-dev] [Bug 88534] include/c11/threads_posix.h PTHREAD_MUTEX_RECURSIVE_NP not defined

2015-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88534 felix.ja...@posteo.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 4/4] i965: Allow Y-tiled allocations for large surfaces

2015-01-31 Thread Jordan Justen
I agree with Jason's comments on 3 & 4. I think I asked something similar previously regarding patch 3. (Ie, why not just do the adjustments all the time?) With Jason's comments fixed, series Reviewed-by: Jordan Justen On 2015-01-14 10:34:52, Jason Ekstrand wrote: > > > On Tue, Jan 13, 2015 at

Re: [Mesa-dev] [PATCH 03/43] st/nine: Declare constants only up to the maximum needed.

2015-01-31 Thread Ilia Mirkin
On Fri, Jan 30, 2015 at 3:34 PM, Axel Davy wrote: > Previously 276 constants were declared everytime. > > This patch makes shaders declare constants up to the maximum > constant needed and moves the moment we print the TGSI > shader after the moment we declare the constants. > > This is needed for

[Mesa-dev] [PATCH 4/7] glsl: Split off memory qualifiers from storage qualifiers.

2015-01-31 Thread Francisco Jerez
Image memory qualifiers (coherent, volatile, restrict, readonly and writeonly) follow slightly different rules from storage qualifiers, e.g. the uniqueness rule doesn't apply. Make them a separate non-terminal. --- src/glsl/glsl_parser.yy | 17 - 1 file changed, 16 insertions(+),

[Mesa-dev] [PATCH 3/7] glsl: Forbid opaque variables as operands of the ternary operator.

2015-01-31 Thread Francisco Jerez
--- src/glsl/ast_to_hir.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 1ba29f7..783384e 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -1596,6 +1596,18 @@ ast_expression::do_hir(exec_list *instruc

[Mesa-dev] [PATCH 7/7] glsl: Keep track of the early_fragment_tests flag in gl_shader.

2015-01-31 Thread Francisco Jerez
And rename _mesa_glsl_parse_state::early_fragment_tests to fs_early_fragment_tests for consistency with other FS-specific flags in the same struct. --- src/glsl/ast_type.cpp | 2 +- src/glsl/glsl_parser_extras.cpp | 4 +++- src/glsl/glsl_parser_extras.h | 2 +- src/glsl/linker.cpp

[Mesa-dev] [PATCH 5/7] glsl: Forbid use of image qualifiers in declarations of type other than image.

2015-01-31 Thread Francisco Jerez
--- src/glsl/ast_to_hir.cpp | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 783384e..1cfba39 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -2399,6 +2399,14 @@ apply_image_qualifier_to_va

[Mesa-dev] [PATCH 2/7] glsl: Forbid calling the constructor of any opaque type.

2015-01-31 Thread Francisco Jerez
The spec doesn't define any opaque type constructors. --- src/glsl/ast_function.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index cbff9d8..151b082 100644 --- a/src/glsl/ast_function.cpp +++ b/src/glsl/ast_funct

[Mesa-dev] [PATCH 6/7] glsl: Error out on invalid uses of the early_fragment_tests layout qualifier.

2015-01-31 Thread Francisco Jerez
--- src/glsl/ast_to_hir.cpp | 14 ++ src/glsl/ast_type.cpp | 10 +- src/glsl/glsl_parser.yy | 15 +++ 3 files changed, 34 insertions(+), 5 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 1cfba39..6db9365 100644 --- a/src/glsl/ast

[Mesa-dev] [PATCH 1/7] glsl: Return correct number of coordinate components for cubemap array images.

2015-01-31 Thread Francisco Jerez
Cubemap array images are unlike cubemap array samplers in that they don't need an additional coordinate to index individual cubemaps in the array, instead they behave like a 2D array of 6n layers, with n the number of cubemaps in the array. Take this exception into account. --- src/glsl/glsl_type

[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

2015-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #6 from nerdopol...@verizon.net --- Any updates on this one? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.o

Re: [Mesa-dev] [PATCH] GL: Update glext.h to fix ARB_dsa function prototypes.

2015-01-31 Thread Ian Romanick
On 01/31/2015 04:58 AM, Chris Forbes wrote: > With the new commit message, > > Reviewed-by: Chris Forbes Me too. Reviewed-by: Ian Romanick > On Sat, Jan 31, 2015 at 2:08 PM, Laura Ekstrand wrote: >> It's updated to: >> >> GL: Update glext.h to Khronos Revision 29537. >> >> Khronos Re

Re: [Mesa-dev] [PATCH 06/21] main: Add entry point for NamedBufferData.

2015-01-31 Thread Ian Romanick
On 02/01/2015 08:25 AM, Ian Romanick wrote: > Did you intend to reply off-list? All discussions about code changes > should be on the public list. Never mind. I just saw the extra fwd... > On 01/31/2015 12:42 AM, Laura Ekstrand wrote: >> >> >> On Wed, Jan 21, 2015 at 6:28 PM, Ian Romanick >

Re: [Mesa-dev] [PATCH 08/21] main: Add entry point for NamedBufferSubData.

2015-01-31 Thread Ian Romanick
On 01/31/2015 02:21 AM, Laura Ekstrand wrote: > > > On Wed, Jan 21, 2015 at 6:42 PM, Ian Romanick > wrote: > > On 01/21/2015 05:40 PM, Laura Ekstrand wrote: > > --- > > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 ++ > > src/mesa/main/buffe