On Thu, 2014-11-20 at 11:10 -0800, Jason Ekstrand wrote:
>
>
> On Thu, Nov 20, 2014 at 1:48 AM, Iago Toral wrote:
> On Wed, 2014-11-19 at 11:28 -0800, Jason Ekstrand wrote:
> > By and large, this looks good to me. Most of my comments
> are cosmetic
> > or suggest
On 21.11.2014 17:07, Iago Toral wrote:
On Thu, 2014-11-20 at 11:10 -0800, Jason Ekstrand wrote:
On Thu, Nov 20, 2014 at 1:48 AM, Iago Toral wrote:
Just out of curiosity: is there any gain in avoiding the GL
types in the
conversion code?
As I said in my reply to Jose
On Fri, 2014-11-21 at 17:40 +0900, Michel Dänzer wrote:
> On 21.11.2014 17:07, Iago Toral wrote:
> > On Thu, 2014-11-20 at 11:10 -0800, Jason Ekstrand wrote:
> >> On Thu, Nov 20, 2014 at 1:48 AM, Iago Toral wrote:
> >> Just out of curiosity: is there any gain in avoiding the GL
> >>
In commit 5e37a2a4a8a, I made the pull constant code stop calling
_mesa_load_state_parameters() when there were no pull parameters.
This worked fine on Gen6+ because the push constant code also called
it if there were any push constants. However, the Gen4-5 push constant
code wasn't doing this.
On 11/10/2014 04:28 AM, Emil Velikov wrote:
I'm not sure did you just said that you've checked it, or that's what
it ought to do ? There is a reason why I'm so picky - this bizarre (as
one might call it) setup is just the tip of the iceberg when it comes
to people building mesa themselves. Wou
On Thu, 2014-11-20 at 18:46 +0200, Eero Tamminen wrote:
> Hi,
>
> > Honestly, I think I'm okay with our usual metrics like:
> > - Increased FPS in a game or benchmark
> > - Reduced number of instructions or memory accesses in
> a shader program
> > - Reduced memory consumption
> > - Sign
https://bugs.freedesktop.org/show_bug.cgi?id=82585
Kenneth Graunke changed:
What|Removed |Added
Component|Mesa core |glsl-compiler
Assignee|mesa-
https://bugs.freedesktop.org/show_bug.cgi?id=82585
--- Comment #8 from Kenneth Graunke ---
This is a separate shader objects bug, and is probably related to 79783. If
you modify the demo application to not use SSO, it works fine.
--
You are receiving this mail because:
You are the assignee for
On Thu, 2014-11-20 at 21:35 -0800, Jason Ekstrand wrote:
>
>
> On Thu, Nov 20, 2014 at 9:33 PM, Jason Ekstrand
> wrote:
>
>
> On Thu, Nov 20, 2014 at 12:29 AM, Iago Toral
> wrote:
> It is explained here:
> https://bugs.freedeskto
On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote:
> On 18.11.2014 17:43, Iago Toral Quiroga wrote:
> >
> > For software drivers we worked with a trimmed set of piglit tests (related
> > to
> > format conversion), ~5700 tests selected with the following filter:
> >
> > -t format -t color -t t
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, Nov 11, 2014 at 9:41 AM, Matt Turner wrote:
> The rest of our backend optimizations have replaced the need for this
> since it was written.
>
> instructions in affected programs: 30626 -> 30564 (-0.20%)
>
> Hurts a small number of CSGO shaders by one instruction, but helps even
> more.
Dead since commit 3d16088f.
---
src/mapi/glapi/gen/Makefile.am | 2 -
src/mapi/glapi/gen/extension_helper.py | 324 -
2 files changed, 326 deletions(-)
delete mode 100644 src/mapi/glapi/gen/extension_helper.py
diff --git a/src/mapi/glapi/gen/Makefile.am
Dead since commit 4e120c97, in which apiparser (which mesadef.py imports)
was removed.
---
src/mapi/glapi/gen/Makefile.am | 1 -
src/mapi/glapi/gen/mesadef.py | 215 -
2 files changed, 216 deletions(-)
delete mode 100644 src/mapi/glapi/gen/mesadef.py
di
Dead since commit 07b85457.
---
src/mapi/glapi/gen/gl_offsets.py | 120 ---
1 file changed, 120 deletions(-)
delete mode 100644 src/mapi/glapi/gen/gl_offsets.py
diff --git a/src/mapi/glapi/gen/gl_offsets.py b/src/mapi/glapi/gen/gl_offsets.py
deleted file mode
On Fri, Nov 21, 2014 at 1:35 PM, Matt Turner wrote:
> Dead since commit 3d16088f.
> ---
> src/mapi/glapi/gen/Makefile.am | 2 -
> src/mapi/glapi/gen/extension_helper.py | 324
> -
> 2 files changed, 326 deletions(-)
> delete mode 100644 src/mapi/glapi/g
What about src/mesa/drivers/windows/gdi/mesa.def -- it claims to be
generated by mesadef.py. I have no idea what it is, but it should
either also be deleted, or the mesadef.py script kept around.
On Fri, Nov 21, 2014 at 1:35 PM, Matt Turner wrote:
> Dead since commit 4e120c97, in which apiparser
On Fri, Nov 21, 2014 at 10:40 AM, Ilia Mirkin wrote:
> On Fri, Nov 21, 2014 at 1:35 PM, Matt Turner wrote:
>> Dead since commit 3d16088f.
>> ---
>> src/mapi/glapi/gen/Makefile.am | 2 -
>> src/mapi/glapi/gen/extension_helper.py | 324
>> -
>> 2 files ch
On Fri, Nov 21, 2014 at 10:42 AM, Ilia Mirkin wrote:
> What about src/mesa/drivers/windows/gdi/mesa.def -- it claims to be
> generated by mesadef.py. I have no idea what it is, but it should
> either also be deleted, or the mesadef.py script kept around.
Good point. Maybe Brian knows (Cc'd).
These were added in commits a760c738 and 43757135 to be used in
implementing C-style aggregate initializers (commit 1b0d6aef). Paul
rewrote that code in commit 0da1a2cc to use GLSL types, rather than
AST types, leaving these copy constructors unused.
Tested by making them private and providing no
Move this to a separate function so that we can begin to add other little
caveats without making too big a mess.
NOTE: There is some desire to improve this function eventually, but we need to
fix a bug first.
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_vec4.cpp | 42 ++
Fix one of the few cases where we can't reliable touch the destination hazard
bits. I am explicitly doing this patch individually so it is easy to backport. I
was tempted to do this patch before the previous patch which reorganized the
code, but I believe even doing that first, this is still easy t
On Fri, Nov 21, 2014 at 10:50:31AM -0800, Ben Widawsky wrote:
> Fix one of the few cases where we can't reliable touch the destination hazard
> bits. I am explicitly doing this patch individually so it is easy to
> backport. I
> was tempted to do this patch before the previous patch which reorgani
On Fri, Nov 21, 2014 at 1:47 PM, Matt Turner wrote:
> These were added in commits a760c738 and 43757135 to be used in
> implementing C-style aggregate initializers (commit 1b0d6aef). Paul
> rewrote that code in commit 0da1a2cc to use GLSL types, rather than
> AST types, leaving these copy construc
On Thu, Nov 20, 2014 at 11:33 PM, Iago Toral wrote:
> On Thu, 2014-11-20 at 10:40 -0800, Jason Ekstrand wrote:
> >
> >
> > On Wed, Nov 19, 2014 at 11:24 PM, Iago Toral
> > wrote:
> > Hi Jason,
> >
> > we discussed this some weeks ago actually, the detailed
> > explanation
On Fri, Nov 21, 2014 at 10:52 AM, Ilia Mirkin wrote:
> On Fri, Nov 21, 2014 at 1:47 PM, Matt Turner wrote:
>> These were added in commits a760c738 and 43757135 to be used in
>> implementing C-style aggregate initializers (commit 1b0d6aef). Paul
>> rewrote that code in commit 0da1a2cc to use GLSL
On Fri, Nov 21, 2014 at 1:56 PM, Matt Turner wrote:
> On Fri, Nov 21, 2014 at 10:52 AM, Ilia Mirkin wrote:
>> On Fri, Nov 21, 2014 at 1:47 PM, Matt Turner wrote:
>>> These were added in commits a760c738 and 43757135 to be used in
>>> implementing C-style aggregate initializers (commit 1b0d6aef).
On Fri, Nov 21, 2014 at 10:50 AM, Ben Widawsky
wrote:
> Move this to a separate function so that we can begin to add other little
> caveats without making too big a mess.
>
> NOTE: There is some desire to improve this function eventually, but we need to
> fix a bug first.
>
> Signed-off-by: Ben Wi
On Fri, Nov 21, 2014 at 10:50 AM, Ben Widawsky
wrote:
> Fix one of the few cases where we can't reliable touch the destination hazard
> bits. I am explicitly doing this patch individually so it is easy to
> backport. I
> was tempted to do this patch before the previous patch which reorganized the
On Fri, Nov 21, 2014 at 11:04:18AM -0800, Matt Turner wrote:
> On Fri, Nov 21, 2014 at 10:50 AM, Ben Widawsky
> wrote:
> > Move this to a separate function so that we can begin to add other little
> > caveats without making too big a mess.
> >
> > NOTE: There is some desire to improve this functio
On Fri, Nov 21, 2014 at 11:09:44AM -0800, Matt Turner wrote:
> On Fri, Nov 21, 2014 at 10:50 AM, Ben Widawsky
> wrote:
> > Fix one of the few cases where we can't reliable touch the destination
> > hazard
> > bits. I am explicitly doing this patch individually so it is easy to
> > backport. I
>
On Fri, Nov 21, 2014 at 11:18 AM, Ben Widawsky wrote:
> On Fri, Nov 21, 2014 at 11:04:18AM -0800, Matt Turner wrote:
>> On Fri, Nov 21, 2014 at 10:50 AM, Ben Widawsky
>> wrote:
>> > +*/ + return !(inst->mlen || inst->predicate || inst->is_math());
>>
>> The return value is a ! expression, a
On 21/11/14 18:46, Matt Turner wrote:
On Fri, Nov 21, 2014 at 10:42 AM, Ilia Mirkin wrote:
What about src/mesa/drivers/windows/gdi/mesa.def -- it claims to be
generated by mesadef.py. I have no idea what it is, but it should
either also be deleted, or the mesadef.py script kept around.
Good p
In my tests, this fixes piglit on gen4/5.
-Mark
Kenneth Graunke writes:
> In commit 5e37a2a4a8a, I made the pull constant code stop calling
> _mesa_load_state_parameters() when there were no pull parameters.
>
> This worked fine on Gen6+ because the push constant code also called
> it if there
---
Strangely, the suggested implementations of double-precision sqrt/rcp
in the BSpec show using a math instruction with an "eo" conditional
modifier. I have no idea what that could possibly mean, or how it could
work since conditional mod shares the same four bits with math SFID.
src/mesa/drive
Ben was asking about the undocumented restriction that the math
instruction cannot use the dependency control hints. I went to reconfirm
and disabled the is_math() check in opt_set_dependency_control() and saw
that the disassembled math instructions with dependency hints had a
bogus SFID. We were m
With bblock_t::end_ip, we can skip entire blocks rather than checking
every instruction in them. Also by making the loops nested (explicitly,
it already was a nested loop), the continue seen at the end of the first
hunk (when viewed with git show -w) will do what the programmer expects.
No functio
We now skip allocating a hiz miptree for gen8. Instead, we calculate
the required hiz buffer parameters and allocate a bo directly.
v2:
* Update hz_height calculation as suggested by Topi
v3:
* Bail if we failed to create the bo (Ben)
Signed-off-by: Jordan Justen
Reviewed-by: Topi Pohjolainen
Today we allocate a miptree's for the hiz buffer. We needed this in
the past because we would point the hardware at offsets of the hiz
buffer. Since the hiz format is not documented, this is not a good
idea.
Since moving to support layered rendering on Gen7+, we no longer point
at an offset into t
We now skip allocating a hiz miptree for gen7. Instead, we calculate
the required hiz buffer parameters and allocate a bo directly.
v2:
* Update hz_height calculation as suggested by Topi
v3:
* Bail if we failed to create the bo (Ben)
Signed-off-by: Jordan Justen
Reviewed-by: Topi Pohjolainen
We are still allocating a miptree for hiz, but we only use fields from
intel_miptree_aux_buffer. This will allow us to switch over to not
allocating a miptree.
Signed-off-by: Jordan Justen
Reviewed-by: Topi Pohjolainen
Reviewed-by: Kenneth Graunke
Reviewed-by: Ben Widawsky
---
src/mesa/driver
We are still allocating a miptree for hiz, but we only use fields from
intel_miptree_aux_buffer. This will allow us to switch over to not
allocating a miptree.
Signed-off-by: Jordan Justen
Reviewed-by: Topi Pohjolainen
Reviewed-by: Kenneth Graunke
Reviewed-by: Ben Widawsky
---
src/mesa/driver
---
src/util/macros.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/util/macros.h b/src/util/macros.h
index da5daff..b67596d 100644
--- a/src/util/macros.h
+++ b/src/util/macros.h
@@ -29,6 +29,10 @@
# define ARRAY_SIZE(x) (sizeof(x) / sizeof(*(x)))
#endif
Cuts a little more than 1k of .text size from i915g.
This was previously done in commit 5f66b340 and subsequently reverted in
commit 3661f757 after bug 30514 was filed. I believe the cause of bug
30514 wasn't anything related to cross compiling, but rather that the
toolchain used defaulted to -mar
Caught by clang.
warning: comparison of constant -1 with expression of type
'ir_texture_opcode' is always false
[-Wtautological-constant-out-of-range-compare]
if (op == -1)
~~ ^ ~~
---
src/glsl/ir_reader.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
note: hidden overloaded virtual function 'ir_hierarchical_visitor::visit_enter'
declared here: type mismatch at 1st parameter
('class ir_loop *' vs 'ir_dereference_variable *')
virtual ir_visitor_status visit_enter(class ir_loop *);
I don't see much value in this warning, but it spi
---
src/mesa/drivers/dri/i965/gen6_gs_visitor.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/gen6_gs_visitor.cpp
b/src/mesa/drivers/dri/i965/gen6_gs_visitor.cpp
index d16cc6e..564b4cb 100644
--- a/src/mesa/drivers/dri/i965/gen6_gs_visitor.cpp
+++
---
src/mesa/drivers/dri/i965/brw_disasm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c
b/src/mesa/drivers/dri/i965/brw_disasm.c
index b211a0f..e235fd4 100644
--- a/src/mesa/drivers/dri/i965/brw_disasm.c
+++ b/src/mesa/drivers/dri/i965
On Fri, Nov 21, 2014 at 6:18 PM, Matt Turner wrote:
> Cuts a little more than 1k of .text size from i915g.
>
> This was previously done in commit 5f66b340 and subsequently reverted in
> commit 3661f757 after bug 30514 was filed. I believe the cause of bug
> 30514 wasn't anything related to cross c
On Fri, Nov 21, 2014 at 3:19 PM, Matt Turner wrote:
> note: hidden overloaded virtual function
> 'ir_hierarchical_visitor::visit_enter'
> declared here: type mismatch at 1st parameter
> ('class ir_loop *' vs 'ir_dereference_variable *')
>virtual ir_visitor_status visit_enter(class
On Fri, Nov 21, 2014 at 3:18 PM, Matt Turner wrote:
> Cuts a little more than 1k of .text size from i915g.
>
> This was previously done in commit 5f66b340 and subsequently reverted in
> commit 3661f757 after bug 30514 was filed. I believe the cause of bug
> 30514 wasn't anything related to cross c
Reviewed-by: Chris Forbes
On Sat, Nov 22, 2014 at 12:19 PM, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_disasm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c
> b/src/mesa/drivers/dri/i965/brw_disasm.c
> index b211a
On 2014-11-21 15:17:00, Matt Turner wrote:
> ---
> src/util/macros.h | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/src/util/macros.h b/src/util/macros.h
> index da5daff..b67596d 100644
> --- a/src/util/macros.h
> +++ b/src/util/macros.h
> @@ -29,6 +29,10 @@
On Fri, Nov 21, 2014 at 3:47 PM, Jordan Justen
wrote:
> On 2014-11-21 15:17:00, Matt Turner wrote:
>> ---
>> src/util/macros.h | 12 +++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/util/macros.h b/src/util/macros.h
>> index da5daff..b67596d 100644
>> --- a/s
On Fri, Nov 21, 2014 at 03:09:03PM -0800, Jordan Justen wrote:
> We now skip allocating a hiz miptree for gen8. Instead, we calculate
> the required hiz buffer parameters and allocate a bo directly.
>
> v2:
> * Update hz_height calculation as suggested by Topi
> v3:
> * Bail if we failed to crea
On 2014-11-21 15:53:35, Matt Turner wrote:
> On Fri, Nov 21, 2014 at 3:47 PM, Jordan Justen
> wrote:
> > On 2014-11-21 15:17:00, Matt Turner wrote:
> >> ---
> >> src/util/macros.h | 12 +++-
> >> 1 file changed, 11 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/src/util/macros.h b/sr
On Fri, Nov 21, 2014 at 4:23 PM, Jordan Justen
wrote:
> So ... assert(expr) instead?
Yes. :(
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: David Heidelberg
for the series.
David
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri, Nov 21, 2014 at 3:09 PM, Jordan Justen
wrote:
> We now skip allocating a hiz miptree for gen8. Instead, we calculate
> the required hiz buffer parameters and allocate a bo directly.
>
> v2:
> * Update hz_height calculation as suggested by Topi
> v3:
> * Bail if we failed to create the bo
On Friday, November 21, 2014 03:19:32 PM Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/gen6_gs_visitor.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/gen6_gs_visitor.cpp
> b/src/mesa/drivers/dri/i965/gen6_gs_visitor.cpp
> index d16cc
On Friday, November 21, 2014 03:19:12 PM Matt Turner wrote:
> Caught by clang.
>
> warning: comparison of constant -1 with expression of type
> 'ir_texture_opcode' is always false
> [-Wtautological-constant-out-of-range-compare]
> if (op == -1)
> ~~ ^ ~~
> ---
> sr
On Fri, Nov 21, 2014 at 03:09:02PM -0800, Jordan Justen wrote:
> We now skip allocating a hiz miptree for gen7. Instead, we calculate
> the required hiz buffer parameters and allocate a bo directly.
>
> v2:
> * Update hz_height calculation as suggested by Topi
> v3:
> * Bail if we failed to crea
On 21.11.2014 06:21, Marek Olšák wrote:
From: Marek Olšák
So far it has been compiled into pretty ugly code (8 instructions or so
for either opcode).
---
src/gallium/drivers/radeonsi/si_shader.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_shader
On Fri, Nov 21, 2014 at 3:09 PM, Jordan Justen
wrote:
> We now skip allocating a hiz miptree for gen7. Instead, we calculate
> the required hiz buffer parameters and allocate a bo directly.
>
> v2:
> * Update hz_height calculation as suggested by Topi
> v3:
> * Bail if we failed to create the bo
From: John Ettedgui
This patch fixes black screen with games based on the Unreal Engine 3.
It was tested that it fixed the issue in Tera Online, Borderlands 2 and
Homefront.
Cc: "10.4"
Reviewed-by: Axel Davy
Reviewed-by: David Heidelberg
Signed-off-by: John Ettedgui
---
src/gallium/state_t
From: Axel Davy
D3DPOOL_SCRATCH is disallowed according to spec.
D3DPOOL_SYSTEMMEM should be allowed but we don't handle it right for now.
v2: Fixes segfault in SetTexture when unsetting the texture
Cc: "10.4"
Tested-by: David Heidelberg
Signed-off-by: Axel Davy
---
src/gallium/state_tracke
From: Stanislaw Halik
Cc: "10.4"
Reviewed-by: David Heidelberg
Reviewed-by: Axel Davy
Signed-off-by: Stanislaw Halik
---
src/gallium/state_trackers/nine/basetexture9.c | 17
src/gallium/state_trackers/nine/cubetexture9.c | 17
src/gallium/state_trackers/nine/device9
From: Axel Davy
Fixes "Error : CONST[20]: Undeclared source register" when running
dx9_alpha_blending_material. Also artifacts on ilo.
Cc: "10.4"
Tested-by: David Heidelberg
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/nine/nine_ff.c | 4 ++--
1 file changed, 2 insertions(+), 2 de
Sorry, for now please without this patch.
This one needs " nine: Refactor Resource9 BaseTexture9 Surface9 and
Texture9 initialization", which isn't part of batch.
Thanks, David.
On 11/22/2014 04:14 AM, David Heidelberg wrote:
From: Stanislaw Halik
Cc: "10.4"
Reviewed-by: David Heidelberg
On Fri, Nov 21, 2014 at 10:13 PM, David Heidelberg wrote:
> From: John Ettedgui
>
> This patch fixes black screen with games based on the Unreal Engine 3.
> It was tested that it fixed the issue in Tera Online, Borderlands 2 and
> Homefront.
What's the actual problem? If there's no begin, then
Mesa 10.3.4 has been released. Mesa 10.3.4 is a bug fix release
fixing bugs since the 10.3.3 release, (see below for a list of
changes).
The tag in the git repository for Mesa 10.3.4 is 'mesa-10.3.4'.
Mesa 10.3.4 is available for download at
ftp://freedesktop.org/pub/mesa/10.3.4/
SHA-256 checksu
Mesa 10.4.0 release candidate 2 is now available for testing. The
current plan is to have an additional release candidate each Friday
until the eventual 10.4.0 release on Friday, Dec 5th.
The tag in the git repository for Mesa 10.4.0-rc2 is 'mesa-10.4.0-rc2'.
Mesa 10.4.0 release candidate 2 is av
The version provided by it should be the same as the one
provided/handled by the module. Add the missing tiny version.
Cc:
Signed-off-by: Emil Velikov
---
configure.ac| 2 ++
src/gallium/targets/d3dadapter9/Makefile.am | 2 +-
src/gallium/targets/d3dadapter9/d3d.
On Sat, Nov 22, 2014 at 12:44 AM, John Ettedgui wrote:
> On Fri Nov 21 2014 at 7:50:03 PM Ilia Mirkin wrote:
>>
>> What's the actual problem?
>
> If you mean in-game, a blocking black screen, the game wants to display
> something but is unable to and keeps trying pretty much forever.
I meant at
On Sat, Nov 22, 2014 at 12:57 AM, Ilia Mirkin wrote:
> On Sat, Nov 22, 2014 at 12:44 AM, John Ettedgui
> wrote:
>> On Fri Nov 21 2014 at 7:50:03 PM Ilia Mirkin wrote:
>>>
>>> What's the actual problem?
>>
>> If you mean in-game, a blocking black screen, the game wants to display
>> something bu
On Sat, Nov 22, 2014 at 1:28 AM, John Ettedgui wrote:
> On Fri Nov 21 2014 at 10:14:19 PM Ilia Mirkin wrote:
>>
>> Oh, I think i see the problem.
>>
>> In GetData:
>>
>> user_assert(This->state != NINE_QUERY_STATE_RUNNING,
>> D3DERR_INVALIDCALL);
>>
>> should be
>>
>> user_assert(This->stat
On Sat, Nov 22, 2014 at 1:45 AM, John Ettedgui wrote:
> On Fri Nov 21 2014 at 10:36:29 PM Ilia Mirkin wrote:
>>
>> Right, I figured as much. My point is that doing what I'm proposing
>> there would allow such usage even though it is illegal based on the
>> API description.
>>
> Alright.
>>
>> It
77 matches
Mail list logo
