On Friday, November 21, 2014 03:19:12 PM Matt Turner wrote:
> Caught by clang.
>
> warning: comparison of constant -1 with expression of type
> 'ir_texture_opcode' is always false
> [-Wtautological-constant-out-of-range-compare]
> if (op == -1)
> ~~ ^ ~~
> ---
> src/glsl/ir_reader.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/glsl/ir_reader.cpp b/src/glsl/ir_reader.cpp
> index ae00e79..fd318c0 100644
> --- a/src/glsl/ir_reader.cpp
> +++ b/src/glsl/ir_reader.cpp
> @@ -972,7 +972,7 @@ ir_reader::read_texture(s_expression *expr)
> op = ir_query_levels;
> } else if (MATCH(expr, other_pattern)) {
> op = ir_texture::get_opcode(tag->value());
> - if (op == -1)
> + if (op == (ir_texture_opcode) -1)
> return NULL;
> } else {
> ir_read_error(NULL, "unexpected texture pattern %s", tag->value());
> Reviewed-by: Kenneth Graunke <[email protected]>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
