[Mesa-dev] [Bug 76698] DRI loader prints misleading error message

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76698 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] gallium: replace pipe_type enum with tgsi_return_type enum

2014-09-22 Thread Brian Paul
The only place the enum pipe_type was used is for the TGSI sampler view return type. So make it a TGSI type. Note: it appears this part of TGSI isn't used by anyone so it may be removed in the future. v2: the new name is tgsi_return_type, not tgsi_type. This means we can drop the previously pos

Re: [Mesa-dev] [PATCH 03/12] mesa: Replace a priori knowledge of gcc attributes with configure tests.

2014-09-22 Thread Brian Paul
How do these kinds of changes interact with the SCons build? I think I'll have to test the whole series with SCons/Windows. -Brian On 09/22/2014 12:51 PM, Matt Turner wrote: Note that I had to add support for testing the packed attribute to m4/ax_gcc_func_attribute.m4. --- configure.ac

Re: [Mesa-dev] [PATCH 1/3] tgsi: rename TGSI_TYPE_x -> TGSI_OPCODE_TYPE_x

2014-09-22 Thread Emil Velikov
On 22/09/14 16:44, Brian Paul wrote: > To avoid conflicts with coming TGSI_TYPE_x enums. > --- > src/gallium/auxiliary/gallivm/lp_bld_tgsi.c| 26 - > src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c| 57 > ++-- > src/gallium/auxiliary/tgsi/tgsi_info.c

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-22 Thread Marek Olšák
No, we cannot detect compute-only contexts yet. We need to add a new parameter to pipe_context::context_create which says that a context is compute-only. That should be OpenCL but not OpenGL. Also, some code paths like resource_copy_region use the graphics engine for copying, which cannot be used

Re: [Mesa-dev] [PATCH 03/12] mesa: Replace a priori knowledge of gcc attributes with configure tests.

2014-09-22 Thread Brian Paul
Yeah, the scons build is broken on Linux even: Compiling src/gallium/state_trackers/egl/common/egl_g3d_image.c ... In file included from src/gallium/include/pipe/p_compiler.h:33:0, from src/gallium/include/pipe/p_screen.h:41, from src/gallium/state_trackers/egl

Re: [Mesa-dev] [PATCH 1/3] tgsi: rename TGSI_TYPE_x -> TGSI_OPCODE_TYPE_x

2014-09-22 Thread Brian Paul
On 09/22/2014 01:47 PM, Emil Velikov wrote: On 22/09/14 16:44, Brian Paul wrote: To avoid conflicts with coming TGSI_TYPE_x enums. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.c| 26 - src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c| 57 ++-- src/gall

[Mesa-dev] [Bug 57702] Eliminate RTLD_GLOBAL glapi hacks after removing support for static libglapi

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57702 --- Comment #2 from Emil Velikov --- Pardon for the non-comprehensive reply there. The funny sentences should read "I do not think that the lack of explicit link is our biggest issue" "Up-to recently the xserver was the second provider for thos

Re: [Mesa-dev] [PATCH 1/4] configure: remove non-functional --with-opencl-libdir

2014-09-22 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 07/12] i965/fs: Use the var_from_vgrf helper function instead of doing it manually

2014-09-22 Thread Jason Ekstrand
On Mon, Sep 22, 2014 at 10:49 AM, Matt Turner wrote: > On Fri, Sep 19, 2014 at 8:14 PM, Jason Ekstrand > wrote: > > > > > > On Fri, Sep 19, 2014 at 5:16 PM, Matt Turner wrote: > >> > >> On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand > >> wrote: > >> > Signed-off-by: Jason Ekstrand > >> > ---

Re: [Mesa-dev] [PATCH 03/12] mesa: Replace a priori knowledge of gcc attributes with configure tests.

2014-09-22 Thread Matt Turner
On Mon, Sep 22, 2014 at 12:50 PM, Brian Paul wrote: > Yeah, the scons build is broken on Linux even: Oh, thanks. You're right. I'll think about how to do this with scons. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.

Re: [Mesa-dev] [PATCH 05/12] i965/fs: Use offset a lot more places

2014-09-22 Thread Jason Ekstrand
On Fri, Sep 19, 2014 at 5:34 PM, Matt Turner wrote: > On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand > wrote: > > We have this wonderful offset() function for advancing registers, but > we're > > not using it. Using offset() allows us to do some sanity checking and > > avoid manually touching

Re: [Mesa-dev] [PATCH 05/12] i965/fs: Use offset a lot more places

2014-09-22 Thread Matt Turner
On Mon, Sep 22, 2014 at 1:40 PM, Jason Ekstrand wrote: > On Fri, Sep 19, 2014 at 5:34 PM, Matt Turner wrote: >> On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand >> > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp >> > b/src/mesa/drivers/dri/i965/brw_fs.cpp >> > index af8c087..ea91705 100644 >>

Re: [Mesa-dev] [PATCH 03/12] i965/fs: Rewrite fs_visitor::split_virtual_grfs

2014-09-22 Thread Jason Ekstrand
On Fri, Sep 19, 2014 at 5:31 PM, Matt Turner wrote: > On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand > wrote: > > The original vgrf splitting code was written assuming that with the > > assumption that vgrfs came in two types: those that can be split into > > s/ with the assumption that// > > >

Re: [Mesa-dev] [PATCH] gallium: replace pipe_type enum with tgsi_return_type enum

2014-09-22 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger Roland Am 22.09.2014 21:36, schrieb Brian Paul: > The only place the enum pipe_type was used is for the TGSI sampler > view return type. So make it a TGSI type. Note: it appears this > part of TGSI isn't used by anyone so it may be removed in the future. > > v2

Re: [Mesa-dev] [PATCH 03/12] mesa: Replace a priori knowledge of gcc attributes with configure tests.

2014-09-22 Thread Matt Turner
On Mon, Sep 22, 2014 at 1:34 PM, Matt Turner wrote: > On Mon, Sep 22, 2014 at 12:50 PM, Brian Paul wrote: >> Yeah, the scons build is broken on Linux even: > > Oh, thanks. You're right. I'll think about how to do this with scons. Is scons supposed to be able to do incremental rebuilds? I get thi

[Mesa-dev] [PATCH 1/2] gallium/rbug: unlock a mutex in rbug_create_query

2014-09-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/rbug/rbug_context.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/rbug/rbug_context.c b/src/gallium/drivers/rbug/rbug_context.c index 71bc216..026c132 100644 --- a/src/gallium/drivers/rbug/rbug_context.c

[Mesa-dev] [PATCH 2/2] gallium/rbug: correctly unreference a sampler view

2014-09-22 Thread Marek Olšák
From: Marek Olšák This fixes heap corruption. The sampler view can be bound in the context, so we cannot call destroy directly. --- src/gallium/drivers/rbug/rbug_objects.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/rbug/rbug_objects.c b/src/gallium

Re: [Mesa-dev] [PATCH 1/2] gallium/rbug: unlock a mutex in rbug_create_query

2014-09-22 Thread Brian Paul
On 09/22/2014 03:18 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/rbug/rbug_context.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/rbug/rbug_context.c b/src/gallium/drivers/rbug/rbug_context.c index 71bc216..026c132 10064

Re: [Mesa-dev] [PATCH 03/12] mesa: Replace a priori knowledge of gcc attributes with configure tests.

2014-09-22 Thread Brian Paul
On 09/22/2014 02:57 PM, Matt Turner wrote: On Mon, Sep 22, 2014 at 1:34 PM, Matt Turner wrote: On Mon, Sep 22, 2014 at 12:50 PM, Brian Paul wrote: Yeah, the scons build is broken on Linux even: Oh, thanks. You're right. I'll think about how to do this with scons. Is scons supposed to be a

[Mesa-dev] [Bug 84124] Please revert 8449121971ce1db03fea19665d314e523fdc10dd

2014-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84124 --- Comment #2 from almos --- Have you tried to talk to Phoronix about this issue? I don't think Michael is deliberately going full retard, he's just underinformed about lots of things. -- You are receiving this mail because: You are the QA Con

Re: [Mesa-dev] [PATCH 2/2] gallium/rbug: correctly unreference a sampler view

2014-09-22 Thread Brian Paul
On Mon, Sep 22, 2014 at 3:18 PM, Marek Olšák wrote: > From: Marek Olšák > > This fixes heap corruption. The sampler view can be bound in the context, > so we cannot call destroy directly. > --- > src/gallium/drivers/rbug/rbug_objects.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-22 Thread Dieter Nützel
Am 22.09.2014 18:54, schrieb Glenn Kennard: On Wed, 17 Sep 2014 06:10:48 +0200, Alexandre Demers wrote: Tested with v3. I get the same result as before: everything is fine except the gs-atan-vec2 test. I don't know if this is of any value, but running the command manually in a shell gives

[Mesa-dev] [PATCH 2/4] glsl: Use signed array index in update_max_array_access()

2014-09-22 Thread Anuj Phogat
Avoids a crash in case of negative array index is used in a shader program. Cc: Signed-off-by: Anuj Phogat --- src/glsl/ast_array_index.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp index 5ca85f6..299ec9

[Mesa-dev] [PATCH 1/4] glsl: Fix crash due to negative array index

2014-09-22 Thread Anuj Phogat
Currently Mesa crashes with a shader like this: [fragmnet shader] float[5] array; int idx = -2; void main() { gl_FragColor = vec4(0.0, 1.0, 0.0, array[idx]); } Cc: Signed-off-by: Anuj Phogat --- src/glsl/opt_array_splitting.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[Mesa-dev] [PATCH 3/4] glsl: No compile error for out of bounds array index

2014-09-22 Thread Anuj Phogat
Emit a warning to let user know that the behavior is undefined. Cc: Signed-off-by: Anuj Phogat --- src/glsl/ast_array_index.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp index 299ec91..b23bb69 10064

[Mesa-dev] [PATCH 4/4] glsl: Don't abort if array index is out of bounds

2014-09-22 Thread Anuj Phogat
Currently abort happens for this shader: [fragment shader] float array[5]; const int idx = 8; void main() { gl_FragColor = vec4(0.0, 1.0, 0.0, array[idx]); } Cc: Signed-off-by: Anuj Phogat --- src/glsl/ir_validate.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/glsl/ir_validat

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: detect LLVM patch level when built via cmake

2014-09-22 Thread Emil Velikov
On 17/09/14 15:37, Jonathan Gray wrote: > On Wed, Sep 17, 2014 at 07:03:56AM -0700, Tom Stellard wrote: >> On Wed, Sep 17, 2014 at 09:29:34PM +1000, Jonathan Gray wrote: >>> On Tue, Sep 16, 2014 at 06:24:40PM -0400, Tom Stellard wrote: On Tue, Sep 09, 2014 at 07:56:03PM +0100, Emil Velikov wro

[Mesa-dev] [PATCH] egl_dri2: Allow both 24 and 32 bit X visuals for RGBA configs

2014-09-22 Thread Emil Velikov
From: Sjoerd Simons When using RGBA EGLConfigs allow both RGB and RGBA X visuals, such that application can decide whether they want to use RGBA (and have the compositor blend their windows). On my system with this change EGLConfigs with a 24 bit visual comes up first, as such applications blind

[Mesa-dev] [PATCH] mesa: Move register_allocate.c to util.

2014-09-22 Thread Eric Anholt
The r300 gallium driver is using it outside of the Mesa tree, and I wanted to do so for vc4 as well. Rather than make the multiple-definitions problem even more complicated, just move it to more-shared code. --- src/gallium/drivers/r300/Makefile.am | 14 +- src/gallium/drivers/r300

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-09-22 Thread Jan Vesely
[SNIP] > > > > > I also don't like that this way there is no difference between > > > explicit and implicit kernel arguments. On the other hand it's simple, > > > and does not need additional per driver code. > > > > > Yeah... We definitely want to hide these from the user, as e.g. the > > CL_KER

Re: [Mesa-dev] [PATCH] mesa: Move register_allocate.c to util.

2014-09-22 Thread Matt Turner
r300 has a symlink to the code: ./src/gallium/drivers/r300/register_allocate.c With that removed as well, Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: Move register_allocate.c to util.

2014-09-22 Thread Emil Velikov
On 23/09/14 01:32, Eric Anholt wrote: > The r300 gallium driver is using it outside of the Mesa tree, and I wanted > to do so for vc4 as well. Rather than make the multiple-definitions > problem even more complicated, just move it to more-shared code. > --- > src/gallium/drivers/r300/Makefile.am

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: detect LLVM patch level when built via cmake

2014-09-22 Thread Jonathan Gray
On Tue, Sep 23, 2014 at 12:38:55AM +0100, Emil Velikov wrote: > On 17/09/14 15:37, Jonathan Gray wrote: > > On Wed, Sep 17, 2014 at 07:03:56AM -0700, Tom Stellard wrote: > >> On Wed, Sep 17, 2014 at 09:29:34PM +1000, Jonathan Gray wrote: > >>> On Tue, Sep 16, 2014 at 06:24:40PM -0400, Tom Stellard

<    1   2