Re: [Mesa-dev] [PATCH] i965: Emit a performance warning on conditional rendering.

Since we were just discussing this in IRC, Reviewed-by: Chris Forbes On Mon, Aug 4, 2014 at 6:54 PM, Kenneth Graunke wrote: > We have a CPU-side implementation of conditional rendering; it really > should be done on the GPU. It's not necessarily that hard, but nobody > has gotten to fixing it

Re: [Mesa-dev] [PATCH] meta: Remove dither bit from blit paths that do not need it

On Sun, Aug 03, 2014 at 06:32:54PM -0700, Kenneth Graunke wrote: > On Friday, August 01, 2014 08:37:53 PM Topi Pohjolainen wrote: > > Similarly to an older patch. This is the minimum needed to fix the > > bug but there are other meta-paths remaining that have the bit > > since its introduction but

Re: [Mesa-dev] [PATCH v3] winsys/radeon: fix nop packet padding for hawaii

On 02.08.2014 03:30, Andreas Boll wrote: > The initial firmware for hawaii does not support type3 nop packet. > Detect the new hawaii firmware with query RADEON_INFO_ACCEL_WORKING2. > If the returned value is 3, then the new firmware is used. > > This patch uses type2 for the old firmware and type

Re: [Mesa-dev] [PATCH v3 10/19] i965/gen6 depth surface: calculate minimum array element being rendered

On Fri, Aug 01, 2014 at 12:43:38PM -0700, Jordan Justen wrote: > On Fri, Aug 1, 2014 at 2:44 AM, Pohjolainen, Topi > wrote: > > On Fri, Aug 01, 2014 at 12:53:40AM -0700, Jordan Justen wrote: > >> (a23cfb8 for gen6) > >> > >> In layered rendering this will be 0. Otherwise it will be the > >> select

Re: [Mesa-dev] [PATCH v3 13/19] i965/gen6 depth surface: program 3DSTATE_DEPTH_BUFFER to top of surface

On Fri, Aug 01, 2014 at 01:27:49PM -0700, Jordan Justen wrote: > On Fri, Aug 1, 2014 at 1:53 AM, Pohjolainen, Topi > wrote: > > On Fri, Aug 01, 2014 at 12:53:43AM -0700, Jordan Justen wrote: > >> (bf25ee2 for gen6) > >> > >> Previously we would always find the 2D sub-surface of interest, > >> and

[Mesa-dev] [PATCH 02/11] i965/fs: Collect all emits of texture ops for Gen5/6 into one place

Reduces duplication, and will do so even more when we change the sampler plumbing. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 31 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visi

[Mesa-dev] [PATCH 01/11] i965/fs: Collect all emits of texture ops for Gen4 into one place

Reduces duplication, and will do so even more when we change the sampler plumbing. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 31 ++-- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visi

[Mesa-dev] [PATCH 00/11] i965: Rework sampler index handling in LIR

Previously sampler indices were stored in a dedicated field of backend_instruction. This series reworks them to be passed as the src1 operand, mirroring how we deal with UBO accesses, etc. This is required in order to relax the restriction that sampler array indices be constant expressions. (We

[Mesa-dev] [PATCH 03/11] i965/fs: pass sampler as src1 of texture op

--- src/mesa/drivers/dri/i965/brw_fs.h | 15 +++--- src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 29 ++-- 3 files changed, 25 insertions(+), 23 deletions(-) diff --git a/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 06/11] i965/fs/Gen8: Pass sampler_index to generate_tex

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 18 -- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs

[Mesa-dev] [PATCH 05/11] i965/fs/Gen4-7: Pass sampler_index to generate_tex

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 18 -- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h

[Mesa-dev] [PATCH 04/11] i965/blorp: Put sampler index in src1 of texture ops

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp index c1676a9..7d4b327 100644 --- a/src/mesa/dri

[Mesa-dev] [PATCH 07/11] i965/vec4: Collect all emits of texture ops into one place

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 38 -- 1 file changed, 12 insertions(+), 26 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index f03b3c9..47ad744 1

[Mesa-dev] [PATCH 08/11] i965/vec4: Pass sampler index in src1 for texture ops

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vec4.h | 6 +++--- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 12 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.

[Mesa-dev] [PATCH 11/11] i965: Get rid of backend_instruction::sampler

The generators no longer use this. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 1 - src/mesa/drivers/dri/i965/brw_fs.cpp| 1 - src/mesa/drivers/dri/i965/brw_fs_cse.cpp| 1 - src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 1 - src/mesa/

[Mesa-dev] [PATCH 10/11] i965/vec4/Gen8: Use src1 for sampler_index instead of ->sampler field

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vec4.h | 3 ++- src/mesa/drivers/dri/i965/gen8_vec4_generator.cpp | 19 +-- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 09/11] i965/vec4/Gen4-7: Use src1 for sampler_index instead of ->sampler field

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vec4.h | 5 +++-- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 18 -- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 1/5] meta: Initialize the variable in declaration statement

On Wed, Jul 30, 2014 at 07:11:23PM -0700, Anuj Phogat wrote: > Saves one line of code :) > > Signed-off-by: Anuj Phogat > --- > Realized today that I never really sent this series out to the list. > > src/mesa/drivers/common/meta.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >

Re: [Mesa-dev] [PATCH 2/5] meta: Use _mesa_get_format_bits() to get the GL_RED_BITS

On Wed, Jul 30, 2014 at 07:11:24PM -0700, Anuj Phogat wrote: > We currently get red bits from ctx->DrawBuffer->Visual.redBits > by making a false assumption that the texture we're writing to > (in glCopyTexImage2D()) is used as a DrawBuffer. > > Fixes many failures in gles3 Khronos CTS test: > cop

Re: [Mesa-dev] [PATCH] glsl: fix switch statement default case regressions

Reviewed-by: Chris Forbes On Fri, Jul 25, 2014 at 6:40 PM, Tapani Pälli wrote: > This patch fixes regressions caused by commit 48deb4d. Regressions > happened because 'run_default' var did not initialized when default > case was the last one. > > Now all the switch tests in es3conform suite are

Re: [Mesa-dev] [PATCH 2/5] meta: Use _mesa_get_format_bits() to get the GL_RED_BITS

On Mon, Aug 04, 2014 at 12:11:53PM +0300, Pohjolainen, Topi wrote: > On Wed, Jul 30, 2014 at 07:11:24PM -0700, Anuj Phogat wrote: > > We currently get red bits from ctx->DrawBuffer->Visual.redBits > > by making a false assumption that the texture we're writing to > > (in glCopyTexImage2D()) is used

Re: [Mesa-dev] [PATCH 3/5] meta: Move the call to _mesa_get_format_datatype() out of switch

On Wed, Jul 30, 2014 at 07:11:25PM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/common/meta.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c > index ba84eb8..ed

Re: [Mesa-dev] [PATCH 4/5] meta: Fix datatype computation in get_temp_image_type()

On Wed, Jul 30, 2014 at 07:11:26PM -0700, Anuj Phogat wrote: > Changes in the patch will cause datatype to be computed > correctly for 8 and 16 bit integer formats. For example: > GL_RG8I, GL_RG16I etc. > > Fixes many failures in gles3 Khronos CTS test: > copy_tex_image_conversions_required > copy

[Mesa-dev] [PATCH v4] winsys/radeon: fix nop packet padding for hawaii

The initial firmware for hawaii does not support type3 nop packet. Detect the new hawaii firmware with query RADEON_INFO_ACCEL_WORKING2. If the returned value is 3, then the new firmware is used. This patch uses type2 for the old firmware and type3 for the new firmware. It fixes the cases when th

Re: [Mesa-dev] [PATCH 4/5] mesa/meta: Add a partial implementation of CopyImageSubData

Jason Ekstrand writes: > Done. Other than that, does this count as a R-B? Yeah, with the cleanup step it looks good to me. Reviewed-by: Neil Roberts Regards, - Neil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.o

Re: [Mesa-dev] [PATCH v4] winsys/radeon: fix nop packet padding for hawaii

Am 04.08.2014 um 12:48 schrieb Andreas Boll: The initial firmware for hawaii does not support type3 nop packet. Detect the new hawaii firmware with query RADEON_INFO_ACCEL_WORKING2. If the returned value is 3, then the new firmware is used. This patch uses type2 for the old firmware and type3 fo

Re: [Mesa-dev] [PATCH v4] winsys/radeon: fix nop packet padding for hawaii

Am 04.08.2014 um 12:48 schrieb Andreas Boll: The initial firmware for hawaii does not support type3 nop packet. Detect the new hawaii firmware with query RADEON_INFO_ACCEL_WORKING2. If the returned value is 3, then the new firmware is used. This patch uses type2 for the old firmware and type3 fo

Re: [Mesa-dev] [PATCH 02/20] i965: Add and use foreach_block macro.

On Thu, Jul 24, 2014 at 07:54:09PM -0700, Matt Turner wrote: > Use this as an opportunity to rename 'block_num' to 'num'. block->num is > clear, and block->block_num has always been redundant. > --- > src/mesa/drivers/dri/i965/brw_cfg.cpp | 17 ++--- > src/mesa/drivers/dri/i965/brw_cf

Re: [Mesa-dev] [PATCH 01/20] i965/cfg: Embed link in bblock_t for main block list.

On Thu, Jul 24, 2014 at 07:54:08PM -0700, Matt Turner wrote: > The next patch adds a foreach_block (block, cfg) macro, which works > better if it provides a direct bblock_t pointer, rather than a > bblock_link pointer that you have to use to find the actual block. > --- > src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 0/2] clover: add clCompileProgram

Hello I'm done with the clCompile part of OpenCL 1.2. As you can see I use char* data to transfert data from core to llvm. At first I was thinking of using std class but we need to be binary safe when data are transfert beetween c++98/c++11 compiled code. Then I try to use compat class, but it

[Mesa-dev] [PATCH 1/2] clover: std::pair is not c++98/c++11 safe

add a simple compat::pair --- src/gallium/state_trackers/clover/util/compat.hpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/state_trackers/clover/util/compat.hpp b/src/gallium/state_trackers/clover/util/compat.hpp index 50e1c7d..c5d1b39 100644 --- a/src/gallium/state_tra

[Mesa-dev] [PATCH 2/2] clover: add clCompileProgram

--- src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 41 -- .../state_trackers/clover/core/compiler.hpp| 11 +++--- src/gallium/state_trackers/clover/core/program.cpp | 14 ++-- src/gallium/state_tracke

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: implement support for cube map arrays

On 08/01/2014 08:12 PM, srol...@vmware.com wrote: From: Roland Scheidegger This just covers the resource side of things, not the actual sampling. Here things are trivial as cube map arrays are identical to 2d arrays in all respects. --- src/gallium/drivers/llvmpipe/lp_screen.c| 3 ++-

Re: [Mesa-dev] [PATCH] dri/xmlconfig: s/uint/unsigned int/

On 08/03/2014 02:03 PM, Vinson Lee wrote: This patch fixes this build error on Mac OS X. ./xmlconfig.h:61:5: error: unknown type name 'uint'; did you mean 'int'? uint nRanges; /**< \brief Number of ranges */ ^~~~ int ./xmlconfig.h:79:5: error: unknown type name 'uint'; did

Re: [Mesa-dev] [PATCH v4] winsys/radeon: fix nop packet padding for hawaii

2014-08-04 13:40 GMT+02:00 Christian König : > Am 04.08.2014 um 12:48 schrieb Andreas Boll: >> >> The initial firmware for hawaii does not support type3 nop packet. >> >> Detect the new hawaii firmware with query RADEON_INFO_ACCEL_WORKING2. >> If the returned value is 3, then the new firmware is us

Re: [Mesa-dev] [PATCH v2 09/13] mesa/format_utils: Add a function to convert a mesa_format to an array format

On 08/02/2014 02:11 PM, Jason Ekstrand wrote: This commits adds the _mesa_format_to_arary function that determines if the "array" given format can be represented as an array format and computes the array format parameters. This is a direct helper function for using _mesa_swizzle_and_convert

Re: [Mesa-dev] [PATCH v2 00/13] Rework the texture upload code

On 08/02/2014 02:11 PM, Jason Ekstrand wrote: This is a direct rework of the patch series starting here: https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/archives/mesa-dev/2014-July/063483.html&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiI

Re: [Mesa-dev] [PATCH v2 08/13] mesa/format_utils: Add a general format conversion function

On 08/02/2014 02:11 PM, Jason Ekstrand wrote: Most format conversion operations required by GL can be performed by converting one channel at a time, shuffling the channels around, and optionally filling missing channels with zeros and ones. This adds a function to do just that in a general, yet

Re: [Mesa-dev] [PATCH v2 06/13] meas: Gather some common format conversion functions into a single file

Typo in subject line: s/meas/mesa/ On 08/02/2014 02:11 PM, Jason Ekstrand wrote: This initial commit puts all of the RGB <-> sRGB conversion functions in format_utils.c. v2: Shorter commit subject and added format_utils.c to SConscript Signed-off-by: Jason Ekstrand --- src/mesa/Makefile.so

Re: [Mesa-dev] [PATCH v2 03/13] mesa/formats: Autogenerate the format_info structure from a CSV file

On 08/02/2014 02:11 PM, Jason Ekstrand wrote: Instead of a having all of the format metadata in a gigantic hard-to-edit array of type struct format_info, we now use a human-readable CSV file. The CSV file also contains more format information than the format_info struct contained so we can potent

Re: [Mesa-dev] [PATCH 0/5] OpenGL ES improvements

Am 03.08.2014 14:40, schrieb Marek Olšák: > Hi everyone, > > This series adds: > - Support for ETC2 texture formats to all gallium drivers. This is a > requirement for OpenGL ES 3.0, which can now be considered feature-complete > as far as I know. Textures of such formats are loaded as plain R/R

[Mesa-dev] [PATCH] st/mesa: adjust Z coordinates for quad clearing

Specify the quad's Z position in clip coordinate space, not normalized Z space. Use viewport scale, translation = 0.5, 0.5. Before, we were specifying the quad's Z position in [0,1] and using viewport scale=1.0, translate=0.0. That works fine, unless your driver needs to work in clip coordinate

Re: [Mesa-dev] [PATCH 0/5] OpenGL ES improvements

On Mon, Aug 4, 2014 at 11:54 AM, Roland Scheidegger wrote: > Am 03.08.2014 14:40, schrieb Marek Olšák: >> Hi everyone, >> >> This series adds: >> - Support for ETC2 texture formats to all gallium drivers. This is a >> requirement for OpenGL ES 3.0, which can now be considered feature-complete >>

Re: [Mesa-dev] [PATCH 1/2] c11/threads: add missing brackets around _MTX_INITIALIZER_NP

On 02/08/14 02:51, Emil Velikov wrote: > On 02/08/14 00:26, Ian Romanick wrote: >> On 08/01/2014 09:41 AM, Emil Velikov wrote: >>> ... for win32 builds. Spotted this warning when I've imported the >>> library into waffle, and gave mingw-w64-gcc a bash at compiling it. >>> >>> src/waffle/core/wcore_

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

Connor Abbott writes: > On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: >> Connor Abbott writes: >> >>> On Fri, Aug 1, 2014 at 11:51 AM, Eric Anholt wrote: Connor Abbott writes: > On Thu, Jul 31, 2014 at 1:05 PM, Eric Anholt wrote: >> Connor Abbott writes: >>> That

Re: [Mesa-dev] [PATCH] mesa: Actually use the Mesa IR optimizer for ARB programs.

Kenneth Graunke writes: > On Haswell, this cuts 1-3 instructions from 183 vertex shaders in > "Shadowrun Returns", "Shatter", and "Trine 2." It adds 2 instructions > to a single fragment shader in "Closure." Reviewed-by: Eric Anholt pgpJJ9s8qS1qU.pgp Description: PGP signature __

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

On Mon, Aug 4, 2014 at 9:46 AM, Eric Anholt wrote: > Connor Abbott writes: > >> On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: >>> Connor Abbott writes: >>> On Fri, Aug 1, 2014 at 11:51 AM, Eric Anholt wrote: > Connor Abbott writes: > >> On Thu, Jul 31, 2014 at 1:05 PM,

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

Connor Abbott writes: > On Mon, Aug 4, 2014 at 9:46 AM, Eric Anholt wrote: >> Connor Abbott writes: >> >>> On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: Connor Abbott writes: > On Fri, Aug 1, 2014 at 11:51 AM, Eric Anholt wrote: >> Connor Abbott writes: >> >>

Re: [Mesa-dev] [PATCH 1/2] c11/threads: add missing brackets around _MTX_INITIALIZER_NP

Am 02.08.2014 03:51, schrieb Emil Velikov: > On 02/08/14 00:26, Ian Romanick wrote: >> On 08/01/2014 09:41 AM, Emil Velikov wrote: >>> ... for win32 builds. Spotted this warning when I've imported the >>> library into waffle, and gave mingw-w64-gcc a bash at compiling it. >>> >>> src/waffle/core/wc

[Mesa-dev] [PATCH] gallivm: Fix Altivec pack intrinsics for little-endian

This patch fixes use of Altivec pack intrinsics on little-endian PowerPC systems. Since little-endian operation only affects the load and store instructions, the semantics of pack (and other) instructions that take two input vectors implicitly change: the pack instructions still fill a register pl

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

On Mon, Aug 4, 2014 at 10:17 AM, Eric Anholt wrote: > Connor Abbott writes: > >> On Mon, Aug 4, 2014 at 9:46 AM, Eric Anholt wrote: >>> Connor Abbott writes: >>> On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: > Connor Abbott writes: > >> On Fri, Aug 1, 2014 at 11:51 AM,

Re: [Mesa-dev] [PATCH 5/5 v2] i965: Add support for ARB_copy_image

One case where the memcpy path won't work is if the source and destination are the same buffer. In that case it tries to map the texture twice and hits an assert. I think this could be a legitimate use case if the source and destination rectangles don't overlap. The extension spec isn't very clear

Re: [Mesa-dev] [PATCH 5/5 v2] i965: Add support for ARB_copy_image

Thanks Neil, I'll make that change. Should be simple enough. --Jason On Mon, Aug 4, 2014 at 10:51 AM, Neil Roberts wrote: > One case where the memcpy path won't work is if the source and > destination are the same buffer. In that case it tries to map the > texture twice and hits an assert. I t

Re: [Mesa-dev] [PATCH 1/3] glsl: Make it possible to ignore built-ins when matching signatures.

Series is Reviewed-by: Ian Romanick Thanks, Ken! On 07/24/2014 02:05 PM, Kenneth Graunke wrote: > Historically, we've implemented the rules for overriding built-in > functions by creating multiple ir_functions and relying on the symbol > table to hide the one containing built-in functions. Tha

Re: [Mesa-dev] [PATCH v2 09/13] mesa/format_utils: Add a function to convert a mesa_format to an array format

On Mon, Aug 4, 2014 at 7:55 AM, Brian Paul wrote: > On 08/02/2014 02:11 PM, Jason Ekstrand wrote: > >> This commits adds the _mesa_format_to_arary function that determines if >> the >> > > "array" > > > > given format can be represented as an array format and computes the array >> format paramet

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

On Mon, Aug 4, 2014 at 10:42 AM, Connor Abbott wrote: > On Mon, Aug 4, 2014 at 10:17 AM, Eric Anholt wrote: >> Connor Abbott writes: >> >>> On Mon, Aug 4, 2014 at 9:46 AM, Eric Anholt wrote: Connor Abbott writes: > On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: >> Conno

Re: [Mesa-dev] [PATCH v2 08/13] mesa/format_utils: Add a general format conversion function

On Mon, Aug 4, 2014 at 7:55 AM, Brian Paul wrote: > On 08/02/2014 02:11 PM, Jason Ekstrand wrote: > >> Most format conversion operations required by GL can be performed by >> converting one channel at a time, shuffling the channels around, and >> optionally filling missing channels with zeros and

Re: [Mesa-dev] [PATCH 0/2] clover: add clCompileProgram

On Aug 4, 2014, at 8:03 AM, EdB wrote: > Hello > > I'm done with the clCompile part of OpenCL 1.2. > > As you can see I use char* data to transfert data from core to llvm. > > At first I was thinking of using std class but we need to be binary safe > when data are transfert beetween c++98/c++

Re: [Mesa-dev] [PATCH 00/11] i965: Rework sampler index handling in LIR

This series looks good to me: Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] targets/vdpau: link with libmesautil.la to fix build breakage

--- src/gallium/targets/vdpau/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/vdpau/Makefile.am b/src/gallium/targets/vdpau/Makefile.am index 8c1e1f6..6c92cd8 100644 --- a/src/gallium/targets/vdpau/Makefile.am +++ b/src/gallium/targets/vdpau/Makefile.am @@ -

[Mesa-dev] [PATCH 1/2] xlib: fix missing mesautil build breakage

Fixes the non-DRI build. --- src/mesa/drivers/x11/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/x11/Makefile.am b/src/mesa/drivers/x11/Makefile.am index 7a35132..40b01dd 100644 --- a/src/mesa/drivers/x11/Makefile.am +++ b/src/mesa/drivers/x11/Makefile.am @@ -2

[Mesa-dev] [PATCH 2/2] loader: silence declarations after code warning

Remove the semicolon from the macro. All the instances of the macro end with a semicolon already. --- src/loader/loader.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/loader/loader.c b/src/loader/loader.c index 47e1f58..b159c51 100644 --- a/src/loader/loader.c +++ b/

[Mesa-dev] [PATCH 1/2] winsys/sw/dri: silence void pointer arithmetic warning

--- src/gallium/winsys/sw/dri/dri_sw_winsys.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/sw/dri/dri_sw_winsys.c b/src/gallium/winsys/sw/dri/dri_sw_winsys.c index 6fed22b..24d6308 100644 --- a/src/gallium/winsys/sw/dri/dri_sw_winsys.c +++ b/src/gall

Re: [Mesa-dev] [PATCH 1/2] xlib: fix missing mesautil build breakage

Both patches: Reviewed-by: Jason Ekstrand On Mon, Aug 4, 2014 at 12:09 PM, Brian Paul wrote: > Fixes the non-DRI build. > --- > src/mesa/drivers/x11/Makefile.am |1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/x11/Makefile.am > b/src/mesa/drivers/x11/Makefile.am >

[Mesa-dev] [PATCH 1/4] i965/guardband: Improve comments for guardband clipping

While working in this part of the code I had a great deal of trouble understanding what it was trying to do, and matching it with the spec. (mostly due bad wording in the PRM). To help future people, I've cleaned up the wording and provided some ascii art. --- src/mesa/drivers/dri/i965/gen8_viewpo

[Mesa-dev] [PATCH 4/4] i965/clip: Removing scissor atom

On GEN8, a change in scissor state does not effect anything for the clipper/sf hardware state. The hardware will always do the right thing once the viewport extents are programmed. We can therefore remove the unecessary state emission. Ken originally spotted this. --- src/mesa/drivers/dri/i965/ge

[Mesa-dev] [PATCH 3/4] i965/guardband: Enable for all viewport dimensions (GEN8+)

The goal of guardband clipping is to try to avoid 3d clipping because it is an expensive operation. When guardband clipping is disabled, all geometry that intersects the viewport is to the FF 3d clipper. Objects which are entirely enclosed within the viewport are said to be "trivially accepted" whi

[Mesa-dev] [PATCH 0/4] BDW viewport extents + misc

The patch commit messages and comments within the diffs explain the intricacies of viewport extents and clipping. So rather, here is the data for these patches. All of the following is for a Broadwell system (which introduced viewport extents). EGYPT PERF == No change WARSOW PERF

[Mesa-dev] [PATCH 2/4] i965: Viewport extents on GEN8

Viewport extents are a 3rd rectangle that defines which pixels get discarded as part of the rasterization process. This can potentially improve performance by reducing cache usage, and freeing up PS cycles. It also permits the use of guardband clipping in all cases (see later patch). The actual pix

Re: [Mesa-dev] [PATCH 00/10] [RFC] Probably useless algebraic optimizations

thomashellan...@gmail.com writes: > From: Thomas Helland > > When writing that A || (A && B) patch some > days ago I also wrote some other patches > that have no impact on my collection of shaders. > (shader-db + Some TF2 and Portal-shaders). > No reduction in instruction count, and no > signific

[Mesa-dev] [PATCH] src/Makefile.am: Move gtest before util

Since the ralloc test in util/tests needs gtest, we need to make sure that the gtest subdir is loaded first. This fixes bug #82148. Signed-off-by: Jason Ekstrand --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 2634c

[Mesa-dev] [PATCH] util: include c99_compat.h in hash_table.h to get 'inline' definition

--- src/util/hash_table.h |1 + 1 file changed, 1 insertion(+) diff --git a/src/util/hash_table.h b/src/util/hash_table.h index 9b67f05..d6b6ebf 100644 --- a/src/util/hash_table.h +++ b/src/util/hash_table.h @@ -31,6 +31,7 @@ #include #include #include +#include "c99_compat.h" #include

[Mesa-dev] [PATCH] gallium: Add libmesautil dependency to gdm and xa targets

Signed-off-by: Jason Ekstrand --- src/gallium/targets/gbm/Makefile.am | 1 + src/gallium/targets/xa/Makefile.am | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/targets/gbm/Makefile.am b/src/gallium/targets/gbm/Makefile.am index 2345ce3..a5f7070 100644 --- a/src/gallium/targets

Re: [Mesa-dev] [PATCH] gallium: Add libmesautil dependency to gdm and xa targets

On 08/04/2014 01:35 PM, Jason Ekstrand wrote: Signed-off-by: Jason Ekstrand --- src/gallium/targets/gbm/Makefile.am | 1 + src/gallium/targets/xa/Makefile.am | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/targets/gbm/Makefile.am b/src/gallium/targets/gbm/Makefile.am inde

[Mesa-dev] [PATCH] util: include c99_compat.h in format_srgb.h to get 'inline' definition

--- src/util/format_srgb.h |1 + 1 file changed, 1 insertion(+) diff --git a/src/util/format_srgb.h b/src/util/format_srgb.h index 17ba283..4a8d73f 100644 --- a/src/util/format_srgb.h +++ b/src/util/format_srgb.h @@ -39,6 +39,7 @@ #include #include +#include "c99_compat.h" extern con

Re: [Mesa-dev] [PATCH] util: include c99_compat.h in hash_table.h to get 'inline' definition

Reviewed-by: Jason Ekstrand On Mon, Aug 4, 2014 at 12:35 PM, Brian Paul wrote: > --- > src/util/hash_table.h |1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/util/hash_table.h b/src/util/hash_table.h > index 9b67f05..d6b6ebf 100644 > --- a/src/util/hash_table.h > +++ b/src/util

Re: [Mesa-dev] [PATCH] util: include c99_compat.h in format_srgb.h to get 'inline' definition

Reviewed-by: Jason Ekstrand On Mon, Aug 4, 2014 at 12:38 PM, Brian Paul wrote: > --- > src/util/format_srgb.h |1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/util/format_srgb.h b/src/util/format_srgb.h > index 17ba283..4a8d73f 100644 > --- a/src/util/format_srgb.h > +++ b/src/

Re: [Mesa-dev] [PATCH] meta: Remove dither bit from blit paths that do not need it

I'm not sure about either of these patches. It looks like according to the GL 4.4 spec dithering is not supposed to affect glBlitFramebuffer: “When values are written to the draw buffers, blit operations bypass most of the fragment pipeline. The only fragment operations which affect a blit are t

[Mesa-dev] meta: Disable dithering during glBlitFramebuffer

According to the GL spec the only fragment operations that should affect glBlitFramebuffer are “the pixel ownership test, the scissor test, and sRGB conversion”. That implies that dithering should not be performed so we need to disable it when implementing the blit with a render. Before commit 05b

Re: [Mesa-dev] [PATCH] src/Makefile.am: Move gtest before util

On 08/04/2014 01:27 PM, Jason Ekstrand wrote: Since the ralloc test in util/tests needs gtest, we need to make sure that the gtest subdir is loaded first. This fixes bug #82148. Signed-off-by: Jason Ekstrand --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[Mesa-dev] [PATCH 5/6] wmesa: link with mesautil

--- src/mesa/drivers/windows/gdi/SConscript |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/windows/gdi/SConscript b/src/mesa/drivers/windows/gdi/SConscript index 10a7eea..1f4d7e1 100644 --- a/src/mesa/drivers/windows/gdi/SConscript +++ b/src/mesa/drivers/windows/gdi/SCo

[Mesa-dev] [PATCH 3/6] targets:libgl-gdi: link with mesautil

--- src/gallium/targets/libgl-gdi/SConscript |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/targets/libgl-gdi/SConscript b/src/gallium/targets/libgl-gdi/SConscript index f8393da..594f34d 100644 --- a/src/gallium/targets/libgl-gdi/SConscript +++ b/src/gallium/targets/libgl-g

[Mesa-dev] [PATCH 4/6] osmesa: link with mesautil

--- src/mesa/drivers/osmesa/SConscript |1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/osmesa/SConscript b/src/mesa/drivers/osmesa/SConscript index cbff594..caa14d3 100644 --- a/src/mesa/drivers/osmesa/SConscript +++ b/src/mesa/drivers/osmesa/SConscript @@ -10,6 +10,7 @@ e

[Mesa-dev] [PATCH 1/6] targets/egl-static: link with libmesautil.la

--- src/gallium/targets/egl-static/Makefile.am |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/targets/egl-static/Makefile.am b/src/gallium/targets/egl-static/Makefile.am index 84f3338..ff053e2 100644 --- a/src/gallium/targets/egl-static/Makefile.am +++ b/sr

[Mesa-dev] [PATCH 6/6] targets/graw-gdi: link with mesautil, not mesautils

--- src/gallium/targets/graw-gdi/SConscript |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/targets/graw-gdi/SConscript b/src/gallium/targets/graw-gdi/SConscript index dc7b7f1..f8db6e6 100644 --- a/src/gallium/targets/graw-gdi/SConscript +++ b/src/gallium/target

[Mesa-dev] [PATCH 2/6] targets/egl-static: link with libmesautil.la

--- src/gallium/targets/egl-static/SConscript |1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/egl-static/SConscript b/src/gallium/targets/egl-static/SConscript index 33db8e9..e423d5d 100644 --- a/src/gallium/targets/egl-static/SConscript +++ b/src/gallium/targets/egl-st

Re: [Mesa-dev] [PATCH 1/6] targets/egl-static: link with libmesautil.la

On 04/08/14 21:16, Brian Paul wrote: > --- > src/gallium/targets/egl-static/Makefile.am |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/targets/egl-static/Makefile.am > b/src/gallium/targets/egl-static/Makefile.am > index 84f3338..ff053e2 100644 > ---

[Mesa-dev] [PATCH] mesa/x86: put code in braces to silence declarations after code warning

--- src/mesa/x86/common_x86.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/mesa/x86/common_x86.c b/src/mesa/x86/common_x86.c index b401c35..2a936a4 100644 --- a/src/mesa/x86/common_x86.c +++ b/src/mesa/x86/common_x86.c @@ -343,16 +343,18 @@ _mesa_get_x

Re: [Mesa-dev] [PATCH] egl: Fix OpenGL ES version checks in _eglParseContextAttribList()

On Fri, Aug 1, 2014 at 4:12 PM, Ian Romanick wrote: > On 06/18/2014 05:49 PM, Anuj Phogat wrote: >> Fixes gles3 Khronos CTS test: >> egl_create_context.egl_create_context >> >> Cc: >> Signed-off-by: Anuj Phogat >> --- >> src/egl/main/eglcontext.c | 11 --- >> 1 file changed, 8 insertion

Re: [Mesa-dev] [PATCH] mesa/x86: put code in braces to silence declarations after code warning

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/5] OpenGL ES improvements

Like Alex said. I don't plan to add gallium support if our hardware cannot do it. Marek On Mon, Aug 4, 2014 at 5:54 PM, Roland Scheidegger wrote: > Am 03.08.2014 14:40, schrieb Marek Olšák: >> Hi everyone, >> >> This series adds: >> - Support for ETC2 texture formats to all gallium drivers. This

Re: [Mesa-dev] [PATCH 1/6] targets/egl-static: link with libmesautil.la

On 08/04/2014 02:21 PM, Emil Velikov wrote: On 04/08/14 21:16, Brian Paul wrote: --- src/gallium/targets/egl-static/Makefile.am |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/targets/egl-static/Makefile.am b/src/gallium/targets/egl-static/Makefile.am i

Re: [Mesa-dev] [PATCH 3/6] targets:libgl-gdi: link with mesautil

For some reason, I'm not seeing patch 2. 3, 4, 5, and 6 look fine to me. I haven't tested them, but they seem consistent with what I did in other places. On Mon, Aug 4, 2014 at 1:16 PM, Brian Paul wrote: > --- > src/gallium/targets/libgl-gdi/SConscript |3 +++ > 1 file changed, 3 insertio

[Mesa-dev] [PATCH 2/2] targets/omx: automake: link against libmesautil.la

Or the build will fail due to unresolved symbols. Signed-off-by: Emil Velikov --- src/gallium/targets/omx/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/omx/Makefile.am b/src/gallium/targets/omx/Makefile.am index 3840143..4045548 100644 --- a/src/gallium/tar

[Mesa-dev] [PATCH 1/2] targets/xvmc: automake: link against libmesautil.la

Or the build will fail due to unresolved symbols. Signed-off-by: Emil Velikov --- src/gallium/targets/xvmc/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/xvmc/Makefile.am b/src/gallium/targets/xvmc/Makefile.am index 329a1d4..884bccf 100644 --- a/src/gallium/

[Mesa-dev] [PATCH 05/13] i965/fs: make rescale_texcoord() more generic

Signed-off-by: Connor Abbott --- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 11 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 01/13] i965/fs: don't use ir->shadow_comparitor in emit_texture_*

Signed-off-by: Connor Abbott --- src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 4 +--- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 8 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_fp.cpp b/src/mesa/drivers/dri/i965/brw_fs_fp.cpp inde

[Mesa-dev] [PATCH 11/13] i965/fs: make gather_channel() more generic

Signed-off-by: Connor Abbott --- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index d3c2e5f..b0f2

[Mesa-dev] [PATCH 10/13] i965/fs: make swizzle_result() more generic

Signed-off-by: Connor Abbott --- src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 10 +- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 02/13] i965: make brw_texture_offset() more generic

Signed-off-by: Connor Abbott --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 +++- src/mesa/drivers/dri/i965/brw_shader.cpp | 13 + src/mesa/drivers/dri/i965/brw_shader.h | 3 ++- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 +++- 4 files changed, 13 inse

  1   2   >