[Mesa-dev] [PATCH] mesa: Make Geom.UsesEndPrimitive a bool instead of a GLboolean

--- Following Ian's comments on patch 9/23 of the multi-stream support series about moving away from GL types in things that are not visible to the GL API it makes sense to do the same for UsesEndPrimitive. src/mesa/main/mtypes.h| 4 ++-- src/mesa/main/shaderobj.c | 2 +- 2 files changed, 3

[Mesa-dev] [PATCH v3 11 3/3] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

--- src/glsl/builtin_functions.cpp | 60 +- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index eadc20c..5178eef 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builti

[Mesa-dev] [PATCH v3 11 2/3] glsl: Modify ir_end_primitive to have a stream.

This will be necessary to implement EndStreamPrimitive(). EndPrimitive() will produce an ir_end_primitive with the default stream 0. --- src/glsl/builtin_functions.cpp | 3 ++- src/glsl/ir.h| 17 + src/glsl/ir_hierarchical_visitor.cpp | 25 +++

[Mesa-dev] [PATCH v3 11 1/3] glsl: Modify ir_emit_vertex to have a stream.

This will be necessary to implement EmitStreamVertex(). EmitVertex() will produce an ir_emit_vertex with the default stream 0. --- src/glsl/builtin_functions.cpp | 3 ++- src/glsl/ir.h| 17 + src/glsl/ir_hierarchical_visitor.cpp | 25 -

[Mesa-dev] [PATCH v3 11 0/3] Split patch for EmitStreamVertex() and EndStreamPrimitive()

This splits the patch as requested, notice that I have not done anything to ir_to_mesa.cpp or st_glsl_to_tgsi.cpp since as I explain in another reply I think there is nothing to change in these files in the end. Iago Toral Quiroga (3): glsl: Modify ir_emit_vertex to have a stream. glsl: Modify

Re: [Mesa-dev] Testing OpenCL with gegl

On Fri, 2014-06-20 at 10:27 +0200, Bruno Jimenez wrote: > Hi, Hi Bruno, I have added mesa list to CC as others might be interested. Hope you don't mind. > > I have built babl and gegl but I don't know how to run the OpenCL tests. > Inside the tests/opencl directory there's just .xml files and th

[Mesa-dev] [Bug 79230] After upgrade from 10.1.4 to 10.2-rc4 cross-compile fails

https://bugs.freedesktop.org/show_bug.cgi?id=79230 --- Comment #9 from war...@o2.pl --- This ticket can be closed. 10.2.1 cross-compiles now OK without any patches. Thx! -- You are receiving this mail because: You are the assignee for the bug. ___ mesa

Re: [Mesa-dev] Testing OpenCL with gegl

On Fri, 2014-06-20 at 09:31 -0400, Jan Vesely wrote: > On Fri, 2014-06-20 at 10:27 +0200, Bruno Jimenez wrote: > > Hi, > > Hi Bruno, > I have added mesa list to CC as others might be interested. Hope you > don't mind. Sure, no problem. > > > > > I have built babl and gegl but I don't know how

Re: [Mesa-dev] [PATCH v2 01/23] glsl: Add parsing support for multi-stream output in geometry shaders.

On 06/18/2014 01:45 PM, Kenneth Graunke wrote: > On Wednesday, June 18, 2014 11:16:47 AM Ian Romanick wrote: >> On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: >>> From: Samuel Iglesias Gonsalvez >>> >>> This implements parsing requirements for multi-stream support in >>> geometry shaders as def

Re: [Mesa-dev] [PATCH 00/11] [RFC v2] Solve the mapping bug

On Wed, Jun 18, 2014 at 05:01:50PM +0200, Bruno Jiménez wrote: > Hi, > > This is my second attempt to fix the mapping bug adding all the > suggestions that Tom Stellard sent, and, so far, it seems that > it is resolved. > > This series changes completely how OpenCL buffers are handled > by the r6

Re: [Mesa-dev] [PATCH 00/11] [RFC v2] Solve the mapping bug

On Fri, 2014-06-20 at 13:50 -0400, Tom Stellard wrote: > On Wed, Jun 18, 2014 at 05:01:50PM +0200, Bruno Jiménez wrote: > > Hi, > > > > This is my second attempt to fix the mapping bug adding all the > > suggestions that Tom Stellard sent, and, so far, it seems that > > it is resolved. > > > > Th

[Mesa-dev] [Bug 54372] GLX_INTEL_swap_event crashes driver when swapping window buffers

https://bugs.freedesktop.org/show_bug.cgi?id=54372 --- Comment #24 from Ian Romanick --- I pushed the first patch to master, and it should end up in the next 10.2 release and probably in the final 10.1 release. Could you send your other patches to the mesa-dev mailing list with a full commit mes

Re: [Mesa-dev] Testing OpenCL with gegl

On Fri, 2014-06-20 at 19:46 +0200, Bruno Jimenez wrote: > On Fri, 2014-06-20 at 09:31 -0400, Jan Vesely wrote: > > On Fri, 2014-06-20 at 10:27 +0200, Bruno Jimenez wrote: > > > Hi, > > > > Hi Bruno, > > I have added mesa list to CC as others might be interested. Hope you > > don't mind. > > Sure,

Re: [Mesa-dev] [PATCH] i965: Save meta blit programs in the context.

On 06/19/2014 12:02 AM, Kenneth Graunke wrote: > When the last context in a share group is destroyed, the hash table > containing all of the shader programs (ctx->Shared->ShaderObjects) is > destroyed, throwing away all of the shader programs. > > Using a static variable to store program IDs ends

[Mesa-dev] [Bug 80266] Many instances of 1<<31, which is undefined in C99

https://bugs.freedesktop.org/show_bug.cgi?id=80266 Ilia Mirkin changed: What|Removed |Added Assignee|nouveau@lists.freedesktop.o |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 80266] Many instances of 1<<31, which is undefined in C99

https://bugs.freedesktop.org/show_bug.cgi?id=80266 --- Comment #10 from Patrick Baggett --- (In reply to comment #5) > Does gcc warn about this? Are you _sure_ that (signed int)1 << 31 is illegal > in C99? And as tedious as this is to mention, C99 section 6.5.7.4 does state this is undefined beh

[Mesa-dev] [Bug 80266] Many instances of 1<<31, which is undefined in C99

https://bugs.freedesktop.org/show_bug.cgi?id=80266 --- Comment #11 from Vittorio --- Another one in nouveau_fence.c:170 "#define NOUVEAU_FENCE_MAX_SPINS (1 << 31)" should be "#define NOUVEAU_FENCE_MAX_SPINS (1U<< 31)" -- You are receiving this mail because: You are the assignee for the bug. ___

Re: [Mesa-dev] [PATCH 03/11] i965: Check calloc return value in gather_statistics_results()

On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote: > Check calloc return value and report on error, also later skip > results handling if there was no memory to store results to. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/drivers/dri/i965/brw_performance_monitor.c | 7 ++- > 1 f

Re: [Mesa-dev] [PATCH 04/11] i965: Handle miptree creation failure in intel_alloc_texture_storage()

Reviewed-by: Ian Romanick On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote: > Check intel_miptree_create() return value before using it as > a pointer. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/drivers/dri/i965/intel_tex.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --g

Re: [Mesa-dev] [PATCH 05/11] i965/fs: Check variable_storage return value in fs_visitor::visit

Reviewed-by: Ian Romanick On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote: > check variable_storage() found the requested fs_reg. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/me

Re: [Mesa-dev] [PATCH 06/11] glsl: check _mesa_hash_table_create return value in link_uniform_blocks

Reviewed-by: Ian Romanick On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote: > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/link_uniform_blocks.cpp | 6 ++ > src/glsl/linker.cpp | 2 ++ > 2 files changed, 8 insertions(+) > > diff --git a/src/glsl/link_uniform_blocks.cpp

Re: [Mesa-dev] [PATCH 07/11] glsl: Add missing null check in push_back()

Reviewed-by: Ian Romanick On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote: > Report memory error on realloc failure and don't leak any memory. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/link_atomics.cpp | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > >

[Mesa-dev] [PATCH] gallivm: Fix build after LLVM commit 211259

Signed-off-by: Aaron Watry --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp index df26883..413a0c2 100644 --- a/src/gallium/aux

Re: [Mesa-dev] [PATCH] gallivm: Fix build after LLVM commit 211259

On Fri, Jun 20, 2014 at 07:14:43PM -0500, Aaron Watry wrote: > Signed-off-by: Aaron Watry Reviewed-by: Tom Stellard > --- > src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

Hi again, Autogen seems to work flawlessly with the updated branch. Everything builds and compiles as normal on my Ivy Bridge setup. When trying to do a make install though, something fails. I'm not sure if it's related to your changes, but at least master gets further into the process before fail

[Mesa-dev] [PATCH] glsl: Silence many unused parameter warnings

From: Ian Romanick In file included from ../../src/glsl/builtin_functions.cpp:61:0: ../../src/glsl/glsl_parser_extras.h:154:9: warning: unused parameter 'var' [-Wunused-parameter] Signed-off-by: Ian Romanick Cc: Tapani Pälli --- src/glsl/glsl_parser_extras.h | 2 +- 1 file changed, 1 inserti

Re: [Mesa-dev] [PATCH] mesa: Make Geom.UsesEndPrimitive a bool instead of a GLboolean

On Friday, June 20, 2014 10:01:40 AM Iago Toral Quiroga wrote: > --- > > Following Ian's comments on patch 9/23 of the multi-stream support series > about moving away from GL types in things that are not visible to the GL > API it makes sense to do the same for UsesEndPrimitive. > > src/mesa/mai

[Mesa-dev] [PATCH 13/13] i965: Request lowering gl_VertexID

From: Ian Romanick Fixes the (new) piglit tests gles-3.0-drawarrays-vertexid, gl-3.0-multidrawarrays-vertexid, and gl-3.2-basevertex-vertexid. Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80247 Cc: "10.2" --- src/mesa/drivers/dri/i965/brw_context.c | 1 +

[Mesa-dev] [PATCH 11/13] i965: Handle SYSTEM_VALUE_VERTEX_ID_ZERO_BASE

From: Ian Romanick Signed-off-by: Ian Romanick Cc: "10.2" --- src/mesa/drivers/dri/i965/brw_vec4_vs_visitor.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_vs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_vs_visitor.cpp index 79cb40f..d0d89e7 1006

[Mesa-dev] [PATCH 10/13] glsl: Add a lowering pass for gl_VertexID

From: Ian Romanick Converts gl_VertexID to (gl_VertexIDMESA + gl_BaseVertex). gl_VertexIDMESA is backed by SYSTEM_VALUE_VERTEX_ID_ZERO_BASE, and gl_BaseVertex is backed by a built-in uniform from {STATE_INTERNAL, STATE_BASE_VERTEX}. NOTE: The enum has to be declared outside the struct or C++ jus

[Mesa-dev] [PATCH 01/13] glsl_to_tgsi: Constify mesa_sysval_to_semantic

From: Ian Romanick Signed-off-by: Ian Romanick Cc: Ilia Mirkin Cc: Marek Olšák Cc: Roland Scheidegger Cc: "10.2" --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tr

[Mesa-dev] [PATCH 08/13] mesa: Add STATE_BASE_VERTEX

From: Ian Romanick This is a "uniform" that represents the basevertex value passed to glDrawElementsBaseVertex and related functions. For hardware that does not implement a hardware register for SYSTEM_VALUE_BASE_VERTEX, passing the value via a uniform is the only way to implement the functional

[Mesa-dev] [PATCH 00/13] Fix gl_VertexID on i965

This patch series fixes bugs in the i965 w.r.t. several uses of gl_VertexID. OpenGL (desktop and ES) have the following expectations of gl_VertexID: 1. When used with BaseVertex drawing commands, gl_VertexID will include the value of basevertex. This differens from "the other API," but the chang

[Mesa-dev] [PATCH 03/13] glsl_to_tgsi: Assert that the _mesa_sysval_to_semantic mapping is correct

From: Ian Romanick Future patches will rearrange the values in gl_system_value, and I want to catch errors. Designated initializers would make all of this unnecessary. v2: Don't use STATIC_ASSERT. Not only does it not work, but GCC doesn't tell you that it's not going to work. Thanks for noth

[Mesa-dev] [PATCH 06/13] mesa: Add SYSTEM_VALUE_VERTEX_ID_ZERO_BASE

From: Ian Romanick There exists hardware, such as i965, that does not implement the OpenGL semantic for gl_VertexID. Instead, that hardware does not include the value of basevertex in the gl_VertexID value. SYSTEM_VALUE_VERTEX_ID_ZERO_BASE is the system value that represents this semantic. Sign

[Mesa-dev] [PATCH 05/13] mesa: Document SYSTEM_VALUE_VERTEX_ID and SYSTEM_VALUE_INSTANCE_ID

From: Ian Romanick Signed-off-by: Ian Romanick Cc: "10.2" --- src/mesa/main/mtypes.h | 48 1 file changed, 48 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 3899e7f..34e66c9 100644 --- a/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 12/13] i965: If STATE_BASE_VERTEX is used, set its value

From: Ian Romanick Signed-off-by: Ian Romanick Cc: "10.2" --- src/mesa/drivers/dri/i965/brw_draw.c | 37 1 file changed, 37 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index ac21656..dd914b6 10064

[Mesa-dev] [PATCH 02/13] mesa/st: Only one copy of mesa_sysval_to_semantic

From: Ian Romanick Future patches will necessitate changes to the table, and I only want to update one. Signed-off-by: Ian Romanick Cc: Ilia Mirkin Cc: Marek Olšák Cc: Roland Scheidegger Cc: "10.2" --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 ++-- src/mesa/state_tracker/st_glsl_to_

[Mesa-dev] [PATCH 09/13] glsl/linker: Make get_main_function_signature public

From: Ian Romanick The next patch will use this function in a different file. Signed-off-by: Ian Romanick Cc: "10.2" --- src/glsl/linker.cpp | 9 + src/glsl/linker.h | 3 +++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp ind

[Mesa-dev] [PATCH 04/13] mesa: Group gl_system_value values by the stage where they exist

From: Ian Romanick Signed-off-by: Ian Romanick Cc: Ilia Mirkin Cc: Marek Olšák Cc: Roland Scheidegger Cc: "10.2" --- src/mesa/main/mtypes.h | 32 +++--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 +-- 2 files changed, 35 insertions(+)

[Mesa-dev] [PATCH 07/13] mesa: Add SYSTEM_VALUE_BASE_VERTEX

From: Ian Romanick This system value represents the basevertex value passed to glDrawElementsBaseVertex and related functions. Signed-off-by: Ian Romanick Cc: "10.2" --- src/mesa/main/mtypes.h | 15 ++- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + 2 files

Re: [Mesa-dev] [PATCH 08/11] glsl: Check calloc return value in link_intrastage_shaders()

On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote: > Check calloc return value while adding build-in functions. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/linker.cpp | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp > index 247

Re: [Mesa-dev] [PATCH 09/11] mesa/main: Verify calloc return value in register_surface()

Reviewed-by: Ian Romanick On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote: > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/main/vdpau.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/mesa/main/vdpau.c b/src/mesa/main/vdpau.c > index d974593..f1b3ece 100644 > --- a/sr

Re: [Mesa-dev] [PATCH 10/11] mesa/main: In register_surface() verify gl_texture_object was found

This is Reviewed-by: Ian Romanick but we should probably have someone familiar with that code also review it. Christian? On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote: > Verify _mesa_lookup_texture() returned valid pointer before using it. > > Signed-off-by: Juha-Pekka Heikkila > --- >

Re: [Mesa-dev] [PATCH 11/11] glx: Added missing null check in GetDrawableAttribute()

On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote: > For GLX_BACK_BUFFER_AGE_EXT query added extra null check. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/glx/glx_pbuffer.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/src/glx/glx_pbuffer.c b/src/gl

Re: [Mesa-dev] [PATCH v2 01/23] glsl: Add parsing support for multi-stream output in geometry shaders.

On Fri, 2014-06-20 at 10:46 -0700, Ian Romanick wrote: > I care a lot less about "what is often done" than I do about "what > should be done". If there is an argument to be made that stand-alone > comments (not on a line with other code) are better, that would be good > data to have. Well I'm n

[Mesa-dev] [Bug 80243] Mesa and libclc build failure after llvm >= llvm-3.5svn r211259

https://bugs.freedesktop.org/show_bug.cgi?id=80243 Iaroslav Andrusyak changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] Testing OpenCL with gegl

Hmm. I get GEGL_DEBUG=opencl ./run-compositions.py apply-lens.xml GEGL-gegl-cl-init.c-Message: [GEGL_DEBUG_OPENCL] gegl-cl-init.c:508: libOpenCL.so: 'clCreateFromGLTexture2D': /usr/lib/x86_64-linux-gnu/libOpenCL.so: undefined symbol: clCreateFromGLTexture2D GEGL-gegl-cl-init.c-Message: [GEGL_DEBUG