[Mesa-dev] [PATCH 1/2] mesa: Move TextureView layer error checks before dimension checking.

2014-03-20 Thread Kenneth Graunke
If the number of layers is invalid, we're supposed to return INVALID_VALUE. _mesa_legal_texture_dimensions detects some of these cases (i.e. number of layers not being divisible by 6 for cubes), but results in an INVALID_OPERATION error (which appears to be correct for more general dimension probl

[Mesa-dev] [PATCH 2/2] mesa: Don't minify depth for cube map arrays.

2014-03-20 Thread Kenneth Graunke
Minifying depth really only make sense for 3D textures. For 2D and Cube arrays, we don't want to minify it. Fixes oglconform's texture_view/basic.castTarget.cubeMapArray test, which called glTexStorage3D to set up a cube map array with 18 layers and 3 miplevels. We only allocated 9 slices for mi

Re: [Mesa-dev] [PATCH 7/8] mesa: Enable GL_ARG_query_buffer_object extension

2014-03-20 Thread Erik Faye-Lund
It seems the subject has a typo, and "ARG" -> "ARB" would be appropriate. On Wed, Mar 19, 2014 at 10:30 PM, Rafal Mielniczuk wrote: > Signed-off-by: Rafal Mielniczuk > --- > src/mesa/main/extensions.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/main/extensions.c b/src/mesa

Re: [Mesa-dev] [PATCH] nouveau: don't assume libdrm include prefix

2014-03-20 Thread Ilia Mirkin
On Wed, Mar 19, 2014 at 11:43 PM, Jonathan Gray wrote: > drm headers may be installed in a different directory I'm curious -- how can this happen? Looking at Makefile.am from drm:nouveau/Makefile.am: libdrm_nouveauincludedir = ${includedir}/libdrm libdrm_nouveauinclude_HEADERS = nouveau.h > > S

Re: [Mesa-dev] [PATCH] nouveau: use DLOPEN_LIBS instead of -ldl

2014-03-20 Thread Ilia Mirkin
On Wed, Mar 19, 2014 at 11:45 PM, Jonathan Gray wrote: > libdl does not exist on many platforms which have dlopen in libc. > > Signed-off-by: Jonathan Gray Reviewed-by: Ilia Mirkin > --- > src/gallium/drivers/nouveau/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH] nouveau: don't assume libdrm include prefix

2014-03-20 Thread Jonathan Gray
On Thu, Mar 20, 2014 at 07:29:32AM -0400, Ilia Mirkin wrote: > On Wed, Mar 19, 2014 at 11:43 PM, Jonathan Gray wrote: > > drm headers may be installed in a different directory > > I'm curious -- how can this happen? Looking at Makefile.am from > drm:nouveau/Makefile.am: > > libdrm_nouveauinclude

Re: [Mesa-dev] [PATCH] nouveau: don't assume libdrm include prefix

2014-03-20 Thread Ilia Mirkin
On Thu, Mar 20, 2014 at 7:57 AM, Jonathan Gray wrote: > On Thu, Mar 20, 2014 at 07:29:32AM -0400, Ilia Mirkin wrote: >> On Wed, Mar 19, 2014 at 11:43 PM, Jonathan Gray wrote: >> > drm headers may be installed in a different directory >> >> I'm curious -- how can this happen? Looking at Makefile.a

Re: [Mesa-dev] [PATCH] nouveau: don't assume libdrm include prefix

2014-03-20 Thread Jonathan Gray
On Thu, Mar 20, 2014 at 08:09:41AM -0400, Ilia Mirkin wrote: > On Thu, Mar 20, 2014 at 7:57 AM, Jonathan Gray wrote: > > On Thu, Mar 20, 2014 at 07:29:32AM -0400, Ilia Mirkin wrote: > >> On Wed, Mar 19, 2014 at 11:43 PM, Jonathan Gray wrote: > >> > drm headers may be installed in a different dire

Re: [Mesa-dev] [PATCH] nouveau: don't assume libdrm include prefix

2014-03-20 Thread Ilia Mirkin
On Thu, Mar 20, 2014 at 8:25 AM, Jonathan Gray wrote: > On Thu, Mar 20, 2014 at 08:09:41AM -0400, Ilia Mirkin wrote: >> On Thu, Mar 20, 2014 at 7:57 AM, Jonathan Gray wrote: >> > On Thu, Mar 20, 2014 at 07:29:32AM -0400, Ilia Mirkin wrote: >> >> On Wed, Mar 19, 2014 at 11:43 PM, Jonathan Gray wr

Re: [Mesa-dev] [PATCH] nouveau: don't assume libdrm include prefix

2014-03-20 Thread Jonathan Gray
On Thu, Mar 20, 2014 at 08:42:59AM -0400, Ilia Mirkin wrote: > On Thu, Mar 20, 2014 at 8:25 AM, Jonathan Gray wrote: > > On Thu, Mar 20, 2014 at 08:09:41AM -0400, Ilia Mirkin wrote: > >> On Thu, Mar 20, 2014 at 7:57 AM, Jonathan Gray wrote: > >> > On Thu, Mar 20, 2014 at 07:29:32AM -0400, Ilia Mi

Re: [Mesa-dev] [PATCH] nouveau: don't assume libdrm include prefix

2014-03-20 Thread Ilia Mirkin
On Thu, Mar 20, 2014 at 8:57 AM, Jonathan Gray wrote: > On Thu, Mar 20, 2014 at 08:42:59AM -0400, Ilia Mirkin wrote: >> On Thu, Mar 20, 2014 at 8:25 AM, Jonathan Gray wrote: >> > On Thu, Mar 20, 2014 at 08:09:41AM -0400, Ilia Mirkin wrote: >> >> On Thu, Mar 20, 2014 at 7:57 AM, Jonathan Gray wro

Re: [Mesa-dev] [PATCH 2/2] mesa: Don't minify depth for cube map arrays.

2014-03-20 Thread Marek Olšák
I had already done this in my Mesa patch: "[PATCH 3/9] mesa: fix software fallback for generating mipmaps for cube arrays" I will commit it shortly. Marek On Thu, Mar 20, 2014 at 10:18 AM, Kenneth Graunke wrote: > Minifying depth really only make sense for 3D textures. For 2D and Cube > array

Re: [Mesa-dev] OpenCL Image Support

2014-03-20 Thread Aditya Avinash
Hi Tom, Do I need to have an AMD GPU for compute images to R600? Thank you! On Tue, Mar 18, 2014 at 9:14 PM, Tom Stellard wrote: > On Mon, Mar 17, 2014 at 10:50:18PM -0400, Aditya Avinash wrote: > > Hi, > > I am a student. I have experience in OpenCL for 3 years. I would like to > > know what n

[Mesa-dev] [PATCH] egl/main: Fix eglMakeCurrent when releasing context from current thread.

2014-03-20 Thread Beren Minor
EGL 1.4 Specification says that eglMakeCurrent(display, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT) can be used to release the current thread's ownership on the surfaces and context. MESA's egl implementation was only accepting the parameters when the KHR_surfaceless_context extension is suppo

Re: [Mesa-dev] [PATCH] llvmpipe: Tighten check for alpha-only formats

2014-03-20 Thread Roland Scheidegger
Am 19.03.2014 18:12, schrieb Richard Sandiford: > The AoS version of ld_build_blend_factor was assuming that if the first > channel was alpha, there were no rgb components. > > Fixes glean/blendFunc on System z. No piglit regressions on x86_64. > The shortcut is still used in tests like spec/ARB_

[Mesa-dev] [PATCH 2/2] llvmpipe: add support for b5g6r5_srgb

2014-03-20 Thread sroland
From: Roland Scheidegger The conversion code for srgb was tuned for n x 4x8bit AoS -> 4 x nxfloat SoA (and vice versa), fix this to handle also 16bit 565-style srgb formats. Still not really all that generic, things like r10g10b10a2_srgb or r4g4b4a4_srgb wouldn't work (the latter trivial to fix,

[Mesa-dev] [PATCH 1/2] gallium: add b5g6r5 srgb format

2014-03-20 Thread sroland
From: Roland Scheidegger GL generally doesn't seem to allow srgb formats with less (or more) than 8 bit for the rgb channels, though some hw could easily do it (typically for formats with up to 10 bits for the rgb channels, at least for formats with less than 8 bits support is likely widespread e

Re: [Mesa-dev] [PATCH 1/2] radeon: Move r600_need_dma_space to common code

2014-03-20 Thread Marek Olšák
This looks good, thanks. I have pushed it with small modifications (e.g. context functions should be at the beginning of r600_pipe_common.c, screen functions should be at the end). Marek On Mon, Mar 17, 2014 at 6:48 PM, Niels Ole Salscheider wrote: > Signed-off-by: Niels Ole Salscheider > --- >

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: add support for b5g6r5_srgb

2014-03-20 Thread Jose Fonseca
Series looks good to me. Jose - Original Message - > From: Roland Scheidegger > > The conversion code for srgb was tuned for n x 4x8bit AoS -> 4 x nxfloat SoA > (and vice versa), fix this to handle also 16bit 565-style srgb formats. > Still not really all that generic, things like r10g1

[Mesa-dev] [PATCH 1/3] i965: Use the correct program when uploading Broadwell SOL state.

2014-03-20 Thread Kenneth Graunke
This is the equivalent of commit 43e77215b13b2f86e461cd8a62b542f. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_sol_state.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_sol_state.c b/src/mesa/drivers/dri/i965/gen8

[Mesa-dev] [PATCH 2/3] i965: Drop BRW_NEW_RASTERIZER_DISCARD flag from Broadwell SOL atom.

2014-03-20 Thread Kenneth Graunke
Nothing actually uses this---we handle rasterizer discard in the clipper in order for statistics counters to work. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_sol_state.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen8_sol_state.c b/src/me

[Mesa-dev] [PATCH 3/3] i965: Fix missing dirty bits in the gen8_sbe_state atom.

2014-03-20 Thread Kenneth Graunke
These are clearly needed---the comments in the function are even present for each one of them. I originally had two separate state atoms for 3DSTATE_SBE and 3DSTATE_SBE_SWIZ. When I combined the functions, I must have forgotten to add the atoms for 3DSTATE_SBE_SWIZ. Signed-off-by: Kenneth Graun

[Mesa-dev] [PATCH] mesa: In core profile, refuse to draw unless a VAO is bound.

2014-03-20 Thread Kenneth Graunke
Core profile requires a non-default VAO to be bound. Currently, calls to glVertexAttribPointer raise INVALID_OPERATION unless a VAO is bound, and we never actually get any vertex data set. Trying to draw without any vertex data can only cause problems. In i965, it causes a crash. Bugzilla: http

Re: [Mesa-dev] [PATCH 6/9] st/mesa: properly implement MapTextureImage with multiple mapped slices

2014-03-20 Thread Marek Olšák
On Mon, Mar 17, 2014 at 6:24 PM, Roland Scheidegger wrote: > Am 15.03.2014 18:17, schrieb Marek Olšák: >> From: Marek Olšák >> >> This is needed by _mesa_generate_mipmap. >> >> This adds an array of pipe_transfers to st_texture_image. Each transfer is >> for mapping a single layer. It's ugly, but

Re: [Mesa-dev] [PATCH 11/12] i965/vec4: Eliminate writes that are never read.

2014-03-20 Thread Eric Anholt
Matt Turner writes: > With an awful O(n^2) algorithm that searches previous instructions for > dead writes. > > total instructions in shared programs: 805582 -> 788074 (-2.17%) > instructions in affected programs: 144561 -> 127053 (-12.11%) > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 46

Re: [Mesa-dev] [PATCH 00/12] i965/vec4: Better dead code elimination.

2014-03-20 Thread Eric Anholt
Matt Turner writes: > total instructions in shared programs: 811813 -> 788004 (-2.93%) > instructions in affected programs: 185685 -> 161876 (-12.82%) > (this is only the .shader_test files. Our .vert files are useless) > > This series improves the dead code elimination pass in i965 > vec4 ba

[Mesa-dev] [Bug 74717] r600g: 'invalid read' linking geometry shader

2014-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74717 --- Comment #16 from Benjamin Bellec --- (In reply to comment #12) > I'm not able to reproduce it (tested with RV770 and CYPRESS) with current > master Mesa 10.2.0-devel (git-f74cf5f). Forget my comment about RV770, I realized I'm stuck to GL3.0

[Mesa-dev] [Bug 70599] [SNB/IVB/HSW Bisected]Piglit glx/GLX_ARB_create_context/current_with_no_framebuffer segfault

2014-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70599 ajax at nwnk dot net changed: What|Removed |Added Assignee|a...@nwnk.net |mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] nvc0/ir: move sample id to second source arg to fix sampler2DMS

2014-03-20 Thread Ilia Mirkin
The nvc0 texfetch instruction expects the sample id to be in the second source (usually used for the offset) rather than as part of the texture coordinate. This fixes all the sampler2DMS/Array tests on nvc0. Signed-off-by: Ilia Mirkin Cc: "10.1" --- Tested on nvc1 with a full piglit run, no re

[Mesa-dev] [Bug 72863] Weston-simple-egl fullscreening causes client application flicker

2014-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72863 U. Artie Eoff changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 72863] Weston-simple-egl fullscreening causes client application flicker

2014-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72863 U. Artie Eoff changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail

[Mesa-dev] Request for review of GSOC proposal

2014-03-20 Thread Aditya Avinash
Hi, Please provide me with the feedback of my GSOC proposal. http://www.google-melange.com/gsoc/proposal/public/google/gsoc2014/aatluri/5707702298738688 Thank you. -- Regards, *Atluri Aditya Avinash*, India. ___ mesa-dev mailing list mesa-dev@lists.fr

[Mesa-dev] [PATCH] i965: Drop BLT TexSubImage Y-tiling restriction on Gen6+.

2014-03-20 Thread Kenneth Graunke
Currently, we don't use this path on Sandybridge because we suspect other paths will be faster. But we potentially could. If we do, we should allow it to support Y-tiled BLTs. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 4 ++-- 1 file changed, 2 insertio