Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

2013-12-19 Thread Lauri Kasanen
On Wed, 18 Dec 2013 17:57:16 -0800 Matt Turner wrote: > On Tue, Dec 17, 2013 at 7:15 AM, Lauri Kasanen wrote: > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=72708 > > Make this "Bugzilla: ..." Sure, will do. But there are both conventions used, for example see: 0b16042377a 8bc7673ef87

Re: [Mesa-dev] [PATCH] radeonsi: Only scan pixel shaders for TGSI_PROPERTY_FS_COLOR0_WRITES_ALL_CBUFS

2013-12-19 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Dec 19, 2013 at 3:37 AM, Michel Dänzer wrote: > From: Michel Dänzer > > It's not relevant for other shader types. > > Signed-off-by: Michel Dänzer > --- > src/gallium/drivers/radeonsi/si_state.c | 11 +++ > 1 file changed, 7 insertions(+), 4 del

[Mesa-dev] [Bug 72877] New: Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72877 Priority: medium Bug ID: 72877 Assignee: mesa-dev@lists.freedesktop.org Summary: Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems Severity: normal Classifica

[Mesa-dev] [PATCH 1/3] glx: Fix two identical null check errors in driSet/GetInterval

2013-12-19 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri_glx.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c index 0b89e3e..2e00bf0 100644 --- a/src/glx/dri_glx.c +++ b/src/glx/dri_glx.c @@ -747,13 +747,15 @@ static int

[Mesa-dev] [PATCH 2/3] Mesa: Add asserts into emit_fog_instructions

2013-12-19 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/ff_fragment_shader.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 16715f6..6e91697 100644 --- a/src/mesa/main/ff_fragment_shader.cpp +++ b/src/mesa/m

[Mesa-dev] [PATCH 3/3] Mesa: Assert variable coming from get_variable() in get_current_attrib

2013-12-19 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/ff_fragment_shader.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 6e91697..ba6258d 100644 --- a/src/mesa/main/ff_fragment_shader.cpp +++ b/src/mesa/main

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

2013-12-19 Thread Kenneth Graunke
On 12/19/2013 01:50 AM, Lauri Kasanen wrote: [snip] > Gallium has a cpu detect function that includes a SSE 4.1 cap. Perhaps > you'd like to move it to a common area and make use of it for runtime > detection? Yes, that would be far better. The Mesa code has really rotted - it only does CPU detec

Re: [Mesa-dev] [PATCH 1/3] glx: Fix two identical null check errors in driSet/GetInterval

2013-12-19 Thread Brian Paul
On 12/19/2013 05:27 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri_glx.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c index 0b89e3e..2e00bf0 100644 --- a/src/glx/dri_glx.c +++

Re: [Mesa-dev] [PATCH 1/1] mesa: Add some convention to MESA_FORMATs with attention to PIPE_FORMATs

2013-12-19 Thread Brian Paul
On 12/18/2013 09:44 PM, Mark Mueller wrote: Though a large patch, this is simply a series of global search and replace operations. Please refer to formats.h for the core deltas. In summary this change adds UNORM, and UINT to formats where no type is given, as necessary; replaces the SIGNED design

Re: [Mesa-dev] [PATCH] Break instead of loop all paths once dri driver is gotten successfully

2013-12-19 Thread Brian Paul
On 12/18/2013 10:11 PM, Quanxian Wang wrote: Originally it will continue all paths. The next search will overwrite previous result even if the previous is successful. In some case it will cause error. Signed-off-by: Quanxian Wang Reviewed-By: Gong, Zhigang --- src/egl/drivers/dri2/egl_dri2.c

[Mesa-dev] [PATCH] glxgears: also print VisualID with -info option

2013-12-19 Thread Brian Paul
To help with debugging. --- src/xdemos/glxgears.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/xdemos/glxgears.c b/src/xdemos/glxgears.c index 2089715..54fbf97 100644 --- a/src/xdemos/glxgears.c +++ b/src/xdemos/glxgears.c @@ -477,7 +477,7 @@ no_border( Dis

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

2013-12-19 Thread Matt Turner
On Thu, Dec 19, 2013 at 1:50 AM, Lauri Kasanen wrote: > On Wed, 18 Dec 2013 17:57:16 -0800 > Matt Turner wrote: > >> On Tue, Dec 17, 2013 at 7:15 AM, Lauri Kasanen wrote: >> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=72708 >> >> Make this "Bugzilla: ..." > > Sure, will do. But there a

Re: [Mesa-dev] [PATCH] Break instead of loop all paths once dri driver is gotten successfully

2013-12-19 Thread Matt Turner
On Thu, Dec 19, 2013 at 8:34 AM, Brian Paul wrote: > On 12/18/2013 10:11 PM, Quanxian Wang wrote: >> >> Originally it will continue all paths. The next search will overwrite >> previous >> result even if the previous is successful. In some case it will cause >> error. >> >> Signed-off-by: Quanxian

Re: [Mesa-dev] [PATCH] llvmpipe: fix possible constant buffer overflow

2013-12-19 Thread Jose Fonseca
Looks great to me. - Original Message - > It's possible to bind a smaller buffer as a constant buffer, than > what the shader actually uses/requires. This could cause nasty > crashes. This patch adds the architecture to pass the maximum > allowable constant buffer index to the jit so let i

[Mesa-dev] [Bug 67676] Transparent windows no longer work

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67676 --- Comment #3 from Chad Versace --- I don't think there is anything fundamentally wrong with your proposed X11-specific hack. But, I think it's unwise to implement the hack. The amount of code and hackery needed---the implementation code in Mes

[Mesa-dev] [PATCH 1/5] r200: Sort list of enabled extensions

2013-12-19 Thread Ian Romanick
From: Ian Romanick Note that ARB_occlusion_query was previously enabled twice. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/r200/r200_context.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/r200/r200_context.c b/s

[Mesa-dev] [PATCH 2/5] radeon: Sort list of enabled extensions

2013-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/radeon/radeon_context.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_context.c b/src/mesa/drivers/dri/radeon/radeon_context.c index c8b997b..cc1e62f 100

[Mesa-dev] [PATCH 4/5] mesa: Clean up bad code formatting left from previous commit

2013-12-19 Thread Ian Romanick
From: Ian Romanick Also s/_EXT// on enums that are now part of core. This could probably be squashed with the previous commit when it is pushed. Signed-off-by: Ian Romanick --- src/mesa/main/fbobject.c | 20 +--- src/mesa/main/glformats.c | 2 +- src/mesa/main/teximage.c |

Re: [Mesa-dev] [PATCH 06/23] i965: Define common register base class shared between both back-ends.

2013-12-19 Thread Paul Berry
On 2 December 2013 11:31, Francisco Jerez wrote: > diff --git a/src/mesa/drivers/dri/i965/brw_shader.h > b/src/mesa/drivers/dri/i965/brw_shader.h > index ff5af93..f284389 100644 > --- a/src/mesa/drivers/dri/i965/brw_shader.h > +++ b/src/mesa/drivers/dri/i965/brw_shader.h > @@ -23,6 +23,7 @@ > >

[Mesa-dev] [PATCH 5/5] mesa: It is not possible to have GLSL < 1.20

2013-12-19 Thread Ian Romanick
From: Ian Romanick This hasn't been possible for a long time. Signed-off-by: Ian Romanick --- src/mesa/main/getstring.c | 2 -- src/mesa/main/version.c | 1 - 2 files changed, 3 deletions(-) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index d818911..b66e247 100644 ---

[Mesa-dev] [PATCH 3/5] mesa: GL_EXT_packed_depth_stencil is not optional

2013-12-19 Thread Ian Romanick
From: Ian Romanick Every driver supports it. All current and future Gallium drivers always support it, and all existing classic drivers support it. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_extensions.c | 1 - src/mesa/drivers/dri/i965/intel_extensions.c | 1 - src

[Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags, v2

2013-12-19 Thread Lauri Kasanen
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72708 Signed-off-by: Lauri Kasanen --- configure.ac| 6 m4/ax_check_compile_flag.m4 | 72 + src/mesa/Makefile.am| 6 +++- 3 files changed, 83 insertions(+), 1 deletio

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72877 Lauri Kasanen changed: What|Removed |Added CC||cur...@operamail.com --- Comment #1 from

Re: [Mesa-dev] [PATCH 1/5] r200: Sort list of enabled extensions

2013-12-19 Thread Brian Paul
On 12/19/2013 12:39 PM, Ian Romanick wrote: From: Ian Romanick Note that ARB_occlusion_query was previously enabled twice. Signed-off-by: Ian Romanick For the series: Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 68296] Using old viewport value after a window resize (content is clipped)

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=68296 U. Artie Eoff changed: What|Removed |Added Version|git |9.2 -- You are receiving this mail beca

Re: [Mesa-dev] [PATCH 1/7] i965: Include brw_reg.h in brw_disasm.c.

2013-12-19 Thread Eric Anholt
Kenneth Graunke writes: > We're going to move some things from brw_defines.h there in a moment. > Both files contain symbols named negate, so we need to arbitrarily > rename them. (The "m_" prefix is a convention I adopted in the Gen8+ > code). I think maybe series rewrites may have made this p

[Mesa-dev] [Bug 72889] New: wayland/weston EGL/GLESv2 client corruption/flicker on r600 mesa-10.x

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72889 Priority: medium Bug ID: 72889 Assignee: wayland-b...@lists.freedesktop.org Summary: wayland/weston EGL/GLESv2 client corruption/flicker on r600 mesa-10.x QA Contact: mesa-dev@

[Mesa-dev] [Bug 72890] New: wayland/weston EGL/GLESv2 client corruption+flicker on mesa-10.x r600

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72890 Priority: medium Bug ID: 72890 Assignee: wayland-b...@lists.freedesktop.org Summary: wayland/weston EGL/GLESv2 client corruption+flicker on mesa-10.x r600 QA Contact: mesa-dev@

[Mesa-dev] [Bug 72890] wayland/weston EGL/GLESv2 client corruption+flicker on mesa-10.x r600

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72890 --- Comment #1 from U. Artie Eoff --- Possibly related to Bug 72863 and/or Bug 72854? -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@lis

[Mesa-dev] [Bug 72889] wayland/weston EGL/GLESv2 client corruption/flicker on r600 mesa-10.x

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72889 --- Comment #1 from Alex Deucher --- Can you bisect? -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.f

[Mesa-dev] [Bug 72890] wayland/weston EGL/GLESv2 client corruption+flicker on mesa-10.x r600

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72890 Alex Deucher changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 72889] wayland/weston EGL/GLESv2 client corruption/flicker on r600 mesa-10.x

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72889 --- Comment #3 from Alex Deucher --- Possibly related to Bug 72863 and/or Bug 72854? -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@list

[Mesa-dev] [Bug 72889] wayland/weston EGL/GLESv2 client corruption/flicker on r600 mesa-10.x

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72889 --- Comment #2 from Alex Deucher --- *** Bug 72890 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 06/23] i965: Define common register base class shared between both back-ends.

2013-12-19 Thread Francisco Jerez
Paul Berry writes: > On 2 December 2013 11:31, Francisco Jerez wrote: > >> diff --git a/src/mesa/drivers/dri/i965/brw_shader.h >> b/src/mesa/drivers/dri/i965/brw_shader.h >> index ff5af93..f284389 100644 >> --- a/src/mesa/drivers/dri/i965/brw_shader.h >> +++ b/src/mesa/drivers/dri/i965/brw_shade

[Mesa-dev] [PATCH 01/16] i965: Print reg_offset for vgrf of size > 1 in dump_instruction().

2013-12-19 Thread Matt Turner
Previously we wouldn't print the +0 for the first part of a VGRF of size greater than 1. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 +++--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/

[Mesa-dev] [PATCH 00/16] i965/fs: Bunch of new optimizations

2013-12-19 Thread Matt Turner
Series adds some new optimization passes and adds new capabilities to the existing register_coalesce pass. Short description of patches: i965: Print reg_offset for vgrf of size > 1 in dump_instruction(). Useful for spotting vgrfs of size > 1 in instruction dumps. i965/fs: Fix the example abou

[Mesa-dev] [PATCH 03/16] mesa: Add STRINGIFY macro.

2013-12-19 Thread Matt Turner
--- src/mesa/main/macros.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/macros.h b/src/mesa/main/macros.h index 379f756..dafeaa3 100644 --- a/src/mesa/main/macros.h +++ b/src/mesa/main/macros.h @@ -809,5 +809,7 @@ DIFFERENT_SIGNS(GLfloat x, GLfloat y) /* Compute the size of

[Mesa-dev] [PATCH 02/16] i965/fs: Fix the example about overwriting uniforms in SIMD16.

2013-12-19 Thread Matt Turner
mov takes only a single source argument. Example instruction inexplicably changed from add to mov in commit f10f5e49. --- src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_live_variabl

[Mesa-dev] [PATCH 09/16] i965/fs: Calculate interference better in register_coalesce.

2013-12-19 Thread Matt Turner
Previously we simply considered two registers whose live ranges overlapped to interfere. Cases such as set A -- ... | mov B, A --| ... | B | A use B --| ... | use A -- would be considered to interfere, even though B

[Mesa-dev] [PATCH 05/16] i965/fs: Add a comment explaining how register coalescing works.

2013-12-19 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 1e6ffbc..1a16f4e 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cp

[Mesa-dev] [PATCH 15/16] i965: Dump the register pressure!

2013-12-19 Thread Matt Turner
From: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 14 ++ src/mesa/drivers/dri/i965/brw_fs.h | 1 + src/mesa/drivers/dri/i965/brw_shader.h | 2 +- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/dri

[Mesa-dev] [PATCH 10/16] i965/fs: Call opt_peephole_sel later in the optimization loop.

2013-12-19 Thread Matt Turner
Calling it after value numbering (added in the next commit) prevents some instruction count regressions. total instructions in shared programs: 1524387 -> 1523905 (-0.03%) instructions in affected programs: 13112 -> 12630 (-3.68%) GAINED:0 LOST:

[Mesa-dev] [PATCH 14/16] i965: Compute the number of live registers at each IP.

2013-12-19 Thread Matt Turner
From: Kenneth Graunke Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 18 ++ src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1 + 3 files changed, 22 insertions(+) diff --git a/src/mesa/dri

[Mesa-dev] [PATCH 06/16] i965/fs: Assert that var < num_vars.

2013-12-19 Thread Matt Turner
Helped to track down a problem in a version of the next commit. --- src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp b/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp index a29767d..a2

[Mesa-dev] [PATCH 08/16] i965/fs: Don't search in vain for uses of dead channels.

2013-12-19 Thread Matt Turner
Improves three programs in Unigine Tropics. total instructions in shared programs: 1549880 -> 1549868 (-0.00%) instructions in affected programs: 858 -> 846 (-1.40%) --- src/mesa/drivers/dri/i965/brw_fs.cpp | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff -

[Mesa-dev] [PATCH 07/16] i965/fs: Support coalescing registers of size > 1.

2013-12-19 Thread Matt Turner
total instructions in shared programs: 1550048 -> 1549880 (-0.01%) instructions in affected programs: 1896 -> 1728 (-8.86%) --- src/mesa/drivers/dri/i965/brw_fs.cpp | 80 ++-- 1 file changed, 58 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 13/16] i965/fs: Add a saturation propagation optimization pass.

2013-12-19 Thread Matt Turner
Transforms, for example, mul vgrf3, vgrf2, vgrf1 mov.sat vgrf4, vgrf3 into mul.sat vgrf3, vgrf2, vgrf1 mov vgrf4, vgrf3 which gives register_coalescing an opportunity to remove the MOV instruction. total instructions in shared programs: 1512588 -> 1501297 (-0.75%) instructions in affec

[Mesa-dev] [PATCH 16/16] i965/fs: Print the maximum register pressure.

2013-12-19 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 606e21a..e1edd0f 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 12/16] i965: Add can_do_saturate() method to backend_instruction.

2013-12-19 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_shader.cpp | 44 src/mesa/drivers/dri/i965/brw_shader.h | 1 + 2 files changed, 45 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index ddb4524..b33c1f8 100644 --

[Mesa-dev] [PATCH 04/16] i965/fs: Add and use MAX_SAMPLER_MESSAGE_SIZE definition.

2013-12-19 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.h| 2 ++ src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 3 ++- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 10 ++ 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/me

[Mesa-dev] [PATCH 11/16] i965/fs: Add local value numbering optimization pass.

2013-12-19 Thread Matt Turner
total instructions in shared programs: 1520829 -> 1511991 (-0.58%) instructions in affected programs: 559725 -> 550887 (-1.58%) GAINED:6 LOST: 9 --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 1/1] Adjust MESA_FORMAT color component ordering to match API docs

2013-12-19 Thread Mark Mueller
No piglit regressions on i965, or autotools based build regressions on ilo,nouveau,r300,r600 were observed as a result of these changes. Mark On Thu, Dec 19, 2013 at 1:56 PM, Mark Mueller wrote: > Adjust MESA_FORMAT color component ordering to match API docs, driver > specific formats (e.g. PIP

Re: [Mesa-dev] [PATCH 08/23] i965/fs: Add support for specifying register horizontal strides.

2013-12-19 Thread Paul Berry
On 2 December 2013 11:31, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 29 > +++--- > src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ > .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 7 +- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 06/23] i965: Define common register base class shared between both back-ends.

2013-12-19 Thread Paul Berry
On 19 December 2013 13:30, Francisco Jerez wrote: > Paul Berry writes: > > > On 2 December 2013 11:31, Francisco Jerez wrote: > > > >> diff --git a/src/mesa/drivers/dri/i965/brw_shader.h > >> b/src/mesa/drivers/dri/i965/brw_shader.h > >> index ff5af93..f284389 100644 > >> --- a/src/mesa/drivers

Re: [Mesa-dev] [PATCH 08/23] i965/fs: Add support for specifying register horizontal strides.

2013-12-19 Thread Francisco Jerez
Paul Berry writes: >[...] > In v2 of this patch, you add the following code to > fs_visitor::try_copy_propagate(): > > + /* Bail if the result of composing both strides cannot be expressed > +* as another stride. > +*/ > + if (entry->src.stride != 1 && > + (inst->src[arg].stride

[Mesa-dev] [PATCH] glsl: Fix condition to generate shader link error

2013-12-19 Thread Anuj Phogat
GL_ARB_ES2_compatibility don't say anything about shader linking when one of the shaders (vertex or fragment shader) is absent. So, the extention shouldn't change the behavior specified in GLSL specification. Tested the behavior on proprietary linux drivers of NVIDIA and AMD. Both of them allow li

Re: [Mesa-dev] [PATCH 14/16] i965: Compute the number of live registers at each IP.

2013-12-19 Thread Kenneth Graunke
On 12/19/2013 01:40 PM, Matt Turner wrote: > From: Kenneth Graunke > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 18 ++ > src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1 + > 3

[Mesa-dev] [PATCH] scons: Add system library linker flags on LLVM 3.5.

2013-12-19 Thread Vinson Lee
llvn-3.5svn r197664 split out the linker flags from ldflags to system-libs. Signed-off-by: Vinson Lee --- scons/llvm.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scons/llvm.py b/scons/llvm.py index 8388d8e..6282cb5 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -202,6 +202,8 @@ de

[Mesa-dev] [PATCH 1/2] glcpp: Add a more descriptive comment for the SKIP state manipulation

2013-12-19 Thread Carl Worth
Two things make this code confusing: 1. The uncharacteristic manipulation of lexer start state outside of flex rules. 2. The confusing semantics of the skip_stack (including the "lexing_if" override and the SKIP_NO_SKIP state). This new comment is intended t

[Mesa-dev] [PATCH 2/2] glcpp: Replace multi-line comment with a space (even as part of macro definition)

2013-12-19 Thread Carl Worth
The preprocessor has always replaced multi-line comments with a single space character, (as required by the specification), but as of commit bd55ba568b301d0f764cd1ca015e84e1ae932c8b the lexer also emitted a NEWLINE token for each newline within the comment, (in order to preserve line numbers). The

Re: [Mesa-dev] [PATCH 2/2] glcpp: Replace multi-line comment with a space (even as part of macro definition)

2013-12-19 Thread Carl Worth
Carl Worth writes: > Given those considerations, and given that the SKIP-state manipulation already > involves a code block at the top of the lexer function, before any rules, it > seems best to me to go with the implementation here which adds a similar > pre-rule code block for the NEWLINE_CATCHU

Re: [Mesa-dev] [PATCH 2/2] glcpp: Replace multi-line comment with a space (even as part of macro definition)

2013-12-19 Thread Kenneth Graunke
On 12/19/2013 04:25 PM, Carl Worth wrote: [snip] > diff --git a/src/glsl/glcpp/tests/063-comments.c.expected > b/src/glsl/glcpp/tests/063-comments.c.expected > index 73ca707..1965c9b 100644 > --- a/src/glsl/glcpp/tests/063-comments.c.expected > +++ b/src/glsl/glcpp/tests/063-comments.c.expected >

Re: [Mesa-dev] [PATCH 1/1] Adjust MESA_FORMAT color component ordering to match API docs

2013-12-19 Thread Michel Dänzer
On Don, 2013-12-19 at 13:56 -0800, Mark Mueller wrote: > Adjust MESA_FORMAT color component ordering to match API docs, driver > specific formats (e.g. PIPE_FORMATs), Actually, there are a couple of examples of other format definitions which match the Mesa formats before your change but no longer

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

2013-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #2 from Michel Dänzer --- This is probably due to commit 2151d893fbd4a4be092098170e2fbca8c35797a5 ('gallium: Fix llvmpipe on big-endian machines'). The r600g driver needs to be adapted for the changed PIPE_FORMAT_* semantics. -- You

Re: [Mesa-dev] [PATCH 1/1] R600: Allow ftrunc

2013-12-19 Thread Tom Stellard
On Wed, Dec 18, 2013 at 04:50:53PM -0500, Jan Vesely wrote: > v2: Add ftrunc->TRUNC pattern instead of replacing int_AMDGPU_trunc > v3: move ftrunc pattern next to TRUNC definition, it's available since R600 > I've pushed this patch, thanks! I forgot to remind you to add a test case, so I added