Carl Worth <cwo...@cworth.org> writes: > Given those considerations, and given that the SKIP-state manipulation already > involves a code block at the top of the lexer function, before any rules, it > seems best to me to go with the implementation here which adds a similar > pre-rule code block for the NEWLINE_CATCHUP.
Since, apparently, that commit message wasn't long enough already, I just amended my commit locally to add: Finally, this commit also changes the expected output of a few, existing glcpp tests. The change here is that the space character resulting from the multi-line comment is now emitted before the newlines corresponding to that comment. (Previously, the newlines were emitted first, and the space character afterward.) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72686 The updates to these tests do look a bit odd if you just read the patch. I've tried to review those whitespace-only patch hunks fairly carefully, but don't take my word for it. -Carl
pgp4lIgTn1CBs.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
