Re: [Mesa-dev] [PATCH 1/5] glsl: Add support for separate reference Z for shadow samplers

2013-10-11 Thread Chris Forbes
>As a follow-on, maybe fold _textureCubeArrayShadow() into this function now that it has support for a separate comparitor parameter? Yeah, I'll take a look at that. On Fri, Oct 11, 2013 at 7:56 PM, Kenneth Graunke wrote: > On 10/10/2013 12:21 AM, Chris Forbes wrote: >> ARB_gpu_shader5's texture

Re: [Mesa-dev] [PATCH] radeonsi: pass alpha_ref value to PS in the user sgpr

2013-10-11 Thread Christian König
Am 11.10.2013 01:15, schrieb Marek Olšák: On Thu, Oct 10, 2013 at 6:38 PM, Vadim Girlin wrote: On 10/10/2013 08:10 PM, Christian König wrote: Am 10.10.2013 18:02, schrieb Vadim Girlin: On 10/10/2013 02:11 PM, Michel Dänzer wrote: On Don, 2013-10-10 at 12:49 +0400, Vadim Girlin wrote: Curren

Re: [Mesa-dev] [PATCH] glcpp: error on multiple #else directives

2013-10-11 Thread Erik Faye-Lund
On Mon, Sep 23, 2013 at 11:02 PM, Erik Faye-Lund wrote: > On Mon, Sep 23, 2013 at 10:35 PM, Erik Faye-Lund wrote: >> The preprocessor currently eats multiple #else directives >> int the same #if(def) ... #endif block. While I haven't been able >> to find anything that explicitly disallows it, it'

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-11 Thread Mike Lothian
Well done on getting this enabled Out of interest how far is SandyBridge from 3.2? Cheers Mike On 11 Oct 2013 05:28, "Paul Berry" wrote: > It's been a long and rocky road, but geometry shader support in Mesa's > i965/gen7 driver has finally reached a point I'm willing to call > "feature comple

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Emil Velikov
On 07/10/13 18:53, Emil Velikov wrote: > On 07/10/13 16:48, Tom Stellard wrote: >> On Sat, Sep 28, 2013 at 03:46:21PM +0100, Emil Velikov wrote: >>> Use PKG_CHECK_MODULE over requesting the user to setup the >>> option at configure time. Drop unused EXPAT_INCLUDE and add >>> EXPAT_CFLAGS to all cla

[Mesa-dev] [PATCH] llvmpipe: increase fs shader variant instruction cache limit by factor 4

2013-10-11 Thread sroland
From: Roland Scheidegger The previous limit of of 128*1024 was reported to cause frequent recompiles in some apps due to shader variant thrashing on IRC in some apps leading to noticeable lags. Note that the LP_MAX_SHADER_VARIANTS limit (1024) was more or less impossible to reach, since even simp

[Mesa-dev] [glsl] indvar in ir_loop

2013-10-11 Thread Liu Xin
Hi, Mesa developers, According to glsl v1.0, we have loop construct: for (for-init-statement; condition(opt); expression) statement-no-new-scope Variables declared in for-init-statement or condition are only in scope until the end of the statement-no-new-scope of the for loop. let's assume I

Re: [Mesa-dev] [PATCH] llvmpipe: increase fs shader variant instruction cache limit by factor 4

2013-10-11 Thread Brian Paul
On 10/11/2013 07:11 AM, srol...@vmware.com wrote: From: Roland Scheidegger The previous limit of of 128*1024 was reported to cause frequent recompiles in some apps due to shader variant thrashing on IRC in some apps leading to noticeable lags. Note that the LP_MAX_SHADER_VARIANTS limit (1024) w

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-11 Thread Brian Paul
On 10/10/2013 10:27 PM, Paul Berry wrote: It's been a long and rocky road, but geometry shader support in Mesa's i965/gen7 driver has finally reached a point I'm willing to call "feature complete". Since geometry shaders were the last remaining feature needed for GL 3.2, it's time to turn on GL

Re: [Mesa-dev] [PATCH 1/2] r600/uvd: fix mapping of UVD surfaces for readback

2013-10-11 Thread Marek Olšák
On Wed, Oct 9, 2013 at 10:19 PM, Grigori Goronzy wrote: > R600_RESOURCE_FLAG_TRANSFER forces direct mapping, and reading from > VRAM is simply too slow. VDPAU GetBitsYCbCr is unusuable. Change to > the new PIPE_BIND_LINEAR and adjust r600_transfer_map so that it uses > a staging texture. > --- >

[Mesa-dev] [PATCH] radeonsi: Do not set both inreg and byval

2013-10-11 Thread Vincent Lejeune
--- src/gallium/drivers/radeonsi/radeonsi_shader.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c index ab996cc..209b77e 100644 --- a/src/gallium/drivers/radeonsi/radeonsi

Re: [Mesa-dev] [PATCH] r600g: fix crash in set_framebuffer_state

2013-10-11 Thread Marek Olšák
Pushed, thanks. Marek On Fri, Oct 11, 2013 at 1:23 AM, Grigori Goronzy wrote: > We should be able to safely set the framebuffer state without a > fragment shader bound. bind_ps_state will take care of updating the > necessary state bits later. > > v2: check in update_db_shader_control > --- > s

[Mesa-dev] [Bug 70378] New: fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 Priority: medium Bug ID: 70378 Assignee: mesa-dev@lists.freedesktop.org Summary: fatal error: xmlpool/options.h: No such file or directory Severity: normal Classification

Re: [Mesa-dev] [PATCH] llvmpipe: increase fs shader variant instruction cache limit by factor 4

2013-10-11 Thread Roland Scheidegger
Am 11.10.2013 16:21, schrieb Brian Paul: > On 10/11/2013 07:11 AM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> The previous limit of of 128*1024 was reported to cause frequent >> recompiles >> in some apps due to shader variant thrashing on IRC in some apps leading >> to noticeable

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 --- Comment #1 from Emil Velikov --- Created attachment 87471 --> https://bugs.freedesktop.org/attachment.cgi?id=87471&action=edit set HAVE_COMMON_DRI when building plain classic swrast Damn, should have noticed this when I did the fix for bug

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 Emil Velikov changed: What|Removed |Added CC||emil.l.veli...@gmail.com,

[Mesa-dev] [PATCH] configure: set HAVE_COMMON_DRI when building plain classic swrast

2013-10-11 Thread Emil Velikov
Commit d81632fb1(dri: Merge drisw_util.c into dri_util.c) unified the dri and drisw util code, but forgot to set HAVE_COMMON_DRI. Thus the translations for driconf (that drisw now depends on) were not built, leading to a build errors. This is the equivalent for classic dri drivers of commit 757ec7

[Mesa-dev] [PATCH] nv50: report only 16 texure_samplers

2013-10-11 Thread Emil Velikov
Current mesa code(cso and drivers) expect and use only up-to 16 texture samplers. Verbatum copy from the nvc0 driver. Cc "9.1" Cc "9.2" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70212 Reported-by: Aaron Watry Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nv50/nv50_

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 --- Comment #2 from Fabio Pedretti --- The patch doesn't fix the issue, new log here: https://launchpadlibrarian.net/153514663/buildlog_ubuntu-raring-i386.mesa_9.3~git1310111821.3de7e1%2Bglvdpau~gd~r_FAILEDTOBUILD.txt.gz -- You are receiving th

[Mesa-dev] PATCH: R600: Fix crash in AMDILCFGStructurizer

2013-10-11 Thread Tom Stellard
Hi, The attached patches fix a crash in the AMDILCFGStructurizer. The first patch does some code cleanup and the second patch actually fixes the crash. -Tom >From 8a95058178eba343cb6ee408677b42329e7069ed Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Fri, 11 Oct 2013 09:18:22 -0700 Subject:

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Francisco Jerez
Kenneth Graunke writes: > On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: >> >> In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 >> >> This breaks everything on our end (missing rtti related symbols) in our >> C++ libGL.so as Haiku uses dynamic casts. >> >> We build our

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 --- Comment #3 from Emil Velikov --- Interesting, the attached patch will resolve build failure when configured with $ ./autogen.sh --with-dri-drivers=swrast --with-gallium-drivers= $ make Fabio Pedretti, what configure flags you're using ? --

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 Emil Velikov changed: What|Removed |Added CC|e...@anholt.net | -- You are receiving this mail because:

[Mesa-dev] [PATCH] i965: add XRGB to fast texture upload

2013-10-11 Thread Courtney Goeltzenleuchter
MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms of storage on the device, so okay to use this optimized copy routine. --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_sub

[Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-11 Thread Courtney Goeltzenleuchter
Support all levels of a supported texture format. --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965/intel_tex_subimage.c index 4aec05d..5e

[Mesa-dev] [PATCH] clover: Link libclc before running any optimizations

2013-10-11 Thread Tom Stellard
From: Tom Stellard This is required in order for clang to correctly handle the OpenCL C barrier() builtin which has the following restrictions acording to the OpenCL 1.1 Specification: If barrier is inside a conditional statement, then all work-items must enter the conditional if any work-item e

[Mesa-dev] [PATCH] r600g/compute Improve debugging output

2013-10-11 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/r600/compute_memory_pool.c | 8 +--- src/gallium/drivers/r600/evergreen_compute.c | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_po

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 --- Comment #4 from Fabio Pedretti --- It builds with: ../../configure --prefix=/usr --mandir=\${prefix}/share/man \ --infodir=\${prefix}/share/info --sysconfdir=/etc \ --libdir=\${prefix}/lib/i386-linux-gnu \

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-11 Thread Paul Berry
On 11 October 2013 05:43, Mike Lothian wrote: > Well done on getting this enabled > > Out of interest how far is SandyBridge from 3.2? > I believe geometry shaders are all we would have to implement for Sandy Bridge. Unfortunately, geometry shaders work pretty differently on Sandy Bridge, so ge

[Mesa-dev] [PATCH] R600: Make sure OQAP defs and uses happen in the same clause

2013-10-11 Thread Tom Stellard
From: Tom Stellard Reading the special OQAP register pops the top value off the LDS input queue and returns it to the instruction. This queue is invalidated at the end of an ALU clause and leaving values in the queue can lead to GPU hangs. This means that if we load a value into the queue, we m

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Alexander von Gluck IV
On Fri, 11 Oct 2013 09:50:08 -0700 Francisco Jerez wrote: > Kenneth Graunke writes: > > > On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: > >> > >> In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 > >> > >> This breaks everything on our end (missing rtti related symbol

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Kenneth Graunke
On 10/11/2013 09:50 AM, Francisco Jerez wrote: > Kenneth Graunke writes: > >> On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: >>> >>> In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 >>> >>> This breaks everything on our end (missing rtti related symbols) in our >>> C++ li

[Mesa-dev] [PATCH 1/6] glsl: When constructing a variable with an interface type, set interface_type

2013-10-11 Thread Ian Romanick
From: Ian Romanick Ever since the addition of interface blocks with instance names, we have had an implicit invariant: var->type->is_interface() == (var->type == var->interface_type) A similar invariant exists if var->type->fields.array->is_interface(). However, the ir_variable constructor

[Mesa-dev] [PATCH 2/6] glsl/tests: Verify vertex shader built-ins generated by _mesa_glsl_initialize_variables

2013-10-11 Thread Ian Romanick
From: Ian Romanick Checks that the variables generated meet certain criteria. - Vertex shader inputs have an explicit location. - Vertex shader outputs have an explicit location. - Fragment shader-only varying locations are not used. - Vertex shader uniforms and system values don't have a

Re: [Mesa-dev] [PATCH] i965: add XRGB to fast texture upload

2013-10-11 Thread Kenneth Graunke
On 10/11/2013 10:16 AM, Courtney Goeltzenleuchter wrote: > MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms > of storage on the device, so okay to use this optimized copy routine. > --- > src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 ++- > 1 file changed, 2 insertions(+),

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-11 Thread Kenneth Graunke
On 10/11/2013 10:17 AM, Courtney Goeltzenleuchter wrote: > Support all levels of a supported texture format. > --- > src/mesa/drivers/dri/i965/intel_tex_subimage.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.

[Mesa-dev] [PATCH] mesa: fix transform feedback when a geometry shader is active.

2013-10-11 Thread Paul Berry
From: Bryan Cain When a geometry shader is active, the transform feedback primitive type ("mode") needs to be validated against the geometry shader output primitive type, not the primitive type passed to the glDraw*() function. Fixes the following piglit tests: - glsl-1.50-geometry-primitive-typ

[Mesa-dev] [PATCH 5/6] glsl/tests: Unit test vertex shader in / out with link_invalidate_variable_locations

2013-10-11 Thread Ian Romanick
From: Ian Romanick This required fixing the out-of-date prototype in linker.h. While making that change, further change the prototype to make unit testing a bit easier. Validates: - ir_variable::explicit_location should not be modified. - If ir_variable::location is not a generic location

[Mesa-dev] [PATCH 4/6] glsl/tests: Verify geometry shader built-ins generated by _mesa_glsl_initialize_variables

2013-10-11 Thread Ian Romanick
From: Ian Romanick Checks that the variables generated meet certain criteria. - Geometry shader inputs have an explicit location. - Geometry shader outputs have an explicit location. - Fragment shader-only varying locations are not used. - Geometry shader uniforms and system values don't

[Mesa-dev] [PATCH 3/6] glsl/tests: Verify fragment shader built-ins generated by _mesa_glsl_initialize_variables

2013-10-11 Thread Ian Romanick
From: Ian Romanick Checks that the variables generated meet certain criteria. - Fragment shader inputs have an explicit location. - Fragment shader outputs have an explicit location. - Vertex / geometry shader-only varying locations are not used. - Fragment shader uniforms and system valu

[Mesa-dev] [PATCH 6/6] glsl: Simplify the interface to link_invalidate_variable_locations

2013-10-11 Thread Ian Romanick
From: Ian Romanick The unit tests added in the previous commits prove some things about the state of some internal data structures. The most important of these is that all built-in input and output variables have explicit_location set. This means that link_invalidate_variable_locations doesn't

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-11 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick On 10/10/2013 09:27 PM, Paul Berry wrote: > It's been a long and rocky road, but geometry shader support in Mesa's > i965/gen7 driver has finally reached a point I'm willing to call > "feature complete". Since geometry shaders were the last remaining > featur

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-11 Thread Eric Anholt
Abdiel Janulgue writes: > On Thursday, October 10, 2013 01:04:08 PM Eric Anholt wrote: >> >> My basic comment on resource streamer: We need performance data showing >> that it is a win before we commit it. I'm not planning on reviewing the >> changes until we get that data. > > At it's current

Re: [Mesa-dev] [PATCH] mesa: fix transform feedback when a geometry shader is active.

2013-10-11 Thread Kenneth Graunke
On 10/11/2013 11:28 AM, Paul Berry wrote: > From: Bryan Cain > > When a geometry shader is active, the transform feedback primitive > type ("mode") needs to be validated against the geometry shader output > primitive type, not the primitive type passed to the glDraw*() > function. Reviewed-by: K

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Francisco Jerez
Kenneth Graunke writes: > On 10/11/2013 09:50 AM, Francisco Jerez wrote: >> Kenneth Graunke writes: >> >>> On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 This breaks everything on our end (missing rtti

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Francisco Jerez
Alexander von Gluck IV writes: > On Fri, 11 Oct 2013 09:50:08 -0700 > Francisco Jerez wrote: > >> Kenneth Graunke writes: >> >> > On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: >> >> >> >> In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 >> >> >> >> This breaks every

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Kenneth Graunke
On 10/11/2013 11:45 AM, Francisco Jerez wrote: > Kenneth Graunke writes: > >> On 10/11/2013 09:50 AM, Francisco Jerez wrote: >>> Kenneth Graunke writes: >>> On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: > > In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 >

Re: [Mesa-dev] [PATCH] configure: set HAVE_COMMON_DRI when building plain classic swrast

2013-10-11 Thread Matt Turner
On Fri, Oct 11, 2013 at 9:19 AM, Emil Velikov wrote: > Commit d81632fb1(dri: Merge drisw_util.c into dri_util.c) unified the > dri and drisw util code, but forgot to set HAVE_COMMON_DRI. Thus the > translations for driconf (that drisw now depends on) were not built, > leading to a build errors. >

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Matt Turner
On Sat, Sep 28, 2013 at 7:46 AM, Emil Velikov wrote: > Use PKG_CHECK_MODULE over requesting the user to setup the > option at configure time. Drop unused EXPAT_INCLUDE and add > EXPAT_CFLAGS to all classic/dri and gallium/dri targets. > > Signed-off-by: Emil Velikov > --- > configure.ac

Re: [Mesa-dev] Mesa (master): i965/fs: Convert gen7 to using GRFs for texture messages.

2013-10-11 Thread Eric Anholt
Chia-I Wu writes: > Hi Eric, > The frame rate of Unigine Tropics (with low shader quality) dropped > from 40.8 to 23.5 after this change. Thanks for the note. I see the regression as well, and I see a shader that's started spilling. It looks like we can drop the regs_written <= 1 check on gen7

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Francisco Jerez
Kenneth Graunke writes: > On 10/11/2013 11:45 AM, Francisco Jerez wrote: >> Kenneth Graunke writes: >> >>> On 10/11/2013 09:50 AM, Francisco Jerez wrote: Kenneth Graunke writes: > On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: >> >> In llvm.py -fno-rtti is always a

Re: [Mesa-dev] [PATCH] configure: set HAVE_COMMON_DRI when building plain classic swrast

2013-10-11 Thread Emil Velikov
On 11/10/13 19:59, Matt Turner wrote: > On Fri, Oct 11, 2013 at 9:19 AM, Emil Velikov > wrote: >> Commit d81632fb1(dri: Merge drisw_util.c into dri_util.c) unified the >> dri and drisw util code, but forgot to set HAVE_COMMON_DRI. Thus the >> translations for driconf (that drisw now depends on) w

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 --- Comment #5 from Emil Velikov --- I have to admit that build log was a bit too "inspiring" for me. I got bored half way though the list of downloading and installing all the dependencies :) Anywho, the issue reported seems different from the

Re: [Mesa-dev] [PATCH] configure: set HAVE_COMMON_DRI when building plain classic swrast

2013-10-11 Thread Matt Turner
On Fri, Oct 11, 2013 at 12:25 PM, Emil Velikov wrote: > On 11/10/13 19:59, Matt Turner wrote: >> I think now that xf86drm.h's include is protected by __NOT_HAVE_DRM_H >> we can now just drop HAVE_COMMON_DRI entirely. Right? >> > Sounds like a plan, with a minor side effect that you'll be building

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-11 Thread Jordan Justen
On Fri, Oct 11, 2013 at 11:04 AM, Paul Berry wrote: > On 11 October 2013 05:43, Mike Lothian wrote: >> >> Well done on getting this enabled >> >> Out of interest how far is SandyBridge from 3.2? > > I believe geometry shaders are all we would have to implement for Sandy > Bridge. Unfortunately,

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Tom Stellard
On Fri, Oct 11, 2013 at 02:09:57PM +0100, Emil Velikov wrote: > On 07/10/13 18:53, Emil Velikov wrote: > > On 07/10/13 16:48, Tom Stellard wrote: > >> On Sat, Sep 28, 2013 at 03:46:21PM +0100, Emil Velikov wrote: > >>> Use PKG_CHECK_MODULE over requesting the user to setup the > >>> option at confi

Re: [Mesa-dev] [PATCH 04/14] glx: Add an optional function call for getting the DRI driver interface.

2013-10-11 Thread Eric Anholt
Matt Turner writes: > On Mon, Sep 30, 2013 at 1:44 PM, Eric Anholt wrote: >> The previous interface relied on a static struct, which meant tha the >> driver didn't get a chance to edit the struct before the struct got used. >> For megadrivers, I want to return a variable struct based on what dri

Re: [Mesa-dev] [PATCH 09/14] nouveau: Build the driver into the shared mesa_dri_drivers.so.

2013-10-11 Thread Eric Anholt
Matt Turner writes: > On Mon, Sep 30, 2013 at 1:44 PM, Eric Anholt wrote: >> diff --git a/src/mesa/drivers/dri/Makefile.am >> b/src/mesa/drivers/dri/Makefile.am >> index 9d15c43..6152fcc 100644 >> --- a/src/mesa/drivers/dri/Makefile.am >> +++ b/src/mesa/drivers/dri/Makefile.am >> @@ -27,6 +27,8

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 Emil Velikov changed: What|Removed |Added Attachment #87471|0 |1 is obsolete|

[Mesa-dev] [PATCH] i965/gs: Set the REORDER bit in 3DSTATE_GS.

2013-10-11 Thread Paul Berry
Ivy Bridge's "reorder enable" bit gives us a binary choice for the order in which vertices from triangle strips are delivered to the geometry shader. Neither choice follows the OpenGL spec, but setting the bit is better, because it gets triangle orientation correct. Haswell replaces the "reorder

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-11 Thread Chad Versace
Paul, nice work! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glcpp: error on multiple #else directives

2013-10-11 Thread Ian Romanick
Carl, Can you look at this patch and Erik's follow-up patch? You (still) know the glcpp much better than any of the rest of us. (Carl is currently out of town, so I know his response will be slow...) Thanks. On 09/23/2013 01:35 PM, Erik Faye-Lund wrote: > The preprocessor currently eats multip

[Mesa-dev] [PATCH 1/2] vbo: Make vbo_sw_primitive_restart optionally count primitives.

2013-10-11 Thread Paul Berry
This will be necessary in order to get the i965 back-end to produce the correct value of gl_PrimitiveIDIn when using software primitive restart. --- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 2 +- src/mesa/vbo/vbo.h| 3 ++- src/mesa/vbo/vbo_exec_array.c

[Mesa-dev] [PATCH 2/2] i965/gs: Fix gl_PrimitiveIDIn when using SW primitive restart.

2013-10-11 Thread Paul Berry
Ivy Bridge hardware doesn't support primitve restart under all circumstances--when it doesn't, we emulate it in software by splitting up each logical draw operation into multiple 3DPRIMITIVE commands. This causes the hardware's primitive ID counter to be reset to 0, producing incorrect values for g

[Mesa-dev] [PATCH] i965/fs: Remove bogus field prog_data->dispatch_width.

2013-10-11 Thread Paul Berry
Despite the name, this field wasn't being set to the dispatch width at all; it was always 8. The only place it was used was that the constant buffer read length was aligned to it, and as far as I can tell from the docs, there is no need to align this value to the dispatch width; aligning it to a m

[Mesa-dev] [PATCHv2 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Emil Velikov
Use PKG_CHECK_MODULE over requesting the user to setup the option at configure time. Drop unused EXPAT_INCLUDE and update all targets. NOTE: This commit removes the --with-expat configure option. One should ensure that the expat they wish to use has expat.pc file accessible by pkg-config. v2: * A

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Emil Velikov
On 11/10/13 20:09, Matt Turner wrote: > On Sat, Sep 28, 2013 at 7:46 AM, Emil Velikov > wrote: >> Use PKG_CHECK_MODULE over requesting the user to setup the >> option at configure time. Drop unused EXPAT_INCLUDE and add >> EXPAT_CFLAGS to all classic/dri and gallium/dri targets. >> >> Signed-off-

Re: [Mesa-dev] [PATCH] i965/gs: Set the REORDER bit in 3DSTATE_GS.

2013-10-11 Thread Matt Turner
On Fri, Oct 11, 2013 at 1:27 PM, Paul Berry wrote: > Ivy Bridge's "reorder enable" bit gives us a binary choice for the > order in which vertices from triangle strips are delivered to the > geometry shader. Neither choice follows the OpenGL spec, but setting > the bit is better, because it gets t

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Emil Velikov
On 11/10/13 20:44, Tom Stellard wrote: > On Fri, Oct 11, 2013 at 02:09:57PM +0100, Emil Velikov wrote: >> On 07/10/13 18:53, Emil Velikov wrote: >>> On 07/10/13 16:48, Tom Stellard wrote: On Sat, Sep 28, 2013 at 03:46:21PM +0100, Emil Velikov wrote: > Use PKG_CHECK_MODULE over requesting t

Re: [Mesa-dev] [glsl] indvar in ir_loop

2013-10-11 Thread Ian Romanick
On 10/10/2013 11:14 PM, Liu Xin wrote: > Hi, Mesa developers, > > According to glsl v1.0, we have loop construct: > for (for-init-statement; condition(opt); expression) > statement-no-new-scope > > Variables declared in for-init-statement or condition are only in scope > until the end of the > st

Re: [Mesa-dev] Documentation plan: request for comments

2013-10-11 Thread Chad Versace
On 10/10/2013 01:38 AM, Rogovin, Kevin wrote: Hello all, My current goal is to add documentation to Mesa so that the ramp up time of Mesa goes down a great deal. I support that goal. When I see other projects that publish good Doxygen documentation, like http://llvm.org/doxygen/modules.ht

Re: [Mesa-dev] [PATCH] i965/gs: Set the REORDER bit in 3DSTATE_GS.

2013-10-11 Thread Paul Berry
On 11 October 2013 14:13, Matt Turner wrote: > On Fri, Oct 11, 2013 at 1:27 PM, Paul Berry > wrote: > > Ivy Bridge's "reorder enable" bit gives us a binary choice for the > > order in which vertices from triangle strips are delivered to the > > geometry shader. Neither choice follows the OpenGL

Re: [Mesa-dev] [PATCH 1/2] mesa: Define introspection macro to determine whether a type is trivially destructible.

2013-10-11 Thread Ian Romanick
The minor nit in both patches: The closing */ of a multiline comment should go on its own line. I'd like to hear some feedback from Paul and / or Ken before committing, but this series is Reviewed-by: Ian Romanick On 10/09/2013 11:20 AM, Francisco Jerez wrote: > Only implemented on GCC and Cla

[Mesa-dev] [PATCH] r600g: fix tgsi_op2_s with trans-only instructions

2013-10-11 Thread Vadim Girlin
This fixes the issue when dst and src is the same reg and operation on one channel overwrites the source for other channels, e.g.: UMUL TEMP[2].xyz, TEMP[0].xyzz, TEMP[2]. In this example the result of the operation on channel x is written in TEMP[2].x and then used as a second source operand

Re: [Mesa-dev] [PATCH 1/3] just change doxy-directory

2013-10-11 Thread Chad Versace
On 10/07/2013 11:00 PM, Kevin Rogovin wrote: really change the doxygen files swrast, tnl and tnl_dd added In the commit message, please explain what the patch is tries to accomplish and how it accomplishes it. Also, each patch should do just one thing. This patch should be separated into one t

[Mesa-dev] Doxygen published online, updated every 4 hours

2013-10-11 Thread Chad Versace
Tom asked me to do this, and it should also help Kevin. I am building Mesa's Doxygen from master every four hours and publishing it here: http://people.freedesktop.org/~chadversary/mesa/doxygen/ It doesn't look very nice. It's incomplete. It's not cross-referenced as well as it should be. If it

[Mesa-dev] [PATCH 00/18] Implement GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
This is the completion of some work that I started back in February after FOSDEM. *blush* http://www.paranormal-entertainment.com/idr/blog/posts/2013-02-07T22:42:53Z-FOSDEM2013_Presentation/ Basically, this add a method for applications to query various aspects of the GL implementation *before* c

[Mesa-dev] [PATCH 01/18] dri: Add interface definition for DRI_RENDERER_QUERY extension

2013-10-11 Thread Ian Romanick
From: Ian Romanick This will be used to let apps query hardware and driver limits before creating a GL context. Signed-off-by: Ian Romanick --- include/GL/internal/dri_interface.h | 29 + 1 file changed, 29 insertions(+) diff --git a/include/GL/internal/dri_interfa

[Mesa-dev] [PATCH 03/18] i965: Refactor the vendor string out of intelGetString

2013-10-11 Thread Ian Romanick
From: Ian Romanick This will soon be used in intel_screen.c from a function that doesn't have a gl_context. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/intel_context.c | 3 ++- src/mesa/drivers/dri/i965/intel_context.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 02/18] i915: Refactor the vendor string out of intelGetString

2013-10-11 Thread Ian Romanick
From: Ian Romanick This will soon be used in intel_screen.c from a function that doesn't have a gl_context. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_context.c | 3 ++- src/mesa/drivers/dri/i915/intel_context.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 05/18] i965: Refactor the renderer string creation out of intelGetString

2013-10-11 Thread Ian Romanick
From: Ian Romanick This will soon be used in intel_screen.c from a function that doesn't have a gl_context. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/intel_context.c | 37 +++ src/mesa/drivers/dri/i965/intel_context.h | 2 ++ 2 files changed, 25 ins

[Mesa-dev] [PATCH 04/18] i915: Refactor the renderer string creation out of intelGetString

2013-10-11 Thread Ian Romanick
From: Ian Romanick This will soon be used in intel_screen.c from a function that doesn't have a gl_context. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_context.c | 34 +++ src/mesa/drivers/dri/i915/intel_context.h | 2 ++ 2 files changed, 23 ins

[Mesa-dev] [PATCH 06/18] dri: Add function to implement queries common to all Mesa drivers

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/common/utils.c | 62 + src/mesa/drivers/dri/common/utils.h | 3 ++ 2 files changed, 65 insertions(+) diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/drivers/dri/common/util

[Mesa-dev] [PATCH 07/18] i915: Wire up initial support for DRI_RENDERER_QUERY extension

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_screen.c | 79 1 file changed, 79 insertions(+) diff --git a/src/mesa/drivers/dri/i915/intel_screen.c b/src/mesa/drivers/dri/i915/intel_screen.c index 4f8c342..fa4fdc0 100644 --

[Mesa-dev] [PATCH 08/18] i965: Wire up initial support for DRI_RENDERER_QUERY extension

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/intel_screen.c | 81 1 file changed, 81 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index b6b4275..e8a0323 100644 --

[Mesa-dev] [PATCH 09/18] glx: Add extension tracking GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glx/glxextensions.c | 1 + src/glx/glxextensions.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/glx/glxextensions.c b/src/glx/glxextensions.c index 7b00a9e..f186c13 100644 --- a/src/glx/glxextensions.c +++ b/src/glx/glxextensio

[Mesa-dev] [PATCH 10/18] glx: Add GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick THESE ARE JUST PLACEHOLDER VALUES. DO NOT SHIP!!! Signed-off-by: Ian Romanick --- include/GL/glx.h | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/include/GL/glx.h b/include/GL/glx.h index 87c31fd..234abc0 100644 --- a/include

[Mesa-dev] [PATCH 11/18] glx: Add functions and GLX plumbing for GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glx/Makefile.am | 1 + src/glx/glxclient.h | 7 +- src/glx/glxcmds.c| 6 ++ src/glx/query_renderer.c | 173 +++ 4 files changed, 186 insertions(+), 1 deletion(-) create mo

[Mesa-dev] [PATCH 13/18] glx/dri2: Pull some internal structures out to a separate header file

2013-10-11 Thread Ian Romanick
From: Ian Romanick This structures will be accessed by internal functions that will be added in a file separate from dri2_glx.c. The new code will be added to a new file to facilitate unit testing. Signed-off-by: Ian Romanick --- src/glx/dri2_glx.c | 21 + src/glx/dri2_pr

[Mesa-dev] [PATCH 12/18] glx/tests: Silence warnings after adding fields to glx_screen_vtable

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glx/tests/fake_glx_screen.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/glx/tests/fake_glx_screen.cpp b/src/glx/tests/fake_glx_screen.cpp index 845084f..7ee9b82 100644 --- a/src/glx/tests/fake_glx_scre

[Mesa-dev] [PATCH 15/18] docs: Import extension spec for GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick The enumerated values are currently allocated from Intel's range. Signed-off-by: Ian Romanick --- docs/MESA_query_renderer.spec | 381 ++ 1 file changed, 381 insertions(+) create mode 100644 docs/MESA_query_renderer.spec diff --git a

[Mesa-dev] [PATCH 14/18] glx/dri2: Add DRI2 support for GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick The new functions for this extension were added to a separate file (dri2_query_renderer.c) to facilitate unit testing. I tried putting them in dri2_glx.c, and it resulting in an unending chain of dependencies. It was the proverbial threading hanging from a sweater. Signed-of

[Mesa-dev] [PATCH 16/18] glx/tests: Add GetGLXScreenConfigs_called flag

2013-10-11 Thread Ian Romanick
From: Ian Romanick Tests for the GLX_MESA_query_context extension will use this flag. Signed-off-by: Ian Romanick --- src/glx/tests/create_context_unittest.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/tests/create_context_unittest.cpp b/src/glx/tests/create_context_unit

[Mesa-dev] [PATCH 17/18] glx/tests: Add unit tests for the GLX part of GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick These tests primarilly ensure that the functions added by this extension don't abuse other interfaces (e.g., glx_screen::query_renderer_integer) when provided bad data. These tests helped me find a couple small bugs in the initial implementation. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 18/18] glx/tests: Add unit tests for the DRI2 part of GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick After adding $(DEFINES) to AM_CPPFLAGS, the __glXGetCurrentContext wrapper function is no longer needed and causes compile errors. Using the correct defines causes it to be a macro! Signed-off-by: Ian Romanick --- src/glx/tests/Makefile.am | 4 +

[Mesa-dev] [PATCH 1/2] configure.ac: Don't check for cross compiling.

2013-10-11 Thread Matt Turner
Dead since c845140a. --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 0d082d2..5faae97 100644 --- a/configure.ac +++ b/configure.ac @@ -1959,8 +1959,6 @@ AM_CONDITIONAL(HAVE_X86_ASM, echo "$DEFINES" | grep 'X86_ASM' >/dev/null 2>&1) AM_CONDI

[Mesa-dev] [PATCH 2/2] configure.ac: Don't check for awk, grep, nm.

2013-10-11 Thread Matt Turner
Not used since d53901c6. --- configure.ac | 12 1 file changed, 12 deletions(-) diff --git a/configure.ac b/configure.ac index 5faae97..c68e14b 100644 --- a/configure.ac +++ b/configure.ac @@ -1256,19 +1256,7 @@ dnl dnl XA configuration dnl if test "x$enable_xa" = xyes; then -AC_P

[Mesa-dev] [Bug 69437] Composite Bypass no longer works

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69437 Kristian Høgsberg changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] i965/fs: Remove bogus field prog_data->dispatch_width.

2013-10-11 Thread Eric Anholt
Paul Berry writes: > Despite the name, this field wasn't being set to the dispatch width at > all; it was always 8. The only place it was used was that the > constant buffer read length was aligned to it, and as far as I can > tell from the docs, there is no need to align this value to the > dis

[Mesa-dev] [PATCH] configure.ac: drop obsolete variable HAVE_COMMON_DRI

2013-10-11 Thread Emil Velikov
The original intent of the variable was to prevent adding libdrm dependency for non drm drivers (swrast). This is already handled with __NOT_HAVE_DRM_H, and with the recent merge of the dri_util and drisw_util code this variable has started causing build issues. Eg. the following will fail $ ./aut

  1   2   >