[Mesa-dev] [PATCH] tgsi: finish declaration parsing for arrays.

2013-08-12 Thread Dave Airlie
From: Dave Airlie I previously fixed this partly in 9e8400f4c95bde1f955c7977066583b507159a10, however I didn't go far enough in testing it, now when I parse a TGSI shader with arrays in it my iterator can see the ArrayID set to the proper value. Signed-off-by: Dave Airlie --- src/gallium/auxil

Re: [Mesa-dev] [PATCH 12/20] radeonsi: implement MSAA colorbuffer compression for rendering

2013-08-12 Thread Michel Dänzer
On Sam, 2013-08-10 at 18:31 +0200, Marek Olšák wrote: > v2: simplify flushing in si_context_flush Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___

Re: [Mesa-dev] [PATCH] radeonsi: scanout buffers cannot be a destination of MSAA resolve

2013-08-12 Thread Michel Dänzer
On Sam, 2013-08-10 at 18:53 +0200, Marek Olšák wrote: > Resolving to scanout buffers just doesn't work. Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer _

[Mesa-dev] [PATCH 2/3] i965/gen7: Set MOCS L3 cacheability for IVB/BYT

2013-08-12 Thread ville . syrjala
From: Ville Syrjälä IVB/BYT also has the same L3 cacheability control in MOCS as HSW, so let's make use of it. pts/xonotic and pts/reaction @ 1920x1080 gain ~4% on my IVB GT2. Most other things show less gains/no regressions, except furmark which loses some 10 points. I didn't have a BYT at han

[Mesa-dev] [PATCH 1/3] i965/hsw: Populate MOCS for STATE_BASE_ADDRESS

2013-08-12 Thread ville . syrjala
From: Ville Syrjälä Juse spotted these unpopulated MOCS fields when comparing the code against BSpec. No idea if this makes any difference anywhere, or if it even makes any sense. Signed-off-by: Ville Syrjälä --- src/mesa/drivers/dri/i965/brw_misc_state.c | 4 +++- src/mesa/drivers/dri/i965/ge

[Mesa-dev] [PATCH 3/3] i965/gen7: Don't use L3$ for render targets

2013-08-12 Thread ville . syrjala
From: Ville Syrjälä According to HSW Bspec L3$ evictions may land in LLC regardless of LLC MOCS/PTE settings. That means we shouldn't set scanout buffers as L3 cacheable when writing to them. So far I've been unable to observe this phenomenon on my IVB, but better safe than sorry. Especially sin

[Mesa-dev] [PATCH 1/3] glsl/ast: Check that geometry shader interface block inputs are arrays.

2013-08-12 Thread Paul Berry
--- src/glsl/ast_to_hir.cpp | 13 + 1 file changed, 13 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index c06051f..e91e260 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -4495,6 +4495,19 @@ ast_interface_block::hir(exec_list *inst

[Mesa-dev] [PATCH 3/3] glsl/ast: Don't perform GS input array checks on non-inputs.

2013-08-12 Thread Paul Berry
Previously, we were accidentally calling handle_geometry_shader_input_decl() on non-input interface block declarations, resulting in bogus error checking. --- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.c

[Mesa-dev] [PATCH 2/3] glsl/ast: Fix assertion failure when GS input declared as non-array.

2013-08-12 Thread Paul Berry
Previously, if a geometry shader input was declared as a non-array, we would flag the proper compiler error, but then before we got a chance to report it to the client, handle_geometry_shader_input_decl() would assertion fail. With this patch, handle_geometry_shader_input_decl() ignores non-arrays

Re: [Mesa-dev] [PATCH] tgsi: finish declaration parsing for arrays.

2013-08-12 Thread Brian Paul
On 08/12/2013 01:38 AM, Dave Airlie wrote: From: Dave Airlie I previously fixed this partly in 9e8400f4c95bde1f955c7977066583b507159a10, however I didn't go far enough in testing it, now when I parse a TGSI shader with arrays in it my iterator can see the ArrayID set to the proper value. Signe

Re: [Mesa-dev] segfault in pstip_bind_sampler_states

2013-08-12 Thread Brian Paul
On 08/09/2013 01:50 PM, Kevin H. Hobbs wrote: On 08/09/2013 01:59 PM, Brian Paul wrote: That's probably not it, given the above. Can you try setting a breakpoint on pstip_destroy() and see if that's getting called before the segfault? If so, things are getting freed in the wrong order. No,

Re: [Mesa-dev] [PATCH 1/2] st/xorg: set the SCANOUT flag for all pixmaps

2013-08-12 Thread Michel Dänzer
On Sam, 2013-08-10 at 00:23 +0200, Marek Olšák wrote: > Any pixmap can potentially end up as a scanout buffer, right? > > This fixes a whole-screen corruption with radeonsi, which needs a different > texture layout for scanout textures. > --- > src/gallium/state_trackers/xorg/xorg_exa.c | 2 +- >

Re: [Mesa-dev] [PATCH 2/2] radeonsi: don't make scanout resources linear except for cursors

2013-08-12 Thread Michel Dänzer
On Sam, 2013-08-10 at 00:23 +0200, Marek Olšák wrote: > The surface allocator understands the scanout flag just fine. > > This seems to improve performance for Ubuntu Unity on top of st/xorg > and it fixes the cursor. > --- > src/gallium/drivers/radeonsi/r600_texture.c | 2 +- > 1 file changed, 1

[Mesa-dev] [Bug 67962] undefined reference to `wayland_drm_buffer_get'

2013-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67962 --- Comment #4 from U. Artie Eoff --- (In reply to comment #3) > (In reply to comment #2) > > I've sent a fix today > > > > http://lists.freedesktop.org/archives/mesa-dev/2013-August/043097.html > > Discard this, I've sent a v2 patch today whic

[Mesa-dev] [PATCH 1/2] gallivm: simplify geometry shader mask handling a bit

2013-08-12 Thread sroland
From: Roland Scheidegger Instead of reducing masks to 0/1 simply use the mask directly as -1. Also use some signed comparison instead of unsigned (as far as I understand these values have to be (very) small and signed means llvm doesn't have to apply additional logic to do the unsigned comparison

[Mesa-dev] [PATCH 2/2] draw: simplify prim mask construction

2013-08-12 Thread sroland
From: Roland Scheidegger The code was quite weird, the second comparison was in fact a complete no-op and we can also do the comparison with the vector directly instead of scalar, which should not also be faster but it is way more obvious how that mask is actually going to look like. (Not sure ho

[Mesa-dev] [PATCH] gallivm: simplify geometry shader mask handling a bit

2013-08-12 Thread sroland
From: Roland Scheidegger Instead of reducing masks to 0/1 simply use the mask directly as -1. Also use some signed comparison instead of unsigned (as far as I understand these values have to be (very) small and signed means llvm doesn't have to apply additional logic to do the unsigned comparison

Re: [Mesa-dev] [PATCH mesa 3/3] egl: Update to Wayland 1.2 server API

2013-08-12 Thread Kristian Høgsberg
On Wed, Aug 7, 2013 at 1:27 PM, Ian Romanick wrote: > On 08/07/2013 10:39 AM, Kristian Høgsberg wrote: >> >> On Thu, Jul 18, 2013 at 03:11:25PM +0300, Ander Conselvan de Oliveira >> wrote: >>> >>> Since Wayland 1.2, struct wl_buffer and a few functions are deprecated. >>> >>> References to wl_buff

Re: [Mesa-dev] [PATCH mesa 3/3] egl: Update to Wayland 1.2 server API

2013-08-12 Thread Kristian Høgsberg
On Fri, Aug 9, 2013 at 10:44 AM, Mike Lothian wrote: > Hi > > I seem to have a missing symbol wayland_drm_buffer_get in libgbm.so.1 > > I'm pretty sure its related No, it's a different issue: https://bugs.freedesktop.org/show_bug.cgi?id=67962 Kristian > Regards > > Mike > > On 18 Jul 2013 13:15

Re: [Mesa-dev] [PATCH] meta: Fix blitting a framebuffer with renderbuffer attachment

2013-08-12 Thread Anuj Phogat
On Mon, Aug 5, 2013 at 3:00 PM, Anuj Phogat wrote: > > This patch fixes a case of framebuffer blitting with renderbuffer > as color attachment and GL_LINEAR filter. Meta implementation of > glBlitFrambuffer() converts source color buffer to a texture and > uses it to do the scaled blitting in to d

Re: [Mesa-dev] segfault in pstip_bind_sampler_states

2013-08-12 Thread Kevin H. Hobbs
On 08/12/2013 10:29 AM, Brian Paul wrote: > Can you run with valgrind? That should give us some useful info if > there's a use-after-free. Sure, $ valgrind /home/kevin/kitware/VTK_OSMesa_Build/bin/vtkpython "--enable-bt" "/home/kevin/kitware/VTK_OSMesa_Build/Utilities/vtkTclTest2Py/rtImageTest.

[Mesa-dev] [PATCH] r600g, radeonsi: set/get the scanout flag using the set/get_tiling ioctls

2013-08-12 Thread Marek Olšák
--- src/gallium/drivers/r300/r300_state.c | 2 +- src/gallium/drivers/r300/r300_texture.c | 4 ++-- src/gallium/drivers/r600/r600_texture.c | 13 - src/gallium/drivers/radeonsi/r600_texture.c | 13 - src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 12

Re: [Mesa-dev] [PATCH 4/6] i965/fs: Optimize IF/MOV/ELSE/MOV/ENDIF to SEL when possible.

2013-08-12 Thread Kenneth Graunke
On 08/07/2013 03:45 PM, Ian Romanick wrote: On 08/05/2013 06:28 PM, Kenneth Graunke wrote: [snip] + *(+f0) IF + *MOV dst src0 + *ELSE + *MOV dst src1 + *ENDIF Do we see many cases of foo = batman; if (condition) foo = robin; I haven't seen many cases

Re: [Mesa-dev] [PATCH] gallivm: simplify geometry shader mask handling a bit

2013-08-12 Thread Zack Rusin
> From: Roland Scheidegger > > Instead of reducing masks to 0/1 simply use the mask directly as -1. > Also use some signed comparison instead of unsigned (as far as I understand > these values have to be (very) small and signed means llvm doesn't have to > apply additional logic to do the unsigne

[Mesa-dev] [PATCH] gallivm: fix exec_mask interaction with geometry shader after end of main

2013-08-12 Thread sroland
From: Roland Scheidegger Because we must maintain an exec_mask even if there's currently nothing on the mask stack, we can still have an exec_mask at the end of the program. Effectively, this mask should be set back to default when returning from main. Without relying on END/RET opcode (I think i

Re: [Mesa-dev] [PATCH 2/2] draw: simplify prim mask construction

2013-08-12 Thread Zack Rusin
Looks good. Reviewed-by: Zack Rusin - Original Message - > From: Roland Scheidegger > > The code was quite weird, the second comparison was in fact a complete no-op > and we can also do the comparison with the vector directly instead of scalar, > which should not also be faster but it

Re: [Mesa-dev] [PATCH] gallivm: fix exec_mask interaction with geometry shader after end of main

2013-08-12 Thread Zack Rusin
Ah, that looks like a great catch. Reviewed-by: Zack Rusin - Original Message - > From: Roland Scheidegger > > Because we must maintain an exec_mask even if there's currently nothing > on the mask stack, we can still have an exec_mask at the end of the program. > Effectively, this mask

Re: [Mesa-dev] [PATCH 1/6] i965/fs: Log a performance warning if skipping 16-wide due to pulls.

2013-08-12 Thread Matt Turner
On Mon, Aug 5, 2013 at 6:28 PM, Kenneth Graunke wrote: > Usually, the driver creates both 8-wide and 16-wide variants of every > fragment shader. When 16-wide compilation fails, it logs a performance > warning explaining why only an 8-wide program exists. > > However, when there are pull paramete

[Mesa-dev] [PATCH 01/15] i965/fs: Skip global copy propagation step.

2013-08-12 Thread Kenneth Graunke
The dataflow analysis used for global copy propagation is severely broken, and I believe it doesn't actually do anything. Fixing it will require a lot of changes, each of which might break things. Once all the fixes land, we can re-enable this. Signed-off-by: Kenneth Graunke --- src/mesa/drive

[Mesa-dev] [PATCH 02/15] i965/fs: Don't kill ACP entries due to their generating instruction.

2013-08-12 Thread Kenneth Graunke
fs_copy_prop_dataflow::setup_kills() walks through each basic block's instructions, looking for instructions which overwrite registers used in ACP entries. This would be fine, except that it didn't exclude the instructions which generated the ACP entries in the first place. This meant that every

[Mesa-dev] [PATCH 03/15] i965/fs: Switch to a do-while loop in copy propagation dataflow.

2013-08-12 Thread Kenneth Graunke
The fixed-point algorithm needs to run at least once, so a do-while loop is more natural. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propa

[Mesa-dev] [PATCH 04/15] i965/fs: Rename "cont" to "progress" in dataflow algorithm.

2013-08-12 Thread Kenneth Graunke
This variable indicates that the fixed-point algorithm made changes to the data at this step, so it needs to run for another iteration. "progress" seems a nicer name for that. --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-

[Mesa-dev] [PATCH 05/15] i965/fs: Separate the updating of liveout/livein.

2013-08-12 Thread Kenneth Graunke
To compute the actual liveout/livein data flow values, we start with some initial values and apply a fixed-point algorithm until they settle. Previously, we iterated through all blocks, updating both liveout and livein together in one pass. This is awkward, since computing livein for a block requ

[Mesa-dev] i965 global copy propagation fixes

2013-08-12 Thread Kenneth Graunke
Hello, This surprisingly large series fixes bugs in the data flow algorithm for copy propagation. As far as I can tell, there were a myriad of issues. The updated algorithm seems to follow the textbook and online materials much more closely. No Piglit regressions on Ivybridge. shader-db statis

[Mesa-dev] [PATCH 06/15] i965/fs: Rename setup_kills() to setup_initial_values().

2013-08-12 Thread Kenneth Graunke
Although this function currently only initializes the KILL set, it will soon initialize other data flow sets as well. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 07/15] i965/fs: Create the COPY() set for use in copy propagation dataflow.

2013-08-12 Thread Kenneth Graunke
This is the "COPY" set from Muchnick's textbook, which is necessary to do the dataflow algorithm correctly. Signed-off-by: Kenneth Graunke --- .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 27 ++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/src/mesa/d

[Mesa-dev] [PATCH 08/15] i965/fs: Simplify liveout calculation.

2013-08-12 Thread Kenneth Graunke
Excluding the existing liveout bits is a deviation from the textbook algorithm. The reason for doing so was to determine if the value changed, which means the fixed-point algorithm needs to run for another iteration. The simpler way to do that is to save the value from step (N-1) and compare it t

[Mesa-dev] [PATCH 09/15] i965/fs: Use the COPY set in the calculation for liveout.

2013-08-12 Thread Kenneth Graunke
According to page 360 of the textbook, the proper formula for liveout is: CPout(n) = COPY(i) union (CPin(i) - KILL(i)) Previously, we omitted COPY. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 10/15] i965/fs: Properly initialize the livein/liveout sets.

2013-08-12 Thread Kenneth Graunke
Previously, livein was initialized to 0 for all blocks. According to the textbook, it should be the universal set (~0) for all blocks except the one representing the start of the program (which should be 0). liveout also needs to be initialized to COPY for the initial block. Signed-off-by: Kenne

[Mesa-dev] [PATCH 11/15] i965/fs: Drop unnecessary and incorrect liveout initialization.

2013-08-12 Thread Kenneth Graunke
The previous commit properly initialized liveout. This previous (and incorrect) initialization is no longer necessary. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_cop

[Mesa-dev] [PATCH 12/15] i965/fs: Skip the initial block when updating livein/liveout.

2013-08-12 Thread Kenneth Graunke
The starting block always has livein = 0 and liveout = copy. Since we start with real data, not estimates, there's no need to refine it with the fixed point algorithm. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 6 ++ 1 file changed, 6 insertio

[Mesa-dev] [PATCH 13/15] i965/fs: Fully recompute liveout at each step.

2013-08-12 Thread Kenneth Graunke
Since we start with an overestimation of livein (0x), successive steps may should actually take away values. This means we can't simply OR in new liveout values; we need to recompute it from scratch at each iteration of the fixed-point algorithm. Signed-off-by: Kenneth Graunke --- src/m

[Mesa-dev] [PATCH 14/15] i965/fs: Fix computation of livein.

2013-08-12 Thread Kenneth Graunke
Since the initial value for livein is an overestimation (0x), it's extremely likely that it will shrink, which means we can't simply OR in new bits - we need to fully recompute it based on the current liveout values. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_cop

[Mesa-dev] [PATCH 15/15] i965/fs: Re-enable global copy propagation.

2013-08-12 Thread Kenneth Graunke
I believe the data flow analysis actually works now, and it should be safe to re-enable global copy propagation. It even does things now. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/driver

[Mesa-dev] [PATCH 2/2] i965: Don't copy propagate bitcasts with source modifiers.

2013-08-12 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp| 13 + src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 3 +++ src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 10 ++ 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/mesa/driver

[Mesa-dev] [PATCH 1/4] glsl: Add bitcast_i2f() to ir_builder.

2013-08-12 Thread Matt Turner
--- src/glsl/ir_builder.cpp | 24 src/glsl/ir_builder.h | 4 2 files changed, 28 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp index 8fb30a0..5e1da17 100644 --- a/src/glsl/ir_builder.cpp +++ b/src/glsl/ir_builder.cpp @@ -304,12 +304,

[Mesa-dev] [PATCH 2/4] glsl: Add abs() to ir_builder.

2013-08-12 Thread Matt Turner
--- src/glsl/ir_builder.cpp | 6 ++ src/glsl/ir_builder.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp index 5e1da17..06b6a8c 100644 --- a/src/glsl/ir_builder.cpp +++ b/src/glsl/ir_builder.cpp @@ -219,6 +219,12 @@ saturate(operand a)

[Mesa-dev] [PATCH 3/4] glsl: Add nequal() to ir_builder.

2013-08-12 Thread Matt Turner
--- src/glsl/ir_builder.cpp | 6 ++ src/glsl/ir_builder.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp index 06b6a8c..b47d131 100644 --- a/src/glsl/ir_builder.cpp +++ b/src/glsl/ir_builder.cpp @@ -232,6 +232,12 @@ equal(operand a, op

[Mesa-dev] [PATCH 4/4] glsl: Add i2b() and b2i() to ir_builder.

2013-08-12 Thread Matt Turner
--- src/glsl/ir_builder.cpp | 12 src/glsl/ir_builder.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp index b47d131..7d9cf5e 100644 --- a/src/glsl/ir_builder.cpp +++ b/src/glsl/ir_builder.cpp @@ -369,6 +369,18 @@ bitcast_u

[Mesa-dev] [PATCH 1/2] i965: Emit MOVs for neg/abs.

2013-08-12 Thread Matt Turner
Necessary to avoid combining a bitcast and a modifier into a single operation. Otherwise if safe, the MOV should be removed by copy-propagation or register coalescing. --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 ++-- 2 files chan

Re: [Mesa-dev] [PATCH 3/3] glsl/ast: Don't perform GS input array checks on non-inputs.

2013-08-12 Thread Kenneth Graunke
On 08/12/2013 07:14 AM, Paul Berry wrote: Previously, we were accidentally calling handle_geometry_shader_input_decl() on non-input interface block declarations, resulting in bogus error checking. --- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

Re: [Mesa-dev] [PATCH] mesa: Enable LTO by default on i965/libdricore release builds.

2013-08-12 Thread Chad Versace
On 08/08/2013 01:43 PM, Eric Anholt wrote: We can't just smash it on globally due to (probably resolvable) issues with the asm in glapi. And we don't want to penalize developers with longer build times for their normal debug environment. Due to libdricore making almost all of our symbols public

Re: [Mesa-dev] [PATCH 2/4] glsl: Add abs() to ir_builder.

2013-08-12 Thread Kenneth Graunke
On 08/12/2013 01:25 PM, Matt Turner wrote: --- src/glsl/ir_builder.cpp | 6 ++ src/glsl/ir_builder.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp index 5e1da17..06b6a8c 100644 --- a/src/glsl/ir_builder.cpp +++ b/src/glsl/ir_buil

Re: [Mesa-dev] OpenGL ES only configuration (without "desktop" OpenGL support)

2013-08-12 Thread Chad Versace
On 08/06/2013 09:44 PM, Siarhei Siamashka wrote: On Tue, 6 Aug 2013 15:54:57 -0700 Matt Turner wrote: On Tue, Aug 6, 2013 at 2:13 PM, Siarhei Siamashka wrote: But if upstream Mesa treats this configuration as unsupported, then I also don't see it progressing anywhere in Gentoo. So could yo

Re: [Mesa-dev] [PATCH 2/3] mesa: Make detach_renderbuffer available outside fbobject.c

2013-08-12 Thread Chad Versace
On 08/08/2013 04:23 PM, Ian Romanick wrote: From: Ian Romanick Also add a return value indicating whether any work was done. This will be used by the next patch. Signed-off-by: Ian Romanick Cc: "9.2" mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 42 ++

Re: [Mesa-dev] [PATCH 3/3] mesa: Use _mesa_detach_renderbuffer when deleting a texture

2013-08-12 Thread Chad Versace
On 08/08/2013 04:23 PM, Ian Romanick wrote: From: Ian Romanick The functional change is that now invalidate_framebuffer is called if the texture is actually detached from one of the currently bound FBOs. Previously this was only done for renderbuffers. The remaining changes make the texture de

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Ian Romanick
On 08/11/2013 02:32 AM, davya...@free.fr wrote: Hello, To enable using prime on Wayland, we need to have a way to create shareable textures. That's the purpose of __DRI_IMAGE_USE_SHARE and PIPE_BIND_SHARED, but these flags don't disable tiling. This patch change the behaviour of these flags so

Re: [Mesa-dev] [PATCH 2/3] mesa: Make detach_renderbuffer available outside fbobject.c

2013-08-12 Thread Ian Romanick
On 08/12/2013 02:15 PM, Chad Versace wrote: On 08/08/2013 04:23 PM, Ian Romanick wrote: From: Ian Romanick Also add a return value indicating whether any work was done. This will be used by the next patch. Signed-off-by: Ian Romanick Cc: "9.2" mesa-sta...@lists.freedesktop.org --- src/mes

Re: [Mesa-dev] [PATCH] glx: Generate GLXBadDrawable when drawable is zero

2013-08-12 Thread Chad Versace
On 08/09/2013 03:42 PM, Ian Romanick wrote: From: Ian Romanick Fixes piglit glx-query-drawable-GLXBadDrawable. Signed-off-by: Ian Romanick Cc: "9.2" --- src/glx/glx_pbuffer.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) Woot! You fixed my Piglit test from 2011!

[Mesa-dev] [Bug 67962] undefined reference to `wayland_drm_buffer_get'

2013-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67962 Chad Versace changed: What|Removed |Added CC||chad.vers...@linux.intel.co

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Ian Romanick
On 08/11/2013 03:50 AM, davya...@free.fr wrote: This looks good to me, but commit messages should have a prefix indicating which component is changed. In your case it's "gallium:" and "intel:", respectively. Marek Ok, I've suppressed some trailing spaces and changed the commit message. And

[Mesa-dev] [Bug 67962] undefined reference to `wayland_drm_buffer_get'

2013-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67962 --- Comment #5 from Chad Versace --- Artie, I wrote the guilty commit. Next time I'm the guilty one, please add me to bugs CC list. -- You are receiving this mail because: You are the assignee for the bug. __

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Stéphane Marchesin
On Mon, Aug 12, 2013 at 2:29 PM, Ian Romanick wrote: > On 08/11/2013 03:50 AM, davya...@free.fr wrote: >>> >>> This looks good to me, but commit messages should have a prefix >>> indicating which component is changed. In your case it's "gallium:" >>> and "intel:", respectively. >>> >>> Marek >> >>

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread davyaxel
> On 08/11/2013 03:50 AM, davya...@free.fr wrote: >>> This looks good to me, but commit messages should have a prefix >>> indicating which component is changed. In your case it's "gallium:" >>> and "intel:", respectively. >>> >>> Marek >> >> >> Ok, I've suppressed some trailing spaces and changed

Re: [Mesa-dev] [PATCH v2] gbm: fix linking

2013-08-12 Thread Chad Versace
On 08/11/2013 08:27 AM, Armin K wrote: Link to internal libwayland-drm library if Wayland EGL platform is enabled. The library needs to be built before gbm. Link to libdrm if gbm_dri is enabled, otherwise library will report undefined references to libdrm symbols when using libgbm without libdrm

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Dave Airlie
On Tue, Aug 13, 2013 at 7:36 AM, Stéphane Marchesin wrote: > On Mon, Aug 12, 2013 at 2:29 PM, Ian Romanick wrote: >> On 08/11/2013 03:50 AM, davya...@free.fr wrote: This looks good to me, but commit messages should have a prefix indicating which component is changed. In your case i

Re: [Mesa-dev] [PATCH 4/4] glsl: Add i2b() and b2i() to ir_builder.

2013-08-12 Thread Chad Versace
This series, including the abs overload, is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Marek Olšák
On Mon, Aug 12, 2013 at 11:36 PM, Stéphane Marchesin wrote: >> Other than hybrid systems (of which >> there are none with i915 graphics), is there any case where >> __DRI_IMAGE_USE_SHARE can occur? > > You could do interesting things like cross-process sharing with it. I > think it's worth doing i

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Stéphane Marchesin
On Mon, Aug 12, 2013 at 3:05 PM, Marek Olšák wrote: > On Mon, Aug 12, 2013 at 11:36 PM, Stéphane Marchesin > wrote: >>> Other than hybrid systems (of which >>> there are none with i915 graphics), is there any case where >>> __DRI_IMAGE_USE_SHARE can occur? >> >> You could do interesting things li

[Mesa-dev] Patches: R600: Merge R600 and SI vector op expansions

2013-08-12 Thread Tom Stellard
Hi, The attached patches expand a few more vector operations and also move the expansion code into AMDGPUISelLowering.cpp so it can be shared between R600 and SI. -Tom >From a519e387c262ecc0282eb8cb1e2c8802725591b4 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Fri, 2 Aug 2013 11:30:01 -0700

Re: [Mesa-dev] [PATCH 3/9] glsl: Emit errors for things that look like default precision statements

2013-08-12 Thread Kenneth Graunke
On 08/09/2013 04:38 PM, Ian Romanick wrote: From: Ian Romanick Previously we would emit a warning for empty declarations like float; We would also emit the same warning for things like highp float; However, this second case is most likely the application trying to set the default precision.

Re: [Mesa-dev] [PATCH 9/9] glsl: Track existence of default float precision in GLSL ES fragment shaders

2013-08-12 Thread Kenneth Graunke
On 08/09/2013 04:38 PM, Ian Romanick wrote: From: Ian Romanick This is required by the spec, and it's a bit tricky because the default precision is scoped. As a result, I'm slightly abusing the symbol table. Fixes piglit no-default-float-precision.frag tests and the piglit default-precision-n

Re: [Mesa-dev] Patches: R600: Improve load / store support for 8-bit and 16-bit types

2013-08-12 Thread Aaron Watry
It'll take me a while to attempt to parse everything that's going on in these patches (and your resource descriptor types series that this depends on), but I have sent it all through a piglit run on Evergreen (Cedar). Everything was latest Mesa/LLVM/libclc upstream code as of today. Baseline: 567

[Mesa-dev] [PATCH 1/3] gallium: add new float comparison instructions returning integer masks

2013-08-12 Thread sroland
From: Roland Scheidegger Newer graphic languages don't want messy float mask results but instead true "boolean" mask results for float comparisons. Otherwise just need to convert the floats back to integers. Need to keep the old opcodes however due to both legacy (gl and d3d9) needing them and be

[Mesa-dev] [PATCH 2/3] tgsi: implement new float comparison instructions returning integer masks

2013-08-12 Thread sroland
From: Roland Scheidegger Also while here add a bunch of other forgotten (integer) instructions to tgsi_util_get_inst_usage_mask() (which isn't used for much except optimizing away unused input components), though it may still be incomplete. --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 60

[Mesa-dev] [PATCH 3/3] gallivm: implement new float comparison instructions returning integer masks

2013-08-12 Thread sroland
From: Roland Scheidegger FSEQ/FSGE/FSLT/FSNE work just the same as SEQ/SGE/SLT/SNE except skip the select. And just for consistency use the same appropriate ordered/unordered comparisons for the old opcodes as well. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 81 ++

Re: [Mesa-dev] [PATCH 3/3] gallivm: implement new float comparison instructions returning integer masks

2013-08-12 Thread Zack Rusin
Nice. The entire series looks good. Reviewed-by: Zack Rusin - Original Message - > From: Roland Scheidegger > > FSEQ/FSGE/FSLT/FSNE work just the same as SEQ/SGE/SLT/SNE except skip the > select. > And just for consistency use the same appropriate ordered/unordered > comparisons > for

[Mesa-dev] [PATCH] tgsi_build: fix order of arguments for ind register build

2013-08-12 Thread Dave Airlie
From: Dave Airlie This was broken when arrayid was added. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_build.c | 2 +- src/gallium/renderer/virgl_hw.h | 39 + 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/src/gallium/a

[Mesa-dev] [PATCH] draw: make sure that the stages setup outputs

2013-08-12 Thread Zack Rusin
Calling the prepare outputs cleans up the slot assignments for outputs, unfortunately aapoint and aaline didn't have code to reset their slots after the initial setup, this was messing up our slot assignments. The unfilled stage was just missing the initial assignment of the face slot. This fixes a

Re: [Mesa-dev] [PATCH 3/4] R600/SI: Allow conversion between v32i8 and v8i32

2013-08-12 Thread Tom Stellard
On Sat, Aug 10, 2013 at 08:50:31PM +0200, Marek Olšák wrote: > Signed-off-by: Marek Olšák You will need to add a test case to this commit, but otherwise the whole series is: Reviewed-by: Tom Stellard Do you have commit access yet? -Tom > --- > lib/Target/R600/SIInstructions.td | 5 + >

[Mesa-dev] [Bug 67740] render2.c: In function '__indirect_glMap1d'

2013-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67740 --- Comment #2 from Henry --- from the tarball. ./configure --prefix=/local PYTHON2=/local/bin/python2.7 -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing

[Mesa-dev] [PATCH] update wayland requirement

2013-08-12 Thread Fabio Pedretti
Since 8d29b52 wayland 1.2.0 is required.--- configure.ac2013-08-12 13:17:10.0 +0200 +++ configure.ac2013-08-12 13:19:15.0 +0200 @@ -1433,7 +1433,7 @@ egl_platforms=`IFS=', '; echo $with_egl_ for plat in $egl_platforms; do case "$plat" in wayland) -

[Mesa-dev] [PATCH] llvmpipe: fix pipeline statistics with a null ps

2013-08-12 Thread Zack Rusin
If the fragment shader is null then pixel shader invocations have to be equal to zero. And if we're running a null ps then clipper invocations and primitives should be equal to zero but only if both stancil and depth testing are disabled. Signed-off-by: Zack Rusin --- src/gallium/drivers/llvmpip

Re: [Mesa-dev] Patches: R600: Merge R600 and SI vector op expansions

2013-08-12 Thread Michel Dänzer
On Mon, 2013-08-12 at 15:25 -0700, Tom Stellard wrote: > > The attached patches expand a few more vector operations and also move > the expansion code into AMDGPUISelLowering.cpp so it can be shared > between R600 and SI. This series is Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer