[Mesa-dev] [Bug 58326] New: [llvmpipe] piglit glean depthStencil regression

2012-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58326 Priority: medium Bug ID: 58326 CC: mar...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] piglit glean depthStencil regression Severity: normal Classif

Re: [Mesa-dev] [PATCH 1/2] mesa: add support for ARB_texture_buffer_object_rgb32

2012-12-15 Thread Marek Olšák
On Sat, Dec 15, 2012 at 4:38 AM, Dave Airlie wrote: > This adds the extensions + the tex buffer support for checking > the formats. > > There is a piglit test enhancement sent to that list. > > Signed-off-by: Dave Airlie > --- > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h |

Re: [Mesa-dev] [PATCH 1/2] mesa: add support for ARB_texture_buffer_object_rgb32

2012-12-15 Thread Marek Olšák
On Sat, Dec 15, 2012 at 1:18 PM, Marek Olšák wrote: > On Sat, Dec 15, 2012 at 4:38 AM, Dave Airlie wrote: >> This adds the extensions + the tex buffer support for checking >> the formats. >> >> There is a piglit test enhancement sent to that list. >> >> Signed-off-by: Dave Airlie >> --- >> src/

[Mesa-dev] [PATCH] radeon/llvm: fix literals inlining

2012-12-15 Thread Vadim Girlin
Use bitwise comparison to check whether we can replace float literal with inline constant (0.0, 0.5, 1.0), otherwise we can get unexpected results for integer literals bitcasted to float. Fixes lockup with glsl-fs-unroll-out-param.shader_test on evergreen. Signed-off-by: Vadim Girlin --- lib/Ta

[Mesa-dev] [PATCH 1/2] radeon/llvm: add SHADOWCUBE to TEX_SHADOW pattern

2012-12-15 Thread Vadim Girlin
--- lib/Target/AMDGPU/R600Instructions.td | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Target/AMDGPU/R600Instructions.td b/lib/Target/AMDGPU/R600Instructions.td index 5900794..6364645 100644 --- a/lib/Target/AMDGPU/R600Instructions.td +++ b/lib/Target/AMDGPU/R600Instruc

[Mesa-dev] [PATCH 2/2] radeon/llvm: fix MAX_UINT definition

2012-12-15 Thread Vadim Girlin
--- lib/Target/AMDGPU/R600Instructions.td | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Target/AMDGPU/R600Instructions.td b/lib/Target/AMDGPU/R600Instructions.td index 6364645..64bab18 100644 --- a/lib/Target/AMDGPU/R600Instructions.td +++ b/lib/Target/AMDGPU/R600Instruc

[Mesa-dev] [PATCH 1/3] r600g: initialize inst_mod in r600_tex_from_byte_stream

2012-12-15 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index f007204..987ad51 100644 --- a/src/gallium/drivers/r600/r600_shader.c +++ b/src/galliu

[Mesa-dev] [PATCH 2/3] radeon/llvm: fix radeon_llvm_emit_prepare_cube_coords

2012-12-15 Thread Vadim Girlin
--- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index db25c89..e1670ce 100644 --- a/src/gallium/d

[Mesa-dev] [PATCH 3/3] radeon/llvm: fix TXQ_LZ handling for cube maps

2012-12-15 Thread Vadim Girlin
--- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index e1670ce..0ca7e3d 100644 --- a/src/gallium/drivers/radeo

[Mesa-dev] [Bug 54372] GLX_INTEL_swap_event crashes driver when swapping window buffers

2012-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54372 danm...@gmail.com changed: What|Removed |Added Severity|normal |major Priority|medium

Re: [Mesa-dev] [PATCH 1/2] i965: Split struct brw_reg out from brw_eu.h into its own header.

2012-12-15 Thread Eric Anholt
Kenneth Graunke writes: > struct brw_instruction and the related instruction emitting code won't > be useful on Gen8+, as the instruction encoding changed. However, the > struct brw_reg code is still extremely valuable. Series is: Reviewed-by: Eric Anholt pgpTShdbyhewj.pgp Description: PGP

Re: [Mesa-dev] [PATCH 5/5] mesa: Fix GL_TRANSFORM_FEEDBACK_BUFFER_SIZE query when glBindBufferBase used.

2012-12-15 Thread Paul Berry
On 14 December 2012 13:01, Paul Berry wrote: > From the GL 4.3 spec, section 6.7.1 (Indexed Buffer Object Limits and > Binding Queries): > > To query the starting offset or size of the range of a buffer > object binding in an indexed array, call GetInteger64i v with > target set to re

[Mesa-dev] [Bug 54372] GLX_INTEL_swap_event crashes driver when swapping window buffers

2012-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54372 Kenneth Graunke changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |e...@anholt.net |org

Re: [Mesa-dev] [PATCH 3/5] mesa/gles3: Generate error on DrawElements* calls if transform feedback active.

2012-12-15 Thread Paul Berry
On 14 December 2012 17:26, Ian Romanick wrote: > On 12/14/2012 01:01 PM, Paul Berry wrote: > >> In GLES3, only glDrawArrays() and glDrawArraysInstanced() calls are >> allowed when transform feedback is active. >> --- >> src/mesa/main/api_validate.c | 45 ++** >> +

[Mesa-dev] [PATCH] vega: fix for object handle leak

2012-12-15 Thread Andreas Pokorny
Hello, I have been chasing a leak with OpenVG mesa-8.0.5. Massif gave me the following stack: ->09.66% (3,471,568B) 0xB706B80: util_hash_table_set (u_hash_table.c:163) | ->09.66% (3,471,568B) 0xB4E106F: create_handle (handle.c:83) | ->09.66% (3,471,568B) 0xB527B7D: vg_init_object (vg_context.c:1

Re: [Mesa-dev] [PATCH 5/5] mesa: Fix GL_TRANSFORM_FEEDBACK_BUFFER_SIZE query when glBindBufferBase used.

2012-12-15 Thread Ian Romanick
On 12/15/2012 01:27 PM, Paul Berry wrote: On 14 December 2012 13:01, Paul Berry mailto:stereotype...@gmail.com>> wrote: From the GL 4.3 spec, section 6.7.1 (Indexed Buffer Object Limits and Binding Queries): To query the starting offset or size of the range of a buffer

Re: [Mesa-dev] [PATCH] glsl: avoid using gl context as a memory context

2012-12-15 Thread Ian Romanick
On 12/14/2012 07:26 PM, Dave Airlie wrote: Not sure what was going on here, but running piglit with debug builds might be a good plan :-) Hmm... I wonder if this is related to bug #58039. I think we should have a flag-day patch that changes all the places where the memory context is called ct

[Mesa-dev] [PATCH] scons: Use X11 modules if X11 is available.

2012-12-15 Thread Vinson Lee
This patch fixes these build errors. glxinit.c:18:25: error: GL/glxproto.h: No such file or directory glxinit.c:19:26: error: GL/glxtokens.h: No such file or directory Signed-off-by: Vinson Lee --- src/gallium/state_trackers/egl/SConscript | 1 + 1 file changed, 1 insertion(+) diff --git a/src/

Re: [Mesa-dev] [PATCH] scons: Use X11 modules if X11 is available.

2012-12-15 Thread Dan Nicholson
On Sat, Dec 15, 2012 at 5:34 PM, Vinson Lee wrote: > This patch fixes these build errors. > glxinit.c:18:25: error: GL/glxproto.h: No such file or directory > glxinit.c:19:26: error: GL/glxtokens.h: No such file or directory > > Signed-off-by: Vinson Lee > --- > src/gallium/state_trackers/egl/SC

Re: [Mesa-dev] [PATCH] glsl: avoid using gl context as a memory context

2012-12-15 Thread Dave Airlie
> > Hmm... I wonder if this is related to bug #58039. > > I think we should have a flag-day patch that changes all the places where > the memory context is called ctx to call it mem_ctx. That might make future > problems like this easier to notice in code review. > That glsl_parser_extras.cpp is

[Mesa-dev] [PATCH] glsl_parser_extras.cpp: fixup gl vs mem contexts again.

2012-12-15 Thread Dave Airlie
This should fix: https://bugs.freedesktop.org/show_bug.cgi?id=58039 Signed-off-by: Dave Airlie --- src/glsl/glsl_parser_extras.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index d360892..91122cc

Re: [Mesa-dev] [PATCH 5/5] mesa: Fix GL_TRANSFORM_FEEDBACK_BUFFER_SIZE query when glBindBufferBase used.

2012-12-15 Thread Paul Berry
On 15 December 2012 14:56, Ian Romanick wrote: > On 12/15/2012 01:27 PM, Paul Berry wrote: > >> On 14 December 2012 13:01, Paul Berry > > wrote: >> >> From the GL 4.3 spec, section 6.7.1 (Indexed Buffer Object Limits and >> Binding Queries): >> >>

[Mesa-dev] [PATCH v2 0/6] GLES3 transform feedback fixes.

2012-12-15 Thread Paul Berry
Here's an update on my patch series from yesterday. I've made the following changes: - In patch 2, I had accidentaly included some C++-style variable declarations. These don't work with MSVC, so I changed them to C-style variable declarations. - Patch 5 required a complete rewrite--it turne

[Mesa-dev] [PATCH v2 1/6] mesa: Change args to vbo_count_tessellated_primitives.

2012-12-15 Thread Paul Berry
No functional change--this simply paves the way to allow futures patches to call vbo_count_tessellated_primitives() during error checking, before the _mesa_prim struct has been constructed. This will be needed for GLES3, which requires draw calls to fail if there is not enough space available in t

[Mesa-dev] [PATCH v2 2/6] mesa: refactor _mesa_compute_max_transform_feedback_vertices from i965.

2012-12-15 Thread Paul Berry
Previously, the i965 driver contained code to compute the maximum number of vertices that could be written without overflowing any transform feedback buffers. This code wasn't driver-specific, and for GLES3 support we're going to need to use it in core mesa. So this patch moves the code into a co

[Mesa-dev] [PATCH v2 3/6] mesa/gles3: Generate error on DrawElements* calls if transform feedback active.

2012-12-15 Thread Paul Berry
In GLES3, only glDrawArrays() and glDrawArraysInstanced() calls are allowed when transform feedback is active. Reviewed-by: Ian Romanick --- src/mesa/main/api_validate.c | 45 1 file changed, 45 insertions(+) diff --git a/src/mesa/main/api_validate.c

[Mesa-dev] [PATCH v2 4/6] mesa/gles3: Generate error on draw call if transform feedback would overflow.

2012-12-15 Thread Paul Berry
In desktop GL, if a draw call would cause transform feedback buffers to overflow, the draw call should succeed, and the extra primitives should simply not be recorded in the transform feedback buffers. In GLES3, however, if a draw call would cause transform feedback buffers to overflow, the draw c

[Mesa-dev] [PATCH v2 5/6] mesa: Fix corner cases of BindBufferBase with transform feedback.

2012-12-15 Thread Paul Berry
This patch implements the following behaviours, which are mandated by the GL 4.3 and GLES3 specs. 1. Regarding the GL_TRANSFORM_FEEDBACK_BUFFER_SIZE query: "If the ... size was not specified when the buffer object was bound (e.g. if it was bound with BindBufferBase), ... zero is returned."

[Mesa-dev] [PATCH v2 6/6] mesa: Make a function is_transform_feedback_active_and_unpaused.

2012-12-15 Thread Paul Berry
The rather unweildy logic for determining this condition was repeated in a large number of places. This patch consolidates it to a single inline function. Cc: Ian Romanick --- src/mesa/drivers/common/meta.c | 3 +-- src/mesa/drivers/dri/i965/brw_draw.c | 4 ++-- src/mesa/dri

Re: [Mesa-dev] [PATCH] glsl_parser_extras.cpp: fixup gl vs mem contexts again.

2012-12-15 Thread Kenneth Graunke
On 12/15/2012 05:48 PM, Dave Airlie wrote: This should fix: https://bugs.freedesktop.org/show_bug.cgi?id=58039 Signed-off-by: Dave Airlie --- src/glsl/glsl_parser_extras.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl