Re: [Mesa-dev] [PATCH] build: Disable building of d3d1x

2012-09-04 Thread Jose Fonseca
Cristoph Bumiller was the last person to commit any changes to this, last December. d3d1x is not built through scons either. If it is really broken and unmaintained then lets just remove it from the tree, as code will just rot. If an interested party comes along they can always refer to git his

[Mesa-dev] [PATCH 1/2] main: add _mesa_is_gles1() and _mesa_is_gles2() inline functions.

2012-09-04 Thread Oliver McFadden
From: Oliver McFadden Signed-off-by: Oliver McFadden --- src/mesa/main/context.h | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index e238752..b37ddc7 100644 --- a/src/mesa/main/context.h +++ b/src/m

[Mesa-dev] [PATCH 2/2] intel: add ANGLE_texture_compression_dxt extension support.

2012-09-04 Thread Oliver McFadden
From: Oliver McFadden http://www.khronos.org/registry/gles/extensions/ANGLE/ANGLE_texture_compression_dxt.txt Signed-off-by: Oliver McFadden --- src/glx/glxextensions.h |1 + src/mapi/glapi/gen/es_EXT.xml |6 ++ src/mesa/drivers/dri/intel/intel

Re: [Mesa-dev] [PATCH 1/3] mesa: remove null pointer checks before free() calls

2012-09-04 Thread Brian Paul
On 09/03/2012 09:47 PM, Matt Turner wrote: On Mon, Sep 3, 2012 at 12:15 PM, Matt Turner wrote: On Mon, Sep 3, 2012 at 7:13 AM, Brian Paul wrote: From: Brian Paul Since free(NULL) is fine. I think if we want to do this, then we should do it all the way with a Coccinelle semantic patch. I'l

[Mesa-dev] [PATCH] configure.ac: Don't link gallium drivers with libdricore

2012-09-04 Thread Tom Stellard
From: Tom Stellard --- Is there any reason gallium drivers should be linking with libdricore? They seem to work fine without it. configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 82fe225..6e67ec0 100644 --- a/configure.ac ++

[Mesa-dev] [PATCH] radeon/llvm: swap wrong OPCODE_IS_*_ZERO_* opcode and use

2012-09-04 Thread Vincent Lejeune
--- src/gallium/drivers/radeon/AMDGPUInstrInfo.h| 4 ++-- src/gallium/drivers/radeon/R600ISelLowering.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/AMDGPUInstrInfo.h b/src/gallium/drivers/radeon/AMDGPUInstrInfo.h index 2643119..a308076

Re: [Mesa-dev] [PATCH] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Brian Paul
On 09/01/2012 11:14 AM, Jordan Justen wrote: Change the format to [MAJOR.MINOR][CORE|COMPAT] For example: 3.0, CORE, COMPAT, 3.2CORE Signed-off-by: Jordan Justen --- docs/envvars.html | 11 +++-- src/mesa/main/context.c |4 ++ src/mesa/main/version.c | 104 ++

Re: [Mesa-dev] [PATCH] radeon/llvm: swap wrong OPCODE_IS_*_ZERO_* opcode and use

2012-09-04 Thread Tom Stellard
On Tue, Sep 04, 2012 at 04:49:25PM +0200, Vincent Lejeune wrote: > --- > src/gallium/drivers/radeon/AMDGPUInstrInfo.h| 4 ++-- > src/gallium/drivers/radeon/R600ISelLowering.cpp | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Tom Stellard > diff --git a/src/galliu

[Mesa-dev] [PATCH 1/4] radon/llvm: br_cc f32 now lowered without cast

2012-09-04 Thread Vincent Lejeune
--- src/gallium/drivers/radeon/R600ISelLowering.cpp | 33 ++--- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeon/R600ISelLowering.cpp b/src/gallium/drivers/radeon/R600ISelLowering.cpp index fec9d4e..60c8ade 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH 2/4] radeon/llvm: support setcc on f32

2012-09-04 Thread Vincent Lejeune
Conflicts: src/gallium/drivers/radeon/R600ISelLowering.cpp --- src/gallium/drivers/radeon/R600ISelLowering.cpp | 36 ++--- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeon/R600ISelLowering.cpp b/src/gallium/drivers/radeon/R600IS

[Mesa-dev] [PATCH 3/4] radeon/llvm: custom lowering for FP_TO_UINT when dst is i1 (bool)

2012-09-04 Thread Vincent Lejeune
Conflicts: src/gallium/drivers/radeon/R600ISelLowering.cpp --- src/gallium/drivers/radeon/R600ISelLowering.cpp | 20 src/gallium/drivers/radeon/R600ISelLowering.h | 6 -- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/

[Mesa-dev] [PATCH 4/4] radeon/llvm: do not convert f32 operand of select_cc node

2012-09-04 Thread Vincent Lejeune
--- src/gallium/drivers/radeon/R600ISelLowering.cpp | 40 - 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/gallium/drivers/radeon/R600ISelLowering.cpp b/src/gallium/drivers/radeon/R600ISelLowering.cpp index 5296062..04a7e0b 100644 --- a/src/gallium/dri

Re: [Mesa-dev] [PATCH 2/2] mesa: utilize context version routines

2012-09-04 Thread Brian Paul
On 09/03/2012 11:35 AM, Eric Anholt wrote: Kenneth Graunke writes: I'm really ambivalent about these patches. 1. I'm not a huge fan of the name "have_version"...it sounds like it would return whether a driver supports a given version, not whether the current context's version is a certain val

Re: [Mesa-dev] [PATCH 3/4] radeon/llvm: custom lowering for FP_TO_UINT when dst is i1 (bool)

2012-09-04 Thread Tom Stellard
On Tue, Sep 04, 2012 at 05:04:29PM +0200, Vincent Lejeune wrote: > Conflicts: > src/gallium/drivers/radeon/R600ISelLowering.cpp > --- > src/gallium/drivers/radeon/R600ISelLowering.cpp | 20 > src/gallium/drivers/radeon/R600ISelLowering.h | 6 -- > 2 files changed,

Re: [Mesa-dev] [PATCH 4/4] radeon/llvm: do not convert f32 operand of select_cc node

2012-09-04 Thread Tom Stellard
On Tue, Sep 04, 2012 at 05:04:30PM +0200, Vincent Lejeune wrote: > --- > src/gallium/drivers/radeon/R600ISelLowering.cpp | 40 > - > 1 file changed, 20 insertions(+), 20 deletions(-) > > diff --git a/src/gallium/drivers/radeon/R600ISelLowering.cpp > b/src/gallium/drivers

Re: [Mesa-dev] [PATCH 2/2] intel: add ANGLE_texture_compression_dxt extension support.

2012-09-04 Thread Brian Paul
On 09/04/2012 05:53 AM, Oliver McFadden wrote: From: Oliver McFadden http://www.khronos.org/registry/gles/extensions/ANGLE/ANGLE_texture_compression_dxt.txt Signed-off-by: Oliver McFadden --- src/glx/glxextensions.h |1 + src/mapi/glapi/gen/es_EXT.xml

Re: [Mesa-dev] [PATCH 1/4] radon/llvm: br_cc f32 now lowered without cast

2012-09-04 Thread Tom Stellard
On Tue, Sep 04, 2012 at 05:04:27PM +0200, Vincent Lejeune wrote: > --- > src/gallium/drivers/radeon/R600ISelLowering.cpp | 33 > ++--- > 1 file changed, 24 insertions(+), 9 deletions(-) > Just a few coding style issues that I noted with patched 3 and 4. Also, you can remove

[Mesa-dev] [PATCH] radeon/llvm: do not convert f32 operand of select_cc node

2012-09-04 Thread Vincent Lejeune
v2:-use camel coding style --- src/gallium/drivers/radeon/R600ISelLowering.cpp | 40 - 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/gallium/drivers/radeon/R600ISelLowering.cpp b/src/gallium/drivers/radeon/R600ISelLowering.cpp index 261cfa4..9501bdb 1

Re: [Mesa-dev] Default CC list of mesa driver bug

2012-09-04 Thread Brian Paul
On 09/02/2012 01:42 PM, Fabio Pedretti wrote: I noticed that mesa bug report got CCed to mesa-dev list, while driver mesa bug went to dri-devel. That does seem kind of weird. Is this intended, why don't use mesa-dev for all mesa related bug instead and use dri-devel for libdrm/kernel modules

[Mesa-dev] [PATCH] radeon/llvm: custom lowering for FP_TO_UINT when dst is i1 (bool)

2012-09-04 Thread Vincent Lejeune
v2:-wrap line at 80 characters --- src/gallium/drivers/radeon/R600ISelLowering.cpp | 22 ++ src/gallium/drivers/radeon/R600ISelLowering.h | 6 -- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/R600ISelLowering.cpp b/src/galliu

[Mesa-dev] [Bug 54496] New: [swrast] piglit texture-packed-formats regression

2012-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54496 Bug #: 54496 Summary: [swrast] piglit texture-packed-formats regression Classification: Unclassified Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All)

[Mesa-dev] [Bug 54365] [swrast] piglit fbo-1d regression

2012-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54365 --- Comment #1 from Brian Paul 2012-09-04 16:25:07 UTC --- Created attachment 66615 --> https://bugs.freedesktop.org/attachment.cgi?id=66615 fix the DIFFERENT_SIGNS() function Vinson, can you try this patch? -- Configure bugmail: https://bu

[Mesa-dev] [Bug 54496] [swrast] piglit texture-packed-formats regression

2012-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54496 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 54365] [swrast] piglit fbo-1d regression

2012-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54365 --- Comment #2 from Brian Paul 2012-09-04 16:39:11 UTC --- *** Bug 54496 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --

Re: [Mesa-dev] [PATCH] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/01/2012 10:14 AM, Jordan Justen wrote: > Change the format to [MAJOR.MINOR][CORE|COMPAT] For example: 3.0, CORE, > COMPAT, 3.2CORE > > Signed-off-by: Jordan Justen --- > docs/envvars.html | 11 +++-- src/mesa/main/context.c |4 ++ >

[Mesa-dev] [PATCH] mesa: Make glGetStringi(GL_EXTENSIONS, n) respect API

2012-09-04 Thread Chad Versace
The function did not respect the context's API, and so returned internally enabled GLES extensions from GL contexts. Note: This is a candidate for the 7.11, 8.0, and 8.0 branches. CC: Kenneth Graunke CC: Jordan Justen Signed-off-by: Chad Versace --- src/mesa/main/extensions.c | 4 +++- 1 file

Re: [Mesa-dev] [PATCH 2/2] intel: add ANGLE_texture_compression_dxt extension support.

2012-09-04 Thread Eric Anholt
Brian Paul writes: > Most of the patch is 'FEATURE_x' changes. I've been tempted to rip > out all that stuff. > > The original idea was to make it easy for people to build smaller Mesa > subsets (and the ES subset) by running the code through the > preprocessor with all the FEATURE_x flags set

[Mesa-dev] [PATCH] i965/fs: Fix handling of abs modifiers in copy propagation.

2012-09-04 Thread Kenneth Graunke
We recorded MOVs in the ACP that had abs modifiers (losing the sign of the original value), and then went ahead and copy propagated that into an expression that needed the original signed value. NOTE: This is a candidate for stable release branches. Signed-off-by: Kenneth Graunke --- src/mesa/d

[Mesa-dev] [Bug 54365] [swrast] piglit fbo-1d regression

2012-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54365 --- Comment #3 from Vinson Lee 2012-09-04 17:34:12 UTC --- (In reply to comment #1) > Created attachment 66615 [details] [review] > fix the DIFFERENT_SIGNS() function > > Vinson, can you try this patch? Attachment 66615 fixes fbo-1d and textur

Re: [Mesa-dev] [PATCH 1/2] main: add _mesa_is_gles1() and _mesa_is_gles2() inline functions.

2012-09-04 Thread Matt Turner
On Tue, Sep 4, 2012 at 4:53 AM, Oliver McFadden wrote: > From: Oliver McFadden > > Signed-off-by: Oliver McFadden > --- > src/mesa/main/context.h | 20 > 1 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h >

[Mesa-dev] [Bug 54365] [swrast] piglit fbo-1d regression

2012-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54365 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] [PATCH] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Jordan Justen
On Tue, Sep 4, 2012 at 9:55 AM, Chad Versace wrote: > On 09/01/2012 10:14 AM, Jordan Justen wrote: >> Change the format to [MAJOR.MINOR][CORE|COMPAT] For example: 3.0, CORE, >> COMPAT, 3.2CORE >> >> Signed-off-by: Jordan Justen --- >> docs/envvars.html | 11 +++-- src/mesa/main/context.c |

Re: [Mesa-dev] Default CC list of mesa driver bug

2012-09-04 Thread Eric Anholt
Brian Paul writes: > On 09/02/2012 01:42 PM, Fabio Pedretti wrote: >> I noticed that mesa bug report got CCed to mesa-dev list, while driver mesa >> bug >> went to dri-devel. > > That does seem kind of weird. > >> Is this intended, why don't use mesa-dev for all mesa >> related bug instead and u

Re: [Mesa-dev] [PATCH] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Kenneth Graunke
On 09/01/2012 10:14 AM, Jordan Justen wrote: > Change the format to [MAJOR.MINOR][CORE|COMPAT] > For example: 3.0, CORE, COMPAT, 3.2CORE > > Signed-off-by: Jordan Justen Since we aren't going to support compatibility contexts, I would just make MESA_GL_VERSION_OVERRIDE=3.1 force API_OPENGL_CORE.

Re: [Mesa-dev] [PATCH] configure.ac: Don't link gallium drivers with libdricore

2012-09-04 Thread Matt Turner
On Tue, Sep 4, 2012 at 7:37 AM, Tom Stellard wrote: > From: Tom Stellard > > --- > > Is there any reason gallium drivers should be linking with libdricore? > They seem to work fine without it. > > configure.ac |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/configur

Re: [Mesa-dev] [PATCH 2/2] intel: add ANGLE_texture_compression_dxt extension support.

2012-09-04 Thread Ian Romanick
On 09/04/2012 08:16 AM, Brian Paul wrote: On 09/04/2012 05:53 AM, Oliver McFadden wrote: From: Oliver McFadden http://www.khronos.org/registry/gles/extensions/ANGLE/ANGLE_texture_compression_dxt.txt Signed-off-by: Oliver McFadden --- src/glx/glxextensions.h |1 +

Re: [Mesa-dev] [PATCH 2/2] intel: add ANGLE_texture_compression_dxt extension support.

2012-09-04 Thread Ian Romanick
On 09/04/2012 04:53 AM, Oliver McFadden wrote: From: Oliver McFadden http://www.khronos.org/registry/gles/extensions/ANGLE/ANGLE_texture_compression_dxt.txt Signed-off-by: Oliver McFadden --- src/glx/glxextensions.h |1 + src/mapi/glapi/gen/es_EXT.xml

Re: [Mesa-dev] [PATCH 1/2] main: add _mesa_is_gles1() and _mesa_is_gles2() inline functions.

2012-09-04 Thread Ian Romanick
On 09/04/2012 04:53 AM, Oliver McFadden wrote: From: Oliver McFadden Signed-off-by: Oliver McFadden --- src/mesa/main/context.h | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index e238752..b37dd

Re: [Mesa-dev] [PATCH] radeon/llvm: Convert to Automake

2012-09-04 Thread Matt Turner
On Fri, Aug 31, 2012 at 1:41 PM, Tom Stellard wrote: > On Fri, Aug 31, 2012 at 01:26:33PM -0700, Matt Turner wrote: >> On Fri, Aug 31, 2012 at 6:04 AM, Tom Stellard wrote: >> > On Thu, Aug 30, 2012 at 02:11:22PM -0700, Matt Turner wrote: >> >> On Thu, Aug 30, 2012 at 1:19 PM, Tom Stellard wrote:

Re: [Mesa-dev] [PATCH] i965/fs: Fix handling of abs modifiers in copy propagation.

2012-09-04 Thread Kenneth Graunke
On 09/04/2012 10:32 AM, Kenneth Graunke wrote: > We recorded MOVs in the ACP that had abs modifiers (losing the sign of > the original value), and then went ahead and copy propagated that into > an expression that needed the original signed value. > > NOTE: This is a candidate for stable release b

Re: [Mesa-dev] [PATCH] mesa: Make glGetStringi(GL_EXTENSIONS, n) respect API

2012-09-04 Thread Ian Romanick
On 09/04/2012 10:19 AM, Chad Versace wrote: The function did not respect the context's API, and so returned internally enabled GLES extensions from GL contexts. Does glGetIntegerv(GL_NUM_EXTENSIONS) return the correct count? Note: This is a candidate for the 7.11, 8.0, and 8.0 branches. Thi

Re: [Mesa-dev] [PATCH] radeon/llvm: Convert to Automake

2012-09-04 Thread Tom Stellard
On Tue, Sep 04, 2012 at 11:10:52AM -0700, Matt Turner wrote: > On Fri, Aug 31, 2012 at 1:41 PM, Tom Stellard wrote: > > On Fri, Aug 31, 2012 at 01:26:33PM -0700, Matt Turner wrote: > >> On Fri, Aug 31, 2012 at 6:04 AM, Tom Stellard wrote: > >> > On Thu, Aug 30, 2012 at 02:11:22PM -0700, Matt Turn

Re: [Mesa-dev] [PATCH 2/2] intel: add ANGLE_texture_compression_dxt extension support.

2012-09-04 Thread Brian Paul
On 09/04/2012 12:08 PM, Ian Romanick wrote: On 09/04/2012 08:16 AM, Brian Paul wrote: Most of the patch is 'FEATURE_x' changes. I've been tempted to rip out all that stuff. The original idea was to make it easy for people to build smaller Mesa subsets (and the ES subset) by running the code

Re: [Mesa-dev] Default CC list of mesa driver bug

2012-09-04 Thread Brian Paul
On 09/04/2012 11:40 AM, Eric Anholt wrote: Brian Paul writes: On 09/02/2012 01:42 PM, Fabio Pedretti wrote: I noticed that mesa bug report got CCed to mesa-dev list, while driver mesa bug went to dri-devel. That does seem kind of weird. Is this intended, why don't use mesa-dev for all mes

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-09-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 --- Comment #18 from Brian Paul 2012-09-04 18:45:48 UTC --- Michel, I think you're right. I started digging into this a few weeks ago but haven't had time to get back to it. I think I'll need a couple hours of quality time to really get to the

[Mesa-dev] [PATCH] mesa: Don't advertise GLES extensions in GL contexts

2012-09-04 Thread Chad Versace
glGetStringi(GL_EXTENSIONS) failed to respect the context's API, and so returned all internally enabled GLES extensions from a GL context. Likewise, glGetIntegerv(GL_NUM_EXTENSIONS) also failed to repsect the context's API. Note: This is a candidate for the 8.0 and 9.0 branches. CC: Kenneth Graunk

[Mesa-dev] [PATCH v2 1/2] main/version: consolodate version string creation for ES/Desktop GL

2012-09-04 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/version.c | 58 --- 1 file changed, 24 insertions(+), 34 deletions(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index f22118a..7002dd8 100644 --- a/src/mesa/main/version.c +++ b/src/

[Mesa-dev] [PATCH v2 2/2] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Jordan Justen
Change the format to [MAJOR.MINOR][CORE|COMPAT] For example: 3.0, CORE, COMPAT, 3.2CORE Signed-off-by: Jordan Justen Reviewed-by: Brian Paul --- v2: * Remove override_version function * Fix comment on create_version_string header docs/envvars.html | 11 +-- src/mesa/main/context

[Mesa-dev] [PATCH 1/2] intel: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Stéphane Marchesin
The current computation for the lastlevel is based on the level size and can lead to writing past the end of the texture array. Instead we clamp it by MAX_TEXTURE_LEVELS. --- src/mesa/drivers/dri/intel/intel_tex_image.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/s

[Mesa-dev] [PATCH 2/2] st/mesa: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Stéphane Marchesin
The current computation for the lastlevel is based on the level size and can lead to writing past the end of the texture array. Instead we clamp according to hardware limits. --- src/mesa/state_tracker/st_cb_texture.c | 28 +++- 1 files changed, 27 insertions(+), 1 deleti

Re: [Mesa-dev] [PATCH] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Jordan Justen
On Tue, Sep 4, 2012 at 10:43 AM, Kenneth Graunke wrote: > On 09/01/2012 10:14 AM, Jordan Justen wrote: >> Change the format to [MAJOR.MINOR][CORE|COMPAT] >> For example: 3.0, CORE, COMPAT, 3.2CORE >> >> Signed-off-by: Jordan Justen > > Since we aren't going to support compatibility contexts, I wo

Re: [Mesa-dev] [PATCH] mesa: Don't advertise GLES extensions in GL contexts

2012-09-04 Thread Jordan Justen
On Tue, Sep 4, 2012 at 11:50 AM, Chad Versace wrote: > glGetStringi(GL_EXTENSIONS) failed to respect the context's API, and so > returned all internally enabled GLES extensions from a GL context. > Likewise, glGetIntegerv(GL_NUM_EXTENSIONS) also failed to repsect the > context's API. > > Note: Thi

Re: [Mesa-dev] glxinfo updates?

2012-09-04 Thread Dave Airlie
On Fri, Aug 31, 2012 at 1:32 AM, Ian Romanick wrote: > On 08/30/2012 02:33 PM, Brian Paul wrote: >> >> On 08/30/2012 08:08 AM, Ian Romanick wrote: >>> >>> It occurs to me that, even though the i965 driver can support OpenGL >>> 3.1 on some hardware, glxinfo will only (ever) say 3.0. We don't >>> s

[Mesa-dev] [PATCH] mesa: Don't advertise GLES extensions in GL contexts (v2)

2012-09-04 Thread Chad Versace
glGetStringi(GL_EXTENSIONS) failed to respect the context's API, and so returned all internally enabled GLES extensions from a GL context. Likewise, glGetIntegerv(GL_NUM_EXTENSIONS) also failed to repsect the context's API. v2: Really fix glGetStringi, I promise. Note: This is a candidate for the

Re: [Mesa-dev] [PATCH v2 1/2] main/version: consolodate version string creation for ES/Desktop GL

2012-09-04 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/04/2012 12:08 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen --- > src/mesa/main/version.c | 58 > --- 1 file changed, 24 > insertions(+), 34 deletions(-) Reviewed-by: Chad Versace -B

Re: [Mesa-dev] [PATCH v2 2/2] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/04/2012 12:08 PM, Jordan Justen wrote: > Change the format to [MAJOR.MINOR][CORE|COMPAT] For example: 3.0, CORE, > COMPAT, 3.2CORE > > Signed-off-by: Jordan Justen Reviewed-by: Brian > Paul --- > > v2: * Remove override_version function * Fix

Re: [Mesa-dev] Default CC list of mesa driver bug

2012-09-04 Thread Eric Anholt
Brian Paul writes: > On 09/04/2012 11:40 AM, Eric Anholt wrote: >> Brian Paul writes: >> >>> On 09/02/2012 01:42 PM, Fabio Pedretti wrote: I noticed that mesa bug report got CCed to mesa-dev list, while driver mesa bug went to dri-devel. >>> >>> That does seem kind of weird. >>>

Re: [Mesa-dev] [PATCH] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Kenneth Graunke
On 09/04/2012 12:35 PM, Jordan Justen wrote: > On Tue, Sep 4, 2012 at 10:43 AM, Kenneth Graunke > wrote: >> On 09/01/2012 10:14 AM, Jordan Justen wrote: >>> Change the format to [MAJOR.MINOR][CORE|COMPAT] >>> For example: 3.0, CORE, COMPAT, 3.2CORE >>> >>> Signed-off-by: Jordan Justen >> >> Sinc

Re: [Mesa-dev] [PATCH 1/2] intel: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Eric Anholt
Stéphane Marchesin writes: > The current computation for the lastlevel is based on the level size and can > lead to writing past the end of the texture array. Instead we clamp it by > MAX_TEXTURE_LEVELS. > --- > src/mesa/drivers/dri/intel/intel_tex_image.c |5 + > 1 files changed, 5 inse

Re: [Mesa-dev] [PATCH v2 2/2] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Jordan Justen
On Tue, Sep 4, 2012 at 2:16 PM, Chad Versace wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/04/2012 12:08 PM, Jordan Justen wrote: >> Change the format to [MAJOR.MINOR][CORE|COMPAT] For example: 3.0, CORE, >> COMPAT, 3.2CORE >> >> Signed-off-by: Jordan Justen Reviewed-by: Bria

Re: [Mesa-dev] glxinfo updates?

2012-09-04 Thread Eric Anholt
Dave Airlie writes: > On Fri, Aug 31, 2012 at 1:32 AM, Ian Romanick wrote: >> On 08/30/2012 02:33 PM, Brian Paul wrote: >>> >>> On 08/30/2012 08:08 AM, Ian Romanick wrote: It occurs to me that, even though the i965 driver can support OpenGL 3.1 on some hardware, glxinfo will only

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Brian Paul
On 09/04/2012 01:15 PM, Stéphane Marchesin wrote: The current computation for the lastlevel is based on the level size and can lead to writing past the end of the texture array. Instead we clamp according to hardware limits. --- src/mesa/state_tracker/st_cb_texture.c | 28

Re: [Mesa-dev] [PATCH 1/2] intel: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Stéphane Marchesin
On Tue, Sep 4, 2012 at 2:59 PM, Eric Anholt wrote: > Stéphane Marchesin writes: > >> The current computation for the lastlevel is based on the level size and can >> lead to writing past the end of the texture array. Instead we clamp it by >> MAX_TEXTURE_LEVELS. >> --- >> src/mesa/drivers/dri/int

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Stéphane Marchesin
On Tue, Sep 4, 2012 at 3:08 PM, Brian Paul wrote: > On 09/04/2012 01:15 PM, Stéphane Marchesin wrote: >> >> The current computation for the lastlevel is based on the level size and >> can >> lead to writing past the end of the texture array. Instead we clamp >> according >> to hardware limits. >>

Re: [Mesa-dev] [PATCH 1/2] intel: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Ian Romanick
On 09/04/2012 03:19 PM, Stéphane Marchesin wrote: On Tue, Sep 4, 2012 at 2:59 PM, Eric Anholt wrote: Stéphane Marchesin writes: The current computation for the lastlevel is based on the level size and can lead to writing past the end of the texture array. Instead we clamp it by MAX_TEXTURE_L

Re: [Mesa-dev] [PATCH 1/2] intel: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Stéphane Marchesin
On Tue, Sep 4, 2012 at 3:27 PM, Ian Romanick wrote: > On 09/04/2012 03:19 PM, Stéphane Marchesin wrote: >> >> On Tue, Sep 4, 2012 at 2:59 PM, Eric Anholt wrote: >>> >>> Stéphane Marchesin writes: >>> The current computation for the lastlevel is based on the level size and can lead

Re: [Mesa-dev] [PATCH] mesa: Don't advertise GLES extensions in GL contexts (v2)

2012-09-04 Thread Kenneth Graunke
On 09/04/2012 02:05 PM, Chad Versace wrote: > glGetStringi(GL_EXTENSIONS) failed to respect the context's API, and so > returned all internally enabled GLES extensions from a GL context. > Likewise, glGetIntegerv(GL_NUM_EXTENSIONS) also failed to repsect the > context's API. > > v2: Really fix glG

Re: [Mesa-dev] [PATCH 1/2] intel: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Ian Romanick
On 09/04/2012 03:32 PM, Stéphane Marchesin wrote: On Tue, Sep 4, 2012 at 3:27 PM, Ian Romanick wrote: On 09/04/2012 03:19 PM, Stéphane Marchesin wrote: On Tue, Sep 4, 2012 at 2:59 PM, Eric Anholt wrote: Stéphane Marchesin writes: The current computation for the lastlevel is based on the

Re: [Mesa-dev] [PATCH 5/8] i965: Prepare the uip/jip setting for compacted instructions in the program.

2012-09-04 Thread Paul Berry
On 31 August 2012 11:32, Eric Anholt wrote: > The first cut at instruction compaction won't compact things that > would change control flow jump distances, but we do need to still be > able to walk the instruction stream, which involves jumping by 8 or 16 > bytes between instructions. > I'm not

Re: [Mesa-dev] [PATCH v2 2/2] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/04/2012 03:03 PM, Jordan Justen wrote: > On Tue, Sep 4, 2012 at 2:16 PM, Chad Versace > wrote: On 09/04/2012 12:08 PM, Jordan Justen wrote: Change the format to [MAJOR.MINOR][CORE|COMPAT] For example: 3.0, CORE, COMPAT, 3.2CORE >

Re: [Mesa-dev] [PATCH 1/2] intel: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Brian Paul
On 09/04/2012 04:39 PM, Ian Romanick wrote: On 09/04/2012 03:32 PM, Stéphane Marchesin wrote: On Tue, Sep 4, 2012 at 3:27 PM, Ian Romanick wrote: On 09/04/2012 03:19 PM, Stéphane Marchesin wrote: On Tue, Sep 4, 2012 at 2:59 PM, Eric Anholt wrote: Stéphane Marchesin writes: The current

Re: [Mesa-dev] [PATCH 1/2] intel: Prevent huge lastlevel values from being computed.

2012-09-04 Thread Stéphane Marchesin
On Tue, Sep 4, 2012 at 4:01 PM, Brian Paul wrote: > On 09/04/2012 04:39 PM, Ian Romanick wrote: >> >> On 09/04/2012 03:32 PM, Stéphane Marchesin wrote: >>> >>> On Tue, Sep 4, 2012 at 3:27 PM, Ian Romanick >>> wrote: On 09/04/2012 03:19 PM, Stéphane Marchesin wrote: > > > On

Re: [Mesa-dev] [PATCH 7/8] i965: Support instruction compaction between control flow.

2012-09-04 Thread Paul Berry
On 31 August 2012 11:32, Eric Anholt wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 111 > ++-- > 1 file changed, 87 insertions(+), 24 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c > b/src/mesa/drivers/dri/i965/brw_eu_compact.c > i

Re: [Mesa-dev] [PATCH 8/8] i965: Add support for instruction compression on Gen7.

2012-09-04 Thread Paul Berry
On 31 August 2012 11:32, Eric Anholt wrote: > From: Kenneth Graunke > > Reduces l4d2 program size from 1195kb to 919kb. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_eu.c |2 + > src/mesa/drivers/dri/i965/brw_eu.h |1 + > src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] mesa: Don't advertise GLES extensions in GL contexts (v2)

2012-09-04 Thread Ian Romanick
On 09/04/2012 02:05 PM, Chad Versace wrote: glGetStringi(GL_EXTENSIONS) failed to respect the context's API, and so returned all internally enabled GLES extensions from a GL context. Likewise, glGetIntegerv(GL_NUM_EXTENSIONS) also failed to repsect the context's API. v2: Really fix glGetStringi,

[Mesa-dev] [PATCH] mesa: fix per-level max texture size error checking

2012-09-04 Thread Brian Paul
From: Brian Paul This is a long-standing omission in Mesa's texture image size checking. We need to take the mipmap level into consideration when checking if the width, height and depth are too large. Fixes the new piglit max-texture-size-level test. Thanks to Stéphane Marchesin for finding this

[Mesa-dev] [PATCH 1/2] _mesa_meta_GenerateMipmap: Support all texture targets by generating shaders at runtime

2012-09-04 Thread Anuj Phogat
glsl path of _mesa_meta_GenerateMipmap() function would require different fragment shaders depending on the texture target. This patch adds the code to generate appropriate fragment shader programs at run time. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=54296 NOTE: This is a candidate for

[Mesa-dev] [PATCH 2/2] _mesa_meta_GenerateMipmap: Generate separate shaders for glsl 120 / 130

2012-09-04 Thread Anuj Phogat
glsl version of _mesa_meta_GenerateMipmap() would require separate shaders for glsl 120 and 130. NOTE: This is a candidate for stable branches. Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta.c | 149 1 files changed, 90 insertions(+), 59 de

[Mesa-dev] [PATCH v3 0/3] update version & MESA_GL_VERSION_OVERRIDE

2012-09-04 Thread Jordan Justen
v3: * Based on feedback from Ken, Ian and Eric, change the format of MESA_GL_VERSION_OVERRIDE to MAJOR.MINOR[FC] v2: * Remove unused version override_version function * Fix comment on create_version_string v1: * Update MESA_GL_VERSION_OVERRIDE format to be [MAJOR.MINOR][CORE|COMPAT] Jo

[Mesa-dev] [PATCH v3 1/3] main/version: consolodate version string creation for ES/Desktop GL

2012-09-04 Thread Jordan Justen
Signed-off-by: Jordan Justen Reviewed-by: Chad Versace --- src/mesa/main/version.c | 58 --- 1 file changed, 24 insertions(+), 34 deletions(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index f22118a..55bcb35 100644 --- a/src/mes

[Mesa-dev] [PATCH v3 3/3] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

2012-09-04 Thread Jordan Justen
Change the format to MAJOR.MINOR[FC] For example: 2.1, 3.0FC, 3.1 The FC suffix indicates a forward compatible context, and is only valid for versions >= 3.0. Examples: 2.1: GL Legacy/Compatibility context 3.0: GL Legacy/Compatibility context 3.0FC: GL Core Profile context + Forward Compatibl

[Mesa-dev] [PATCH v3 2/3] main/version: add "(Core Profile) to version string for core profiles

2012-09-04 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/version.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index 55bcb35..0d27606 100644 --- a/src/mesa/main/version.c +++ b/src/mesa/main/version.c @@ -65,13 +65,15 @@ cre

[Mesa-dev] [PATCH] Use the correct macro _WIN32 for Windows.

2012-09-04 Thread Vinson Lee
Signed-off-by: Vinson Lee --- src/gallium/auxiliary/util/u_snprintf.c |2 +- src/gallium/auxiliary/util/u_string.h |4 ++-- src/gallium/tests/graw/fs-test.c|2 +- src/gallium/tests/graw/gs-test.c|2 +- src/gallium/tests/graw/vs-test.c|2 +- src/glx/gl

Re: [Mesa-dev] [PATCH] mesa: fix per-level max texture size error checking

2012-09-04 Thread Michel Dänzer
On Die, 2012-09-04 at 20:21 -0600, Brian Paul wrote: > From: Brian Paul > > This is a long-standing omission in Mesa's texture image size checking. > We need to take the mipmap level into consideration when checking if the > width, height and depth are too large. > > Fixes the new piglit max-te

[Mesa-dev] [PATCH 1/9] Remove Xcalloc/Xmalloc/Xfree calls

2012-09-04 Thread Matt Turner
These calls allowed Xlib to use a custom memory allocator, but Xlib has used the standard C library functions since at least its initial import into git in 2003. It seems unlikely that it will grow a custom memory allocator. The functions now just add extra overhead. Replacing them will make future

[Mesa-dev] [PATCH 2/9] glX_proto_send.py: Remove deprecated Xmalloc/Xfree calls

2012-09-04 Thread Matt Turner
--- src/mapi/glapi/gen/glX_proto_send.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mapi/glapi/gen/glX_proto_send.py b/src/mapi/glapi/gen/glX_proto_send.py index c533592..24dc500 100644 --- a/src/mapi/glapi/gen/glX_proto_send.py +++ b/src/mapi/glapi/gen/glX_

[Mesa-dev] [PATCH 4/9] glX_proto_send.py: Don't cast the return value of malloc

2012-09-04 Thread Matt Turner
--- src/mapi/glapi/gen/glX_proto_send.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mapi/glapi/gen/glX_proto_send.py b/src/mapi/glapi/gen/glX_proto_send.py index 24dc500..d42f661 100644 --- a/src/mapi/glapi/gen/glX_proto_send.py +++ b/src/mapi/glapi/gen/glX_prot

[Mesa-dev] [PATCH 5/9] Remove useless checks for NULL before freeing

2012-09-04 Thread Matt Turner
This patch has been generated by the following Coccinelle semantic patch: // Remove useless checks for NULL before freeing // // free (NULL) is a no-op, so there is no need to avoid it @@ expression E; @@ + free (E); + E = NULL; - if (unlikely (E != NULL)) { - free(E); ( - E = NULL; | - E =

[Mesa-dev] [PATCH 6/9] Use calloc instead of malloc/memset-0

2012-09-04 Thread Matt Turner
This patch has been generated by the following Coccinelle semantic patch: @@ expression E; identifier I; @@ - I = malloc(E); + I = calloc(1, E); ... - memset(I, 0, sizeof *I); --- src/egl/drivers/dri2/egl_dri2.c |4 +--- src/egl/drivers/dri2/platform_drm.c |7 ++- src/egl/

[Mesa-dev] [PATCH 7/9] Remove useless memset after calloc

2012-09-04 Thread Matt Turner
--- src/glx/dri_glx.c |1 - src/glx/drisw_glx.c |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c index 3a727e5..03237d4 100644 --- a/src/glx/dri_glx.c +++ b/src/glx/dri_glx.c @@ -850,7 +850,6 @@ driCreateScreen(int screen, struct

[Mesa-dev] [PATCH 8/9] Replace another malloc/memset-0 combination with calloc

2012-09-04 Thread Matt Turner
--- src/glx/indirect_glx.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c index f3cc1e7..ff869e2 100644 --- a/src/glx/indirect_glx.c +++ b/src/glx/indirect_glx.c @@ -361,14 +361,13 @@ indirect_create_context(struct glx_scr

[Mesa-dev] [PATCH 9/9] Remove useless checks for NULL before freeing

2012-09-04 Thread Matt Turner
Same as earlier commit, except for "FREE" This patch has been generated by the following Coccinelle semantic patch: // Remove useless checks for NULL before freeing // // free (NULL) is a no-op, so there is no need to avoid it @@ expression E; @@ + FREE (E); + E = NULL; - if (unlikely (E != NULL