[Mesa-dev] [PATCH] mesa: Fix memory leak in _mesa_get_uniform_location.

2012-03-23 Thread Vinson Lee
Fixes Coverity resource leak defect. NOTE: This is a candidate for the 8.0 branch. Signed-off-by: Vinson Lee --- src/mesa/main/uniform_query.cpp |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 99

[Mesa-dev] [Bug 47742] [softpipe] piglit fbo-generatemipmap-array regression

2012-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47742 --- Comment #2 from José Fonseca 2012-03-23 00:14:00 PDT --- I took another look at the commit, and now noticed numFaces is never set to 6 for cube maps. Perhaps the test or mipmap generation is relying on texture to not be complete. -- Confi

Re: [Mesa-dev] [PATCH] mesa: Fix memory leak in _mesa_get_uniform_location.

2012-03-23 Thread Jose Fonseca
Looks good. Jose - Original Message - > Fixes Coverity resource leak defect. > > NOTE: This is a candidate for the 8.0 branch. > > Signed-off-by: Vinson Lee > --- > src/mesa/main/uniform_query.cpp |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/src/me

Re: [Mesa-dev] [PATCH 09/15] configure.ac: Don't sort GALLIUM_WINSYS_DIRS

2012-03-23 Thread Jakob Bornecrantz
- Original Message - > From: Tom Stellard > > This allows targets to order winsys directories, so dependencies are > built in the correct order. This makes me think you have done something wrong in winsys, can you please tell my why this is needed, the theory behind it is that winsys's a

Re: [Mesa-dev] [PATCH 10/15] winsys/sw/null: Convert to automake.

2012-03-23 Thread Jakob Bornecrantz
I'm not against this and the other change per say, I just wished all of the winsys's where converted at the same time. Cheers, Jakob. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 12/15] gallium: Add winsys loader for device enumeration and driver multiplexing.

2012-03-23 Thread Jakob Bornecrantz
> +libws_loader_la_LIBADD = \ > + $(top_srcdir)/src/gallium/winsys/sw/null/libws_null.la > + > +if HAVE_XLIB_LOADER_GALLIUM > +libws_loader_la_LIBADD += \ > + $(top_srcdir)/src/gallium/winsys/sw/xlib/libws_xlib.la > +AM_CFLAGS += -DHAVE_WS_LOADER_XLIB > +endif Ah so this explains the not s

Re: [Mesa-dev] [PATCH 12/15] gallium: Add winsys loader for device enumeration and driver multiplexing.

2012-03-23 Thread Francisco Jerez
Jakob Bornecrantz writes: >> +libws_loader_la_LIBADD = \ >> +$(top_srcdir)/src/gallium/winsys/sw/null/libws_null.la >> + >> +if HAVE_XLIB_LOADER_GALLIUM >> +libws_loader_la_LIBADD += \ >> +$(top_srcdir)/src/gallium/winsys/sw/xlib/libws_xlib.la >> +AM_CFLAGS += -DHAVE_WS_LOADER_XLIB >> +en

Re: [Mesa-dev] [PATCH 12/15] gallium: Add winsys loader for device enumeration and driver multiplexing.

2012-03-23 Thread Jakob Bornecrantz
- Original Message - > Jakob Bornecrantz writes: > > >> +libws_loader_la_LIBADD = \ > >> + $(top_srcdir)/src/gallium/winsys/sw/null/libws_null.la > >> + > >> +if HAVE_XLIB_LOADER_GALLIUM > >> +libws_loader_la_LIBADD += \ > >> + $(top_srcdir)/src/gallium/winsys/sw/xlib/libws_xlib.la > >>

[Mesa-dev] [Bug 47742] [softpipe] piglit fbo-generatemipmap-array regression

2012-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47742 --- Comment #3 from Brian Paul 2012-03-23 06:56:04 PDT --- (In reply to comment #2) > I took another look at the commit, and now noticed numFaces is never set to 6 > for cube maps. Good catch. I guess we don't have any tests that exercise inco

[Mesa-dev] [PATCH 1/2] mesa: set numFaces=6 for cube maps in _mesa_test_texobj_completeness()

2012-03-23 Thread Brian Paul
--- src/mesa/main/texobj.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index cfaac64..97bef35 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -567,7 +567,8 @@ _mesa_test_texobj_completeness( const st

[Mesa-dev] [PATCH 2/2] st/mesa: fix mipmap image size computation w.r.t. texture arrays

2012-03-23 Thread Brian Paul
The image height or depth is the array_size for array textures. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=47742 NOTE: This is a candidate for the 8.0 branch. --- src/mesa/state_tracker/st_gen_mipmap.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --gi

Re: [Mesa-dev] [PATCH 1/2] mesa: set numFaces=6 for cube maps in _mesa_test_texobj_completeness()

2012-03-23 Thread Jakob Bornecrantz
- Original Message - > --- > src/mesa/main/texobj.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c > index cfaac64..97bef35 100644 > --- a/src/mesa/main/texobj.c > +++ b/src/mesa/main/texobj.c > @@ -567,7 +56

Re: [Mesa-dev] [PATCH 1/2] mesa: set numFaces=6 for cube maps in _mesa_test_texobj_completeness()

2012-03-23 Thread Brian Paul
On 03/23/2012 08:21 AM, Jakob Bornecrantz wrote: - Original Message - --- src/mesa/main/texobj.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index cfaac64..97bef35 100644 --- a/src/mesa/main/texobj.c +++ b/

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix mipmap image size computation w.r.t. texture arrays

2012-03-23 Thread Jakob Bornecrantz
- Original Message - > The image height or depth is the array_size for array textures. > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=47742 > > NOTE: This is a candidate for the 8.0 branch. Reviewed-by: Jakob Bornecrantz > --- > src/mesa/state_tracker/st_gen_mipmap.c | 18 +

Re: [Mesa-dev] [PATCH 1/2] mesa: set numFaces=6 for cube maps in _mesa_test_texobj_completeness()

2012-03-23 Thread Jose Fonseca
Looks good. Jose - Original Message - > --- > src/mesa/main/texobj.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c > index cfaac64..97bef35 100644 > --- a/src/mesa/main/texobj.c > +++ b/src/mesa/main/texob

[Mesa-dev] [Bug 47742] [softpipe] piglit fbo-generatemipmap-array regression

2012-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47742 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [PATCH] intel: fix TFP at 16-bpp

2012-03-23 Thread Dave Airlie
don't ask why I had to debug this. tested to fix g-s and kwin at 16-bpp on Ironlake. Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/intel/intel_tex_image.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_tex_image.c

[Mesa-dev] [PATCH] glx/drisw: avoid segfaults when we fail to get visual

2012-03-23 Thread Dave Airlie
From: Dave Airlie piglit glx-tfp segfaults on llvmpipe when run vs a 16-bit radeon screen, it now fails instead of segfaulting, much prettier. Signed-off-by: Dave Airlie --- src/glx/drisw_glx.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/glx/drisw_gl

Re: [Mesa-dev] [PATCH] mesa: Fix memory leak in _mesa_get_uniform_location.

2012-03-23 Thread Kenneth Graunke
On 03/23/2012 12:09 AM, Vinson Lee wrote: Fixes Coverity resource leak defect. NOTE: This is a candidate for the 8.0 branch. Signed-off-by: Vinson Lee --- src/mesa/main/uniform_query.cpp |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/uniform_query.c

[Mesa-dev] [PATCH] draw: fix missing immediates bug in polygon stipple code

2012-03-23 Thread Brian Paul
The function that counts the number of TGSI immediates also needs to emit the immediates. This fixes assorted failures when using polygon stipple with fragment shaders that have their own immediates. NOTE: This is a candidate for the 8.0 branch. --- src/gallium/auxiliary/draw/draw_pipe_pstipple.

Re: [Mesa-dev] [PATCH] glx/drisw: avoid segfaults when we fail to get visual

2012-03-23 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > From: Dave Airlie > > piglit glx-tfp segfaults on llvmpipe when run vs a 16-bit radeon > screen, > > it now fails instead of segfaulting, much prettier. > > Signed-off-by: Dave Airlie > --- > src/glx/drisw_glx.c | 11 +-- > 1 f

Re: [Mesa-dev] [PATCH 09/15] configure.ac: Don't sort GALLIUM_WINSYS_DIRS

2012-03-23 Thread Marek Olšák
The main reason for the sorting was to remove duplicates. r300g adds "drivers/r300" and "winsys/radeon", while r600g adds "drivers/r600" and also "winsys/radeon", so the winsys directory appears twice in GALLIUM_WINSYS_DIRS. Nevertheless, I've got the same hunch as Jakob. This patch seems to just

[Mesa-dev] [PATCH 1/2] glapi: add GL_ARB_depth_buffer_float

2012-03-23 Thread nobled
--- These are based on the sorting-the-xml patches I forgot to push a while back: http://lists.freedesktop.org/archives/mesa-dev/2012-January/017610.html Which I'll push along with these if they're okay to commit. src/mapi/glapi/gen/ARB_depth_buffer_float.xml | 15 +++ src/mapi/glap

[Mesa-dev] [PATCH 2/2] glapi: add GL_ARB_texture_float

2012-03-23 Thread nobled
And add some missing core GL 3.0 enums that came from this extension, too. --- src/mapi/glapi/gen/ARB_texture_float.xml | 36 ++ src/mapi/glapi/gen/GL3x.xml |7 + src/mapi/glapi/gen/Makefile |1 + src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [Bug 47248] autogen missing dependency on flex and bison, causes infinite loop in glsl build

2012-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47248 Joel changed: What|Removed |Added CC||k00_...@k.kth.se Keywords|

[Mesa-dev] [PATCH] mesa: Fix memory leak in generate_mipmap_compressed.

2012-03-23 Thread Vinson Lee
Fixes Coverity resource leak defect. NOTE: This is candidate for the 8.0 branch. Signed-off-by: Vinson Lee --- src/mesa/main/mipmap.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/mipmap.c b/src/mesa/main/mipmap.c index 756316a..abd26b8 100644 --- a/src/