[Mesa-dev] [Bug 42128] Crash when visiting a site with Firefox

2011-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42128 --- Comment #5 from Thor 2011-10-27 02:53:52 UTC --- Created attachment 52818 --> https://bugs.freedesktop.org/attachment.cgi?id=52818 The output of glxinfo -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- Yo

Re: [Mesa-dev] Implement NV_fog_distance for Gallium hardware

2011-10-27 Thread Marek Olšák
If there are no other concerns, I'll push this on Saturday, including the nv20 fix from Francisco Jerez. http://cgit.freedesktop.org/~mareko/mesa/log/?h=nv-fog-distance Marek On Tue, Sep 20, 2011 at 7:50 AM, Nicholas Miell wrote: > On 09/19/2011 10:23 AM, Ian Romanick wrote: >> >> I guess the b

Re: [Mesa-dev] Implement NV_fog_distance for Gallium hardware

2011-10-27 Thread Jose Fonseca
I only see implementation for ffvertex_prog.c Wasn't (or will soon be) the FF->Mesa IR replaced with FF->GLSL IR? If so, can you truly enable unconditionally on gallium/st? Jose - Original Message - > If there are no other concerns, I'll push this on Saturday, including > the nv20 fix

Re: [Mesa-dev] Implement NV_fog_distance for Gallium hardware

2011-10-27 Thread Marek Olšák
From what I can see, the fog distance is computed per-vertex and stored in the FogCoord vertex shader output. There is no fragment shader change required. The fixed-function vertex program hasn't been converted to the GLSL IR yet, only the fragment program, which is irrelevant here. Gallium only u

Re: [Mesa-dev] Implement NV_fog_distance for Gallium hardware

2011-10-27 Thread Jose Fonseca
- Original Message - > From what I can see, the fog distance is computed per-vertex and > stored in the FogCoord vertex shader output. There is no fragment > shader change required. The fixed-function vertex program hasn't been > converted to the GLSL IR yet, only the fragment program, whic

Re: [Mesa-dev] [PATCH 1/5] glsl: Fix copy-paste error in constant_expression_value(ir_binop_nequal)

2011-10-27 Thread Eric Anholt
On Wed, 26 Oct 2011 18:42:52 -0700, Paul Berry wrote: > The implementation of ir_binop_nequal in constant_expression_value() > appears to have been copy-and-pasted from the implementation of > ir_binop_equal, but with all instances of '==' changed to '!='. This > is correct except for one minor f

[Mesa-dev] [Bug 42313] New: software rasterizer: ignore glTexCoordPointer if GL_TEXTURE_2D is disabled

2011-10-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42313 Bug #: 42313 Summary: software rasterizer: ignore glTexCoordPointer if GL_TEXTURE_2D is disabled Classification: Unclassified Product: Mesa Version: 7.11 Platform: x86

Re: [Mesa-dev] [PATCH] r600g: Replace needless flush in texture upload.

2011-10-27 Thread Mathias Fröhlich
Hi, On Saturday, October 22, 2011 13:36:37 Mathias Fröhlich wrote: > The attached patch reduces the amount of pipe flushes for r600g. > I am not exactly sure if we could skip this flush entirely because of the > internal r600g winsys flush logic. > But what we can do is the attached patch: > > R

Re: [Mesa-dev] [PATCH] r600g: Replace needless flush in texture upload.

2011-10-27 Thread Marek Olšák
Looks good to me. Ideally even texture_barrier should not be needed. set_framebuffer_state() and flush() should flush caches automatically. If they don't, there is a bug. Marek 2011/10/27 Mathias Fröhlich : > > Hi, > > On Saturday, October 22, 2011 13:36:37 Mathias Fröhlich wrote: >> The attached

Re: [Mesa-dev] [PATCH] r600g: Replace needless flush in texture upload.

2011-10-27 Thread Fredrik Höglund
On Thursday 27 October 2011, Mathias Fröhlich wrote: > > Hi, > > On Saturday, October 22, 2011 13:36:37 Mathias Fröhlich wrote: > > The attached patch reduces the amount of pipe flushes for r600g. > > I am not exactly sure if we could skip this flush entirely because of the > > internal r600g win

Re: [Mesa-dev] [PATCH] glsl: translate transform feedback varyings into low-level representation

2011-10-27 Thread Kenneth Graunke
On 10/26/2011 03:28 PM, Marek Olšák wrote: > This adds a function that takes an array of varyings from > glTranformFeedbackVaryingsEXT and generates gl_transform_feedback_info, > which is supposed to be consumed by drivers. Useful for ir_to_mesa > and glsl_to_tgsi. > > With Dan McCabe's patch, I t

Re: [Mesa-dev] mis-counting varying vars in the linker

2011-10-27 Thread Ian Romanick
On 10/26/2011 11:11 AM, Brian Paul wrote: I think the linker is mis-counting gl_TexCoord[] varying vars when linking. For example, if we have this vertex/fragment shader combination: // vs void main() { gl_Position = ftransform(); gl_TexCoord[6] = gl_MultiTexCoord[0]; } // fs void main() { gl

Re: [Mesa-dev] [PATCH 17/33] i965: Fold prepare() and emit() of VS surface state setup together.

2011-10-27 Thread Paul Berry
On 24 October 2011 14:17, Eric Anholt wrote: > This rearranges the code a bit, and makes the upload of the binding > table take only as many surfaces as there are in use. > --- > src/mesa/drivers/dri/i965/brw_vs_surface_state.c | 62 > +- > 1 files changed, 25 insertions(+)

Re: [Mesa-dev] i965 batch rollback: no more prepare() vs emit().

2011-10-27 Thread Paul Berry
On 24 October 2011 14:16, Eric Anholt wrote: > I did do some testing by making libdrm claim a smaller aperture size > and thus trigger the rollback code, which caught one bug. Generally, > piglit doesn't trigger rollback at all, which is a bit concerning from > a testing coverage standpoint. > >

[Mesa-dev] [PATCH] glsl: Remove pointless uses of glsl_type::get_base_type().

2011-10-27 Thread Kenneth Graunke
These are effectively doing type->get_base_type()->base_type, which is equivalent to type->base_type. Just use that, as it's simpler. Signed-off-by: Kenneth Graunke --- src/glsl/ir_print_visitor.cpp |4 +--- src/glsl/ir_reader.cpp|6 ++ 2 files changed, 3 insertions(+), 7 de

[Mesa-dev] [PATCH] i965: Use the actual hardware g0 register for texel offset setup.

2011-10-27 Thread Kenneth Graunke
The idea here is to set up the message header with the Sampler State pointer which the hardware provides as part of the PS Thread Payload in register g0. Unfortunately, the existing code fs_reg(GRF, 0, BRW_REGISTER_TYPE_UD)) actually references "virtual GRF 0" rather than the hardware g0. Th

Re: [Mesa-dev] [PATCH] glsl: Implement GLSL 1.30's literal integer range restrictions.

2011-10-27 Thread Paul Berry
On 26 October 2011 13:00, Eric Anholt wrote: > From page 22 (28 of PDF) of GLSL 1.30 spec: >It is an error to provide a literal integer whose magnitude is too >large to store in a variable of matching signed or unsigned type. > >Unsigned integers have exactly 32 bits of precision. Si

Re: [Mesa-dev] [PATCH] glsl: Implement GLSL 1.30's literal integer range restrictions.

2011-10-27 Thread Ian Romanick
On 10/26/2011 01:00 PM, Eric Anholt wrote: From page 22 (28 of PDF) of GLSL 1.30 spec: It is an error to provide a literal integer whose magnitude is too large to store in a variable of matching signed or unsigned type. Unsigned integers have exactly 32 bits of precision. Signed

Re: [Mesa-dev] [PATCH] glsl: Remove pointless uses of glsl_type::get_base_type().

2011-10-27 Thread Ian Romanick
On 10/27/2011 10:48 AM, Kenneth Graunke wrote: These are effectively doing type->get_base_type()->base_type, which is equivalent to type->base_type. Just use that, as it's simpler. Signed-off-by: Kenneth Graunke Reviewed-by: Ian Romanick --- src/glsl/ir_print_visitor.cpp |4 +--- sr

Re: [Mesa-dev] [PATCH 1/5] glsl: Fix copy-paste error in constant_expression_value(ir_binop_nequal)

2011-10-27 Thread Ian Romanick
On 10/26/2011 06:42 PM, Paul Berry wrote: The implementation of ir_binop_nequal in constant_expression_value() appears to have been copy-and-pasted from the implementation of ir_binop_equal, but with all instances of '==' changed to '!='. This is correct except for one minor flaw: one of those '

Re: [Mesa-dev] [PATCH] gallium: implement WGL_ARB_create_context

2011-10-27 Thread Jose Fonseca
Margan, The code in the diff has wrapped-around and can't be applied automatically. Please re-send the patch as an attachment. Jose - Original Message - > Here is the modified patch. I just checked if it works but doesn't > have a good test case for it. But I will write one for sure! >

[Mesa-dev] [PATCH] mesa: Fix memory leak in out-of-memory path.

2011-10-27 Thread Vinson Lee
Fixes Coverity resource leak defect. --- src/mesa/main/pack.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c index ecdeaf5..539a06c 100644 --- a/src/mesa/main/pack.c +++ b/src/mesa/main/pack.c @@ -1983,6 +1983,7 @@ _mesa_pack_rg

[Mesa-dev] [PATCH 1/2] i965: Use glsl_type::column_type instead of open-coding it

2011-10-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index 02ecdaf..1312c0d 1

[Mesa-dev] [PATCH 2/2] ir_to_mesa: Let check_resources halt compilation

2011-10-27 Thread Ian Romanick
From: Ian Romanick Previously check_resources could fail, but we'd still try to optimize the shader, do device-specific code generation, etc. In some cases, this could explode (especially in the device-specific code generation). I haven't found that I could trigger this with the current code.

[Mesa-dev] [PATCH 0/5] intel: Replace renderbuffer region with miptree

2011-10-27 Thread Chad Versace
See the commit meesage for patch 5/5. Chad Versace (5): intel: Temporarily disable HiZ for textures intel: Define intel_miptree_create_for_renderbuffer() intel: Kill intel_framebuffer_get_hiz_region() intel: Move inline functions from intel_fbo.h to intel_fbo.c intel: Replace intel_rende

[Mesa-dev] [PATCH 1/5] intel: Temporarily disable HiZ for textures

2011-10-27 Thread Chad Versace
A great refactor thrashing begins after this commit. Removing code for texture HiZ will make that refactoring easier. HiZ was broken for textures anyway, so there's no regression here. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/intel/intel_fbo.c | 62 ++--

[Mesa-dev] [PATCH 2/5] intel: Define intel_miptree_create_for_renderbuffer()

2011-10-27 Thread Chad Versace
This function creates a miptree that is suitable as the storage for a non-texture renderbuffer. This commit is prerequisite for replacing intel_renderbuffer::region with a miptree. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 21 + src/m

[Mesa-dev] [PATCH 3/5] intel: Kill intel_framebuffer_get_hiz_region()

2011-10-27 Thread Chad Versace
The only client of intel_framebuffer_get_hiz_region() was intel_framebuffer_has_hiz(). So I folded the body of the former into the latter. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/intel/intel_fbo.h | 20 +++- 1 files changed, 3 insertions(+), 17 deletions(-) diff -

[Mesa-dev] [PATCH 4/5] intel: Move inline functions from intel_fbo.h to intel_fbo.c

2011-10-27 Thread Chad Versace
Move the following inline functions: intel_get_rb_region intel_framebuffer_has_hiz A future commit will replace the renderbuffer's region with a miptree. This small refactor will eliminate the need for intel_fbo.h to include intel_mipmap_tree.h on that commit. I'd like to avoid the situati

[Mesa-dev] [PATCH 5/5] intel: Replace intel_renderbuffer::region with a miptree

2011-10-27 Thread Chad Versace
This is in preparation for 1) fixing the implementation of glFramebufferTexture(GL_DEPTH_STENCIL) for separate stencil and 2) supporting HiZ for miptrees. As a nice benefit, this lays down some preliminary groundwork for easily texturing from any renderbuffer, even those of the window system. With

Re: [Mesa-dev] [PATCH 2/5] glsl: Extend s-expression parsing to handle infinity.

2011-10-27 Thread Kenneth Graunke
On 10/26/2011 06:42 PM, Paul Berry wrote: > In order to implement the GLSL 1.30 isinf() function, it will be > necessary to be able to represent infinity in the GLSL IR s-expression > format. This patch extends the s-expression parser so that it treats > the string "#inf" as a floating point value

Re: [Mesa-dev] [PATCH 2/2] ir_to_mesa: Let check_resources halt compilation

2011-10-27 Thread Kenneth Graunke
On 10/27/2011 02:59 PM, Ian Romanick wrote: > From: Ian Romanick > > Previously check_resources could fail, but we'd still try to optimize > the shader, do device-specific code generation, etc. In some cases, > this could explode (especially in the device-specific code > generation). I haven't