Re: [Mesa-dev] [PATCH 01/13] gallium: add PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS

2011-09-06 Thread Christoph Bumiller
On 05.09.2011 23:44, Marek Olšák wrote: > --- > src/gallium/include/pipe/p_defines.h |1 + > src/mesa/state_tracker/st_extensions.c |3 +++ > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/src/gallium/include/pipe/p_defines.h > b/src/gallium/include/pipe/p_defines.h >

[Mesa-dev] [Bug 40401] Cogs is slow

2011-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40401 Niels Ole Salscheider changed: What|Removed |Added CC||niels_ole@salscheider-onlin

Re: [Mesa-dev] [PATCH 01/13] gallium: add PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS

2011-09-06 Thread Jose Fonseca
- Original Message - > On 05.09.2011 23:44, Marek Olšák wrote: > > --- > > src/gallium/include/pipe/p_defines.h |1 + > > src/mesa/state_tracker/st_extensions.c |3 +++ > > 2 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/src/gallium/include/pipe/p_defines.h

Re: [Mesa-dev] [PATCH 1/3] glsl/builtins: Fix invalid vecN constants in hyperbolic functions.

2011-09-06 Thread Paul Berry
On 5 September 2011 12:24, Kenneth Graunke wrote: > Each of these vecN constants only provided one component, which is > illegal. The printed IR is meant to contain exactly as many components > as are necessary; the IR reader does not splat single values. > > Signed-off-by: Kenneth Graunke > --

Re: [Mesa-dev] [PATCH] mesa: add a UniformBooleanTrue option

2011-09-06 Thread Eric Anholt
On Mon, 5 Sep 2011 14:59:03 -0500, Bryan Cain wrote: > Drivers supporting native integers set UniformBooleanTrue to the integer value > that should be used for true when uploading uniform booleans. This is ~0 for > Gallium and 1 for i965. Looks good. Reviewed-by: Eric Anholt pgpm1u1Bwud8c.p

Re: [Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-06 Thread Eric Anholt
On Tue, 6 Sep 2011 09:34:00 +0800, Yuanhan Liu wrote: > Fix the constant interpolation enable bit mask for flat light mode. > FRAG_BIT_COL0 attribute bit might be 0, in which case we need to > shift one more bit right. > > This would fix the oglc specularColor test fail on both Sandybridge and

Re: [Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-06 Thread Kenneth Graunke
On 09/05/2011 06:34 PM, Yuanhan Liu wrote: > Fix the constant interpolation enable bit mask for flat light mode. > FRAG_BIT_COL0 attribute bit might be 0, in which case we need to > shift one more bit right. > > This would fix the oglc specularColor test fail on both Sandybridge and > Ivybridge. >

Re: [Mesa-dev] new-vs on gen4

2011-09-06 Thread Kenneth Graunke
On 09/02/2011 06:37 PM, Eric Anholt wrote: > This series gets gen4 to be non-regressing for the new vertex shader. > I'd be fine with not pushing the last patch and letting Paul's patches > land, then fixing the bug as it remains there. Once these two land, I > think it's time to turn on the new b

Re: [Mesa-dev] [RFC 0/3] Fix several segmentation faults related to depth buffer

2011-09-06 Thread Eugeni Dodonov
On Mon, Sep 5, 2011 at 16:37, Alon Levy wrote: > Fixes three segmentation faults where it is wrongly assumed the depth > buffer's > renderbuffer's region is not NULL. > > 735794 - verified to be fixed by these three patches (these three apply > to 7.11 almost cleanly, just the second requires min

Re: [Mesa-dev] [PATCH 01/11] mesa: Remove API facing bits of EXT_paletted_texture and EXT_shared_texture_palette

2011-09-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/31/2011 08:36 PM, Brian Paul wrote: > On 08/31/2011 02:21 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This was also discussed at XDS 2010. However, actually making the >> change was delayed because several drivers still exposed these >>

[Mesa-dev] [PATCH 0/9] Stop trying to remap function offset in drivers

2011-09-06 Thread Ian Romanick
This is the first part of a re-spin of my previous extension refactoring patches. This series just removes the function remapping from all of the drivers. This has been handled by remap.c in core Mesa for a long time. The next patch to the list will gut most of the now-unused parts of remap_help

[Mesa-dev] [PATCH 1/9] intel: Enable extensions by just setting the flags

2011-09-06 Thread Ian Romanick
From: Ian Romanick Core Mesa already does the dispatch offset remapping for every function that could possibly ever be supported. There's no need to continue using that cruft in the driver. Reviewed-by: Eric Anholt --- src/mesa/drivers/dri/intel/intel_extensions.c | 290 +

[Mesa-dev] [PATCH 2/9] intel: Move S3TC extension enable bits to intel_extensions.c

2011-09-06 Thread Ian Romanick
From: Ian Romanick Reviewed-by: Eric Anholt --- src/mesa/drivers/dri/intel/intel_context.c|7 --- src/mesa/drivers/dri/intel/intel_extensions.c |8 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/driv

[Mesa-dev] [PATCH 3/9] nouveau: Enable extensions by just setting the flags

2011-09-06 Thread Ian Romanick
From: Ian Romanick Core Mesa already does the dispatch offset remapping for every function that could possibly ever be supported. There's no need to continue using that cruft in the driver. Since the call to _mesa_enable_imaging_extensions (via driInitExtensions) is removed, EXT_blend_color, EX

[Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-06 Thread Ian Romanick
From: Ian Romanick Core Mesa already does the dispatch offset remapping for every function that could possibly ever be supported. There's no need to continue using that cruft in the driver. Since the call to _mesa_enable_imaging_extensions (via driInitExtensions) is removed, EXT_blend_logic_op

[Mesa-dev] [PATCH 6/9] r600: Enable extensions by just setting the flags

2011-09-06 Thread Ian Romanick
From: Ian Romanick Core Mesa already does the dispatch offset remapping for every function that could possibly ever be supported. There's no need to continue using that cruft in the driver. Since the call to _mesa_enable_imaging_extensions (via driInitExtensions) is removed, EXT_blend_color and

[Mesa-dev] [PATCH 5/9] r300: Enable extensions by just setting the flags

2011-09-06 Thread Ian Romanick
From: Ian Romanick Core Mesa already does the dispatch offset remapping for every function that could possibly ever be supported. There's no need to continue using that cruft in the driver. Since the call to _mesa_enable_imaging_extensions (via driInitExtensions) is removed, EXT_blend_color and

[Mesa-dev] [PATCH 8/9] swrast-dri: Remove call to driInitExtensions

2011-09-06 Thread Ian Romanick
From: Ian Romanick The only purpose this call served in the DRI swrast driver was to initialize the remap table. Core Mesa already does the dispatch offset remapping for every function that could possibly ever be supported. There's no need to continue using that cruft in the driver. --- src/me

[Mesa-dev] [PATCH 7/9] radeon: Enable extensions by just setting the flags

2011-09-06 Thread Ian Romanick
From: Ian Romanick Core Mesa already does the dispatch offset remapping for every function that could possibly ever be supported. There's no need to continue using that cruft in the driver. Since the call to _mesa_enable_imaging_extensions (via driInitExtensions) is removed, EXT_blend_color, EX

[Mesa-dev] [PATCH 9/9] dri: Remove all extension enabling utility functions

2011-09-06 Thread Ian Romanick
From: Ian Romanick --- src/mesa/drivers/dri/common/utils.c | 114 -- src/mesa/drivers/dri/common/utils.h | 25 - src/mesa/drivers/dri/intel/intel_extensions_es.c |6 - src/mesa/drivers/dri/swrast/swrast.c |3 - 4 files chan

[Mesa-dev] [PATCH 0/5] glsl: Add front-end support for gl_ClipDistance.

2011-09-06 Thread Paul Berry
This patch series modifies the GLSL front-end to implement all the proper behaviors for gl_ClipDistance, namely: - gl_ClipDistance is predeclared as unsized in both the vertex and fragment shader. - It is an error to size gl_ClipDistance (either explicitly or implicitly) larger than gl_MaxClip

[Mesa-dev] [PATCH 1/5] glsl: Make gl_ClipDistance[] implicitly sized.

2011-09-06 Thread Paul Berry
>From the GLSL 1.30 spec, section 7.1 (Vertex Shader Special Variables): The gl_ClipDistance array is predeclared as unsized and must be sized by the shader either redeclaring it with a size or indexing it only with integral constant expressions. Fixes piglit tests clip-distance-implicit-le

[Mesa-dev] [PATCH 2/5] glsl: Add constant gl_MaxClipDistances.

2011-09-06 Thread Paul Berry
Fixes piglit tests {vs,fs}-clip-distance-sizeable-to-max.shader_test. --- src/glsl/ir_variable.cpp | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/glsl/ir_variable.cpp b/src/glsl/ir_variable.cpp index 3809456..e0b6f38 100644 --- a/src/glsl/ir_variable.cp

[Mesa-dev] [PATCH 3/5] glsl: Rework oversize array check for gl_TexCoord.

2011-09-06 Thread Paul Berry
The check now applies both when explicitly declaring the size of gl_TexCoord and when implicitly setting the size of gl_TexCoord by accessing it using integral constant expressions. This is prep work for adding similar size checks to gl_ClipDistance. Fixes piglit tests texcoord/implicit-access-ma

[Mesa-dev] [PATCH 4/5] glsl: Check that gl_ClipDistance[] is not sized too large.

2011-09-06 Thread Paul Berry
Fixes piglit tests clip-distance-explicit-too-large-with-access.{frag,vert} and clip-distance-explicit-too-large.{frag,vert}. --- src/glsl/ast_to_hir.cpp | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index

[Mesa-dev] [PATCH 5/5] glsl: Make sure gl_ClipDistance and gl_ClipVertex are not both written.

2011-09-06 Thread Paul Berry
>From section 7.1 (Vertex Shader Special Variables) of the GLSL 1.30 spec: "It is an error for a shader to statically write both gl_ClipVertex and gl_ClipDistance." Fixes piglit test mixing-clip-distance-and-clip-vertex-disallowed.c. --- src/glsl/linker.cpp | 19 +++ 1 file

Re: [Mesa-dev] DEATH to old drivers!

2011-09-06 Thread Adam Jackson
On Thu, 2011-08-25 at 07:38 -0700, Kenneth Graunke wrote: > On 08/25/2011 07:03 AM, Ian Romanick wrote: > > That's a fair point. Since we have a clean mechanism to improve those > > interfaces (e.g., DRI2!), there's relatively little cost in keeping that > > code around. > > > > I'd usually be pr

Re: [Mesa-dev] [PATCH 5/9] r300: Enable extensions by just setting the flags

2011-09-06 Thread Corbin Simpson
So much win! I have a couple nits; replying inline. On Tue, Sep 6, 2011 at 1:13 PM, Ian Romanick wrote: > From: Ian Romanick > > Core Mesa already does the dispatch offset remapping for every > function that could possibly ever be supported.  There's no need to > continue using that cruft in the

Re: [Mesa-dev] DEATH to old drivers!

2011-09-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/06/2011 02:17 PM, Adam Jackson wrote: > On Thu, 2011-08-25 at 07:38 -0700, Kenneth Graunke wrote: >> On 08/25/2011 07:03 AM, Ian Romanick wrote: >>> That's a fair point. Since we have a clean mechanism to improve those >>> interfaces (e.g., DRI2

Re: [Mesa-dev] [PATCH 5/9] r300: Enable extensions by just setting the flags

2011-09-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/06/2011 02:45 PM, Corbin Simpson wrote: > So much win! I have a couple nits; replying inline. > > On Tue, Sep 6, 2011 at 1:13 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Core Mesa already does the dispatch offset remapping for every >>

Re: [Mesa-dev] State tracker pipe_surface woes...

2011-09-06 Thread Stéphane Marchesin
2011/9/3 Jose Fonseca : > > > - Original Message - >> 2011/9/2 Stéphane Marchesin : >> > 2011/9/2 Jose Fonseca : >> >> - Original Message - >> >>> Hi, >> >>> >> >>> While debugging some code I ran across the following situation: >> >>> >> >>> - pipe_context c1 is created >> >>> - pi

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-06 Thread Roland Scheidegger
Am 06.09.2011 22:13, schrieb Ian Romanick: > From: Ian Romanick > > Core Mesa already does the dispatch offset remapping for every > function that could possibly ever be supported. There's no need to > continue using that cruft in the driver. > > Since the call to _mesa_enable_imaging_extension

[Mesa-dev] [PATCH 1/8] meta: move texcoord setup into setup_texture_coords()

2011-09-06 Thread Brian Paul
From: Brian Paul --- src/mesa/drivers/common/meta.c | 268 ++-- 1 files changed, 176 insertions(+), 92 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index ad04d36..a0e9316 100644 --- a/src/mesa/drivers/common/meta.

[Mesa-dev] [PATCH 2/8] meta: added _mesa_meta_GetTexImage()

2011-09-06 Thread Brian Paul
From: Brian Paul If the texture is compressed, call the meta decompress_texture_image() function. Otherwise, call the core _mesa_get_teximage() function. --- src/mesa/drivers/common/driverfuncs.c |2 +- src/mesa/drivers/common/meta.c| 224 + src/mesa

[Mesa-dev] [PATCH 3/8] mesa: add new pixel format unpacking code

2011-09-06 Thread Brian Paul
From: Brian Paul This will be used instead of the texel fetch code to unpack images in various formats. --- src/mesa/SConscript |1 + src/mesa/main/format_unpack.c | 1494 + src/mesa/main/format_unpack.h | 49 ++ src/mesa/sources.mak

[Mesa-dev] [PATCH 4/8] mesa: added _mesa_get_uncompressed_format(), _mesa_format_num_components()

2011-09-06 Thread Brian Paul
From: Brian Paul --- src/mesa/main/formats.c | 64 +++ src/mesa/main/formats.h |7 + 2 files changed, 71 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c index c6634c4..11d6706 100644 --- a/src/mes

[Mesa-dev] [PATCH 5/8] mesa: new _mesa_decompress_image() function

2011-09-06 Thread Brian Paul
From: Brian Paul Use the old texture fetch functions to decompress a whole image. To be used by glGetTexImage(). --- src/mesa/main/texcompress.c | 86 +++ src/mesa/main/texcompress.h |5 ++ 2 files changed, 91 insertions(+), 0 deletions(-) diff --gi

[Mesa-dev] [PATCH 6/8] mesa: handle compressed images in get_tex_rgba()

2011-09-06 Thread Brian Paul
From: Brian Paul Uses the new _mesa_decompress_image() function. Unlike the meta path that uses textured quad rendering to do decompression, this works with signed formats as well. --- src/mesa/main/texgetimage.c | 164 --- 1 files changed, 106 insertion

[Mesa-dev] [PATCH 7/8] mesa: use ctx->Driver.GetTexImage() to decompress base texture image

2011-09-06 Thread Brian Paul
From: Brian Paul This is a simple way to do the job and it removes one more use of the soon-to-be-removed gl_texture_image::FetchTexelc() function. --- src/mesa/main/mipmap.c | 85 --- 1 files changed, 43 insertions(+), 42 deletions(-) diff --git a/

[Mesa-dev] [PATCH 8/8] mesa: use _mesa_unpack_float_z_row in get_tex_depth()

2011-09-06 Thread Brian Paul
From: Brian Paul Removes another use of the gl_texture_image::FetchTexelf() function. --- src/mesa/main/texgetimage.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index a39ac59..4ab39a4 100644 --- a/

Re: [Mesa-dev] State tracker pipe_surface woes...

2011-09-06 Thread Roland Scheidegger
Am 07.09.2011 00:01, schrieb Stéphane Marchesin: > 2011/9/3 Jose Fonseca : >> >> >> - Original Message - >>> 2011/9/2 Stéphane Marchesin : 2011/9/2 Jose Fonseca : > - Original Message - >> Hi, >> >> While debugging some code I ran across the following situation:

Re: [Mesa-dev] [PATCH 0/9] Stop trying to remap function offset in drivers

2011-09-06 Thread Kenneth Graunke
On 09/06/2011 01:13 PM, Ian Romanick wrote: > This is the first part of a re-spin of my previous extension > refactoring patches. This series just removes the function remapping > from all of the drivers. This has been handled by remap.c in core > Mesa for a long time. > > The next patch to the

Re: [Mesa-dev] State tracker pipe_surface woes...

2011-09-06 Thread Stéphane Marchesin
2011/9/6 Roland Scheidegger : > Am 07.09.2011 00:01, schrieb Stéphane Marchesin: >> 2011/9/3 Jose Fonseca : >>> >>> >>> - Original Message - 2011/9/2 Stéphane Marchesin : > 2011/9/2 Jose Fonseca : >> - Original Message - >>> Hi, >>> >>> While debugging some

Re: [Mesa-dev] [PATCH 07/13] r600g: fix texture array filtering

2011-09-06 Thread Marek Olšák
On Tue, Sep 6, 2011 at 8:29 AM, Dave Airlie wrote: > On Mon, Sep 5, 2011 at 10:44 PM, Marek Olšák wrote: >> This fixes piglit/fbo-generatemipmap-array. >> >> It looks like SQ_TEX_SAMPLER_WORD0_0.TEX_ARRAY_OVERRIDE should be set >> for array textures in order to disable filtering between slices, >

Re: [Mesa-dev] [PATCH 0/5] glsl: Add front-end support for gl_ClipDistance.

2011-09-06 Thread Kenneth Graunke
On 09/06/2011 01:51 PM, Paul Berry wrote: > This patch series modifies the GLSL front-end to implement all the > proper behaviors for gl_ClipDistance, namely: > > - gl_ClipDistance is predeclared as unsized in both the vertex and > fragment shader. > - It is an error to size gl_ClipDistance (eit

[Mesa-dev] [Bug 40668] New: Mesa compilation failure with wayland master

2011-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40668 Summary: Mesa compilation failure with wayland master Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medi

Re: [Mesa-dev] [PATCH 01/13] gallium: add PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS

2011-09-06 Thread Marek Olšák
On Tue, Sep 6, 2011 at 12:12 PM, Jose Fonseca wrote: > - Original Message - >> On 05.09.2011 23:44, Marek Olšák wrote: >> > --- >> >  src/gallium/include/pipe/p_defines.h   |    1 + >> >  src/mesa/state_tracker/st_extensions.c |    3 +++ >> >  2 files changed, 4 insertions(+), 0 deletions(

Re: [Mesa-dev] State tracker pipe_surface woes...

2011-09-06 Thread Stéphane Marchesin
2011/9/2 Jose Fonseca : > - Original Message - >> Hi, >> >> While debugging some code I ran across the following situation: >> >> - pipe_context c1 is created >> - pipe_surface s1 is created >> - strb-> surface is set to s1 (s1's refcount goes up) >> - pipe_context c1 is destroyed >> - strb