Re: [Mesa-dev] [RFC 01/27] i965: Remove unused sampler key fields

2014-02-24 Thread Chris Forbes
Ken, Just noticed -- all those fields that we're keeping need to be widened to uint32_t for 32 samplers. None of our sampler quirks get flagged correctly for `high` samplers on Haswell at present. I'll send some patches for that this evening if no one beats me to it. -- Chris On Tue, Feb 25, 201

Re: [Mesa-dev] [RFC 01/27] i965: Remove unused sampler key fields

2014-02-24 Thread Kenneth Graunke
On 02/24/2014 10:48 AM, Ian Romanick wrote: > It seems very weird that these are unused. Are GL_YCBCR_MESA just > completely broken on our driver? If so, we should probably disable that > extension... Yeah. The old fragment shader backend had code for this, which used these fields, but the new

Re: [Mesa-dev] [RFC 01/27] i965: Remove unused sampler key fields

2014-02-24 Thread Ian Romanick
It seems very weird that these are unused. Are GL_YCBCR_MESA just completely broken on our driver? If so, we should probably disable that extension... On 02/22/2014 01:05 AM, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_program.h | 6 --