Re: [Mesa-dev] [PATCH v2] radeonsi: Add CIK SDMA support

2014-10-03 Thread Michel Dänzer
On 02.10.2014 19:14, Marek Olšák wrote: 1) We should have our own copyright in the new file. Other than that: Reviewed-by: Marek Olšák The following things can be done in a separate patch. 2) I recommend removing the CMASK and FMASK checking and replacing it with nr_samples > 1 (for SI too).

Re: [Mesa-dev] [PATCH v2] radeonsi: Add CIK SDMA support

2014-10-02 Thread Marek Olšák
1) We should have our own copyright in the new file. Other than that: Reviewed-by: Marek Olšák The following things can be done in a separate patch. 2) I recommend removing the CMASK and FMASK checking and replacing it with nr_samples > 1 (for SI too). For nr_samples <= 1, CMASK checking is alr