On 02.10.2014 19:14, Marek Olšák wrote:
1) We should have our own copyright in the new file.
Other than that:
Reviewed-by: Marek Olšák <marek.ol...@amd.com>
The following things can be done in a separate patch.
2) I recommend removing the CMASK and FMASK checking and replacing it
with nr_samples > 1 (for SI too). For nr_samples <= 1, CMASK checking
is already covered by dirty_level_mask checking and CMASK is pretty
much disabled after the flush_resource call, whose sole purpose is to
decompress a surface with CMASK.
3) I'm pretty sure this won't work with HTILE and flush_resource
doesn't decompress a surface with HTILE. The solution is to check
dirty_level_mask of depth buffers and fall back if it's non-zero.
Basically, dirty_level_mask always tells you whether CMASK or HTILE is
in use and which mipmap levels are affected.
Thanks for your review and suggestions. I hope v3 matches what you're
thinking of.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
