Re: [Mesa-dev] [PATCH 2/2] r600: Turn 'r600_shader_key' struct into union

2015-08-20 Thread Emil Velikov
Hi Edward, On 19 August 2015 at 09:58, Edward O'Callaghan wrote: > From: Edward O'Callaghan > > This struct was getting a bit crowded, following the lead of > radeonsi, mirror the idea of having sub-structures for each > shader type. Turning 'r600_shader_key' into an union saves > some trivial m

Re: [Mesa-dev] [PATCH 2/2] r600: Turn 'r600_shader_key' struct into union

2015-08-19 Thread Dave Airlie
On 19 August 2015 at 18:58, Edward O'Callaghan wrote: > From: Edward O'Callaghan > > This struct was getting a bit crowded, following the lead of > radeonsi, mirror the idea of having sub-structures for each > shader type. Turning 'r600_shader_key' into an union saves > some trivial memory and CP

Re: [Mesa-dev] [PATCH 2/2] r600: Turn 'r600_shader_key' struct into union

2015-08-19 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Wed, Aug 19, 2015 at 10:58 AM, Edward O'Callaghan wrote: > From: Edward O'Callaghan > > This struct was getting a bit crowded, following the lead of > radeonsi, mirror the idea of having sub-structures for each > shader type. Turning 'r600_sha