Re: [Mesa-dev] [PATCH 00/10] [RFC] Probably useless algebraic optimizations

2014-08-06 Thread Thomas Helland
2014-08-04 21:25 GMT+02:00 Eric Anholt : > thomashellan...@gmail.com writes: > >> From: Thomas Helland >> >> When writing that A || (A && B) patch some >> days ago I also wrote some other patches >> that have no impact on my collection of shaders. >> (shader-db + Some TF2 and Portal-shaders). >> N

Re: [Mesa-dev] [PATCH 00/10] [RFC] Probably useless algebraic optimizations

2014-08-04 Thread Eric Anholt
thomashellan...@gmail.com writes: > From: Thomas Helland > > When writing that A || (A && B) patch some > days ago I also wrote some other patches > that have no impact on my collection of shaders. > (shader-db + Some TF2 and Portal-shaders). > No reduction in instruction count, and no > signific

Re: [Mesa-dev] [PATCH 00/10] [RFC] Probably useless algebraic optimizations

2014-07-16 Thread Brian Paul
Some of these optimizations are pretty obscure and I can't imagine a real shader hitting them. What's the cost of checking for these cases? I don't know how expensive the equals() methods are. Do we want to litter the optimizer with cases that may never be used in practice? -Brian On 07

Re: [Mesa-dev] [PATCH 00/10] [RFC] Probably useless algebraic optimizations

2014-07-15 Thread Thomas Helland
So, a little update on these patches. I've written some shaders for hitting each specific case in the patch-series. This shows that: Patch 1 (X - X) == 0,and Patch 9 (A - neg(B)) == A + B have no effect at all. The rest of the patches do indeed have a positive effect on the special-case shade