Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants and #define to enum.

2017-04-13 13:45 GMT+08:00 Matthew Mondazzi : > More relevant ISA constants put in place of chipset compares. This helps > better display which features are available to card than previous chipset > compares, making future development easier continue with. > > Signed-off-by: Matthew Mondazzi > -

Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants and #define to enum.

On Thu, Apr 13, 2017 at 1:45 AM, Matthew Mondazzi wrote: > More relevant ISA constants put in place of chipset compares. This helps > better display which features are available to card than previous chipset > compares, making future development easier continue with. > > Signed-off-by: Matthew M

Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants.

I would agree with Ilia on making it an enum (maybe even an enum class?), rather than a define. If keeping it as a define, maybe we should also change the value while at it, and have NVISA_SM30 equal 0x1d or 0x30 (or by numbering from 0 and on), rather than keeping it linked to a chipset. Pierre

Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants.

Karol told me that over IRC. Introducing ->getIsa() looks good to me. On 04/11/2017 01:01 AM, Ilia Mirkin wrote: I wanted to flip things over and use smxx notation... On Apr 10, 2017 6:20 PM, "Samuel Pitoiset" > wrote: Not sure why you get confused here.

Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants.

I wanted to flip things over and use smxx notation... On Apr 10, 2017 6:20 PM, "Samuel Pitoiset" wrote: > Not sure why you get confused here. The chipset names are globally > consistent inside the codegen part and we never use SMxx. Maybe add a > comment like: > > #define NVISA_GK104_CHIPSET

Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants.

Not sure why you get confused here. The chipset names are globally consistent inside the codegen part and we never use SMxx. Maybe add a comment like: #define NVISA_GK104_CHIPSET0xe0 /* SM30 */ If you really need this? On 04/10/2017 11:41 PM, Matthew Mondazzi wrote: Define references to