Re: [Mesa-dev] About merging pipe-video to master

2011-07-12 Thread Henri Verbeet
2011/7/12 Christian König : > Am Dienstag, den 12.07.2011, 15:44 +0200 schrieb Henri Verbeet: >> 2011/7/12 Christian König : >> > +           // TODO get BLEND_CLAMP state from rasterizer state >> Is this comment still accurate? > Yes it is, the very first generation of R600 chipsets need to know i

Re: [Mesa-dev] About merging pipe-video to master

2011-07-12 Thread Christian König
Am Dienstag, den 12.07.2011, 15:44 +0200 schrieb Henri Verbeet: > 2011/7/12 Christian König : > > it works with my available hardware (no piglit regressions). The changes > > to the winsys code is about making a bo optional, even when the reg > > informations says it isn't. This is useful for regis

Re: [Mesa-dev] About merging pipe-video to master

2011-07-12 Thread Jose Fonseca
- Original Message - > Hi guys, > > as the subject already indicates: I'm about to merge pipe-video to > master and just wanted to ask if anybody has still any objections? > > After following Jose and Younes discussion on mesa-dev about how to > design such an abstraction layer I took a

Re: [Mesa-dev] About merging pipe-video to master

2011-07-12 Thread Keith Whitwell
On Tue, 2011-07-12 at 11:13 -0400, Younes Manton wrote: > 2011/7/12 Keith Whitwell : > > I'm a bit unsure about what's the best approach here, though at this > > stage I'm happy with your approach and don't think it needs to be > > changed before any merge. > > > > But speaking in general terms, in

Re: [Mesa-dev] About merging pipe-video to master

2011-07-12 Thread Younes Manton
2011/7/12 Keith Whitwell : > I'm a bit unsure about what's the best approach here, though at this > stage I'm happy with your approach and don't think it needs to be > changed before any merge. > > But speaking in general terms, individual planes map well onto 8-bit > single-component texture image

Re: [Mesa-dev] About merging pipe-video to master

2011-07-12 Thread Henri Verbeet
2011/7/12 Christian König : > it works with my available hardware (no piglit regressions). The changes > to the winsys code is about making a bo optional, even when the reg > informations says it isn't. This is useful for registers where only a > subset of the bits needs to be informed about a bo r

Re: [Mesa-dev] About merging pipe-video to master

2011-07-12 Thread Christian König
Am Dienstag, den 12.07.2011, 13:06 +0200 schrieb Henri Verbeet: > 2011/7/11 Christian König : > > So what do you guys think about it? > > > I didn't look much at the rest of the changes, but some of the changes > for r600g (diff attached) look a bit questionable. Could you take a > look at those to

Re: [Mesa-dev] About merging pipe-video to master

2011-07-12 Thread Christian König
Hi, > >as the subject already indicates: I'm about to merge pipe-video to > >master and just wanted to ask if anybody has still any objections? > > > > Yes [I am a watchman of compile/build errors (I know I am an old bitcher but > code quality rules)]: > > https://build.opensuse.org/package/raw

Re: [Mesa-dev] About merging pipe-video to master

2011-07-12 Thread Henri Verbeet
2011/7/11 Christian König : > So what do you guys think about it? > I didn't look much at the rest of the changes, but some of the changes for r600g (diff attached) look a bit questionable. Could you take a look at those to see if they're really all intentional and correct before merging? r600g.d

Re: [Mesa-dev] About merging pipe-video to master

2011-07-12 Thread Keith Whitwell
On Mon, 2011-07-11 at 18:24 +0200, Christian König wrote: > Hi guys, > > as the subject already indicates: I'm about to merge pipe-video to > master and just wanted to ask if anybody has still any objections? > > After following Jose and Younes discussion on mesa-dev about how to > design such an

Re: [Mesa-dev] About merging pipe-video to master

2011-07-11 Thread Johannes Obermayr
Christian König schrieb: >Hi guys, > >as the subject already indicates: I'm about to merge pipe-video to >master and just wanted to ask if anybody has still any objections? > Yes [I am a watchman of compile/build errors (I know I am an old bitcher but code quality rules)]: https://build.opensuse

[Mesa-dev] About merging pipe-video to master

2011-07-11 Thread Christian König
Hi guys, as the subject already indicates: I'm about to merge pipe-video to master and just wanted to ask if anybody has still any objections? After following Jose and Younes discussion on mesa-dev about how to design such an abstraction layer I took another round of cleaning up the interface and