Re: [Mesa-dev] [PATCHv2 08/14] i965: Define and initialize image parameter structure.

2015-08-07 Thread Jason Ekstrand
Thanks for adding the comments. Reviewed-by: Jason Ekstrand On Thu, Aug 6, 2015 at 7:19 AM, Francisco Jerez wrote: > Francisco Jerez writes: > >> "Pohjolainen, Topi" writes: >> >>> On Wed, Aug 05, 2015 at 12:11:02PM +0300, Pohjolainen, Topi wrote: On Mon, Jul 20, 2015 at 07:17:48PM +0300

Re: [Mesa-dev] [PATCHv2 08/14] i965: Define and initialize image parameter structure.

2015-08-06 Thread Francisco Jerez
Francisco Jerez writes: > "Pohjolainen, Topi" writes: > >> On Wed, Aug 05, 2015 at 12:11:02PM +0300, Pohjolainen, Topi wrote: >>> On Mon, Jul 20, 2015 at 07:17:48PM +0300, Francisco Jerez wrote: >>> > This will be used to pass image meta-data to the shader when we cannot >>> > use typed surface

Re: [Mesa-dev] [PATCHv2 08/14] i965: Define and initialize image parameter structure.

2015-08-06 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Wed, Aug 05, 2015 at 12:11:02PM +0300, Pohjolainen, Topi wrote: >> On Mon, Jul 20, 2015 at 07:17:48PM +0300, Francisco Jerez wrote: >> > This will be used to pass image meta-data to the shader when we cannot >> > use typed surface reads and writes. All entries ex

Re: [Mesa-dev] [PATCHv2 08/14] i965: Define and initialize image parameter structure.

2015-08-06 Thread Pohjolainen, Topi
On Wed, Aug 05, 2015 at 12:11:02PM +0300, Pohjolainen, Topi wrote: > On Mon, Jul 20, 2015 at 07:17:48PM +0300, Francisco Jerez wrote: > > This will be used to pass image meta-data to the shader when we cannot > > use typed surface reads and writes. All entries except surface_idx > > and size are o

Re: [Mesa-dev] [PATCHv2 08/14] i965: Define and initialize image parameter structure.

2015-08-06 Thread Pohjolainen, Topi
On Wed, Aug 05, 2015 at 12:51:19PM +0300, Pohjolainen, Topi wrote: > On Mon, Jul 20, 2015 at 07:17:48PM +0300, Francisco Jerez wrote: > > This will be used to pass image meta-data to the shader when we cannot > > use typed surface reads and writes. All entries except surface_idx > > and size are o

Re: [Mesa-dev] [PATCHv2 08/14] i965: Define and initialize image parameter structure.

2015-08-05 Thread Pohjolainen, Topi
On Mon, Jul 20, 2015 at 07:17:48PM +0300, Francisco Jerez wrote: > This will be used to pass image meta-data to the shader when we cannot > use typed surface reads and writes. All entries except surface_idx > and size are otherwise unused and will get eliminated by the uniform > packing pass. siz

Re: [Mesa-dev] [PATCHv2 08/14] i965: Define and initialize image parameter structure.

2015-08-05 Thread Pohjolainen, Topi
On Wed, Aug 05, 2015 at 12:11:02PM +0300, Pohjolainen, Topi wrote: > On Mon, Jul 20, 2015 at 07:17:48PM +0300, Francisco Jerez wrote: > > This will be used to pass image meta-data to the shader when we cannot > > use typed surface reads and writes. All entries except surface_idx > > and size are o

Re: [Mesa-dev] [PATCHv2 08/14] i965: Define and initialize image parameter structure.

2015-08-05 Thread Pohjolainen, Topi
On Mon, Jul 20, 2015 at 07:17:48PM +0300, Francisco Jerez wrote: > This will be used to pass image meta-data to the shader when we cannot > use typed surface reads and writes. All entries except surface_idx > and size are otherwise unused and will get eliminated by the uniform > packing pass. siz

[Mesa-dev] [PATCHv2 08/14] i965: Define and initialize image parameter structure.

2015-07-20 Thread Francisco Jerez
This will be used to pass image meta-data to the shader when we cannot use typed surface reads and writes. All entries except surface_idx and size are otherwise unused and will get eliminated by the uniform packing pass. size will be used for bounds checking with some image formats and will be us