Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-17 Thread Ian Romanick
On 05/17/2012 03:43 PM, Paul Berry wrote: On 17 May 2012 11:21, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 05/14/2012 06:24 PM, Paul Berry wrote: On 14 May 2012 16:50, Ian Romanick mailto:i...@freedesktop.org>

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-17 Thread Paul Berry
On 17 May 2012 11:21, Ian Romanick wrote: > On 05/14/2012 06:24 PM, Paul Berry wrote: > >> On 14 May 2012 16:50, Ian Romanick > > wrote: >> >>On 05/14/2012 02:13 PM, Paul Berry wrote: >> >>Just to update the list: I had an in-person meeting with Eric, >>

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-17 Thread Ian Romanick
On 05/14/2012 06:24 PM, Paul Berry wrote: On 14 May 2012 16:50, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 05/14/2012 02:13 PM, Paul Berry wrote: Just to update the list: I had an in-person meeting with Eric, Ian, and Ken today to discuss the design of the

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-15 Thread Kenneth Graunke
On 05/14/2012 06:24 PM, Paul Berry wrote: [snip] I'm not going to try to change your mind, but in the spirit of clarifying the method that was behind my madness: I did not have the clarity of mind during our discussion today to point out that in creating the brw_blorp_params class, I was in fact

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-14 Thread Paul Berry
On 14 May 2012 16:50, Ian Romanick wrote: > On 05/14/2012 02:13 PM, Paul Berry wrote: > >> Just to update the list: I had an in-person meeting with Eric, Ian, and >> Ken today to discuss the design of the patch series and decide what to >> do about it. We agreed to go ahead and push the patches

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-14 Thread Ian Romanick
On 05/14/2012 02:13 PM, Paul Berry wrote: Just to update the list: I had an in-person meeting with Eric, Ian, and Ken today to discuss the design of the patch series and decide what to do about it. We agreed to go ahead and push the patches to master as is, and to make further improvements as ti

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-14 Thread Paul Berry
Just to update the list: I had an in-person meeting with Eric, Ian, and Ken today to discuss the design of the patch series and decide what to do about it. We agreed to go ahead and push the patches to master as is, and to make further improvements as time goes on. Specific improvements that were

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-11 Thread Kenneth Graunke
No. Please don't push code until people have reviewed it (and more than just one person). A small schedule slip is reasonable, and if people do have concerns/requests, cleaning it up afterwards may just result in more churn and effort. ___ mesa-dev

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-11 Thread Chad Versace
On 05/11/2012 01:37 PM, Paul Berry wrote: > On 11 May 2012 12:40, Chad Versace > wrote: > > On 05/10/2012 11:21 AM, Paul Berry wrote: > > This patch enables MSAA for Gen6, by modifying intel_mipmap_tree to > > understand multisampled buffers, adapt

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-11 Thread Paul Berry
On 11 May 2012 12:40, Chad Versace wrote: > On 05/10/2012 11:21 AM, Paul Berry wrote: > > This patch enables MSAA for Gen6, by modifying intel_mipmap_tree to > > understand multisampled buffers, adapting the rendering pipeline setup > > to enable multisampled rendering, and adding multisample res

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-11 Thread Chad Versace
On 05/10/2012 11:21 AM, Paul Berry wrote: > This patch enables MSAA for Gen6, by modifying intel_mipmap_tree to > understand multisampled buffers, adapting the rendering pipeline setup > to enable multisampled rendering, and adding multisample resolve > operations to brw_blorp_blit.cpp. Some prepar